summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-03-12Revert "loplugin:constfields in sc"Noel Grandin
This reverts commit fb1d3b580763a333bbbfe115d09e1b5cd8849675. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: Ib48334ffbeb2c768896dd8ced6818aa0b9910b0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90333 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Revert "loplugin:constfields in oox"Noel Grandin
This reverts commit a84e3df74eecc8778e3d5be5dd80ad4ddb511edf. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: I7b45b7ead281cf3a9202ca6aabc55ee5033e5331 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90332 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-11Blind fix for Android Tinderbox buildMichael Weghorn
... which failed as follows, which looks related to commit 6d9a31a58c2b55c0caef10c8bbb3d75147c2476f ("android: Use the best speed compression as on iOS"), s. [1] for full log: 12883 [build CXX] vcl/source/pdf/XmpMetadata.cxx 12884 In file included from /home/android/lo/master-android-arm/vcl/source/filter/graphicfilter.cxx:24: 12885 In file included from /home/android/lo/master-android-arm/include/comphelper/processfactory.hxx:23: 12886 In file included from /home/android/lo/master-android-arm/include/com/sun/star/uno/Reference.hxx:28: 12887 In file included from /home/android/lo/master-android-arm/workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/uno/RuntimeException.hpp:8: 12888 In file included from /home/android/lo/master-android-arm/workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/uno/Exception.hpp:8: 12889 In file included from /home/android/lo/master-android-arm/workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/uno/XInterface.hpp:6: 12890 In file included from /home/android/lo/master-android-arm/workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/uno/XInterface.hdl:6: 12891 In file included from /home/android/lo/master-android-arm/include/com/sun/star/uno/Any.h:29: 12892 NEXT /home/android/lo/master-android-arm/include/cppu/unotype.hxx:296:16: error: no matching function for call to ´cppu_detail_getUnoType´ 12893 return cppu_detail_getUnoType(static_cast< T1 * >(0)); 12894 ^~~~~~~~~~~~~~~~~~~~~~ 12895 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:321:34: note: in instantiation of member function ´cppu::UnoType<int>::get´ requested here 12896 return ::cppu::UnoType< T >::get(); 12897 ^ 12898 /home/android/lo/master-android-arm/include/com/sun/star/uno/Any.hxx:276:34: note: in instantiation of function template specialization ´cppu::getTypeFavourUnsigned<int>´ requested here 12899 const Type & rType = ::cppu::getTypeFavourUnsigned(&value); 12900 ^ 12901 /home/android/lo/master-android-arm/vcl/source/filter/graphicfilter.cxx:2216:60: note: in instantiation of function template specialization ´com::sun::star::uno::operator<<=<int>´ requested here 12902 aFilterData[aFilterData.getLength() - 1].Value <<= 1; 12903 ^ 12904 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:120:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::cppu::UnoVoidType *´ for 1st argument 12905 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::cppu::UnoVoidType const *) { 12906 ^ 12907 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:125:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const bool *´ for 1st argument 12908 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER bool const *) { 12909 ^ 12910 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:130:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const sal_Bool *´ (aka ´const unsigned char *´) for 1st argument 12911 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER sal_Bool const *) { 12912 ^ 12913 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:135:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::sal_Int8 *´ (aka ´const signed char *´) for 1st argument 12914 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::sal_Int8 const *) { 12915 ^ 12916 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:140:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::sal_Int16 *´ (aka ´const short *´) for 1st argument 12917 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::sal_Int16 const *) { 12918 ^ 12919 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:145:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::cppu::UnoUnsignedShortType *´ for 1st argument 12920 cppu_detail_getUnoType( 12921 ^ 12922 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:155:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const sal_uInt16 *´ (aka ´const unsigned short *´) for 1st argument 12923 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER sal_uInt16 const *) { 12924 ^ 12925 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:161:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::sal_Int32 *´ (aka ´const long *´) for 1st argument 12926 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::sal_Int32 const *) { 12927 ^ 12928 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:166:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::sal_uInt32 *´ (aka ´const unsigned long *´) for 1st argument 12929 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::sal_uInt32 const *) { 12930 ^ 12931 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:172:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::sal_Int64 *´ (aka ´const long long *´) for 1st argument 12932 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::sal_Int64 const *) { 12933 ^ 12934 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:177:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::sal_uInt64 *´ (aka ´const unsigned long long *´) for 1st argument 12935 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::sal_uInt64 const *) { 12936 ^ 12937 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:183:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const float *´ for 1st argument 12938 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER float const *) { 12939 ^ 12940 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:188:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const double *´ for 1st argument 12941 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER double const *) { 12942 ^ 12943 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:193:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::cppu::UnoCharType *´ for 1st argument 12944 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::cppu::UnoCharType const *) { 12945 ^ 12946 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:200:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const sal_Unicode *´ (aka ´const char16_t *´) for 1st argument 12947 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER sal_Unicode const *) { 12948 ^ 12949 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:206:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::rtl::OUString *´ for 1st argument 12950 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::rtl::OUString const *) { 12951 ^ 12952 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:211:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const css::uno::Type *´ for 1st argument 12953 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER css::uno::Type const *) 12954 ^ 12955 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:217:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const css::uno::Any *´ for 1st argument 12956 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER css::uno::Any const *) 12957 ^ 12958 NEXT /home/android/lo/master-android-arm/include/cppu/unotype.hxx:243:31: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const css::uno::Exception *´ for 1st argument 12959 inline css::uno::Type const & cppu_detail_getUnoType( 12960 ^ 12961 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:249:31: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const css::uno::XInterface *´ for 1st argument 12962 inline css::uno::Type const & cppu_detail_getUnoType( 12963 ^ 12964 NEXT /home/android/lo/master-android-arm/include/cppu/unotype.hxx:223:1: note: candidate template ignored: could not match ´UnoSequenceType<type-parameter-0-0>´ against ´int´ 12965 cppu_detail_getUnoType( 12966 ^ 12967 NEXT /home/android/lo/master-android-arm/include/cppu/unotype.hxx:236:1: note: candidate template ignored: could not match ´Sequence<type-parameter-0-0>´ against ´int´ 12968 cppu_detail_getUnoType( 12969 ^ 12970 NEXT /home/android/lo/master-android-arm/include/cppu/unotype.hxx:256:1: note: candidate template ignored: could not match ´Reference<type-parameter-0-0>´ against ´int´ 12971 cppu_detail_getUnoType( 12972 ^ 12973 NEXT 1 error generated. 12974 [build CXX] vcl/source/uitest/logger.cxx [1] https://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&full-log=1583961601.24939 Change-Id: I098c21bc492f734115ae0e91f095ef542851c2ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90352 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-11tdf#89849 editeng: adjust escapement before resetting ProprJustin Luth
THIS IS A LAYOUT REGRESSION FIX FOR SUBSCRIPTS/SUPERSCRIPTS. The position of subscripts and superscripts is a percentage based on the 100% fontsize. When LO 4.1 tricked the font into thinking it was 100%, it failed to adjust the escapement to be relative to the new fake size. In the default case, this meant that the superscript was only raised about half as much as it should have. THIS CHANGE WILL AFFECT EXISTING DOCUMENTS WHERE THE TEXTBOX IS SET TO "AUTOFIT THE TEXT". This will primarily be Impress documents, since many of the templates enable autofit text. As a result of this bug, users creating new documents since 4.1 using autofit-text will have specified highly exaggerated subscript/superscript positioning in order to look nice. This fix will expose the exaggerated percentages and make the document look poor. I don't know how that can be avoided. Nor do I know how to create a unit test for a layout bug. I guess QA's PDF compare tests will suffice for this. A clearly exaggerated unit test is attached to the bug report. The new ability to have a larger-than-100% escapement in LO 6.3 comes in handy here, so that small superscripts can gain a fake escapment big enough to put them in the proper position. Change-Id: I0f8dcff8741eb05d8657235930a4eb684629b9d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89214 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-03-11android: Fix asset handling in build.gradleMichael Weghorn
... after commit 367431b6987b75e7a201499bfbd25a41c92a4a59 ("tdf#126909 android: include icons into APK") had accidently not only added the icon zip file to the 'assets/share/config' folder, but also caused the assets mentioned below in build.gradle to be copied there instead of the proper places, leading to a crash when trying to access them. (The problem did not show up in an incremental build, since "the old copies" of the assets were still present where expected.) Change-Id: I7d9cf89c399d6415ce97ac8af4a98610555c5f17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90344 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-11Sukapura: Add shadow to icons, add many more icons:rizmut
- QR code, Apply Style, Zoom 200% - Delete wrong placed SVG icons in PNG dir - Update Index Entry, Show Formatting, Toggle Extrusion, DB Sorting & Grouping - Update/add slide related icons - etc Change-Id: I29a05e1b39cee5972299f21d083021cb1ef54b62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90342 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-03-11m_sHelpRoot in weld::Builder is unusedNoel Grandin
since commit 082e69fefb7439fd4f3d543f0c402039e94c1e9c convert various MessBox to weld::MessageDialog - Change-Id: I08370632803c26ac9c47267e57c51eb56ad713f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-11tdf#114441: Convert use of sal_uLong to better integer typesBugra
Change-Id: I6b6f59a73aeda6af78fecaf4344826a943072033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90191 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-11tdf#114441 Convert use of sal_uLong to sal_uInt32AlanTang
Change-Id: Ia359a33e7cbc25764861b17372df9d1c9dbc0913 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89942 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-11Add some fallback minimum size when screen size detection goes wrongSamuel Mehrbrodt
Change-Id: I97ec2359b8ae406e310a5d043ac068ddd89b3fd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90320 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-11update creditsChristian Lohmaier
Change-Id: I90fba19d96f0fce6ca0e63c83e6dd45087f81c0a
2020-03-11android: Use the best speed compression as on iOS.Jan Holesovsky
Change-Id: Ib2be570a924c6ac6e226f47e6b183975df1fca2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90258 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 07fb148971b6853c2020cea6660fa62d6caacb85) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90281 Tested-by: Jenkins
2020-03-11Window::Update means to call Paint immediatelyCaolán McNamara
rather than wait until the next event loop. This is causing the scrollbar to be painted at pos 0 and then appears to flicker when it is repainted at its final position when the gen navigator treeview is cleared and refilled. call Invalidate instead to schedule in the painting of the scrollbars at the usual time. Update is used since initial commit so its unknown as to the reason why. If SetUpdateMode(true) is in use it won't happen so the flicker normally doesn't happen, but the equivalent we're using for the native gtk widgerty disconnects the model when frozen for performance, so setting cursor positions and other similar operations have to happen unfrozen. Not calling Update here would make things much easier. Change-Id: I4575e55802c54e5b849f076f2da79dd010fb27e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-11tdf#114441: Convert use of sal_uLong to better integer typesBugra
Change-Id: I5065899525e57c48eb43023b7a22db46e8e5bedc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89961 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-11tdf#124424 Enhanced SvgGradientHelper for EMF+Armin Le Grand
Added support for repeat modes in GDI+ support and saw that the SVG primitive gradient helpers are not capable to support these completely, so had to do some quite complex adaptions which OTOH will be useful for more complex gradients anyways Change-Id: Ib9a9e4a55115834a4fb00300b05abe17ae36d105 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90329 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-03-11tdf#126909 android: include icons into APKMichael Weghorn
While default build config for Android Viewer caused the zip file(s) containing the icons to be built (e.g. 'distro-configs/LibreOfficeAndroid.conf' contains '--with-theme=colibre'), icons were not included in the APK. Do so now, which among others also makes page breaks shown in Android Viewer (as requested in tdf#126909). Change-Id: Ie16ff4b483287367b9f892ee614b3e5aa4d31820 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90330 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-11Convert filter token generator from Perl to Python.Jussi Pakkanen
See tdf#130911 for motivation. Change-Id: Iad0960d5e6298236dea57e37930dfad1f13628c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90127 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-11tdf#39674 Translate German variable namesJohnny_M
Titel -> Title Thema -> Subject In "strings.hrc", translated the defines, but kept the their NC_(...) translation references to prevent a need to update translations. Change-Id: Ie8b4a94376495d5e148bc50dcc9902e805deff0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90156 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-11mysterious greyed out native toggle buttons when in foregroundCaolán McNamara
and flipping to normal mode when in background. Change-Id: I100efb651515b044d56a8c3838569cf717b37d51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90328 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-11tdf#42949 Fix IWYU warnings in extensions/*/*cxxGabor Kelemen
Except for Windows-specific parts Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I36c81bced6c8b1567e52ba3a4a688a963f294bb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90179 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-11Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' to 2184ece0e3d6a76dc8cb8ad58bdb0b86f0f70294 - Addition to Basic reference TOC Change-Id: Icaea025c635127f5503270e071fab83f2760c480 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90278 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-03-11tdf#125440 Allow raising text import dialog for pasteSamuel Mehrbrodt
This adds an entry to the "Paste special" dialog to raise the Text Import Dialog. This way, users can correctly import CSV/TSV, even when pasting just one line of formatted input. Change-Id: Ic09d7d60a05b14906f166668b38ec0eb8ead2d19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89886 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-11tdf#125440 When inserting TSV, consider quotes as field markersSamuel Mehrbrodt
The problem is that this is "plain text" from the clipboard format, but actually contains TSV (tab separated values). So treat them accordingly, so that each value gets its own cell. Change-Id: I0029e6ace90fc542c3269dd82bb7531654157a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87194 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-11tdf#131265: Fix 'update' icon in 3D Effects dialog meaningJulien Nabet
The effect was reversed Change-Id: I611d12eec88ba213d952df541cec89c0664471cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90313 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-11tdf#131261: fix Cannot set "Flat" shading mode in 3D Effects dialogJulien Nabet
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=278f01eadd513608e306ea6b85d52fb115a6dedf author Caolán McNamara <caolanm@redhat.com> 2020-01-23 15:28:08 +0000 committer Caolán McNamara <caolanm@redhat.com> 2020-01-24 15:59:50 +0100 commit 278f01eadd513608e306ea6b85d52fb115a6dedf (patch) tree dc4e9a62dc3753353fd1202a28f84d1599cf3996 parent d52384260c4a8f096945b33b89430398ffa69431 (diff) weld Svx3DWin Change-Id: I7d7d5cb0f40da310103a1c281b381818948257f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90311 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-11scroll treeview correctlyCaolán McNamara
Change-Id: Ie769b0e4ba984b95378c4e7c418c7e4ba0d7acb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90307 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-11tdf#131260: Add unittestXisco Fauli
Change-Id: Ic8d049c7b4a9005473c91cdb6200ae24b14e1a58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90306 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-11Get rid of some SAL_MATH_FINITE useStephan Bergmann
Change-Id: I850efb6215c95d356d42e19e639c578c377d1507 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90316 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-11sfx2: fix UB in SfxBindings::LeaveRegistrations()Miklos Vajna
Seen during online.git's unit-wopi-temp test: sfx2/source/control/bindings.cxx:1374:45: runtime error: member call on null pointer of type 'SfxApplication' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior sfx2/source/control/bindings.cxx:1374:45 in Assume that no longer having a SfxApplication is the same as IsDowning() returning true. Change-Id: I31149e98d18202e99d95638470428b2bce16dfc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90304 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-11tdf#126742 Don't change visible area while retrieving itSamuel Mehrbrodt
This leads to funny size changes in embedded calc docs Change-Id: I2c4a0fbebb782faae7508e7d61c8da9d440a5916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90247 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-11Fix typoAndrea Gelmini
Change-Id: I0eaddcdcd41327a40559ec943d5c744b7e4c5387 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90310 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-11tdf#59274 DOCX import: fix tables with incomplete gridLászló Németh
Fix layout of "auto" width tables with incomplete grids, where table width is defined by cells of an arbitrary table row, not necessarily the first row, and last cells of the rows can be wider, than their saved values. Change-Id: I68bc8f1a4f57f3c64d0e83c585f2be129d9b5a84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90261 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-11Revert "Revert "add some libs to libmerged""Noel Grandin
This reverts commit b8077713987253f6db0887ddad56fd6871374a8b. Reason for revert: Change-Id: I09b7d548a674fc8b2991be00616a7e95ec7d1444 sberg:You can probably reverts this again, as <https://ci.libreoffice.org/job/lo_daily_tb_win/162/> now succeeded with <https://gerrit.libreoffice.org/plugins/gitiles/core/+/9ed75e2c65544b4f71c73e1c51a68d74e31d544b%5E!/> "Properly use createOneInstanceComponentFactory for javaloader". Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-11Sukapura: add shadow to icons, etcrizmut
Change-Id: I54b5204e36857f0f0f7c39514155202a9c9ac3de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90314 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-03-11WIN add bootstrap var to re-enable foreground hackJan-Marek Glogowski
We already found a regressed installation from commit 518c0265efebf39ab6d1e90c4ec4e7cf52b701c6 ("WIN prevent deadlock in SetForegroundWindow"). Finding a real fix might be impossible, so this just adds the bootstrap.ini boolean variable Win32.EnableAttachThreadInputHack to re-enable the previous AttachThreadInput hack on demand. Change-Id: I3b6d770b060b5dee60e02a5aa85efb8a51518c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90235 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-11fldbas.cxx: SwIterator no more ...Bjoern Michaelsen
Change-Id: I83a8ab6d8d9f6b0143a51176fed4fa8f2f682cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90312 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-10DocumentStatisticsManager: SwIterator no more ...Bjoern Michaelsen
Change-Id: I179db8fe1762a4931a4752c9c865f8c1e1b4fc4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90309 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-10DocumentFieldsManager::UpdateTableFields(): SwIterator no more ...Bjoern Michaelsen
Change-Id: I9c04e15ae05b8b6e98d79cddd87dff55ebbf1f1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90308 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-10Enable CppunitTest_sc_uicalc also for MACOSXStephan Bergmann
there appears to be no reason not to Change-Id: Ic7c0e34e28bc67bd7b342b50f893990057b2e261 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90305 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-10SwEditShell::IsAnyDatabaseFieldInDoc(): SwIterator no more ...Bjoern Michaelsen
Change-Id: I58f3d546981ad80f8eeabab6b023c4a985f7aecb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90173 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-10SwTOXBaseSection::UpdateAuthorities(): SwIerator no more ...Bjoern Michaelsen
Change-Id: I51d7bbe527a722ddd8a603afe15e75ad4b8c737a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90167 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-10Fix typoAndrea Gelmini
Change-Id: Id3fe1d66cb1d3cb57f8aa5e652bf1c9ad6346091 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90286 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-10Fix typoAndrea Gelmini
Change-Id: I81f5b545641e21a602f3858815c5a3b9ca0c8e8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90287 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-10Fix typoAndrea Gelmini
Change-Id: I7742e947c4657bed5484b939f4a0972155081ff1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90288 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-10Fix typoAndrea Gelmini
Change-Id: I0e41ac95532b8d1782c4a5148a2b70b1d8a13b16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90289 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-10tdf#61274 sd PDF export: fix links ending up on wrong pages with hidden slidesMiklos Vajna
SdPage::IsExcluded() decides if a slide is hidden, SdXImpressDocument::render() checks for this and returns early if needed. In that case PDFExport::ExportSelection() detects that the produced metafile has no actions and avoids creating a PDF page. Then Impress links are created using the vcl::PDFExtOutDevData::CreateLink() call in drawinglayer::processor2d::VclMetafileProcessor2D::processTextHierarchyFieldPrimitive2D(), not specifying the PDF page number explicitly. This means the link is created on the "current" page number, set in vcl::PDFExtOutDevData::SetCurrentPageNumber(), called by PDFExport::ExportSelection(), but that filter/ code can't know about hidden slides in sd/. Fix the problem by setting the page number again in SdXImpressDocument::render(), that way the link created by drawinglayer will end on the correct page. Change-Id: Ic29e345d45bc7c944d65e6e450f1d742dd0e9f8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90299 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-10Deref of DynTypedNode* must not outlive owning DynTypedNodeListStephan Bergmann
Change-Id: I8ac4a2f1e442446384b88f38bdef21644409f8a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90303 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-10tdf#131088 Automatic Control Focus not workingNoel Grandin
regression from commit a361231b1363d072d737e9b1d411b71aa9550d84 Date: Fri May 10 10:13:12 2019 +0200 fix wrong SET/QUERY flags passed to uno::Reference Change-Id: Id0dd46c3d40f8acab980147c4c7f64911bc30d22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90293 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-10tdf#125520 create a persist correctly for OLEArmin Le Grand
If the D&D-Start described as in the task is an OLE object we need to create a Persist-object to copy the included EmbeddedObjectContainer Change-Id: Ib8b9677bbc3e6c5b3895abc55e6da5b0a96e33d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90263 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-03-10tdf#124815: move UItest to CppunitTestXisco Fauli
Change-Id: If6482bf6666f00c3c613315cd18d188239ea61f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90265 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-03-22 10:42:06 +0000