summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-07-23followup b714ba73c - remove excessive bracesChris Sherlock
Change-Id: I59fe131c6d14d9058fedaf89a2e9d5ceca444aa5
2017-07-22osl: (Win32) check allocated pipe succeeded, otherwise needs to failChris Sherlock
Change-Id: I0e508de4215d92700a9134e422a7b9370f387aea Reviewed-on: https://gerrit.libreoffice.org/40300 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-07-22tdf#109271: Use ScopedVclPtrJulien Nabet
so disposeAndClear is called See https://bug-attachments.documentfoundation.org/attachment.cgi?id=134781 Change-Id: I5d9a3c4ddc73b303a36643a7d1111d8cc7da7006 Reviewed-on: https://gerrit.libreoffice.org/40306 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22rtl: fix bootstrap formatting, comparison to nullptrChris Sherlock
Change-Id: I8d00e616a56cc3edac6ba2149fd6f9ae44c23a95
2017-07-22rtl: remove comparisons against nullptr from RTL mem filesChris Sherlock
Change-Id: Ic0ae0378d5b46b3d11c99aef2e845796ad0a9c71
2017-07-22rtl: remove comment cruft from alloc filesChris Sherlock
Change-Id: Ibac120af6879739091aacefef5c773649e222f85
2017-07-22Cleanup duplicate functions in cfg.cxxMuhammet Kara
And move all helper functions to the temporary namespace killmelater Change-Id: If74102209a05b8d28c96d51a623ac14c1700630c Reviewed-on: https://gerrit.libreoffice.org/39404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-on: https://gerrit.libreoffice.org/40302 Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-07-22Typo: "disposeAndClear", not "clearAndDispose"Julien Nabet
Change-Id: I9f7f30fce9324f7ccb79e9a8ef0c13e091d7c3a3 Reviewed-on: https://gerrit.libreoffice.org/40304 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22loplugin:unusedfields in basctl..connectivityNoel Grandin
Change-Id: I2f10daadb84e48eaf96f6cc63899b2f4fce7326e Reviewed-on: https://gerrit.libreoffice.org/40295 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22loplugin:unusedfields in cppcanvas..cuiNoel Grandin
Change-Id: I1cf1f7919e03d863c6f7756e1caf3b9313777479 Reviewed-on: https://gerrit.libreoffice.org/40294 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22add test for CJK (~X) mnemonicsCaolán McNamara
Change-Id: I1f69c23dcde6d963ad9c3bc1f2d9178fe15eb27c
2017-07-22tweak test a littleCaolán McNamara
Change-Id: I6b9aeaf03716496dc2c6dfcc88688891f57fb0c7
2017-07-22osl: get rid of comment cruft in w32/time.cxxChris Sherlock
Change-Id: Ief31a90cb0d14ac396be4d11719f8deb136b081d
2017-07-22osl: get rid of comment cruft in w32/sockimpl.hxxChris Sherlock
Change-Id: Iab2ac765435113b8776be6b6a632e21385b02fae
2017-07-22osl: get rid of comment cruft in w32/socket.cxxChris Sherlock
Change-Id: Ide9debe3e1029646b01ba7698e2c613ba0040bed
2017-07-22osl: get rid of comment cruft in w32/security.cxxChris Sherlock
Change-Id: Ifd3ba56ad420985e646162041682e4872a13258d
2017-07-22osl: remove sig in commentChris Sherlock
Change-Id: I7e02e463105cf65fcc47ce5e3d5f9476ff778cce
2017-07-22osl: remove dead code from w32/salinit.cxxChris Sherlock
Change-Id: I895c0bb5f9d2d072ab6aa7a6aabb22449287283a
2017-07-22osl: get rid of comment cruft in w32 profile.cxxChris Sherlock
Change-Id: If85f1a6d436e894b27a2fcb10a8d44e56e193fff
2017-07-22osl: small cosmetic change to make comment more readableChris Sherlock
Change-Id: I5be685355b0c3180bbf23a421c66c086f05834fa
2017-07-22osl: get rid of comment cruft in w32 path_helper.hxxChris Sherlock
Change-Id: Iaa6160c21281153041fda38ed99f94419f1e9e0d
2017-07-22osl: get rid of comment cruft in w32 path_helper.cxxChris Sherlock
Change-Id: I111c8b4e39fc9f1dd894979ff6fb5e98659182d1
2017-07-22osl: get rid of comment cruft in w32 nlsupport.cxxChris Sherlock
Change-Id: I530537cb897c21ad4c219a3125d97b97429584a8
2017-07-22osl: get rid of comment cruft in w32 mutex.cxxChris Sherlock
Change-Id: I8ca5a16d0d7bdedf8a8c5685e088043566bab8eb
2017-07-22osl: get rid of comment cruft in w32 module.cxxChris Sherlock
Change-Id: I7cbad67d06942257800403d2d5530e272d33ebb9
2017-07-22osl: minor whitespace fixup from automated changeChris Sherlock
Change-Id: I93186466ba800f46c263bc49f51604a1d014a52f
2017-07-22osl: remove extraneous comments from w32/file_dirvold.cxxChris Sherlock
Change-Id: I21a0ce806f64582a62b9ff0e30a2299d1f478ffc
2017-07-22osl: fix w32/backtrace.cxx commentChris Sherlock
Change-Id: Id6f941a9ef62827d7e4aa1d8ad4af0494470ea8e
2017-07-22osl: get rid of comment cruft in w32 conditn.cxxChris Sherlock
Change-Id: I4ef57b561813c28dfbb2e930e4d972953b94f5ba
2017-07-22osl: give condition tests more descriptive namesChris Sherlock
Change-Id: Iac83de722e5c3ee350e1588940567fc67a79e045
2017-07-22osl: condition qa remove extraneous commentsChris Sherlock
Change-Id: I2db888e3260543563d8c6ea5b0575e46e98df9d7
2017-07-22avoid unnecessary calls of AdjustRowHeightTamas Bunth
Change-Id: I2d164f69a7313d69f3fe5cabe1e3cc39aeba4d32 Reviewed-on: https://gerrit.libreoffice.org/40272 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-07-22loplugin:constparams in editeng,lingucomponentNoel Grandin
Change-Id: I99d9153e3fd1fead34c856ac68a120bb06a003d3 Reviewed-on: https://gerrit.libreoffice.org/40296 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22loplugin:unusedfields in editengNoel Grandin
Change-Id: I61ddd2ce8ded65251fdf1903e6cb67f0d18c9451 Reviewed-on: https://gerrit.libreoffice.org/40293 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22loplugin:unusedfields in extensions..frameworkNoel Grandin
Change-Id: I687c67c8f3c0e03c6ab2da0a93a9e62f0caf12cd Reviewed-on: https://gerrit.libreoffice.org/40292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22loplugin:unusedfields in ioNoel Grandin
Change-Id: I8be28fa2ed1e005c76eafc60746620338c8a49ac Reviewed-on: https://gerrit.libreoffice.org/40291 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22loplugin:unusedfields in oox,reportdesignNoel Grandin
Change-Id: I0201d76cb3d4605bdc00c81cfa9d91f98341c7f3 Reviewed-on: https://gerrit.libreoffice.org/40290 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22make oncevar plugin ignore methods with #ifdef-eryNoel Grandin
Change-Id: I8a9cf2c4b81b95bf654f7e90306328d72e3d3408 Reviewed-on: https://gerrit.libreoffice.org/40280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22vcl: fix Unicode cast in mnemonic testChris Sherlock
Fix the following: /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/qa/cppunit/mnemonic.cxx:35:50:error: in LIBO_INTERNAL_ONLY code, replace literal cast to 'sal_Unicode' (aka 'char16_t') with a u'...' char16_t character literal [loplugin:salunicodeliteral] CPPUNIT_ASSERT_EQUAL(sResult[1], sal_Unicode('~')); ~~~~~~~~~~~~^~~~ /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:300:32: note: expanded from macro 'CPPUNIT_ASSERT_EQUAL' (actual), \ ^~~~~~ 1 error generated. Change-Id: I323270d4ddf9e8ae22f9bf7cd7333a8d7e58d17c Reviewed-on: https://gerrit.libreoffice.org/40301 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-07-22Separate SvxToolbarConfigPage from cfg.cxxMuhammet Kara
Change-Id: I4aa504b92e9507635152c623a07d0538079860de Reviewed-on: https://gerrit.libreoffice.org/39389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-on: https://gerrit.libreoffice.org/40297 Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-07-21sw: it looks like MoveRange() is never called withMichael Stahl
... Undo enabled; let's try if somebody finds a way and remove this later if not. Change-Id: I9bad32342b129743ecfecb26901857cc4c79a89d
2017-07-21tdf#99692 sw: fix bookmark positions in tables at start of redlinesMichael Stahl
The code assumes that if it can move the cursor backward in line 2038, that move can be "inverted" by moving the cursor forward after the content has been moved - but if the cursor moved back a node, and the moved content does not start with a SwTextNode, the cursor will move forward skipping over the non-text nodes, so offsets in the aSaveBkmks (and aSaveRedl, presumably) are going to be wrong. Just don't use Move() if it leaves the current node. Change-Id: I95278a10c14aeba9f76558486bb2712f6726dbcb
2017-07-21tdf#106533 Correct insert index entry icon filenameYousuf Philips
Change-Id: I70ba9feb06056a7dbcf34ed1b533639be217833b Reviewed-on: https://gerrit.libreoffice.org/39441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-07-21mnemonics in words with Eszett misplacedCaolán McNamara
because the text is normalized with toUpper and uppercase ß is SS and using the insertion index of the normalized string in the original string is out by one if we normalize with toLower then according to icu/source/data/unidata/SpecialCasing.txt then as long as the language is not Lithuanian its always one to one so just normalize to lower case with blank locale Change-Id: I0ad1c7e2ad0216b7c27ec62105f9a25672ade8a8
2017-07-21call python script with whatever is set as the python to useCaolán McNamara
Change-Id: I5dcfe7c1eca2f6388d6606521722a5fe876a9f34
2017-07-21ofz#2704 null-dereference readCaolán McNamara
Change-Id: Iaadec2dfdebd2b2e273d369cc22f48153cd6d213
2017-07-21Rename InitAnySequence -> InitAnyPropertySequence, and convert some callers.Jan Holesovsky
Change-Id: I410fef49679360f3308ec0f00bb032a2de0d7931 Reviewed-on: https://gerrit.libreoffice.org/40282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-07-21sd pptm: Unit tests for the .pptm support.Jan Holesovsky
Change-Id: Ie0d05e70fe2b0869470a1750d5b60566f129247b Reviewed-on: https://gerrit.libreoffice.org/40268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-07-21sd pptm: Preserve the VBA stream on export.Jan Holesovsky
This actually implements the reading of the VBA stream in Impress too, so the user will get a warning when opening such a file (that the it contains macros). Change-Id: I1638199529196ed217cbd9ebef88eb7c88f2179a Reviewed-on: https://gerrit.libreoffice.org/40197 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/40267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-07-21lok: Add docm/xlsm/pptm filters to be known by LOK.Jan Holesovsky
Change-Id: I4995498132b832ce783efc9740f1d7129f085a01 Reviewed-on: https://gerrit.libreoffice.org/40196 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/40266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>