summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-04tdf#120291 Attaching a connector makes draw Draw busy-loopNoel Grandin
regression from commit ffe84f49270e0a8818365ca7d1fd5242abff5562 remove SdrObject::GetHdl in favour of AddToHdlList Change-Id: Idb15b976f6e1fcb6ffeda933ffbec96d59e6f155 Reviewed-on: https://gerrit.libreoffice.org/61370 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04Resolves: tdf#120238 remove wrong assert()Eike Rathke
There may be a non-empty RowMap even if nColCount == 0 || nRowCount == 0 if there was only one column or row (or cell) selected and bRowHeaders and/or bColHeaders were set, thus nColCount and/or nRowCount were decremented by 1. Regression from commit b1f9aa5f58ea322097998839e00d95fc40be8b22 CommitDate: Fri Sep 28 09:04:07 2018 +0200 loplugin:useuniqueptr in ScChartPositionMap Change-Id: I942e3fcc92449da57d708f654000387f862a4066
2018-10-04gla11y: better print paired element for visibility conflictSamuel Thibault
Change-Id: I1f3bcaf732d01c5def7b84ecbd14e0cbe3397927 Reviewed-on: https://gerrit.libreoffice.org/61300 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-04sal_False -> false in commentLionel Elie Mamane
Change-Id: I3344af4ce28bd2b94725ea9336ce1b1ab9c98554
2018-10-04weld SwCreateAddressListDialogCaolán McNamara
Change-Id: I9b8fa8ff001f82904db2478a6c88419294df2855 Reviewed-on: https://gerrit.libreoffice.org/61364 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04loplugin:redundantcastStephan Bergmann
"static_cast from 'CGContextRef' (aka 'CGContext *') prvalue to 'CGContextRef' (aka 'CGContext *') prvalue is redundant" with --with-macosx-version-min-required=10.14 at least. (Not exactly sure why this warning only starts to appear now. Presumably something changed in the system headers. Lets see whether older baseline builds are happy with the dropped casts, too.) Change-Id: Id52d1891e5e33f7c37d095440339980b4000ca4e Reviewed-on: https://gerrit.libreoffice.org/61353 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-04weld SwFindEntryDialogCaolán McNamara
Change-Id: Ia45e4ce13b92fd73fcc8ad52233aa5eccc3cfb6d Reviewed-on: https://gerrit.libreoffice.org/61365 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld SwAddRenameEntryDialogCaolán McNamara
Change-Id: I687486a392450fcf3b92fdc4d7a193b10f829835 Reviewed-on: https://gerrit.libreoffice.org/61363 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld SchLegendDlgCaolán McNamara
Change-Id: Ie57d195782d9fbfdf555205e53e733529b4c1ae8 Reviewed-on: https://gerrit.libreoffice.org/61360 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04drop SvMemoryStream::GetBufferNoel Grandin
since it does the same thing as GetData() Change-Id: I18d35aa4e67ad7775987160c021863d0de90179b Reviewed-on: https://gerrit.libreoffice.org/61350 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04Select the current format if multiple instead of first matching format codeEike Rathke
This never worked.. Change-Id: I79b8687dde4faac383121abeda70931d0192b33d Reviewed-on: https://gerrit.libreoffice.org/61290 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-04external/gpgmepp: Clash between VERSION and trunk libc++ <version>Stephan Bergmann
...on macOS with case-insensitive file systems. When compiling e.g. workdir/UnpackedTarball/gpgmepp/lang/cpp/src/parser/exception.cpp, libtool adds -I../../.. (presumably to find files like workdir/UnpackedTarball/gpgmepp/config.h), and including e.g. <string> internally includes <version> now, and workdir/UnpackedTarball/gpgmepp/VERSION happens to win. So just remove VERSION from the sources, which appears to not be needed at least in our build of gpgmepp. (An alternative approach might have been to use -iquote../../.. instead of -I../../.., but that's probably hard to shoehorn into the libtool-generated compiler invocation.) Change-Id: Ib1a30a6b825cab208238d17ff384e7900a27047d Reviewed-on: https://gerrit.libreoffice.org/61359 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-04external/liborcus: Clash between VERSION and trunk libc++ <version>Stephan Bergmann
...on macOS with case-insensitive file systems. When compiling e.g. workdir/UnpackedTarball/liborcus/src/parser/base64.cpp, libtool adds -I../.. (presumably to find files like workdir/UnpackedTarball/liborcus/config.h), and including e.g. <vector> internally includes <version> now, and workdir/UnpackedTarball/liborcus/VERSION (generated from VERSION.in) happens to win. So disable generation of VERSION from VERSION.in (Kohei confirmed in private communication that that file isn't actually used for anything, so not generating it is fine). (An alternative approach might have been to use -iquote../.. instead of -I../.., but that's probably hard to shoehorn into the libtool-generated compiler invocation.) Change-Id: Id9a6778368796dc2494df3499b5e1ca560df1e56 Reviewed-on: https://gerrit.libreoffice.org/61358 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Jenkins
2018-10-04Avoid -Werror=stringop-truncationStephan Bergmann
... "‘strncpy’ output truncated before terminating nul copying as many bytes from a string as its length", as reported at <https://lists.freedesktop.org/archives/libreoffice/2018-October/081109.html> "LO build fails -Werror=stringop-truncation in _lex.c". Not adding the terminating NUL appears to be intentional here, as the s->inp buffer is terminated (through s->inl) with EOB bytes after the if/else blocks. Change-Id: I5a8559e620b7e34ee27cbcd0f836432deb8cba90 Reviewed-on: https://gerrit.libreoffice.org/61355 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-04weld SteppedPropertiesDialogCaolán McNamara
Change-Id: I6e5a5a76f4e7d0d8b71e7d2e3dee9f7c2815f5d5 Reviewed-on: https://gerrit.libreoffice.org/61357 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld SchTitleDlgCaolán McNamara
Change-Id: Ie4537b9b6d856178ae378473fda4a1b27a1ed0b5 Reviewed-on: https://gerrit.libreoffice.org/61356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04tdf#120287 sw layout, TabOverMargin: imply PrinterIndependentLayout=high-resMiklos Vajna
In case an ODT document has the usual layout compat flags enabled (by the DOC/DOCX/RTF imports) to emulate Word behavior, then it's expected that Word will lay out the resulting ODT document similar to Writer. This works most of the time, but in case exact spacing matters, it's important that PrinterIndependentLayout is not disabled, as that doesn't match the Word default and will result in mismatching Writer vs Word layout. Change-Id: I0fbe110a6417ffa5d919fb81236a60bfa1fc30f5 Reviewed-on: https://gerrit.libreoffice.org/61352 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-04pass AbstractGeometryAttributes around by std::unique_ptrNoel Grandin
Change-Id: I6e06c89b5e4b77c8fc5e3e1a6bf7d76d8ebd7810 Reviewed-on: https://gerrit.libreoffice.org/61349 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:useuniqueptr in SwInsDBColumnsNoel Grandin
Change-Id: Idd159cfd29d487773e478a0cca352fcb77f88a33 Reviewed-on: https://gerrit.libreoffice.org/61340 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:useuniqueptr in SwWriteTableColsNoel Grandin
Change-Id: Ib4c95401c3e9e60c1c909080b3381d652c862e62 Reviewed-on: https://gerrit.libreoffice.org/61342 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:useuniqueptr in SetGetExpFieldsNoel Grandin
and a couple more utility methods to o3tl::sorted_vector to make this easier Change-Id: Iebbbb8899b67fffa1ac98ae46b7fa70a7e35f866 Reviewed-on: https://gerrit.libreoffice.org/61344 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:useuniqueptr in HTMLControlsNoel Grandin
Change-Id: I7301fdb1dba6f05b43b114cfb72641958322964d Reviewed-on: https://gerrit.libreoffice.org/61343 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:useuniqueptr in SwSeqFieldListNoel Grandin
no need to store such a small structure separately on the heap Change-Id: I36b3ad5250718b7bdf526f5f67219740c69a549a Reviewed-on: https://gerrit.libreoffice.org/61298 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:useuniqueptr in SwBlockNamesNoel Grandin
Change-Id: Ib7b0b206439b9b14cbfdf58bc8932281329e7deb Reviewed-on: https://gerrit.libreoffice.org/61346 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:override (--enable-qt5)Stephan Bergmann
Change-Id: Id9e3127a7ac53dc9e50caa4d4c4c4d7c6e7008fb
2018-10-04loplugin:subtlezeroinit (--enable-qt5)Stephan Bergmann
Change-Id: I1a6f0a2b0de82fd0e8c30818c2ddf6e0a2d3f1b0
2018-10-04loplugin:nullptr (--enable-qt5)Stephan Bergmann
Change-Id: I85e310a4e2cf8e9f726d8d7c6ac8bbb399f0cd7c
2018-10-04loplugin:useuniqueptr in SwXMLTableColumns_ImplNoel Grandin
Change-Id: Iee894bccfc162bd97093def7eb86d54be9fde13d Reviewed-on: https://gerrit.libreoffice.org/61341 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04Implement qt5 plain text copy to clipboardKatarina Behrens
Change-Id: I5804467c97758641718a6d6314cae015a0442d1b Reviewed-on: https://gerrit.libreoffice.org/61233 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-04Implement qt5 plain text paste from system clipboardKatarina Behrens
Change-Id: I44053d445098efc619ad9255d8f21962531a0654 Reviewed-on: https://gerrit.libreoffice.org/60674 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-04Clipboard support for qt5, first cutKatarina Behrens
this adds just enough of basic UNO ifaces to have SID_PASTE enabled. It can't actually paste anything yet. Change-Id: I82e8ef37e11e9df21d27f08d4d199f3e5924ed84 Reviewed-on: https://gerrit.libreoffice.org/60494 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-04Resolves: tdf#120175 normalize theme names to our naming schemeCaolán McNamara
So breeze-dark turns into breeze_dark Change-Id: Id5d06f73a79f099048b31fd16f9f9611236af392 Reviewed-on: https://gerrit.libreoffice.org/61321 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04color moved to slot 4Caolán McNamara
Change-Id: I965d4b042cf1510d5286c85043792a140116497f Reviewed-on: https://gerrit.libreoffice.org/61331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld SbaSbAttrDlgCaolán McNamara
Change-Id: Ic1478d92fcf829bebdf8ada1051a4373d47077cf Reviewed-on: https://gerrit.libreoffice.org/61330 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld DlgSizeCaolán McNamara
Change-Id: I5e27d2a27810af98bd0cf59f9e9cbe1cf75d7f1b Reviewed-on: https://gerrit.libreoffice.org/61329 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04replace sclo-ScExtIButton with MenuButtonCaolán McNamara
Change-Id: I1f03bebe465e76f7e62f707937b9289e17b76605 Reviewed-on: https://gerrit.libreoffice.org/61328 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04xmlsecurity nss: avoid deleting the dsig context manuallyMiklos Vajna
Change-Id: I0198c1b0d6ba6c27072376943895718d536a284c Reviewed-on: https://gerrit.libreoffice.org/61323 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-04elementary: sync folder color with upstream, add more 32px, etcRizal Muttaqin
Change-Id: I28f0e7b964a229320ede7accfd3a98e35ef113b3 Reviewed-on: https://gerrit.libreoffice.org/61180 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-04Fix crash when no key bindings are availableSamuel Mehrbrodt
Change-Id: I89693a01bd3e89f6d4000901c01accf88b453691 Reviewed-on: https://gerrit.libreoffice.org/61232 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-04related tdf#76683 writerfilter: hanging implemented as SignedJustin Luth
despite the documentation that states it must be a positive value, the actual implmentation honors a negative number (as opposed to treating it as a zero, or an absolute). Change-Id: Ie38369ecdf5353b73572dd3533c2efe41adda290 Reviewed-on: https://gerrit.libreoffice.org/59401 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-04use regular Set methods in TextCharAttribNoel Grandin
instead of returning a mutable ref, which just reads weird Change-Id: Ia2e2a7222f6ccd73e1d7f69dd7c2523f3a05ae24 Reviewed-on: https://gerrit.libreoffice.org/61309 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04use unique_ptr in TextCharAttribList::InsertAttribNoel Grandin
Change-Id: Ie6818586e9dbbcbf79f0bb8e1031fc0a0b13763a Reviewed-on: https://gerrit.libreoffice.org/61308 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04pass SvXMLNamespaceMap around using std::unique_ptrNoel Grandin
Change-Id: Ia5ae67678a508e3df81e72cb84993491e222c528 Reviewed-on: https://gerrit.libreoffice.org/61307 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04reserve space before appending to vector in a loopNoel Grandin
Change-Id: Ib0017fc2a57ab90596aa494934c9579cae4bf4aa Reviewed-on: https://gerrit.libreoffice.org/61301 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:useuniqueptr in ResultMembersNoel Grandin
no need to store a small structure separately on the heap Change-Id: I054ca078242225d12cf8abc86e25813586e6495f Reviewed-on: https://gerrit.libreoffice.org/61299 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03tdf#120057: protect sheet dialog checklistbox should be can-focusXisco Fauli
Same logic as fee3669a3395133a9e47ff2f0a96159cb3eefb89 Change-Id: I43c00a6fcd0e3b42798702f746df9bcb7f817a5f Reviewed-on: https://gerrit.libreoffice.org/61320 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03Resolves: tdf#120265 assert on moving item via customization dialogCaolán McNamara
Change-Id: I435409a1e16ad138519fb31e873dcb4f500b3734 Reviewed-on: https://gerrit.libreoffice.org/61319 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03Resolves: tdf#93372 format table in base is ignoredCaolán McNamara
since... commit b4bbb5e5d7b31caad2fbcc00382ad27df3c81001 Date: Sun May 17 22:56:46 2015 +0900 refactor how font, fg. and bg. are applied in widgets/controls revert the relevant piece, in this case there are two Windows/Contexts getting their settings manipulated, rather than the usual one Change-Id: I0a228aee6aaf1f58b2235fccf14dc63ffa96dd2d Reviewed-on: https://gerrit.libreoffice.org/61317 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03Resolves: tdf#117784 inherit SfxTabDialogController from SfxDialogControllerCaolán McNamara
Change-Id: I6b7ce81093ec402954aa5a2f4b266827fe85a88f Reviewed-on: https://gerrit.libreoffice.org/61314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03Related: tdf#120277 inherit from SfxDialogControllerCaolán McNamara
where the dialog originally inherited from SfxModalDialog. Change-Id: Ibe0006de93b0a9f05fb3b6181baf3ba1b4cf04c8 Reviewed-on: https://gerrit.libreoffice.org/61313 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-03-01 09:21:51 +0000