summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-25return std::unique_ptr from CloneSetWhichNoel Grandin
Change-Id: I709122cb8cd7c257e7eb2bd564c529689e6d555a Reviewed-on: https://gerrit.libreoffice.org/62350 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-25Drop duplicate PhysicalFontFace referenceJan-Marek Glogowski
A LogicalFontInstance has a pointer to its parent font face. And don't pretend we can actually nest MultiSalLayout, so store the GenericSalLayout internally. Change-Id: I801acbc34497fc57e8e185eee34c1a1162dbea93 Reviewed-on: https://gerrit.libreoffice.org/62314 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-25Fix typoAndrea Gelmini
Change-Id: I7c5603468f5ee7f7e33940d7b3787318c307acfa Reviewed-on: https://gerrit.libreoffice.org/62343 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-25weld SwTOXStylesTabPageCaolán McNamara
Change-Id: I1e7056ef8293ddc7072e95ee248e45b2785d1234 Reviewed-on: https://gerrit.libreoffice.org/62347 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25Fix external/hunspell/0001-recent-Hunspell-fixes-for-suggestion-spelling-...Stephan Bergmann
...introduced with b691e5824a6346d2fe7f702b5280b56532a2f89e "tdf#118162 spell checking: fix freezing and add missing OCONV", leaving HunspellImpl::suggest_internal's newly introduced out-parameters uninitialized when the function returns early, causing HunspellImpl::suggest to use capwords uninitialized, as seen when invoking spell-checking in LO built with UBSan: > hunspell.cxx:907:7: runtime error: load of value 160, which is not a valid value for type 'bool' > #0 in HunspellImpl::suggest(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) at workdir/UnpackedTarball/hunspell/src/hunspell/hunspell.cxx:907:7 (instdir/program/../program/libspelllo.so +0x288ccd) > #1 in Hunspell::suggest(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) at workdir/UnpackedTarball/hunspell/src/hunspell/hunspell.cxx:888:18 (instdir/program/../program/libspelllo.so +0x288693) > #2 in SpellChecker::GetProposals(rtl::OUString const&, com::sun::star::lang::Locale const&) at lingucomponent/source/spellcheck/spell/sspellimp.cxx:467:56 (instdir/program/../program/libspelllo.so +0x202913) > #3 in SpellChecker::spell(rtl::OUString const&, com::sun::star::lang::Locale const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at lingucomponent/source/spellcheck/spell/sspellimp.cxx:520:17 (instdir/program/../program/libspelllo.so +0x203b84) > #4 in non-virtual thunk to SpellChecker::spell(rtl::OUString const&, com::sun::star::lang::Locale const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at lingucomponent/source/spellcheck/spell/sspellimp.cxx (instdir/program/../program/libspelllo.so +0x203e62) > #5 in SpellCheckerDispatcher::spell_Impl(rtl::OUString const&, o3tl::strong_int<unsigned short, LanguageTypeTag>, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at linguistic/source/spelldsp.cxx:484:44 (instdir/program/liblnglo.so +0x672505) > #6 in SpellCheckerDispatcher::spell(rtl::OUString const&, com::sun::star::lang::Locale const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at linguistic/source/spelldsp.cxx:227:12 (instdir/program/liblnglo.so +0x670040) > #7 in SpellCheckerDispatcher::spell(rtl::OUString const&, short, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at linguistic/source/spelldsp.cxx:768:12 (instdir/program/liblnglo.so +0x67b353) > #8 in non-virtual thunk to SpellCheckerDispatcher::spell(rtl::OUString const&, short, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at linguistic/source/spelldsp.cxx (instdir/program/liblnglo.so +0x67b538) > #9 in Thesaurus::queryMeanings(rtl::OUString const&, com::sun::star::lang::Locale const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at lingucomponent/source/thesaurus/libnth/nthesimp.cxx:433:27 (instdir/program/../program/liblnthlo.so +0x88315) > #10 in non-virtual thunk to Thesaurus::queryMeanings(rtl::OUString const&, com::sun::star::lang::Locale const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at lingucomponent/source/thesaurus/libnth/nthesimp.cxx (instdir/program/../program/liblnthlo.so +0x8a322) > #11 in ThesaurusDispatcher::queryMeanings(rtl::OUString const&, com::sun::star::lang::Locale const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at linguistic/source/thesdsp.cxx:181:40 (instdir/program/liblnglo.so +0x6b6fa5) > #12 in non-virtual thunk to ThesaurusDispatcher::queryMeanings(rtl::OUString const&, com::sun::star::lang::Locale const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at linguistic/source/thesdsp.cxx (instdir/program/liblnglo.so +0x6b7ca2) > #13 in ThesaurusMenuController::getMeanings(std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> >&, rtl::OUString const&, com::sun::star::lang::Locale const&, unsigned long) at framework/source/uielement/thesaurusmenucontroller.cxx:117:31 (instdir/program/../program/libfwklo.so +0x1be1a9a) > #14 in ThesaurusMenuController::fillPopupMenu() at framework/source/uielement/thesaurusmenucontroller.cxx:75:5 (instdir/program/../program/libfwklo.so +0x1bdf973) > #15 in ThesaurusMenuController::statusChanged(com::sun::star::frame::FeatureStateEvent const&) at framework/source/uielement/thesaurusmenucontroller.cxx:63:9 (instdir/program/../program/libfwklo.so +0x1bdf24d) > #16 in SfxDispatchController_Impl::addStatusListener(com::sun::star::uno::Reference<com::sun::star::frame::XStatusListener> const&, com::sun::star::util::URL const&) at sfx2/source/control/unoctitm.cxx:861:16 (instdir/program/libsfxlo.so +0x2b6851f) > #17 in SfxOfficeDispatch::addStatusListener(com::sun::star::uno::Reference<com::sun::star::frame::XStatusListener> const&, com::sun::star::util::URL const&) at sfx2/source/control/unoctitm.cxx:249:16 (instdir/program/libsfxlo.so +0x2b671d4) > #18 in svt::PopupMenuControllerBase::updateCommand(rtl::OUString const&) at svtools/source/uno/popupmenucontrollerbase.cxx:189:20 (instdir/program/libsvtlo.so +0x2b0ef9e) > #19 in svt::PopupMenuControllerBase::updatePopupMenu() at svtools/source/uno/popupmenucontrollerbase.cxx:173:5 (instdir/program/libsvtlo.so +0x2b0e66f) > #20 in svt::PopupMenuControllerBase::setPopupMenu(com::sun::star::uno::Reference<com::sun::star::awt::XPopupMenu> const&) at svtools/source/uno/popupmenucontrollerbase.cxx:357:5 (instdir/program/libsvtlo.so +0x2b13e92) > #21 in framework::MenuBarManager::CreatePopupMenuController(framework::MenuBarManager::MenuItemHandler*) at framework/source/uielement/menubarmanager.cxx:984:31 (instdir/program/../program/libfwklo.so +0x1a9ff7e) > #22 in framework::MenuBarManager::Activate(Menu*) at framework/source/uielement/menubarmanager.cxx:737:50 (instdir/program/../program/libfwklo.so +0x1a94daa) > #23 in framework::MenuBarManager::LinkStubActivate(void*, Menu*) at framework/source/uielement/menubarmanager.cxx:605:1 (instdir/program/../program/libfwklo.so +0x1a8f150) > #24 in Link<Menu*, bool>::Call(Menu*) const at include/tools/link.hxx:84:45 (instdir/program/libvcllo.so +0x3bda2ae) > #25 in Menu::Activate() at vcl/source/window/menu.cxx:269:28 (instdir/program/libvcllo.so +0x3b75b01) > #26 in PopupMenu::ImplExecute(VclPtr<vcl::Window> const&, tools::Rectangle const&, FloatWinPopupFlags, Menu*, bool) at vcl/source/window/menu.cxx:2849:5 (instdir/program/libvcllo.so +0x3bcc12e) > #27 in PopupMenu::Execute(vcl::Window*, tools::Rectangle const&, PopupMenuFlags) at vcl/source/window/menu.cxx:2788:12 (instdir/program/libvcllo.so +0x3bc95d6) > #28 in PopupMenu::Execute(vcl::Window*, Point const&) at vcl/source/window/menu.cxx:2763:12 (instdir/program/libvcllo.so +0x3bc8c20) > #29 in SfxDispatcher::ExecutePopup(rtl::OUString const&, vcl::Window*, Point const*) at sfx2/source/control/dispatch.cxx:1857:23 (instdir/program/libsfxlo.so +0x27980ec) > #30 in SfxDispatcher::ExecutePopup(vcl::Window*, Point const*) at sfx2/source/control/dispatch.cxx:1806:19 (instdir/program/libsfxlo.so +0x279500f) > #31 in SwEditWin::Command(CommandEvent const&) at sw/source/uibase/docvw/edtwin.cxx:5224:25 (instdir/program/../program/libswlo.so +0xd546dd0) > #32 in ImplCallCommand(VclPtr<vcl::Window> const&, CommandEventId, void const*, bool, Point const*) at vcl/source/window/winproc.cxx:228:17 (instdir/program/libvcllo.so +0x4283a3c) > #33 in ImplHandleMouseEvent(VclPtr<vcl::Window> const&, MouseNotifyEvent, bool, long, long, unsigned long, unsigned short, MouseEventModifiers) at vcl/source/window/winproc.cxx:792:34 (instdir/program/libvcllo.so +0x427e12e) > #34 in ImplHandleSalMouseButtonDown(vcl::Window*, SalMouseEvent const*) at vcl/source/window/winproc.cxx:1982:12 (instdir/program/libvcllo.so +0x429c206) > #35 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at vcl/source/window/winproc.cxx:2316:20 (instdir/program/libvcllo.so +0x4296785) > #36 in SalFrame::CallCallback(SalEvent, void const*) const at vcl/inc/salframe.hxx:280:29 (instdir/program/libvclplug_gtk3lo.so +0xb9badd) > #37 in GtkSalFrame::CallCallbackExc(SalEvent, void const*) const at vcl/unx/gtk3/gtk3gtkframe.cxx:4477:16 (instdir/program/libvclplug_gtk3lo.so +0xb139f3) > #38 in GtkSalFrame::signalButton(_GtkWidget*, _GdkEventButton*, void*) at vcl/unx/gtk3/gtk3gtkframe.cxx:2690:16 (instdir/program/libvclplug_gtk3lo.so +0xb2f96e) > #39 in _gtk_marshal_BOOLEAN__BOXED at /usr/src/debug/gtk3-3.24.1-1.fc29.x86_64/gtk/gtkmarshalers.c:83:14 (/lib64/libgtk-3.so.0 +0x3e16fa) [...] Change-Id: I613bf37ded8c525301297d96e0d33826c9a48215 Reviewed-on: https://gerrit.libreoffice.org/62345 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2018-10-25re-orient insert index entry to have action buttons at the bottomCaolán McNamara
Change-Id: Id383ef7eaab9b48c93ced12277f1676a01a6da84 Reviewed-on: https://gerrit.libreoffice.org/62349 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25Reorganize FrameBorderPrimitive creation (II)Armin Le Grand
Step5: Move the view-dependent decomposition from BorderLinePrimitive2D to SdrFrameBorderPrimitive2D. It is now possible to use discrete sizes before the line and edge matching is done what will look much better. When it was done at BorderLinePrimitive2D and the matching was already done, that match was 'displaced' with the adapted forced scale to discrete units. The space and size used when zooming out for a single discrete unit (pixel) can heavily vary - it just covers a much larger logical area than the 'real' line/poly would do. All this needs to be handled (also for bound ranges) and can only be in a good way using primitives. Adapted to no longer do view-dependent changes in BorderLinePrimitive2D. Adapted to do these now at SdrFrameBorderPrimitive2D. Currently used to force the existing border partial lines (up to three) to not get taller than one logical unit. Adapted to no longer switch off AntiAliased rendering in VclPixelProcessor2D for processBorderLinePrimitive2D, this is problematic with various renderers on various systems (e.g. vcl still falls back to render multiple one-pixel-lines when taller than 3.5 pixels which looks horrible combined with other parts like filled polygons) All this needs fine balancing on - all systems - all renderers - all apps (which all have their own table implementation) - all render targets (pixel/PDF/print/slideshow/...) Done as thorough as possible, but may need additional finetuning. May also be a motivation to move away from vcl and implement these urgetly needed system-dependent primitive renderers... Adapted UnitTest testDoublePixelProcessing with the needed comments. Change-Id: Ie88bb76c2474b6ab3764d45a9cd1669264492acd Reviewed-on: https://gerrit.libreoffice.org/62344 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-10-25Resolves: tdf#113977 implement REGEX() spreadsheet functionEike Rathke
REGEX( Text ; Expression [ ; Replacement ] ) Using ICU regular expressions http://userguide.icu-project.org/strings/regexp Change-Id: I4cb9b8ba77cfb5b8faab93037aa0d947609383d7 Reviewed-on: https://gerrit.libreoffice.org/62332 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-25tdf#120830 crash opening Form-Based FiltersNoel Grandin
regression from commit 7469e078dc3a7a891bd7f5c44a693e4421d3bcdd loplugin:useuniqueptr in FmXGridCell Change-Id: Ia74fcb518fe568d702101ff088f30dc8c096528f Reviewed-on: https://gerrit.libreoffice.org/62346 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-25tdf#118747 sc: use manual height for previous rows in TransferObjVasily Melenchuk
This can ensure, that visible area will not shift if autoheight will change height of previous rows. Change-Id: I66e013e9f3f27396f13b26fde37353cb63e47258 Reviewed-on: https://gerrit.libreoffice.org/62279 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-25sw: fix some IWYU warningsMiklos Vajna
Change-Id: Ic7e6aa31e5c6d210101da7223a294092ab5b7481 Reviewed-on: https://gerrit.libreoffice.org/62334 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-25tdf#119856 related: opening kde5 filepicker from extensions now possibleKatarina Behrens
certain things have to be done exclusively in main thread Change-Id: Ib9f5a3187080cd986977e323a38a1e6c2ed57366 Reviewed-on: https://gerrit.libreoffice.org/62281 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-25Update git submodulesMarco A.G.Pinto
* Update dictionaries from branch 'master' - Updated the English dictionaries: GB+AU+CA+US+Extension logo Change-Id: I4223020f9ead26d3497908a3160395fa7b75d9f9 Reviewed-on: https://gerrit.libreoffice.org/62340 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-10-25tdf#120713 correctly handle boolean values in filtersLionel Elie Mamane
This commit has two parts: - Hardcode the correct BooleanComparisonMode in the firebird-sdbc driver (this fixes on Firebird databases, among others, the AutoFilter for bools) - Generic to all DBMS, have the "form-based filter" obey the BooleanComparisonMode Change-Id: Ib14e6c3d5cb773ae1f972840f8b53062f0224396 Reviewed-on: https://gerrit.libreoffice.org/62319 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-10-25weld OUserAdminDlgCaolán McNamara
Change-Id: I3e190db7c00ebff55296fe1ffb8999d9892c7723 Reviewed-on: https://gerrit.libreoffice.org/62329 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25rename DBOConnectionURLEdit and DBOConnectionHelper backCaolán McNamara
Change-Id: I9353efc407d9dab04b72d7ddedd43bfa125c63ca Reviewed-on: https://gerrit.libreoffice.org/62328 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25drop OConnectionURLEdit and OConnectionHelperCaolán McNamara
Change-Id: I028b243b21a41f3fbd23dea57ea90f77e4a5317c Reviewed-on: https://gerrit.libreoffice.org/62327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25rename DBOConnectionTabPageSetup back to OConnectionTabPageSetupCaolán McNamara
Change-Id: I3d5c90e51922350ca3bb6f59fc94bf5768c995f1 Reviewed-on: https://gerrit.libreoffice.org/62326 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25fix up wizards pagesCaolán McNamara
Change-Id: Icea2c91d06af4fc5d190186d4f6d624ebfc991ff Reviewed-on: https://gerrit.libreoffice.org/62325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25drop unused stuffCaolán McNamara
Change-Id: Icd92801dc88c603c369bfb6c85bf4278ea609ea9 Reviewed-on: https://gerrit.libreoffice.org/62324 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25weld OJDBCConnectionPageSetupCaolán McNamara
Change-Id: I8c194c8efa17079253c857e171af203c17d3aff3 Reviewed-on: https://gerrit.libreoffice.org/62323 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25weld OSpreadSheetConnectionPageSetupCaolán McNamara
Change-Id: Ibcf63af2bb1272d35420ac1b6f71aaa6f147ec16 Reviewed-on: https://gerrit.libreoffice.org/62322 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25rename DBOTextConnectionHelper back to OTextConnectionHelperCaolán McNamara
Change-Id: Ie20403b88c8510465ab7cccbb431072331dbc96f Reviewed-on: https://gerrit.libreoffice.org/62321 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25rename DBCharSetListBox back to CharSetListBoxCaolán McNamara
Change-Id: I14c8b95ee166b75aa309f701be569f54b57538aa Reviewed-on: https://gerrit.libreoffice.org/62300 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25remove unused stuffCaolán McNamara
Change-Id: I5ae616f46cb86b35435e007f98e4b0f882a75751 Reviewed-on: https://gerrit.libreoffice.org/62299 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25weld OTextConnectionPageSetupCaolán McNamara
Change-Id: Iaa4fdc97be23ccd50471c26923745fd565e10653 Reviewed-on: https://gerrit.libreoffice.org/62298 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25avoid running into commandline length limits on win with all-lang helpChristian Lohmaier
also simplify the recipe by removing the one-time-use only calls to helper commands Unclear though why help adds the lang-dirs individually, as all come from the same subdir and end up in the same target dir... Change-Id: I489b1ac3f1312a565fb2a9cfc071d94201c74555 Reviewed-on: https://gerrit.libreoffice.org/62304 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-10-25loplugin:unusedmethodsNoel Grandin
Change-Id: I1f9ac5f8a090f365d9a21486029e1c13d721a4a4 Reviewed-on: https://gerrit.libreoffice.org/62338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-25tdf#42949 Fix IWYU warnings in include/xmlscript/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iacc5b98b947a26ca920cb9c49e579bc61d69b0c9 Reviewed-on: https://gerrit.libreoffice.org/62119 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-25vcl: use default member initializer for PDFElementMiklos Vajna
Less code and other classes in the same header already do this. Change-Id: I8a64cabcdb4b95acb7e2f55ec371568702d9c331 Reviewed-on: https://gerrit.libreoffice.org/62333 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-25tdf#108064 OOXML export: keep preset dashes with linewidth < 1ptAdam Kovacs
Before this patch prstDash xml tags were preserved only with linewidth 1/4 pt, 1/2 pt or 3/4 pt below 1 pt. Now it is working for example with 0.33 pt. Change-Id: I36372edfaea560d8913cd4aa8ee551ee059ec682 Reviewed-on: https://gerrit.libreoffice.org/61737 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-10-25Fix typoAndrea Gelmini
Change-Id: I48748a2ceb359c3da8f838887e48a81a717df552 Reviewed-on: https://gerrit.libreoffice.org/61711 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-10-25Adapt external/epm/asan.patch.0 to pre-C99Stephan Bergmann
...as e.g. still used in <https://ci.libreoffice.org/job/lo_daily_update_gandalf/511/> Change-Id: I11d85ff9ae7462a4149272344e0b0f52eb120c22
2018-10-25LibreLogo: add unit testsLászló Németh
for program running and command name expansion, and for following fixes: tdf#106792: regression in line length and continuous line drawing tdf#100941: line breaking by "magic wand" tdf#120422: program lines are different paragraphs by "magic wand" Also add function __is_alive__() to LibreLogo.py to check LibreLogo program termination via XScript API. Change-Id: If884b3fd608a6e8077be853eb2dd17fbdfff2011 Reviewed-on: https://gerrit.libreoffice.org/62263 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-10-24tdf#120038 Fix broken svg galler arrow A25andreas kainz
Change-Id: I833e4d7bddec89d83ea09fbf677c818988c149ce Reviewed-on: https://gerrit.libreoffice.org/62312 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-24Fix typosAndrea Gelmini
Change-Id: I64cfe4c24d3abb4a8445fd2e7b832b2bdb0b40d3 Reviewed-on: https://gerrit.libreoffice.org/62310 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-24Removed executable permission on hxx fileAndrea Gelmini
Change-Id: I0004193fc0de93632cdd05628052c35cc524690f Reviewed-on: https://gerrit.libreoffice.org/62311 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-24Fix typoAndrea Gelmini
Change-Id: I403de8537d36dbd476e34070e1a02d4db52fba82 Reviewed-on: https://gerrit.libreoffice.org/62313 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-24ofz#11103 Integer-overflowCaolán McNamara
Change-Id: I4ca56e675056b8bd40c6e9b43516815511b33f20 Reviewed-on: https://gerrit.libreoffice.org/62302 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24hdo is always a HWPDrawingObjectCaolán McNamara
Change-Id: Ia9484304e9fc3c5bc9aa833bf14711203e9e72fe Reviewed-on: https://gerrit.libreoffice.org/62306 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24ofz#11119 Direct-leakCaolán McNamara
since... commit 55f0b65b0568b8a8b1d823578eea1cbf633f4134 Date: Tue Oct 23 09:27:51 2018 +0200 loplugin:useuniqueptr in LoadDrawingObject Change-Id: Id5c7929482a1dc00584c4c1a228d993525fc8ed6 Reviewed-on: https://gerrit.libreoffice.org/62307 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24tdf#120764 Toolbar popups sometimes not showing under WaylandMaxim Monastirsky
This happens with gtk 3.24 if the toolbar button is clicked when the tooltip of that button is visible. The warning gtk emits is "Tried to map a popup with a non-top most parent". The solution is to hide the tooltip early on mouse button press event processing. (gtk does hiding too, but in a way which isn't useful here - see the code comment. We also have similar code for the non-native case in ImplHandleMouseEvent of winproc.cxx.) Note that it's likely a gtk bug, as this new tooltip behavior breaks some native cases too, e.g. combo boxes with tooltips. But we can't leave our toolbars broken until this is fixed upstream. Change-Id: I1ce8bffcd78a3bcbbfe2ffdd1bd006ae5dc79618 Reviewed-on: https://gerrit.libreoffice.org/62207 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-10-24Tell the actual end result and not an intermediate one in the SAL_INFO()Tor Lillqvist
Change-Id: If896ed5b1a8daa3dc057888b858b6b0d5da18f28
2018-10-24pvs-studio: silence V530 use std::unique_ptr less weirdlyCaolán McNamara
Change-Id: I24bcf03ca9277597aea6ccaac661c7e4e3869541 Reviewed-on: https://gerrit.libreoffice.org/62168 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24external/epm: AddressSanitizer: strcpy-param-overlapStephan Bergmann
...during CustomTarget_instsetoo_native/install Change-Id: Ia796057b98044ccd227c150788d5caa1ef68eb25 Reviewed-on: https://gerrit.libreoffice.org/62308 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-24weld ODbAdminDialogCaolán McNamara
Change-Id: I691ce67b55fb16d06d7266ebe671ac31e30c05d5 Reviewed-on: https://gerrit.libreoffice.org/62297 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24fix OGeneralSpecialJDBCDetailsPageCaolán McNamara
Change-Id: Iee83dcd992ff5d66ff4090019ceb764051a9c776 Reviewed-on: https://gerrit.libreoffice.org/62296 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld TextConnectionSettingsDialogCaolán McNamara
Change-Id: Iaa08d066d9c2198bca7e21f619fb89808620fba9 Reviewed-on: https://gerrit.libreoffice.org/62295 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24rename DBOCommonBehaviourTabPage back to OCommonBehaviourTabPageCaolán McNamara
Change-Id: I7877f746280b76bce73998e1ad48f21b02eb521c Reviewed-on: https://gerrit.libreoffice.org/62294 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24drop now unused OCommonBehaviourTabPageCaolán McNamara
Change-Id: I0a7ff8a018cbe20481360196f6f2ed919f11ded8 Reviewed-on: https://gerrit.libreoffice.org/62293 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-01 01:55:18 +0000