summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-02-10Optimize Excel GetOrCreateRow: reduce loopsJustin Luth
for ( size_t nFrom = maRowMap.size(); nFrom <= nXclRow; ++nFrom ) This previous code worked best under the assumption that every row is added to the map. However, the size of the map actually has no correlation to the row numbers contained in it when many rows are identical to each other (think silly formatting and empty rows - related to tdf#105840) Thus row 1,000,000 could occupy slot 2, and every access of that row would then trigger nearly 1 million redundant loops. Optimize: -check to see if the row already exists - if so do nothing. -existance of higher rows indicates there are no missing rows. -build missing rows from the previously-mapped row. Change-Id: Ib02520a1bf0f77b5ca0ec5ad3165ff7ea879515f Reviewed-on: https://gerrit.libreoffice.org/34038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-02-10loplugin:dynexcspec: Deallocation functions are implicitly non-throwingStephan Bergmann
...so a dynamic exception specification should be replaced with noexcept(false). Doesn't look like this omission made any difference when running the rewriter across the LO code base earlier, though. Change-Id: Ib0e2b412b65cae7c1a68e875bbddf93f3656cebb
2017-02-10Remove unnecessary blacklists from loplugin:stringconstantStephan Bergmann
Change-Id: I866a421a2b3e8830aaa7096adaef945a2264195e
2017-02-10Related: tdf#105707 PPTX import: warn on invalid SmartArt fallback relidMiklos Vajna
We already warn when the SmartArt doesn't have a drawingML fallback, but having a reference to a fallback that is not a valid one (so resolves to an empty fragment path) is also unusable. So warn in that case as well. Change-Id: I03b2325003b4eb38b1347a88899799c6d5c33606 Reviewed-on: https://gerrit.libreoffice.org/34129 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-10vcl: move out ImportPDF() from the global namespaceMiklos Vajna
It's a public symbol and can live in the vcl namespace just fine. Change-Id: I677f22e79f8ddc0c0756cc9bfeb498249354c516
2017-02-10unwind RID_POPUP_FILTER local resourceCaolán McNamara
Change-Id: I7369b3eb0e0d937c135fe591beafe9ec96ea9c17
2017-02-10unwind RID_STATISTICS_DLGS local resourceCaolán McNamara
Change-Id: Ib5e7692cce9e097250182ec1518e93848fdc9b86
2017-02-10add --disable-pdfiumCaolán McNamara
Change-Id: I9137dc0030c3c752ffc0931721bf6b0013309d39
2017-02-10coverity#1079165 Uninitialized scalar variableCaolán McNamara
Change-Id: I49284d409bbe678e1e018c9d9502d79db5553faa
2017-02-10pUnicodesPerGlyph[i] is already 1 hereCaolán McNamara
Change-Id: Ib47e850d8ade769cad11f53b7eb3d7cab0337feb
2017-02-10test coverity sanitizing in-source modellingCaolán McNamara
Change-Id: I31b1f021c414b26372c07a28c235bedb3e5a2b32
2017-02-10pdfverify preview: fix macOS color spaceMiklos Vajna
Unlike on Linux and Windows, we need to do an ARGB -> BGRA conversion here. Change-Id: Ifa539973de439de25125e544cfbbe941d08dee00
2017-02-10Further modifications to FastAttributeIter:Mohammed Abdul Azeem
attempt to further reduce unnecessary allocation and freeing of OUString. Change-Id: I85169cfcd2311a5e6a96dc0292ce0686d1b0e43d Reviewed-on: https://gerrit.libreoffice.org/34092 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-10coverity#736181 Out-of-bounds readCaolán McNamara
it should be fine, as we rely on there being at least one password char, this is the same as, commit 2d3ed7ebb592401de214eaeee68c656afbefbe05 Author: Michael Meeks <michael.meeks@collabora.com> Date: Tue Feb 25 22:48:48 2014 +0000 cid#736173 - increase default fill chars buffer size. which is another impl of this Change-Id: I5e1e07af37bea0398153ede300beed67d37d5e12
2017-02-10coverity#1371289 Missing move assignment operatorCaolán McNamara
Change-Id: Iabdebb02e91c630aef11e99f4677fd4187df78a5
2017-02-10tdf#105288 MM wait until all emails are sendJan-Marek Glogowski
Seems mail merge is now much faster then the sending of the merged documents via email. This is why the attached workaround patch to the tdf#103919 bug report, which simply sleeps after queuing a new message, helped solving the problem. It slows down the mail merge and gives time to the mail dispatcher thread. But we actually want to wait until all mails are send, so we have to add a listener and wait for the mail thread to become idle. This listener also allows us to cancel further mail merge when an SMTP error has occured. Change-Id: I9d13bcd8f0d0ff084b20d72ab96f70afa3a764ba Reviewed-on: https://gerrit.libreoffice.org/33989 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-02-10ofz#579 wrong variable tested for 0Caolán McNamara
Change-Id: I721dc9d1c15296b2658421b4c4fe794578f3f1af
2017-02-10mark numbers in floatingareastyle.ui as untranslatableStanislav Horacek
Change-Id: I2a95f50ed32486e47c4017c70ba6bc199317c9c7 Reviewed-on: https://gerrit.libreoffice.org/32817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-02-10tdf#105625 related: don't duplicate dummy character on copyMike Kaganski
Change-Id: I5881887c7a0fd0c9ccd954a36482a3ada5103098 Reviewed-on: https://gerrit.libreoffice.org/34025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-02-10Remove unused installer propertiesSamuel Mehrbrodt
Change-Id: I8a2bbd05ccdf71a59a0c74d5595c37b2308988ea Reviewed-on: https://gerrit.libreoffice.org/34091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-10-Werror=unused-parameterStephan Bergmann
Change-Id: I63e466f8a1e2fbbf1b1bd84f491b37026909b1eb
2017-02-10gbuild-to-ideNS: stop printing multi-target warningMiklos Vajna
gbuild-to-ide stopped doing so in commit 2a4b291d3bfb378776388f67670d877c658fce47 (gbuild-to-ide GbuildParser cleaned, 2017-01-14), be consistent. Change-Id: I307fb2919bf2ace57cd65f81d410d231d3636b80
2017-02-10xmlsecurity: use pdfium to generate a preview in pdfverifyMiklos Vajna
This is just test code to check if the bundled pdfium is usable. Change-Id: I1f1d808796fe77924518cd004d99affe70279e88 Reviewed-on: https://gerrit.libreoffice.org/34081 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-10convert SwXPrintSettingsType to scoped enumNoel Grandin
and drop read-only PRINT_SETTINGS_WEB enumerator Change-Id: I5260b92bca2d86082bbec37569e31be9525a300e
2017-02-10remove unused enumerator from EncodedWordStateNoel Grandin
Change-Id: I793276d2b13bdb966e18acb8f13b4c7e77516898
2017-02-10remove unused enumerators from PolyClipOpNoel Grandin
Change-Id: I0988ebbbc5fe394eaa6fead0d2f909d4a931856c
2017-02-10remove unused enumerators from FTPErrors enumNoel Grandin
Change-Id: I30a2cc41d246b5048f2514eb38ee8e3bef0ed41c
2017-02-10convert InsertOperation to scoped enumNoel Grandin
and drop unused LINK enumerator Change-Id: I6c42424ae5a7503b3e14e5f04fcf7a49b595b416
2017-02-10convert LocationType to scoped enumNoel Grandin
and drop unused ltAnyInstance enumerator Change-Id: Ic471470973542ebcd3c9d0123870e70b3de6b8bb
2017-02-10convert ConfigNameFormat to scoped enumNoel Grandin
and drop unused constants CONFIG_NAME_PLAINTEXT_NAME CONFIG_NAME_FULL_PATH Change-Id: Ibf7e88da0ae54516cb863b8efa995201f2a95268
2017-02-10convert EItem to scoped enumNoel Grandin
and drop read-only enumerators: enum EItem E_APEARCFG enum EItem E_FLTRCFG enum EItem E_FONTSUBSTCONFIG enum EItem E_LANGUAGEOPTIONS enum EItem E_SEARCHOPT Change-Id: Ie3baaecec3d1c30404b4fb0d948e25d4bb2f3f93
2017-02-10convert SvtSaveOptions::EOption to scoped enumNoel Grandin
and remove unused E_SAVEUNPACKED, E_USESHA1INODF12, E_USEBLOWFISHINODF12 enumerators Change-Id: I7c384e0c30af5091a22beeda1c77e4b71fdde55e
2017-02-10convert SvtSecurityOptions::EOption to scoped enumNoel Grandin
and drop unused E_MACRO_DISABLE enumerator Change-Id: I0bd706d4d4e1d8b9004e68c9e77c11410c62a64a Reviewed-on: https://gerrit.libreoffice.org/34067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-10convert SvtSysLocaleOptions::EOption to scoped enumNoel Grandin
and drop unused E_UILOCALE enumerator Change-Id: Ic9bdac91fab15af45e7dbd613e6e44b73b5cf9de Reviewed-on: https://gerrit.libreoffice.org/34066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-10convert SearchParam::SearchType to scoped enumNoel Grandin
and drop unused SRCH_LEVDIST enumerator Change-Id: Ic5118757060656562e04dd7da24a3f143abec3fb Reviewed-on: https://gerrit.libreoffice.org/34065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-10convert Orientation to scoped enumNoel Grandin
and drop unused enumerators Change-Id: I2f42f0f441cf9ce96338d40382acb6d75ea1e1a0 Reviewed-on: https://gerrit.libreoffice.org/34061 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-10starmath: Kill redundant checkTakeshi Abe
Change-Id: I45f873f3733800c43c36b38dcefb79eba46b9007 Reviewed-on: https://gerrit.libreoffice.org/34030 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-09tdf#105672 framework managed menu buttonMaxim Monastirsky
This adds a menu button that can use a popup menu controller to manage its menu. It supports 2 cases: - Use any controller that is registered in Controller.xcu, by specifing its .uno command. - Manage an arbitrary popup menu with MenuBarManager (assuming its items have proper .uno commands in their MenuItemData::aCommandStr). It means that a menu that was defined in a .ui file, can be used inside that .ui file without any additional code. This commit uses the new control to fix some currently non-working buttons in Calc's Notebookbar (but there are more that can be fixed the same way). It's not clear how long we will continue to use buttons (instead of toolboxes) for the Notebookbar, but hopefully this control will be useful in other places too. Change-Id: Ie00cde7cd7e39948948960ca2eff76e9db837109 Reviewed-on: https://gerrit.libreoffice.org/34103 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-02-09tdf#105447 Move accelerator to first letters in Help menuYousuf Philips
Change-Id: I14088435228a989cb388cb9e205dc7fcd3fbbfa9 Reviewed-on: https://gerrit.libreoffice.org/33646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-02-09tdf#98993 cui: Paragraph dialog: decimals in Line Spacing spinboxMichael Stahl
For whatever reason, this also makes the +/- buttons increment by 1pt instead of the previous 10pt, which is also an improvement. (presumably regression from 324141f21bf2280d7613c4056ee8cd997ea345f9) Change-Id: If47dd768b2faea760d9967a73453d3f714c65fe3
2017-02-09add IMSINH, IMSQRT,IMSUB,IMSUM,IMTAN test caseZdeněk Crhonek
Change-Id: I02e4517948a300f0c8753bbccb2f1980dcc3ae2c Reviewed-on: https://gerrit.libreoffice.org/34102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-02-09tdf#91596 sw: make Format All Comments persistentMichael Stahl
Change-Id: I8f9a20084d2dc8abd7699f64307b81321699498c
2017-02-09use proper message passingBjoern Michaelsen
Change-Id: Ic41c7acc73c2d275dfdb6b2ffcbb24fba5f8be72 Reviewed-on: https://gerrit.libreoffice.org/33980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-09use std::unique_ptrJochen Nitschke
Change-Id: I6d80d47dcc40daf2749eeec58a7ca19d09c4b803 Reviewed-on: https://gerrit.libreoffice.org/34045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09-Werror,-Wunused-macrosStephan Bergmann
Change-Id: I06a6b6fa51fe437661610a4a678cd2d410bb1e4c
2017-02-09Dummy implementations of backtrace/backtrace_symbols on Android, tooStephan Bergmann
pt#2 Change-Id: I5cc280613879786bd723019d630edb5a920419b9
2017-02-09loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: I5b344a92f4d762517529fb43fb68e849a7c0a619
2017-02-09and more unit tests for tdf#103890Eike Rathke
Change-Id: I342b11cb1442ff5ad4a51d8b8f2f7ed9f081bcaa
2017-02-09yet more 3D flag to preserve cases, tdf#103890 follow-upEike Rathke
Change-Id: I8b8cdb01325d0cd54e436c1043c243eedfddbfb0
2017-02-09add absolute sheet reference unit test for tdf#103890Eike Rathke
Change-Id: Idb4a182a548efe00be66194ba38655baeb80069f
generated by cgit (git 2.34.1) at 2024-08-15 18:56:08 +0000