summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-02loplugin:stringadd in tools..unotoolsNoel Grandin
Change-Id: I441a5ccef6adc8be8029178e304ff3044e812e2a Reviewed-on: https://gerrit.libreoffice.org/79986 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-02loplugin:stringadd in svxNoel Grandin
Change-Id: I47944e589c5261d26d5ef0c116a9173bf6ed1f03 Reviewed-on: https://gerrit.libreoffice.org/79983 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-02loplugin:stringadd in svtoolsNoel Grandin
Change-Id: Ic085990173051f421d1ffc7914574cb63a7ae21d Reviewed-on: https://gerrit.libreoffice.org/79982 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-02tdf#127858 Assertion when trying to edit a form (gen backend)Noel Grandin
regression from commit 78b9dac2ee77bf6efc1298962cbeca284db5b00a remove internal use of 16-bit packed formats we are trying to create a 32-bit image in drawinglayer::primitive2d::createDefaultCross_3x3 Change-Id: Iaf19326b1e2c11c5d535dd8f317086bebbaaebec Reviewed-on: https://gerrit.libreoffice.org/79948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-02Resolves tdf#127508 - Flat table header in CalcHeiko Tietze
Shading removed to comply with the zeitgeisty flatness Change-Id: I766d86dc8d26191fa87c94d3e8f64feda79c3030 Reviewed-on: https://gerrit.libreoffice.org/79584 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-02Refactoring of the class CrashReporterJuergen Funk
- remove double code - using of all the methode of the CrashReporter-Class - all methode only active when crash-dump enable except the addKeyValue With this change the handling for the patch tdf#127711 A runtime-switch for the MiniCrashDump would be simpler Change-Id: I339b3b8e06f7fc2cd3c0d34ece112a6fd352913a Reviewed-on: https://gerrit.libreoffice.org/79272 Tested-by: Jenkins Reviewed-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de>
2019-10-02tdf#122570 Make Enter key work in autofilter search items inputJim Raykowski
Fixes regression introduced by patch for tdf#122774 Change-Id: I24fc8a32cbb660027fb40fb017d03567e784aa77 Reviewed-on: https://gerrit.libreoffice.org/79815 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-10-02tdf#124601 sw FollowTextFlow: fix vert pos of objects outside the current cellMiklos Vajna
There were two problems here: 1) CalcHeightWithFlys() considered all follow-text-flow objects when determining the cell size, while wrap-through objects should never influence the layout of text (i.e. when they conflict, the second should have priority). 2) Once the cell had correct height, the oscillaction described in the SwFlyFreeFrame::CheckClip() comment started. Such a position update was already disabled for headers, but footers have exactly the same problem. In the case of the bugdoc, we jumped between 14618 and 14744 twips, till finally layout loop control kicked in. [ FollowTextFlow is meant to be same behavior as Word's layoutInCell shape property, so this is expected to improve rendering of existing documents. It's not likely that any user would opt in for FollowTextFlow to have the old close-but-not-exactly-matching behavior. ] Change-Id: I6b3b672fc82c6c67dbbdd35c349613fe4cda610d Reviewed-on: https://gerrit.libreoffice.org/79980 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-02tdf#79007: PPTX: reset Contrast and Brightness when we map...Xisco Fauli
...MSO 'washout' to our watermark colormode After d151ed35ad4c4e7aa9fbb807930fcf91dea2eba7, Contrast and Brightness was reset only in writer, so do it earlier for Impress and Writer Change-Id: Icaf2b565880e31d86e09e2f56bac25eba52c8467 Reviewed-on: https://gerrit.libreoffice.org/79905 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-10-01external/boost: clang-cl cannot use MSVC's ATOMIC_FLAG_INITStephan Bergmann
The C++ standard leaves it unspecified how ATOMIC_FLAG_INIT is defined, and at least MS Visual Studio 2017 version 15.9 defines it as {0}, asking for list- initialization, but std::atomic_flag is no aggregate (it has a default ctor) and has no suitable ctor for that initializer list. Other standard library implementations solve that by e.g. adding a std::atomic_flag ctor taking a bool parameter, and defining ATOMIC_FLAG_INIT as std::atomic_flag(false); but MSVC apparently relies on some non-standard behavior here that allows to initialize std::atomic_flag from {0}. But that is apparently not supported by clang-cl, causing failures like > [build CXX] workdir/UnpackedTarball/boost/libs/locale/src/shared/date_time.cpp > In file included from workdir/UnpackedTarball/boost/libs/locale/src/shared/date_time.cpp:11: > In file included from workdir/UnpackedTarball/boost\boost/thread/locks.hpp:10: > In file included from workdir/UnpackedTarball/boost\boost/thread/lock_algorithms.hpp:11: > In file included from workdir/UnpackedTarball/boost\boost/thread/lock_types.hpp:18: > In file included from workdir/UnpackedTarball/boost\boost/thread/thread_time.hpp:9: > In file included from workdir/UnpackedTarball/boost\boost/date_time/time_clock.hpp:17: > In file included from external/boost/include\boost/shared_ptr.hpp:27: > In file included from workdir/UnpackedTarball/boost\boost/shared_ptr.hpp:17: > In file included from workdir/UnpackedTarball/boost\boost/smart_ptr/shared_ptr.hpp:36: > workdir/UnpackedTarball/boost\boost/smart_ptr/detail/spinlock_pool.hpp(77,5): error: no matching constructor for initialization of 'std::atomic_flag' > BOOST_DETAIL_SPINLOCK_INIT, BOOST_DETAIL_SPINLOCK_INIT, BOOST_DETAIL_SPINLOCK_INIT, BOOST_DETAIL_SPINLOCK_INIT, BOOST_DETAIL_SPINLOCK_INIT, > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > workdir/UnpackedTarball/boost\boost/smart_ptr/detail/spinlock_std_atomic.hpp(81,38): note: expanded from macro 'BOOST_DETAIL_SPINLOCK_INIT' > #define BOOST_DETAIL_SPINLOCK_INIT { ATOMIC_FLAG_INIT } > ^~~~~~~~~~~~~~~~ > C:/PROGRA~2/MIB055~1/2017/COMMUN~1/VC/Tools/MSVC/1416~1.270/Include\atomic(158,26): note: expanded from macro 'ATOMIC_FLAG_INIT' > #define ATOMIC_FLAG_INIT {0} > ^~~ > C:/PROGRA~2/MIB055~1/2017/COMMUN~1/VC/Tools/MSVC/1416~1.270/Include\atomic(169,2): note: candidate constructor not viable: no known conversion from 'int' to 'const std::atomic_flag' for 1st argument > atomic_flag(const atomic_flag&) = delete; > ^ > C:/PROGRA~2/MIB055~1/2017/COMMUN~1/VC/Tools/MSVC/1416~1.270/Include\atomic(168,2): note: candidate constructor not viable: requires 0 arguments, but 1 was provided > atomic_flag() noexcept = default; > ^ The internals of external/boost appear to be the only place where we currently use ATOMIC_FLAG_INIT, and we can work around that easily by picking a different backend in boost/smart_ptr/detail/spinlock.hpp for the problematic combination of Clang and _MSC_VER 1916 (which may need to be extended to further MSVC versions). Change-Id: Ie6aa62556efbedd3897ad7803b546cb8088ebe10 Reviewed-on: https://gerrit.libreoffice.org/79967 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01CXX_X64_BINARY must be clang-cl not cl when building with clang-clStephan Bergmann
...to avoid failures like > [build CXX] shell/source/win32/spsupp/registrar_x64.cxx > cl : Command line error D8021 : invalid numeric argument '/Wendif-labels' after 58ef8c188b6bb2ed307f5e825cc7e475c33d0c33 "Make spsupp*.dll usable on 64- bit Windows". This is a bit of a hack, relying on CXX being passed in via autogen.input in my clang-cl build. Ideally, the code would be reorganized so that CXX_X64_BINARY is only set after CXX has been set. Change-Id: Ia2c823ad6b917218858ea541cc6a65fa423e3a09 Reviewed-on: https://gerrit.libreoffice.org/79959 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:logexceptionnicely (clang-cl)Stephan Bergmann
Change-Id: I2da126a38db61d2a0f36f8f2d38b0dddeb26c9d4 Reviewed-on: https://gerrit.libreoffice.org/79929 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01Use --with-sytem-cairo for the ASan+UBSan tinderbox againStephan Bergmann
After 1ae450504cf57457f9702684b1517fda1dd3c481 "drop gtk2 support" removed the implicit --enable-gtk which removed the implicit --with-system-cairo, <https://ci.libreoffice.org/job/lo_ubsan/1402/> started to fail with > [build LNK] Executable/canvasdemo [...] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libcairo.so.2: undefined reference to `__muloti4' [...] > clang-9: error: linker command failed with exit code 1 (use -v to see invocation) > /home/tdf/lode/jenkins/workspace/lo_ubsan/solenv/gbuild/LinkTarget.mk:635: recipe for target '/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/Executable/canvasdemo' failed etc. Instead of trying to fix that, just explicitly build --with-system-cairo again. (Another approach could be to --enable-gtk3, which implicitly sets --with-system-cairo, too.) Change-Id: I335b2a694b85a15efae6002d890ce0d67811b2bb Reviewed-on: https://gerrit.libreoffice.org/79962 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01When building with clang-cl, nevertheless use MSVC's CXXFLAGS_CXX11 for CLRStephan Bergmann
...which is built with MSVC after all. 0a99b5a1b7325454fe3d1174d44354888aa22012 "When building with clang-cl on Windows, build CLR code with MSVC" had happened to get away with passing a bogus -Xclang -std=... (which cl then ignores) instead of /std:c++17, but nowadays the build fails with things like > [build CLR] cli_ure/source/climaker/climaker_app.cxx [...] > cl : Command line warning D9002 : ignoring unknown option '-Xclang' > cl : Command line warning D9002 : ignoring unknown option '-std=gnu++2a' > string_view is only available with C++17 or later. > include\rtl/stringconcat.hxx(232): error C2429: attribute 'nodiscard' requires compiler flag '/std:c++17' [...] This is a bit of a hack, using hardcoded values for now. Ideally we would capture MSVC's CXXFLAGS_CXX11 in an additional variable in configure.ac, and do a subst from CXXFLAGS_CXX11 to MSVC's CXXFLAGS_CXX11 here. Change-Id: Ifde367c7d1c3db57e75a6ccadc82d534bcb13d0a Reviewed-on: https://gerrit.libreoffice.org/79961 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01-Werror,-Wswitch (clang-cl)Stephan Bergmann
Change-Id: I3d40104d6822ebb80ebec44b36bcdfa5c7e953ed Reviewed-on: https://gerrit.libreoffice.org/79960 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01tdf#124983 In calc make printable page borders also initially visibleIlhan Yesil
If option "LibreOfficeDev Calc/View/Page breaks" is enabled, breaks should be visible. But if the document is opened the first time, the breaks are not calculated yet and therefore not visible. Change-Id: I651e4df4a9c292aa953888498a5c9d0fb5b8c8d2 Reviewed-on: https://gerrit.libreoffice.org/75355 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-10-01Avoid unnecessary iterations in for loopMuhammet Kara
Change-Id: I9f2d0fba4754b8d4db906012dc1429640fe444b5 Reviewed-on: https://gerrit.libreoffice.org/79944 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-10-01tdf#119021 Support lock down settings of Formula tab pageGabor Kelemen
Change-Id: I3131e8fd98b43cf4073970444589e8fae9553bc1 Reviewed-on: https://gerrit.libreoffice.org/75402 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-10-01loplugin:returnconstval (clang-cl)Stephan Bergmann
Change-Id: Ib3c3e32bd998ac7e29f45cc4ce511a863096c3b5 Reviewed-on: https://gerrit.libreoffice.org/79958 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:returnconstval (clang-cl)Stephan Bergmann
Change-Id: Id1bcc878f40fba804f78f7a5b7cd463db8dc5988 Reviewed-on: https://gerrit.libreoffice.org/79957 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:noexceptmove: Cater for null FunctionDecl::getBodyStephan Bergmann
...which can happen for function templates with clang-cl, leading to false warnings like > [build CXX] codemaker/source/commoncpp/commoncpp.cxx > In file included from codemaker/source/commoncpp/commoncpp.cxx:25: > In file included from include\codemaker/typemanager.hxx:28: > include\rtl/ref.hxx(126,5): error: move operator= can be noexcept [loplugin:noexceptmove] > Reference<reference_type> & > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I541c7c3d86d05964834e3e5cf678c8f1145ea132 Reviewed-on: https://gerrit.libreoffice.org/79956 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01should be original colors, not original sizeCaolán McNamara
Change-Id: I032489f773cc9fad0d2cafabb1c39a663180f0f9 Reviewed-on: https://gerrit.libreoffice.org/79955 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-01SmartArt edit UI: fix crash on empty node textGrzegorz Araminowicz
Change-Id: Idacbbb50cbdd8ae4c78f3159bc362c7ee2137149 Reviewed-on: https://gerrit.libreoffice.org/79848 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-10-01remove empty GtkSizeGroupsCaolán McNamara
Change-Id: I848fc4a9f97b4cc7cd5243bcf328fb6f8fbdd5be Reviewed-on: https://gerrit.libreoffice.org/79861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-01-Werror,-Wreturn-std-move (clang-cl)Stephan Bergmann
Change-Id: I74d595e1480c421c5cad4095203270578acf9521 Reviewed-on: https://gerrit.libreoffice.org/79947 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01-Werror,-Wunused-macros (clang-cl)Stephan Bergmann
(WIN32_LEAN_AND_MEAN is also defined in include/prewin.h) Change-Id: Ie5e134909f4381d24f2406aa292fa46979c49ca6 Reviewed-on: https://gerrit.libreoffice.org/79946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:external (clang-cl, HasAtHook), againStephan Bergmann
...after d00ee2cb0dce84173c035cf89f332c150dd02d00 "tdf#42949 Fix IWYU warnings in vcl/source/[a-e]*" Change-Id: I5a118cab222d32f5891f9e6ede44e1cded5985b0 Reviewed-on: https://gerrit.libreoffice.org/79942 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:refcounting (clang-cl)Stephan Bergmann
Change-Id: Ifae4a5617e6fcad58319ee3854b20224c4099e1b Reviewed-on: https://gerrit.libreoffice.org/79941 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01Silence -Werror,-Wmissing-field-initializers (clang-cl)Stephan Bergmann
Change-Id: I4c6a820a91f620e9677f6a946265c38e9ca6ef73 Reviewed-on: https://gerrit.libreoffice.org/79933 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:sallogareas (clang-cl)Stephan Bergmann
Change-Id: I4fd32d006299cfb7ed856e5e8ef8bfd7a680fc6c Reviewed-on: https://gerrit.libreoffice.org/79940 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:unnecessaryparen (clang-cl)Stephan Bergmann
Change-Id: Ief84a2e87bd8bb3cbdb753fdb5bec6e57cf38116 Reviewed-on: https://gerrit.libreoffice.org/79939 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:loopvartoosmall (clang-cl)Stephan Bergmann
Change-Id: I682fccecd94d1d1524fcb12e93f5d53b0c94ea03 Reviewed-on: https://gerrit.libreoffice.org/79935 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:referencecasting (clang-cl)Stephan Bergmann
Change-Id: Ie534212b09b92a02b377d0bb348e11c96bf61786 Reviewed-on: https://gerrit.libreoffice.org/79934 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01Implement parallel version of super-scalar-sample-sort...Dennis Francis
and use it for the pivot table construction routine processBuckets(). The implementation uses ideas from the non-parallel sample sort discussed in the below paper, but parallelizes the "binning"/"classification" operations and the sorting of the bins themselves. Sanders, Peter, and Sebastian Winkel. "Super scalar sample sort." European Symposium on Algorithms. Springer, Berlin, Heidelberg, 2004. which can be accessed at : http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.72.366&rep=rep1&type=pdf Change-Id: I3723b87e2feb8d7d9ee03f71f6025e26add914ce Reviewed-on: https://gerrit.libreoffice.org/79486 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-01Thread a group of formula-groups together if possibleDennis Francis
Just before about to thread a FG, look to left and right for "mutually" independent FG's with some restrictions and thread this group of FG's together treating it as a single but longer computation load. For now the restrictions are :- All formula-groups in a FG "group" must have :- 1. Same length 2. Same relative position. 3. Same weight. This is very helpful in cases similar to the below : There are lots of (say 32) consecutive formula-groups all with same "small" length (say 8) and same weight. By conventional formula-group-threading the speed-up is limited to 8x even if we have a 256 core processor, but with this threading-multiple-formula-groups patch (in this case) we can get a speed-up of 256x provided we have a >= 256 core machine. So effectively with this patch the speed-up is now only limited to the number of cells in a range consisting of mutually indepdendent formula-groups rather than number of cells in each formula-group. Change-Id: Ib25b5abbb583fa207e8befff9a908d14313f3d51 Reviewed-on: https://gerrit.libreoffice.org/79485 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-01Silence a supposedly unproblematic loplugin:badstatics (clang-cl)Stephan Bergmann
Change-Id: I9c76fb4aca21757a0bf033103bd6dc2bea740eb5 Reviewed-on: https://gerrit.libreoffice.org/79932 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01jsdialogs: send selection for listboxSzymon Kłos
Change-Id: Ie5e026da0a4ca95df8fe52a6bf7967dc93b3d869 Reviewed-on: https://gerrit.libreoffice.org/79805 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01loplugin:redundantcast (clang-cl)Stephan Bergmann
Change-Id: I0682989cdc9528d26925c7770b78fd455c0be396 Reviewed-on: https://gerrit.libreoffice.org/79931 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:redundantcast (clang-cl)Stephan Bergmann
Change-Id: I3f66a7850b4604dee576aeb61a39c4e45563d0c1 Reviewed-on: https://gerrit.libreoffice.org/79930 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01tdf#42949 Fix IWYU warnings in ucb/source/*/*hxxGabor Kelemen
Note: to build ucb/source/ucp/webdav one needs to use the --with-webdav=serf configure option Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6da50aeeea0c05d49b8b9eadf67ab91d3d250f41 Reviewed-on: https://gerrit.libreoffice.org/79577 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-01tdf#81100 DOCX: keep "repeat table header" table style settingLászló Németh
during round trip by grab-bagging //tblStylePr/trPr/tblHeader. Change-Id: Id9d3150ca48031791aeda19c126bc4d4ac16fb8f Reviewed-on: https://gerrit.libreoffice.org/79597 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-10-01jsdialogs: send JSON to the clientSzymon Kłos
Change-Id: If43a774e1e3a4bff4a8ec862f0091d60477090d4 Reviewed-on: https://gerrit.libreoffice.org/79803 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01uitest: make child soffice process die when parent diesNoel Grandin
using PR_SET_PDEATHSIG. Note that this can only be called by the child process in question, so we have to pass a new command line argument down to activate it. And we have to plumb it through the wrapper oosplash process. I wonder where else our testing infrastructure could benefit from this Change-Id: I55e8e9f7f4e6cc415046df04c804e51475b8a4c9 Reviewed-on: https://gerrit.libreoffice.org/79854 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-01Removed executable permission on fileAndrea Gelmini
Change-Id: I6408d8c0d2c7dec30187a147501e19ef6ac86527 Reviewed-on: https://gerrit.libreoffice.org/79969 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-01loplugin:indentation (clang-cl)Stephan Bergmann
Change-Id: I19750bd9ac4c77c88097210626fd0c3dfa510a7a Reviewed-on: https://gerrit.libreoffice.org/79928 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01lok jsdialogs: Add handling of checked state for checkbox and radiobutton.Jan Holesovsky
Change-Id: Id64833a08c62388220921208cba33a60c178e9ac Reviewed-on: https://gerrit.libreoffice.org/79797 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01Remove spurious #include <unistd.h>Stephan Bergmann
(which appears to be unused and caused compilation failure on Windows) Change-Id: Ice6882d98da3bac1f53e869b73ab179df93280fa Reviewed-on: https://gerrit.libreoffice.org/79925 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01tdf#123628 DOCX export: fix color change of unvisited hyperlinksTünde Tóth
by exporting the character style name "Hyperlink" requested by Word instead of the previous "Internet Link" to allow unvisited/visited color change at opening the link in the document editor. Change-Id: Ib5e22f8f26a6f3c71543d6e5410d6cc263b83830 Reviewed-on: https://gerrit.libreoffice.org/79855 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-10-01Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - redmine#2555 replace Help online Google search This is the helpcontent2/ part of the patch. Add xapian-omega search to online Help. The patch replaces Google custom search with xapian-omega search. A new build key is introduced. --with-omindex=server : Localizes and adds the xapian result page template, adds the xapian form to each Help page. --with-omindex=noxap : do not localize the result template and do not add a form in the Help page. --with-omindex= will force Online Help build. Default is noxap NOTES: - xapian-omega databases are built in the server. - searches returns results only on localized Help pages, avoiding same resulis in many languages. TODO: - Tweak the xapian-omega result page CSS and markup. Change-Id: I3dc2b79c4111f61fd5fea01b1f8c95bfacab1e8f Reviewed-on: https://gerrit.libreoffice.org/79366 Tested-by: Jenkins Reviewed-by: Guilhem Moulin <guilhem@libreoffice.org> Tested-by: Guilhem Moulin <guilhem@libreoffice.org>
2019-10-01redmine#2555 replace Help online Google searchOlivier Hallot
This is the core/ part of the patch. Add xapian-omega search to online Help. The patch replaces Google custom search with xapian-omega search. A new build key is introduced. --with-omindex=server : Localizes and adds the xapian result page, adds the xapian form to each Help page. --with-omindex=noxap : do not localize the result template and do not add a form in the Help page. --with-omindex will force Online Help build. Default is noxap NOTES: - searches returns resuls only on localized Help pages, avoiding same resulis in many languages. -xapian-omega databases must be built in server TODO: - Tweak the xapian-omega result page CSS and markup. Change-Id: I5e3fe4191a3b054e3b6403f7cb5640953d92ba42 Reviewed-on: https://gerrit.libreoffice.org/79368 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-07-01 16:52:16 +0000