summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-09-09Drop unused ooXMLFileFormat* config keysGabor Kelemen
These are unused since 2013, see: https://cgit.freedesktop.org/libreoffice/core/commit/?id=041d2b88a473cc7ba9b68113f7642dd8417369e4 https://cgit.freedesktop.org/libreoffice/core/commit/?id=abd3338486a515380d50c4ee5f4ab242fb5fd4bd Change-Id: I0265b476797f0be6703fbf710f0baf983c47d489 Reviewed-on: https://gerrit.libreoffice.org/41216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-09tdf#112278: Pivot table: filtering of non-string fields is not exported to XLSTamás Zolnai
It is needed to use the right string representation of field value. During export this representation is available directly, next to the actual value. During import we can use the number format attached to the corresponding pivot field. Change-Id: Ie8f731f6c72d7f55f43c318e52d63dc4e993d9c0 Reviewed-on: https://gerrit.libreoffice.org/42069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-09tdf#108572 remove connections only for current shellSzymon Kłos
Also remove connections to temp files. Change-Id: Ie5c09eb365d1246e053dc52884c72687ac226f3c Reviewed-on: https://gerrit.libreoffice.org/42095 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-09Updated coreOlivier Hallot
Project: help 6005c5c31ca8e9f9107c5c0e35858d27e4a55490 Add better support for <bascode> in helponline Insert a div around a code snippet and categorize for schema.org Change-Id: I7d4c9e15fccbf7e48af3c2faca9ed61ae5279c79 Reviewed-on: https://gerrit.libreoffice.org/42105 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-09Avoid underflow of unsigned integer which leads a false error messageTamás Zolnai
Change-Id: Ica65a96efe44fb46e25c224298aaff4cd7a40fa6 Reviewed-on: https://gerrit.libreoffice.org/42120 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-09tdf#112289 OSX fpicker: don't default to trueJan-Marek Glogowski
When LO requests a value for the currently unimplemented GPG encryption checkbox, the Aqua file picker defaults to a "uno::Any <<= true", which triggers the GPG key dialog. This simply returns an empty uno::Any for values of unknown controls, which is handled fine. If something else relies on the current default value, it must to be properly implemented. Change-Id: I3637ca833d59e19416e25f3096bc90a756aa8840
2017-09-08tdf#108722 vcl: fix bugs in TextEngine with TEXTATTR_PROTECTEDMichael Stahl
1. If the cursor is at the end of the paragraph, attributes ending at that position are skipped in TextEngine::FindCharAttrib(). 2. If a TEXTATTR_PROTECTED is found, TextView::KeyInput() retains the selection that was extended to cover the attribute after deleting the text, because it compares to the initial selection. Why delete/backspace keys only work with the "gtk" vcl-plug but not "gtk3", "gen" or "kde4" is a mystery to me. Change-Id: Id7a6f298332f5a99454c793dd2dd6d424a975ad4
2017-09-08sc-perf: do not add a million empty filter entries just to sort and discardEike Rathke
Which can happen if an (anonymous) database range as filter range was selected to span an entire column of which most (the tail) is empty cells. The entries are processed to be unique anyway. This significantly shortens the time to display the filter dialog. Happened with attachment http://bugs.documentfoundation.org/attachment.cgi?id=136074 of bug https://bugs.documentfoundation.org/show_bug.cgi?id=112258 Change-Id: Ia169911d6f23611a3b3ecbf291757465f1998210 Reviewed-on: https://gerrit.libreoffice.org/42118 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-08svl: assert calls of SfxPoolItem::Create/StoreMichael Stahl
Change-Id: I2d92897d558ad0914e8bbc80b4dec72d0fd00629
2017-09-08clang-tidy modernize-use-emplace in b*Noel Grandin
Change-Id: I51e0369ba2e1fe0b7c934531f71d3bda95ba09ec Reviewed-on: https://gerrit.libreoffice.org/42109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08EPUB export: avoid writing image/x-vclgraphic to the output fileMiklos Vajna
The spec has a fixed list of allowed MIME types. Change-Id: I99a3121e41a2f6a3d0c5a040d66302161b16b0fb Reviewed-on: https://gerrit.libreoffice.org/42116 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-08EPUB export: handle section contentMiklos Vajna
Just the minimum so content is not completely ignored on export. Change-Id: I2880780ed3ce5d1dd15adbd9222296f52a5e7c3d Reviewed-on: https://gerrit.libreoffice.org/42115 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-08Document baselinesJan-Marek Glogowski
Change-Id: I32c8b027abec13805fcb4fc244c7eca00e0c6fee Reviewed-on: https://gerrit.libreoffice.org/42072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-08EPUB export: inherit text properties in spans from paragraphMiklos Vajna
This is similar to nested spans, but here the outer element is a paragraph. Change-Id: Ibcdfe5aac54a44797067b06d319d19d2d47d5dd1 Reviewed-on: https://gerrit.libreoffice.org/42104 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-08external/openldap: Update config.{guess,sub}Stephan Bergmann
...with versions of those files from the latest <http://ftp.gnu.org/gnu/automake/automake-1.15.tar.xz>. The current versions failed for a Flathub aarch64 test build, see <https://flathub.org/builds/#/builders/6/builds/304>. Change-Id: I782371c88cf1c46bdee4f14a82b58f673f40e982
2017-09-08-Werror,-Wtautological-compare with latest clangNoel Grandin
Change-Id: I073f1893b759f8d31a24187f542b031b86dc4b8a error: comparison of unsigned enum expression >= 0 is always true [-Werror,-Wtautological-compare] Reviewed-on: https://gerrit.libreoffice.org/42103 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08clean up SdrDragStatNoel Grandin
- some light formatting in the header file - change aPnts from std::vector<Point*> to std::vector<Point>, no point in dynamically allocating a small value class - rename aPnts -> mvPnts - use std::unique_ptr for userdata - rename pUser to mpUserData - change some methods protected->private, since nothing external is using them Change-Id: I7a3f4c30c60ae1be3713f460fe65de95bed2f124 Reviewed-on: https://gerrit.libreoffice.org/42102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08EPUB export: fix double escaped NBSPMiklos Vajna
The EPUB package interface already XML-escapes characters, avoid a double escape. And once that works, handle NBSP/tabs. Change-Id: I8b7bbdc2592096bdd46fbdb29b48b723ef5cf990 Reviewed-on: https://gerrit.libreoffice.org/42098 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-08Inspecting children is only necessary if parent is selectedEike Rathke
Change-Id: I9980bef27442504f59f5a85e655a761c5d35a012
2017-09-08svx: Make SdrDragStatUserData's dtor pure virtualTakeshi Abe
to clarify that it is an abstract base class, and to avoid memleak when deleting derived instance as pUser in SdrDragStat::Clear(). Change-Id: I39670841fda1ea3c45698585ce50aec944e0d4ab Reviewed-on: https://gerrit.libreoffice.org/42097 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08If children then insert only if a child is selected, tdf#112258 follow-upEike Rathke
Otherwise the chain down to the parent would be pickable, though in practice it doesn't have a consequence as only leaves are picked. However, inserting to the set can be avoided. Change-Id: I6a6b63b2d7c031a2dd13d8cc7d98f15e1f946298
2017-09-08upload poppler 0.59.0David Tardon
Change-Id: I21dfa3aa04bd960cb2fb87a53213ae4bbd510a24 Reviewed-on: https://gerrit.libreoffice.org/42061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-09-08Actually this would be better as SAL_WARN.Jan Holesovsky
Change-Id: I11c92f451ec5dcc77a7dadb948c61680c3cce444
2017-09-08tdf#112074 doc export: re-calculate indent for RTL tableJustin Luth
In MSO tables, the only side that can have an indent is the logical left orientation. In right-to-left tables, the indent is measured from the physical right margin. So, we need to re-calculate LO's physical LEFT_AND_WIDTH indent to measure the distance from the right margin to the table. Importing already expects this recalculated indent. Change-Id: I9b8b7078aea8b7800cd31fbc11e2f27bd051be7d Reviewed-on: https://gerrit.libreoffice.org/41666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-08convert pEntryLists to std::array<std::unique_ptr<...Noel Grandin
Change-Id: Ibe5d97c7a5138f1fd47cb2419c33b8f78ff1559c Reviewed-on: https://gerrit.libreoffice.org/42094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08set parent for file dialog helperCaolán McNamara
Change-Id: I3994ee48dcb5b2732cb27cb9ccb54926abf0828a Reviewed-on: https://gerrit.libreoffice.org/42048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-08sw: inline trivial IS_FLYS macroMiklos Vajna
Change-Id: If3f62fb6ad7e5ce7e3fb7fb728acdf53010ba76d Reviewed-on: https://gerrit.libreoffice.org/42092 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-08Disable test on Linux x86 that makes plain 'make' fail due to -mpfmath=387Stephan Bergmann
...rounding issues, and thus caused LO Flathub builds to fail, see <https://flathub.org/builds/#/builders/3/builds/280>. Change-Id: I91e8662e0a85b4ed8b16719eed4ade3397edfa0c
2017-09-08tdf#110737 set user-events to a lower priority than system redrawCaolán McNamara
Change-Id: Ic6672fcce4cb5516d388fee22120383ccc70a4a5 Reviewed-on: https://gerrit.libreoffice.org/42066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-08loplugin:unusedmethodsNoel Grandin
Change-Id: Idba437cf35606e782e94c020c8ac3bb265703d00 Reviewed-on: https://gerrit.libreoffice.org/42091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08loplugin:unusedfieldsNoel Grandin
Change-Id: Ie26c52090d984c40cc108c9f20eb2ba31a866796 Reviewed-on: https://gerrit.libreoffice.org/42090 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08oovbaapi: create XOval and XLine shape typesTamas Bunth
This is needed in order to make "TypeOf myLine Is Line" or similar expressions return the expected "true" value. The implementation of the basic interpreter of TypeOf uses XTypeProvider to determine the type of an object by getting the last part of the type name. E.g. "ooo:vba::msforms::XLine" is determined as a "Line". That's why I created the XLine and XOval blank classes. TypeOf doc: https://docs.microsoft.com/en-us/dotnet/visual-basic/language-reference/operators/typeof-operator Change-Id: Ia49cc92d672e30d0126f02d61a55a956ac1425f0 Reviewed-on: https://gerrit.libreoffice.org/42083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-09-08loplugin:constantparamNoel Grandin
Change-Id: Ic87f0cc863490858b7cc7e74a7f90ec31992dd53 Reviewed-on: https://gerrit.libreoffice.org/42089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08ZLIB_LIBS must be passed into external/cairo as LIBS, not LDFLAGSStephan Bergmann
Change-Id: I76bd966d6932b3b3210d04137f18f928276ce631
2017-09-07svtools: HTML import: don't put lone surrogates in OUStringMichael Stahl
The bytes "ed b3 b5" in fdo67610-1.doc (which, as the name indicates, is an HTML file) are converted to the lone UTF-16 surrogate "dcf5", which is inserted into SwTextNode and causes asserts later on. The actual encoding of the HTML document is probably GBK (at least VIM doesn't display any missing characters with that), but because it doesn't contain any indication of its encoding it's apparently imported as UTF-8; the ImplConvertUtf8ToUnicode() thinking a surrogate code point is valid even if the JSON-compatible mode RTL_TEXTENCODING_JAVA_UTF8 is not specified is a bit of a surprise. Change-Id: Idd788d9d461fed150171dd907439166f3075a834
2017-09-07SvTreeListBox: turn some DBG_ASSERT() into assert()Eike Rathke
Change-Id: I14cd42d816cfd6fcc7f0fc3f32ece09e10d3137f
2017-09-07tdf#112280: Unit test.Jan Holesovsky
Change-Id: I70d7f388c1573ed34bb3d93b480fe1ccaa97076f Reviewed-on: https://gerrit.libreoffice.org/42075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-09-07tdf#112280: Export spin animation in PPTX.Jan Holesovsky
Change-Id: I9f13bbc2bd3a3de582491ea5b2ad16535589420a Reviewed-on: https://gerrit.libreoffice.org/42074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-09-07Resolves: tdf#112258 correctly pick items from AutoFilter selectionEike Rathke
Combining only one child with one parent to lookup is not sufficient if we have year,month,day chains. The entire chain is needed. Regression from commit 2a39dc74724d3648ff76aa900edfebe0dd19b296 Date: Thu Jun 1 18:27:13 2017 +0200 tdf#108259 Fix nested checkbox handling in autofilter popup and commit 511fb8e80d298d42f5c45e7410bf64f2a25b441e Date: Wed May 31 10:59:42 2017 +0200 tdf#108259 Enable autofilter with many different values which combined landed in 5.4 as commit 0163957ef808cffa332c2ddd3267409c5ae1494a Date: Wed May 31 10:59:42 2017 +0200 tdf#108259 Enable autofilter with many different values This on the other hand makes the change of these doubtful, as for each leaf item the concatenation and the lookup has to be done. Something to be investigated. Change-Id: I07fd6367bb8da2adab94a43c45fe88391179f496
2017-09-07tdf#90556 android: make buildID in about a clickable link to git logChristian Lohmaier
that will allow them to deduce the age of the build Change-Id: Ic1baffbf1ecc6a743a1edd91d24c86670dc640a3 Reviewed-on: https://gerrit.libreoffice.org/41962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-09-07android: drop workarounds for ndk-gdb support (can still run manually)Christian Lohmaier
packing gdbserver into apk conflicts with extractNativeLibs="false", as the gradle pugin compresses it (which could be disabled using aaptOptions), but furthermore it doesn't page-align it, breaking installation. So instead let the user manually push the gdbserver tool to device and remove the hardcoded values that were only there to please the ndk-gdb scripts. Using lldb from within Android Studio is more comfortable anyway :-) Change-Id: I31c3af4847a479c56b3fcd6b5bed114e004bf0d2 Reviewed-on: https://gerrit.libreoffice.org/41950 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-09-07fix nss build for android x86 and remove duplicated configure callChristian Lohmaier
remove hardcoded arm flags for android, and instead of patching the sources, rather specify the desired values on commandline to override nss' makefile defaults where possible. Also since the build stage runs nspr configure by itself in a dedicated outdir, the separate configure step was removed (for all systems). Change-Id: I586c605615cc2d45b757497395a98c53dd1beb1d Reviewed-on: https://gerrit.libreoffice.org/42070 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-09-07unotest.py: refactor confusing mess of openDoc functionsMichael Stahl
Change-Id: I148332c639510c55dea2d09bc7aa695708fbf34c
2017-09-07EPUB export: handle span-level line breakMiklos Vajna
By pulling out common part of the paragraph/span context factory. Change-Id: If5fda87ce9f60e7e10d7f9406c30740bc8707143 Reviewed-on: https://gerrit.libreoffice.org/42064 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-07Fix firebird build with MSVC update 15.3Szymon Kłos
Change-Id: I236f182fd99e19e4ea171ad1bae6c03f1a258c7e Reviewed-on: https://gerrit.libreoffice.org/42060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-07tdf#42982 Improve exceptions in text document apiSamuel Mehrbrodt
* Throw DisposedException instead of RuntimeException when the document has been destroyed * Add messages to RuntimeExceptions Change-Id: I5cc370ed835a0f620596754ac6339d2ef543f6c4 Reviewed-on: https://gerrit.libreoffice.org/42062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-07Fix typosAndrea Gelmini
Change-Id: I855b26e447a8406cbab6f4c7f918b3319debba35 Reviewed-on: https://gerrit.libreoffice.org/42034 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-07sw: oops, forgot to amend that before pushingMichael Stahl
Change-Id: Idaf3d066a61dcf30019eda9f84bb7442362ab57d
2017-09-07sw: fix text_portion_enumeration_test.py on WNTMichael Stahl
This fails, mostly because of confusing native paths and URLs, and because of deleting the temp. directory before closing the file that the test wrote into it. Also, why open the document as a template. Change-Id: I6da2f3f2c47308c4956444869b5b100a124b8db0
2017-09-07configure: find MSVC 2017 MSMs & DLLs againMichael Stahl
They're still called "VC150" in my installation. Change-Id: I0a005236ff5edc758be41616e33b254577144f17