summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-02-03tdf#114635: Add TWAINDSM.DLL to 64-bit Windows packageMike Kaganski
This patch allows us to use our own bundled TWAINDSM.dll (from twain-dsm project, http://www.twain.org, https://github.com/twain/twain-dsm) on 64-bit Windows systems that don't have their own TWAIN DLL, and without requiring users to install it from some other source. The DLL is put into INSTALLOCATION/program along soffice.bin. Of course, TWAIN sources still need to be 64-bit themselves (i.e., true 64-bit TWAIN drivers required) to be usable by 64-bit program. Also this drops external/twain/inc/twain/twain.h, which is an old version copied from twain-dsm, and instead uses the tarball to get the header (required by Library_scn on both 32- and 64-bit Windows). Change-Id: I191027f3221ce46db17f50db91c9cb9315900810 Reviewed-on: https://gerrit.libreoffice.org/46992 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-03Ignore the alpha value in font colors.Kohei Yoshida
Using it would remove the color altogether. Change-Id: I2c14316c9c9c885f4e7615e4057e752a58223227 Reviewed-on: https://gerrit.libreoffice.org/49170 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-02sw: disable ooxmlexport testWatermark on WNTMichael Stahl
This one tends to fail quite a bit in CI builds, at least on Windows, most recently in https://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&brief-log=1517580416.5910 Change-Id: I243b317fb27c51d06fbddf085713e51734eae27a
2018-02-02sw: remove very dubious DBG_UTIL codeMichael Stahl
This looks like some defensive programming to avoid a crash only in DBG_UTIL mode, which is a pretty moronic thing to want to do. Change-Id: I93c791a76cf9114359be3fef6b604c86ec49da51
2018-02-02sw: convert OSL_ENSURE to assert() in SwCacheMichael Stahl
Change-Id: I66075a8f77a3b399116ddd0493037c1427dfd7d2 Reviewed-on: https://gerrit.libreoffice.org/49153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-02Make SAL_WARN domain "sc.filter" in sc/source/filter/lotus/Eike Rathke
Change-Id: I6fd767bd2694369db836bb1943c7135c10fa6aa6
2018-02-02Simplify sortElements in pdfiprocessor (sdext)Julien Nabet
For explanation, see: http://nabble.documentfoundation.org/About-simplifying-sortElements-in-pdfiprocessor-sdext-tt4231909.html Change-Id: I53fb732d776d7152279e5fc1440eafac1cfd71fe Reviewed-on: https://gerrit.libreoffice.org/49127 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-02ofz#5435 sw: fix SwCache::Insert() stale pointersMichael Stahl
If SwCache::Insert() happens to delete the object that m_pFirst or m_pRealFirst point to, which is unlikely as it means every other object is locked, then these pointers must be updated. This sometimes happens in the bugdoc after scrolling around for some time. Change-Id: I13f04d28c37969469efa4e1109c7f5b751ceba96 Reviewed-on: https://gerrit.libreoffice.org/49151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-02ofz#5435 sw: fix crash during painting of excessively nested tablesMichael Stahl
Could not find a single instance where the return value of SwCacheAccess::Get() was actually checked, so let's have SwCache::Insert() automatically resize the cache, since it starts out with just 100 capacity; also, check that the size doesn't overflow. Change-Id: I3cd7cf2aea79e01816b12e4dbaf79c3bf82bf8fe Reviewed-on: https://gerrit.libreoffice.org/49140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-02tdf#45904 Move _SheetCellRanges Java tests to C++Jens Carl
Change-Id: If391071a7e44c2fbeaaa0fa46f6043f30e777cec Reviewed-on: https://gerrit.libreoffice.org/49125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-02-02tdf#45904 Move _SheetCellRange Java tests to C++Jens Carl
Change-Id: Ia4ebe9d0418e33d245437a49c7ce9551b4a06e82 Reviewed-on: https://gerrit.libreoffice.org/49124 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-02-02These fields can be constTor Lillqvist
Change-Id: I7012e0d7b65fbb3317719f24572f77fb9aafd910 Reviewed-on: https://gerrit.libreoffice.org/49143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-02-02sc: disable "forecast.ets.add.fods" test file on MacsMichael Stahl
This sometimes fails, since months, and nobody has fixed it. Let's improve the reliability of CI a bit. Change-Id: Ic4d2e085151855d35804f8ed6ebca04366815c0b Reviewed-on: https://gerrit.libreoffice.org/49144 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-02Clean up of dirty hack.Winfried Donkers
Follow up of tdf#103550. The conversion from half to full width characters and vice versa happens per character according to a table. There is no need to have a separate table with exceptions to the general rule. Change-Id: Id611d1d6074cb2489fb0254d8ba9a83d7c26065f Reviewed-on: https://gerrit.libreoffice.org/49102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-02-02Do not force non-existent parameters into the TokenPool, ofz-relatedEike Rathke
Change-Id: I2fa0ae81b987af592c14486040077c9ff157fab9
2018-02-02Use the {...} notation for configuration provided language tags without nameEike Rathke
As is done for all other on-the-fly tags as well so they group nicely on top of the list. Change-Id: Ib4b759af189386dac98397888ba0bfb8b4bc3bc6
2018-02-02init known ExtraLanguages before document loadsJustin Luth
Extensions can add RegisterOnTheFly languages for spell checkers. A late initialization of the LanguageTable resulted in the inability to recognize the available spell checker. So, if a .doc file had an onTheFly language inside, and it was the first document that LibreOffice opened, then the spell checking extension was disabled for any other document opened while LibreOffice was living, including docx and odt files. (Starting with a blank document, or a .docx or .odt file seems to initialize OK - and then subsequent .doc files are also ok in those sessions.) Ensuring that the static LanguageTable is intialized early in the process avoids this headache. In my case, .doc was failing with: LanguageTag::registerOnTheFly: not cross-inserted 0x7e0 for 'kbo' have 'en-US' but with this patch now matches .odt/docx with: LanguageTag::registerOnTheFly: cross-inserted 0x7e0 for 'kbo' [have 'kbo'] This fixes .ods .odg, odp, .xls .xlsx .ppt, pptx .doc and likely many others Change-Id: Ie6dcbfd73e063eef4573016c3c62d29cf8ad43ca Reviewed-on: https://gerrit.libreoffice.org/49142 Reviewed-by: Martin Hosken <martin_hosken@sil.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-02-02Related tdf#100243: blacklist Intel HD Graphics 630 for non minimal versionJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=100243#c17 Change-Id: I8315176a55aa46a74b45329f9f28882c2aa73c1f Reviewed-on: https://gerrit.libreoffice.org/48844 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-02-02Blind fix for MSVC warning C4101: 'rError': unreferenced local variableStephan Bergmann
...after 4e102d6a4b483098e80ca86e19ee8576ae5356f1 "sdext: MSVC: pragma warning: make more specific, remove obsolete" Change-Id: Ibd198ef24aa67c4c98bc1f504deccb1fdf28d054
2018-02-02uitest for tdf#114724 headings outline tracking in NavigatorJim Raykowski
Change-Id: I4390c3d33d69ddd93880545f58d0ef81469c960d Reviewed-on: https://gerrit.libreoffice.org/47865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-02tdf#115388: Android: Use HTTP SecureXisco Fauli
Change-Id: Ia2e198c20b904ba178fac2969dfa80f3f1291be1 Reviewed-on: https://gerrit.libreoffice.org/49123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-02-02xmlsecurity: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I8303ba62198f4beb934623df7c52bf484a66a5e5 Reviewed-on: https://gerrit.libreoffice.org/49059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-02xmlhelp: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I211a6f95f7146d7ffaa0c44af786c4474abc73f4 Reviewed-on: https://gerrit.libreoffice.org/49058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-02vcl: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: Ib2d89cfba3ad625779ee501a7caaa94893d8c681 Reviewed-on: https://gerrit.libreoffice.org/49057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-02unoxml: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I6c09eeeb43cd0bf85b89b1332f2ee6121b11de3c Reviewed-on: https://gerrit.libreoffice.org/49056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-02usb: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I17030fc129de3e79965a1abe140fa0c28b949035 Reviewed-on: https://gerrit.libreoffice.org/49053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-02tools: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: If36242e93a700313becbd37ceae06491fcd84b8a Reviewed-on: https://gerrit.libreoffice.org/49052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-02sw: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I0307561186651884ea08b908be6a53d2d49f74b2 Reviewed-on: https://gerrit.libreoffice.org/49051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-02sot: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I0a0dc82561968cd1ff179c9930525e188060d9b7 Reviewed-on: https://gerrit.libreoffice.org/49050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-02sdext: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I317b952c27fd052d4f19aa0dfc4ee9ce1e4705ad Reviewed-on: https://gerrit.libreoffice.org/49046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-02lokdialog: Color/font picker in dialogs don't show previewTamás Zolnai
Invalidation needs to be passed upward to the right parent window. It should work similar to other dialog items, but this preview class is not derived from the Control class. Change-Id: I5fb2b6438b8be92d55609c8d3c25110b49d0e6d7 Reviewed-on: https://gerrit.libreoffice.org/49101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-02loplugin:useuniqueptr in X11SalFrameNoel Grandin
Change-Id: If8693b106f8755e506375f1a65754c972971700f Reviewed-on: https://gerrit.libreoffice.org/49129 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02Replace some front/pop_front by for-range loops+clearJulien Nabet
Change-Id: I8a9239667b0d80ee2fa6ebbc8a19ba4c0076c2fb Reviewed-on: https://gerrit.libreoffice.org/49107 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-02loplugin:useuniqueptr in GtkSalFrameNoel Grandin
Change-Id: Ia98080d5c214824624ca4cbe875038374919f662 Reviewed-on: https://gerrit.libreoffice.org/49132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02remove connectivity OSubComponentNoel Grandin
push the logic that is still necessary down into the subclasses Change-Id: I99424f0b3c654c5652991a4140b17ceb02224e50 Reviewed-on: https://gerrit.libreoffice.org/49087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02loplugin:useuniqueptr in SalGtkFilePickerNoel Grandin
Change-Id: I3cbe4121c1cb323ad00e110bcdb1f61334e656bc Reviewed-on: https://gerrit.libreoffice.org/49131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02loplugin:useuniqueptr in i18npoolNoel Grandin
Change-Id: Iff39b9298bfad474c5c011b6355b8ebf5be06318 Reviewed-on: https://gerrit.libreoffice.org/49091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02use TypedWhichId in BaseProperties::GetItemNoel Grandin
Change-Id: Ic359d33d92928f5baa89cd98debe1a6a9d6a52f3 Reviewed-on: https://gerrit.libreoffice.org/49128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02sw: replace DELETEZ with std::unique_ptr in textapi.cxxMichael Stahl
Change-Id: I4e4eaa67995a4a8041ab701e02984aa2fb0d349e Reviewed-on: https://gerrit.libreoffice.org/49118 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-02loplugin:useuniqueptr in NWPixmapCacheNoel Grandin
Change-Id: Ibf9f5c3ec3ea502bb93942516936ff844235b4d3 Reviewed-on: https://gerrit.libreoffice.org/49130 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02editeng: remove dead codeChris Sherlock
Change-Id: I2ce15bc2c6b9663b479ae98bb1d5e0900716adcf Reviewed-on: https://gerrit.libreoffice.org/47492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-02Don't recycle DocumentInserter, create a new one every timeKatarina Behrens
After all, everyone else using DocumentInserter across the codebase does the same. For KDE4, an attempt to reuse the same filepicker dialog sporadically crashes in the depths of (old-ish, possibly buggy) libQt due to nested event loop and/or recursive repaints. (crash scenario: Calc > Sheet > Link to external data > Browse > double-click a file > Browse again > Kaboom!) Change-Id: Ib494203abd07873919b8394a442f09c5329d237c Reviewed-on: https://gerrit.libreoffice.org/49082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-02tdf#115319 references with Hungarian articlesLászló Németh
Add new alternative reference formats, stored by the proposed text:reference-language attribute. This is an implementation of the ODF improvement draft published in the bug report. Note: choose Hungarian locale setting to show the new "Article a/az + Page" etc. reference formats in dialog window "Fields". Change-Id: I210d4b9a3e821fb4e45e24643bad9c70b867c89d Reviewed-on: https://gerrit.libreoffice.org/48944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-02svtools: SvParser<T>::NextToken() can be pure-virtualMiklos Vajna
Change-Id: I9e8c87beb86ee073d6b5ee95c3f80e6dc55a99e9 Reviewed-on: https://gerrit.libreoffice.org/49117 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-02DOCX import: don't try to set grab-gag props as UNO propsMiklos Vajna
This fixes loads of warnings like this one: warn:legacy.osl:22335:22335:writerfilter/source/dmapper/StyleSheetTable.cxx:1611: Exception in StyleSheetTable::getOrCreateCharStyle - Style::setPropertyValue during import. They are harmless as we catch the exception, but they are just noise. It seems the code that transforms grab-bag pseudo-props into real props was added in commit 4c3ba3a413be7339115ea5e6edc825a8434cd345 (fdo#75757: Remove inheritance from std::map., 2014-07-26), which is supposed to be a pure refactoring, so just remove this problematic transformation. Change-Id: Ibf45bfedc661f9e065405c47623516c4026148a4 Reviewed-on: https://gerrit.libreoffice.org/49105 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-02Remove obsolete overflow checkStephan Bergmann
...which had originally been added with 766d2b65e3799fb66099c94837280cb9102219a6 "INTEGRATION: CWS geordi2q10: #111934#: join CWS os21" as - rInf.Left( KSHORT(Left()) ); - rInf.Right( KSHORT(Right()) ); - rInf.First( short(FirstLeft()) ); + + // Handle overflows: + SwTwips nTmpLeft = Left(); + SwTwips nTmpRight = Right(); + SwTwips nTmpFirst = FirstLeft(); + + if ( nTmpLeft > USHRT_MAX || + nTmpRight > USHRT_MAX || + nTmpFirst > USHRT_MAX ) + { + SWRECTFN( rInf.GetTxtFrm() ) + nTmpLeft = (rInf.GetTxtFrm()->Frm().*fnRect->fnGetLeft)(); + nTmpRight = (rInf.GetTxtFrm()->Frm().*fnRect->fnGetRight)(); + nTmpFirst = nTmpLeft; + } + + rInf.Left( KSHORT( nTmpLeft ) ); + rInf.Right( KSHORT( nTmpRight ) ); + rInf.First( KSHORT( nTmpFirst ) ); But later 2a2f9a30dc67bb64860333b83b0489bc610da48f "INTEGRATION: CWS swqbugfixes10: #i34348# Underflow with negative numbering indent values" had changed the SwTxtFormatInfo members from KSHORT to SwTwips, presumably obviating the need for such an overflow check. Change-Id: Id622d2bbc280e3d825981356e19c7fe9ed23fc5b Reviewed-on: https://gerrit.libreoffice.org/49077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-02Breeze-icon: add 32px trackchangesbar icon for default writer barandreas kainz
Change-Id: I4cab78d3566e574e4176ca9b3b9692cd13f5bf86 Reviewed-on: https://gerrit.libreoffice.org/49121 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-02-02Revert "tdf#98141 add svg file for all app icons in all sizes"andreas_kainz
This reverts commit 61be109b1c10df3ddbb27f2a398b121a7c977f30. Change-Id: I1e3dc953154a6b75ffb507e9dc554df1acea45bf Reviewed-on: https://gerrit.libreoffice.org/47442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-02-02avmedia: move BitmapWriteAccess inside BitmapNoel Grandin
part of a larger project to hide BitmapWriteAccess inside Bitmap Change-Id: Ia46c12b3297107892a6236633c11ca9ada6edbd4 Reviewed-on: https://gerrit.libreoffice.org/49106 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02loplugin:useuniqueptr in PhysicalFontFamilyNoel Grandin
Change-Id: I010339eaf7874e61b5d0e5d41574c54e98ea1921 Reviewed-on: https://gerrit.libreoffice.org/49094 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-02 13:48:05 +0000