summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-08replace some more copy/clear with swapNoel Grandin
Change-Id: I6501dd59682d2605e9b9856c2deaa02a873ce641 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88239 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-08tdf#130148 Gallery drop-down list in Impress B&N dialog shows only start...Onur Yilmaz
Change-Id: Ieb8d79d7b3d291ffb36a7daaee0716d4ed8c9a85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87972 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-08Fix typoAndrea Gelmini
Change-Id: I12cbc2f91dbcc622839c407cfbb5c1e32b324f98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88248 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-08Fix typoAndrea Gelmini
Change-Id: I45c764cfbc436ee62370047f1bd65f5b1de53ab0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88247 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-08Fix typoAndrea Gelmini
Change-Id: I7e213d6fee88593da8a25ce4bbbc514c60494329 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88243 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-08Fix typoAndrea Gelmini
Change-Id: I0dd153d1766d1f6a6da974a847e937edcd3399f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88246 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-08Fix typoAndrea Gelmini
Change-Id: Ib6e37272a4c183de137ba3d63ede6bbd344c6f5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88245 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-08Fix typoAndrea Gelmini
Change-Id: Ia3238554505ed25f480ac35fca5b74817a55541c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88244 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-08Fix typoAndrea Gelmini
Change-Id: I99333fab507d9a7dc7583bfab20388afffd3ec20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88249 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-08Fix typoAndrea Gelmini
Change-Id: If83a1a5cc7b6170579f852e735d0a94bdff2d9d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88252 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-08Fix typoAndrea Gelmini
Change-Id: I935579ee9df56cda1a87816603b23a0562bb1b97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88256 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-08tdf#130482 sw: fix text alignment in shape textMiklos Vajna
Regression from commit a3c7a8282ddd08c7ed4a15d23089d09e418f8fae (jsdialogs: apply .uno:Color and CharBackColor to floating text frames, 2019-11-08), the problem was that the original code populated aNewAttr, while SetAttrToMarked() was only invoked in case there were arguments. Fix this by making pNewAttrs a copy, so lcl_convertStringArguments() can work on it in place, and then restore the old code that copied from pNewAttrs to aNewAttr. This fixes the no-arguments case and keeps the lcl_convertStringArguments() case working. Change-Id: If7bf2d7b21e48d513a512ec6127b61ee74635ef5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88227 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-08pack some data structuresNoel Grandin
Change-Id: I7ef990b8aa7b26c413b54186c360ed3f858d4e26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-08move some headers inside frameworkNoel Grandin
Change-Id: Ia005938c6a3a954eba910981dde5010a1f977fca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88201 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-08tdf#84553 Detect and warn of Windows Antivirus.Michel Thomas
Change-Id: I7731cb316306c153ad14bb3d27f39600a44ed9ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87811 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-02-08tdf#129809 qt5: take a reference in case m_aContents is replacedMichael Weghorn
This takes over Caolán's solution for gtk3 from dbcdc5cd98df5756a96559e467cad95c629343ca ("tdf#129809 take a reference in case m_aContents is replaced") for the qt5 case as well, to prevent that the XTransferable is destroyed along with the Qt5MimeData object as new QMimeData are set in the clipboard, as follows: 1 Qt5Clipboard::setContents Qt5Clipboard.cxx 2 TransferableHelper::CopyToSelection transfer.cxx 3 TransferableHelper::CopyToSelection transfer.cxx 4 SwTransferable::CreateSelection swdtflvr.cxx 5 SwWrtShell::SttSelect select.cxx 6 SwWrtShell::SelectTextAttr move.cxx 7 SwTransferable::GetData swdtflvr.cxx 8 TransferableHelper::getTransferData2 transfer.cxx 9 TransferableHelper::getTransferData transfer.cxx 10 Qt5MimeData::retrieveData Qt5Transferable.cxx 11 QMimeDataPrivate::retrieveTypedData qvariant.h 12 QMimeData::data qmimedata.cpp 13 QInternalMimeData::renderDataHelper(QString const&, QMimeData const *) 14 ?? 15 ?? 16 ?? 17 QXcbConnection::handleXcbEvent(xcb_generic_event_t *) 18 QXcbConnection::processXcbEvents(QFlags<QEventLoop::ProcessEventsFlag>) 19 ?? 20 g_main_context_dispatch Change-Id: Ic712c901a31131efc596cac7f00f14bb6a7ce068 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88192 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-02-07Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to a797d607f1d56f4e401d03669d766124317baa46 - adjust embedding of Position header in chapter numbering help Change-Id: I0e3e5ecc78dc8747e71342edbce23358a14e71a7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88254 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-02-07Removed executable permission on filesAndrea Gelmini
Change-Id: I33964ea73b905e9ad4cc22f662b01be07cc96eca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88250 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-07Fix typoAndrea Gelmini
Change-Id: Idf99108e6f7813551a8cee2e8d7b990de8a36ebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88251 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-07Fix typoAndrea Gelmini
Change-Id: I372f5b8fe3d2b1db8e9b672e67709f68b22735b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88253 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-07property browser appearing as a blank area when changing modulesCaolán McNamara
under gtk, so just don't create it until we need it Change-Id: I0fd86c6b587788c42646a107746e8e4e10f2a13f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88230 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07tdf#130501: Fix off-by-one error in URIHelper::resolveIdnaHostStephan Bergmann
Change-Id: Ibc231308d0fc93085933ae7d80dc8c4b2699fe02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88204 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-07DOCX export: fix handling of section starts that originally had page marginsMiklos Vajna
This is similar to commit 26f2a9e1a10a22e864e71ee7c94934821703e021 (DOCX export: fix handling of section starts that originally had headers, 2020-02-06), except here the top margin has to taken from that follow page style, not the header. Without this, it can happen that the page number in the original Writer doc model and the exported Word result do not match. This required reworking WriteNextStyleHeaderFooter(), which assumed that the header/footer status is already calculated by the time its called. But the page margin code runs earlier, so we need to make that decision earlier, even when the header/footer status is not yet calculated. Change-Id: Ife7396603702d2048d544aa46f96acfa337a041a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88211 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-07weld ImplGrafControl ItemWindowCaolán McNamara
Change-Id: I1c3551ffe510d49ea7ddce9d896f59857f4b2946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88213 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07ofz#20517 null-dereferenceCaolán McNamara
Change-Id: I443869f848925911ed46e2f547f0dc652b1ff290 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88214 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' to c0f4ae88b0ae0a59a0f8c3c3301f5d385a9ee750 - Improve visibility + whitespace cleanups Change-Id: Icdcd544cf7ee53dd01488059f1ffc622248a2562 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88059 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-07SwFormatField::Modify no more (folded into SwClientNotify)Bjoern Michaelsen
- refactor out field formatting * make direct calls explicit with new UpdateTextNode() call * try to bring at least some sanity to the event handler Change-Id: I40a39ddf70476b7fa0bf5e157fb263e863bb1d20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87927 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-02-07Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' to f9d83461af0630daece8a497aab5e02fea97efa6 - fixing a typo Change-Id: I45c38402392c2424e78e022cc8943c453adb8707 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88033 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-07tdf#130478 Enhance Dashed line drawing on all systemsArmin Le Grand (Collabora)
For more info and explanation including state of process information and discussion(s) see task please. Adding corrections for gerrit build Change-Id: Ie10fb8093a86459dee80db5ab4355b47e46c1f8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88130 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-02-07tdf#94234 Add Period as chart data label separatorGabor Kelemen
Change-Id: I50b9662b22bdb10086e6aa557622566591135514 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88139 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-02-07tdf#130380 Chart: Fix area chart data labels positionTünde Tóth
Regression from commit: f8966bb398cf0623be841c618b123866801a063c (tdf#130031 Chart OOXML import: fix area chart data label position) Change-Id: Iafcbacb0ecf6f8a175adbf0782ee3e3a1185a726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87881 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-02-07create-tags: Exuberant Ctags 5.8 lacks -D, try to detect thatMichael Stahl
Change-Id: I1abc60184e0e5b68c41f5a3517f0877889d8f43a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88195 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-02-07tdf#129789: Add unittestXisco Fauli
Extend it to cover all fill styles in shown/hidden comments Change-Id: I866d1b7f6248a5b5520348b249ed3cda4eec46dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88122 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07rename GetBaseOfstForFly->GetBaseOffsetForFlyNoel Grandin
Change-Id: Ieeeaa53d916e192e7219d7d3d405584a22249e7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88181 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07tdf#123873 DOCX IMPORT: fix unhandled textwrap for objectsBakos Attila
The OLE objects (in this case charts) had bad wrap option setting and this lead to misplaced objects. Now this parameter is set according to the file. Change-Id: I506be91b6801f0ffc3942e514f81119d895fdcb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88091 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-02-07sw: fix misnamed m_IsFootnoteInfoMichael Stahl
Silly copypasta in f3bb701223953df02f005b98d2eee13e82016bd7 Change-Id: Idf20017a7eb180e6a9f429e6976cea8c13cff066 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88194 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-02-07weld ImplGrafModeControl ItemWindowCaolán McNamara
Change-Id: Ib71436cf9ecb312ea9f273bb974954556868e613 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88189 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07rename URLBox back to SvtURLBoxCaolán McNamara
Change-Id: Icd90eeb492002c45ddd8ff562a6da411abead122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88185 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07tdf#99693 Add Highlighting tab for WriterMaxim Monastirsky
Works with shapes and comments. Change-Id: Ic2e4b3cf7decce493426bed1ec077cc97ea17bb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88173 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-07SvtURLBox is now unusedCaolán McNamara
Change-Id: Iab78b3803272ceb62c4df74241b64f23b1437b03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88184 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07reportdesign: Use .uno:UnderlineSimpleMaxim Monastirsky
So we get a simple button, like it used to be before commit c81afdb5118536b2e2365a9a9af6b6e162c87aeb ("rework TextUnderlinePopup to be a PopupWindowController"). The dropdown doesn't work in reportdesign anyway. Change-Id: I9cec636ecc983a353b807624cea6523a9a2b92ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88182 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-07weld URLBox ItemWindowCaolán McNamara
Change-Id: I7dad000404a188e2f5588b90d73ea9b1236bd301 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88183 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07Fix typoAndrea Gelmini
Change-Id: I9bae8051b27eddca47ca5ffbd17006bf23d4f232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88149 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-07Fix typoAndrea Gelmini
Change-Id: I2df1bab891cb1661da48ded41f0bc669fb4b0bbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88147 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-07Fix typoAndrea Gelmini
Change-Id: Ia1cd4fc4e6f5cfbf327132cdd499cb42c1f7d3e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88148 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-07Fix typoAndrea Gelmini
Change-Id: I44241cf4c81543ad2a3091e3b19639f63e016cd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88193 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-07remove unused suppressionsCaolán McNamara
Change-Id: Ibee4281b884cf65a0f99ebd7a52087c6a5ebb66c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88177 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07move some headers inside svtools moduleNoel Grandin
Change-Id: I62fe3345aebe148010971bc8c487d96fa601d420 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88164 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07weld GlueEscDirLB ItemWindowCaolán McNamara
Change-Id: I472ba595bb2f31bedf1d0e0a890024f9ac3ada39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88176 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07neon: escape broken SharePoint 2016 URIsJan-Marek Glogowski
SharePoint returns broken URIs in its href replies, which aren't correctly URI encoded, but still "valid" URIs w.r.t. general and UTF8 encoding, e.g. http://<host>/Shared%20Documents/ümlaut.docx As a workaround, this allows all invalid / other bytes (except '\0') in the path of the URI in ne_uri_parse. Change-Id: I70e7d323837469d7ced429a42c009972f4fb0ebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88120 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins