summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-08-25tdf#92287 Make LibreLogo icons theme basedMaxim Monastirsky
Change-Id: I9f8eacd79fd890ae81f9ef8337e03213818c879e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101078 Tested-by: Jenkins Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-08-25Fix typoAndrea Gelmini
Change-Id: Id3aa0f0569a9f783fc4ab97a789e20b65aec5991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101288 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-25use more fastparser in SdXMLStylesContextNoel Grandin
Change-Id: I251833e14b96729ce754912fd4bfc68fe2e57299 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101294 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-25Chart sidebar: smoothline dialog spacing according dialog HIGandreas kainz
Change-Id: Ic05223889606d56747b5a0f944becf8856d17754 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101299 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-08-25tdf#133661 Modified soffice.odp/ods/odg files to empty bare minimal ODF filesEzinne Nnamani
Change-Id: I91734d32719f1b68da1b1810dad5960c0bd807e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101195 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-08-25Chart sidebar: steppedline dialog spacing according dialog HIGandreas kainz
Change-Id: Id01704be50715b76a16832d672ce926b6d58f4dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101300 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-08-25Chart sidebar: spacing according dialog HIGandreas kainz
Change-Id: I4d26f0cb8fc9b0ccfa10193a34728a84a08ea6c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101301 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-08-25Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 031b9e971a9a04875220887c5b97849de737800b - Fix typo Change-Id: Ie1578d623ae891994611e43843fb41e7f47bc4d6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/101239 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-25tdf#135997: properly check loop conditionMike Kaganski
It should break when any of iterators reaches end, not only when both. Introduced in commit 710a39414569995bd5a8631a948c939dc73bcef9. The crash dump from the bug report points to one of these lines; this is a blind fix, since I cannot reproduce myself. Change-Id: Ie7f6b827256cdb7061901dc9b2ae5ee8e0222a38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101162 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-25Colorpicker Dialog fix spacing according to Dialog HIGandreas kainz
Change-Id: I9864aa8915b482596671957e686ef06c76b7712b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101295 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-08-24tdf#136067 left align GtkMenuButtons contentsCaolán McNamara
most already are, align the rest too and have for gtk "fill" the label widget Change-Id: I6f75c5c6ebaad0d2e3301854882aeaf3eab8580b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101280 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24restore translatable="no"Caolán McNamara
Change-Id: I42b46c0cada25703e8e9600533a220252796457e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101289 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24use fastparser in SdXMLNumberFormatImportContextNoel Grandin
Change-Id: I3a63a80363d1c9b41e9ea73e2cc6c78d24bb1bad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101246 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-24tdf#133026: Additions: Rating image implementationYusuf Keten
Change-Id: Id250f0e70490941743e0f3ca2b94897f69a9208f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101013 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-24ofz#25174 build failureCaolán McNamara
Change-Id: I758e39bc89282ad76482b0b66aa28d143325953c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101292 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24NullToPointer ValueDependentIsNotNull GNUNull -> nullptr [loplugin:nullptr]Caolán McNamara
Change-Id: I93efe23af18c622123ddc3feb41a43a485ee2722 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101285 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24fix some fastparser related bugsNoel Grandin
in my previous commits, which interacted in entertaining ways to prevent any unit test from finding them Change-Id: Ifc3a5e7bbf83549d9f56eac70d9e6a064a6fb103 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101286 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-24tdf#118148 Extended tips from HC2/shared/Olivier Hallot
These extended tips are extracted from <ahelp> in Help files Only for ui files, where dialogs/widget pair could be determined. Other forms of <ahelp hid=".."> such as .uno:.. and *HID* ... will be addressed elswhere. Change#1 Removed extended tips from GtkMenu of svx/.../acceptrejectchangesdialog.ui Change#2 Some empty ET's slipped in cui/macroselectdialog.ui Change-Id: Ic8dc62734143f621fcd3c4156fc004f585630277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24Sidebar: update Area fill be align with Transparancy:andreas kainz
Change-Id: Ied50f9f478aea916f728330be2a4111ee2d19153 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101278 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-08-24tdf#135828 XLSX shape export: fix distortion of rotated shapesSzabolcs Toth
Shapes that were rotated at angles {[45, 135) U [225, 315)} need new anchor positions that does an extra 90 degrees rotation. See commit 130e6a3f4493b987a7d0b177cc84d65219b47d13 (tdf#83593 XLSX DrawingML shape import: fix missing rotation) Co-authored-by: Balázs Regényi Change-Id: I42a5d203cf3b6f6e725d84dd5f39ac323f4f1ceb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100853 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-24remove unused XIM.hCaolán McNamara
Change-Id: Icf15604a2d449159fceb212717264952e8cacb33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101282 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24Access2Base - tdf#136063 Workaround Basic missing argument handlingJean-Pierre Ledure
When an argument is missing in a call to a Basic function the IsMissing() function applied on the argument should respond True. However sometimes(?) the argument contains instead "Error 448" making IsMissing responding False. This commit puts an explicit argument in the function call avoiding the different behaviour of the Basic interpreter in LO 7.0 vs. previous releases. Change-Id: Ic90fb7ec9b6e520cc762a441ca383b54c5d4db16
2020-08-24Sidebar: update Line align and arrangement with Transparancy:andreas kainz
Change-Id: Id3f61bdc4041f2e7d9b791348ad10fade0fbd137 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101279 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-08-24tdf#135720 sw: fix PAGE_PRINT_AREA_BOTTOM alignment with footerTibor Nagy
Top of the page margin area was the footer instead of the page text area bottom, when the vertical position of the object was "top" or "center" instead of "from top", resulting lower positions after DOCX import. Follow-up of commit d54264e34c1ccc0eaf4178ab165a843028500223 (tdf#133071 DOCX import: fix vertical alignment to bottom page margin) Co-authored-by: Attila Szűcs (NISZ) Change-Id: I4be46501fc4a3e5fb17330ea5f695a65014a7585 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100720 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-24crashtesting: exception on reexport of fdo55178-3.xlsx to xlsxCaolán McNamara
since... commit acfd9e9ca2dfd76536c072e21c65cb3efc6aac80 Date: Mon Jul 27 00:31:04 2020 +0200 tdf#128345 PPTX: add transparence gradient for fill in chart use GetProperty which checks for exceptions and put result on success into mAny Change-Id: If327848031910f47eb05e5998fa2b3265e8e258a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101275 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24Fix typo in codeAndrea Gelmini
Change-Id: I3a594969e35d6cf5a02e36cbb0493e7bb77f3e22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101204 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24Fix typosAndrea Gelmini
Change-Id: I9385704bea54ff504457f7ac1ec39ed98cfdaf97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101276 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-24tdf#134174 Fix the rotation of bitmap filled custom shapes.Gülşah Köse
During import we were rotating only custom shape. Not its bitmap. Custom shape and its bitmap rotated with same rotation value in that commit. Change-Id: I02d19c820670df7b4d1622836156c6bf8ed1c154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101255 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-08-24GetProperty extracts property to mAny alreadyCaolán McNamara
so its already available to assign to nVal and doesn't need to be refetched Change-Id: Iecfa5e7546b0ef7915999335995e43d85692dfa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101273 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24tdf#129423 sw: remove last two bad nullptr checksDaniel Arato (NISZ)
Clean-up of commit 5ac88d12b377f64ff36551bfb3cf95a4a23a167d (tdf#129423 sw: Convert more tests to export-only). After a bulk refactor of OOXML export-only tests some unnecessary, in fact harmful, checks whether parseExport returned a valid pointer remained in the codebase (spotted by Mike Kaganski). These checks have been deleted. Change-Id: I0374596c2f1b01be8092461168177f8c13ee1ca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101274 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-08-24add documentation to get_buildable_nameCaolán McNamara
Change-Id: Idb18905f741cbb6f25508c3b9afc0ae6cca7abd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101270 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24tdf#133026: Additions: Install Extension FunctionYusuf Keten
Change-Id: Ifcad25a85533833c7d05e5be46ea763e1eeaa5d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100714 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-24crashtesting: sdr::table::TableDesignStyle doesn't support XPropertySetCaolán McNamara
rStyle is a sdr::table::TableDesignStyle which doesn't support XPropertySet Change-Id: I4987cfd57abc1954e108271d85433ad6e8b1493f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101266 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24tdf#123218 tdf#108067 config key ReverseXAxisOrientationDoughnutChartTünde Tóth
for OOXML compatibility of newly created doughnut charts. The X axis orientation of doughnut charts is the opposite of the primary writing direction in LibreOffice but not in Microsoft Office. Default value is "true" to keep current behavior. Using "false", the inner and outer data series of new doughnut charts are the same, as after DOCX export. Change-Id: If431d5717e70599f07231bd673cd90c196450ae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100417 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-24ofz#1466265 Logically dead codeCaolán McNamara
since... commit db10942f021026e67ab146da1b625e534f58cf34 Date: Wed Aug 19 20:38:24 2020 +0200 use fastparser in StoredChapterNumberingRootContext Change-Id: I3f4bc4557c1b1f53b4bffac88fa634ef93c30a3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101250 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24Remove no-longer used files related to LDAP mappingStephan Bergmann
They appear to be unused ever since c8dddd5a6b7fa273b0cebfb5d8b2794cce90eca7 "#i101955# adapted LDAP backend to new interface, dropped registry/ldap/*-attr.map files, replaced registry/data/org/openoffice/LDAP.xcu.sample with registry/oo-ldap.xcd.sample and registry/oo-ad-ldap.xcd.sample". (8b3807dbc925e69afcf20bf619986e832ee19845 "do not deliver unused files" had not dared to remove them completely.) Change-Id: I46daa90025ee30a1644d4ca48470e8f1fe8b4473 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101264 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-24tdf#135973: DOCX export: improved list override supportVasily Melenchuk
Removed remains of old override support which are not working now. Partial refactoring and fixing for listid and overrides detection. Change-Id: I1f94a09b7d51fcc3300b056d6d9e8ea6367a4446 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101238 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-24tdf#135918 XLSX DrawingML shape import: fix needless displacementRegényi Balázs
Shape was displaced on rotation if it is placed next to the sheets upper/left edges. Co-authored-by: Szabolcs Tóth Change-Id: I987e7b0d863b89cfb5d8154e2f0a017e21248ee1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101001 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-24ofz#25169 insertion into set might find a duplicateCaolán McNamara
in which case pImpRec is deleted and pImpRecTmp is invalid Change-Id: I2a273a436ebd88cb53e329bbcb4f171dda6ed840 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101248 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24avoid gtk_widget_event assertion !WIDGET_REALIZED_FOR_EVENTCaolán McNamara
just bail if the focus widget isn't realized yet Change-Id: I2f0ebe424abb688b6fa0c82bb61ba56a47fad701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101249 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24cid#1466264 Dereference null return valueCaolán McNamara
Change-Id: Idb2543b811cc5081e34ab3d1cc3aaa44399162ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101251 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24Don't apply transparency twice when drawing to mpAlphaVDevMike Kaganski
We pass fTransparency to mpAlphaVDev->DrawTransparent; using adjusted fill/line color is wrong. The correct COL_BLACK/COL_TRANSPARENT were already set in mpAlphaVDev when SetFillColor/SetLineColor were called to the virtual device. Wrong implementation from commit 9c621ee8ea41a1c53bfeca49827290826785973e. Change-Id: Ic858ede1ba793ac00f831a3960f748ad20ccb70a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101262 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-24Related tdf#100492 Detect click into empty fieldSamuel Mehrbrodt
Change-Id: Ic2937d619a8361b9d17b7dfa16698a5005f34ec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101076 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-08-24tdf#136047: fix OutputDevice::DrawTransformBitmapExDirect for ...Mike Kaganski
transparent bitmap case This has been broken in commit 9c621ee8ea41a1c53bfeca49827290826785973e, where transparent bitmap started to override any transparency of vdev with transparency of its pixels, and not use alpha when drawing RGB when mpAlphaVDev was present. Instead, this restores using alpha in RGB output, and blends alpha to what is already in mpAlphaVDev. Change-Id: Id82717def4535336450a7118f8bd29a1660c9520 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101254 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-24uilogger : Add support in the Logger and DSL for ZOOM in CALCAhmed ElShreif
For example the DSL syntax will be: >>"Set Zoom to 46" Change-Id: Ie8a77441da10bd32efd7a95c3f1550671a62d16f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101125 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com>
2020-08-24uilogger : Add support in the Logger and DSL for the ToolBoxAhmed ElShreif
The support is tested on the FindBar and it works well . For example the DSL syntax in the FindBar should be like: >>"Click on item number 3 in FindBar" Change-Id: I3ec5f5afc260df4b38dc4e420fcc48d9c774c29f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100811 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-08-23Fix typo in codeAndrea Gelmini
Change-Id: Ie0f3d8b01e0370f0a2e95d46b61be56943d3bd78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101198 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-23Bin overly eager early return that stops replacement image creationTor Lillqvist
The return causes a customer's Java code that handles some .odt document to unexpectedly not create object replacement images in the document. The problem is that in the bad case, the SwTextShell is created later than .uno:UpdateAll is dispatched, so the dispatch does nothing. SwBaseShell::Execute() for FN_UPDATE_ALL is not called. And this is required, becase that calls setUserAllowsLinkUpdate(true), so that on save, when EmbeddedObjectContainer::StoreAsChildren() in comphelper/ hits the 'if ( !xStream.is() && getUserAllowsLinkUpdate() )' condition, then we create a replacement image. This is a Basic script that demonstrates the same issue: desktop = CreateUnoService("com.sun.star.frame.Desktop") Dim props(0) as new com.sun.star.beans.PropertyValue props(0).Name = "Hidden" props(0).Value = true component = desktop.loadComponentFromURL("file:///.../test.odt", "_default", 0, props) dispatcher = createUnoService("com.sun.star.frame.DispatchHelper") frame = component.CurrentController.Frame dispatcher.executeDispatch(frame, ".uno:UpdateAll", "", 0, Array()) component.storeSelf(Array()) component.dispose() (Will also try to add a unit test that demonstrates the problem and verifies this fix.) Change-Id: I4a5f78a2118a387f062c2d5213a0012a7df2dd9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101138 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-08-23tdf#135779 move focus back to usual parent before grabbing pointerCaolán McNamara
Change-Id: Ia4f1f2f1672a76515ab586d679a05467515868d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101247 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-23WaE: -Werror=maybe-uninitializedCaolán McNamara
with --enable-dbgutil + --enable-optimized=debug Change-Id: I98fdc7e0b97c48bfb7c425013640c91c29e46a3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101244 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>