summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-08-26Access2Base - tdf#136063 Workaround Basic missing argument handling (2)Jean-Pierre Ledure
Complementary modifs where behaviour described in bug report could happen in the same way. Root cause IMHO is due to Basic error reported in bug#136143 Change-Id: Ib275f74a0c28995e6b05af31a1fd53b6ae069691
2020-08-26tdf#136097: make physics animation effects handle skips and rewindsSarper Akdemir
Making box2d world only stay populated when there's an animation effect going on. This makes it possible to get rid of big chunk of sequential update implementation. Change-Id: Iaf50d4871b2355035495618354f0ae09abe94164 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101304 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-26Sidebar: mediaplayback alignment update to fit HIGandreas kainz
Change-Id: I33d838f0f51788387e7a50359010d9a9a78549e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101392 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-08-26lok: send cell border state updatesSzymon Kłos
Change-Id: I400ee3cb9f0a98804d98e25d0164fa5148b79191 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100424 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101385 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-08-26lok: Hide not working 'More Styles' optionSzymon Kłos
Option was shown in the sidebar style dropdown. Change-Id: Icd7b555d1c6c1a860454c4b367146a1ea9746b76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100204 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101386 Tested-by: Jenkins
2020-08-26Except[Const]CharArrayDetector is only used by RTL_STRING_UNITTESTStephan Bergmann
...which in turn should be a LIBO_INTERNAL_ONLY feature, so confine all relevant declarations accordingly Change-Id: I7545eadad6f097d0ee905583b1610631c92f1858 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101373 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-26optimize polygon merging in Skia (tdf#136139)Luboš Luňák
basegfx::utils::mergeToSinglePolyPolygon() can be an expensive operation when many polygons are involved, and the code was calling it for every new polygon, which is actually not needed. Simply merge all the collected polygons just once before they need to be drawn. Change-Id: Id29d5dd5647d262b2cdfe9963f8d4e2ace844b66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101384 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-08-26update Skia to chrome/m86 snapshotLuboš Luňák
Change-Id: Id0c0679bc1ca546a75f71d4716ba151ae46569bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101311 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-08-26use more fastparser in SdXMLMasterPageContextNoel Grandin
and drop some unused code Change-Id: I4ed57ab843759e2214ad2b679003fcc329c073ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-26add GetTextWidth to CustomWidgetControllerCaolán McNamara
Change-Id: I1325ec66a8ed85626dfd0c9d5a79ac6264906abd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101371 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-26ThumbnailViewItem not guaranteed to measure with the font it will draw withCaolán McNamara
Change-Id: Ie590a6d7ffc619b1ac5f9b766582a8088e6b8d02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101370 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-26tdf#123401 DOCX: fix table formula AVERAGELászló Németh
by adding AVERAGE as an alternative name of MEAN, and by converting MEAN to AVERAGE during DOCX export. Change-Id: I691618141a67f19f5823d8a214169c15f2ac6cce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101336 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-26merge SwXMLItemSetContext_Impl and SvXMLItemSetContextNoel Grandin
Change-Id: I8a9dba020e7189d31040e8cb742d105390b242e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101349 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-26Missing 'const'Stephan Bergmann
Apparently typos in 0c8fa58a2d73702770687ed15b98822d09f96ac3 "Support ConstCharArrayDetector also for UTF-16 arrays" that went unnoticed as for a const OUString s, s == u"..." could still pick the bool operator ==(OUString const &, sal_Unicode const *) overload. Change-Id: I61344ef2912fffca3cccf375e2e4c2be9beca604 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101377 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-26Remove outdated comment lineAndrea Gelmini
Please see Julien comment here: https://gerrit.libreoffice.org/c/core/+/100871 Change-Id: I8188d2b26cab24f39630151d256104f633252b98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100920 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2020-08-26remove slowparser stuff from SvXMLStyleContextNoel Grandin
Change-Id: Ic4efc2eba7d1cdd71df76b535811c706bab3860e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101347 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-26use fastparser in SwXMLStylesContext_ImplNoel Grandin
Change-Id: I81075b44ec8417bf0126aa5a64389b434c1247f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101345 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-26CppunitTest_sw_htmlexport: The actual PNG data does not matter.Jan Holesovsky
The test was supposed to test whether the PNG data is embedded (or not), not the actual content of the data. Turns out that a different zlib affects the PNG content, so let's ignore that part, and only check that the data is actually embedded. Change-Id: I603bd546d97abda7c47248db0a95349f4a48b4aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101329 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-26use fastparser in SdXMLStylesContextNoel Grandin
Change-Id: I5cf46f6ba8366c92a18d1cc00eb7eebf8ae82be6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101343 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-26use fastparser in OTableStyleContextNoel Grandin
Change-Id: Ied05d161811c3b87d00cd99c56940a9f66cb4e59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101342 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-26use more fastparser in XMLTableStyleContextNoel Grandin
Change-Id: I558459138f3d4191b6ecdcf726d022497dbb9f06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-26Only check X11/Intrinsic.h when $ENABLE_JAVAMike Kaganski
See Stephan's comment at https://gerrit.libreoffice.org/c/core/+/101341/2/configure.ac@10059: > that file is only compiled (via bean/Module_bean.mk -> bean/Library_officebean.mk) > when ENABLE_JAVA, so that should arguably be reflected here Change-Id: I648543cd7b71b88a29fd52483f2d97e53d3c23dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101374 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-25ofz#25174 build failureCaolán McNamara
Change-Id: Ied1b29ff4625d7d7fb847ab08df498dfdaf6f3c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101346 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25Check for X11/Intrinsic.h required by officebeanMike Kaganski
Change-Id: I49b6868c2896c4aa5a70c2517c2f35f3ea475f2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101341 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-25unused suppressionsCaolán McNamara
Change-Id: I6dcedc63bbca7e93ffbda135e4d596a2f709abf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101339 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25GetProperty extracts property to mAny alreadyCaolán McNamara
so its already available to assign to nVal and doesn't need to be refetched Change-Id: Ie4ed1a63873847007c85fca24aff0724ee7e65c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101338 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25tdf#135018 sw_redlinehide: fix accept delete redline at start of bodyMichael Stahl
There is no predecessor text node. (regression from 34b32f56e7f76639ee3a31cfc230a3340acf635a) Change-Id: I5f6a1a7a1a35a2a6e600166dc1afcf6c4bf9d389 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101337 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-25use more fastparser in OReportStylesContextNoel Grandin
Change-Id: Ie8126206d9144ccba1fb120d47af9ebe35a345d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101320 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-25(related: tdf#132160) sw: fix lcl_RejectRedline if end is on table nodeMichael Stahl
This happens on Undo: sw/source/core/undo/undobj.cxx:1394: void SwRedlineSaveData::RedlineToDoc(const SwPaM&): Assertion `result != IDocumentRedlineAccess::AppendResult::IGNORED' failed. Because the SwRedlineSaveData was created in SwUndoDelete ctor from this: (rr) p *pRedl $18 = (SwRangeRedline) { <SwPaM> = SwPaM = { point = SwPosition (node 13457, offset 0), mark = SwPosition (node 13455, offset 0) }, (rr) p pRedl->GetPoint()->nNode.GetNode().GetNodes()[13457] $19 = (SwTableNode *) 0x80bdbe0 DelFullPara() will delete the end node, see "m_rDoc.GetNodes().Delete( aRg.aStart, nNodeDiff+1 );" or equivalent in SwUndoDelete. So if the end is on a start node, set it back to the previous node, because deleting just a start node is a bad idea. Change-Id: Ib7c35c103ce05ede39e66505fa47fa70bfece018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101334 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-25crashtesting: exceptions thrown on export to xlsxCaolán McNamara
e.g. ooo37900-1.xls since... commit 5e8875780d665b7ae0fee1a053b5ce78ec513f69 Date: Mon Aug 17 10:55:43 2020 +0200 tdf#135828 XLSX shape export: fix distortion of rotated shapes Change-Id: Ib426486d9ea8be5d9a4eaa3a8e02bc849af683d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101333 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25tdf#127802 support tristate for hidden/unhidden textCaolán McNamara
Change-Id: I9a8ad72ae3ee45ac2521e662b17d3d22d98aa055 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25-Werror=maybe-uninitializedNoel Grandin
which only shows up in an optimised build, using gcc Change-Id: I16015c7d139680aba11bf183c3e2bceb79c9ecba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101330 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-25tdf#132160 sw_redlinehide: more pathological redline problemsMichael Stahl
This is similar to 63dba5203e8bc7fc390943cb8208ae904f18e3bb except here the redline starts with a section (in particular an entire alphabetical index); this one is at node 13489 to node 14206. There's another fun one, starts with a table but has a text node following it, at node 8222 to 8231; this case also wasn't handled correctly at least in one direction. Fix that by continuing iteration of text-nodes once table/section at the start are handled. (regression from d258fc29560baa5ecae03ebc2740e11420643e27) Change-Id: I3f75ad473881f01be80d2c3804b9ac209f430bdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101287 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-25Related: tdf#135965 don't install accel group on adapterCaolán McNamara
it already has a suitable one in this case Change-Id: I177e7c690ea91c82ac9a4e5fe21e40f2e2992992 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25dont turn on malloc debugging for gdb itselfNoel Grandin
fix the command such that, when we insert the malloc debugging env vars, we only do it for the executable itself, not for gdb, or some gdb operations will be very very slow. Before this fix, if I did a make Cppunit... CPPUNITRACE=... ran the program, then ran it again, the second time would take 5 min to get going. Now the second time it runs in seconds. Change-Id: Id08c3a82679164588b88af65a6a7b5f7dd19ff05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101318 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-25tdf#136094 Handle background color in drawNativeControlMichael Weghorn
Make gtk3's 'GtkSalGraphics::drawNativeControl' take into account a control's background color, if any is explicitly set: Set background/fill color (in 'Edit::ApplySettings') also for the case where the control is drawn "natively", but don't draw the background in the generic 'Window::Erase' method for the case of native drawing; instead handle it when drawing the control itself. This adds an additional parameter to pass the background color to the relevant '{d,D}rawNativeControl' methods (defaulting to 'COL_AUTO') and implements the required handling to apply the background color for the gtk3 case. qt5/kf5 will probably be handled in an upcoming commit as well. Windows as well as the "gen" VCL plugin were not affected by the issue, so remain unchanged and just ignore the new parameter. In a quick test on on macOS, the rendering of the controls in the sample doc was broken beyond just the missing background colors (s. screenshot attached to tdf#136094); the behavior there also remains unchanged by this patch, the new parameter is ignored for now. Change-Id: I01923a504fea2367ae96032104f09099e35f410e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101284 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Michael Weghorn <m.weghorn@posteo.de>
2020-08-25use more fastparser in PageStyleContextNoel Grandin
Change-Id: I1de96a68881e5f035c34136cd3ad89fa7cad29ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101310 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-25Related: tdf#135965 return true to show event was handledCaolán McNamara
Change-Id: I87ee0f990bf2c908a28bd212bdef870d245a9282 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101313 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25Resolves: tdf#135965 distinguish between press and releaseCaolán McNamara
Change-Id: I537d052e80875d75334cfc72c93fd7d90bf2f888 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101312 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25Sidebar: glow.ui file simplifyandreas kainz
Change-Id: Ie9b16ee45f5a3c8d0c0aadaf90c7807aa06b7d9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101309 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-08-25tdf#123388 sw: add PRODUCT table formulaLászló Németh
for DOCX interoperability. Change-Id: Icd19d1e0025e76bc3ff00a347fa2743ed7c8ee06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101306 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-25tdf#135334 Add keyboard shortcut to launch SIShivam Kumar Singh
Change-Id: Id4e911e36527395eb0ed5f29a089a66e0908e882 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100835 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-08-25tdf#133026: Additions: Set label of install button for installed extensionsYusuf Keten
Change-Id: Ic45f5684c1b483e294179e151d6beec34de2e004 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101297 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-25use fastparser in PageStyleContextNoel Grandin
Change-Id: Iaa433e5c8c5712bbcbef519c613927dbffa22906 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101305 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-25use fastparser in XMLFontStylesContextNoel Grandin
Change-Id: I122216400ae5f97bc2a757146f84f146ba92afb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101303 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-25make drawing item border optionalCaolán McNamara
Change-Id: I8310f77c9e90f3f95a519069709a9d465268eb55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101026 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25move thumbnailviewitem.hxxCaolán McNamara
Change-Id: I151a98e34f7ae31dfe6a21fc1e9d0e7aa944248e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101025 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25Derive ActiveColor as a brighter HighlightColorCaolán McNamara
and use it opaque in thumbnail views so the selected item is always Highlighted but appears brighter when hovered over, leaving the non-selected items using transparent Highlight Change-Id: If0cbc05b779d230332e821aa7fac68a08ac40c41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101184 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25add a getCaretPositions like getTextArrayCaolán McNamara
Change-Id: I6f5ab6c659a7b6827c1c5f017a740173806504d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101291 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25drop unused suppressionCaolán McNamara
Change-Id: I87d2c5802ffd38d342d945df316c942bb2c3402e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101290 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-12 17:31:47 +0000