summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-03-29Pushing a few Tango icons before I forgetAdolfo Jayme Barrientos
Change-Id: I77cef00c720696810413b9fb419a01e4781c8862
2017-03-29vcl PDF export, norefxobj: add UI for thisMiklos Vajna
Disable the "use reference XObjects" (old behavior) by default, but keep it as an option in case someone wants it. Summary till the help is updated: the old way is simpler code, so it's always correct, but really only Acrobat supports that markup. The new way is supported by all readers, but more complex, so it's more likely it goes wrong. Change-Id: I4769474f29d98412be496a0aa4e8254ae4f0919e Reviewed-on: https://gerrit.libreoffice.org/35826 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-29oox: remove redundant virtuals, implied by overrideMiklos Vajna
Change-Id: Ia72aa17e82ccdf78b0581228b84ffafc1f6be4ba Reviewed-on: https://gerrit.libreoffice.org/35824 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-29Add warning about intended use case of debug helperTor Lillqvist
Change-Id: I685509a92653112f2bbbfc970db3706b5a9bf994
2017-03-29expand vis to visible; fix typosdennisroczek
* translate German source code comments * remove bogus surce code comments * remove ascii art * removed old StarOffice/Sun internal bug tracker references * remove left over from commit dcd5dee88e3c1185638b190553bef65c2ef6566f Change-Id: I3c5cce621c43e4a03afb76f4cc5a12065914e5ad Reviewed-on: https://gerrit.libreoffice.org/35404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-29tdf#106792: Fix "Geometry" property of changed-to-bezier SvxShapePolyPolygonStephan Bergmann
After "Convert to Curve" as described in the issue, the shape apparently is still an SvxShapePolyPolygon shape but with getShapeKind() of OBJ_PATHLINE instead of OBJ_PLIN (and same for OBJ_PATHFILL). That causes XMLShapeExport::ImpExportPolygonShape (xmloff/source/draw/shapeexport.cxx) to determine bBezier == true and thus expect the obtained "Geometry" property to be of type css::drawing::PolyPolygonBezierCoords, not merely css::drawing::PointSequenceSequence. Smells like this issue had always been present, and would have caused bad memory access when accessing the non-css::drawing::PolyPolygonBezierCoords object in XMLShapeExport::ImpExportPolygonShape, and only now throws an exception since 0d7c5823124696f80583ac2a5f0e28f329f6f786 "New o3tl::try/doGet to obtain value from Any". Change-Id: Ica31a114e5beac97bac2a1c509eb1a85f8354d5e Reviewed-on: https://gerrit.libreoffice.org/35825 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-29Attempted fix for mirrored geometry crasher.Michael Meeks
Only plausible cause is pWindow->GetParent() being null, while we have a pParent which has to be valid. http://crashreport.libreoffice.org/stats/crash_details/6161398d-17b6-4a93-aa70-a559efa07868 Code was initially introduced in this form: commit 4716735ba7d0ad133ff018481f94d6b4f201bbd9 Author: Stephan Schäfer <ssa@openoffice.org> Date: Thu Sep 19 15:46:19 2002 +0000 #103362# improve positioning and resizing of system windows No public report, sadly. And modified by commit fba46c6efd08d50fee92cc11546f3ed253a57af8 Author: Chris Sherlock <chris.sherlock79@gmail.com> Date: Mon Feb 3 16:46:04 2014 +1100 fdo#74424 Use Window::GetOutDev() to access ImplReMirrored() Part of the decoupling of Window from OutputDevice. We now get he Window's OutputDevice instance and manipulate this. Do not rely on the inherited function. where the GetParent()/pWindow->GetParent() problem surfaces Change-Id: Ia261028a4719525135e3fe4b00074427c1d9df6c Reviewed-on: https://gerrit.libreoffice.org/35796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-03-29loplugin:singlevalfieldsNoel Grandin
Change-Id: I7f05903aaab9b0b274358243d680d0c30694ae61 Reviewed-on: https://gerrit.libreoffice.org/35804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29Add note that the xmlMissing thing is not implementedTor Lillqvist
Customer was not interested after all, so dropping the attempt for now. Change-Id: I9a0afb6add66efbd43ee67ba0a8d0b1f79c5a7be
2017-03-29Fix typosAndrea Gelmini
Change-Id: I379c3f8ca971e6180744fb7270dde9164ebcec1a Reviewed-on: https://gerrit.libreoffice.org/35814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-29Close already calls unlockFileMarkus Mohrhard
Change-Id: I2c9cc94de1b43555b3bdfbed9a476802e1c97733 Reviewed-on: https://gerrit.libreoffice.org/35818 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-28tdf#90290 use custom asserter in shared_test_impl.hxxkerem
Change-Id: I00bbd0fb3f63f5641fea75ce0cb797e5f2252fa2 Reviewed-on: https://gerrit.libreoffice.org/35669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-28typo: Didn't found -> Didn't findAndras Timar
Change-Id: Idbaca4fe90cb943124cded56d8b031a66e488c1b Reviewed-on: https://gerrit.libreoffice.org/35776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-28tdf#90290 use custom asserter in ucalc_sharedformula.cxxkerem
Change-Id: Ica0e0aed177c47e402e573d53df54ab6ea4ad15d Reviewed-on: https://gerrit.libreoffice.org/35727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-28Fix typosAndrea Gelmini
Change-Id: Ibef75de246fb31884153437fe8c05e299fe5962f Reviewed-on: https://gerrit.libreoffice.org/35782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-28tdf#106755: Fix script type for combining marksKhaled Hosny
We are classifying characters in the “Combining Diacritical Marks” Unicode block with ScriptType::LATIN, but these are combining marks and can combine with any script and should have been ScriptType::WEAK. Just removing them from the range in scriptList does the trick as we will fallback to getting the script classification based on the Unicode script property. Change-Id: I3577f4b03360a1c8e094a207f01b6bbb6abbaf30 Reviewed-on: https://gerrit.libreoffice.org/35811 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-28fix too small loop varJochen Nitschke
Change-Id: Icaa64ac579a55f53fb1397e5eeee6dcc4c9d37cc Reviewed-on: https://gerrit.libreoffice.org/35802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-28it makes no sense for CC to leak resources when its unaware of modelBjoern Michaelsen
- if the UNO_QUERY_THROW cast throws, this skips all of the disposing (and thus leaks) - the whole try-catch-ignore case has been there since early c6b95527 - even in that commit message, no sane justification has been given - apparently the try-block was Java-style "catch exceptions until it runs" cargo-cult - this change is still the more conservative change: probably the whole try-catch framing should be removed Change-Id: Ie3a71e48eb056afd8a844e19898dc1555de4297e Reviewed-on: https://gerrit.libreoffice.org/35690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-28ofz#954 out of memoryCaolán McNamara
Change-Id: Ib27f2dfe0d0837544910208f38a1bc11a35e3cb4 Reviewed-on: https://gerrit.libreoffice.org/35794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-28vcl PDF export, norefxobj: have the list of keys to copy at one placeMiklos Vajna
To avoid repeting ourselves. Change-Id: I39667620b9cf391251327c8f66ad8b9649ead36f Reviewed-on: https://gerrit.libreoffice.org/35810 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-28Turn XclSupbookType into scoped enum and add operator<< for SAL_INFO etcTor Lillqvist
Part of preparatory work for handling xlExternalLinkPath/xlPathMissing. Change-Id: I29b77bb2680e4dbf293ab65bda5401afee132f11
2017-03-28Bin an unused and a used-once typedefTor Lillqvist
Change-Id: I3f93378889d2c8eb0476dba4a4ea5aca31647f5c
2017-03-28tdf#106693 vcl PDF export, norefxobj: handle multiple refs in copied arraysMiklos Vajna
Also fix confusion about dictionaries in arrays and arrays in dictionaries. Change-Id: I0d71d5796b1eb4f89e3fd9a5b1f807d2a7340a35 Reviewed-on: https://gerrit.libreoffice.org/35806 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-28First steps to round-trip xlExternalLinkPath/xlPathMissing thingsTor Lillqvist
Links to broken or missing external workbooks in .xlsx have the relationship type http://schemas.microsoft.com/office/2006/relationships/xlExternalLinkPath/xlPathMissing . Ideally we should round-trip those (save identically back to .xlsx). Currently we don't save them at all, and Excel doesn't like formulas that refer to such external (but not mentioned in externalLinks) workbooks. Just a start, does not actually produce anything useful yet. Change-Id: Ic5a481c91864134f1caf66c56a4aef685d3018a7
2017-03-28Resolves: tdf#106748 infinite dashed line from annotations to FAR_AWAY thingsCaolán McNamara
we (very irritatingly) create dashed lines by creating a sequence of dash drawing layer objects, so if its hugely long we create a hugely long sequence Change-Id: I38a0c6052cf058d5e02ebef7dd6a90e27f6e5454 Reviewed-on: https://gerrit.libreoffice.org/35781 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-28std::unique_ptr<sal_uInt16[]> -> std::vectorCaolán McNamara
Change-Id: I708e1f24e14bc21f40cf4d5a2d3e6f849b6f7762
2017-03-28move inlines into the classCaolán McNamara
Change-Id: If185834c35c9aa7d48e3305cfee3fde47826180f
2017-03-28valgrind: use of uninitialized valuesCaolán McNamara
Change-Id: I5b8c6d4d4576fd88dbffdfc710cbd9b2e9429942
2017-03-28Resolves: tdf#106155 avoid opengl for toplevel X window iconsCaolán McNamara
because an opengl context requires a toplevel window so it recurses to death. Only the gen/kde4 vclplugs are affected here Change-Id: If5396d183d90d1872931b170dc90c3a70d8ea6b6
2017-03-28remove some more unused SID constants and commandsNoel Grandin
Change-Id: Ibf2bb58ca687c18798328ed86cd549d64f3621b4 Reviewed-on: https://gerrit.libreoffice.org/35792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28tdf#106693 vcl PDF export, norefxobj: copy nested arrays correctlyMiklos Vajna
When copying an array we're only interested in the start/end position of the outermost array, otherwise only part of the array is copied. Change-Id: I9f5cb5e3ed395142fd82db34e1153ddfdf9f0eb3 Reviewed-on: https://gerrit.libreoffice.org/35797 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-28update results of mergeclasses pluginNoel Grandin
Change-Id: I97f67bb7f98d0cf0a835f55e12c24a30ffd4ed3d
2017-03-28fixes for some lopluginsNoel Grandin
ran the ones in store/ just for fun, but didn't find anything useful Change-Id: I2bb251e8d99b5d88e11b2ca74e99672d75f0a1fd
2017-03-28tdf#96505 Get rid of cargo cult "long" integer literalsThomas Beck
Removed "long" integer literals where applicable in some files of xmloff module Change-Id: I96f44c00583a95f8a0ae6acf25f439936433ac08 Reviewed-on: https://gerrit.libreoffice.org/35798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-28tdf#39468 Translate German commentsJens Carl
Translate German comments and terms in basctl/ Change-Id: I9f284af4d92e61b53a3280c151a37b1dcbeed7c4 Reviewed-on: https://gerrit.libreoffice.org/35791 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-03-28tdf#39468 Translate German commentsJens Carl
Translate German comments and terms in basic/ Change-Id: I8baf76ea866823a155dfa25c74149dac989c841c Reviewed-on: https://gerrit.libreoffice.org/35793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-28SFX_SLOT macro is unusedNoel Grandin
Change-Id: I29ef05eda5a6e552d497e42220f36200401a3ef1 Reviewed-on: https://gerrit.libreoffice.org/35795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28tdf#39468 Comment translation GER-ENGThomas Beck
translated comments in sw/source/filter/ww8par3.cxx Change-Id: I40b41cecb1c73b9678c51d7e4dc41745a96a243f Reviewed-on: https://gerrit.libreoffice.org/35765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-03-28tdf#106694 RTF import: fix missing paragraph tab positionMiklos Vajna
The problem here was that while in general paragraph style / direct formatting deduplication is supposed to happen in the tokenizer, paragraph tab positions is an exception, and dmapper expects to see the duplicated tokens. Fix the problem by introducing a blacklist that contains tokens not to deduplicate. Change-Id: I1cca53e99cfdb082df389ff295f3447cc8f9d3b8 Reviewed-on: https://gerrit.libreoffice.org/35790 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-28tdf#42949: clean up includes in include/svx/[a-c]* with iwyuJorenz Paragas
Change-Id: I7768f4dbe9892c4264cb16eed87497894aa7494e Reviewed-on: https://gerrit.libreoffice.org/26582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-28remove enum slot code from sfx2Noel Grandin
since we only used it for the pseudo-slot stuff, which is now gone Change-Id: I72146090e7741d5b71d581fa0b5c6d43c154445a Reviewed-on: https://gerrit.libreoffice.org/35759 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28remove PseudoSlot support from idl compilerNoel Grandin
Since we have removed the last usage with commit 12c6caa84a61f23df996a0396432fa4b8d5c4785 "Kill remaining PseudoSlots usage" And remove corresponding support from the list-dispatch-commands script. Also remove the now unused SFX_NEW_SLOT_ENUM macro Change-Id: Id07c431de4404acf61a8bdd3507e390e5249879a Reviewed-on: https://gerrit.libreoffice.org/35754 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28ofz#955 timeout in lwp loadingCaolán McNamara
Change-Id: I3665bd870cd601f2ac7fee59c087034d406ed07c
2017-03-28sc: include cleanup for --enable_formula_loggerJochen Nitschke
don't include osl/file.hxx everywhere it's only needed for --enable_formula_logger builds Change-Id: I6ba30351b5a7afe975ea859e838930f9d1454c8c Reviewed-on: https://gerrit.libreoffice.org/35766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-03-28tdf#105975 Add Set field parsing (docx) in LibreOffice WriterJean-Sebastien Bevilacqua
Introduction ------------ In MSWord, you can create a variable with `SET` field and then reference it later in a formula. When you save your file as `docx`, this `SET` field is registered in you file. In its current state, LibreOffice can't parse the `SET` field in `docx` file. Context of this fix ------------------- This fix is entirely located in the `DomainMapper_Impl.cxx` file because it's where the parsing is done. How this fix works ------------------ First, we add `SET` support by adding it to the `aFields[]` variable. Next, to handle the `SET` constant, we add a condition (swith case) in `DomainMapper_Impl::CloseFieldCommand()` to call `handleFieldSet`. Finally, `handleFieldSet` works like `handleFieldAsk` with small differences. Note ---- I have renamed `lcl_ExctractAskVariableAndHint` to `lcl_ExctractVariableAndHint` because this function is used for both `ASK` and `SET` fields. Change-Id: I2bf948e26e8506ac151d1d0bc8556721bbe0392b Reviewed-on: https://gerrit.libreoffice.org/34333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-03-28remove unused interfaces from sdi filesNoel Grandin
Change-Id: I69e880e348372b3695b14efd4928f38f29bda37e Reviewed-on: https://gerrit.libreoffice.org/35747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28remove unhandled SID commands from sfx2Noel Grandin
Change-Id: I5473dbb1fdc2c3779892610ab4ea5f6146291921 Reviewed-on: https://gerrit.libreoffice.org/35742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28remove unhandled SID commands from svxNoel Grandin
In this case, also remove those unhandled commands which are present in a *Commands.xcu file, but not in any other kind of .xcu file. Change-Id: I8b42df7357349872e28d3ee60ec2c0505358cff6 Reviewed-on: https://gerrit.libreoffice.org/35648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28tdf#105843 : restore Application Start and Stop eventsJean-Baptiste Faure
Change-Id: Ifc99fcf84182edb49cac741f7bb10a1b239d5703 Reviewed-on: https://gerrit.libreoffice.org/35779 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28starmath: Refrain from skipping an extra token at missing "}"Takeshi Abe
which is for closing "stack {". Change-Id: I2161507634fdb33583053168acfcb87754765652 Reviewed-on: https://gerrit.libreoffice.org/35784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
generated by cgit (git 2.34.1) at 2024-08-13 17:30:54 +0000