summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-30loplugin:stringloop in svgio..xmlsecurityNoel Grandin
Change-Id: I1b2fe5674c8350690efc3d3219b9273cc61d5b0c Reviewed-on: https://gerrit.libreoffice.org/58332 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:returnconstant in xmloffNoel Grandin
Change-Id: Ia837a93ae817df282096abb80efcbd6922867b25 Reviewed-on: https://gerrit.libreoffice.org/58335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:stringloop in swNoel Grandin
Change-Id: Ie316aee8d1e4f772dc25725b46e130c6717458c2 Reviewed-on: https://gerrit.libreoffice.org/58331 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:returnconstant in sfx2Noel Grandin
Change-Id: I9a41a2b53669bebfca573fef8d0d755e4621ce37 Reviewed-on: https://gerrit.libreoffice.org/58333 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30sw doc model xml dump: dump float value of user fieldsMiklos Vajna
Change-Id: Ie59070254eb293cbfdd688d97bf4bb6c06e77a79 Reviewed-on: https://gerrit.libreoffice.org/58339 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-30Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I84a9dc3e41e13faa50017644e4bc9c80eb9b8ed5 Reviewed-on: https://gerrit.libreoffice.org/58299 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-30Added SdrObjectLifetimeWatchDog for debug modeArmin Le Grand
Change-Id: I79f65b7511d400c3e7071e45c3f0b1d385bcd8d4 Reviewed-on: https://gerrit.libreoffice.org/58197 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-30tdf#118971: allow arrow keys to move images or drawing objectsXisco Fauli
Partially revert 2d5ce0e1b233c83f91481cd6b9306ac8de7f5ff8 Change-Id: Ie4c91529c1ce878f4b0474d815a3a88ed48769c2 Reviewed-on: https://gerrit.libreoffice.org/58318 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-30Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories scripting, sd, sdext Change-Id: I47889cd889cf1d68353184229bfd4712f1528fbf Reviewed-on: https://gerrit.libreoffice.org/58220 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-30sw doc model xml dump: cover SwValueFieldMiklos Vajna
Also SwUserField. Change-Id: Ie8a8ca997e5b89bcf6b40363721e9caaeb60f696 Reviewed-on: https://gerrit.libreoffice.org/58325 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-30tdf#106374: lock view when updating indexMike Kaganski
Change-Id: I745f8b66cb79c8738dba6fcdd58b8597e604f6fd Reviewed-on: https://gerrit.libreoffice.org/58091 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-30tdf#118869: mark some properties secure to pass them to elevated installMike Kaganski
See also http://helpnet.flexerasoftware.com/installshield19helplib/helplibrary/ISBP10.htm Change-Id: I217d68f98af8e56874af6c071bb7fa7354b3e4b4 Reviewed-on: https://gerrit.libreoffice.org/58326 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-30Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from l10ntools to reportdesign Change-Id: Ia2dc93dd848c2dc0b6a8cb6e19849c614ec55198 Reviewed-on: https://gerrit.libreoffice.org/58205 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-30svl: turn on clang-format for grabbagitemMiklos Vajna
I (tried to) keep these files consistent manually in the past, switching to clang-format makes sure that the recent problem with introducing inconsistencies in these files doesn't happen again. Change-Id: I94e7f846c0d3361082d74a2883486c9aa67ed362 Reviewed-on: https://gerrit.libreoffice.org/58322 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-30deque could be a vector insteadCaolán McNamara
reduces peak memory from 90M to 65M Change-Id: Ia30309b7a1adf0736c1e84b2aafcd8b10b7fea8c Reviewed-on: https://gerrit.libreoffice.org/58324 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-30tdf#108461 Correct use of the default styleMaxim Monastirsky
The underlying issue was fixed by Miklos in commit 9d754a59154c40235c240bb0e7f47a2006fa85bd ("sw: give the 'Default Style' char style a programmatic name"). What left is to actually use the internal name in various UI elements. Also removed a comment that tells to not rename the default style, which isn't relevant anymore, as we no longer write the UI name into files. Change-Id: Ie2ab632e40b4fc6295f2c9d1a1f1f2358ab38e52 Reviewed-on: https://gerrit.libreoffice.org/58311 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-07-30Related: rhbz#1602589 rework to avoid bogus cppcheck double free warningCaolán McNamara
Change-Id: Ie673de68f39b903536c2287b8989fe6afcc9fd66 Reviewed-on: https://gerrit.libreoffice.org/58307 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-30harfbuzz-rtti.patch doesn't applyCaolán McNamara
Change-Id: Ia634c008799793f3a54354a3f7fc13446f7db3c5 Reviewed-on: https://gerrit.libreoffice.org/58302 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-30fix bug in SwXMLTextBlocks::CopyBlockNoel Grandin
would have created a name that looked like xxxx123456789101112 etc, which is probably not what it wanted Change-Id: I4ebdf1444fc12d57762463075ca0dea2cc046dd7 Reviewed-on: https://gerrit.libreoffice.org/58309 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30fix OT font feature description ssxx and cvxx mixupTomaž Vajngerl
Change-Id: I20e169fede237e4760f8be905e70a3ed964c402f Reviewed-on: https://gerrit.libreoffice.org/58305 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-30Resolves: tdf#118965 fix input list edit buttonCaolán McNamara
regression since... commit 7d5245848c28f5786258476cd7aa2a4523645de3 Date: Fri Sep 15 17:39:48 2017 +0200 tdf#79877 revert to old behavior when clicking on input fields. Change-Id: I5e67a8f0c8d2599c139d3d728298c30f4a31c8d1 Reviewed-on: https://gerrit.libreoffice.org/58313 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-30SHELLCHECK_WARNING, VERBOSE is unusedCaolán McNamara
gengal.sh was originally based on unopkg.sh which had this --verbose switch... commit 164027e48899faaee284242eaca04b8aa5545319 Date: Fri Apr 5 16:39:24 2013 +0100 gengal: re-base on original tool. new wrapper based on unopkg.sh. work re-based on original SUSE implementation. and unopkg.sh later had VERBOSE removed... commit 1fc195f7e830619d56cc4c56043b154bc3a72b02 Author: Stephan Bergmann <sbergman@redhat.com> Date: Thu Oct 17 15:34:53 2013 +0200 Simplify code (VERBOSE was unused) but gengal.sh retained its unused VERBOSE variable Change-Id: I56aa830aef829c7727550fcaf7aed5058fffdc78 Reviewed-on: https://gerrit.libreoffice.org/58308 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-30workaround msvc compiler warningCaolán McNamara
warning C4315: 'WW8_FFN': 'this' pointer for member 'WW8_FFN::sFontname' may not be aligned 8 as expected by the constructor Change-Id: Ic23b79c7da5f435f72cf3d1d3052d7a6926e5dce Reviewed-on: https://gerrit.libreoffice.org/58303 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-30sw: prefix members of SwHyperlinkIter_Impl and SwInputFieldMiklos Vajna
Change-Id: I35bb9f6624a74c8351c094355434417790d6027d Reviewed-on: https://gerrit.libreoffice.org/58301 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-30loplugin:stringloop in sfx2..svxNoel Grandin
Change-Id: Ie4ca2421f00259f974b6d94f883adfa11600b1fe Reviewed-on: https://gerrit.libreoffice.org/58251 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30avoid writing StringBuffer twiceNoel Grandin
Change-Id: Ib0a8914cc1967f89a2cd3b062e7a0b52de7a972c Reviewed-on: https://gerrit.libreoffice.org/58281 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from filter to jvmfwk Change-Id: I2a73d63f2aaef5f26d7d08957daaa8a30b412ac5 Reviewed-on: https://gerrit.libreoffice.org/58204 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-30make DBG_TESTSOLARMUTEX available in assert buildsNoel Grandin
where our QA people are more likely to trigger it Change-Id: I4ce7c8c72e7e21f2296c0f9cc9f019aaef32ed0b Reviewed-on: https://gerrit.libreoffice.org/58170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30related tdf#72560 ooxmlexport3: fix tinderbox long -> sal_Int32Justin Luth
Change-Id: Ifb522c5488aeadc327116bef8a21adef16e3e711 Reviewed-on: https://gerrit.libreoffice.org/58300 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-07-30loplugin:useuniqueptr in SwTOXStylesTabPageNoel Grandin
Change-Id: I566ac5f9c334cfdfe879cdb0eef921fcc9a7be8d Reviewed-on: https://gerrit.libreoffice.org/58243 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwMailMergeLayoutPageNoel Grandin
Change-Id: Ia8411b8efa792fe06f25765a2aa4d479c66f1ec5 Reviewed-on: https://gerrit.libreoffice.org/58249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwSendMailDialogNoel Grandin
Change-Id: I653066c25fd627d98e63f7ae94a56954c9c01583 Reviewed-on: https://gerrit.libreoffice.org/58248 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwInsertDBColAutoPilotNoel Grandin
Change-Id: Ida2be4abdeb6788ec9074a81c927e99e633ce394 Reviewed-on: https://gerrit.libreoffice.org/58247 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwCreateAddressListDialogNoel Grandin
Change-Id: I4d118e6f4db66beb3553eeead2a36cbb8bec45be Reviewed-on: https://gerrit.libreoffice.org/58246 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwTitlePageDlgNoel Grandin
Change-Id: I8e68950b311e78dd7bb71d282728a92f98bcccbb Reviewed-on: https://gerrit.libreoffice.org/58245 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwModalRedlineAcceptDlgNoel Grandin
Change-Id: I3c22604a838406d88a324381affbf72d6608235d Reviewed-on: https://gerrit.libreoffice.org/58244 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwNumPositionTabPageNoel Grandin
Change-Id: Ie0ad1694df7429080f2a296bb72370c6e70c97d4 Reviewed-on: https://gerrit.libreoffice.org/58242 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwTOXSelectTabPageNoel Grandin
Change-Id: Idfc3298ef74a3bdde55f2091dc035c5133413dd2 Reviewed-on: https://gerrit.libreoffice.org/58241 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwGlossaryDlgNoel Grandin
Change-Id: I46df74af9eae2cedc7121d6454e92faf03321c63 Reviewed-on: https://gerrit.libreoffice.org/58240 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwMultiTOXTabDialogNoel Grandin
and use a std::vector and a custom struct for storing stuff instead of a rrays and a separate count field Change-Id: Ic1063ed0bfdc06f83a01d18503ccf6f9503f5b9d Reviewed-on: https://gerrit.libreoffice.org/58239 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwGrfExtPageNoel Grandin
Change-Id: Ic71cf09b6a443f6918b074010fe53ea0843bf246 Reviewed-on: https://gerrit.libreoffice.org/58238 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwCaptionDialogNoel Grandin
Change-Id: Ibf49f18ed43bb24a3ef79a0c7862b0dbd2698f3d Reviewed-on: https://gerrit.libreoffice.org/58237 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwColumnPageNoel Grandin
Change-Id: I36cd9ba0c64073ae09d8ab8e2119d1404cbb02f1 Reviewed-on: https://gerrit.libreoffice.org/58236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwColumnDlgNoel Grandin
Change-Id: I115ee37ce3fffa26bbaf011ae2c5aa3427059b5e Reviewed-on: https://gerrit.libreoffice.org/58235 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwJavaEditDialogNoel Grandin
Change-Id: Iccd0cafdc6ac454f125da0f5a1df214d2463a2c5 Reviewed-on: https://gerrit.libreoffice.org/58234 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwLabDlgNoel Grandin
Change-Id: Ie2a54b88e821041ecea6c84ea402486a76ba1f31 Reviewed-on: https://gerrit.libreoffice.org/58233 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwInsertSectionTabPageNoel Grandin
Change-Id: I22ffd16c26c837c8989d9c1875e5f809695ea27c Reviewed-on: https://gerrit.libreoffice.org/58232 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwEditRegionDlgNoel Grandin
Change-Id: I59137a86744db372c9067a1b88b76654016a1823 Reviewed-on: https://gerrit.libreoffice.org/58231 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwEnvDlgNoel Grandin
Change-Id: Ie907974dcdeb6f7f30801fc502d919afdab734f3 Reviewed-on: https://gerrit.libreoffice.org/58230 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30loplugin:useuniqueptr in SwStdFontTabPageNoel Grandin
Change-Id: I9ae756cfbdb1cd1f8a257d34b4e7045143bb92b9 Reviewed-on: https://gerrit.libreoffice.org/58229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-19 08:33:17 +0000