summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-12-22use precalculated members of GeoState..Noel
.. in a couple of places that seem to have been missed. Change-Id: I5e40b46614fe07cd8b47f7148e3e5ec130dd05b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108146 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-22That wasn't a reliable way to detect Apple JDKStephan Bergmann
The check had been introduced with 16c0807d75cfd9ecbca9c703ed0eadda80529aab "configure: reject Apple JDK", but with 7db048f62929a9d267b63db3a6ea2b58b47ec757 "Manually select JDK outside /Library/Java/JavaVirtualMachines on macOS" it works fine to configure --with-jdk-home= a (non-Apple) JDK installed outside /Library/Java/JavaVirtualMachines. If anybody thinks a check to reject Apple JDK would still be useful, and knows a reliable way to detect it, feel free to add back a fixed check. Change-Id: I18910d992e3d1fc6fd8fc4b9d522aec0cce3e652 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108144 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-22rename members of GeoStat classNoel
to make it obvious what they are used for. Change-Id: I8ed825ea0131faa969fa3fd69cd64d195ef61b6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108145 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-22more jumbo sheet workNoel Grandin
Change-Id: I67884a0c0b897d8d60f2cfaba644e01f90f7d164 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108123 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-22Fix typoAndrea Gelmini
Change-Id: Ia0240b8c601e75564109744bb068b7e156384429 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108121 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-22Use gtk_box_pack_start/gtk_grid_attach (vcl/gtk3gtkinst)Julien Nabet
Change-Id: I2b6552e9fcd896a2d9552f81e3b730c82ff3878f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108078 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22use small-button style to remove GtkLinkButton left marginCaolán McNamara
Change-Id: I21a2c97a2d60390f97f84b15a42e2f14edd6d59e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108117 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22drop deprecated 'rules-hint'Caolán McNamara
Change-Id: I8b41ca34d6b751a8086a4a1879a42520dcd9b6fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108116 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22replace deprecated xpad/ypadCaolán McNamara
drop entirely suspicious xpad/ypad which are probably accidental Change-Id: Ie80d93502359373e38cc61f63cd5bec962f5d193 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108115 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22remove deprecated (and unwanted) GtkEntry shadow-typeCaolán McNamara
Change-Id: I5f6efbb4c4e2f9e928a6359d32da4a62cd3556bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22replace margin-left with margin-start and margin-right with margin-endCaolán McNamara
Change-Id: Iee3cc8c22b393ca420d0ed68673c61fe7ef240ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108113 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22SotStorageStream does not need to extend SotObjectNoel
Change-Id: I7651d2f806334297fc3f1874fd2f4ba9cd224046 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-22elementary: tdf#139056 Update color to follow upstream's branding (2)Rizal Muttaqin
Change-Id: I5b54280005971ce0d590bfe66b399441db2d5292 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108110 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-12-22Update git submodulesOlivier R
* Update dictionaries from branch 'master' to c86e9c20e0bed193853cd4df7a9ec921acd9f07e - French dictionary update (v7.0) Change-Id: I1461d5bba34612eab2e9110cc8908950417df0aa Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/107652 Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2020-12-22tdf#138801 vcl: fix lazy-loading of GIF images with logic sizeMiklos Vajna
Regression from commit edda1e5fc8113aa4744e32f97c96a3cc311485ca (DOCX import: lazy-read images without external headers, 2018-04-20), the immediate problem is that GIF images from docx are now lazy-loaded. The deeper problem is that GIF images normally only have pixel size and can have an optional logic size as well (LO-specific extension). The bugdoc in question is a DOCX file, which contains a .png stream, which is in fact a GIF image, with that STARDIV extension in it. Now the initial parsing (that only extracts the metadata) didn't read the logic size, so the preferred map mode was pixels, but later when the actual read happened, the preferred map mode changed to mm100. Thid does not play nicely with writerfilter/ code that sets a different wrap polygon depending on if the (assumed to be final) map mode is pixels or not. Fix the problem by reusing the "is this an animation" GIF parser to also extract the logic size of the GIF image, if it has one. This way we still lazy-load the GIF image, but the preferred map mode won't hange from pixels to mm100 during the real read. Change-Id: Ia6c66e1c4fa0cb23a1daf537e7179b081ef90def Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108125 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-22use string_view in ProcessAttributeNoel
Change-Id: I81feb01bf6823d1d8fb5a7da08490959484ef533 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108095 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-22split SotStorageStream into two classesNoel
since it has two completely different paths of control Change-Id: I89b739d318d52245208a4bda1230f69d19f3ae0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-22reduce duplication in sax converterNoel
Change-Id: I05bfb50e81a84b5f3bb7749e85058f967cb4b4ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108094 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-22Related: tdf#84098 Unify testsMike Kaganski
Shorten the tools module name; use TestUtil.AssertEqual where applicable; remove unnecessary variables that only made noise and masked what was actually asserted; add missing licence headers. Change-Id: If891ed8ceb38fed18335aad061b2b09d341264f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108118 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-12-21Retire the bit-rotting LibreOfficeLight iOS appTor Lillqvist
Change-Id: I21b8055fc97d8dfb8429e7dafa1a3982c3b7499b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108122 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-12-21Improve SAL_INFO output for clipboard operations on iOSTor Lillqvist
Change-Id: Id9ed115067655c62346f765ddc3ed9bdce05ab9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108101 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108103 Tested-by: Tor Lillqvist <tml@collabora.com>
2020-12-21Add two debug output helper functionsTor Lillqvist
Change-Id: I38a234e6f4a3fc5e0f17cfd9a0068d2081b6c654 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108099 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108100 Tested-by: Tor Lillqvist <tml@collabora.com>
2020-12-21sw: fix layout loop due to a keep-with-next vs 100% image height conflictMiklos Vajna
The document in question has a landscape page, the last paragraph has an image where the width is 100% and the height is set to keep the ratio (which 1:1). This means that SwFlyFreeFrame::CheckClip() will scale the image down, so the image fits the page (and give up that 100% width was requested). The next problem is that this image has a wrap type set to none, so not only the total height of the page is taken, but also no content is allowed on the left/right side, effectively taking the entire body frame. Combine this with a previous paragraph, which is a heading, so keep-with-next is set for it. Layout loops because keep-with-next and take-the-entire-page are conflicting requirements and we used to have no explicit code to relax one of them when both are present: SwFlowFrame::MoveBwd: frame is 4, old upper is 10, new upper is 2 SwFlowFrame::MoveFwd: frame is 4, old upper is 2, new upper is 10 SwFlowFrame::MoveBwd: frame is 4, old upper is 10, new upper is 2 SwFlowFrame::MoveFwd: frame is 4, old upper is 2, new upper is 10 SwFlowFrame::MoveBwd: loop control, frame is 4, old upper is 10, new upper would be 2, but not moving there Fix the problem by giving up keep-with-next to stop the loop, mostly because we have to give up one of the requirements and Word resolves the conflict this way. Change-Id: I7da1ebcff9302cd144887f63efb94e0b2b2be8fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108119 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-21weld pagelistmenuCaolán McNamara
Change-Id: I2d3e5a448f03e424e7dad661c550f7e1ff31d808 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108112 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21weld SelectionTypePopupCaolán McNamara
Change-Id: I405a75e78bba0fb3b7350bf5407eeb4c5fc2f6ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108111 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21weld zoommenuCaolán McNamara
Change-Id: I7591f2b1e12e0fdf7d1ac61b358f0df201071f9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108098 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21weld tabledesignrowmenuCaolán McNamara
Change-Id: If4fc3d02308afa27a4eb4d8ee5326440a0d4f5b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108097 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21weld querycolmenuCaolán McNamara
Change-Id: If13436a99c80b619c9deb8d559a617accee64040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108091 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21weld jointablemenuCaolán McNamara
Change-Id: Ie7beb73c6b685b131e7353c2e96b68e564c39351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108089 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21weld queryfuncmenuCaolán McNamara
Change-Id: If6a92f846b00ec5bd719879c3f37290640e2d109 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108086 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21missing use-underline on large/small entriesCaolán McNamara
Change-Id: I0f16402ea0464cf0a8d072ca5d507fe74a531453 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108096 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21Add a comment here, too, that the lists of formats are identicalTor Lillqvist
Sadly I couldn't quickly come up with a trvial way to just factor out that code snippet. Feel free. I have no idea what happens if at some point these two code snippets would start to diverge. Change-Id: Iebf6d8a9827955acac846b19ae48a2b8eede0bbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108109 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-12-21tdf#138710: sc_uicalc: Add unittestXisco Fauli
Change-Id: I5496637baf51035e16fe41d9036de2895d97fed2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108087 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-21Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 095dd4e50117f149332c20b7489c4698c257cf49 - Fix a "D'oh! you found a bug" + Some refactor on the pages. Change-Id: Iec37d94dfa40292eeaae3dae3cf6ab1189fa8d2a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108124 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-12-21ios,nss: use AARCH64 consistentlyMichael Stahl
Presumably missing from 1cee06c080bceab86ac894f8ae86d4d296b050aa Change-Id: I0f658bb36179b741f6f47264ee1400633db69d6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108064 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-12-21tdf#138986 Fix DOC export of LinkDisplayNameRegényi Balázs
The LinkedDisplayName could be empty what caused an assert. tdf#138986 regression from commit: bda05ba17362222b74727872579b65b3fa14e3d8 (tdf#41466 DOCX import: fix VML v:shape/v:textbox) Change-Id: I166a7e4c1defc201d0563a961b28ecb6c6be500c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21paste and delete are never enabled, so handlers never calledCaolán McNamara
Change-Id: If45a55d8b84d691bdfcabc6b68ef2843765262f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108092 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21wrong menu used hereCaolán McNamara
since... commit 9714e7460c3ff67f2683483bf3634b2f31cda361 Date: Tue Apr 18 10:34:10 2017 +0100 convert table design row menu to .ui Change-Id: I772da4b8f97f0e416e72af35e59dfbb8d127a32c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108093 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21Revert "tdf#138739 sw: fix regression of first paragraph"Miklos Vajna
This reverts commit 25ca25ee25278536c56a2ac4a63af91100ce4d2e. cd sw; make -sr CppunitTest_sw_uiwriter3 CPPUNIT_TEST_NAME="testTdf130805" breaks with this one, it just went in due to an old baseline. Change-Id: Ie68f2847b936aefba3198ddd915316a204210d4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108105 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-21presumably we don't then need GDK_VISIBILITY_NOTIFY_MASKCaolán McNamara
Change-Id: Ibfc1e7036dcca91529959695f008938d306d8d46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108083 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21weld joinviewmenuCaolán McNamara
Change-Id: I7c4bf69edb2a8b29ebf69ebdaa30f89123a0749b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108079 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21weld cellmenu.uiCaolán McNamara
Change-Id: I479effad8c1c6df9e325cfa0794a69f8d3426a2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21weld querycolmenuCaolán McNamara
Change-Id: I0b4e27b15b1526eb7122bc5eec98f8d389e58de1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21drop deprecated visibility-notify-event event handlerCaolán McNamara
we're not doing anything with it anyway Change-Id: I2498eca95dcea53b1c216bb7786c6c3246b5c5ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108082 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21Revert "lok: add pre-condition "DontEnableJava""Henry Castro
This reverts commit 8c5c6b8993a52c40b9de231e778204bcdca16333. Reason for revert: "This is broken. For example, "Tools - Macros - Run Macro... - Library - LibreOffice Macros - HelloWorld" under "Macro Name" no longer lists the JVM-based scripts ("helloworld.bsh", "helloworld.js", "org.libreoffice.exmpale.java_scripts.HelloWorld.printHW")." Change-Id: I6fef6ea80689f036e79816c8d58d2c1f9e64967c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108007 Tested-by: Henry Castro <hcastro@collabora.com> Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-21NFC flatten PageBreakWin and minor cleanupJustin Luth
Cleanup: -everything uses the same pCnt, so do that once and share it. -use FindFirstBodyContent to consolidate a lot of ugliness. -make pNd into a reference, since it is used unconditionally. -had to switch to IsInTab since we only have content frames now. Change-Id: I0ce66e98ea915152ef534e7719100da7cd6ca2db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108071 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-12-21do not preload all images in the pptx importerLuboš Luňák
Now with my GraphicFilter::MakeGraphicsAvailableThreaded() patches for Impress images will be loaded in parallel as they are needed, which should usually be more efficient than loading all of them immediately. This basically reverts commits: b1319842a49cdf6512bbd9e81081e2a9edbd6089 04e27df3c162f1df02f061b94434a38d1eaa3a46 9eb8e2737d3a4d52ce1b0cc44091a3b7ecf59e3b Change-Id: I46bb0d6d93fb69f03f464308f6fce1603aafdfd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107945 Tested-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-21sw: prefix members of SwXMLBlockListImport, SwXMLTextBlockImport, ...Miklos Vajna
... SwXMLTextBlockParContext and SwXMLTextBlockTextContext See tdf#94879 for motivation. Change-Id: I85fb65a140381b258d51c2f35c5a8cf27d6dfa4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108074 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-21use std::u16string_view in SvXMLTokenEnumeratorNoel
Change-Id: I1194441063047637adc20c8e37bb717fdb787714 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108073 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-21elementary: tdf#139056 Update color to follow upstream's brandingRizal Muttaqin
- Update some arrow element Change-Id: Iecda4e7efbac6a8cb2416bdd70edc5f8edd07894 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108070 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
generated by cgit (git 2.34.1) at 2024-08-22 09:02:24 +0000