summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-03-06use more Color in vbahelperNoel Grandin
Change-Id: I9d153b184a394ac21d504cb503731f8c5c8ec1de Reviewed-on: https://gerrit.libreoffice.org/50797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-06use more Color in toolkitNoel Grandin
Change-Id: I88860e4180db2c46acda1739235c248a38bb068d Reviewed-on: https://gerrit.libreoffice.org/50798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-06use more Color in xmloffNoel Grandin
Change-Id: Iec12d2e9f3e254dc6525dc285259321b13f75c4a Reviewed-on: https://gerrit.libreoffice.org/50794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-06Normalize computation of directory and file-in-directory URLsStephan Bergmann
There are occasional failures of Jenkins "Daily Screenshot Build on Windows" like <https://ci.libreoffice.org/job/lo_tb_master_win_screenshot/324/console> and <https://ci.libreoffice.org/job/lo_tb_master_win_screenshot/332/console>, always failing with > C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_screenshot/test/source/screenshot_test.cxx(84) : error : Assertion > Test name: ReportdesignDialogsTest::openAnyDialog > assertion failed > - Expression: aNew.IsOpen() > - Failed to open <C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_screenshot/workdir/screenshots/modules/dbreport/ui/condformatdialog/CondFormat.png>: 796 (where 796 is ERRCODE_IO_NOTEXISTSPATH). Beats me how that can happen, when ScreenshotTest::implSaveScreenshot first creates the dir and then the file-in- dir (and it is rather unlikely that something else deletes the dir in the meantime, for various builds of that Jenkins bot, always for the same dir workdir/screenshots/modules/dbreport/ui/condformatdialog/), and why it always happens for exactly the same file, workdir/screenshots/modules/dbreport/ui/condformatdialog/CondFormat.png during CppunitTest_reportdesign_dialogs_test. However, one curiosity was that the dir's URL was computed with m_directories.getURLFromWorkdir(aDirname); (without a leading slash inserted before aDirname) while the file's pathname was computed with m_directories.getPathFromWorkdir("/" + aDirname + ...) (with a leading slash inserted before aDirname). Turns out that SvFileStream accepts a URL as well as a pathname, so normalize the computation of the dir's and the file's URL. Maybe that will give a clue why that Jenkins bot sometimes fails. Change-Id: I53b59b51ffc4355c45aa0ca72f6e187cf2010f92
2018-03-06loplugin:useuniqueptr in sdextNoel Grandin
Change-Id: I0870d4b1e85465b07e3d9cdb05520fcb37dfc267 Reviewed-on: https://gerrit.libreoffice.org/50659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-06Fix typosAndrea Gelmini
Change-Id: I005023337dbe593e0ac1d76f7b10848d24f314a5 Reviewed-on: https://gerrit.libreoffice.org/50785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-06tdf#116147 guard triggerRequestThreadAwareJan-Marek Glogowski
It didn't help putting a SolarMutexGuard into VCLXButton::ProcessWindowEvent, which was my first suspect in my own backtrace, as VCLXWindowImpl::OnProcessCallbacks releases it to process the callbacks. Since the gtk backend also guards all calls into the file picker code, I think it's save to do the same for the Windows picker. I have no idea where it is actually released again... Change-Id: I3ab3b47904dc3d0033739a82f7afd91e6e80403d Reviewed-on: https://gerrit.libreoffice.org/50783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-03-06tdf#115861 DOCX import: avoid last-paragraph removal when discarding footerMiklos Vajna
Discarding header/footer is necessary when the document or section settings request to ignore first or even headers/footers. In the bugdoc case settings.xml didn't opt-in for different even/odd footers, but there was an even footer to be ignored. Handle this state at two more places, so we don't end up in a situation where we ignore the footer but not its "remove last (empty) paragraph at the end of the footer" action. Also make the debug dumper for text ranges more robust to have a working token dump when we try to get the string for a table. Change-Id: I6395f37aa40c42304e2c918d87dadecb21e9d378 Reviewed-on: https://gerrit.libreoffice.org/50786 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-06add some color conversion methods to sax::ConverterNoel Grandin
to make the call-sites less verbose Change-Id: Ifddcbb03a454a241bef93f31a8025801b84a66fc Reviewed-on: https://gerrit.libreoffice.org/50578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-06vcl: remove commented code from bitmappaint.cxxChris Sherlock
Change-Id: I80c1f8961bee4e72b7ffd8e4d9647dbb40f4fc10 Reviewed-on: https://gerrit.libreoffice.org/50531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-06vcl: split painting bitmap functions to bitmappaint.cxxChris Sherlock
Change-Id: Ib5f52e4b7b5121de15cdb205165fcbdb8b09bc8a Reviewed-on: https://gerrit.libreoffice.org/50530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-06vcl: document Bitmap::MakeMonochrome(), fix @return formatChris Sherlock
Change-Id: I10b37907a3ccd5219b7d5e04177bba58d80a676b Reviewed-on: https://gerrit.libreoffice.org/50528 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-06Resolves: tdf#113805 insert special character fails in insert footnote, etc ↵Caolán McNamara
dialog i.e. since commit 710a39414569995bd5a8631a948c939dc73bcef9 Date: Thu May 11 13:27:38 2017 +0530 GSoC: Glyph View and Recent Characters Control in Special Characters dialog Change-Id: Ia55f3fefe7c14327cff2e996ab0038dc52f9b017 it inserts into the document, extend the fix of commit 4020945651b4f3c636980e2103db440b5c55459c Author: Daniel <danielfaleirosilva@gmail.com> Date: Sun Sep 24 17:55:19 2017 -0300 tdf#111739 fix Selecting a custom character as a bullet symbol insertion to do the old thing that existing code depends on if this is not an "insert" dialog, and bubble that setting around from the callers Change-Id: Id8acf16955d0167beffae43e3b201e500ee7a929 Reviewed-on: https://gerrit.libreoffice.org/50781 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-05Use for-range loops in desktop (part1)Julien Nabet
+ remove some useless typedef + some reindent Change-Id: Ic1e445a7096b1663ca8cbc58c40bb8f7af0c70e1 Reviewed-on: https://gerrit.libreoffice.org/50787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-05Unit test for tdf#116216Eike Rathke
Change-Id: Icd2e37c279db43b792e84b3aae64c16db0c4834b
2018-03-05Resolves: tdf#116216 array sort order of error values in LOOKUP and MATCHEike Rathke
Change-Id: I424de514b3a3729bc5f619814b6a4aab42569f82
2018-03-05Resolves: tdf#116188 set min version on all .ui files to 3.18Caolán McNamara
which is already the min for the runtime Change-Id: Ifebe099f1f94a36f65a31989689400327a823dcd Reviewed-on: https://gerrit.libreoffice.org/50776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-05fix mnemonic in add_buttonCaolán McNamara
Change-Id: Icdf4866aab70e065e92c56931289ea7b8db1ff09 Reviewed-on: https://gerrit.libreoffice.org/50777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-05lokdialog: more, convert the dialog to async execHenry Castro
ClassificationDialog SwWatermarkDialog Change-Id: I835648df8df5ad3ee5a404a582c2179e5b3b276a Reviewed-on: https://gerrit.libreoffice.org/50771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-03-05Translate German variable namesJohnny_M
Akt -> Current in ppt filter Change-Id: I06f140d5f9a60b53d815e73ee0b7a2b283a52d79 Reviewed-on: https://gerrit.libreoffice.org/50684 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-05Rename OCharsetMap::find overload to findIanaNameStephan Bergmann
Change-Id: Id3fe81b41b92d6ad4e3f7127331d859a7b3c7f54 Reviewed-on: https://gerrit.libreoffice.org/50779 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-05sw XHTML import: map <object> to OLE objectsMiklos Vajna
This handles native data only so far, replacement image still needs doing. Change-Id: I5f51bc7d837309fa0b88b277c1b754e435cb4208 Reviewed-on: https://gerrit.libreoffice.org/50778 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-05weld SfxSaveAsTemplateDialogCaolán McNamara
Change-Id: Ia663102a2d871fdca093c0d33e5af5a79deebeb5 Reviewed-on: https://gerrit.libreoffice.org/50775 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-05tdf#116171: Tunnel arbitrary rtl_TextEncoding from sc to sdbc:dbase connectionStephan Bergmann
...including those that have no corresponding textual IANA character set name representation, like RTL_TEXTENCODING_MS_950 which is apparently used in some DBase files. In the past, if eCharSet was RTL_TEXTENCODING_DONTKNOW in lcl_getDBaseConnection it was sent as an empty string CharSet property, which the receiving OConnection::construct translated back to else m_nTextEncoding = RTL_TEXTENCODING_DONTKNOW; so the net effect remains the same for that special case. Change-Id: I84eec8a93d000752b3c429976c58721ea9ea32a4 Reviewed-on: https://gerrit.libreoffice.org/50772 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-05Removed duplicated includeAndrea Gelmini
Change-Id: I9baebc135d62fac29512ae5e8eb5e43d61ac227a Reviewed-on: https://gerrit.libreoffice.org/50773 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-05Fix typosAndrea Gelmini
Change-Id: I70e7db0926f8c5815637ae14c1193130d52c3224 Reviewed-on: https://gerrit.libreoffice.org/50774 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-05loplugin:useuniqueptr in XFConfigManagerNoel Grandin
Change-Id: Ia442d2dba8c6fdf577c6cdc950d518cc863d6e0e Reviewed-on: https://gerrit.libreoffice.org/50741 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05loplugin:useuniqueptr in SdrObjEditViewNoel Grandin
Horrible things happening in SdrObjEditView::SdrEndTextEdit, I can't tell if it's deliberately leaking there, or just changing ownership in some terribly opaque way. Change-Id: Idcb30f7e3f1b801901f727b151d3e8dd1124fd3f Reviewed-on: https://gerrit.libreoffice.org/50663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05We now use Unicode with MAPISendMailW, so no need for thisMike Kaganski
Change-Id: I6f03b4212a3434cb5feae8da29107c5f411218e3 Reviewed-on: https://gerrit.libreoffice.org/50759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-05there's already a way to pass around the SfxRequest source frameCaolán McNamara
Change-Id: I790497c3e651890e0971ee334d599a98a7aae7f0 Reviewed-on: https://gerrit.libreoffice.org/50768 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-05drop sax::tools::*base64 methodsNoel Grandin
and use the underlying comphelper methods rather. This is so that I can break the dependency that tools has on sax, and can add methods that make sax depend on tools. Change-Id: I8a2d6ce2ffc3529a0020710ade6a1748ee5af7d5 Reviewed-on: https://gerrit.libreoffice.org/50767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05Make LibreOffice buildable on Haiku.Kacper Kasper
* Obviously VCL wiring is missing, but most components do build. Change-Id: Ie853ada1423a8f4c2b647be59cd47a7730c42978 Reviewed-on: https://gerrit.libreoffice.org/50293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-05sw: prefix members of SwFontAccess, SwFontObj and SwRangeRedlineMiklos Vajna
Change-Id: I6440ea8d4fab730f3335d69c7f434684f7d6874b Reviewed-on: https://gerrit.libreoffice.org/50763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-05loplugin:useuniqueptr in SdrPowerPointImportNoel Grandin
Change-Id: I9a8d1669cbd94f73dc75e4b7339910f8201e06aa Reviewed-on: https://gerrit.libreoffice.org/50695 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05drop long& returning methods in PointNoel Grandin
Change-Id: I5d23191fd5a549b867213acedf9d56c233e2fb13 Reviewed-on: https://gerrit.libreoffice.org/50761 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05weld CuiInputDialogCaolán McNamara
Change-Id: I121ac0ffa1f6c28bb305c90e89ba28f276da52f1 Reviewed-on: https://gerrit.libreoffice.org/50765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-05tdf#116001 Incorrect Colors in Chart Wall Area (2nd attempt)Noel Grandin
regression from commit b10c7022f1be6e4825269bd5872575b5b53744ef "use RawBitmap in BPixelRasterToBitmapEx" fix attempt at fixing it in commit 3d400321910ff0fe89ab8c70c59432e676cb1340 "tdf#116001 Incorrect Colors in Chart Wall Area" was incomplete. the drawinglayer code was (a) not initialising the background transparency on all pixels and (b) not calling the Color constructor correctly. Change-Id: I1cf7d7d5eb67ba472e17790b18c33d8e4b97ae4c Reviewed-on: https://gerrit.libreoffice.org/50764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05Update the reference rdbs to libreoffice-6-0-0Stephan Bergmann
LD_LIBRARY_PATH=.../master/instdir/program \ .../master/workdir/LinkTarget/Executable/unoidl-read --published \ .../libreoffice-6-0-0/instdir/program/types.rdb \ >.../master/udkapi/type_reference/udkapi.idl * no changes LD_LIBRARY_PATH=.../master/instdir/program \ .../master/workdir/LinkTarget/Executable/unoidl-read --published \ .../libreoffice-6-0-0/instdir/program/types.rdb \ .../libreoffice-6-0-0/instdir/program/types/offapi.rdb \ >.../master/offapi/type_reference/offapi.idl Change-Id: I5419f81757ba43664aefb60f081bf52612b8afc4 Reviewed-on: https://gerrit.libreoffice.org/50762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-05Translate German variable and function namesJohnny_M
Akt -> Current in svdibrow Change-Id: I099858e917dcc725cd02c1b99f0fa61d5c769ae1 Reviewed-on: https://gerrit.libreoffice.org/50703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-05Translate German variable namesJohnny_M
Akt -> Current in crsrsh Change-Id: I64205dd776babedc4dc68c82e6fe7de7c7a78c79 Reviewed-on: https://gerrit.libreoffice.org/50666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-05Translate German variable and function namesJohnny_M
Akt -> Current in ww8par Change-Id: I5adedc8edc6e8c0a6b9022ca55bca1293ab046fd Reviewed-on: https://gerrit.libreoffice.org/50670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-05Translate German variable namesJohnny_M
Akt -> Current in MSWordAttrIter (Other occurrences will be done separately.) Change-Id: Ibec27cd626399d7c868272ea7f8e906d458a4c9a Reviewed-on: https://gerrit.libreoffice.org/50689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-05Translate German variable and function namesJohnny_M
Akt -> Current in ww8par Change-Id: If8e0b00082748ef8fe05a25a4966e8b5c7b6c51c Reviewed-on: https://gerrit.libreoffice.org/50671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-05Translate German variable namesJohnny_M
Akt -> Current in svdviter Change-Id: If1abc3705514739f856d7a60e70c7b114836b341 Reviewed-on: https://gerrit.libreoffice.org/50668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-05tdf#107035 Fix field character style DOCX importLuke Deller
Reinstate a call to DontExpandFormat which was removed from appendTextContent in commit 232ad2f2588beff50cb5c1f3b689c581ba317583 This ensures that direct character formatting which ended immediately before the insertion point will not be expanded to cover the inserted content. Change-Id: Ie5fa6b5c5acee4f885f9e67535e98801af23661a Reviewed-on: https://gerrit.libreoffice.org/50729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-05HSQLDB Binary importTamas Bunth
C++ implementation of reading HSQL's binary file format. This file contains the actual rows for the tables, represented in an AVL tree. Import starts from HsqlImporter, which calls to SchemaParser for some metadata (the positions of the trees in "data" file). After that it goes through the tree and read up the rows using HsqlRowInputStream. Finally, it uses sdbc's XPreparedStatement to insert the rows to the actual database. Change-Id: If4b17572e5989c218d45880bc3fd5a8820bb4101 Reviewed-on: https://gerrit.libreoffice.org/50536 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2018-03-05loplugin:useuniqueptr in PPTTextSpecInfoAtomInterpreterNoel Grandin
Change-Id: I42e0fdb53b5a7504f2ac7fcf5d227a9c7378a6ca Reviewed-on: https://gerrit.libreoffice.org/50696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05Updated coreAdolfo Jayme Barrientos
Project: help 913d1549aa0bf4686ab50737731b9fe77f3b7ae4 Mention a more plausible possibility Unlike StarOffice, our default user-facing installer doesn’t let users enter user data, but sysadmins can provide it still through other means. Change-Id: Ifca433ca8330d8547d1b3f07127159dacf2faf94
2018-03-05Removed duplicated includesAndrea Gelmini
Change-Id: I63312215af63b2e7726ca79c6e151772e6ca7192 Reviewed-on: https://gerrit.libreoffice.org/50479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-05Removed duplicated includeAndrea Gelmini
Change-Id: I5c938d4e86e371c7ee5eab66581d6ed736bc2033 Reviewed-on: https://gerrit.libreoffice.org/50754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>