summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-17Change default PDF version to 1.6 (released in 2004)Miklos Vajna
We already write markup which is newer than 1.5, but the PDF version was not changed. Fix the one violation I'm aware of. Printing is left unchanged, similar to how commit 99ac4ee05b039166eedfe361fb985682fd92dd13 (Change default PDF version to 1.5, 2018-04-24) updated the default last time. Change-Id: I9598dc46fe7db428bd2eff98bebff8b3c873b4ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92457 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-04-17loplugin:flatten in cppcanvasNoel Grandin
Change-Id: I4303c31ad3de1ba71aa366b6dc203504b8fffd77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92453 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-17tdf#79553 ww8import: line numbering distance is auto, not zeroJustin Luth
sprmSDxaLnn: An XAS_nonNeg that specifies the distance between line numbers and the lines of text to which they apply. A value of 0 indicates that the application MUST automatically determine positioning. By default, the positioning of line numbers is automatically determined. Change-Id: I35a440a7fa84f315f4a67e201e1a0066d4e4cf73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92126 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-17Move Word compat option where it belongsSamuel Mehrbrodt
Change-Id: I6b28c6782f22190b7b22b11361c200d68d672aea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92347 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-17No need for HAVE_GCC_PRAGMA_OPERATORStephan Bergmann
The _Pragma operator is a C99/C++11 feature, and we only need it for GCC and Clang anyway, to inject some #pragma GCC diagnostic ... directives. (MSVC would only support it with the upcoming VS 2019 Version 16.6, see <https://devblogs.microsoft.com/cppblog/ announcing-full-support-for-a-c-c-conformant-preprocessor-in-msvc/>.) Change-Id: I6de3611021a28ba13860f55e7ad005ad3fbbb5e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92452 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-17HAVE_CPP_GUARANTEED_COPY_ELISION should always be true nowStephan Bergmann
...since 24973523ba59087185d434396fd614e73d72107f "Bump Windows build baseline to Visual Studio 2019 16.4", where that version of the compiler appears to no longer have the issue that at least VS 2017 15.8.1 had. And according to <view-source:https://en.cppreference.com/w/cpp/compiler_support>, the other compilers support it since GCC 7 and Clang 4, so we should be OK there. But for safety, leave the configure.ac check in for some longer. Change-Id: I07bfaa554d897613c0887ab70e8df93f6e000410 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92422 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-17Break overly long lineEike Rathke
... and make it more legible. Change-Id: Ie5325f614cf8d95290e04c9b0e9fa29f353d8301
2020-04-17improve failure mode in flatten lopluginNoel Grandin
rather than asserting, write out a warning so that section of code can be handled manually Change-Id: I1356012f4e480cff9508dad6c2d70cbbba1a5dc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92424 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-17loplugin:flatten in cuiNoel Grandin
Change-Id: I0ea0784ab8c4542747da1e15fa7c60c60bccb602 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-17tdf#130583: fix Switch in CalcJulien Nabet
Don't set bFinished to true too soon if there are still some params to take into account Change-Id: Ie7bdd6f316c08342d379d55bf3853774dd738e7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92345 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-04-17Just use __builtin_ffs on GCC and ClangStephan Bergmann
GCC appears to support it at least since <https://gcc.gnu.org/git/ ?p=gcc.git;a=commit;h=51e2940139d5e3e86590f6e6802ffc3f3010be5b> "Initial revision" in 1992, and Clang appears to support it since <https://github.com/ llvm/llvm-project/commit/d93abc3bb0acdd430839abdd67bd3920fee87bbc> "Implement ffs, parity, and popcount builtins" in Clang 2.4. (And if a build used a compiler that does not support it, there would be no guarantee that it would support strings.h function ffs from X/Open System Interfaces, either.) Introducing HAVE_GCC_BUILTIN_FFS in 334a9f16cd1d1f9694f885c759903a41aa3d4833 "tdf#113211: fix calculations with big integers" appears to be due to a misguided recommendation at <https://gerrit.libreoffice.org/c/core/+/43477/4# message-899806c724fbdcece0ea9438514a6a5db6a2e645>. Change-Id: Ib6ee6de548172b3aae25483d03efb86620133933 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92421 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-17tdf#131621: fix crash in mergedlo.dllMike Kaganski
When the embedded database comes from the template this document was created from, the document might not have old URL yet. We need to construct the embedded data source URL from the template URL to keep the relative references correct. Change-Id: I5607113e0ae88fdb825d8a645c0968d2fe22ebd7 Co-authored-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92398 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-17move LIBO_LANG=C setting to gb_TEST_ENV_VARSRene Engelhard
... since it is an environment variable after all (and without it timeout $(gb_UITest_COMMAND) doesn't work). Change-Id: I898e4b90070f3f4883a707fc88c99e98bc039d9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92060 Tested-by: Jenkins Tested-by: Rene Engelhard <rene@debian.org> Reviewed-by: Rene Engelhard <rene@debian.org>
2020-04-17HAVE_GCC_BUILTIN_FFS is unusedStephan Bergmann
...ever since it was introduced in 334a9f16cd1d1f9694f885c759903a41aa3d4833 "tdf#113211: fix calculations with big integers". (Only the AC_DEFINE'd #define in config_host/config_global.h.in is used in sal/rtl/math.cxx.) Change-Id: I4b84534b022b96fee725988906c047736e7a579b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92411 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-17Update neon website URLStephan Bergmann
See <http://lists.manyfish.co.uk/pipermail/neon/2020-April/001659.html> "FYI: website moved to https://notroj.github.io/neon/". Change-Id: I473efd983870ab4f4bd5af14e726ec4e5009f204 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92414 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-17tdf#131407: move UItest to CppunitTestComing___soON
sw/qa/uitest/writer_tests5/tdf124722.py - tdf124722_crash_paste_text (tdf124722) Change-Id: I08d89f5bb90b95c26c56ebc16df2c56c9803f845 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92074 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-17tdf#131922 DOCX DrawingML shape import: fix lang-idRegényi Balázs
The language identifier of text of grouped shapes wasn't imported. Co-Author: Szabolcs Tóth Change-Id: Ic71ea1bdf3aed27ad813cfa33659921060c0ec0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91801 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-17Revert "[API CHANGE] remove some primitives rendering settings"Noel Grandin
This reverts commit c71656f51a09e88ecae4f3423c96fee84778647d. Reason for revert: I give up Change-Id: I2a09c36c1f0d731f4d3f7d809364de7efa8d8a58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92426 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-17loplugin:buriedassign in sw(1)Noel Grandin
Change-Id: Ifaab4ab1bde3ff8236b51244098c81e6f460fbd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92408 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-17loplugin:buriedassign in tools..xmloffNoel Grandin
Change-Id: I31df6c4fd82c6f6d15bbe5228e92e5171cacba51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92410 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-17loplugin:buriedassign in vclNoel Grandin
Change-Id: I529052c1ba7591d91d3848080af8b06e077b6f14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92409 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-17tdf#131979 Chart ODF import-export of Link to source formatBalazs Varga
setting also into data point styles, fixing lost numbering style of custom data points. (Only export into the data series style was supported previously.) Also fix tdf#131115 - FILEOPEN: Incorrect format of single data label Regression from commit: e57d90cd4e51a1353eafc87bb29cfe6076704a7c (tdf#129173 tdf#129175 Fix number format of data labels) Data point styles in older ODF files do not contain the 'link-data-style-to-source' property, so they used the data series style property during the import previously. Now we set the default false value, if the data point style contains a 'data-style-name' (number format). Change-Id: I4786e62ca75770ed632463bcf1275ece7ea793f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91967 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-17Fix autorecovery using wrong directorySamuel Mehrbrodt
Autorecovery should save in the user profile in the "backup" directory. However, when that directory did not exist, the temp directory was used instead. Fix this, and create the requested directory if it did not exist. Change-Id: Ie298855a740932bc6e6c9f62d4b4bf1b52b80c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92402 Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-04-17loplugin:buriedassign in dbaccessNoel Grandin
Change-Id: Ia97da8d228a8c4e3ced31718a756fb13757beb8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92407 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-17turn off hover selection until mouse is movedCaolán McNamara
which solves in a simpler and better way the problem under wayland where I see that the cursor pos in super long treeview menus ends up in the wrong place Change-Id: If9c7e26c3858ef00bc1fbf26319d859ff529db44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92403 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-17loplugin:external (clang-cl)Stephan Bergmann
Change-Id: I409509d434f5536c6f131c1330974d442e6eba57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92404 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-17Added unique id for number format comboboxMert Tumer
This will allow us to control it for the mobilewizard easily rather than using the id of 'category' which is not unique. Change-Id: I61b612d5355584597a16942b7151a82376033a45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92202 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92309 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2020-04-17Drop unused includes and usingsMike Kaganski
Change-Id: I58ac4add2bb53d0c36cd54ff48964e392d13f6a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92400 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-17tdf#127606 DOCX lists: fix unchangeable formattingLászló Németh
of numbering. It was not possible to modify character formatting of numbering symbols, if it is different from the format of the list item, handled by compatibility setting APPLY_PARAGRAPH_MARK_FORMAT_TO_NUMBERING and paragraph attribute "ListAutoFormat". Now changing character attributes removes ListAutoFormat, if it is applied on wholly list item(s) during editing (like in the case of ODT documents). See also commit 5ba30f588d6e41a13d68b1461345fca7a7ca61ac (tdf#64222 sw: better DOCX import/export of paragraph marker formatting) and commit df07d6cb9f62c0a2c4b29bd850d4efb4fcd4790b (handle direct formatting for numbering in .docx (bnc#875717)). Change-Id: I60dae1b9c084d0804e453f54df5c6bbafe479869 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92343 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-17cid#1462264 Uninitialized scalar fieldCaolán McNamara
Change-Id: I4b733bf37132073ece55fa392c06086410f6f914 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92393 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-17Update git submodulesAndras Timar
* Update translations from branch 'master' to ebb391af06913d791a1b283415744bc9521b4cb0 - Slovenian fixes Change-Id: Ia8634765d18a6fc90bd62f2b89a35a843b42489b
2020-04-17xmloff: create SchXMLExport (flat OOoXML) instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I67138b848411d91172ceec7af6826841b017cfdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92390 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-16tdf#132097: sc: Add UItestXisco Fauli
Change-Id: Ib4aa2c9ed4a0de10aa7a91796fa3034720a160b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92386 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-16cid#1462267 Infinite loopCaolán McNamara
since... commit a2362e0ff5a7cec16e888502a3c16fe2fa7ba0fe Date: Wed Apr 15 19:32:09 2020 +0200 loplugin:buriedassign in sfx2..sot Change-Id: Iabbef1b027cb6bd77b387142df926c5b37858517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92392 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-16PDF export: fix handling of page sizes larger than 508 cmMiklos Vajna
The value of these coordinates are not allowed to be larger than 14 400, and Adobe Reader complains about them. Use UserUnit to declare in case we won't work with points anymore, but with a larger unit. This will mean UserUnit=2 in practice, since e.g. Draw has is page size limited to 600x600cm, so larger values won't happen, at least not for now. Change-Id: I8ee159f2571f4070aded85388792a215de86f7ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92383 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-04-16VCLXAccessibleComponent* may be passed to HandleWindowOpenedMike Kaganski
my_sc_impl::AccessBridgeHandleExistingWindow may do that for combobox floating window; then using the pointer statically cast to VCLXWindow* will crash. Change-Id: Ib4c47715a5fa059aa81f33137cc3d10851a728e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92387 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-16cui about dialog: don't ellipsize any textMiklos Vajna
I got "gt..." instead of "gtk3" without this. Change-Id: I1c666dec88f7cf2dbc48e864ce1a8ae724140697 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92379 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-16gen backend scrollbars are missing their contentsCaolán McNamara
since... commit 059f07f9f33460c809a93e0fda1165f5c6f6d805 Date: Wed Apr 15 18:34:58 2020 +0200 fixes for code creating reversed Rectangles ie. where left > right or top > bottom revert that hunk and it works again but add a Justify call to normalize the rectangle Change-Id: I42b3f1867c6f9bae92e952b444c7946831a5d95c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92381 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2020-04-16cid#1462265 Uncaught exceptionCaolán McNamara
Change-Id: I4c1b8e6a13527ff3c95df8ec23c26c37c127b356 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92384 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-16hover selection start off in the wrong place in long listsCaolán McNamara
Change-Id: I61d93b45d32cfb29e436ae71b83c8d0b252386c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92385 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-16don't allow tooltips from parent to appear while popup menu is activeCaolán McNamara
Change-Id: Ic2ddff3e22a667af992d6b0701f43d3a89153458 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92371 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-16tdf#131120 use a replacement for GtkComboBoxCaolán McNamara
the problems with GtkComboBox we have are: 1) https://gitlab.gnome.org/GNOME/gtk/issues/1910 has_entry long menus take forever to appear (tdf#125388) on measuring each row, the GtkComboBox GtkTreeMenu will call its area_apply_attributes_cb function on the row, but that calls gtk_tree_menu_get_path_item which then loops through each child of the menu looking for the widget of the row, so performance drops to useless. All area_apply_attributes_cb does it set menu item sensitivity, so block it from running with fragile hackery which assumes that the unwanted callback is the only one with a 2) https://gitlab.gnome.org/GNOME/gtk/issues/94 when a super tall combobox menu is activated, and the selected entry is sufficiently far down the list, then the menu doesn't appear under wayland 3) https://gitlab.gnome.org/GNOME/gtk/issues/310 no typeahead support 4) we want to be able to control the width of the button, but have a drop down menu which is not limited to the width of the button 5) https://bugs.documentfoundation.org/show_bug.cgi?id=131120 super tall menu doesn't appear under X sometimes In general we often pack a lot into the comboboxes and the default ones don't like that. Overlay scrolling is turned off for the GtkTreeView replacement because otherwise there are null-derefs in gtk on indicator->scrollbar on repeated reopenings Change-Id: I1b6164020996377341b5992d593a027b76021f65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91990 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-16tdf#132147: formula may be emptyMike Kaganski
"Regression" after commit ab285c743afa1c8769581871d7b56374fd8c49f1 author Noel Grandin <noel.grandin@collabora.co.uk> Sat Nov 02 18:59:49 2019 +0200 committer Noel Grandin <noel.grandin@collabora.co.uk> Sun Nov 03 17:11:14 2019 +0100 loplugin:stringadd tweak the plugin to be more permissive, then validate by hand afterwards which replaced strFor.replaceAt(0,1,"") with strFor.copy(1). Both methods are illegal on empty string, but the former asserted, then silently corrected wrong count; while the latter returns "br0ken". So the change actually revealed a pre-existing bug. Change-Id: Ic32b69d46e852f26e6c6ba819eed08bb79dce7a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92301 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-16tdf#132094 doc: fix export of fill in wrap-through fly framesJustin Luth
This builds on commit 2f13dbac060ae6af7e25ad3eff675cc859cfb3ff by Miklos Vajna on Fri Jun 15 08:49:46 2012 +0100 n#325936 fix ww8 export of fly frames with transparent bg where he wisely and cautiously says Regression from commit ed8b5f2d -- to be safe, reverted only for fly frames in headers. because for some unknown reason, way back in 2002, commit ed8b5f2debac216243930aba0873e0d75de8d0dd forced all frames to specify a background fill. Typically of course this is white, and so who notices? Well, you notice if your frame is transparent, and now the area fill hides something that it is over top of. Like for example a transparent image, where the text wraps through the image. At first I was going to just try and revert everything. Then I decided it likely was a difference between how LO and MSO handled stacking/overlapping things. After that, I was going to just make an exception for eShapeType == mso_sptPictureFrame, but that only seems necessary if there is something underneath. If the something is just a background, that is handled anyway, so really it would only be other shapes or (most importantly) text, so the safest thing is testing wrap through, which there was already a pre-defined variable to reuse (and fix the spelling). Change-Id: I9236579fa692e22205bab5a21c3f9d919f4cf24f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92215 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-04-16tdf#59857: chart2: Add unittestXisco Fauli
Change-Id: I6d27868aacc8f2b2b72621c35c5f52f627e6cebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92380 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-16cid#1462266: Logically dead code (sc/dbfunc3)Julien Nabet
Regression from: commit 61d8db6b1a2026a29f61eaa691beb3c6cf05de5c Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Apr 15 09:25:22 2020 +0200 loplugin:buriedassign in sc Change-Id: I9b4146c4e8814a36c7bfcd4c31f913c8412320e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92244 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Change-Id: I5835f5c92cdf381a57ac6ccf627e327ae9f9e26b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92377 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-16workaround for intel Skia invert() problem (tdf#130430)Luboš Luňák
Change-Id: I02c8cd7af2c35e8631932e3928d63c96dc0db255 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92368 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-16Fix passing --disable-optimized into external/python3Stephan Bergmann
This had originally been covered by dccf47b7f61e088622747539d1487590080da3b8 "Build python3 with debug flags if --enable-debug", which got broken by eeeec33ada5923f1f534334b22c15d6e2c6f1d35 "merge --enable-selective-debuginfo into --enable-symbols" (which removed the definition of gb_Module_CURRENTMODULE_DEBUG_ENABLED without adapting its use here). But looking again, setting OPT for workdir/UnpackedTarball/python3/configure.ac based on our various flags doesn't seem to be such a good idea anyway: It is used to specify a mixture of debuginfo (-g; which is set rather unconditionally, so no need for us to cater for --enable-symbols here), optimization (-fwrapv, -O*), and warning (-Wall) flags. So better let workdir/UnpackedTarball/python3/configure.ac keep deciding for itself what flags to set in OPT, and then just override via CFLAGS those that do not suite us. (Where it appears to be a happy coincidence that the Python build system puts CFLAGS after OPT, so the former can override the latter.) (An alternative approach could have been to pass --with-pydebug based on e.g. --enable-dbgutil, as the former (a) causes OPT to include -O0 rather than -O3, and (b) is documented to change the ABI (see workdir/UnpackedTarball/python3/configure.ac: "Py_DEBUG implies assertions, but also changes the ABI."), so probably best fits --enable-dbgutil. However, at least on Linux, --with-pydebug produces workdir/UnpackedTarball/python3/libpython3.7dm.so rather than workdir/UnpackedTarball/python3/libpython3.so, so would have required further modifications. Also, in a Linux UBsan build, making ExternalProject_python3 would have started to cause some "applying zero offset to null pointer" failures, but which would have been easy to fix.) (I noticed the missing -O0 when I attached gdb to an instdir/program/python.bin process and `py-bt` only showed "(frame information optimized out)" frames, which this change fixes for --disable-optimized builds.) Change-Id: I9583e60692ae7130377422062f3c6df9334d693f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92362 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-16tdf#66305: xhtml: Add unittestXisco Fauli
Change-Id: Iea9d1c5972534eb7fef17464fda88f559e9a75f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92365 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-16tdf#107696, tdf#111492: xhtml: Add unittestXisco Fauli
Change-Id: Ic276a4ad53920c7f1e8bb8f7bcefe580ef88a446 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92346 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-07-07 14:13:21 +0000