summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-05The checks should apparenty be maArguments.getLength() >= 5Stephan Bergmann
...given that maArguments[4] is accessed two lines further down, in both cases. Looks like typos in b6a7c4da52acf45a7b69d1e81cf9548f8552752e "INTEGRATION: CWS canvas05". Change-Id: Iee8a111126f2b81c9e586fe8e3c569fbd81dd8f4 Reviewed-on: https://gerrit.libreoffice.org/80289 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05ofz#17448 avoid OOMCaolán McNamara
Change-Id: Ie709eb0ce7c3987081b4b01fd96e7f99e7a48c27 Reviewed-on: https://gerrit.libreoffice.org/80240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05ofz#16306 avoid timeoutCaolán McNamara
Change-Id: I668b590d7abf466b90a1123ef9c8b9fed1a907ed Reviewed-on: https://gerrit.libreoffice.org/80251 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05simplify SfxAllEnumItemNoel Grandin
It is just a data carrier for an array of values for SID_ATTR_PATHNAME, it does not need associated enum logic. Change-Id: I547cd5580d02eb9c261feeb3545e31910a4ed644 Reviewed-on: https://gerrit.libreoffice.org/80253 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05Drop bogus memsetStephan Bergmann
..that is both bad and unnecessary since 8003f8694ac7c4bc117f7ce692339534d37681f0 "loplugin:useuniqueptr in oneToOneMappingWithFlag" changed oneToOneMappingWithFlag::mpIndex from an array of raw pointers to an array of std::unique_ptr. Change-Id: I247a619ebd7804a8a4faee2797f8c4753f9c4ec6 Reviewed-on: https://gerrit.libreoffice.org/80288 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05Convert some SID in sd to SfxUInt16ItemNoel Grandin
Some, like SID_NAVIGATOR_PAGE were incorrectly using SfxAllEnumItem, and others did not need to use SfxAllEnumItem. Change-Id: I0f61dcdda8bbc021667db3cf78141778f7b85087 Reviewed-on: https://gerrit.libreoffice.org/80252 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05Convert various FID_VALID_* to SfxUInt16ItemNoel Grandin
Change-Id: Ic21ec69513ee520cedc026b8c2d657464beed19b Reviewed-on: https://gerrit.libreoffice.org/80250 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05Convert various RPTUI_ID_* to SfxUInt16ItemNoel Grandin
Change-Id: I261c30c35d3967ece7078b8529a42e646c00a90f Reviewed-on: https://gerrit.libreoffice.org/80249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05Convert SID_PAPER_START/END to SfxUInt16ItemNoel Grandin
Change-Id: I62067075853b1d5c893c14d72a247b07a3cc5585 Reviewed-on: https://gerrit.libreoffice.org/80248 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05Convert SID_ENUM_PAGE_MODE to SfxUInt16ItemNoel Grandin
Change-Id: I5cffa31b45b7752ba3ff18c8a92da9766fcf8de6 Reviewed-on: https://gerrit.libreoffice.org/80241 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05use SfxUInt16Item for SID_ATTR_TRANSFORM_SIZE_POINTNoel Grandin
Change-Id: Id7762047a17a1652c91761d3c910eadd3393040b Reviewed-on: https://gerrit.libreoffice.org/80237 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05Drop bogus memsetStephan Bergmann
...that is both bad and unnecessary since 57871f98d30c0283969de1a41e72f5838d6c0eb0 "loplugin:useuniqueptr in SwNumRule" changed SwNumRule::maFormats from an array of raw pointers to an array of std::unique_ptr. Change-Id: I0cb05f022b2f067c0b62ecd42878377b139ec4fe Reviewed-on: https://gerrit.libreoffice.org/80281 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05Drop bogus memsetStephan Bergmann
...that is both bad and unnecessary since 76643b208c7f0c43b0603e08a3b37f29878c42ea "loplugin:useuniqueptr in SvxNumRule" changed SvxNumRule::aFmts from an array or raw pointers to an array of std::unique_ptr. Change-Id: I889da7973958d5546ded67be4f51f6312b240ea9 Reviewed-on: https://gerrit.libreoffice.org/80275 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05Remove redundant memsetsStephan Bergmann
...since 1f8c2a2e5c8bda6e6e35a868e5ac7afdc7d32317 "coverity#1187868 Uninitialized pointer field" introduced a default ctor zero-initializing all members of SystemEnvData Change-Id: Ifd31282ab4b82e26733afdd74c234a8a1b4dbb4c Reviewed-on: https://gerrit.libreoffice.org/80255 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05Drop bogus memsetsStephan Bergmann
...that are both bad and unnecessary since 54604f01330063635fb974b0ab4335d6af851551 "loplugin:useuniqueptr in SwNumRulesWithName" changed SwNumRulesWithName::aFormats from an array of raw pointers to an array of std::unique_ptr. (GCC -Wclass-memaccess didn't catch that because it apparently fails when the argument is of array instead of pointer type.) Change-Id: I6a4a03b1d16c203118fc83c0c3c44646be39a5b3 Reviewed-on: https://gerrit.libreoffice.org/80254 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05bin/find-most-common-warn-messages.py: Switch to python3Michael Weghorn
python2 is nearing its EOL. (The new version still runs fine with python2 if explicitly called as 'python2 bin/find-most-common-warn-messages.py'). Change-Id: I1153a3e468a7f36c299767a32f683b84efa8af04 Reviewed-on: https://gerrit.libreoffice.org/80286 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-10-04ofz#17675 loop in lwp filterCaolán McNamara
Change-Id: Id0c75e03794a622a9353559453ab5688c31f4b9d Reviewed-on: https://gerrit.libreoffice.org/80238 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04ofz#17992 null derefCaolán McNamara
presumably since... commit f9aac900ada3d507526eeeed5b51fc7a10ab4cae Date: Wed Oct 2 14:57:16 2019 +0200 tdf#81100 DOCX import: repeat header according to table style Change-Id: I4f093606a15909c8e29b18dfb792abd938a80c5b Reviewed-on: https://gerrit.libreoffice.org/80234 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2019-10-04ofz#17823 avoid timeoutCaolán McNamara
Change-Id: I3658d476873a502adc0cbd8be9a4f6ffd5b62c87 Reviewed-on: https://gerrit.libreoffice.org/80236 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04SvtFileView not referenced in any .uis anymoreCaolán McNamara
through the fpicker constructs one directly Change-Id: Ic365231e78ca9425b97006a156273479d104eae9 Reviewed-on: https://gerrit.libreoffice.org/80211 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04weld OCollectionViewCaolán McNamara
Change-Id: I3aac2b42442ec3f61c2d18369eae061ae44880a5 Reviewed-on: https://gerrit.libreoffice.org/80205 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04tdf#127529 vertical text not drawn in slideshow canvasCaolán McNamara
because the canvas text drawing impl falls back to using an OutputDevice view of the canvas to use the vcl text drawing apis to achieve vertical text To get an OutputDevice view of the canvas there is a specific VirtualDevice ctor available to create a VirtualDevice that, unlike the normal case, doesn't have its own specific backing buffer, but instead draws to the underlying target provided via the SystemGraphicsData arg The svp/gtk impl missed that understanding and provided an ordinary VirtualDevice with its own backing buffer, not a VirtualDevice that would draw to the expected target surface of the canvas. So the vertical text was drawn to a different surface than the intended one, and was just discarded. The cairo use in the canvas long precedes the use of cairo in vcl itself. Seeing as text is now rendered with cairo in all cases where the canvas uses cairo its probably now pointless for canvas to have its own text rendering path. Change-Id: Ie3b0a43ca2b746cbfe25e2d0415315b3d5403cd2 Reviewed-on: https://gerrit.libreoffice.org/80162 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04drop unnecessary includesCaolán McNamara
Change-Id: I2d6828734cfdf795499d54e1b1e8ba9fc4b5a4d1 Reviewed-on: https://gerrit.libreoffice.org/80197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04drop some unnecessary includesCaolán McNamara
Change-Id: I5bea83184dd900215ca6f60ba23a4d724789c753 Reviewed-on: https://gerrit.libreoffice.org/80190 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04default arg never usedCaolán McNamara
Change-Id: I4b6277f6dd5557f9ae67588c86819666747400bf Reviewed-on: https://gerrit.libreoffice.org/80191 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04Related: tdf#127529 make it harder to misunderstand this VirtualDevice ctorCaolán McNamara
Change-Id: I250bc68da118a994a2e0ff8ab9eb11112827756d Reviewed-on: https://gerrit.libreoffice.org/80158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04document 0 len case of set_max_lengthCaolán McNamara
Change-Id: I8300ff2d68f35da38e2314eefa7f2a2184981eab Reviewed-on: https://gerrit.libreoffice.org/80194 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04sSubFolder contents is always overwrittenCaolán McNamara
Change-Id: Ic2183a81f85dfec5361db9bf42174f2f9218ae5b Reviewed-on: https://gerrit.libreoffice.org/80204 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04Fix typoAndrea Gelmini
Change-Id: I553bbcdeef269317d97bed5242bc64cb1b42f91c Reviewed-on: https://gerrit.libreoffice.org/80227 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-04Removed executable bit on cxx and ods filesAndrea Gelmini
Change-Id: I137af32cdd3a9e145c0f436d98670869f15f6673 Reviewed-on: https://gerrit.libreoffice.org/80226 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-04jsdialogs: hide one number format option initiallySzymon Kłos
For now mobile wizard in online uses static ui structure so avoid showing both types of controls for numbers Change-Id: I433fcf389b0dafb7234061e8d9ca56d132c0f257 Reviewed-on: https://gerrit.libreoffice.org/80209 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-04button icons are always left align not top changedandreas kainz
Change-Id: I28156de7d9adc74b02bfcecec82f282b7b1a35bf Reviewed-on: https://gerrit.libreoffice.org/79593 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-04Character dialog - Hyperlink move Events button and labels left alignandreas kainz
Change-Id: I33c3e5a957e84054518836f2cd5efea814bd1815 Reviewed-on: https://gerrit.libreoffice.org/80020 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-04SvxAutoCorrect::GetPrevAutoCorrWord should not be constMike Kaganski
Change-Id: Icc5f8eae4347e097f7ff22212dd94467d0702353 Reviewed-on: https://gerrit.libreoffice.org/80198 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-04Update git submodulesMike Kaganski
* Update helpcontent2 from branch 'master' - Also note that wildcards are supported Change-Id: I696133e08fa63f83f0865719cf477198968cab09 Reviewed-on: https://gerrit.libreoffice.org/80111 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-04Update git submodulesMike Kaganski
* Update helpcontent2 from branch 'master' - An alternative way for strings that contain regex metacharacters Change-Id: I856723418ebc006460b983899d6cbc8fc905988c Reviewed-on: https://gerrit.libreoffice.org/80110 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-04tdf#52316 Writer status bar: show also printed page countsLászló Németh
if they are different from the "normal" page counts. If the document contains automatically inserted blank pages, and the document setting "Print automatically inserted blank pages" is disabled, the status bar still shows page counts with blank pages. This is a problem especially, if the user wants to print a document range, because it's not possible to read the correct printing range from the status bar, and using the showed values, printing can result unwanted and missing printed pages without any notice if the Preview option is disabled in the Print dialog window (otherwise if the differency was noticed, it could be hard or near impossible to correct the range using the Preview window). Now, for example, if the title page followed an automatically inserted blank page and a third page, the status bar shows the following on the third page, if there is a differency in printing: Page 3 of 3 (Page 2 of 2 to print) If the setting "Print automatically inserted blank pages" of the actual document is enabled on page "LibreOffice Writer" of the File->Print... dialog window, or the document doesn't contain automatically inserted blank pages, there is no information about printed pages in the status bar (because there is no differency in page counting): Page 3 of 3 Change-Id: I4cef762b8a8c10ae8f65d27c7ff550855219621e Reviewed-on: https://gerrit.libreoffice.org/80185 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-10-04enable -Wunused-exception-parameter on clangNoel Grandin
which is useful because our MSVC build will warn about this by default Change-Id: Idcc0f08b69b6eda4dd2ab010a5fdb674787bebcf Reviewed-on: https://gerrit.libreoffice.org/80184 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-04loplugin:unusedfieldsNoel Grandin
Change-Id: If0df5216dccd2c0a7aa790668471993f5d4d5d32 Reviewed-on: https://gerrit.libreoffice.org/80183 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-04loplugin:unusedmethodsNoel Grandin
Change-Id: Idd98dc9e1090a6b09124c80eed5a878e5e966cfc Reviewed-on: https://gerrit.libreoffice.org/80182 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-04vcl metafile dump: a relative file path is not a good defaultMiklos Vajna
SvFileStream wants an absolute file URL, so improve the default minimally and also assert that opening the file worked, so the dump is not just silently discarded. Change-Id: Iaea45603db65aff475051ea83ba1b45992d53590 Reviewed-on: https://gerrit.libreoffice.org/80195 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-04sw: add DocumentContentOperationsManager::DeleteDummyChar()Michael Stahl
... and lcl_RemoveFieldMarks() uses it; this avoids the problem that lcl_CalcBreaks() would of course remove the dummy character from the deletion range. Change-Id: Iba0f7901b9efe4af273e17c58c6b40d4fd783efd Reviewed-on: https://gerrit.libreoffice.org/80069 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-04use normal VirtualDevice ctor, not the obscure SystemGraphicsData variantCaolán McNamara
Change-Id: I4be43f692a29b1b1ee3f96bb34133f3ef0cf4eb7 Reviewed-on: https://gerrit.libreoffice.org/80151 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04related tdf#99602 writerfilter: deferredCharProps unhandled in StylesJustin Luth
...so don't add deferred properties during style import. Otherwise, the first paragraph picks up those attributes and applies them. Regression from 2012 - only affects subscript/superscript. Truly fixing this for Character Styles will be tricky, because it depends on the final fontsize - regardless of where it is set. So at the style level, the deferred property needs to be percentized based on SOMETHING, and then at appendText time the fontsize needs to be determined. If escapement is inherited from a style, then the escapement needs to be converted BACK into pointsize (based on style charsize), and then the final percentage can be calculated and directly applied. Yuck. I'm inclined to treat charstyle escapement like pre-2012, which just assigned default values and ignored the actual/given amount. Change-Id: I8e3783533ec18740e1c7d0b36c58b6c7e8ce107f Reviewed-on: https://gerrit.libreoffice.org/80178 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-10-04Revert "uitest: make child soffice process die when parent dies"Stephan Bergmann
This reverts commit d35840a2111beafe018851314a624e268e3cde6a, now that 43aef04d77aafb9d055957642e62b559231f3711 "Reliably wait for soffice to terminate" makes sure that no soffice-related processes are left behind by UITests. Using PR_SET_PDEATHSIG had the following drawbacks: * It defeats debugging if a runaway process is forcefully killed by the test framework. (And there are already higher-layer mechanisms in place for the reliable termination of runaway tinderbox builds, see the commit message of 43aef04d77aafb9d055957642e62b559231f3711 mentioned above.) * It is brittle in that it can terminate soffice-related processes too early, as the signal is sent as soon as the parent's thread that spawned the child (and not the parent process as a whole) terminates. * It is Linux-only. Change-Id: Ia07f5dbaafc824bad0dfbdb1a2aabe6d5508741b Reviewed-on: https://gerrit.libreoffice.org/80186 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-04Deduplicate some serializer writing code, and simplify writing OStringMike Kaganski
Change-Id: I391f8cb499a83f1f774fdcaa794169a218bdc7e5 Reviewed-on: https://gerrit.libreoffice.org/80189 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-04sw: SwXTextPortion "TextFieldSeparator"Michael Stahl
Change-Id: I60a5036168287b1972c18e74431b7a6101d85304 Reviewed-on: https://gerrit.libreoffice.org/80052 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-04sw: add CH_TXT_ATR_FIELDSEPMichael Stahl
... and handle it in obvious places. Change-Id: I7e9668994be0bd246f89ecc60fd0a42c240cce0c Reviewed-on: https://gerrit.libreoffice.org/80051 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-04sw: add IDocumentMarkAccess::getFieldmarkAt()Michael Stahl
... and use it where the mark for a given CH_TXT_ATR_FIELD* is retrieved. Change-Id: Id58ac2967ab66be8a07586ef31cfe9e18a5f073d Reviewed-on: https://gerrit.libreoffice.org/80050 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-04sw: add PortionType for fieldmarks for debuggingMichael Stahl
Change-Id: Ie263b09ac499cf30e294300b9ad609461f6ba0ac Reviewed-on: https://gerrit.libreoffice.org/80049 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
generated by cgit (git 2.34.1) at 2024-08-03 18:35:40 +0000