summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-11-02cid#1455215 Improper use of negative valueCaolán McNamara
Change-Id: I0a397cb54192b613bf61a8faa384507b9731b828 Reviewed-on: https://gerrit.libreoffice.org/81940 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02weld SfxRecordingFloat_Impl utility windowCaolán McNamara
we can't abuse action_name anymore as the uno command are not legal actions Change-Id: Iaf9306c6e3eec852d2a50df9161bd20383881a04 Reviewed-on: https://gerrit.libreoffice.org/81902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02Table panel: Make sure all toolbox buttons has the right initial stateTamás Zolnai
For this we need to add a ControllerItem for all toolbox buttons. See SfxStateCache::SetCachedState(). Change-Id: Id69a92fe5748617e3cd98c3007afbff2885a5d3b Reviewed-on: https://gerrit.libreoffice.org/81899 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Remove useless bool manipulation.Tamás Zolnai
Must be a left over of sal_Bool -> bool conversion. Change-Id: I8b37e513dc1f36b015b29ce3dad4ade2df7807d9 Reviewed-on: https://gerrit.libreoffice.org/81898 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Table panel: Make sure Row Height spin button works with the default size typeTamás Zolnai
SwFormatFrameSize() object has ATT_VAR_SIZE size type by default, before we change it to anything else. We will change ATT_VAR_SIZE to ATT_MIN_SIZE when changing the row height on the sidebar panel, similar to the row height dialog. Change-Id: I2520340e023b910549ff2a4b011e9ae3da2b7b11 Reviewed-on: https://gerrit.libreoffice.org/81897 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Table panel: Redesign the panel a bitTamás Zolnai
* Remove some labels. * Move 'Merge Cells' button next to the insert / delete buttons. Change-Id: Ibe0acc8e8825dbaa84464bc7347f7711f8185680 Reviewed-on: https://gerrit.libreoffice.org/81896 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Table panel: Implement functionality of Column Width spinbuttonTamás Zolnai
Change-Id: I809cfe4af82cebabe80c171cdd488ff43d749a86 Reviewed-on: https://gerrit.libreoffice.org/81895 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Table panel: Implement functionality of Row Height spinbuttonTamás Zolnai
Change-Id: Ic3e3ce31fdc74c9cb4c41e1243f10f5977d5bb0c Reviewed-on: https://gerrit.libreoffice.org/81894 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Add new 'Table' sidebar panel to WriterTamás Zolnai
This is the initial layout of the panel. It does not functional yet. Change-Id: Idd67ed921b71559bb704ef50cbfa97013fb80d6b Reviewed-on: https://gerrit.libreoffice.org/81893 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-01tdf#126128 Reduce page properties dialog's height.Gülşah Köse
Change-Id: Ie35c9cb4c9b134a94f3a125dd800936b7160950c Reviewed-on: https://gerrit.libreoffice.org/81910 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-11-01Removed executable permission on src fileAndrea Gelmini
Change-Id: Id4dc99968fc453f5ab3ee5e7b30bfacf79e843b7 Reviewed-on: https://gerrit.libreoffice.org/81867 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-01tdf#126966: Use larger buttons for the colours in the sidebar on iOS - 2Marco Cecchetti
Attempt to merge this with Noel's re-work of the color picker. Change-Id: I9687546889bc20ef95a50aeafbc6f40e939d57a9 Reviewed-on: https://gerrit.libreoffice.org/81755 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/81900 Tested-by: Jenkins
2019-11-01ofz#18660 don't parse past endCaolán McNamara
Change-Id: I3d18202ec637c0231dcf71f2d02c79fab0dc7403 Reviewed-on: https://gerrit.libreoffice.org/81906 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-01ofz#18646 ensure we are inside valid rangeCaolán McNamara
Change-Id: Ide4d4bfad5b365a42790454cca709d175054c933 Reviewed-on: https://gerrit.libreoffice.org/81908 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-01Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - More informative descriptions for GlobalScope, xxLibraries Links to existing examples Note to API materiel Change-Id: Iaee88045b212388ef1cf0fa6207da96bf544d0af Reviewed-on: https://gerrit.libreoffice.org/81889 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-01Fix use of uninitialised variableLuke Deller
Ensure ImpGraphic::maSwapInfo.mbIsTransparent/mbIsAlpha are initialised in the case where image type detection fails. Change-Id: I103d77760326aa3833dd3730ec65fd53d360271b Reviewed-on: https://gerrit.libreoffice.org/81882 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-01the label sync button will relaunch itself from its close handlerCaolán McNamara
so rearrange things so that runAsync can survive that Change-Id: I7d40637fb861ceb64ce32f0e9ecb3451c0d17bad Reviewed-on: https://gerrit.libreoffice.org/81884 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-01README: Add Weblate badge for core l10nAdolfo Jayme Barrientos
Change-Id: Ie188f4d7e5ac3291933089a72be638e9af935097 Reviewed-on: https://gerrit.libreoffice.org/81856 Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com> Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-11-01Resolves: tdf#128476 limit sidebar navigation panel file name combobox widthCaolán McNamara
Change-Id: I81549ada6f6b736ad54e18a4fec6807b8d0412af Reviewed-on: https://gerrit.libreoffice.org/81875 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-01Update git submodulesAndras Timar
* Update translations from branch 'master' - Updated Slovenian translations Change-Id: I205dc5dbdc62bba2c9ac650902d1a8ac1e80db4e
2019-11-01loplugin:finalclasses in sd/incNoel Grandin
Change-Id: I29c7656d532fc0c8bcf1379a2f54d052aa4253e8 Reviewed-on: https://gerrit.libreoffice.org/81877 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-01crashtesting: out of bounds on importing tdf90224-2.odtCaolán McNamara
Change-Id: I5697cefd0859f007023fcd356d69db0e2176d67f Reviewed-on: https://gerrit.libreoffice.org/81850 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-11-01Bin code that has been commented-out for ten years.Tor Lillqvist
Change-Id: I315e22ce296418799b6f51618cb6276c461b537b Reviewed-on: https://gerrit.libreoffice.org/81873 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-11-01Workaround for crash on macOS Catalina at least when built with Xcode 11Tor Lillqvist
For some unclear reason, for me at least, when I have built with Xcode 11.1 or 11.2 and run on macOS Cataline, I run into a crash caused by boundless recursion related to the progress bar in the recovery dialog. Not setting mbProgressNeedsErase to true for the "NWF" seems to help. Whether this has some unintended visually bad side effect I don't know, but hey, it's just a progress bar, who cares if it in some circumstances doesn't look perfect? Change-Id: I6c990adde7689633b2c4b5aa42a4a07966565af2 Reviewed-on: https://gerrit.libreoffice.org/81874 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-11-01check-elf-dynamic-objects: GTK3 drags in libharfbuzz.so.0Michael Stahl
... now on Fedora 31; it looks quite stable ABI-wise so we can allow it. Change-Id: Ic24fa9bdac0d0ce765e3d3844ce4ddcc59c6c9da Reviewed-on: https://gerrit.libreoffice.org/81864 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-01coinmp: disable "glpk", whatever that isMichael Stahl
On Fedora 31, this happens in CppunitTest_sccomp_solver: - loading component library <file:///work/lo/master/instdir/program/libsolverlo.so> failed > nm -D instdir/program/libCbcSolver.so.3 | grep cbc_glp_prob U cbc_glp_prob > grep -r COIN_HAS_GLPK workdir/UnpackedTarball/coinmp | grep config.h workdir/UnpackedTarball/coinmp/Osi/src/Osi/config.h:/* #undef COIN_HAS_GLPK */ workdir/UnpackedTarball/coinmp/Clp/src/config.h.in:#undef COIN_HAS_GLPK workdir/UnpackedTarball/coinmp/Cbc/src/config.h:#define COIN_HAS_GLPK 1 workdir/UnpackedTarball/coinmp/CoinUtils/src/config.h.in:#undef COIN_HAS_GLPK Somehow 2 different configures in coinmp got different ideas about whether something named "glpk" is available.... no idea what that is, it looks like there's a "glpk-devel" package installed on the system, and i doubt that a dependency on that would be desirable. Change-Id: Ief01b6aedc692197c1a8fd6351aef4281e530e70 Reviewed-on: https://gerrit.libreoffice.org/81863 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-01crashtesting: fix creating increments array in tdf106848-1.odtKatarina Behrens
else duplicate indexes happen and sort algorithm falls flat on its face Change-Id: I2b79e8df0f0a8e68117029630c0e026b8c202b02 Reviewed-on: https://gerrit.libreoffice.org/81775 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2019-11-01Accept iOS SDK 13.2Tor Lillqvist
Change-Id: I5d42a60a257661f39d1c9af6299ca3278f783d2b Reviewed-on: https://gerrit.libreoffice.org/81870 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-11-01tdf#127921 Don't change slides when clicking in Slide sorter viewSamuel Mehrbrodt
Change-Id: I21dfe232234d29dd110771a9edf9d4b9b0f6d53b Reviewed-on: https://gerrit.libreoffice.org/81833 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-01loplugin:finalclasses in sc/incNoel Grandin
Change-Id: I6a08a86262deae4bed3a05f77d3041a568f23595 Reviewed-on: https://gerrit.libreoffice.org/81853 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-01loplugin:finalclasses in xmloffNoel Grandin
Change-Id: I664aa4dce822bcf14368fd8d08f678e2cd41fd12 Reviewed-on: https://gerrit.libreoffice.org/81852 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-01odk: fix for change directory in complextoolbarcontrols sampleVasily Melenchuk
On Windows classical "cd" command does not change drive automatically. So if OO_SDK_OUT folder located on another drive than SDK_HOME we will receive confusing buid errors. To avoid this for Windows configuration we should use "cd /d". Change-Id: I22908d49fc915d3a834972357934349ba82bbec5 Reviewed-on: https://gerrit.libreoffice.org/80827 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-01Add ability to set tooltip text for toolbar controlsSerge Krot
Change-Id: I994b9cee248900786e0d386bd648bd1d64aeeff7 Reviewed-on: https://gerrit.libreoffice.org/79676 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit 092273919e1adec93617b08ebf1d44088301365c) Reviewed-on: https://gerrit.libreoffice.org/81639 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-01Toolbar: add usage of FixedText as toolbar controlSerge Krot
Change-Id: I26a79c485fa2e168058025e058bcfb793af7515f Reviewed-on: https://gerrit.libreoffice.org/81039 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit c2682ba52ea0cbb7af95e80f6d67b286061aeae2) Reviewed-on: https://gerrit.libreoffice.org/81643 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-01ToggleButton: add ability to set tooltip text for pop-up menu itemsSerge Krot
Change-Id: Iacd5c97438782ffddc8a9196688e1d58abce9abe Reviewed-on: https://gerrit.libreoffice.org/80906 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit 8f79936d5278fd5172f5864f99befaa878de5f5d) Reviewed-on: https://gerrit.libreoffice.org/81642 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-01Tooltips: Use HELPWINSTYLE_BALLOON when tooltip contains \nSerge Krot
Change-Id: I33ef48b5a90338471d85a613ede73eada323381c Reviewed-on: https://gerrit.libreoffice.org/80825 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit ba5722319a585bf887965177f2d26e859b8e732b) Reviewed-on: https://gerrit.libreoffice.org/81641 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-10-31Fix typoAndrea Gelmini
Change-Id: Id26980c410f512f711f674af72d070e3b074f13b Reviewed-on: https://gerrit.libreoffice.org/81866 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-31tdf#128431 Box info item is needed by the Border Background dialogJim Raykowski
...so put it back Change-Id: Ie2883410514496c247f840fb2d6755bec362a8b2 Reviewed-on: https://gerrit.libreoffice.org/81815 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-10-31jsdialogs: refresh SidebarDockingWindow after eventSzymon Kłos
Before we had JSON genertion in Deck now it was moved to the parent. Change-Id: I0fc11ec716542fd3aa6862292ae94985ee3d20d4 Reviewed-on: https://gerrit.libreoffice.org/81854 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-31pass an explicit parent for the password dialogsCaolán McNamara
Change-Id: Ic25d6b61750df9ccf5271df1b4d314ae9cb07550 Reviewed-on: https://gerrit.libreoffice.org/81758 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31crashtesting: null deref on import of fdo51601-2.xlsxCaolán McNamara
Change-Id: I2db907a9247b622b3977aec9686c09d56fe3ef38 Reviewed-on: https://gerrit.libreoffice.org/81846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31avoid intermediate vcl::WindowsCaolán McNamara
Change-Id: Ie0618107a3aee4a0d35867f3c1cf83715e7bc842 Reviewed-on: https://gerrit.libreoffice.org/81763 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31tdf#125688, cache token names as OUStringNoel Grandin
to avoid construction cost, shaves 2% off load time Change-Id: I37a70a6e989f53d67911a6cb217d07e2db55cb44 Reviewed-on: https://gerrit.libreoffice.org/81841 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-31tdf#125688, better sizing for some OUStringBufferNoel Grandin
Change-Id: Ib1f49a53bd5e799455b57abd8532e3e61e119abe Reviewed-on: https://gerrit.libreoffice.org/81840 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-31tdf#125038 DOCX import: better support for linebreaks in IF fieldsMiklos Vajna
IF fields can't contain linebreaks, so instead of just calling finishParagraph() and hoping it does something sane, explicitly handle them: remember the properties and perform the call only once the field is closed. Change-Id: I676aa2c83f12cb600829177a0eb25558822b1d94 Reviewed-on: https://gerrit.libreoffice.org/81847 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-31Fix typosAndrea Gelmini
Change-Id: I917e4cdac3690dd5134e4994a0ee4106ae88ae36 Reviewed-on: https://gerrit.libreoffice.org/81860 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-31crashtesting: null deref on import of fdo64646-4.xlsCaolán McNamara
Change-Id: Ie9d3e06a713660124148362f97f0f9dbe45f69bc Reviewed-on: https://gerrit.libreoffice.org/81844 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31crashtesting: null deref on import of fdo48634-1.xlsCaolán McNamara
Change-Id: If718c39d31ae214f02cbb747f0ceafd35b297521 Reviewed-on: https://gerrit.libreoffice.org/81843 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31avoid intermediate vcl::WindowsCaolán McNamara
Change-Id: I5d6a03baed2af5801132f3e3a0411867ba60186e Reviewed-on: https://gerrit.libreoffice.org/81760 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Update Impress help pages (wip) refactor pages after menu changes remove unused page. Change-Id: I85caa9ab6cb42cf8da018d8e54e3387397b0e9f6 Reviewed-on: https://gerrit.libreoffice.org/81859 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>