summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-07-06make binary functor unary, related tdf#108782dcvb
PropertyValueEqualFunctor was only used as unary functor with std::bind2nd Change-Id: Ic91e49de360e04ec5250f2d63f49163a8e7c7b92 Reviewed-on: https://gerrit.libreoffice.org/39624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06Assert that GetClipDoc() is indeed a clipboard document, tdf#108612 relatedEike Rathke
Change-Id: Idb782bc04239e28967830fae9e89a7433579669b
2017-07-06ofz#2410 avoid oomCaolán McNamara
Change-Id: If9f5ed5c9b229eab7779b2e07bd33c8094510c36 Reviewed-on: https://gerrit.libreoffice.org/39655 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06crashtesting: 554 crashing documents on export to .docCaolán McNamara
regression from... commit d72e0cadceb0b43928a9b4f18d75c9d5d30afdda Date: Mon Jun 19 15:32:16 2017 +0200 Watermark: tdf#91687 correct size in the .doc hopefully this fix is correct Change-Id: I17512ffdd4db605e79b3adb97551e6f4e3816f2f Reviewed-on: https://gerrit.libreoffice.org/39661 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06Attempt to blind fix tdf#108612 explicitly checking for clipboard documentEike Rathke
It seems that for some yet unknown reason in an (un)certain constellation ScDocument::IsClipboardSource() returns true because ScModule::GetClipDoc() does not return the clipboard document but the actual document instead, so destroying the clipboard document executes ScDocument::ClosingClipboardSource() and (or in earlier versions) ScDocument::ForgetNoteCaptions() on the actual document instead. Check also that ScDocument::bIsClip is set, hopefully curing the symptom, the real cause is something else. Change-Id: I5ffd0706592d2737808e7004630a56c53115295b
2017-07-06ofz#2469 docshell leaks if progress bar is not stoppedCaolán McNamara
Change-Id: I2595833dd3c6c9e05a32b70c880444128d66c4d3 Reviewed-on: https://gerrit.libreoffice.org/39643 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06nLCode is signed, so check for > 0Caolán McNamara
Change-Id: I2e40d020d088679a8f9d197485a782d511012bd5 Reviewed-on: https://gerrit.libreoffice.org/39657 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06valgrind: use of uninitialized valueCaolán McNamara
Change-Id: I09279bf27eaa227ab6cdb74e79a1d03e424bb8db Reviewed-on: https://gerrit.libreoffice.org/39656 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06ofz: fix some leaksCaolán McNamara
Change-Id: Icf43996a57aa4284b309e127431e7406b833d88f Reviewed-on: https://gerrit.libreoffice.org/39642 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06tdf#43157 - osl: convert OSL_ASSERT in unx & w32 tempfile.cxxChris Sherlock
Change-Id: I243a5dc4061844af95eae83347ddb15ea7134c0c Reviewed-on: https://gerrit.libreoffice.org/39542 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-06ofz: fix some leaksCaolán McNamara
Change-Id: Ia29ccd98c60bb73ce2532e47eefc317de1e87303 Reviewed-on: https://gerrit.libreoffice.org/39641 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06ofz: fix some leaksCaolán McNamara
Change-Id: I35dcd9db95cd1bd567202b4cf61c8e166e17c099 Reviewed-on: https://gerrit.libreoffice.org/39640 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06ofz: fix some leaksCaolán McNamara
Change-Id: I73806c0fff325159c624e87338aac3bbe61c9382 Reviewed-on: https://gerrit.libreoffice.org/39639 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06ofz: fix some leaksCaolán McNamara
Change-Id: Ia5961336fc399b079814cbcf66d47a465f5ba789 Reviewed-on: https://gerrit.libreoffice.org/39638 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06ofz: fix some leaksCaolán McNamara
Change-Id: I2542447ed6bf5098829c3d8c77435d39c1cb2e5f Reviewed-on: https://gerrit.libreoffice.org/39637 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06ofz: fix some leaksCaolán McNamara
Change-Id: I908114f12257fdd287cce9a108d5fb2dc7b6a8bf Reviewed-on: https://gerrit.libreoffice.org/39636 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06ofz: fix some leaksCaolán McNamara
Change-Id: I14a0a2ad39d388d8d96d2100be46b8b4c239e644 Reviewed-on: https://gerrit.libreoffice.org/39635 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06ofz: fix some leaksCaolán McNamara
Change-Id: I6c4706e203f82d692630b4953e48050c71235d16 Reviewed-on: https://gerrit.libreoffice.org/39634 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06ofz: fix some leaksCaolán McNamara
Change-Id: I9f5640461d09103ed6da4613e7ca520bc54b3c51 Reviewed-on: https://gerrit.libreoffice.org/39633 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06ofz#889: UriReferenceFactory unavailableCaolán McNamara
Change-Id: Id041976e273c0ee2c1862c7a27dd39cfac12aaaf
2017-07-06ofz: fix some leaksCaolán McNamara
Change-Id: I7394f9b9c51fd827c5381119d32f5c75a95feb5c Reviewed-on: https://gerrit.libreoffice.org/39632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06GSoC: Recent Charaters Toolbar Dropdown ControlAkshay Deep
Change-Id: Ib04d26fa5556e5c32db6799c16d0bbedc45504ec Reviewed-on: https://gerrit.libreoffice.org/38944 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-06Translate German comments/debug strings (leftovers in dirs sdext to soltools)Johnny_M
Translates leftovers found using a custom regex and manually checking the rest of the affected file. Additionally: - Translation of someone's attempts at Spanish in the .java file Change-Id: Ie3a761bc1a8e302247d5dd6e93a6bc4cb3e85a9f Reviewed-on: https://gerrit.libreoffice.org/39609 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-06ofz: more leaksCaolán McNamara
Change-Id: Ibb388c1596894ea3e9cd3d3ecd5f299aa9ccf8be Reviewed-on: https://gerrit.libreoffice.org/39631 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06ofz: fix leakCaolán McNamara
Change-Id: I4cb6f83d7c55f673f31a77efdbd65bcf1e00d741 Reviewed-on: https://gerrit.libreoffice.org/39630 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06tdf#106990 set cleartype setting / force to use GDI render modeTomaž Vajngerl
With this we read the system setting for cleartype and set it to the render target we are using. Additionally we set the GDI like rendering mode which forces that the text is rendered similar as this was done with GDI. Change-Id: If6fb72bc371accf50278c968c94e625aee3f0953 Reviewed-on: https://gerrit.libreoffice.org/39602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-06ofz: stay inside stringCaolán McNamara
Change-Id: Ia0d0ddfce4ee3d5f8763be6804fe52c514375bb3 Reviewed-on: https://gerrit.libreoffice.org/39629 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06loplugin:unusedfields in scNoel Grandin
found a couple more by running make build-nocheck to exclude testing code Also, teach unusedfields loplugin about operator<<, since referring to a field in an ostream operator<< does not indicate a real use, it's normally for debugging Change-Id: I3dce22bf5afda2fd09e01de9bf1d0ef85e535aa8 Reviewed-on: https://gerrit.libreoffice.org/39625 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06LibreOffice.natvis: several new visualisersMike Kaganski
Change-Id: I451797b987ec7a8ffa069cbf34f0c22d6c1ce280 Reviewed-on: https://gerrit.libreoffice.org/39628 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-07-06tdf#108524 sw: split section frames inside table cells, non-split text framesMiklos Vajna
Commit f991b842addddeada6dc45c4054deeca5aa7f17b (tdf#108524 sw: attempt to split section frames inside table cells, 2017-06-19) added initial support for multi-page sections inside a table cell, but turns out this only worked in case at the split point there was a long enough paragraph, so it was split into two (a "master" text frame and a "follow" one), and then the follow was moved to the next page by SwContentFrame::MakeAll(), with the MoveFwd() call in the "If a Follow sits next to its Master and doesn't fit, we know it can be moved right now." block. However, if the section contains lots of one-liner text frames, then all of them are masters, so the above code doesn't move them to the next page; so the section frame is still not split. Fix the problem by allowing the move of frames inside table-in-sections in SwSectionFrame::MoveAllowed(), that way SwTextFrame::AdjustFrame() will not set the text frame as undersized, so at the end SwContentFrame::MakeAll() will call MoveFwd() in the "If a column section can't find any space for its first ContentFrame" block. With this the split of text frames in section-in-table frames is consistent regardless if they are of multiple or single lines. Change-Id: Ief9d62da3fd8a5c707e1f9489a92f7a81e7b38ac Reviewed-on: https://gerrit.libreoffice.org/39623 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-06simplify LocalFileHelper::GetFolderContentsNoel Grandin
Change-Id: Iaab871f0ec87fadb54fe0a2cb3b92052de9434b8 Reviewed-on: https://gerrit.libreoffice.org/39621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06tdf#108782 replace std::bind2nd with lambdaJochen Nitschke
and inline PropertyValueCompare functor Change-Id: Ie8fd33810f7897cad35a727286b546a17db43ab7 Reviewed-on: https://gerrit.libreoffice.org/39603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-07-06libxmlsec: no need to build the gcrypt backend on Linux/macOSMiklos Vajna
We only use the NSS one. Change-Id: I84c89cb22a1b880d59ada4b68167e14c1223a177 Reviewed-on: https://gerrit.libreoffice.org/39618 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-06tdf#108821 - fixed bad alloc on opening large fileMichael Meeks
Workaround for streams with size > SAL_MAX_INT32. More complicated ways using available() and navigating cross-thread are possible, but probably harder to maintain. Change-Id: I721b1f38055dfcea03fef555b8a5fd93dfc1b886 Reviewed-on: https://gerrit.libreoffice.org/39374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-06tdf#108923 : Use display string for generating chart labelsDennis Francis
Use display string for generating chart labels in PivotTableDataProvider::collectPivotTableData as chart2 does not seem to use number format for labels although it does for the data. Added unit test PivotChartTest::testPivotChartWithDateRowField() for this fix. Change-Id: I668d4c9d7cf8bbb7e4213cce7a6e7cd4d7d07cbe Reviewed-on: https://gerrit.libreoffice.org/39548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-07-06remove unused text property of spinbuttons for animation delayStanislav Horacek
to remove numbers from translatable strings Change-Id: I347fc15a3f80c6c2cb72d7676138c9b80557a478 Reviewed-on: https://gerrit.libreoffice.org/39610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-07-06ensure safe GlobalEditData release of xForbiddenCharsTableCaolán McNamara
ensure that when the editeng GlobalEditData dtor is called that the vtable of the xForbiddenCharsTable shared_ptr will point to functions that are callable from editeng. otherwise a shared_ptr created in the sw uwriter cppunit test, but now belonging to GlobalEditData, will have deleter entries pointing to functions in uwriter that have been unloaded and are not available anymore Change-Id: I375a84156c0b1a0f8b24194fc07f0c512f556dbc Reviewed-on: https://gerrit.libreoffice.org/39605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06silence coverity#1414485 Uninitialized pointer fieldCaolán McNamara
Change-Id: If62f528b1118aee702f364aa448e36230512fac6 Reviewed-on: https://gerrit.libreoffice.org/39572 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06rework as a shared_ptrCaolán McNamara
mostly to try and track down a crash on exit of sw uwriter under windows Change-Id: Id67e93863056da319dd8225038d60a7f5783b103 Reviewed-on: https://gerrit.libreoffice.org/39604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06use more begin()/end() for SequenceNoel Grandin
Change-Id: I399be6b6ef7a6ce01e883569a177c0969bc29c69
2017-07-06teach unnecessaryparen plugin about other kinds of statementsNoel Grandin
i.e. do / while / switch Change-Id: Id0985015cc425557f9984734701d56466f8a6088 Reviewed-on: https://gerrit.libreoffice.org/39601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06loplugin unnecessaryparan improvementsNoel Grandin
Change-Id: I73e945d6ec53537a0da45f6b6291018c7f251a7e Reviewed-on: https://gerrit.libreoffice.org/39587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06tdf#108782 replace std::bind2nd with lambdaJochen Nitschke
in preparation of removal of deprecated std::binary_function Change-Id: Ibbf9e4689301d1eb525ee965c75d07077291a6ac Reviewed-on: https://gerrit.libreoffice.org/39556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06writerfilter: remove unused nkey variable assignmentJustin Luth
Introduced with Noel's commit f433a86839499662cfc1356882b0538f01d850b6. It looks like leftover debugging code (to check that the value written is the value retrieved). Change-Id: Idd9dffedf14788be19193785855060733a0b3e3e Reviewed-on: https://gerrit.libreoffice.org/39616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-05loplugin:unnecessaryparenStephan Bergmann
Change-Id: Ifeacfc198c71ae1224ef38a4c8b95b31364f8227
2017-07-05coverity#1414484 Division or modulo by zeroCaolán McNamara
this looks wrong since initial checkin, why check that xres is non 0 before dividing by yres Change-Id: I5f1c19dadafe561cac8fde4f2bf371587c4ef5f0 Reviewed-on: https://gerrit.libreoffice.org/39573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-05tdf#108873 fix merge data handling in fieldsJan-Marek Glogowski
This is a regression from tdf#70346 / commit 4851cde7b98226b0f82ae2b191c290173e9b06c6 It added the whole DB row as variables to the SwCalc hash set. This works correct for conditionals when hiding sections, but not for conditionals used in fields - actually they break. Previously the field would do a fallback to query the DB again, if no variable was in the dict and the only possible variables in the dict could have been user-defined fields. This handles the added variables correctly for fields. Also fixes a bug to store the DB number values as number variables and adds the record number, as SwCalc::VarLook does. Change-Id: Ib0dbeda68234e671768ede55b2012235a3680276 Reviewed-on: https://gerrit.libreoffice.org/39509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-05Display string results in the Function Wizard quotedEike Rathke
To distinguish number strings from numeric results. Change-Id: I68e044e839b2d5d2e87835dd0002f42aa0fc8192
2017-07-05Make that debuggable despite AnyInput() pendingEike Rathke
Somehow opening the Function Wizard always still has a keyboard input pending when breaking in the debugger so the first calculateValue() call was bypassed. Change-Id: I1ad2fdf1724ae793edc7497895c8d8cead733f86
2017-07-05coverity#1414481 Uninitialized scalar fieldCaolán McNamara
regression from commit 7b850c15b15be10ed3b52822f63b02d8787bcb2f Date: Wed Jun 21 15:32:03 2017 +0200 loplugin:unusedfields in sc part1 Change-Id: Ibd3a8410f7916bf7c03b436f45bf382ff9eb3798 Reviewed-on: https://gerrit.libreoffice.org/39571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-19 13:54:32 +0000