summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-08-04tdf#109347: don't verify SSL certificate for crashreport uploadMarkus Mohrhard
Seems that on Windows we can not rely on the CA information to include the necessary info to verify the connection to the server. Change-Id: Ieed639c438f5a66e538d1126bb1e8ec1ea02b168 Reviewed-on: https://gerrit.libreoffice.org/40642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7457079b85b05dca2a35dc29e0dac1204e6eda00)
2017-08-04CVE-2017-11742: Expat 2.2.3Caolán McNamara
Reviewed-on: https://gerrit.libreoffice.org/40718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f680e5a441cecba4d238f031fc417ef3bccfd792) Change-Id: I1a1de789eaa5a78d2dc0e41ef861d10fa97b689b Reviewed-on: https://gerrit.libreoffice.org/40749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 2351570154e43fe919e5b9dd756bbe13a6b9c60d)
2017-08-04Resolves: tdf#111308 crash after load designs with no design selectedCaolán McNamara
Change-Id: Ia7d5e1d0c4c960700d94cfec01a8a01799f89d9a Reviewed-on: https://gerrit.libreoffice.org/40732 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e325a5442ab350e8eb66458aed98d38ce21aec06) Reviewed-on: https://gerrit.libreoffice.org/40750 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 2b4ebf00d21f6305966c78f82336f9ac76425804)
2017-08-04lo-commit-stat: use matching group before destroying it with another matchChristian Lohmaier
it also doesn't make sense to numerically compare a %hash enable warnings in the script and remove a duplicated variable (and some unnecessary hash-declarations) Change-Id: I0a84dc28f369931ee31a1cf12849fde2b63f1ca2 (cherry picked from commit 249b6a552b00637ae7ad3dcb8d797befba1734ad) (cherry picked from commit 7193a4a1a0df775a0eb2ef222871d46b3c8b92b0)
2017-08-04lo-commit-stat: improve sort in buglists (by number within a tracker)Christian Lohmaier
Change-Id: I8eb5a3d3141fcc76bf5caffe0a7b30d5ec2b0c8c (cherry picked from commit 0b8cccdc20f7e9209de406ee1ec01aec8bfafceb) (cherry picked from commit 5f9da269510ea81bc346aba7364dc39f5e42a5fd)
2017-08-04lo-commit-stat: default to utf8, adjust regex for tdf bugzillaChristian Lohmaier
Change-Id: I61960512e297417eb096b3bc921974aa43f74ccc (cherry picked from commit 9c83796f45e634afd770b772a16209e1dbed7068) (cherry picked from commit cbd3c09e29df72a05025c117def44fbcc1163f20)
2017-08-04lo-commit-stat: drop unnecessary check whether hash is definedChristian Lohmaier
besides using deprecated syntax – "if (defined %hash)" (or "if (defined @array)" for that matter) – just using "if (%hash)" (or "if (@array)") would do, it is also unnecessary to create the hash if it doesn't exist (autovivification will take care of that) Change-Id: Ib5704b2d609ae3658f3c166f9e26a051957149f8 (cherry picked from commit 146258f82fc15d0a5f8779447a4919429496e9e3) (cherry picked from commit 39092ed597bbe3653638736f61748843ddc1cc99)
2017-08-04tdf#107723 Import font name from text portions in shapesSamuel Mehrbrodt
Reviewed-on: https://gerrit.libreoffice.org/40439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 178b361c6379bc963c8a48925f1807c583f2d09f) Reviewed-on: https://gerrit.libreoffice.org/40529 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 07e656c99f86a59039decd462f66fa272ee2fbed) Change-Id: Ib9b73b5c05ec2e6846ea3adc950ccab5d1c0a9b0
2017-08-04tdf#108944 writerfilter: fix missing footnote separatorJustin Luth
Fix regression from e79ef12b7a904f17d4147fa409d055c12b70f952 tdf#107033 DOCX import: fix unexpected missing footnote separator. Initially related to tdf#68787. If HandleMarginsHeaderFooter was called twice, then it automatically would have disabled the separator. Clearing the HasFtn/HasFtnSep flags also shouldn't be run when in the footnote sections. Reviewed-on: https://gerrit.libreoffice.org/40551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 6f57c09aadd40009173f8ae3654004dd0cad9fb8) Change-Id: I00cbd1cbc8dc86edf426f852c59c3f943e373b13 Reviewed-on: https://gerrit.libreoffice.org/40590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 234df2fb5901588ccf20cb35cb4c5922aeb89817)
2017-08-04tdf#109223: PPTX: Vertical flip of child shape is not imported correctlyTamás Zolnai
Group shape level vertical flip is not handled well. Recent handling of group shape's transformation makes it hard to import this attribute, but we can import the right text direction at least. Reviewed-on: https://gerrit.libreoffice.org/40554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit d742c0019435d0bc90c9342492583636099a057f) Change-Id: Ib9e39e3dcb28a95fabc61c13152a3f7296fbd4c3 Reviewed-on: https://gerrit.libreoffice.org/40556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c49f2c00067cbe5de714525807290b71aec57ea3)
2017-08-04tdf#105705 sw: sort bookmarks in ContentIdxStoreImpl::RestoreBkmks()Michael Stahl
The problem here is that the SplitNode() calls in SwRTFReader::Read() destroy the order of the bookmarks, which causes an assert later from the std::lower_bound() when a new mark is created. The 2 marks that cause the problem are: SwPosition (node 5, offset 0) SwPosition (node 5, offset 0), SwPosition (node 5, offset 0) During the 2 SplitNode calls, the second one is corrected by ContentIdxStore and remains on 5, but the first one is not and becomes: SwPosition (node 7, offset 0) ContentIdxStoreImpl::SaveBkmks() does different things when a mark position is exactly on the parameter position: if it has only one position, it is ignored, but if it has a second position, then both its positions are corrected. It is not possible to change the sort order so that marks with one position are sorted behind marks with 2 positions, because while SplitNode() corrects marks "backward", JoinNode() uses ContentIdxStore to correct marks "forward"; hence manually sort the marks. Change-Id: If5b35f18bfd47ffe98c0f67e84d380ca801411a3 (cherry picked from commit f2d2093b2198bd4c65475a60329a5a6a7a8575f1) Reviewed-on: https://gerrit.libreoffice.org/40544 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 75a1dce57f7038bc88c74c4e50dd22306be8cf61)
2017-08-04Related: tdf#109856 redo 'insert multiple tabs after' inserts too many tabsCaolán McNamara
Change-Id: I50e8941408343f8fa9acf017d7c195279952916d Reviewed-on: https://gerrit.libreoffice.org/40628 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit def36294754a7263101b421166195eb1b95d6d6f)
2017-08-04Resolves: tdf#109856 undo 'insert multiple tabs after' doesn't workCaolán McNamara
Change-Id: I534536358b2a949667c1c258bf27e13763c0de57 Reviewed-on: https://gerrit.libreoffice.org/40622 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit b8db40fb2eb39c4330de475a7cc8155d16479218)
2017-08-04tdf#109228: FILESAVE: ODT: Anchor changed to 'to character' after RTTamás Zolnai
Ignore frames without names, becuase the code does not handle them well. It does not affect those use case for which the deduplication code was added. Reviewed-on: https://gerrit.libreoffice.org/40222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 615c2a2c54d3e7aefb4986ae7d8de81a42022988) Change-Id: I08ad062b8b11cc06323467329d8c4e97bc4932dd Reviewed-on: https://gerrit.libreoffice.org/40236 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit de5afba4c116792d795339f7e773e302259d8bf0)
2017-08-03lok - add support for in place chart editingMarco Cecchetti
This commit add a minimal support for editing chart embedded in a spreadsheet or a text document or a presentation. Graphic object can be moved and resized, text object can be edited. Change-Id: I8e637dabf328a94bd6bb0e309a245302cff421d8 Reviewed-on: https://gerrit.libreoffice.org/40681 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-02lok: Support RTF as output format.Jan Holesovsky
Change-Id: Ifea2d1dbf3d4424af557c18e31404e07f8ae89c2 Reviewed-on: https://gerrit.libreoffice.org/40690 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-07-31build fixcp-5.3-21Andras Timar
Change-Id: I8cc1b9fc7120249fc3a1287f70e7b4327eab62a6
2017-07-31tdf#109537: treat Temporary Internet Files as temp directoryMike Kaganski
... on Windows. Also, when testing against ordinary temp directory, use system path, not LibreOffice temp directory (thanks to Aron Budea). Change-Id: I52ecddc65097d6d64ec45e882cce8f1e7006794d Reviewed-on: https://gerrit.libreoffice.org/40594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 22334f8a003d26c71d772a8e00fc80b7e6d2bef1) Reviewed-on: https://gerrit.libreoffice.org/40601 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-07-31Bump version to 5.3-21Andras Timar
Change-Id: I207c94c06740d95197ba305b9648fb95783ce01f
2017-07-31tdf#80807 guisaveas: never recommend system's tempdirJustin Luth
Various download-and-open mechanisms save to the system's $TEMP dir. If so, don't recomment saving in that same location in the GUI dialog! That's just silly. Change-Id: Ifa20fdfd81d768bbd893f92a50355f08c3aab356 Reviewed-on: https://gerrit.libreoffice.org/33353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit eb9f90186ae52efa7ff884b3e64f5dd59ddc0329)
2017-07-31update creditsChristian Lohmaier
Change-Id: I13b07b0a60fdb9fdf736431c6af87d2c2d123182 (cherry picked from commit b1fd54a408602126003ffd5032fb86e95b2744cb) (cherry picked from commit 8cfb5788cc602e0a81ae47832c65cf2402471034)
2017-07-31Resolves: tdf#106872 only request selected shapesCaolán McNamara
that way we can avoid the super slow code path for filtered rows when we only care about selected shapes Reviewed-on: https://gerrit.libreoffice.org/40496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 192d97cdf091af08a492416824918ea447bfb16f) Related: tdf#106872 factor out getting selected shapes (cherry picked from commit 221dae68df80298e81e6e6549636f3528f5c8bc3) Reviewed-on: https://gerrit.libreoffice.org/40519 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 5e2ffa0b2eb7623d0c9ed37c30caea1452810646) Change-Id: I175fa841e406dbbe7075296f2e0a0e79fa115fb7 765c482a41e9681a1eb145c1833cc94f35a27db3
2017-07-31ofz: survive missing macro supportCaolán McNamara
Change-Id: Ica9c66fe09f7340f76f62e536527dc63b3735d90 (cherry picked from commit aa529a1957fce324c500753039ae7766b8dcf6a6) Reviewed-on: https://gerrit.libreoffice.org/40523 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit a9a1306266e2fc67e8ac3029584d7a264fe37ff0)
2017-07-31don't jump back to selected slide on right click context menuCaolán McNamara
i.e. two many slides to fit in slide sorter panel, so scroll bar, select slide one, scroll to the end and right click between slides (or anywhere that isn't a slide) and without this fix the sorter jumps back to make the selected slide 1 visible. The right click menu will offer "new slide", choosing that will insert a slide at the point that was originally clicked, not at the point it was scrolled back to losing focus trigger a (dubious looking) callback to jump to the selected slide, so disable it while context menu is up Change-Id: Ie42bf158258cc38c9b7cfda7672f24d2ac8bfa11 Reviewed-on: https://gerrit.libreoffice.org/40383 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 5e0b0be9b34343070b422c8a1cef1671c51f5773)
2017-07-31ofz#2759 null dereferenceCaolán McNamara
(cherry picked from commit 6f5841e60ed29ae2577e63623edacc9fe1467ba5) Change-Id: I23671f0cea592c92a05b34b3cf284a47a73962b1 Reviewed-on: https://gerrit.libreoffice.org/40506 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 26222c3baca76eaed5f45dde4592a059e0e4a85d)
2017-07-31gtk3: Resolves: tdf#109277 take modifier key into account for dndCaolán McNamara
Change-Id: Id0aa4ced8644ddbee9e1a0453887f07907547aae (cherry picked from commit 0c840d9bf308464d58a2df8aaa1e61481b5e4f52) Reviewed-on: https://gerrit.libreoffice.org/40477 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 3cb369463e4e9d0a00baee3adf10957d1ed7ed83)
2017-07-31tdf#108867 sw: fix dangling text box frame format pointers in UndoMichael Stahl
If the text box is removed, the SwFrameFormat of the drawing shape still retains a pointer to the frame SwFrameFormat, and the latter is owned by the SwUndoFlyBase. This is pretty bad, so try to clear & reset the connection between them in SwUndoFlyBase::InsFly() and DelFly(). Hopefully nothing will actually delete the drawing shape SwFrameFormat while the Undo object is alive. Note that when the SwUndoInsLayFormat is created when the text box is added, the GetOtherTextBoxFormat() returns null as it's set later, that's why the constructor can't do anything. Change-Id: Iae562b6f8f272e47b2b5cf8ee80778db15d29ce0 (cherry picked from commit 2e486daff35ab16e810bfdafb24b19bcbf2fe8cd) Reviewed-on: https://gerrit.libreoffice.org/40283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit b39cb50c6afb47f39b21c3fb3ea913b902632924)
2017-07-31Resolves: tdf#109289 add SvxColorListBox::IsValueChangedFromSavedCaolán McNamara
and remove PushButton::IsValueChangedFromSaved (cherry picked from commit 39fd7e97c253153a10161ef3694b64e90e65e80a) Related: tdf#109289 move PushButton::IsValueChangedFromSaved to consumer inheriting the IsValueChangedFromSaved from PushButton has allowed undesirable behaviour to be selected (cherry picked from commit 247607727986df0fd0fef198459eb6646e056ea3) Change-Id: Ib1c51e27fd708c5d4811c90ef5659b4d55dd8860 fccb1657d2565005e6f9e239c6118f2e5ae7970c Reviewed-on: https://gerrit.libreoffice.org/40486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit d747a00f550cc8556e29b29b08c57f84afb4078f)
2017-07-31Related: tdf#106872 amount of a11y selection listeners constantly growsCaolán McNamara
so it gets progressively slower Change-Id: Ib53c69231c902d064b939be096e0dbeab2f0fc71 Reviewed-on: https://gerrit.libreoffice.org/40493 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 09716380e12ac2b7119afff20033ce2e7929ebd8)
2017-07-31tdf#99692 sw: fix bookmark positions in tables at start of redlinesMichael Stahl
The code assumes that if it can move the cursor backward in line 2038, that move can be "inverted" by moving the cursor forward after the content has been moved - but if the cursor moved back a node, and the moved content does not start with a SwTextNode, the cursor will move forward skipping over the non-text nodes, so offsets in the aSaveBkmks (and aSaveRedl, presumably) are going to be wrong. Just don't use Move() if it leaves the current node. Change-Id: I95278a10c14aeba9f76558486bb2712f6726dbcb (cherry picked from commit 850795942b3e168cab8ce88b4f2b421945ff29ca) Reviewed-on: https://gerrit.libreoffice.org/40419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit be2a7025e5b62e9dab73886436ee52d5330ae381)
2017-07-31fix image map item idsCaolán McNamara
broken since... commit 4bbf35572d94efe8b321e3159e9810f52bc3f9f8 Date: Mon Jul 7 11:24:48 2014 +0200 RID_SVXDLG_IMAP conversion to .ui Change-Id: Ic08b82af0b8890fb910153c87fb170618d95f34f Reviewed-on: https://gerrit.libreoffice.org/40407 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit a8f791ec013d9b703d12eb9f045e42d9b0e8bd1f)
2017-07-31tdf#97743: mediawiki accountJulien Nabet
To find main url in header section, search link containing: - load.php - or opensearch_desc.php In Wikipedia or wiki.documentfoundation.org, I haven't seen any link with index.php Change-Id: Iccb27aa8aaaf936faf8ec3b3f67eaa98d0426f19 Reviewed-on: https://gerrit.libreoffice.org/38631 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit e34b02834b24be4062ffd535aa1b929481ff427e) Reviewed-on: https://gerrit.libreoffice.org/38646 (cherry picked from commit c51e789b3a5b77b8bca03c3404699655b19ac80d)
2017-07-31tdf#109304: Seems infobar child window wasn't registered in MathKatarina Behrens
thus no signature status infobar appeared (I wonder if read-only bar ever worked too) Change-Id: I8829b2b6a17fb8d38e3ea79b87d544e3fb29f1c1 Reviewed-on: https://gerrit.libreoffice.org/40377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit a542fe8d38811dff152b69796380e1feec7daa28) Reviewed-on: https://gerrit.libreoffice.org/40387 (cherry picked from commit ef4f47e27477f32f022f3d5f93475a58dc06f5e1)
2017-07-31add libebook-1.2.so.19 in EApi.cxxRico Tzschichholz
Change-Id: I900a190948087360bb4c3cd9235c9848333ad66f Reviewed-on: https://gerrit.libreoffice.org/40358 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 5844d813411be8c4c7c394be07a49eaf92885758) Reviewed-on: https://gerrit.libreoffice.org/40362 (cherry picked from commit ffe568afd34be683430e6a31ca2368f957a4876d)
2017-07-31tdf#103984 : For bubble charts append data column...Dennis Francis
for "values-size" role too, after parsing in InternalDataProvider::createDataSequenceFromArray(). Without this, embedded bubble charts in documents(MSO) other than spreadsheets will be empty when imported. Also adds docx import chart2-unit-test in chart2import.cxx Change-Id: I63168074b30090a8b7cf977eb5af443f6b9ac240 Reviewed-on: https://gerrit.libreoffice.org/40258 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 0bdbd099bb52ae687196e06561e03c5c4d9c90eb) Reviewed-on: https://gerrit.libreoffice.org/40337 (cherry picked from commit 34845eca8a6965ef887f180baeffa3af2215c541)
2017-07-31update credits - with aliases fixedChristian Lohmaier
Change-Id: I486428da5459e758d23dd58b189b539896886c4c (cherry picked from commit c48f659a38af4da57cd1c978f17f2598de19156a) (cherry picked from commit ef1d2ab292ec912d4e17bc45ff3b42f59ee5b405)
2017-07-31update creditsChristian Lohmaier
Change-Id: I3d2a7bd97c085c68dc5036b6cb3731c24ed63aa2 (cherry picked from commit 8f338d85a576dcc636907ce036cb34559e9c7e36) (cherry picked from commit 4d26a07058deb514c8e6602261ddf94828c7f7cb)
2017-07-31Resolves: tdf#75650 reset boolean number format to General for new formulaEike Rathke
Change-Id: Iec2feefcbb5a92c64f182d93b4055fc009dbe1e5 (cherry picked from commit 1c1783864a356a4394f80dec28db939f4cf572cd) Reviewed-on: https://gerrit.libreoffice.org/40053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit c967cebeab0d5b343bd33d3a6f758aeaa40258f8)
2017-07-31Resolves: tdf#104186 spaces between function name and ( not allowed in OOXMLEike Rathke
(cherry picked from commit 7232980be6a4d67ed28a21b74ef3544cacb29d6a) Conflicts: formula/source/core/api/FormulaCompiler.cxx Backported. Change-Id: I6f6fcdab24a426d0f62052fa2d31f4098d1d893a Reviewed-on: https://gerrit.libreoffice.org/40086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 6ff7de9c93e280cfe54a0ed660595c98d052ab11)
2017-07-31Blind fix tdf#108612 explicitly checking for and against clipboard documentEike Rathke
This is a combination of 2 commits. Attempt to blind fix tdf#108612 explicitly checking for clipboard document It seems that for some yet unknown reason in an (un)certain constellation ScDocument::IsClipboardSource() returns true because ScModule::GetClipDoc() does not return the clipboard document but the actual document instead, so destroying the clipboard document executes ScDocument::ClosingClipboardSource() and (or in earlier versions) ScDocument::ForgetNoteCaptions() on the actual document instead. Check also that ScDocument::bIsClip is set, hopefully curing the symptom, the real cause is something else. (cherry picked from commit d5020f35aec54f0241fa58557dc6caadc149f5a9) Another attempt to blind fix tdf#108612 Oddly in that scenario on Windows there are two clipboard documents alive when destroying one, so the destroyed one erroneously is said to be a clipboard source and then detachs the comments' caption information. There's no legit case where a clipboard document could actually be the real original source of another clipboard document, so bail out if the caller already is one. (cherry picked from commit 52e09f2c03f7cc024b2973c4806283c324fc23df) 0f8d240d8ec13bf91b77176dc6439a541cf14eaa Change-Id: I5ffd0706592d2737808e7004630a56c53115295b Reviewed-on: https://gerrit.libreoffice.org/40251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit c5917736e39ff1e5d6995f93e9108082a87d9e35)
2017-07-31tdf#109080 First page header/footer ODF (1/2)Luke Deller
The proposal to add <style:header-first> / <style:footer-first> to the ODF standard has not yet been accepted, so meanwhile we should be using an extension namespace for these elements. This first commit (intended for backport) adds support for reading <loext:header-first> / <loext:footer-first> (cherry picked from commit bff8cd3d52223002263dcb8c09758c4fc753b6e3) Change-Id: I616b6a0acaead9d767ae7d119e539b865f3a6774 Reviewed-on: https://gerrit.libreoffice.org/40228 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 63274a5b0528e82faf7eed9cbc50badfdd1d3b55)
2017-07-31tdf#109188 Always load documents read-only in SwOneExampleFrameSamuel Mehrbrodt
Should be no problem since 38a3743e0c5d52f9386f74097fd512d3133fbbe3 Change-Id: I0ce47bc2bdaa900559a16baf25305066977caa6d Reviewed-on: https://gerrit.libreoffice.org/40140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/40213 (cherry picked from commit 14f9bb560cc1ebf588683bcf2297ab44cb8993eb)
2017-07-31tdf#107975: Revert "fix deleting an image anchored to last paragraphMichael Stahl
... in document" This reverts commit 2903d85d6197829633d7f96c95cd55821c2c20ff. It was a good idea, but is not complete. Change-Id: Ia0da2640889ce6e78b89b27c75fae9d6508afd40 (cherry picked from commit 14d2255cbd254dea6e87a04f747e7d6d3d54ceb9) Reviewed-on: https://gerrit.libreoffice.org/40191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 1450f9f56c2053a1584f2f1a9e40c54971b57edd)
2017-07-31sw: make SwGrfNode::mpReplacementGraphic swappableMichael Stahl
Same as previous commit, but for sw. (cherry picked from commit a03a0cfb1e41c357950a40623c2f8b6f5507e97d) loplugin:staticmethods (cherry picked from commit 3039b7cae36abb7e9bfffa4fbbba023721376568) Reviewed-on: https://gerrit.libreoffice.org/39968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 524377f1815773a678721c8ad179be9dbdaf7716) Reviewed-on: https://gerrit.libreoffice.org/40179 (cherry picked from commit 7d229d287ebc2ac961ee36ea048273dcc7ec405a) Change-Id: Id678de3f512204437e37aaedf24e24aff7a9e592
2017-07-31xmloff: ODF export: fix redundant setting of GraphicStreamURL swappingMichael Stahl
XMLShapeExport::ImpExportGraphicObjectShape() unnecessarily swaps out the GraphicObject by calling setPropertyValue("GraphicStreamURL") even if the URL didn't actually change from what was retrieved just a couple lines earlier, incidentally swapping it in too. Well actually it isn't really swapped out, it's marked as auto-swapped, but nevertheless on getting the "ReplacementGraphicURL" property its Graphic will be replaced by swapping it in again. So don't do that, then it's only swapped in once. This speeds up round-tripping the ML bugdoc from 3:20 to 3:00. Change-Id: I65a211a0c225444c06d5516df9c6716360be46c0 (cherry picked from commit b3992ddcd13082a934246b717ae22f57394e6533) Reviewed-on: https://gerrit.libreoffice.org/39966 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 753eb4b54c5ce2a1ce0f392505b5e18a1a10d905) Reviewed-on: https://gerrit.libreoffice.org/40177 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 953c801a678d8af180e27cf67b057136a55be60a)
2017-07-31svx: make SdrGrafObj::mpReplacementGraphic swappableMichael Stahl
These GraphicObjects clog up the GraphicManager cache so it's effectively useless. Round-tripping the ML bugdoc, this doesn't provide much of a speed-up by itself, but together with the previous fix it goes from 3:00 to 1:30 (in an optimized build). (cherry picked from commit c96e3e226fe4eb8f25c54cce4d653d12eda63ce2) Reviewed-on: https://gerrit.libreoffice.org/39967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit c60344481a60f77ff86e7e5f1f1e952f7ba76d90) Reviewed-on: https://gerrit.libreoffice.org/40178 (cherry picked from commit 142ab1c3e452109d2e5143d26abc6f13e904d7a7) Change-Id: If52e176c790b94ffef9984be53376a34345b06e3
2017-07-31tdf#104883 Don't call InstallFontconfigResources if it's not availableSamuel Mehrbrodt
We need to call it once because we have no other way to detect whether it's working or not. But if we receive an error the first time, we disable it from now on. Change-Id: I67dba8b65660ff7e05bdf2ddc18b565550901cd1 Reviewed-on: https://gerrit.libreoffice.org/39895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f86d9d732d9b2aa711d321a8c9f4110b638560b4)
2017-07-31don't use memset on structure with std::shared_ptr memberMarkus Mohrhard
Change-Id: Ie6033b9820435bb6a45aa70f9a48115000571e0f Reviewed-on: https://gerrit.libreoffice.org/40004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit c7fe625c8d41f648f89765abc40bb7b8fd4ed12a) Reviewed-on: https://gerrit.libreoffice.org/40011 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 5b9654f240b77448954c707e53adcdfccbdc74f4)
2017-07-31Resolves: tdf#93745 gtk3 spinbuttons are wider than available spaceCaolán McNamara
make dialog 40 pixels wider and allocate 20 extra pixels per spinbutton and shift labels accordingly Change-Id: Ic7e5dd662e01207abcbcbb9043f927eceb5b2bd0 Reviewed-on: https://gerrit.libreoffice.org/39905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit c1f7d3819387c442b3acb54b09091dd116f28d5e)
2017-07-31Windows build fix: ambigous symbolTamás Zolnai
Caused by: ae86557de53a8762924f18c78a556e2d6881002a These namespaces were removed from the cxx file, but not from the header. Change-Id: I5bae177638f0c9d404aac0fa4577689965ef5c26 Reviewed-on: https://gerrit.libreoffice.org/40585 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>