summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-09-14Add missing @since tagsSamuel Mehrbrodt
Change-Id: Ie4436986f847828cf1644325d692d64c344b03c5 Reviewed-on: https://gerrit.libreoffice.org/60482 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-14tdf#119841 Crash when pasting an HTML table from a web pageNoel Grandin
regression from commit 510033783a9921eef507d424fc5adf6e2696bc4a loplugin:useuniqueptr in ScHTMLLayoutParser Change-Id: If2c46552d8c784eb2ea1b182140fd731c39b1bd3 Reviewed-on: https://gerrit.libreoffice.org/60483 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14weld SvxCharNamePageCaolán McNamara
Change-Id: Ia54a5ac4fe4a11b7c03508c336193bb52c616e7f
2018-09-14Reduce variable scopeMichael Weghorn
Change-Id: Ia5016284c338f5d305d9f7fc92180a770230b446 Reviewed-on: https://gerrit.libreoffice.org/60479 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-09-14kde5backend.cxx: Fix inverted logic leading to invalid writeMichael Weghorn
Only write to 'pFakeArgv[2]' when 'aDisplay' is NON-empty. Otherwise, the 'pFakeArgv' array only has size 2 and the write is invalid. (Found by valgrind while looking at another issue.) Change-Id: I58aff6d25c8647bc6ef346af8ac09b0b0fc030b8 Reviewed-on: https://gerrit.libreoffice.org/60476 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-09-14loplugin:constfields in vclNoel Grandin
Change-Id: I1072642be4fdfa720e61f2d7bad3c2701eb81610 Reviewed-on: https://gerrit.libreoffice.org/60430 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14loplugin:useuniqueptr in SwSubFont::DoOnCapitalsNoel Grandin
Change-Id: Ib5a02c71fa66f46a8e1072c5c0a263e1eb977692 Reviewed-on: https://gerrit.libreoffice.org/60454 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14loplugin:useuniqueptr in SwTextPortion::CreateHyphenNoel Grandin
Change-Id: I9ab88f5d15a2d98285ac4c1ffce8750c16830d56 Reviewed-on: https://gerrit.libreoffice.org/60453 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14make WinFontInstance take and return a WinFontFaceNoel Grandin
to make the handling more explicit here Change-Id: I934fcc7b0da8a160acd904440f18fc6c01ec1ad3 Reviewed-on: https://gerrit.libreoffice.org/60475 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14loplugin:useuniqueptr in SwTable::OldSplitRowNoel Grandin
Change-Id: Ie01de0c9463b9a1012d4b1adc9e92e8f8b1d8a58 Reviewed-on: https://gerrit.libreoffice.org/60447 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14Improve loplugin:simplifyconstruct warningsStephan Bergmann
Change-Id: I0a64d0eb9938d5a99416dbe4078ba4c05e5d588b Reviewed-on: https://gerrit.libreoffice.org/60465 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-14tdf#119848 DOCX export: keep tracked deleted empty lineLászló Németh
when it has no other paragraph property change. Change-Id: I4e18c89f1a4c7f39a7e55303956b85f61c9d5105 Reviewed-on: https://gerrit.libreoffice.org/60442 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-09-14loplugin:useuniqueptr in SwXDrawPage::addNoel Grandin
Change-Id: If929ee4725f65d8695367f38b5203be3a7e426d1 Reviewed-on: https://gerrit.libreoffice.org/60457 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14loplugin:useuniqueptr in SwTextNode::MakeNewTextNodeNoel Grandin
Change-Id: I524375af95b988e53838b87c00be5fbaf2895a84 Reviewed-on: https://gerrit.libreoffice.org/60456 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14loplugin:useuniqueptr in SwTextSizeInfo::GetMultiCreatorNoel Grandin
Change-Id: I5cc13b33f46eee9a770049c1127e5de47fecea84 Reviewed-on: https://gerrit.libreoffice.org/60455 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14loplugin:useuniqueptr in SwHolePortion::PaintNoel Grandin
Change-Id: I068c83db5a3f5e717c72e4f2459a18eee690bbfd Reviewed-on: https://gerrit.libreoffice.org/60452 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14loplugin:useuniqueptr in SwTextFrame::EmptyHeightNoel Grandin
Change-Id: I76647a9441fee2f4d2d338a70f9bf95e80fa18ee Reviewed-on: https://gerrit.libreoffice.org/60451 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14loplugin:useuniqueptr in SwTextFrameNoel Grandin
Change-Id: I34fac0560a1a408df421365379b15e64c96c9a15 Reviewed-on: https://gerrit.libreoffice.org/60450 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14Remove MSVC workaround from 2002Stephan Bergmann
...introduced with fec05c3deabec6299eec87fa481b7e50b6fb29f5 "#90279# performance: DoSubTotals: collect formula cell positions and put cells after InsertRow calls to not have them inspected for updates again" and hopefully no longer necessary Change-Id: I2cd781c81defb3838612d460e8234fd4de97b88d Reviewed-on: https://gerrit.libreoffice.org/60459 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-14loplugin:simplifyconstruct (make screenshot)Stephan Bergmann
Change-Id: Ia888dba63ee6917bd5726e92a8e248b63f744047 Reviewed-on: https://gerrit.libreoffice.org/60467 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-14tdf#82177 docx export: eliminate invalid tbl insideV/H bordersJustin Luth
Inherited from OOo, these insideV/H borders incorrectly assume that every inside border will match the bottom/right border of cell A1. For the most part this error is harmless since every cell specifies every border anyway (that doesn't match a table-style default). The only time it is visible is when insideV/H specifies a border, but none is set on the cell. The problem is that these pseudo-defaults are not passed to the cellborders function as defaults, so cells have no idea whether they need to override these values or not. Since the implementation is completely flawed and unnecessary, simply eliminate it. (TODO: In fact, the entire tblBorders output is flawed, as demonstrated by the outside borders in the unit test.) One unit test is removed since insideV/H is no longer being written (this was just a "lets specify what we see being written out" test, not one concerned specifically with insideV/H. Not enforcing the absence of insideV/H because theoretically someone could legitimately add zero-width borders to the table borders and still be valid. The ordering of the borders test was moved from a table borders test (no longer created) to a styles border (which is still valid - a grabbag dump.) Change-Id: Ie6786a66fe88d2c7e3bdcff8fda3b4f77cb988d7 Reviewed-on: https://gerrit.libreoffice.org/59675 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-14oox: create QuickDiagrammingImport instances with an uno constructorMiklos Vajna
This is effectively dead code as commit 547217ecf2348cf511b1f058ecbab6f15f2bceff (Document seemingly dead QuickDiagrammingImport, QuickDiagrammingLayout, 2013-06-03) found, so the primary motivation is to just get this out of oox_component_getFactory(). Change-Id: If0a585c2fc4b87ceb00e6f772fef2ac65d10dc67 Reviewed-on: https://gerrit.libreoffice.org/60470 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-14loplugin:useuniqueptr in SwImpBlocks::MakePaMNoel Grandin
Change-Id: Icba921c1875592df7d120c9cc4866184cea74b92 Reviewed-on: https://gerrit.libreoffice.org/60449 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14loplugin:useuniqueptr in SwFrame::PaintSwFrameBackgroundNoel Grandin
Change-Id: I351ebf8ece7e6c298bfd352d308bb811029ea266 Reviewed-on: https://gerrit.libreoffice.org/60448 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14loplugin:useuniqueptr in SwDoc::CopyPageDescHeaderFooterImplNoel Grandin
Change-Id: I14841e14272878d0a17f58b001df9bf1c937f0f2 Reviewed-on: https://gerrit.libreoffice.org/60446 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14loplugin:useuniqueptr in DocumentContentOperationsManager::MoveNodeRangeNoel Grandin
Change-Id: I2e32dba4ad9770ed62dbf74769ee00c05235bd40 Reviewed-on: https://gerrit.libreoffice.org/60445 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-14tdf#108064 OOXML export: fixing linestyle export in chartsAdam Kovacs
getLineDash function copy paste from ChartLinePanel.cxx. We query the actual linedash value associated to the LineDashName of the chart line via DashTable service. Thanks for the guidance of László Németh! Change-Id: I565fc968ce009803f9872da1f01dd56cfe07ddb3 Reviewed-on: https://gerrit.libreoffice.org/60424 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-09-14These rtl_hash* functions appear to never have been exported from salStephan Bergmann
They were introduced with 9399c662f36c385b0c705eb34e636a9aec450282 "initial import" without any trace of being exported DLLPUBLIC-style, and were probably included in error in the initial sal/util/sal.map when that was introduced in 92b0714c409bd3cffcefd338371ee000fa1b5805 "new". That means the functions themselves can be moved from extern "C" to an unnamed namespace (and the resulting loplugin:salbool warnings be fixed). Change-Id: Ida99540edce9560e69081f507e41db2af34966fb Reviewed-on: https://gerrit.libreoffice.org/60469 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-14loplugin:simplifyconstruct (macOS)Stephan Bergmann
Change-Id: I460732b2ea9e7366943162bef8f4fced5f975e95 Reviewed-on: https://gerrit.libreoffice.org/60466 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-14Remove redundant declarationStephan Bergmann
...where the documentation for the declaration and the definition curiously differed ever since 84a3db80b4fd66c6854b3135b5f69b61fd828e62 "initial import" Change-Id: I53add6ee84f392c321de5aefa21d528165cc8187 Reviewed-on: https://gerrit.libreoffice.org/60458 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-14Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I9edeef1f74414dd5d7dcf75c24934d8ba1f274bf Reviewed-on: https://gerrit.libreoffice.org/60473 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-14Fix warning out-of-range value from the DatasourceType selectionJulien Nabet
Fix warn:dbaccess.ui.generalpage:19437:19437:dbaccess/source/ui/dlg/generalpage.cxx:405: Got out-of-range value '2147483647' from the DatasourceType selection ListBox's GetSelectedEntryPos(): no corresponding URL prefix Just Launch Base and select "Open an existing database file" and see this log If there's nothing to display, we get 2147483647 which corresponds to LISTBOX_ENTRY_NOTFOUND Change-Id: Iaab680695d9816c6375d9ef04f02845890f99dda Reviewed-on: https://gerrit.libreoffice.org/60464 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2018-09-14Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' - More tag vomit cleanup, plus a menu path fix Change-Id: Id7ae7c637c0d74d228fb88ca5e55deaafb9ea140
2018-09-13tdf#118881: Fix HTML parsing for personasMuhammet Kara
This is just a band-aid to make personas feature work again. Change-Id: I80b54fe9a8ddc93d93744fcf2c7f739d81f6face Reviewed-on: https://gerrit.libreoffice.org/60432 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-09-13mysqlc: fix XPreparedStatement::setTimestampTamas Bunth
Change-Id: Ia0d0290517fdebd9a7700d52fa0e86de0e958b2d Reviewed-on: https://gerrit.libreoffice.org/60406 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-09-13mysqlc: prep stmt: check if cursor out of rangeTamas Bunth
Change-Id: I81307c6e45220081c39ddd7d1672457202bbc517 Reviewed-on: https://gerrit.libreoffice.org/60404 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-09-13Make use of special operator == explicitStephan Bergmann
Change-Id: I6449da3ef928a5a92a4197f5c2228e55253e43c3 Reviewed-on: https://gerrit.libreoffice.org/60431 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-13sw: move frame id SwFrame to SwFrameAreaDefinitionMiklos Vajna
Otherwise it's not easy to see which frame position was invalidated in SwFrameAreaDefinition::setFrameAreaPositionValid() in a SAL_DEBUG() statement. Change-Id: I5771a81b98524bbce6557653a1a366e7a91c583e Reviewed-on: https://gerrit.libreoffice.org/60443 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-13add GetDialogExampleSet rather than guess at itCaolán McNamara
Change-Id: I8d7fc780c77e7f410ce78eb07bcb92dcd71f6c13 Reviewed-on: https://gerrit.libreoffice.org/60434 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-13must call enterpage handler if we do enter a pageCaolán McNamara
Change-Id: I2eb6949a22de038d8e501bc8ade57e6ebc053d34 Reviewed-on: https://gerrit.libreoffice.org/60433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-13More temp copies of test docs in Python/UITestsStephan Bergmann
...similar to d76281864b0e83812c0edf7490b1e8271e89fff5 "Create temp copies of test docs in Python/UITests", which only fixed those places that were broken with a read-only SRCDIR. However, I now ran into a deadlock on Linux (where UITests are run with SAL_USE_VCLPLUGIN=svp) that suggests that /all/ documents from SRCDIR that are opened by those tests should better first be copied to WORKDIR sub-dirs (that are removed prior to running tests, so stale lock files cannot exists). This commit addresses just a small part of all those tests, though. I had cancelled (ctrl-c) a `make check` midway, when it happened to be in the middle of UITest_calc_tests2 and left beind a sc/qa/uitest/calc_tests/data/.~lock.stableSorting.ods# lock file (which records, among other things, the host name). I then dropped off a VPN, which caused the host name as seen by LO to switch from "alpha" to "alpha.fritz.box", then re- started the build as `make check screenshot` (which was the thing I'd originally intended, but forgotten the screenshot target). The new built hung during UITest_calc_tests2's sc/qa/uitest/calc_tests2/stableSorting.py, as loading sc/qa/uitest/calc_tests/data/stableSorting.ods found the lock file with non- matching host name in SfxMedium::LockOrigFileOnDemand, and hung in SfxMedium::ShowLockedDocumentDialog -> UUIInteractionHandler::handle -> (switch to main thread...) -> UUIInteractionHelper::handleLockedDocumentRequest -> ... -> Dialog::Execute, which just blocks in svp mode (which, unlike --headless, doesn't cause Application::IsDialogCancelEnabled). Change-Id: I999af50d6b1e5012d3978f5e476bcbfc9be6fd1d Reviewed-on: https://gerrit.libreoffice.org/60439 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-13vcl: revert verbose WNT font loggingMichael Stahl
Revert 656bef6ce3626769bd59fc7c46d781af512dfe0e to use SAL_INFO again, as there are few if any font related test failures now. Change-Id: If91908b93394790eb5d0615508e1f64f83f2f9c6 Reviewed-on: https://gerrit.libreoffice.org/60438 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-13mysqlc: Fix XResultSet::absolute and previousTamas Bunth
We need to update the actual row position after using absolute or previous. Change-Id: Ie85f9679b7a06649a88ac8ee08436bf7f4a58a22 Reviewed-on: https://gerrit.libreoffice.org/60328 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-09-13loplugin:constfields in writerfilterNoel Grandin
Change-Id: Ibe380e1fb35d9defc478d459a988f9f6df13bf35 Reviewed-on: https://gerrit.libreoffice.org/60427 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-13Fix typosAndrea Gelmini
Change-Id: I4cea59a00029af5cdbd75ab12476d7b0c08419c0 Reviewed-on: https://gerrit.libreoffice.org/60428 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-13Fix typosAndrea Gelmini
Change-Id: I1ee620200a285936159fed57d0cbbf5320e7d3ec Reviewed-on: https://gerrit.libreoffice.org/60429 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-13fix typoAndrea Gelmini
Change-Id: Ic06c2cc3fa9fee3ae81b71ac011cac53a6893e0e Reviewed-on: https://gerrit.libreoffice.org/60437 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-09-13loplugin:constfields in xmlhelpNoel Grandin
Change-Id: Ia8eda3075b0387ec3a5ed6267f1dfcfb3a8cf782 Reviewed-on: https://gerrit.libreoffice.org/60426 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-13loplugin:simplifyconstruct exclude std::unique_ptr with custom deleterNoel Grandin
Change-Id: I8f4ba883747a2aace88786ef807fd7c338bef5da
2018-09-13crashtesting: divide by zeroCaolán McNamara
since... commit f3d6c44c9cb533fe4f1cd28fc95adc36cac4bfd5 Date: Mon Sep 3 11:05:44 2018 -0400 tdf#108064 OOXML export: keep preset dashes with any line width Change-Id: I948123977f48d1f1005788f6a2c117e8971cab6f Reviewed-on: https://gerrit.libreoffice.org/60423 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-10 21:54:41 +0000