summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-03-16remove some GraphicObject URL funct. from GraphicImportHelperTomaž Vajngerl
GraphicImportHelper is an implementation of XGraphicObjectResolver which is mostly used to "resolve" a GraphicObject URL to the internal storage URL (and save the graphic to the storage in the process). Most of the GraphicObject URL functionality was removed so the required overrides from XGraphicObjectResolver interface now return an empty result or do nothing. Change-Id: Iee6bb71b15411d03ef82ab4d20d234ff0e834425 Reviewed-on: https://gerrit.libreoffice.org/51331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-16tdf#116213 OS X and OpenGL bitmap scaline sizes are not 32-bit alignedChris Sherlock
Change-Id: I92b43ae2f034bf63cc3f212ec8728c5c6b5e8934 Reviewed-on: https://gerrit.libreoffice.org/51222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-16iOS, added description of __cxa_throwjan Iversen
Change-Id: I6a537957528a0d2de989b347bde1167e21544236
2018-03-16tdf#104789 Export opacity attribute nameSzymon Kłos
Change-Id: Id47ab6b3cb20fbcebb2d7fa589f3b0d7552e2cce Reviewed-on: https://gerrit.libreoffice.org/51369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-16tdf#104786 Don't export empty 'to'Szymon Kłos
Change-Id: I16b573fd6455813c6be5c2f5a0f0a820360a239f Reviewed-on: https://gerrit.libreoffice.org/51359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-16tdf#90627 Don't save empty conditionsSzymon Kłos
Change-Id: I5a953c1b0fff7bf41a59360a8f52596264ddf266 Reviewed-on: https://gerrit.libreoffice.org/51293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-16Fix typosAndrea Gelmini
Change-Id: If70b03cad4c46010a59cf3bee139e801230fa3aa Reviewed-on: https://gerrit.libreoffice.org/51385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-16Revert "sd lok: Set the view size to full page size and hide ruler, scrollbars"pranavk
Pushed by mistake. Let's revert until tests passes This reverts commit 1354bafdc707b87f8db1e89c96382c4f4f460554. Change-Id: I4a8973f4e22332115143319a264fefa68e343dcc Reviewed-on: https://gerrit.libreoffice.org/51386 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-03-16sd lok: Set the view size to full page size and hide ruler, scrollbarsPranav Kant
... such that during insertion of objects when sd calculates the center of the view to place the object, it is the center of the whole slide, not the center of the default rectangle of 800x600. It's also important to hide rulers, scrollbars so that correct center is calculated; we don't need them anyways in LOK. Change-Id: I1180541c1b8c8a35f39112ca0a670c9d96d1320b Reviewed-on: https://gerrit.libreoffice.org/51347 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-03-16lokdialog: Invalidate upon window size changePranav Kant
This problem can be seen with some of the dialogs like chart dialogs where not all of the area which should be invalidated is invalidated. The reason being that their container gets resized but not lok-invalidated. Change-Id: I12eb68e8644ca67b2666badb7b772b92a145c624 Reviewed-on: https://gerrit.libreoffice.org/51264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-16loplugin:useuniqueptr in SwAccessibleTableNoel Grandin
Change-Id: Ife93c2bb6c0d064946dc760b8cbc6133b9e97c62 Reviewed-on: https://gerrit.libreoffice.org/51371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16loplugin:useuniqueptr in SwBlockCursorNoel Grandin
Change-Id: I3c3b9969ea26bd378a25a3c58e4710a5538889fb Reviewed-on: https://gerrit.libreoffice.org/51373 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16chart2 lok: give parent to data table dialog to tunnel itPranav Kant
Change-Id: Ie82a9a6d9b499e5da34e04f0c2f5fc7c164b098e Reviewed-on: https://gerrit.libreoffice.org/51346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-16use more TypedWhichId in sfxsidsNoel Grandin
Change-Id: I136427319ce2f1117501517efec2f03019bbf71e Reviewed-on: https://gerrit.libreoffice.org/51339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16loplugin:useuniqueptr in SmCategoryDescNoel Grandin
Change-Id: I4a6be3c84fb7c64b5f72499e5393e44f02514201 Reviewed-on: https://gerrit.libreoffice.org/51334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16solenv: sort the clang-format blacklistChris Sherlock
LC_ALL=C sort solenv/clang-format/blacklist > ~/blacklist mv ~/blacklist solenv/clang-format/blacklist Change-Id: Id00c5dc912220c6af6b1334e833abef4a0889ee0 Reviewed-on: https://gerrit.libreoffice.org/51349 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-16Modernize a bit filter (part2)Julien Nabet
mainly by using for-range loops + some algo simplifications Change-Id: I25b02676527d551985434e07e7dc5f2927d4955e Reviewed-on: https://gerrit.libreoffice.org/51377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-16tdf#112118: DOC: properly import/export border distanceMike Kaganski
DOCX part was done in fb959e581c900b392efd0bb329b7cf30c8ed56a5. This commit fixes DOC part. Line width wasn't taken into account on import; and export was done only with "from text" distance, which gave poor interoperability with Word, where the borders were close to page edge. The common code is moved to editeng/source/items/frmitems.cxx and include/editeng/boxitem.hxx. Change-Id: I3d1d1312cb9dc9a9e00d9847ec11234cd787df60 Reviewed-on: https://gerrit.libreoffice.org/51366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-16Clip BColor lightness value at 1.0Stephan Bergmann
UBSan build started to fail CppunitTest_sw_ooxmlexport8 with > /include/tools/color.hxx:59:27: runtime error: value 258.5 is outside the range of representable values of type 'unsigned char' > #0 0x2ad219182418 in Color::Color(basegfx::BColor const&) /include/tools/color.hxx:59:27 > #1 0x2ad219175e48 in (anonymous namespace)::lcl_compute3DColor(Color, int, int, int) /editeng/source/items/borderline.cxx:50:16 > #2 0x2ad219175574 in editeng::SvxBorderLine::threeDLightColor(Color) /editeng/source/items/borderline.cxx:77:12 > #3 0x2ad21917ea78 in editeng::SvxBorderLine::GetColorOut(bool) const /editeng/source/items/borderline.cxx:573:23 where lcl_compute3DColor had been called with (aMain=rgba(255, 255, 255, 255), nLight=3, nMedium=40, nDark=83) Change-Id: I0f4569d9fd9f54164efe395960bcc8a6840e7744 Reviewed-on: https://gerrit.libreoffice.org/51351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-16XGraphicObject: remove construct. with uniqueIDTomaž Vajngerl
Also make getUniqueID return empty string. Change-Id: I200a1facf088a205302991e5c26fe93adec55a87 Reviewed-on: https://gerrit.libreoffice.org/51330 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-16more robust method to load a Graphic from URL, +clean upTomaž Vajngerl
Change-Id: Ib7fb107a56a3cc9fffb6cfaa9bbc2117434902df Reviewed-on: https://gerrit.libreoffice.org/51329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-16weld SvxObjectNameDialogCaolán McNamara
Change-Id: I588bdc61cce9a7b4e709fcac612b229c02e734c0 Reviewed-on: https://gerrit.libreoffice.org/51375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16drop support for GraphicObject URLs in toolkitTomaž Vajngerl
Change-Id: I86d18232b8fcb34272d3cc04f65a7dc72248591a Reviewed-on: https://gerrit.libreoffice.org/51328 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-16crashtesting: asserts on legal xml names on exportCaolán McNamara
e.g. ooo82358-1.odt which has Chinese characters used in tags inside a parent xforms:instance tag Change-Id: If2edf9cc13e5a4cc969f5a46618a6534c52f2877 Reviewed-on: https://gerrit.libreoffice.org/51352 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-15loplugin:unused-returns in scNoel Grandin
Change-Id: Ic1d6cbf883fcfeb013c3a82d31c177a1a14bb7c8 Reviewed-on: https://gerrit.libreoffice.org/48193 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-15Check return of ScFlatBoolRowSegments::ForwardIterator::getValue()Eike Rathke
And if it is only an assert() where code (probably rightly) assumed there is a value.. if there wasn't then we'll have to handle it. Change-Id: Icbdb4a7727ca4cf8a6372c03e02d3bffa6156b6c Reviewed-on: https://gerrit.libreoffice.org/51374 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-15filedialog: use isGraphicObjectUniqueIdURL instead of constantTomaž Vajngerl
Change-Id: I54f5a1dae10219b3d6f06640488eded7f6840767 Reviewed-on: https://gerrit.libreoffice.org/51327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-15forms: Don't create a GraphicObject URL if we have xGraphic anywayTomaž Vajngerl
Change-Id: Ia80df77372ed08abc4ff816515c216c26d8330b4 Reviewed-on: https://gerrit.libreoffice.org/51326 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-15ofz#6827 Bad-castCaolán McNamara
Change-Id: I856d781f122c21c02a0a8cd01369d49f50b8a555 Reviewed-on: https://gerrit.libreoffice.org/51363 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-15weld sort dialogCaolán McNamara
rework huge language listbox into a combobox see https://gitlab.gnome.org/GNOME/gtk/issues/94 and the lack of typeahead/search for lists Change-Id: I4a3af695d86bbcb92e5cdd500c4acb7cfaf37f41 Reviewed-on: https://gerrit.libreoffice.org/51340 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-15sw: tweak sanity check in SwFrame::GetNextSctLeaf()Michael Stahl
An additional way in which column sections are a special case is if "this" is the SwBodyFrame inside the SwColumnFrame; handle this too. Happens in ooo31607-2.sxw. Change-Id: Id07b76e67c34b2335f2802f52e215d37476b3446
2018-03-15move swffilter use of BitmapEx::GetAlpha inside vclNoel Grandin
Change-Id: I22f489a26b8566ddc00c0c77f95127adb8eb2489 Reviewed-on: https://gerrit.libreoffice.org/51324 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-15Fix typosAndrea Gelmini
Change-Id: Icb2d5f8bb9eb781d6a59384e1aac75abf6145774 Reviewed-on: https://gerrit.libreoffice.org/51337 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-15iOS, move assembler constants to C++jan Iversen
Change-Id: Iad94a2e2e55bb158d2ac42e3a67a6d94f84ffedd
2018-03-15iOS, simplified bridge assembler code.jan Iversen
Use x14 and x15 as function and offset instead of having x15 as a pointer to 2 words. Change-Id: I1cb3af4e86e3abe1b56fba2509eda31af0435885
2018-03-15Use return value of ScTable::GetDataEntries()Eike Rathke
It's unnecessary to insert an empty set and sort it.. Change-Id: I01b7ce926747083dc9b5a82304c8ab182cd5a1bd
2018-03-15tdf#97977 related : make MODE.SNGL comply with Excel.Winfried Donkers
MODE.SNGL is to return the first occurrence of the number that has the most occurences in the array of numbers in case of multiple numbers having the same amount of (maximum) occurrences. Change-Id: If76115ddc6b84367cbcb75de611f29076a538476 Reviewed-on: https://gerrit.libreoffice.org/50593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-15tdf#115675: Shape selection was breaking when changing pos/size from sidebar.Jan Holesovsky
Fixes also other potential breakages with the same root cause. Change-Id: I09b3650189f6edb28ab64652cd411b1dca7dca89 Reviewed-on: https://gerrit.libreoffice.org/51342 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-03-15tdf#50916 Refactor of the table7.cxx to allow dynamic column sizeBartosz Kosiorek
Change-Id: I60ea249ca621e25b3585e1d2f75bdf15d96f6dcc Reviewed-on: https://gerrit.libreoffice.org/48205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-15tdf#115573 Revert: tdf#107555 Apply 'Default Style' table styleJim Raykowski
...to newly inserted tables Revert due to tables with autoformat style not able to persist direct formatting. Change-Id: Ic33033235b9f5bfba15ec74fa88e94da2dc21b69 Reviewed-on: https://gerrit.libreoffice.org/51253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-15tdf#116072 Add PrefixLetter ")" in Hungarian word breakingLászló Németh
to handle bad word breaking of ")-ban", ")-ben" after reference fields. (Field content is not expanded for spell checking, resulting red underlined "ban" and "ben" in the correct form "a)-ban", "b)-ben" etc., see the test file of the issue.) Change-Id: Ic4b1fd2c99bdd2509d85dd6f2aa43e2a53becaa7 Reviewed-on: https://gerrit.libreoffice.org/51284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2018-03-15tdf#112448: Fix: take correct line heightSerge Krot
When line metrics is not calculated we need to call CalcRealHeight() before usage of the Height() and GetRealHeight(). Change-Id: I104bbb81ea9d7130dfd728f7114d02e3672afbc3 Reviewed-on: https://gerrit.libreoffice.org/51319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-15tdf#115453 Remove Master Handout tab from Views Tab BarÁlex Puchades
The Views Tab Bar has had five tabs until now (Normal, Outline, Notes, Slide Sorter and Master Handout). Before this commit, selecting the Master Handout tab and then going back to the Normal or Notes tab showed the Slide/Notes Master instead of the expected behaviour. This commit removes the Master Handout Tab from the Views Tab Bar, with master views remaining accessible through the View Menu. Change-Id: I017af5f29d154386e4f0910151c478956aa0985f Reviewed-on: https://gerrit.libreoffice.org/51320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-15--without-lxml for Flatpak buildsStephan Bergmann
where the Yocto-based GNOME SDK provides no python lxml, but building LO's internal one fails because it internally uses {xml2,xslt}-config, and those are broken by (mis?-)design in Yocto, just returning with exit code 1. It didn't work well to pass applications of pkg-config into the external/lxml build as replacements for --with-{xml2,xslt}-config (as is successfully done elsewhere with 1462b2784fa3e95499808b2ef706e4787a01aaae "Adapt the external/redland/raptor/xml2-config.patch to raptor2-2.0.15"), so just run gla11y in its slightly limited form without lxml in the Flatpak build. Change-Id: I2d42901373c8c861b16da385c37bcc24d6e783fd Reviewed-on: https://gerrit.libreoffice.org/51321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-15loplugin:useuniqueptr in SdModuleNoel Grandin
Change-Id: I3b79696f06b33703cf61b73867014e4fd86ee9c7 Reviewed-on: https://gerrit.libreoffice.org/51313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-15Updated coreOlivier Hallot
Project: help dd03b7ecde2abb961790a69f99aeec9e3fbd653e Help pages typos and other fixes from translators Change-Id: If85b1749001b95cad904bae379362e36f96001d1 Reviewed-on: https://gerrit.libreoffice.org/51325 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-03-15Updated coreOlivier Hallot
Project: help 71c51c931a99039b3bd4944dbce56ee53be29867 tdf#99483 Clarify Calc paste operation Clarify the role of Ctrl + V and Enter key when pasting in Calc. Change-Id: I78366068edc82c4d948e5303d096eea7c5722fa8 Reviewed-on: https://gerrit.libreoffice.org/51301 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-03-15iOS, solved corrupted stack in cpp -> unojan Iversen
Solved problem in assembler code, so the call chain is correct. There are still something missing for uno to work correctly Change-Id: Ieb3b3d6b15153576159e07b52ced0efedd135713
2018-03-15move Bitmap::ScopedWriteAccess inside vclNoel Grandin
would have liked to make the AcquireWriteAccess methods DLLPRIVATE, but they are needed by the workbench and testing code Change-Id: I22497788eb68dfb84b7e542e5ef53322892a5274 Reviewed-on: https://gerrit.libreoffice.org/51310 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-15Adapt solenv/flatpak-manifest.in to recent download.lst changesStephan Bergmann
Change-Id: Id9a41e528e45d60a5429be4c51d58badff200fba