summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-11-09Colibre icons: add icons for context menuesandreas kainz
Change-Id: I22cbbafb0ed4fe361d88aa791adfdc9c7fe0fca4 Reviewed-on: https://gerrit.libreoffice.org/63140 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-09Fix typosAndrea Gelmini
Change-Id: I4beaec7bf6b023a73be464a8c38b0701ff3ae1b1 Reviewed-on: https://gerrit.libreoffice.org/63116 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-09lok: sc: make hi-dpi/zoom compatible with retrieving cell cursorMarco Cecchetti
A bit different approach than trying to handle different zoom levels at the samet time: instead, always handle the spreadsheet at 100%, but use cairo to scale to the actual zoom level. Change-Id: I318aec8fa4baaab2ee1f271223b2e10e26d41fcf Reviewed-on: https://gerrit.libreoffice.org/63040 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-11-09loplugin:useuniqueptr extend to checking more local var deletesNoel Grandin
Change-Id: I5da0f6ecd2577e92e679ed26dd42629dbac4afd4 Reviewed-on: https://gerrit.libreoffice.org/63132 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-09loplugin:useuniqueptr in ScHeaderFieldsObjNoel Grandin
Change-Id: I7d9855a45ebfb5bc185e964d4437ab0c9c2deff4 Reviewed-on: https://gerrit.libreoffice.org/63131 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-09fix bug in listbox height calc in ExtensionBox_ImplNoel Grandin
found by loplugin:singlevalfields Change-Id: Ide29da9222c8323e87fe640bd3548306c1778919 Reviewed-on: https://gerrit.libreoffice.org/63125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-09loplugin:useuniqueptr in ResultSetForQueryNoel Grandin
Change-Id: Ie375f7fded2592cd1e926f14be0216608c2695d6 Reviewed-on: https://gerrit.libreoffice.org/63130 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-09loplugin:useuniqueptr in SwDoc::GetRowHeight and GetRowSplitNoel Grandin
fixing a memory leak in the process Change-Id: I1b168159a8aa23e392768c49127f42b72e1ce3b3 Reviewed-on: https://gerrit.libreoffice.org/63128 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-09KJ: Yet another improvementRizal Muttaqin
Change-Id: If524e701ab295c83b485376fd4139540d3f28d7c Reviewed-on: https://gerrit.libreoffice.org/63085 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2018-11-08Don't set too-large size for SdrPageStephan Bergmann
...(from which ScDrawPage is derived). SdrPage::mnWidth/Height have been signed 32-bit ever since at least b97a3f93c3794174b22b25181dd858ab75e4c28e "INTEGRATION: CWS hedaburemove01" (INT32 nWdt/nHgt back then). With (new-in-Clang) -fsanitize=implicit-signed-integer-truncation, this cause failure during CppunitTest_desktop_lib: > svx/source/svdraw/svdpage.cxx:1215:19: runtime error: implicit conversion from type 'long' of value 9223372036854775807 (64-bit, signed) to type 'sal_Int32' (aka 'int') changed the value to -1 (32-bit, signed) > #0 in SdrPage::SetSize(Size const&) at svx/source/svdraw/svdpage.cxx:1215:19 (instdir/program/libsvxcorelo.so +0x4aede6f) > #1 in ScDrawPage::ScDrawPage(ScDrawLayer&, bool) at sc/source/core/data/drawpage.cxx:30:5 (instdir/program/libsclo.so +0x9addca3) > #2 in ScDrawLayer::AllocPage(bool) at sc/source/core/data/drwlayer.cxx:369:16 (instdir/program/libsclo.so +0x9aee60d) > #3 in ScDrawLayer::ScAddPage(short) at sc/source/core/data/drwlayer.cxx:397:50 (instdir/program/libsclo.so +0x9aeeea7) > #4 in ScDocument::InitDrawLayer(SfxObjectShell*) at sc/source/core/data/documen9.cxx:155:26 (instdir/program/libsclo.so +0x91fd6d0) > #5 in ScDocShell::MakeDrawLayer() at sc/source/ui/docshell/docsh2.cxx:175:21 (instdir/program/libsclo.so +0xcd0d25e) > #6 in ScTabView::MakeDrawLayer() at sc/source/ui/view/tabview2.cxx:1400:34 (instdir/program/libsclo.so +0xed70dda) > #7 in ScTabViewShell::ScTabViewShell(SfxViewFrame*, SfxViewShell*) at sc/source/ui/view/tabvwsh4.cxx:1702:5 (instdir/program/libsclo.so +0xee61296) > #8 in ScTabViewShell::CreateInstance(SfxViewFrame*, SfxViewShell*) at sc/source/ui/view/tabvwsh.cxx:106:1 (instdir/program/libsclo.so +0xee060a0) > #9 in SfxViewFactory::CreateInstance(SfxViewFrame*, SfxViewShell*) at sfx2/source/view/viewfac.cxx:28:12 (instdir/program/libsfxlo.so +0x419481e) > #10 in SfxBaseModel::createViewController(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/doc/sfxbasemodel.cxx:4089:46 (instdir/program/libsfxlo.so +0x3a9244c) > #11 in non-virtual thunk to SfxBaseModel::createViewController(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/doc/sfxbasemodel.cxx (instdir/program/libsfxlo.so +0x3a94895) > #12 in (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView(com::sun::star::uno::Reference<com::sun::star::frame::XModel2> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, comphelper::NamedValueCollection const&, rtl::OUString const&) at sfx2/source/view/frmload.cxx:584:60 (instdir/program/libsfxlo.so +0x40ca60a) > #13 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/view/frmload.cxx:711:13 (instdir/program/libsfxlo.so +0x40c3f25) > #14 in framework::LoadEnv::impl_loadContent() at framework/source/loadenv/loadenv.cxx:1149:37 (instdir/program/libfwklo.so +0x1520131) > #15 in framework::LoadEnv::startLoading() at framework/source/loadenv/loadenv.cxx:383:20 (instdir/program/libfwklo.so +0x1510b16) > #16 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/loadenv/loadenv.cxx:169:14 (instdir/program/libfwklo.so +0x150c7c8) > #17 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx:619:12 (instdir/program/libfwklo.so +0x166f1ce) > #18 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx (instdir/program/libfwklo.so +0x166f3da) > #19 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at unotest/source/cpp/macros_test.cxx:50:60 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x8f176) > #20 in DesktopLOKTest::loadDoc(char const*, LibreOfficeKitDocumentType) at desktop/qa/desktop_lib/test_desktop_lib.cxx:215:19 (workdir/LinkTarget/CppunitTest/libtest_desktop_lib.so +0xf2ca0) > #21 in DesktopLOKTest::testSearchCalc() at desktop/qa/desktop_lib/test_desktop_lib.cxx:423:37 (workdir/LinkTarget/CppunitTest/libtest_desktop_lib.so +0x100543) [...] Change-Id: I2af2f259a1415ba7977331d53d7ae9919692ff93 Reviewed-on: https://gerrit.libreoffice.org/63114 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-08Fix typosAndrea Gelmini
Change-Id: Ifd1affb7c3945de84a210dfbda894b60014f6cd6 Reviewed-on: https://gerrit.libreoffice.org/63020 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-08Fix typoAndrea Gelmini
Change-Id: Id76063b32ba37d42608cf7a19cbdf53d46fcbcc4 Reviewed-on: https://gerrit.libreoffice.org/63035 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-08Resolves: tdf#121238 format welded metricspinbuttons the same as historicallyCaolán McNamara
i.e. not with the UI Language, but with the Locale setting. Change-Id: I5146ece3356fdb67c3c715c6d17e608ec92e739a Reviewed-on: https://gerrit.libreoffice.org/63088 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-08uitest Writer Text to table dialogZdeněk Crhonek
Change-Id: I0c28174d24cc626ebdab647844c711fc2be51fe8 Reviewed-on: https://gerrit.libreoffice.org/63110 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-11-08tdf#113624 EMF+ Fix shift of DrawString without StringFormatBartosz Kosiorek
While we are drawing DrawString record, in most cases optional StringFormat information is available. If StringFromat information is available then we should use default values. For LeadingMargin for String the default value is 1/6 inch. Change-Id: I4a0a68df5ebe74e810f8b5864232b477b3aac255 Reviewed-on: https://gerrit.libreoffice.org/62927 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-11-08Resolves: tdf#121225 needs to be resizableCaolán McNamara
Change-Id: I978196d7b8cc5dada2ebb5d72f996780fbab80b8 Reviewed-on: https://gerrit.libreoffice.org/63102 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-08Bin some leftover and actually unnecessary iOS crack in vclTor Lillqvist
We don't need the '#define SvpSalGraphics AquaSalGraphics' in vcl/inc/headless/svpgdi.hxx. The actual AquaSalGraphics we use for iOS is in vcl/inc/quartz/salgdi.h. I don't remember the details of the convoluted history behind this. Change-Id: Ie56c3c93acf7ad89e10a05e75aa4ca7fd596ba98 Reviewed-on: https://gerrit.libreoffice.org/63098 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-11-08Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Clarify caption element description Change-Id: I03491b07a7c4b1da4441713c8f5bbff82ad164e1 Reviewed-on: https://gerrit.libreoffice.org/63096 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-08Related: tdf#121181 basic input box used to have a very wide edit widgetCaolán McNamara
so for a quiet life make it around that width again Change-Id: I7ffc0dc6d989ada3f9bf483aa1f5c1ac1ac352fc Reviewed-on: https://gerrit.libreoffice.org/63099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-08Resolves: tdf#121200 better ofz#7802 infinite loop fixCaolán McNamara
Change-Id: I50163d6545782012b177a48a1aded0572499f9af Reviewed-on: https://gerrit.libreoffice.org/63097 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-08tdf#120784 KDE5: Process "Enter" key from numpad like normal "Enter" keyAleksei Nikiforov
Change-Id: Id4a721aa30e92a9396f93342cf42d5790207bb89 Reviewed-on: https://gerrit.libreoffice.org/63095 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-11-08NB tabbed compact calc: copy files to install dirandreas kainz
Change-Id: Ibe2db53db5bffde38d24e105e87a6739dc6dbe8f Reviewed-on: https://gerrit.libreoffice.org/63101 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-11-08tdf#120252 use the already transformed PolyPolygonArmin Le Grand
Change-Id: I38abc73116720b99364c3de9fa4378c730385dc2 Reviewed-on: https://gerrit.libreoffice.org/63104 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-11-08Resolves: tdf#121270 use never scrollbar policy for gtk 3.18Caolán McNamara
Change-Id: I76df258c822b7811024f3bb6f96bafbc3298b15d Reviewed-on: https://gerrit.libreoffice.org/63105 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-08tdf#120777 KDE5: Remove initial painting of widgetsAleksei Nikiforov
Widget will be painted later, after correct widget size is set. If window is not resizeable and painted before setting correct size, it saves clipping size in function vcl::Window::ImplIntersectWindowClipRegion and never updates it when window is resized to correct size. This initial painting call causes painting issues in "File" -> "Wizard" -> "Letter" dialog: "Cancel" button is painted only partially, as well as line above that button. Other unresizeable windows with width over 640 pixels or height over 480 pixels may be affected too. Change-Id: Ieccb58368670ebbbe6d17826fafc717101309ac4 Reviewed-on: https://gerrit.libreoffice.org/63017 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-08tdf#120777 KDE5: Prohibit resizing windows unless they're marked resizeableAleksei Nikiforov
Change-Id: I412c3d263881d24dea1bb61520c2291d8f0b9b20 Reviewed-on: https://gerrit.libreoffice.org/63016 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-08Related: tdf#121238 show ui language as well as localeCaolán McNamara
Change-Id: I350c71f50fdb8f0602badd7a7ad13b3a7c2c85e0 Reviewed-on: https://gerrit.libreoffice.org/63083 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-08tdf#120642 - GetInvoled updateheiko tietze
UNO command is used now and period set to 180 days Change-Id: Ib9950e75a5288e242c5a9a5c5a6a0c1dbb277e2b Reviewed-on: https://gerrit.libreoffice.org/62949 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-11-08crash on export to pdf with password setCaolán McNamara
mostly since... commit 47a173edb603538521a035157efb6ef684238087 Date: Sat Sep 15 18:36:08 2018 +0200 use std::vector in PDFWriterImpl for encryption buffer instead of manual allocation and size field though that nLen*2 cound was already wrong as it is actually nChars, which is (nLen*2)+2, its just that the initial 0x4000 size was bigger than that so we got away with it Change-Id: I445bef87b6ba45b2034a82fe457e4540258b92d5 Reviewed-on: https://gerrit.libreoffice.org/63078 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-08Resolves: rhbz#1647507 try inputted password as both user and owner passwordCaolán McNamara
Change-Id: Ibe1fae39d3153238e85400c9645766c260c9290d Reviewed-on: https://gerrit.libreoffice.org/63080 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-08Revert "lok: calc: fix needed when position caching is disabled"Miklos Vajna
This reverts commit 4cee8ccc2caff17b5cbecc5ae895dcc9fd974c2e partially, which set the dictionaries submodule by accident. Change-Id: I798daaf5bf7a494880a2cd07820bccc4e23117e5
2018-11-08lok: calc: fix needed when position caching is disabledMarco Cecchetti
In case it would be needed to disable position caching we can't retrieve the nTotalPixels value from the LOKHeight/WidthHelper. The new code works in both cases. Change-Id: I65562dd4458eee40c5db958067fc91af6b3eb79e Reviewed-on: https://gerrit.libreoffice.org/63039 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-11-08lokdialog: Implement hi-dpi support for the routed dialogs.Jan Holesovsky
Change-Id: I770c605a049b7ac9c26c2773414eef8b6fc093a2 Reviewed-on: https://gerrit.libreoffice.org/63032 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-11-08sc lok: Implement hi-dpi and zoom for spreadsheets.Jan Holesovsky
A bit different approach than trying to paint different zoom levels at the samet time, because it is terribly hard to achieve with Calc - things misalign, because Calc tries to fit the lines into the pixels etc. Instead, always paint the spreadsheet at 100%, but use cairo to scale the actual painting. Change-Id: I228a9dd41bf29862bdd188825d12e61e1c86cccc Reviewed-on: https://gerrit.libreoffice.org/63031 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-11-08Revert "The debugging rectangles are not needed any more."Jan Holesovsky
Still useful for debugging, particularly in combination with gtktiledviewer. This reverts commit dec025d4cb51f252ecd7e981fe36800cf2bedff5. Change-Id: Id2174486c0427adf083be199ce2dbb453beb8f22 Reviewed-on: https://gerrit.libreoffice.org/63030 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-11-08More --enable-debug --disable-assert-always-abort fixesStephan Bergmann
...which <https://ci.libreoffice.org/job/lo_tb_random_config_linux/> occasionally stumbles across Change-Id: I2f28fda7522b2f6b009fc2b64766ec9e43c1ab67 Reviewed-on: https://gerrit.libreoffice.org/63067 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-08coverity#1441102 silence Copy-paste errorCaolán McNamara
Change-Id: I389984fa56a8709416f9d525e4a879993b432bea Reviewed-on: https://gerrit.libreoffice.org/63077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-08coverity#1441101: Use std::atomic instead of volatileStephan Bergmann
ee9ccdf6ecd944c2f448a30d10700754d1f0cfa2 "reduce cost of ProfileZone when it is not active" had changed g_bRecording from a bool guarded by g_aMutex to a volatile bool. But having been guarded by a mutex indicates that g_bRecording is potentially accessed from multiple threads, and volatile does not avoid races. Change-Id: I933ff5d912cbc7acce52155c605d9c19049c66aa Reviewed-on: https://gerrit.libreoffice.org/63073 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-08Resolves: tdf#119790 for gtk3 save and restore typed name on changing filterCaolán McNamara
Change-Id: I17c3d154144b13ce401b0e4afe84c91a2fe98d8e Reviewed-on: https://gerrit.libreoffice.org/63075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-08tdf#121131: Default COMPILER_PLUGINS_CXX to g++ -std=c++11Stephan Bergmann
ab8bf5533f8de9bb1aa9dc83e650e4eccf0fcac3 "Avoid error message from configure about clang's header for compiler plugins" caused problems after cd472d1d8489f30797f47d3f6dafede28c1feb90 "Compile as C++2a, where available", when the compiler used to build LO (CXX) supports -std=gnu++2a but the compiler used to build loplugin (COMPILER_PLUGINS_CXX) does not. So solve that problem instead by just adding -std=c++11 to the default for COMPILER_PLUGINS_CXX. Change-Id: I95e86bc28f2a0dfb2b7bdce6b15955b870428b8c Reviewed-on: https://gerrit.libreoffice.org/62997 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2018-11-08select entire column, not just text-occupied portionCaolán McNamara
making this consistent with ListBox Change-Id: Ifa2fd7070f95232fca8aa129e107ef5adf32e3df Reviewed-on: https://gerrit.libreoffice.org/62907 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-08Silence GCC 8.2.1 -Werror=format-truncation=Stephan Bergmann
After 09841225fc055f8270cee3059253f923dd544797 "soltools: fix -Werror=format-overflow" changed the sprintf into an snprintf, at least the Fedora 29 "gcc (GCC) 8.2.1 20181011 (Red Hat 8.2.1-4)" now complains about > [C ] soltools/mkdepend/include.c > soltools/mkdepend/include.c: In function ‘remove_dotdot.constprop’: > soltools/mkdepend/include.c:246:42: error: ‘snprintf’ output may be truncated before the last format character [-Werror=format-truncation=] > int n = snprintf(buf, BUFSIZ, "%s%s%s", dir, *dir ? "/" : "", component); > ^ > soltools/mkdepend/include.c:246:13: note: ‘snprintf’ output 1 or more bytes (assuming 8193) into a destination of size 8192 > int n = snprintf(buf, BUFSIZ, "%s%s%s", dir, *dir ? "/" : "", component); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This all looks not very helpful, lets limit the silencing to just GCC 8.2 (in the hopes that later versions of GCC won't emit that warning any more, anyway). Change-Id: I006964e4f32bbb52b6b90288e2d623797b8d38ea Reviewed-on: https://gerrit.libreoffice.org/63068 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-08update main thread "properly" in headless caseAndras Timar
Change-Id: Ie76555a007db13e89f06c85d02beebf84eadea0b Reviewed-on: https://gerrit.libreoffice.org/62912 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 3fb90f6eab998d0fda07bd3f4a2ebf650e6b6a61) Reviewed-on: https://gerrit.libreoffice.org/63062 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-11-08Convert FieldUnit to scoped enumMike Kaganski
Change-Id: Id2df31daa596a18c79af5fc6ea162deb6e24d5af Reviewed-on: https://gerrit.libreoffice.org/62958 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-08Adapt LibreLogo.py to Python 3.7 re.sub changeStephan Bergmann
In a build using the system Python during build (i.e., not using --enable-python=fully-internal) on Fedora 29 (where /usr/bin/python3 is 3.7.1), UITest_librelogo failed with > ====================================================================== > FAIL: test_compile_librelogo (compile.LibreLogoCompileTest) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/data/sbergman/lo-system/core/sw/qa/uitest/librelogo/compile.py", line 128, in test_compile_librelogo > self.assertEqual(test[1], re.sub(r'(\n| +\n)+', '\n', re.sub(r'\( ', '(', compiled)).strip()) > AssertionError: 'glob[52 chars]_#\n label(_y + _z)\n #_@L_i_N_e@_#\n#_@L_i_N_e@_#\nx(25, 26)' != 'glob[52 chars]_#\n label(_y + _z)\n #_@L_i_N_e@_#\n#_@L_i_N_e@_#\nx(25, ,26)' > global x > def x(_y, _z): > __checkhalt__() > #_@L_i_N_e@_# > label(_y + _z) > #_@L_i_N_e@_# > #_@L_i_N_e@_# > - x(25, 26)+ x(25, ,26)? + > > > ---------------------------------------------------------------------- due to an upstream Python change discussed at <https://bugs.python.org/issue34982#msg329418> "re.sub() different behavior in 3.7". I am not sure that upstream change really makes sense, despite that being explicitly confirmed in <https://bugs.python.org/issue34982#msg329420>. But lets tweak our code to adapt to that anyway. (There may be further places in LibreLogo.py that would need similar changes; I just fixed enough to make UITest_librelogo succeed for me.) Change-Id: I6c8f4b78f63953d582b88037fa56388b50af2b54 Reviewed-on: https://gerrit.libreoffice.org/63038 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-08tdf#119738 - Set default image caption to illustration if already being usedNickson
Change-Id: I8371bd4184734857a6c5578dc5c235760f83cc36 Reviewed-on: https://gerrit.libreoffice.org/60787 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-11-08coverity#1440238 silence Wrapper object use after freeCaolán McNamara
Change-Id: Iaf371360239ca07f45e76530c7d8e497b2ef697f Reviewed-on: https://gerrit.libreoffice.org/63049 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-08clarify that edit doesn't change during FormatterBase lifetimeCaolán McNamara
Change-Id: I416eee47eaae49a629fb0199e6b086215d315a94 Reviewed-on: https://gerrit.libreoffice.org/63048 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-08SetField/GetField do not need to be publicCaolán McNamara
Change-Id: I5989ce6485656f6ddb8f4994e8764cfa278d9ecb Reviewed-on: https://gerrit.libreoffice.org/63047 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-08mbDefaultLocale is always trueCaolán McNamara
Change-Id: I92bcb381330a129ca42a2407a3e4db0ed044ed51 Reviewed-on: https://gerrit.libreoffice.org/63041 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-18 08:45:17 +0000