summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-09-04tdf#118967 Batch all a11y notificationsPaul Trojahn
Currently all a11y notifications get send out immediately, which often ends up formatting the document before it is ready. With the current EnterBlockNotifications()/LeaveBlockNotifications() system it is difficult to find all places that need blocking and any change in the a11y code might require additional blocking in unpredictable places. By queueing all notifications by default and only sending them out when the document is ready, we can make sure that it can't be corrupted. Change-Id: I9599c7b57eb5b8f8f0575de57fcc8bab171f78ff Reviewed-on: https://gerrit.libreoffice.org/58703 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-04loplugin:useuniqueptr in AcceleratorConfigurationNoel Grandin
Change-Id: I255005e80ee57638846e353a88477dd54bbbb284 Reviewed-on: https://gerrit.libreoffice.org/59943 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-04tdf#42949 Fix IWYU warnings in sc/source/filter/inc/[a-l]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I92cfd8d09ca8229764db4200568b96a62e2ab21e Reviewed-on: https://gerrit.libreoffice.org/59742 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-04loplugin:useuniqueptr in HandlerCacheNoel Grandin
Change-Id: Ic3ba52568cbf1281162b3b4146d8c5d2ce9574b4 Reviewed-on: https://gerrit.libreoffice.org/59942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-04Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Refactor pages for string <-> numbers/refs/dates Change-Id: I988850bd09ed2877bc98a3fda7ddff4b3ffbcff6 Reviewed-on: https://gerrit.libreoffice.org/59595 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-09-04sd/pptx export: allow exporting effect preset id.Mark Hung
Change-Id: I2a0149e7f47fe3d5abeea61c93d0a55782af3e6d Reviewed-on: https://gerrit.libreoffice.org/59891 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-03Enable the align group button for framesMaxim Monastirsky
Change-Id: I6ba8b5fe0d185817e61986c90f5264493b6d5339 Reviewed-on: https://gerrit.libreoffice.org/59951 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-09-03tdf#119146: fix populating maCurrentSubsetsMike Kaganski
Regression from commit 4600b07c1d787f959618d9ecf54161e4ea4ffa61 Before the mentioned commit, creating a subset X, and then adding sub-subsets until all the subset is excluded, had left the subset X with two *empty* nodes in maCurrentSubsets, 1st of them having both mnStartIndex and mnEndIndex equal to maSubset.mnStartIndex, and 2nd having both mnStartIndex and mnEndIndex equal to maSubset.mnEndIndex. The commit above changed that to adding maSubset to maCurrentSubsets in the beginning of each exclusion, which finally resulted in a messy maCurrentSubsets with multiple duplicating nodes effectively covering all maSubset. That resulted in the item as a whole handled *besides* the sub-subsets. This commit (1) avoids adding extra maSubset to maCurrentSubsets, and (2) adds the two empty nodes in case all the subset has been excluded by its sub-subsets. Change-Id: I7fc5f2d0b6ecf4f9247351da3a2746032150557b Reviewed-on: https://gerrit.libreoffice.org/59948 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-03ofz#10198 reset uncommitted fly stuff & pams before applying redliningCaolán McNamara
Change-Id: I2a2587ec4590926f7cffc2a4d58a22d9d5f19c99 Reviewed-on: https://gerrit.libreoffice.org/59946 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-03define PURIFY for openssl for dbgutil to silence valgrind spewCaolán McNamara
Change-Id: I318ca368f26e42038a043b1e264a619795a9515e Reviewed-on: https://gerrit.libreoffice.org/59945 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-03Adapt solenv/flatpak-manifest.in to recent changesStephan Bergmann
Change-Id: Ibbc167ca736012e7585694885370c1505ad48499 Reviewed-on: https://gerrit.libreoffice.org/59939 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-03sc dataprovider/databar dialogs: fix some a11y issuesKatarina Behrens
Change-Id: Id57c11e6e41d5b940e4c48519a198885a593f2ef Reviewed-on: https://gerrit.libreoffice.org/59921 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-03weld SvxAreaTabPageCaolán McNamara
which itself has 5 sub tab pages Change-Id: If71e91248b5771af4845ad6dba997ac4c7841b5d Reviewed-on: https://gerrit.libreoffice.org/56112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-03expand CheckBox AddItemConnectionCaolán McNamara
Change-Id: I35e7f0e129186a863d0ddcc6ebcb86b81378ea78 Reviewed-on: https://gerrit.libreoffice.org/59933 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-03sd/ pttx export: wrap user data handling in NodeContext.Mark Hung
Move effect node type, effect preset class, preset id, and prset subtype to NodeContext. Change-Id: I1f89a71e0bfc4bf3beb6c3c55662c076bef88fa8 Reviewed-on: https://gerrit.libreoffice.org/59890 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-03return by std::unique_ptr from GetErrorInfoNoel Grandin
Change-Id: I80f1643b252d0b38d279b402a422733c0c4749b9 Reviewed-on: https://gerrit.libreoffice.org/59938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-03sw: prefix members of SwXTextColumnsMiklos Vajna
Change-Id: I03add1c19ce225eeec92d6d3d43063b59c6b7967 Reviewed-on: https://gerrit.libreoffice.org/59917 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-03sd/ pptx export: refactor WriteAnimationNodeCommonPropsStart().Mark Hung
Make switch-case conversions standalone functions to make the function shorter and more clear. Change-Id: I71ea33c92ab4df848f106979c8d2d69340775da8 Reviewed-on: https://gerrit.libreoffice.org/59888 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-03upgrade curl to 7.61.0Caolán McNamara
Change-Id: Iaaa83fc4146c2b91b1d1f1942882ab1e664f998b Reviewed-on: https://gerrit.libreoffice.org/59925 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-03tdf#37268: use also sheet local range in PivotJulien Nabet
There are 2 types of range names: - those global to the document - those specific to a sheet Before this patch, Pivot could only see global range names There are 2 parts on the patch: 1) ScCellShell::ExecuteDataPilotDialog() Retrieve all the range names and use: - for sheets range names: <scope>.<range name> - for global range names: <range name> 2) ScSheetSourceDesc::GetSourceRange() Search about the presence of . to know if it's a global or sheet name range Change-Id: I92ac321e1475516cce7ee42b6e6038c231d0514b Reviewed-on: https://gerrit.libreoffice.org/58070 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-09-03sd/pptx export: clean up rXNode and bMainSeqChildMark Hung
from function paramter list, invoke getCurrentNode() and isMainSeqChild() only when necessary. Change-Id: I1da472426fab84219176b98a826210bbe279bb53 Reviewed-on: https://gerrit.libreoffice.org/59877 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-03Resolves: tdf#119574 set specific width for style list widgetCaolán McNamara
so super wide style name doesn't break things Change-Id: I096eb1d3deeb935b43566b4d3ccb45d89ac2a56a Reviewed-on: https://gerrit.libreoffice.org/59928 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-03Missing includeStephan Bergmann
Change-Id: Ib04de3f3f143cfa8a0c9d6171e329655d96527eb
2018-09-03Related: tdf#119613 inherit af_ZA separators from identical en_ZAEike Rathke
Also LC_FORMAT is already inherited. Change-Id: I166ac1b50329430139d3f243454d7fdd2069e4ad Reviewed-on: https://gerrit.libreoffice.org/59920 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-09-03tdf#119613 [*-ZA] decimal separator is comma, group separator is spaceEike Rathke
Change-Id: I9152a419385cc894f973a7333ae03b75b7f79008 Reviewed-on: https://gerrit.libreoffice.org/59919 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-09-03fix bug in SwEditShell::GetGlobalDocContentNoel Grandin
ever since commit 84a3db80b4fd66c6854b3135b5f69b61fd828e62 Date: Mon Sep 18 23:08:29 2000 +0000 initial import where it could insert an uninitialised pointer into the SwGlblDocContents sorted vector Change-Id: Id58778444593c39b5f80bac3a6dab8e14404030a Reviewed-on: https://gerrit.libreoffice.org/59932 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-03move identity checks into B3DHomMatrix::operator*=Noel Grandin
and consequently simplify some call-sites Change-Id: I301fc4c88fdfb8af75a348a41593a27f4c6567c5 Reviewed-on: https://gerrit.libreoffice.org/59916 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-03loplugin:useuniqueptr in various in scNoel Grandin
Change-Id: I47eb6ea14495a3f21fd008f8b8716c30effde985 Reviewed-on: https://gerrit.libreoffice.org/59924 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-03sd/pptx export: utility class to further refactor.Mark Hung
Add NodeContext to wrap reference of XAnimationNode and bMainSeqChild so that the node under processing can be get via getCurrentNode() and isMainSeqChild() instead passing arround via parameters. Change-Id: Ie4be58211f4194fc2a24aa951c2110911c91d94e Reviewed-on: https://gerrit.libreoffice.org/59876 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-03loplugin:useuniqueptr update exclusionsNoel Grandin
Change-Id: I9c741dbaba772550b4d68406fff50d8b0ac60874 Reviewed-on: https://gerrit.libreoffice.org/59923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-03tdf#82177 ooxmlimport: ignore direct insideV/H cell bordersJustin Luth
17.4.25 insideV (Table Cell Inside Vertical Edges Border) This element specifies the border which shall be displayed on all interior vertical edges of the current group of table cells. [Note: Although individual table cells have no concept of n internal edge, which would render this property useless in most cases, it is used to determine the cell borders to apply to a specific group of cells as part of table conditional formatting in a table style, for example, the inside vertical edges on the set of cells in the header row. end note] So, I interpret this as insideV/H having meaning only within table styles, and not when directly applied to a cell. The only documents I've seen with insideV/H directly applied to a cell seem to have been created by LO - which dumps them everywhere, redundantly. Change-Id: Ie76e9af6845cc87b0b847050b031e57d95b1a31b Reviewed-on: https://gerrit.libreoffice.org/59674 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-03ofz#10189 check container sizeCaolán McNamara
Change-Id: Ie99e3b082795989290799d057a99b1bcff94b161 Reviewed-on: https://gerrit.libreoffice.org/59911 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-03use less magic in sw/Noel Grandin
rename the "magic" members and fields that are actually a font-cache-id, to more useful names Change-Id: Ie787b0939115c576e979c7e27a21a68c138c32f6 Reviewed-on: https://gerrit.libreoffice.org/59868 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-03sw: save more vcl layout calls in SwFntObjMiklos Vajna
This builds on top of commit 436b829f5b904d76039db0818cff5dedf1ae89f1 (sw: save one vcl layout call in SwFntObj::DrawText(), 2018-08-16), but now layouts are shared not only inside SwFntObj::DrawText(), but also between SwFntObj::GetTextSize() and SwFntObj::DrawText(). To get there, create an SwFntObj cache member that stores already calculated vcl layouts. SwFntObj already derives from SwCacheObj, so no need to explicitly expire this cache member. Total number of GenericSalLayout::LayoutText() invocations go down from 8 to 5 with this when pressing a key in Writer. Change-Id: Ifbe84a5c00025604f9c1331b56074b3dc27864b5 Reviewed-on: https://gerrit.libreoffice.org/59879 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-03tdf#99296 - Disable headers/footers by defaultheiko tietze
Change-Id: I9232c879cebdcb92236322e4d4a12048d9fec00f Reviewed-on: https://gerrit.libreoffice.org/59696 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-09-03tdf#119293 - UI Consistency for inserting rows in Writer tableheiko tietze
Labels are set now depending on row/col as left/right and above/below Change-Id: I73b81660db1e4e8c3d0146f59e193744a3883583 Reviewed-on: https://gerrit.libreoffice.org/59867 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-09-03tdf#79022 - Please bundle Source Serif Proheiko tietze
Source Serif added Change-Id: Ibbdbd2556852e7c4e19357d332990646aec7a43d Reviewed-on: https://gerrit.libreoffice.org/59498 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-09-03SvXMLUnitConverter::convertDateTime: use tools::Time::GetClock()Eike Rathke
... to not round up to the next magnitude. Change-Id: Ibda6e014ae3bdbe021e208c8781f619b112bee21 Reviewed-on: https://gerrit.libreoffice.org/59887 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-09-03cppcheck: useInitializationList in basicJochen Nitschke
Change-Id: I97fefc25076c2c163f6010745081772ee8c17712 Reviewed-on: https://gerrit.libreoffice.org/59908 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-03cppcheck: knownConditionTrueFalseJochen Nitschke
Change-Id: I6ee2dd049b2482d93b5d05754c11b34bf535e377 Reviewed-on: https://gerrit.libreoffice.org/59907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-03pass SdrUndoAction around by std::unique_ptrNoel Grandin
convert the LINK we use here to std::function, since LINK does not currently handle std::unique_ptr Change-Id: I9df80352e612445e5f5ca513d7d4196d65589778 Reviewed-on: https://gerrit.libreoffice.org/59804 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-03tdf#104354 writerfilter: not FirstParaInSection if InFootOrEndnoteJustin Luth
or InComment. The first footnote does not get special treatment in autospacing either, so no exception needs to be made for it like in autospacing, unlike many other "firsts". The unit test is simply preventative. I'm a bit surprised, but the section isn't even marked as "IsFirstSection" until after the comment and footnote paragraphs are finished. That seems a bit odd to me, since they are in the FirstSection after all. Change-Id: Ib0107c969bf624e44f0c78b936bf9531fd25bfc2 Reviewed-on: https://gerrit.libreoffice.org/59858 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2018-09-02Fix typoAndrea Gelmini
Change-Id: I9d039e14fdc4600f6f20ebc57e69250ac89ab9f5 Reviewed-on: https://gerrit.libreoffice.org/59909 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-02tdf#118993 - Missing new Insert Special Character in Writer (global)Rizal Muttaqin
Change-Id: I8b9925f6124527dfc27c7a27f6c8832c7e9c88e4 Reviewed-on: https://gerrit.libreoffice.org/59855 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-09-02tdf#117835 Paste as Unformatted for comments in WriterMaxim Monastirsky
Change-Id: Ia96f8c51cc0a3898c1169454bd7c3031e08c45d4 Reviewed-on: https://gerrit.libreoffice.org/59906 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-09-02tdf#118674 Paste special and unformatted for shapes in WriterMaxim Monastirsky
Change-Id: I348a6f93b61ea644077dcd3a16ba9d9fe17afb91 Reviewed-on: https://gerrit.libreoffice.org/59905 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-09-02tdf#112935 Paste as Unformatted doesn't work in shapes and commentsMaxim Monastirsky
The shapes and comments code in sw and sc assumes that OutlinerView::Paste does paste as unformatted text, and OutlinerView::PasteSpecial does paste as formatted, similar to the corresponding methods of EditView, which it's supposed to call internally. But the reality is that OutlinerView::Paste just calls PasteSpecial, with a comment "HACK(SD does not call PasteSpecial)". All this situation goes back to "initial import" commits. This commit changes OutlinerView::Paste to paste as unformatted (by default). Call sites that were using it, but apparently wanted formatted output, were changed to an explicit PasteSpecial call. Change-Id: I1d7472039fb9fe09810260a199e216ec95765b10 Reviewed-on: https://gerrit.libreoffice.org/59904 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-09-02tdf#104354 writerfilter: rewrite AutospacingJustin Luth
which also resolves a regression from tdf#113258. The previous code segments were being spread out all over the place. It all consolidates nicely in finishParagraph, and the code is much easier to read using the new GetAnyProperty function. Plus there were regressions creeping in. The mere presense of the Autospacing property normally, but not necessarily means that it is on. Verify that it is enabled, and update grabbag if autoSpacing changes. Additionally, support was added for a zero top margin for the first paragraph of the document. This will be too hard to backport since it depends on 150c12fc0fba2c2f4b08b4298678ee49676ebae0 from tdf#72560 and the many code fixes related to GetPropertyFromStyleSheets. Change-Id: Iaf1600fffea54e9800e215e89cad40006d5bcdda Reviewed-on: https://gerrit.libreoffice.org/59705 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-09-02Fix typoAndrea Gelmini
Change-Id: I3947c13a595f94ea56d01dc5c3db5e634e737342 Reviewed-on: https://gerrit.libreoffice.org/59902 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-09-02tdf#119188 DOCX import: fix zero margins of numbered lines in cellsLászló Németh
regression from 5c6bce38a01b21403a603acd3148cf3bbb4c685f (tdf#104354 DOCX import: fix paragraph auto spacing in tables). Change-Id: I486d155eb4463599ab922837fd2f4347b48e0851 Reviewed-on: https://gerrit.libreoffice.org/58818 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
generated by cgit (git 2.34.1) at 2024-07-20 07:37:18 +0000