summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-06-07Bin the much too verbose SAL_INFO() calls for the "vcl.cg" tagTor Lillqvist
Quikee agreed that they aren't really useful. Doing even the simplest things causes such a huge amount of logging that it is questionable whether anybody could have any use of it. Parts of it might be useful to restore later, if need arises. Like the mnContextStackDepth logging in vcl/inc/quartz/CGHelpers.hxx. Change-Id: If635e6492a50e5955c56c54fa310e7c0ab2986ae Reviewed-on: https://gerrit.libreoffice.org/73639 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-06-07Fix typoAndrea Gelmini
Change-Id: I0037cf0a59189862ad502bfbdb00580ed7378fe4 Reviewed-on: https://gerrit.libreoffice.org/70393 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typoAndrea Gelmini
Change-Id: I4b4f0d6c96d85d050110ff39db2cc06bb1d666c2 Reviewed-on: https://gerrit.libreoffice.org/70690 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typosAndrea Gelmini
Change-Id: Iec0824418063fa4d146d9d48f3c74561fc0c5a67 Reviewed-on: https://gerrit.libreoffice.org/73631 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typosAndrea Gelmini
Change-Id: If9d52bd769d96865a3fbfdda1f339bbd0f8c3ca3 Reviewed-on: https://gerrit.libreoffice.org/73633 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typoAndrea Gelmini
Change-Id: Ie9174d46b3936ee19a7d1e70f85af6fed2c0c6d4 Reviewed-on: https://gerrit.libreoffice.org/73637 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typoAndrea Gelmini
Change-Id: I577cecc9b5c73a999b0e38478adf71c527210619 Reviewed-on: https://gerrit.libreoffice.org/73635 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typoAndrea Gelmini
Change-Id: Icbfc9276e09f2d50647c4e800b6d688d978b875b Reviewed-on: https://gerrit.libreoffice.org/73632 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typoAndrea Gelmini
Change-Id: I1ed7280266fc2612ca1286c129a614c51aba3571 Reviewed-on: https://gerrit.libreoffice.org/73636 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typoAndrea Gelmini
Change-Id: I4cfc98ab3be0c789274978ec6b26f981ad627494 Reviewed-on: https://gerrit.libreoffice.org/73634 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Remove .uno:ToolsMacroEdit commandJens Carl
A search with git grep ".uno:ToolsMacroEdit" showed that the entry isn't used anywhere (also .uno:BasicIDEAppear provides a similar functionality). Change-Id: Ib97f4ebd6707d82f9077dd2f4e6c05e537f8154d Reviewed-on: https://gerrit.libreoffice.org/73582 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-07sanitize LibreLogo callsLászló Németh
Change-Id: Ie4d9858e5b4b3e55ab08416fb9338d2df34ee5e1 Reviewed-on: https://gerrit.libreoffice.org/73627 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-06-07tabbar: make ImplFormat more readableTomaž Vajngerl
Change-Id: Id9a188fc46d800212ff583a233f06553bf1b4596 Reviewed-on: https://gerrit.libreoffice.org/73591 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-06Sifr: Add missing large iconsrizmut
Change-Id: Iadd17df97f374752097c8cad4b82735a4c77f923 Reviewed-on: https://gerrit.libreoffice.org/73343 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-06lok: remove ext text event re-entrancy hazard.Michael Meeks
Change-Id: I7566c158330bab77589d422c61c64210727ab835 Reviewed-on: https://gerrit.libreoffice.org/73625 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-06-06tdf#125556 URL fragment leaked from one object..Noel Grandin
to another when importing Powerpoint ppt file regression from commit 4245454d0c3d6df2d0e0a75aed6f22f0a26ce3e2 Date: Wed Feb 28 15:50:29 2018 +0200 loplugin:useuniqueptr in SdrPowerPointImport Change-Id: I5f415dfa1f6125629b9f3be1d799cb596c64c605 Reviewed-on: https://gerrit.libreoffice.org/73602 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-06tdf#125201 fix QWheelEvent angleDelta() handlingJan-Marek Glogowski
Comming back to my initial, known broken implementation from 2017-11 (see commit 1426437be053 ("QT5 implement some mouse handling")), which just works with mouse scroll wheels. This just fixes angleDelta() based scrolling. An additional patch might be needed, if some driver just uses pixelDelta() values, but Qt explicitly states: "On X11 the pixelDelta() value is driver specific and unreliable, use angleDelta() instead.", so we'll do just that for now. Change-Id: I1be5f9392ed475aea7ab4d965a07e1e3c2574fe7 Reviewed-on: https://gerrit.libreoffice.org/73614 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-06distro-config: Drop '--enable-gstreamer-0-10' everywhereMichael Weghorn
This avoids the issue that build breaks when both gtk3 and gstreamer-0.10 are enabled, caused by commit 34bbf192a7753205bb64d14e4eec4ce303317396 ("Drop extra define ENABLE_GTKSINK"). gstreamer-0.10 related code will be removed in a subsequent step according to ESC decision (no longer needed). Change-Id: Ief07a797a3e52229da0ff7b23478108aac900841 Reviewed-on: https://gerrit.libreoffice.org/73608 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-06-06tdf#125670 just check gradient clipping on drawingJan-Marek Glogowski
Otherwise the gradient won't be commited to the Metafile, as mbOutputClipped will be true, because the output device will have just one pixel size. Change-Id: I73084eb715ee6313f6478eded24feb9abfc411f3 Reviewed-on: https://gerrit.libreoffice.org/73423 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06Refactor a bit of the presentation minimizerJan-Marek Glogowski
This was originally just about getting rid of the resource leak. Turned out to include a little refactoring to hide most of the UnoDialog member variables. * use cppu::component_getFactoryHelper * free leaked createPeer resources in destructor Change-Id: I45449c49e32af4935908b801ed9bd9732af944d3 Reviewed-on: https://gerrit.libreoffice.org/73565 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-06tdf#124118 Qt5 post non-code keys via ExtTextInputJan-Marek Glogowski
Originally I tried to implement the gtk3 way by shoving all key input in some way through the QInputMethod. But that turned out to be impossible, because all the nice input event filtering is privately hidden in the platform abstraction. And it took me much longer to realize that gtk3 is doing this. Still the delivered code point in the KeyEvent is correct, so this simply uses ExtTextInput events for non-code key events, if LO has enabled input method support for a frame. Change-Id: Ia9bb6baf013cf790deecb9675f8309e32294e982 Reviewed-on: https://gerrit.libreoffice.org/73322 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-06loplugin:nullptr (macOS)Stephan Bergmann
Change-Id: Ibd4bd34fc73f80aea7aaf2a5e524cf877822ee6b Reviewed-on: https://gerrit.libreoffice.org/73587 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-06update precompiled_rptui.hxxCaolán McNamara
Change-Id: Iaef795ee48f590ed2cd0ba1c47dcc703172d8677 Reviewed-on: https://gerrit.libreoffice.org/73597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06weld HeaderFooterDialogCaolán McNamara
Change-Id: I6a5068106d0f243646cf12ec676dff60a04922ee Reviewed-on: https://gerrit.libreoffice.org/73596 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06duplicated about dialog close button when headerbars not enabledCaolán McNamara
Change-Id: Idd69b37ff0dc85dc96349c4e85fc5d4a93597e62 Reviewed-on: https://gerrit.libreoffice.org/73601 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06tdf#125324 table export: do not ignore default valuesPatrick Jaap
It seems like Writer default values for table positioning differ from OOXML spec. if nothing is given. So write them anyway during export. Change-Id: If5bf77de71b457a826be8f1559212e7d06c5237c Reviewed-on: https://gerrit.libreoffice.org/73402 Tested-by: Jenkins Reviewed-by: Patrick Jaap <patrick.jaap@tu-dresden.de>
2019-06-06CoreTextStyle::mbFauxBold shall presumably be boolStephan Bergmann
...it was added as float with eb5606511fac2a8ee1af7cc03c12d6c5b16f7c96 "tdf#101854 Move to CommonSalLayout removed faux bold in macos", but that causes loplugin:implicitboolconversion warnings, and was probably just a typo. Change-Id: Ib35c5b001f0a77befa17e7bbb6447129e36a42ba Reviewed-on: https://gerrit.libreoffice.org/73590 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2019-06-06tdf#124947 fix hit area of the radio buttons, size in ios themeTomaž Vajngerl
The hit area of the radio buttons was not calculated correctly, so sometimes when you hit the radio button at the "wrong" place, nothing happened. This fixes the hit area to correctly cover the radio button and the text. Another issue was that the ios theme size of the radio button was not defined correctly (32px instead of 26px), which increased the error when calculating the hit are even more. The height of the radio button should be the same as defined in the definition.xml, and not bigger (or smaller). Change-Id: I4b03f36ca9d9c82bd6dc442bd6e06af938c62bdd Reviewed-on: https://gerrit.libreoffice.org/73592 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-06Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#68103 Mark differences between Draw and Impress Although the 2 modules share a common kernel, the nomeclature, menus and master pages/slides are different. Change-Id: Id4282b2ebaf48a57b753ff0cefa228c3f3bdc644 Reviewed-on: https://gerrit.libreoffice.org/73578 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-06-06Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Remove superfluous string in impress/Draw contents Keep same Contents structure as other apps Change-Id: I1afc21e3581c3200ce6821ee3594686a1f8a70dc Reviewed-on: https://gerrit.libreoffice.org/73571 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-06-06loplugin:simplifyconstruct (macOS)Stephan Bergmann
Change-Id: I7c46c231f720c7d35a24e19833fb3239a31946ef Reviewed-on: https://gerrit.libreoffice.org/73589 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-06loplugin:data (macOS)Stephan Bergmann
Change-Id: I404a8364a4c7f8d48533fb3c7757a5b7798de9d8 Reviewed-on: https://gerrit.libreoffice.org/73588 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-06sfx2: warn when invoking LOK callback before setupAshod Nakashian
Change-Id: I2c845c357f73dbce71b1e420979aecf2cff38827 Reviewed-on: https://gerrit.libreoffice.org/68255 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/73482 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-06sd: support inserting background image from file via .uno:SelectBackgroundAshod Nakashian
The UNO command always prompted the user via file open dialog. This change allows for passing the filename as an argument to allow for inserting slide background programatically. Also, hide the Insert Image button in the sidebar since we can't use that (just yet), because it invokes .uno:SelectBackground directly. We would need to send LOOL a notification to invoke this on its own end to first prompt the user for a file. (cherry picked from commit 2118143bdd246921439ba9e835207585203dd45f) Change-Id: I20c0e33d66f8bcd72a6388e39c4ac92e64978f45 Reviewed-on: https://gerrit.libreoffice.org/73481 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-06tdf#125719 sw: rtf: refactor associated character propertiesSerge Krot
1. \rtlch, \ltrch should be placed before their properties. 2. Do not mix associated and normal character properties in output. 3. Do not output empty "\rtlch \ltrch", "\ltrch \rtlch" pairs. 4. Handle associated character properties runs instead of handling separately their parts without order of them. Change-Id: Ibbf7365d04708682a5f1eb664a579c60a47465d2 Reviewed-on: https://gerrit.libreoffice.org/72578 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-06-06loplugin:typedefparam: Work around different size_t typedefs on macOSStephan Bergmann
...which for me caused > [CXX] registry/tools/options.cxx > /Users/stephan/Software/lo/core/registry/tools/options.cxx:39:89: error: function param 3 at definition site does not match function param at declaration site, 'size_t' (aka 'unsigned long') vs 'size_t' (aka 'unsigned long') [loplugin:typedefparam] > bool Options::checkArgument(std::vector< std::string> & rArgs, char const * arg, size_t len) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~ > /Users/stephan/Software/lo/core/registry/tools/options.hxx:41:93: note: declaration site here [loplugin:typedefparam] > static bool checkArgument (std::vector< std::string > & rArgs, char const * arg, size_t len); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~ because one is TypedefType 0x115a4d700 'size_t' sugar |-Typedef 0x115a4d460 'size_t' `-BuiltinType 0x7fde8e0393c0 'unsigned long' while the other is TypedefType 0x7fde8e94a3a0 'size_t' sugar |-Typedef 0x7fde8e94a138 'size_t' `-TypedefType 0x7fde8e94a100 '__darwin_size_t' sugar |-Typedef 0x7fde8e88cc28 '__darwin_size_t' `-BuiltinType 0x7fde8e0393c0 'unsigned long' and > [CXX] store/source/storcach.cxx > /Users/stephan/Software/lo/core/store/source/storcach.cxx:218:43: error: function param 1 at definition site does not match function param at declaration site, 'std::size_t' (aka 'unsigned long') vs 'std::size_t' (aka 'unsigned long') [loplugin:typedefparam] > void PageCache::rescale_Impl (std::size_t new_size) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~ > /Users/stephan/Software/lo/core/store/source/storcach.hxx:67:36: note: declaration site here [loplugin:typedefparam] > void rescale_Impl (std::size_t new_size); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~ because one is ElaboratedType 0x116f5cba0 'std::size_t' sugar `-TypedefType 0x7fd58673e090 'size_t' sugar |-Typedef 0x7fd58673dde8 'size_t' `-BuiltinType 0x7fd58603cfc0 'unsigned long' while the other is ElaboratedType 0x7fd586742200 'std::size_t' sugar `-TypedefType 0x7fd58621cdc0 'size_t' sugar |-Typedef 0x7fd5861ce4a0 'size_t' `-TypedefType 0x7fd5861cdc70 '__darwin_size_t' sugar |-Typedef 0x7fd586889ec8 '__darwin_size_t' `-BuiltinType 0x7fd58603cfc0 'unsigned long' Change-Id: I3622716376198cc046b0489db59c5cbf613ea1f4 Reviewed-on: https://gerrit.libreoffice.org/73585 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-06loplugin:cstylecast (macOS)Stephan Bergmann
Change-Id: I4468aff1817fdb47256dff94e7f2d8aa7575137e Reviewed-on: https://gerrit.libreoffice.org/73586 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-06KJ & elementary: +/^ svx dir, elementary: ^ bezier & mimerizmut
Change-Id: Ieaff18277743da93393667c946ed2e95c98921b0 Reviewed-on: https://gerrit.libreoffice.org/73466 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-06vcl: move bitmap scale test to its own fileTomaž Vajngerl
Change-Id: I21e01f63da1c95c3a2c8bae9b998a28fc0a27bc1 Reviewed-on: https://gerrit.libreoffice.org/73560 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-06Cosmetics.Ashod Nakashian
Change-Id: Ic86960ce2f690bebc51c9120053bdd50232f0358 Reviewed-on: https://gerrit.libreoffice.org/73480 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-06-06fix the color dropdownCaolán McNamara
Change-Id: I7666a8364f765830634be46bcb590a1604e5ced1 Reviewed-on: https://gerrit.libreoffice.org/73551 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06weld AboutDialogCaolán McNamara
use a native GtkAboutDialog on that platform and refactor the current cui about dialog body to form the body of a vcl AboutDialog use add_button to add the buttons to whichever is preferred of the headerbar or action-area Change-Id: I67e0b36dcb8d3fa08ec4f0397b0f6185b0778675 Reviewed-on: https://gerrit.libreoffice.org/73439 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06ViewShellBase const correctnessAshod Nakashian
Change-Id: I00bffe23f2f850f5e0cbf63a60aa1600f848edac (cherry picked from commit 4e6e33870a60a796c17c1e2d67ac6482b853ad28) Reviewed-on: https://gerrit.libreoffice.org/73479 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-06drop never used dialogCaolán McNamara
Change-Id: I2474887914ec74e62667fd6f68ecb57bad89ca0d Reviewed-on: https://gerrit.libreoffice.org/73561 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06xmloff: create XMLDrawMetaImportOasis instances with an uno constructorMiklos Vajna
Change-Id: I6793d227fd5e7f358904083f37ccae825f733fd4 Reviewed-on: https://gerrit.libreoffice.org/73570 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-06tdf#115212 DOCX export: fix ToC with tracked deletionLászló Németh
Removing part of Table of Contents with tracked deletion resulted broken DOCX export, ie. unrecoverable and uneditable document in MSO. Change-Id: If5972b2c9fb967819b7be889e0a3efb3714e670b Reviewed-on: https://gerrit.libreoffice.org/73550 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-06-06only want a border here surely, not scrollabilityCaolán McNamara
Change-Id: Ief22fa4e437af5d408a4debc776be3237a97601a Reviewed-on: https://gerrit.libreoffice.org/73553 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-06-06tdf#125642: fix minimal sizes of dialog and its elementsMike Kaganski
Change-Id: I0232999866eb731fd74b3e954121f1960a3873bd Reviewed-on: https://gerrit.libreoffice.org/73577 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-06-06Fix typoAndrea Gelmini
Change-Id: I3883dedde0ad3ca6c4d6190d711af9c1e6411a50 Reviewed-on: https://gerrit.libreoffice.org/73573 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-06Fix typoAndrea Gelmini
Change-Id: I391dd0af85ced2cb16d54c560c7fb733ff8d780d Reviewed-on: https://gerrit.libreoffice.org/73574 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2024-07-13 13:29:43 +0000