summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-03-13tdf#42316 always evaluate macro signatures on loadJan-Marek Glogowski
As already stated in the comments of the signing unit tests, disabling macro security will not only ignore the signatures, but actually drop the macro signature, as these are never evaluated and as a result can't be restored for the new document. Change-Id: Ie41a9e72d3367c2eed58a52387bb67d8c41abff3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90435 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-12tdf#130094 Work around content pastes twice after undoJim Raykowski
commit 24019d56fbc4ac94bd1b72b37a9bcabc7ef8164b seems to have introduced this behavior. This patch is a work around that skips code introduced by the above commit when selection type includes number list type. Change-Id: I7a74ad7262e3e008f6aa11fe04fb81b9604ef3e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87795 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-03-12Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 996909e80712157f57b650fec7b529320398dd4f - Helponline: Make that image shadow look not tacky Change-Id: I7e0b370ad883e787a8c7b7970d8d96653e577f8e
2020-03-12tdf#130976 replace `rtl::math::isInf` with `std::inf`.Yukio Siraichi
Change-Id: Id0f0e07b324230d2d69cbf4ab07b0fff5b24474d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90377 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-12Revert "loplugin:constfields in slideshow"Noel Grandin
This reverts commit 56940b766e5d52cb1c17b4250e4c7e2c375b7b65. Change-Id: I5b585ff44870193becc0770e6504ac645b254ef3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90418 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Revert "loplugin:constfields in smoketest..sot"Noel Grandin
This reverts commit 1de7e818a417a412678013c100b4bf73fd8858ac. Change-Id: Ie1100fd1af636a0538f589845b9391ba40dbf12a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90417 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Revert "loplugin:constfields in sfx2"Noel Grandin
This reverts commit 8411b80d46765f1ddd4e37aa634ec963dcf4b04f. Change-Id: Ibf3aa3ce4bfedf9d47001ad824db7c48ff093a21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90416 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12tdf#131291: Add UItestXisco Fauli
Change-Id: I65aede1899d2c509fd52f8db0657ec3a5791f681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90430 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-12Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to cd70c38c6fae4d4ccdf861a923ac2be944944808 - Remove line breaks from translatable string 🤦‍♂️ Problem reported by Steen Rønnow at Weblate. Change-Id: I7f0dd381e36d0349d83d2db3f774a8cc86487a2d
2020-03-12Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 42797a6bc9f90ab9bfa4818bc1344f52125d2afa - tdf#128494 Change Spellcheck to Spelling 1098fba99acb8c8cc7e87c55ece12ef175593147 left Help in a broken state. Change-Id: Ie8d8f6506a6634fefce875590fe54fa2e477c82a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90060 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-03-12Revert "loplugin:constfields in sd"Noel Grandin
This reverts commit 453879cfd8f4a8e22847043231a0929e4d50f238. Change-Id: Ic542fd6b1f09d71d8e6c9530198fe45151d75e16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90410 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Revert "loplugin:constfields in shell"Noel Grandin
This reverts commit ec7e3609917092ee00667c78ff40cd4c2f0adec1. Change-Id: I11aa028f6562f97b0d251d6b326e9aecb45d03de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Revert "loplugin:constfields in scaddins,sccomp"Noel Grandin
This reverts commit 1ab27f9ae6f32c7502884c02c2217bbdcf035c48. Change-Id: Iaf9b011201ee763aaf4d08ceedd6074bafad1c3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90409 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 6009017afc932c6949b477d809c5537457b686d6 - corrections and clarifications on help page for field Variables - correction of "Chapter by Numbering" name - add indications of when certain options appear for different options. - add "DDE Statement" (and embed explanation from "Section") - move warning to more appropriate place - <h1>, <h2>, <h3>, <warning> - add <section> and <variable> in Cross-references help page so they can be embedded for Name"into Variables page. - add <section> in Section help page about DDE to embed in Variables. - remove unnecessary spaces Change-Id: Ibbaa2d2beb482ee95d10d5e632d41603a7e152ae Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90041 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-03-12Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 4801c038bbd392c61f44d47f34c9302bc20d5931 - tdf#106668 clarify how to apply styles - reorganize page to separate information about applying styles from information about the Styles deck - clarify how to apply Character and Paragraph Styles - move links about the updating, loading, new style commands from under the descriptions to the titles of the commands - remove heading and description "Applied Styles" (because not relevant to this page) - add information about predefined shortcuts for applying styles. - change information about Styles toolbar into a <tip> and update the toolbar name. - add link about docking/hiding windows to related topics Change-Id: I24aef3b7f632097f201545c54f7080645f767317 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90285 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-12Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' to 695f6b4be016b252315f213421331680cbaaaa8c - Fixing an uppercase typo + superfluous whitespace + small reformatting of the source file Change-Id: I1ceca55968f7e4918804c86c4c35a4407828331c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88021 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-03-12Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' to 0c44674c45452bafc67388bf333d01a632988ca3 - Small whitespace issue Change-Id: Ifc63c363932cb3749d7f99754f94b252a495de62 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88038 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-12Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' to a8013ec6c4bc8f02286987dfdb4372ea33a430a4 - Mainly whitespace fixes + visibility improvements Change-Id: I82f31ebdbae945ab823154242480930958707fb9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88095 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-12android: Fix 32bit build.Jan Holesovsky
Change-Id: Ife6740860cd7e1844b1ff0166694652538048a44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90411 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-03-12tdf#130208 use TableCellBackgroundColor instead of BackgroundColorandreas kainz
Change-Id: I2f1d5fdf976f9e787d64098a091022182156e401 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90408 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-03-12Survive missing <Eras> elementEike Rathke
Change-Id: Ic7e609ebac10921b4891877802892fe2cde9ecbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90406 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-12tdf#131297 Add Sundanese [sun-ID] to language listEike Rathke
Change-Id: I2935811e1fb3bc13cb61a849aeaf9e628a55cdf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90383 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-12tdf#124424 Corrections at SvgGradientHelper for EMF+Armin Le Grand
Change-Id: Ibda3568887de5df2bc45a9bc8cb424ba7658a768 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90382 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-03-12rework Skia setupLuboš Luňák
Calls to SkiaHelper::isVCLSkiaEnabled() may be done from many places, even if LO uses a VCL plugin that doesn't use Skia, which leads to the Skia code not being prepared properly (and crashing/asserting). So make the SalInstance of those relevant VCL plugins call a setup function that is required for Skia actually getting enabled. Avoids crashes/asserts in the About dialog if the Skia UI checkbox is enabled but e.g. the KF5 VCL plugin is actually used. Change-Id: Ib56a5f32e88bd130a4c564031313f85e99898ba7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90376 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-12Resolves: tdf#126366 revert use of SfxDispatcher::LockCaolán McNamara
Revert "tdf#121607 defer other requests until password dialog is dismissed" This reverts commit 205aeffda1a29865576fb865f23dfb6761ebfab1 as far as I can see the original problem doesn't reappear anyway Change-Id: If5fd3383f3473662bc87a367fad2c1febe1c6a23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90375 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-12typo: SIP_SA_GRAD -> SIP_SA_GLOWAndras Timar
Change-Id: I4d94824108e4e5b3432f7d152c36f2f0933f9205 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89972 Tested-by: Jenkins Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-12comparison operators should be constNoel Grandin
Change-Id: Ifa76e004128223460945d58d1c59c4e23db0f108 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90370 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12tdf#130977 replace `rtl::math::isFinite` with `std::isfinite`.Yukio Siraichi
- make all calls look like `std::isfinite`. - change the comments referring `rtl::math::isFinite`. Change-Id: I0cde9ceb9f20150467b454cddde5e62003cfde1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90234 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-12tdf#83901: move UItest to CppunitTestXisco Fauli
Change-Id: I0d074da097912f8abba6bae6171596076d71e998 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90345 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-12Revert "loplugin:constfields in sdext"Noel Grandin
This reverts commit 565746cf861c407ae222b2284d8525b4e9a62d94. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: I3c98d9a3049b581fe10113708b13d483c5bd85e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90369 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Revert "loplugin:constfields in scripting"Noel Grandin
This reverts commit 383a4f883d4a2932167695c761611b998f773f0e. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: I9fc04024b12a977481d010950244cff05e18bd74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90368 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Revert "loplugin:constfields in reportdesign,sal,sax"Noel Grandin
This reverts commit d4d37662b090cb237585156a47cd8e1f1cbe2656. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: Idef4937b89a83d2efbfaf0ab87d059a0143c0164 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90364 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12tdf#123116 sw layout: allow rows larger than page to split anywayJustin Luth
Even if the row is set to not allow splitting across pages, ignore that setting if the row is too big to fit on a single page. Don't worry too much about compatibility, because there is no sensible reason why anyone would have hidden content like this intentionally. An oversized row has always moved to start a new page. While that may not strictly be necessary anymore, to approximate a bit of backward compatibility, continue to do that. MS Word will do the same... Word, prior to 2013, always tries to keep the whole row on one page. In 2013 (compatibleMode == 15), native documents will be treated like this patch. So, although this patch throws away senseless compatibility with existing documents, it is interoperable with anything authored by Word >= 2013. Word 2013/2016 also opens .odt files this way. HOWEVER, LO authored .docx files do not set compatibleMode=15, so Word will treat them the old way - hiding all the content on a single page. Change-Id: I306e22230ed6fe21f6b66700ffd7615678859f5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90005 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-12writerfilter: extract before/afterPopState() from popState()Miklos Vajna
This function was a 1365 lines monster. Ideally it would be a one-liner, just popping the parser stack. In reality the RTF format has lots of exceptions where the state leaks outside the current push/pop boundaries. Move this large list of special cases to separate functions. Change-Id: Ib6c729c5eccbcd361852f5bbc0539fd51315f86d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90349 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-12tdf#95854 Same shortcut for insert and edit commentMaxim Monastirsky
But at the same time keep them as two separate commands for tdf#84153. The idea is to define a global shortcut for the insert command (it's the same shortcut in all modules anyway), and then override it as a Calc-specific shortcut for the edit command. As a result, both menu (or context menu) items will show the same shortcut, but what will be actually executed by the shortcut is the edit command (as module specific commands have higher priority). This would work, as both commands share the same execution code. The only problem is that the edit command is disabled when the cell doesn't have a comment, and so can't be executed. Solve that by setting the FastCall sdi property on it (and reuse this general solution for the lok case too). Change-Id: I8a7280edb2aad7016ca31c63ca778b98fef85365 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90354 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-03-12tdf#131258 DOCX: fix table styles in empty tablesLászló Németh
Pending paragraphs were disposed before table processing, so empty tables have left out of the rewritten table style preference handling, resulting for example different cell heights. Regression from commit 4d5c0eaf3e0d3d3bcd9e691fffee19b75f3d6631 (tdf#118812 DOCX import: fix table style preference – part 2). Change-Id: I5d5d29f37c8198484e24519ced5a50458c923064 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90347 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-12Revert "loplugin:constfields in package..registry"Noel Grandin
This reverts commit 31138ff7729cbf179079a5e635d3a823e2971f08. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: I3f1ae65532f441c8be5ebca5866b8a1e1c69318c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90363 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Resolves tdf#99675: Add BPMN images to the galleryandreas kainz
Sources provided at the bugzilla ticket Change-Id: Ibef652980f307272278722d85322db81d3682c0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/77480 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-03-12Revert "loplugin:constfields in sc"Noel Grandin
This reverts commit fb1d3b580763a333bbbfe115d09e1b5cd8849675. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: Ib48334ffbeb2c768896dd8ced6818aa0b9910b0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90333 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Revert "loplugin:constfields in oox"Noel Grandin
This reverts commit a84e3df74eecc8778e3d5be5dd80ad4ddb511edf. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: I7b45b7ead281cf3a9202ca6aabc55ee5033e5331 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90332 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-11Blind fix for Android Tinderbox buildMichael Weghorn
... which failed as follows, which looks related to commit 6d9a31a58c2b55c0caef10c8bbb3d75147c2476f ("android: Use the best speed compression as on iOS"), s. [1] for full log: 12883 [build CXX] vcl/source/pdf/XmpMetadata.cxx 12884 In file included from /home/android/lo/master-android-arm/vcl/source/filter/graphicfilter.cxx:24: 12885 In file included from /home/android/lo/master-android-arm/include/comphelper/processfactory.hxx:23: 12886 In file included from /home/android/lo/master-android-arm/include/com/sun/star/uno/Reference.hxx:28: 12887 In file included from /home/android/lo/master-android-arm/workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/uno/RuntimeException.hpp:8: 12888 In file included from /home/android/lo/master-android-arm/workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/uno/Exception.hpp:8: 12889 In file included from /home/android/lo/master-android-arm/workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/uno/XInterface.hpp:6: 12890 In file included from /home/android/lo/master-android-arm/workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/uno/XInterface.hdl:6: 12891 In file included from /home/android/lo/master-android-arm/include/com/sun/star/uno/Any.h:29: 12892 NEXT /home/android/lo/master-android-arm/include/cppu/unotype.hxx:296:16: error: no matching function for call to ´cppu_detail_getUnoType´ 12893 return cppu_detail_getUnoType(static_cast< T1 * >(0)); 12894 ^~~~~~~~~~~~~~~~~~~~~~ 12895 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:321:34: note: in instantiation of member function ´cppu::UnoType<int>::get´ requested here 12896 return ::cppu::UnoType< T >::get(); 12897 ^ 12898 /home/android/lo/master-android-arm/include/com/sun/star/uno/Any.hxx:276:34: note: in instantiation of function template specialization ´cppu::getTypeFavourUnsigned<int>´ requested here 12899 const Type & rType = ::cppu::getTypeFavourUnsigned(&value); 12900 ^ 12901 /home/android/lo/master-android-arm/vcl/source/filter/graphicfilter.cxx:2216:60: note: in instantiation of function template specialization ´com::sun::star::uno::operator<<=<int>´ requested here 12902 aFilterData[aFilterData.getLength() - 1].Value <<= 1; 12903 ^ 12904 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:120:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::cppu::UnoVoidType *´ for 1st argument 12905 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::cppu::UnoVoidType const *) { 12906 ^ 12907 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:125:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const bool *´ for 1st argument 12908 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER bool const *) { 12909 ^ 12910 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:130:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const sal_Bool *´ (aka ´const unsigned char *´) for 1st argument 12911 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER sal_Bool const *) { 12912 ^ 12913 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:135:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::sal_Int8 *´ (aka ´const signed char *´) for 1st argument 12914 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::sal_Int8 const *) { 12915 ^ 12916 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:140:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::sal_Int16 *´ (aka ´const short *´) for 1st argument 12917 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::sal_Int16 const *) { 12918 ^ 12919 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:145:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::cppu::UnoUnsignedShortType *´ for 1st argument 12920 cppu_detail_getUnoType( 12921 ^ 12922 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:155:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const sal_uInt16 *´ (aka ´const unsigned short *´) for 1st argument 12923 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER sal_uInt16 const *) { 12924 ^ 12925 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:161:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::sal_Int32 *´ (aka ´const long *´) for 1st argument 12926 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::sal_Int32 const *) { 12927 ^ 12928 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:166:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::sal_uInt32 *´ (aka ´const unsigned long *´) for 1st argument 12929 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::sal_uInt32 const *) { 12930 ^ 12931 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:172:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::sal_Int64 *´ (aka ´const long long *´) for 1st argument 12932 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::sal_Int64 const *) { 12933 ^ 12934 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:177:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::sal_uInt64 *´ (aka ´const unsigned long long *´) for 1st argument 12935 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::sal_uInt64 const *) { 12936 ^ 12937 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:183:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const float *´ for 1st argument 12938 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER float const *) { 12939 ^ 12940 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:188:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const double *´ for 1st argument 12941 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER double const *) { 12942 ^ 12943 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:193:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::cppu::UnoCharType *´ for 1st argument 12944 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::cppu::UnoCharType const *) { 12945 ^ 12946 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:200:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const sal_Unicode *´ (aka ´const char16_t *´) for 1st argument 12947 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER sal_Unicode const *) { 12948 ^ 12949 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:206:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const ::rtl::OUString *´ for 1st argument 12950 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER ::rtl::OUString const *) { 12951 ^ 12952 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:211:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const css::uno::Type *´ for 1st argument 12953 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER css::uno::Type const *) 12954 ^ 12955 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:217:1: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const css::uno::Any *´ for 1st argument 12956 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER css::uno::Any const *) 12957 ^ 12958 NEXT /home/android/lo/master-android-arm/include/cppu/unotype.hxx:243:31: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const css::uno::Exception *´ for 1st argument 12959 inline css::uno::Type const & cppu_detail_getUnoType( 12960 ^ 12961 /home/android/lo/master-android-arm/include/cppu/unotype.hxx:249:31: note: candidate function not viable: no known conversion from ´T1 *´ (aka ´int *´) to ´const css::uno::XInterface *´ for 1st argument 12962 inline css::uno::Type const & cppu_detail_getUnoType( 12963 ^ 12964 NEXT /home/android/lo/master-android-arm/include/cppu/unotype.hxx:223:1: note: candidate template ignored: could not match ´UnoSequenceType<type-parameter-0-0>´ against ´int´ 12965 cppu_detail_getUnoType( 12966 ^ 12967 NEXT /home/android/lo/master-android-arm/include/cppu/unotype.hxx:236:1: note: candidate template ignored: could not match ´Sequence<type-parameter-0-0>´ against ´int´ 12968 cppu_detail_getUnoType( 12969 ^ 12970 NEXT /home/android/lo/master-android-arm/include/cppu/unotype.hxx:256:1: note: candidate template ignored: could not match ´Reference<type-parameter-0-0>´ against ´int´ 12971 cppu_detail_getUnoType( 12972 ^ 12973 NEXT 1 error generated. 12974 [build CXX] vcl/source/uitest/logger.cxx [1] https://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&full-log=1583961601.24939 Change-Id: I098c21bc492f734115ae0e91f095ef542851c2ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90352 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-11tdf#89849 editeng: adjust escapement before resetting ProprJustin Luth
THIS IS A LAYOUT REGRESSION FIX FOR SUBSCRIPTS/SUPERSCRIPTS. The position of subscripts and superscripts is a percentage based on the 100% fontsize. When LO 4.1 tricked the font into thinking it was 100%, it failed to adjust the escapement to be relative to the new fake size. In the default case, this meant that the superscript was only raised about half as much as it should have. THIS CHANGE WILL AFFECT EXISTING DOCUMENTS WHERE THE TEXTBOX IS SET TO "AUTOFIT THE TEXT". This will primarily be Impress documents, since many of the templates enable autofit text. As a result of this bug, users creating new documents since 4.1 using autofit-text will have specified highly exaggerated subscript/superscript positioning in order to look nice. This fix will expose the exaggerated percentages and make the document look poor. I don't know how that can be avoided. Nor do I know how to create a unit test for a layout bug. I guess QA's PDF compare tests will suffice for this. A clearly exaggerated unit test is attached to the bug report. The new ability to have a larger-than-100% escapement in LO 6.3 comes in handy here, so that small superscripts can gain a fake escapment big enough to put them in the proper position. Change-Id: I0f8dcff8741eb05d8657235930a4eb684629b9d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89214 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-03-11android: Fix asset handling in build.gradleMichael Weghorn
... after commit 367431b6987b75e7a201499bfbd25a41c92a4a59 ("tdf#126909 android: include icons into APK") had accidently not only added the icon zip file to the 'assets/share/config' folder, but also caused the assets mentioned below in build.gradle to be copied there instead of the proper places, leading to a crash when trying to access them. (The problem did not show up in an incremental build, since "the old copies" of the assets were still present where expected.) Change-Id: I7d9cf89c399d6415ce97ac8af4a98610555c5f17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90344 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-11Sukapura: Add shadow to icons, add many more icons:rizmut
- QR code, Apply Style, Zoom 200% - Delete wrong placed SVG icons in PNG dir - Update Index Entry, Show Formatting, Toggle Extrusion, DB Sorting & Grouping - Update/add slide related icons - etc Change-Id: I29a05e1b39cee5972299f21d083021cb1ef54b62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90342 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-03-11m_sHelpRoot in weld::Builder is unusedNoel Grandin
since commit 082e69fefb7439fd4f3d543f0c402039e94c1e9c convert various MessBox to weld::MessageDialog - Change-Id: I08370632803c26ac9c47267e57c51eb56ad713f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-11tdf#114441: Convert use of sal_uLong to better integer typesBugra
Change-Id: I6b6f59a73aeda6af78fecaf4344826a943072033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90191 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-11tdf#114441 Convert use of sal_uLong to sal_uInt32AlanTang
Change-Id: Ia359a33e7cbc25764861b17372df9d1c9dbc0913 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89942 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-11Add some fallback minimum size when screen size detection goes wrongSamuel Mehrbrodt
Change-Id: I97ec2359b8ae406e310a5d043ac068ddd89b3fd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90320 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-11update creditsChristian Lohmaier
Change-Id: I90fba19d96f0fce6ca0e63c83e6dd45087f81c0a
2020-03-11android: Use the best speed compression as on iOS.Jan Holesovsky
Change-Id: Ib2be570a924c6ac6e226f47e6b183975df1fca2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90258 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 07fb148971b6853c2020cea6660fa62d6caacb85) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90281 Tested-by: Jenkins