summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-04-24clang-tidy readability-simplify-boolean-expr in hwpfilter..lotuswordproNoel Grandin
Change-Id: I945d3fe6af5f88937b341dfc3696bf1d36344862 Reviewed-on: https://gerrit.libreoffice.org/36874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-24tdf#47243 tdf#39327 Add support for SetPageTransformBartosz Kosiorek
Change-Id: Iea78cf1e9ca99c97814d9eaa4a65ad4b83a2bbe2 Reviewed-on: https://gerrit.libreoffice.org/36749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-04-24EMF+ Add initial support for EmfPlusStringFormat ObjectBartosz Kosiorek
The EmfPlusStringFormat object specifies text layout, display manipulations, and language identification. With this commit the support for font language and country was added. Also Bold style is applied, for strings which needs that. Change-Id: Id9735a9ddb959aebd20d6d4d1bb5da0fa9c1fb85 Reviewed-on: https://gerrit.libreoffice.org/36555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-04-24Indentation fixesMiklos Vajna
No functional changes intended. Change-Id: Ibc23de9cb33428765b8b0c85a221a2014ad4d7bd
2017-04-24move SwDrawFlyContract creation into CreateNewRefBjoern Michaelsen
Change-Id: Ied86e1fd9424fc28e95215e60bed95069b7b51a6 Reviewed-on: https://gerrit.libreoffice.org/36869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-04-24Updated coreStephan Bergmann
Project: help 0205b43e4d518239ff3d6b9bed0cc9317939acd9 Mac does have a "Control" key (even labeled "Ctrl" on my German MacBook keyboard, not "Strg" as the localization of "Ctrl" on German standard PC-style keyboards), and Writer's "Format - Clear Direct Formatting" (which this help item is presumably about) is indeed Ctrl+M (labeled "^M" in the menu) on macOS. So unconditionally use "Ctrl+M" here for now, notwithstanding potential Mac localization issues (see that German "Ctrl" vs "Strg" issue). This corrects 9ed1958ba7f75bb4184f09d79814849d06313d72 "I don’t think Macs have Control keys…" Change-Id: I2f62c95341fc4079686ac616965675b307a97fde
2017-04-24Updated coreAndras Timar
Project: translations ffc762723b354fb19a607df53cbb6290e1a177eb Updated Slovenian translation Change-Id: I93d35d68aa63ced0030a65bd0ad2899abaf463e9
2017-04-24tdf#107147 ignore subtotals and grandtotals when gathering labelsTomaž Vajngerl
When gathering the labels and categories for the pivot chart, ignore subtotals and grandtotals so they don't end up in the chart. Change-Id: I45e80a59531d6a048a22016132e9bef280bb325c Reviewed-on: https://gerrit.libreoffice.org/36868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-24preserve "Total" label on round-trip, remove code duplicationTomaž Vajngerl
Change-Id: Ic4e682f2193291798a3ebbf5a7f3f435d40a0645 Reviewed-on: https://gerrit.libreoffice.org/36867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-24use translated string for "Total" label in pivot chartsTomaž Vajngerl
Change-Id: Ic75224cb35c34b8be5504af1032cb326196e2306 Reviewed-on: https://gerrit.libreoffice.org/36866 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-24tools: cleanup tools/source/ref/errinf.cxxChris Sherlock
Make the code more readable, some whitespace formatting changes and changed ppDcr, etc. to clearer variable names. Change-Id: I9d0f3eec6607376b6648241cea80922f11d9773e Reviewed-on: https://gerrit.libreoffice.org/36837 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-23BASIC: Make TokenLabelInfo a singleton, never modified and simplify it.Arnaud Versini
Change-Id: Ie233aebc39f5b181087a64d3cf2053ef4ecbab91 Reviewed-on: https://gerrit.libreoffice.org/36829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-23tools: change internal DynamicErrorInfo struct nameChris Sherlock
Change of an internal struct's name in errinf.cxx - renaming EDcrData to DynamicErrorRegistry as EDcr makes very little sense to me. EDcrData is an internally used struct consisting of collections of error data, error handlers and error contexts, and uses only DynamicErrorInfo instances. Change-Id: I79d7f7db5d9550dffca6adcb2a286a2d6e1fa2e7 Reviewed-on: https://gerrit.libreoffice.org/36836 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-23Toolbars can't be nestedMaxim Monastirsky
This is not supported by framework. Change-Id: I4afde5243130e1ec1ac5c3126d755331842601e5
2017-04-23tdf#101374 Don't confuse "Label" with "Name"Maxim Monastirsky
We compare the actual label of a command with the default one, in order to determine whether the label was changed by the user. The problem is that commands that were inserted via the "Add Commands" dialog might have different label by default, because it uses the "Name" command property (from the theUICommandDescription singleton), but the customization dialog assumes usage of the "Label" property. Which means that if these properties differ for some command, it will be considered as having a modified label, and such label will be written to the user profile, and stay there even after UI language change. This commit does 2 things: - Prefer using the "Label" property for inserted commands, instead of copying the label that's shown in the "Add Commands" dialog. - Properly track whether we're using the default label or a custom one. Change-Id: I16ceb4d0bc92ad2a9f833fb09753962ad21a903b
2017-04-23Replace GetImage with CommandInfoProvider::GetImageForCommandMaxim Monastirsky
And move ToolBoxButtonSize->ImageType mapping code to a common place. Change-Id: If158f4b6f2750054fcf64491c2941706e7d3a329
2017-04-23tdf#95845 Use CommandInfoProviderMaxim Monastirsky
And a few unused theUICommandDescription includes. Change-Id: Ic80dbfb91e5e7662723efe0cb4090416994adabd
2017-04-23No usage of the private:commandimage thingMaxim Monastirsky
Change-Id: I8e5c1431f095c875cda6f66f16a03af4bbd1d1fb
2017-04-23Customization of notebookbar menu always possibleMaxim Monastirsky
i.e. even when experimental features disabled. That's the same behavior as for the notebookbar shortcuts toolbar. Change-Id: Ic87e5c8015f796f33042d1e348ea567681ae240d
2017-04-23SID_FM_CONFIG isn't executableMaxim Monastirsky
It's only used to host a toolbox controller nowadays, and has no defined execute method in the sdi file. Change-Id: I20717d25190bb15b8ecff9d3a9038b05dac86b14
2017-04-23Fix open command nameMaxim Monastirsky
Change-Id: If5768a8f624a34b721ed14039ba5d2440aaf109d
2017-04-23Fix mouse position conversion in case of BottomToTop textTamás Zolnai
Change-Id: Ib058e44a1480013ce924585d8950534d0f3fc5a4 Reviewed-on: https://gerrit.libreoffice.org/36834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-04-23Handle keyinput properly in case of BottomToTop vertical textTamás Zolnai
Change-Id: I2b0f7cee9a4a7d7ad154c705f84a8b995b4f23a1 Reviewed-on: https://gerrit.libreoffice.org/36830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-04-23Use automatic integer type, with minor simplificationsMatteo Casalin
Change-Id: I08b8370311b11d45ab744875f7ad6b885f318a74
2017-04-23OUStrings: avoid temporaries and constifyMatteo Casalin
Change-Id: Id6b4b26df09ddb750f3e5430636b41c89e4d9e8e
2017-04-23These data members can be file scope consts, and reusedMatteo Casalin
Change-Id: I977d523d6aefeb2475044783ba30744b950d3708
2017-04-23merge comphelper::ChainablePropertySet with comphelper::ChainableHelperNoStateNoel Grandin
Change-Id: I8fb93665b2a2f46019306f473882a7f3d7aece87 Reviewed-on: https://gerrit.libreoffice.org/36787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-23tdf#104610 Always enabled no-width break formatting marksYousuf Philips
Change-Id: I0708a61d43bfa44dac19683b200975e3a6da788a Reviewed-on: https://gerrit.libreoffice.org/36807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-04-23AutoText: importing docx contentSzymon Kłos
- passing "ReadGlossaries" flag to the WriterFilter - if set - WriterFilter reads glossary document instead of the main content - updated model.xml to read docParts and docPart nodes - SwDOCXReader adds document content as an AutoText entry Change-Id: I9a0cc91c793d6accc8461e1c3aca791c5997d497 Reviewed-on: https://gerrit.libreoffice.org/36753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-04-23tdf#107301: Improve non snap-to-char text rendering.Mark Hung
DrawText ingnores calculated KernArray so the text is cluttered, use DrawTextArray instead of DrawText. Change-Id: I9f7294cd6540257034ac7fcffdaff5b4f2529d8f Reviewed-on: https://gerrit.libreoffice.org/36751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-04-23simplify ChainableProperySet and MasterPropertySetNoel Grandin
bunch of methods that do nothing Change-Id: If7806018721bb101825d3489ca8e7fe70e175af4 Reviewed-on: https://gerrit.libreoffice.org/36778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-23starmath: Show underscore which does not mark a mnemonic keyTakeshi Abe
Change-Id: I119f308d59b309bf432421a50c616032f6c74e87 Reviewed-on: https://gerrit.libreoffice.org/36826 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-23starmath: Fix wrong ids in Command Menu to be inserted as commandsTakeshi Abe
Change-Id: I56343724ce8d2a2040aa2f354868a474743fb04d Reviewed-on: https://gerrit.libreoffice.org/36760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-22mark all new styles as default styles, tdf#103380, tdf#103330Markus Mohrhard
Change-Id: I0b893d61ea6c9d0fd4af9f08b0d3b2e5454e544e Reviewed-on: https://gerrit.libreoffice.org/36819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-22fix --with-tls=openssl buildCaolán McNamara
Change-Id: I10bab565a5a152755fbc38268559657b4ec539b2
2017-04-22revert bits of "remove some old MSVC workarounds"Noel Grandin
in commit 841e1a6f3619054ecc9240e061cd83d4e41d1ca9, since MSVC 2015 still does not pack heterogenous bitfields tightly Change-Id: I251c797492762cbd2381496b2f2c6c3223d563c6 Reviewed-on: https://gerrit.libreoffice.org/36800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-22fix the buildMarkus Mohrhard
Change-Id: Icb33610ba7923f86e48f3173b16fc7f0abd05344
2017-04-22tdf#107237 Add shape and frame contextual tabs to WriterYousuf Philips
Add contextual tabs to the tabbed Notebookbar implementation Change-Id: I24062aa2bb36d7ec2f47c97850cb2d48c3745fcd Reviewed-on: https://gerrit.libreoffice.org/36630 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-04-22Notebookbar: better tab placing for the NotebookbarTabControlSzymon Kłos
Change-Id: Ia44ce20455829048be457584c49fde0996f4a699 Reviewed-on: https://gerrit.libreoffice.org/36814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-04-22tdf#102132 Contextual section in its own sectionYousuf Philips
Change-Id: I40a956075181a0692e0635090b314f4a4f09fbb5 Reviewed-on: https://gerrit.libreoffice.org/36811 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-04-22sw: skip part of uiwriter/testTdf107025 if not testable.Mark Hung
The unit test is about textgrid and uses DFKAI-SB that shipped with Windows. Required font might not installed in some build environment. Not having width in the first implies that the case is not testable. Change-Id: I98f9b9f6291eea95a1b36f1890b1be903ccb26dd Reviewed-on: https://gerrit.libreoffice.org/36802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-04-22tdf#102779 Set a minimum height for Notebookbar tabsYousuf Philips
Change-Id: Ieccd9c721632c4e194afcfab53322aab315174cd Reviewed-on: https://gerrit.libreoffice.org/36810 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-04-22Don't keep gGlobalGlyphCache, gTextureCache around until exitStephan Bergmann
Those static variables had been introduced with 56c5a0ba7781a325123852737970fa7f0179ff7f "tdf#94682 limit the number of textures for the glyph texture atlas" and dea885f80a80c6a5839ee5dbf8521487186a9522 "opengl: cache native widget textures also for Windows", but at least the clang-cl build crashed on exit from soffice.bin with > Exception thrown at 0x00007FFF3906AA84 (opengl32.dll) in soffice.bin: 0xC0000005: Access violation reading location 0x0000000000000898. > opengl32.dll!glGetString() Unknown > epoxy.dll!epoxy_glGetString_dispatch_table_rewrite_ptr(unsigned int name) Line 46456 C > epoxy.dll!epoxy_glGetString_dispatch_table_thunk(unsigned int name) Line 46456 C > epoxy.dll!epoxy_is_desktop_gl() Line 299 C > epoxy.dll!gl_provider_resolver(const char * name, const gl_provider * providers, const unsigned short * entrypoints) Line 7323 C > epoxy.dll!epoxy_glDeleteTextures_resolver() Line 14646 C > epoxy.dll!epoxy_glDeleteTextures_dispatch_table_rewrite_ptr(int n, const unsigned int * textures) Line 45813 C > epoxy.dll!epoxy_glDeleteTextures_dispatch_table_thunk(int n, const unsigned int * textures) Line 45813 C > vcllo.dll!TextureState::unbindAndDelete(unsigned int nTexture) Line 59 C++ > vcllo.dll!ImplOpenGLTexture::~ImplOpenGLTexture() Line 182 C++ > [External Code] > vcllo.dll!PackedTextureAtlasManager::~PackedTextureAtlasManager() Line 129 C++ > vcllo.dll!GlobalGlyphCache::~GlobalGlyphCache() Line 67 C++ > [External Code] > vcllo.dll!??__FgGlobalGlyphCache@GlyphCache@@0V?$unique_ptr@UGlobalGlyphCache@@U?$default_delete@UGlobalGlyphCache@@@std@@@std@@A@YAXXZ() Line 48 C++ > [External Code] resp. > Exception thrown at 0x00007FFF3A5AAA84 (opengl32.dll) in soffice.bin: 0xC0000005: Access violation reading location 0x0000000000000898. > opengl32.dll!glGetString() Unknown > epoxy.dll!epoxy_glGetString_dispatch_table_rewrite_ptr(unsigned int name) Line 46456 C > epoxy.dll!epoxy_glGetString_dispatch_table_thunk(unsigned int name) Line 46456 C > epoxy.dll!epoxy_is_desktop_gl() Line 299 C > epoxy.dll!gl_provider_resolver(const char * name, const gl_provider * providers, const unsigned short * entrypoints) Line 7323 C > epoxy.dll!epoxy_glDeleteTextures_resolver() Line 14646 C > epoxy.dll!epoxy_glDeleteTextures_dispatch_table_rewrite_ptr(int n, const unsigned int * textures) Line 45813 C > epoxy.dll!epoxy_glDeleteTextures_dispatch_table_thunk(int n, const unsigned int * textures) Line 45813 C > vcllo.dll!TextureState::unbindAndDelete(unsigned int nTexture) Line 59 C++ > vcllo.dll!ImplOpenGLTexture::~ImplOpenGLTexture() Line 182 C++ > [External Code] > vcllo.dll!OpenGLTexture::~OpenGLTexture() Line 313 C++ > [External Code] > vcllo.dll!TextureCombo::~TextureCombo() Line 51 C++ > [External Code] > vcllo.dll!std::pair<ControlCacheKey, std::unique_ptr<TextureCombo, std::default_delete<TextureCombo> > >::~pair() Line 145 C++ > [External Code] > vcllo.dll!o3tl::lru_map<ControlCacheKey, std::unique_ptr<TextureCombo, std::default_delete<TextureCombo> >, ControlCacheHashFunction>::~lru_map() Line 34 C++ > vcllo.dll!??__FgTextureCache@?A@@YAXXZ() Line 738 C++ > [External Code] Change-Id: I0198f657f5d59314c5f662c214504ed3e1523567 Reviewed-on: https://gerrit.libreoffice.org/36801 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-22tdf#107277 add findbar and pagedialog icon to writerandreas kainz
Change-Id: I8a53f99ef9e614fe226ff396ee5258ab192e4c39 Reviewed-on: https://gerrit.libreoffice.org/36806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-04-22tdf#107068 add arrow to the buttons, mark if field is filteredTomaž Vajngerl
Change-Id: Iba0b4c2ce3ab84229d388a7cb2d20db1f47c0b57 Reviewed-on: https://gerrit.libreoffice.org/36738 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-22sw: fix a11y crash on double DisposeMichael Stahl
When testing with the bugdoc for tdf#107126, it happend that upon applying a page style, SwAccessibleContext::Dispose() was called twice, and that's not supposed to happen (and crashes, too, at least inside an assertion). There was an Action that queued up a bunch of events, but the Action did not complete formatting the document, so right after that during Paint more formatting happened and then the FireEvents() called Dispose() and InvalidatePosOrSize() called it again. Guess we shouldn't generate events for objects that we know are disposed due to not being visible. Change-Id: I5a0f04c0f32ee5e949b552f7a373c10ceee5c279
2017-04-22tdf#107126 sw: fix layout crash with section in footnoteMichael Stahl
SwContentFrame::WouldFit_() contains a hack to temporarily reparent a SwTextFrame. In the bugdoc, there is a SwTextFrame below a SwSectionFrame below a SwFootnoteFrame. The reparenting ignores the SwSectionFrame so the result is a SwTextFrame below SwFootnoteFrame, but it still has its mbInfSct set, hence crashes with a null pointer. If the SwTextFrame is permanently moved later on, in SwFlowFrame::MoveBwd() line 2450 a new SwSectionFrame is created. Change-Id: I45a7ab793b4459e551bd11b7fb83dedc58a6c8da
2017-04-21add test for generic digest classMarkus Mohrhard
Change-Id: Ibe3f033ebec5f832eee7420013c7083ab224e65e Reviewed-on: https://gerrit.libreoffice.org/36791 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-21add generic digest classMarkus Mohrhard
Change-Id: Ic5d2d8fbb0bb4edc4c966e185be81f6ca673950e Reviewed-on: https://gerrit.libreoffice.org/36790 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-21[pt-PT] Autocorrect - Added 25 wordsMarco A.G.Pinto
Change-Id: I1b542baf0f78ad90caeffca2456ad0c1eaae8a70 Reviewed-on: https://gerrit.libreoffice.org/36566 Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>