summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-06OSX use font cache based glyph rect cacheJan-Marek Glogowski
Change-Id: Ia9bf718f1158c68971511688fe5af3e335d841ba Reviewed-on: https://gerrit.libreoffice.org/61386 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-06Convert ImplFontCache to use o3tl::lru_mapJan-Marek Glogowski
We still do our own cleanup of the LRU map, as we can't drop any fonts in use. Change-Id: I8ec5c6ce8f80893635621357e9085950e7010f5b Reviewed-on: https://gerrit.libreoffice.org/61455 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-06tdf#119829 use font cache based glyph rect cacheJan-Marek Glogowski
The current glyph cache on Windows didn't work for multiple fonts and had to be manually invalidated on font change. The new glyph rect cache is coupled to the font cache and will invalidate all cached glyph rects, if a cached font is released. So switch to the new cache on Windows. Change-Id: Ic641f78e2e664dc0ad52e595d5fdfb6ef611eb3f Reviewed-on: https://gerrit.libreoffice.org/61278 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-06Add a glyph-bound-rect cache to the font cacheJan-Marek Glogowski
This way the font cache can correctly invalidate the cached glyph rects when a font is dropped from the cache. Change-Id: I050866099742334f01cac1b872228a017ddb5e9b Reviewed-on: https://gerrit.libreoffice.org/61371 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-06Use range-based loopMike Kaganski
Change-Id: I5c1233f53ca5c9f4322ecf7a832880399d6fec5e Reviewed-on: https://gerrit.libreoffice.org/61463 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-06try to fix SvtBroadcaster on macOSNoel Grandin
this reverts commit a20ec3b5cd691ae18f0d87d045673ce3a06579c6 fix iterator invalidation assert and commit 4a290888580474f9542f185091bb2a6fcf4e9a53 SvtBroadcaster unify the normal and PrepareForDestruction paths no idea what is going on, I suspect that std::vector is re-allocating its data buffer despite having called reserve() Change-Id: I681ae5fca4578240a2a0dc0af51ff06d919f9099 Reviewed-on: https://gerrit.libreoffice.org/61464 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-06introduce SdrObjectUniquePtr typedefNoel Grandin
Change-Id: I00106a7be04d473e2ee60ef6165bebc4148f954b Reviewed-on: https://gerrit.libreoffice.org/61438 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-06use more std::unique_ptr in ScUndoMoveTab and ScUndoCopyTabNoel Grandin
Change-Id: Id69d87369d2a73b00e4ed6159047eef3135722e1 Reviewed-on: https://gerrit.libreoffice.org/61432 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-06Fix typoAndrea Gelmini
Change-Id: I822fa325d37955583a21e4d7ce2e79a4d5b02fc5 Reviewed-on: https://gerrit.libreoffice.org/61462 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-06Add GlyphCache instance to GenericUnixSalDataJan-Marek Glogowski
This gets rid of some statics and drops some duplicate code: - the X11 based GlyphCache => gone - the svp version of the GlyphCache => gone - the "normal" GlyphCache - the PrintFontManager And while at it move the implementation into its own file gendata.cxx. Change-Id: I9063139c9482f5f37285505f389cf5f32c02426b Reviewed-on: https://gerrit.libreoffice.org/61454 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-06UNX merge FreetypeManager into GlyphCacheJan-Marek Glogowski
Change-Id: I736cc60af6d0c91623a25843bd9ff8fcdd9e8e90 Reviewed-on: https://gerrit.libreoffice.org/61453 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-06Quieten compiler warningJan-Marek Glogowski
Change-Id: I96d66d09a911d393e7f618e539b9eab5c3d740f9 Reviewed-on: https://gerrit.libreoffice.org/61450 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-06WIN rename GlyphCache to OpenGLGlyphCacheJan-Marek Glogowski
The Windows-backend based GlyphCache is OpenGL specific, so reflect that by renaming it. Change-Id: I1034bfde14792f0b6a807f8e938742556a31fcfb Reviewed-on: https://gerrit.libreoffice.org/61452 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-06Extract hardcoded strings to string resource file on Android ViewerMert Tumer
Change-Id: Ie2276ac162062e7365c9605f98fe03e5011ba6cb Signed-off-by: Mert Tumer <merttumer@outlook.com> Reviewed-on: https://gerrit.libreoffice.org/60688 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-06inline GfxLink::SwapInNoel Grandin
only called from one site Change-Id: I2f8cb927df2f4f389c5d1bee19845aed5535663b Reviewed-on: https://gerrit.libreoffice.org/61437 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-06loplugin:useuniqueptr in SwHTMLPosFlyFramesNoel Grandin
and add a new method erase_extract to o3tl::sorted_vector, otherwise there is no decent way to extract an element from such a vector without freeing it. Change-Id: I769782c04a54a2d7433e8349c99134f997a54689 Reviewed-on: https://gerrit.libreoffice.org/61345 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-06use more uniqueptr in SdGlobalResourceContainerNoel Grandin
Change-Id: I2cfd478032066c7e4cd930d098a086711b99934f Reviewed-on: https://gerrit.libreoffice.org/61431 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-06lru_map: fix std::move insertJan-Marek Glogowski
After the move the std::pair is invalid. That caused invalid iterators on lookups - hard to debug... Also adds an assertion to warn if size of map and list differ. Change-Id: Ib987d47963d5e1009d64a96dcdd588a0bc27cd77 Reviewed-on: https://gerrit.libreoffice.org/61451 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-06Unit test for de-* Januar/Jänner, tdf#114927Eike Rathke
Change-Id: I8f0f3b88e172e93caca4de6d8000cb20c5af8333 Reviewed-on: https://gerrit.libreoffice.org/61428 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-06Resolves: tdf#120334 crash on ESC in position and sizeCaolán McNamara
Change-Id: I50421f01ca368ec4d074db4b0add2f08b7b3fc0d Reviewed-on: https://gerrit.libreoffice.org/61448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05Resolves: tdf#120345 wrong text model column used for line GtkComboBoxCaolán McNamara
Change-Id: I6804fea72e105b118c8ef0228ca295ddfc0b1454 Reviewed-on: https://gerrit.libreoffice.org/61427 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Update help on Help in module pages fix DTD issue Change-Id: I178683b7352e2eff3de111bbb726d2ab60a31063 Reviewed-on: https://gerrit.libreoffice.org/61429 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-10-05s/0/nullptr/Tor Lillqvist
Change-Id: Id1b75435134da830130ebe725d86ad4e273d1f06
2018-10-05WaE: unused parameterTor Lillqvist
Change-Id: I0ccdad335f0a2cd6f14a4a226590b0e1d3033244
2018-10-05Bin some ancient debug tracing stuff from TiledLibreOffice daysTor Lillqvist
Change-Id: I3928c6e9240ad28a65aeb4fecb07268f789faf67
2018-10-05SAL_WRN and SAL_INFO tweaksTor Lillqvist
Also add an assertion and some verbose debug output (in #if 0). Change-Id: If4907a682ee7359d71078f72ca2f483c80fc4a58
2018-10-05Add more vcl sources for easier breakpointingTor Lillqvist
Change-Id: I3dccdd3253bf6e3e451b9ed53786eefaa02d451e
2018-10-05We should call pDevice->SetBackground(Wallpaper(COL_TRANSPARENT)) also on iOSTor Lillqvist
Change-Id: Id42d3b84ab97ec1efd9551e4d9cc5fd16ab77c80
2018-10-05Use LOK_FEATURE_NO_TILED_ANNOTATIONS here, like in OnlineTor Lillqvist
Change-Id: Ib34b83bc14f17dbb2bf3e89140edb734697710a8
2018-10-05Add sources in vcl/headless for easier breakpointingTor Lillqvist
Change-Id: I02c73c040eafd77628d94f6045c48f02b650f8d6
2018-10-05Add more source files from vcl for breakpointing convenienceTor Lillqvist
Change-Id: I61b030d277a7fbcc1fd714b3edafc7922c59483a
2018-10-05Don't disable dbgutil here, let the developer choose in their autogen.inputTor Lillqvist
Change-Id: If6149dce7a0467a73720e9ea40e54705518f3316
2018-10-05Call also initializeForRendering() and registerCallback()Tor Lillqvist
... to make the LibreOfficeKit usage more like a real app, to make sure that calling these doesn't cause any change in behaviour. (It didn't, as far as I could see.) Change-Id: Idded20c06031b46d5194ffeeb17309f2dbcdbaac
2018-10-05Add files from vcl/quartz for easy breakpointingTor Lillqvist
Change-Id: Iccf4b7156677c6db7e675b2c7a6926d8395d025a
2018-10-05Call SetOutputSizePixel() in the iOS case, tooTor Lillqvist
Change-Id: I844901f38ec1d93f4183e0678741fecdc7636139
2018-10-05OUString::fromUtf8() instead of createFromAscii()Eike Rathke
So we can use UTF-8 input to test. Change-Id: Ie56d43226c8cc8a5bf10317961fa0a91d8acfcf0
2018-10-05Fix typoAndrea Gelmini
Change-Id: Ia555369ae5dd530e5c0fdb4122071eff262059f1 Reviewed-on: https://gerrit.libreoffice.org/61418 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-05give SvFilterOptionsDialog a proper parentCaolán McNamara
Change-Id: Ie6545844546dc78d14e1fabdf28f4e1938cf2dd4 Reviewed-on: https://gerrit.libreoffice.org/61413 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05weld ExportDialogCaolán McNamara
Change-Id: I9d0f21a10708edcc7f5da14f83944da58c33b1d9 Reviewed-on: https://gerrit.libreoffice.org/61408 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05elementary: Add 32px size for symbolshape,arrowshape and flowchartshapeRizal Muttaqin
Change-Id: Ie6545844546dc78d14e1fabdf28f4e1938cf2dd5 Reviewed-on: https://gerrit.libreoffice.org/61414 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-05Remove references to java classesSamuel Mehrbrodt
Change-Id: I040d6b597d7f947b6ee19cefc19b21cf7a55fa71 Reviewed-on: https://gerrit.libreoffice.org/61425 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-05Resolves: tdf#114927 recognize both Januar and Jänner in de-* German localesEike Rathke
Change-Id: Ifcf087a8a20a1cdc460bd2caf6d1ceb528792e0d Reviewed-on: https://gerrit.libreoffice.org/61415 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-05loplugin:useuniqueptr look for deleting in loops with iteratorsNoel Grandin
Change-Id: I0e5bf671ee11265c0afa8770430ec9e064e05fe3 Reviewed-on: https://gerrit.libreoffice.org/61402 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05Fix typoAndrea Gelmini
Change-Id: Ic491b7f63726abe25acb61c619c15967e496094d Reviewed-on: https://gerrit.libreoffice.org/61422 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-05bodge up a workaround for GtkComboBox menus not appearing under waylandCaolán McNamara
when the menu is too tall to fit and the active entry is sufficiently far down the menu that the problem gets triggered. i.e. https://gitlab.gnome.org/GNOME/gtk/issues/94 as a workaround set wrap to 1, which is good enough to make GtkComboBox take an alternative path to the one which sets the problematic rect-anchor-dy value and the menu will at least appear Change-Id: Ia05887e0db727b7e1045179e36d348d22228a0ce Reviewed-on: https://gerrit.libreoffice.org/61416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05tdf#120022 SVG Colibre icon is broken in web browserandreas kainz
Change-Id: I0dc2594371f6d11e6ba1f02de7d70bdde3af9957 Reviewed-on: https://gerrit.libreoffice.org/61409 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-05tdf#85850 Pass CTRL+F5 event in sidebar to parent classesJim Raykowski
Change-Id: I86e1fba17402d0a5f06d7942cf0733b0f2c924ba Reviewed-on: https://gerrit.libreoffice.org/61276 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-05fix iterator invalidation assertNoel Grandin
which only recent versions of MSVC (from 15.8.6) seem to spot. It resulted in PythonTest_sw_python failures with "vector iterators incompatible" assertion on the dest != maDestructedListeners.end() check ever since commit 4a290888580474f9542f185091bb2a6fcf4e9a53 Date: Mon Oct 1 14:31:00 2018 +0200 SvtBroadcaster unify the normal and PrepareForDestruction paths Although this code appears to always have been wrong, it is just that it is being hit much more often now. Change-Id: I45d4f2ceef4ddf19c205702645a41363eea93f21 Reviewed-on: https://gerrit.libreoffice.org/61397 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05Related: tdf#120287 sw layout, TabOverMargin: fix too wide tab portionMiklos Vajna
What happened is: - the paragraph was split into two lines, at the correct position - but then the first line checked how wide the tab portion can be, and there it concluded that it has a lot of space, so the tab portion was 1418 twips wide, instead of the expected "almost zero" 69 The root of the problem was that first the text break was determined using the TabOverMargin rules (more horizontal space), but later a check validated the result ignoring the TabOverMargin flag (less horizontal space). Fix this inconsistency by using GetLineWidth() in SwTextPortion::Format_() instead of manual calculation. Change-Id: Iaa7144341dfeaa8d177716dd87165598f11fd573 Reviewed-on: https://gerrit.libreoffice.org/61403 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-05Record external/gpgmepp/version.patch as sent upstreamStephan Bergmann
Change-Id: Ibc0dc42f3df8c5a4acc1ccece5a4ef63bd04fd39 Reviewed-on: https://gerrit.libreoffice.org/61405 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>