summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-08sw: prefix members of SwUndoTableNdsChgMiklos Vajna
Change-Id: I70c6a0c9ff6306ba3c703028a732626fd92ad378 Reviewed-on: https://gerrit.libreoffice.org/61515 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-08loplugin:constfields in starmathNoel Grandin
Change-Id: I5092401b4138ca15e93b36adf1b059e75d4e8f5a Reviewed-on: https://gerrit.libreoffice.org/61514 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08loplugin:constfields in stoc..svgioNoel Grandin
Change-Id: Icfd936fe9b83e0e122af5b09f7ed6dde2ead4400 Reviewed-on: https://gerrit.libreoffice.org/61512 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08Fix for --enable-debug --disable-assert-always-abortStephan Bergmann
...found by <https://ci.libreoffice.org//job/lo_tb_random_config_linux/1522/> Change-Id: I9087d54f783e1ab51029704aa34eed16dc14605d Reviewed-on: https://gerrit.libreoffice.org/61513 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-08sc: speed-up: no usage of temp strings objectsSerge Krot
Change-Id: I7d9812672e4cbefd7e422b5c70b54ee3ea50df2d Reviewed-on: https://gerrit.libreoffice.org/61446 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-08loplugin:constfields in svlNoel Grandin
Change-Id: I18183c5c257cbe69bd067d4e74c50483ae683cf3 Reviewed-on: https://gerrit.libreoffice.org/61509 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08weld ScTPValidationErrorCaolán McNamara
Change-Id: Iaea475dc1037ed070ab2ff61be647f345d39ae3c Reviewed-on: https://gerrit.libreoffice.org/61501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-08weld ScTPValidationHelpCaolán McNamara
Change-Id: I7bf8219bfef8f6e7d765b2a9f1240f364418cbc2 Reviewed-on: https://gerrit.libreoffice.org/61500 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-08weld ScTpSubTotalOptionsCaolán McNamara
Change-Id: Id147ae786c8c93939acff8a97c4167f99451f364 Reviewed-on: https://gerrit.libreoffice.org/61499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-08weld ORptPageDialogCaolán McNamara
Change-Id: I96bd38046e527c76782504edd408df1aee490e37 Reviewed-on: https://gerrit.libreoffice.org/61498 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-08l10ntools: remove unused srclexAndras Timar
Change-Id: I464309a2409485b34bd9662372bedd897b41e474 Reviewed-on: https://gerrit.libreoffice.org/61490 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-10-08Modernize personas under-the-hood - The searchMuhammet Kara
* Upgrade the used mozilla API from v1.5 to v3 * Ditch Neon for curl * Get rid of the get-HTML-then-search-within craziness It is much faster and smarter now: * Fetches the search results at once in JSON format, instead of repetitively making http calls for each persona, and relying on an ever-changing HTML design * Doesn't redownload and overwrite files each time, so it is much faster for the second time of the same search query This patch handles the search part. A follow-up patch will handle the apply part. Change-Id: I703fc7b510799e8c205566cf5ffad2a81f12c4ea Reviewed-on: https://gerrit.libreoffice.org/61449 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-10-08loplugin:external (--enable-gtk3-kde5)Stephan Bergmann
Change-Id: Id096bd25cd6df5941eaec45f7573f5887ae51d79
2018-10-08tdf#120261 gtk3_kde5: Leave event handling on gtk3 side to gtkMichael Weghorn
This introduces a new thread that takes care of handling the IPC command and result for executing the file picker ('Commands::Execute'), which is the only command in the file picker that may block for a longer time until it receives its result from the kde5 side (namely, when the dialog has been closed). While the file dialog is being executed, activate a dummy GTK dialog that also takes care of handling events in its main loop as long as the file dialog is shown. The dummy dialog is closed together with the KDE file dialog. (Since the actual KDE file dialog is run as a separate process, this one is mostly "transparent" to the soffice process from the point of view of a dialog.) This allows dropping the custom event processing previously done in 'Gtk3KDE5FilePickerIpc::readResponse()' that had the potential to cause all kinds of problems, e.g. when another event related to the file picker was triggered from a Java process via UNO. Change-Id: I3d663253f09320f7a8e0d9ec32a8fd6ec191c189 Reviewed-on: https://gerrit.libreoffice.org/61253 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-10-08tdf#120261 gtk3_kde5: Read IPC cmds in own thread on kde5 sideMichael Weghorn
Move reading IPC commands and arguments to those commands to a separate thread and use the signal/slot mechanism to notify 'FilePickerIpc' whenever a new command and its arguments have been read. This allows to handle the events of other commands that have been received while the dialog is being executed. This will be needed by a subsequent change that will modify how IPC is handled on the gtk3 side. Change-Id: Ia77b21045b0196710cbe164fb640b36a128d5081 Reviewed-on: https://gerrit.libreoffice.org/61252 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-10-08tdf#119266: Nodes don't expand on double click in the Customize dialogMuhammet Kara
Change-Id: I8b6667dc631df2fd38a8a2d99668b4a2336801b6 Reviewed-on: https://gerrit.libreoffice.org/61504 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-10-08Qt5AccessibleWidget: Add stub for QAccessibleTextInterfaceSamuel Mehrbrodt
Change-Id: Iee80b40d2c33a0464abfc285360e76774c644b32 Reviewed-on: https://gerrit.libreoffice.org/61372 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-08loplugin:constfields in svxNoel Grandin
Change-Id: I643e8686e015ca85dd96221f1c93038f4fddf27b Reviewed-on: https://gerrit.libreoffice.org/61182 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08return by unique_ptr from E3dObject::GetBreakObjNoel Grandin
Change-Id: Id983695650b13b2cb7881ce17a186e35fbb480ef Reviewed-on: https://gerrit.libreoffice.org/61441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08return by unique_ptr from CreateDefaultObject in sd/Noel Grandin
Change-Id: I6e103ef4b858ceb0d350069f523cb3cb670fe95b Reviewed-on: https://gerrit.libreoffice.org/61440 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08tdf#99678 Show style in common template dialog tree box immediatlyJim Raykowski
...after creation using New Style dialog Change-Id: Idb24f537fe7be2dfb9660a1a5de0bcd26612affc Reviewed-on: https://gerrit.libreoffice.org/59914 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-10-07move com_sun_star_comp_Writer_RtfExport_get_implementation to writerCaolán McNamara
Change-Id: I039d416adc23722740125c5f0845e79c47505f03 Reviewed-on: https://gerrit.libreoffice.org/61503 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-07tdf#120152: fix adding labels in reportdesignJulien Nabet
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=4b4942224b550235da228655677b5c068a053254 Change-Id: I7935f11e82410574e64cf3d50ea4e2e3791f0487 Reviewed-on: https://gerrit.libreoffice.org/61146 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-07drop unnecessary includesCaolán McNamara
Change-Id: I0a873ecc812f229d972f18370ff06c02f521fedb Reviewed-on: https://gerrit.libreoffice.org/61484 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-07weld FontworkCharacterSpacingDialogCaolán McNamara
Change-Id: I847c705ae486f9c83877ff3092ebf904e9332e63 Reviewed-on: https://gerrit.libreoffice.org/61483 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-07weld ListSelectionDialogCaolán McNamara
Change-Id: Id2aaec88bd864167e0815ddb675c27b10331247f Reviewed-on: https://gerrit.libreoffice.org/61482 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-07weld NewDataTypeDialogCaolán McNamara
Change-Id: Ice5146e72baba397e60fbcb8d64d1ddaeb32e45c Reviewed-on: https://gerrit.libreoffice.org/61481 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-07weld OPageNumberDialogCaolán McNamara
Change-Id: I074dade23767e48bc1e0e311629ed4c0b55c1a00 Reviewed-on: https://gerrit.libreoffice.org/61480 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-07unused Dialog field in FuPoorCaolán McNamara
Change-Id: Ic8ff613f7de37476054874f60bc83666d4cf404c Reviewed-on: https://gerrit.libreoffice.org/61479 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-07tdf#120151: fix crash in edit reportJulien Nabet
Change-Id: I5ac7960233b615a3dd163cf1ab8355753948240e Reviewed-on: https://gerrit.libreoffice.org/61152 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-07use more unique_ptr in SmParserNoel Grandin
Change-Id: I132598f5829e02664040dff745011a59c6a19c1d Reviewed-on: https://gerrit.libreoffice.org/61401 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-07flatten some impls in SvxBackgroundTabPageNoel Grandin
having not one, but two separate impl classes and then a whole bunch of data members? Change-Id: Icd2d4017015d277b55770aea1495366401008ed9 Reviewed-on: https://gerrit.libreoffice.org/61443 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-07Resolves: tdf#73081 empty <> not-empty is also a match if numericEike Rathke
This simplifies to match empty for the same conditions whether numeric or not, an empty string does not result in numeric 0 here. Change-Id: I923a3e1f07dd2691d3ac720fc28ba76986fe6c3d Reviewed-on: https://gerrit.libreoffice.org/61486 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-07Fix typosAndrea Gelmini
Change-Id: Ia26896cbcd8912f7cad641ea2ecf14c4ddf2d741 Reviewed-on: https://gerrit.libreoffice.org/61489 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-07tdf#120317 Set control layer name if not defaultRegina Henschel
In commit a9ec212c1b545d745285f0ab3119a80713b1d1f2 the internal default name of the layer, which holds form controls, was changed to controls, the same name as used in file format and UNO. Users of the class SdrLayerAdmin have to set the control layer name explicitly in case they want an own, different name. Change-Id: Ia08a85a4d01a75ee2c5115da25b2a409204ccc01 Reviewed-on: https://gerrit.libreoffice.org/61447 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-10-07-Werror=catch-value=Julien Nabet
Change-Id: I58563735e6cf5004b4ac5e846885414f0c603f4c Reviewed-on: https://gerrit.libreoffice.org/61491 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-07use std::unique_ptr in SvxBackgroundTable_Impl and SvxBackgroundPage_ImplNoel Grandin
Change-Id: I823e4ab434ac41865c8faf513769f7a985c199ea Reviewed-on: https://gerrit.libreoffice.org/61442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-07use more std::unique_ptr in ScCheckListMenuWindowNoel Grandin
Change-Id: Ia63d663204af570fb0e7faa46e4925c2787fc59b Reviewed-on: https://gerrit.libreoffice.org/61433 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-07tdf#119900 Fix Navigator Content Navigation View Headings focusJim Raykowski
Change-Id: I884ae9d1f13646782f56a982d3d8dc0bc3aacee0 Reviewed-on: https://gerrit.libreoffice.org/60906 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-10-06drop some now unnecessary includesCaolán McNamara
Change-Id: Idb41ddc0ff01333bac6cfce8bdd5e80c3c101de9 Reviewed-on: https://gerrit.libreoffice.org/61478 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06weld ImpSWFDialogCaolán McNamara
Change-Id: I0650ab2b95eddde0337b1d65e957a58083d993bf Reviewed-on: https://gerrit.libreoffice.org/61477 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06weld FontWorkGalleryDialogCaolán McNamara
Change-Id: I6a3a2b445d6f79d0c259c69176e1b23de1ff05d3 Reviewed-on: https://gerrit.libreoffice.org/61474 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06return unique_ptr from CreateDefaultObject in sc/Noel Grandin
Change-Id: I8981050aeadc1efe907e7e9a47d18dc3c72956c2 Reviewed-on: https://gerrit.libreoffice.org/61439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-06use more std::unique_ptr in ScUndoDrawNoel Grandin
Change-Id: I4216efd74f279a0997754b75b62b2dedce09511e Reviewed-on: https://gerrit.libreoffice.org/61434 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-06weld SwSelGlossaryDlgCaolán McNamara
Change-Id: I8d8b4a3b7ed461275eb4af86f3fd7709bab30586 Reviewed-on: https://gerrit.libreoffice.org/61476 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06drop some now unnecessary includeCaolán McNamara
Change-Id: I9db3d9a172a41c70ed343efd76f4c7c8f88b3a3f Reviewed-on: https://gerrit.libreoffice.org/61471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06make scrollabledialog.hxx a private headerCaolán McNamara
Change-Id: I16c68436c35568867677c33f70ef48287bc9e8ac Reviewed-on: https://gerrit.libreoffice.org/61470 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06make OGenericUnoDialog take an awt::XWindowCaolán McNamara
Change-Id: I7c63397d0579306f4ade1947ce5bf9e1866bf876 Reviewed-on: https://gerrit.libreoffice.org/61469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06Support estimateUsageInBytes for SystemDependentDataArmin Le Grand
Change-Id: I6074035ed8f90e452915e9ecffdbe9363375e126 Reviewed-on: https://gerrit.libreoffice.org/61306 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-10-06UNX use font cache based glyph rect cacheJan-Marek Glogowski
Drop the special / duplicate glyph rect bound cache implementation for Freetype fonts. The GlyphCache class now looks a lot like the ImplFontCache class. The lru handling for Freetype fonts is based on the byte / memory size, including the glyth bound-rect caching. Using the new common cache is effectivly removing the bound-rects from this accounting, so the garbage collection won't free them anymore. Change-Id: Ie53226596ee2287e1059a74885f52c3d64bbccaa Reviewed-on: https://gerrit.libreoffice.org/61377 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>