summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-06-18use std::atomic rather than OSL_DOUBLE_CHECKED_LOCKING_MEMORY_BARRIERLuboš Luňák
Sources such as http://preshing.com/20130930/double-checked-locking-is-fixed-in-cpp11/ or https://en.wikipedia.org/wiki/Double-checked_locking suggest that it wasn't possible to reliably do a portable double-checked initialization before C++11. It may be true that for all platforms we support those memory barriers are in fact not needed (which seems to be the assumption behind OSL_DOUBLE_CHECKED_LOCKING_MEMORY_BARRIER being empty), and looking at the generated assembly here on x86-64 seems to confirm that, but in the worst case then this is a more chatty and standard way of writing a no-op. I don't want to use threadsafe statics or std::call_once() because ScGlobal::Clear() does cleanup, which would be non-trivial to do with these, and also some functions may not necessarily always force creation of the singleton when touching the pointer, so it can't be easily hidden behind a single function call. The need to explicitly use load() with delete (thus preventing DELETEZ) looks like a Clang bug to me. Change-Id: Id3b0ef4b273ed25a5c154f90cde090ea1f9674fb Reviewed-on: https://gerrit.libreoffice.org/55851 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-06-18add calc threads assert to a thread-unsafe functionLuboš Luňák
Change-Id: I36fcdf88c3e037b9db60f24cef3508aa9791bb35
2018-06-18Back up content.xml when migrating databaseTamas Bunth
Change-Id: I4eacbf689989d20142c04dc8fe586d0054c46350 Reviewed-on: https://gerrit.libreoffice.org/55962 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-06-18weld SfxDocumentFontsPageCaolán McNamara
Change-Id: I09bb788455053c266ce18d21055157147668263e Reviewed-on: https://gerrit.libreoffice.org/55968 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18weld SfxManageStyleSheetPageCaolán McNamara
Change-Id: I3769d294e5a5458d3172c330360f7e6207c3d1b1 Reviewed-on: https://gerrit.libreoffice.org/55961 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18tdf#107969: use proper serializer for VML in footnotes/endnotesMike Kaganski
Change-Id: Ie0e062fab0ae1a63094655cc0f6bee958b4c1087 Reviewed-on: https://gerrit.libreoffice.org/55978 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-18Fix typosAndrea Gelmini
Change-Id: I77c4c8feb12d7ed6ee4b4eaa6132a91f4e655fbc Reviewed-on: https://gerrit.libreoffice.org/55967 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-18Updated coreAndrea Gelmini
Project: help bedb482f8d914e9319c711df1c665e636fd856be Fix typos Change-Id: Idf4ffe077bd71dc8170a20df93d714e581ef02b2 Reviewed-on: https://gerrit.libreoffice.org/55963 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-06-18Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: Ibf4de00b63579aff9faf4cae657824a81c1c80dc Reviewed-on: https://gerrit.libreoffice.org/55976 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-18Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I9b79528e90426ee63dff22765ee8cfe717aa8d30 Reviewed-on: https://gerrit.libreoffice.org/55972 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-18vcl: share GfxLinkAshod Nakashian
When importing PDF as images, we store the PDF stream in the GfxLink. For large PDFs storing a copy of the full PDF with each page is overkill. For example a 10MB PDF with 200 pages will consume 2GB of memory! Change-Id: I99913514cf5c562683080bc817668095bee69427 Reviewed-on: https://gerrit.libreoffice.org/55571 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-06-17use hub.libreoffice.org for links from within LibreOfficeChristian Lohmaier
Change-Id: I01eff9b5d921787ff0c251ab8467912144577705
2018-06-17crashtesting: check nLineIdxCaolán McNamara
Change-Id: If499712955702e760524478711160194ecea47c0 Reviewed-on: https://gerrit.libreoffice.org/55954 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-17crashtesting: export of ooo24533-1.sxw to docxCaolán McNamara
a problem (I assume) since... commit d7d5fa52b03fe058759f90f489a5071a39883ed7 Date: Tue May 22 10:49:36 2018 +0200 sw_redlinehide: trivial conversions in reffld.cxx Change-Id: I4a9ec367e8a280cb56c3e0e47558da959fc14b38 Reviewed-on: https://gerrit.libreoffice.org/55956 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-17tdf#42949 Add a class declaration to include/sfx2/shell.hxxGabor Kelemen
This is necessary to not get IWYU warnings or build errors where SFX_DECL_INTERFACE is used Also remove an earlier workaround in sd Change-Id: I4cc86f7ad0c83aeaae225ee05af34fa49ba67e73 Reviewed-on: https://gerrit.libreoffice.org/55955 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-06-17weld SvxPageDescPageCaolán McNamara
Change-Id: I5e2457b51a294cbdacc5c78db4ec0a048567b93d Reviewed-on: https://gerrit.libreoffice.org/55877 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-17Updated coreOlivier Hallot
Project: help 184324625ea1e803007b9c41ce625ae6014573f1 tdf#118187 Text for INDIRECT() in wrong place Change-Id: Ia6b37858c79940ce95467345bd96d22c8fe4737c Reviewed-on: https://gerrit.libreoffice.org/55945 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-06-17tdf#71850 delete string "case-sensitive" in function wizzard EUROCONVERTZdeněk Crhonek
Change-Id: I9ab56279c748eae1e54f4cecc799db1aee2e2601 Reviewed-on: https://gerrit.libreoffice.org/55716 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-06-17sw: Avoid unnecessary copy in SwAutoCompleteWord::GetWordsMatching()Takeshi Abe
Its sole client code in sw/source/uibase/docvw/edtwin.cxx allows the precondition that its 2nd argument rWords is empty. This also corrects the @param description of the argument. Change-Id: Icc12bc36d0d4157ed05ef10fb3c3db325c6bfaf2 Reviewed-on: https://gerrit.libreoffice.org/55943 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-17cppcheck: uselessAssignmentArgJochen Nitschke
Change-Id: I230c35a5cf1b660041fb10f6ff81e219cad6a1b1 Reviewed-on: https://gerrit.libreoffice.org/55942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-17fix packaging break after bindir handling & new iconsChristian Lohmaier
Change-Id: Ieacbf46f22d4943542ff318aa8236aacab255460
2018-06-17tdf#42949 Fix IWYU warnings in sc/inc/P*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ic46d80186b0eb69e7bd8553278ffc9043b9b4bef Reviewed-on: https://gerrit.libreoffice.org/55768 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-06-17Removed executable permission on images filesAndrea Gelmini
Change-Id: I6963b91a58bd88e7c920a96a44fc982ad4768d4b Reviewed-on: https://gerrit.libreoffice.org/54666 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-06-17Remove some cargo-cult copied dependenciesJens Carl
Change-Id: I4dba1ad747acc69abf1587a64ffdbd62eb715d4f Reviewed-on: https://gerrit.libreoffice.org/55938 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-17gtk3: Correctly mirror popovers in rtl uiMaxim Monastirsky
e.g. formula prompt or fill series in Calc. The reason is that for this particular vcl::Window, HasMirroredGraphics() != IsRTLEnabled(). Change-Id: Icd4bb2d22ba77d64c32b243d9c07745824e5e558 Reviewed-on: https://gerrit.libreoffice.org/55936 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-17Fix crash on deactivating Chart after playing aroundArmin Le Grand
Change-Id: I55fab9213d3571e9457c1a0e0d68574ab4760d1e Reviewed-on: https://gerrit.libreoffice.org/55931 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-16GraphCtrl factory no longer neededCaolán McNamara
Change-Id: I55f8280bb256c8eb298dd3550cc2a9621b2cfb4b Reviewed-on: https://gerrit.libreoffice.org/55933 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-16tdf#58941 Manipulate with font features using FontFeatureDialogTomaž Vajngerl
This adds a font feature dialog activated on the Character page, which adds a way to manipulate the available font features for the current selected font (by adding them to the font name). Change-Id: Icd0eda31b235d3cc8ef6eaee582fb78b4b346d78 Reviewed-on: https://gerrit.libreoffice.org/55894 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-16weld SvxHFPageCaolán McNamara
Change-Id: I9e39e276c64da4fca01ff79ebbb42d6f342f0379 Reviewed-on: https://gerrit.libreoffice.org/55863 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-16tdf#117415 write underline icons in colibre language translationandreas kainz
Change-Id: I675bda88a17971497da9b98d0798bee536091b49 Reviewed-on: https://gerrit.libreoffice.org/55924 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-16vcl: parser of font features included in the font nameTomaž Vajngerl
Change-Id: I7347410b4eb5e940d94c34aac4fdf344869541fa Reviewed-on: https://gerrit.libreoffice.org/55893 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-16AW080: Continued cleanups/remaps/correctionsArmin Le Grand
Change-Id: I953f29e6a8d398e00884a600d6f4ceba880489a5 Reviewed-on: https://gerrit.libreoffice.org/55913 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-06-16fix build because of the change to Reference<LogicalFontInstance>Tomaž Vajngerl
Change-Id: I97c23685d70c751dc6b365db776c4438a5f05db0
2018-06-16menubar: DataMenu is needed in bibliography tooandreas kainz
Change-Id: I8ede08755efab25e2cbbf1b8a13df8fe05c36a27 Reviewed-on: https://gerrit.libreoffice.org/55907 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-16weld SwCharURLPageCaolán McNamara
Change-Id: I5263147c2dd15e6cab5b405d1680c2a3778137a6 Reviewed-on: https://gerrit.libreoffice.org/55861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-16make drawing area transparent by defaultCaolán McNamara
Change-Id: Ib31d68ce13b74f3f92e81e09bef7eaed2d7f9708 Reviewed-on: https://gerrit.libreoffice.org/55862 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-16tdf#58941 implement retrieving font features and structuresTomaž Vajngerl
This adds the following: - Retrieving of features using HarfBuzz - Retrieving of feature definitions from graphite fonts - Adds description texts of OpenType features - Tests for retrieving features (Linux Libertine G graphite font) and making sure the features and definitions are what we expect. Change-Id: I51573fe086e59c6228cb546bbfac95ac53824c47 Reviewed-on: https://gerrit.libreoffice.org/55892 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-16tdf#42949 Fix IWYU warnings in chart2/source/model/{main,template}/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I53b8ac58e5f5a3778835e06a73b5f6e11dce4357 Reviewed-on: https://gerrit.libreoffice.org/55569 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-06-16tdf#42949 Fix IWYU warnings in sd/source/ui/inc/[dDE]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here and a bit of fallout management. Change-Id: Ie86a34f7f091525f21369f989165a56eace70513 Reviewed-on: https://gerrit.libreoffice.org/55558 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-06-16tdf#117827 Restore Synchronize labels in templateLaurent BP
Correction of de14f0487118d8ea15db54d94c44d7bd28833c82 Update Businesscard-with-logo - restore "Synchronize labels" function - restore links that need to be updated at the begining - change Tab for name and profession to center Tab - change "Sektsioon" to "Section" - change "Paneel" to "Frame" - change "Pilt" to "Image" Change-Id: If3123ed76faf1055f539dc9f47051696f3f1b40b Reviewed-on: https://gerrit.libreoffice.org/55243 Tested-by: Jenkins Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>
2018-06-16uitest Calc-statistics- ttest, ztest,ftest, chi squareZdeněk Crhonek
Change-Id: I5d4aa467c786a04f5d2a4ad6da2d021d39a0aafb Reviewed-on: https://gerrit.libreoffice.org/55868 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-06-16tdf#70838 ww8export: rotate shape vertically = swap width/heightVictor Mireyev
During import, rotation past 45 degrees swaps height and width in SvxMSDffManager::ImportShape, so exporting needs to do the same. restored from abandonment and corrected by Justin Import also adjusts TopLeft position, but position seems to generally be set by other factors on export. Prefer to have an example proof document and not just guess since it seems that position is affected by many factors. Therefore, not doing anything about the position in this commit. Change-Id: I4d67ab0e0da296956190aed3468e0c98f29795b9 Reviewed-on: https://gerrit.libreoffice.org/53902 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins
2018-06-16AW080: Cleanup of 3D Object methodsArmin Le Grand
Change-Id: I3a8247aabd2fd24b53faf9e1e8da29856dde70bf Reviewed-on: https://gerrit.libreoffice.org/55897 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-06-15menubar reportdesigner initial updateandreas kainz
Change-Id: Ic74638695cd6c6897b6a5d6f39c656105dcd69c7 Reviewed-on: https://gerrit.libreoffice.org/55867 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-15stoc: replace double-checked locking with static initializersJochen Nitschke
Change-Id: I2a36033d0377a58dc27564e903e2c7ce02696206 Reviewed-on: https://gerrit.libreoffice.org/55900 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-06-15Restore binary compatibility for ClassLoaderFactoryStephan Bergmann
As discussed in the mail thread starting at <http://mail-archives.apache.org/ mod_mbox/openoffice-dev/201806.mbox/%3c651c8fee-b467-421c-eae1-a8710f41692c @apache.org%3e> "Just a little side note on the scripting framework ...", external code that uses the Java class com.sun.star.script.framework.provider.ClassLoaderFactory stopped working because LO changed that class in binary (and compile-time) incompatible ways over time. The class is not listed at <https://api.libreoffice.org/docs/java/ref/index.html> (and neither at <http://www.openoffice.org/api/docs/java/ref/overview-summary.html>), so it was not considered part of the stable URE interface. But it is apparently used by external code, and it indeed seems to make sense that it is used by external code that implements scripting providers. (A follow-up commit should therefore mark the class as part of the stable URE interface. I keep that separate so that it is easier to backport this functional fix.) With ScriptProviderForooRexx.oxt from https://svn.code.sf.net/p/bsf4oorexx/code@r589 installed in LO, "Tools - Macros - Organize Macros - ooRexx... - My Macros - Create... - Library1 - OK - Create... - Macro1 - OK - Edit" failed due to > warn:cui.dialogs:21768:21768:cui/source/dialogs/scriptdlg.cxx:740: Caught exception trying to invoke N3com3sun4star3uno9ExceptionE msg: [jni_uno bridge error] UNO calling Java method invoke: non-UNO exception occurred: java.lang.NoSuchMethodError: com.sun.star.script.framework.provider.ClassLoaderFactory.getURLClassLoader(Lcom/sun/star/script/framework/container/ScriptMetaData;)Ljava/lang/ClassLoader; > java stack trace: > java.lang.NoSuchMethodError: com.sun.star.script.framework.provider.ClassLoaderFactory.getURLClassLoader(Lcom/sun/star/script/framework/container/ScriptMetaData;)Ljava/lang/ClassLoader; > at com.sun.star.script.framework.provider.oorexx.ScriptEditorForooRexx.edit(ScriptEditorForooRexx.java:305) > at com.sun.star.script.framework.browse.ScriptBrowseNode.invoke(ScriptBrowseNode.java:200) cae57d2e588a4b5a104171e022b00abcc1605775 "ClassLoader->URLClassLoader" (which this commit reverts) had changed the return type of the two getURLClassLoader overloads from ClassLoader to derived URLClassLoader (and ultimately only for cosmetic effect; it was leftover from a previous attempt at fixing a Coverity issue by using URLClassLoader.close(), but which is only available in Java 1.7, so the attempt had been reverted). That caused the above failure. And 68cd011c907d00493bf2bfde531c1e244819596b "java: reduce scope, make some methods private" (which this commit also reverts) had changed the second getURLClassLoader overload (which is not called in the above scenario) from public to private, which is also a binary-incompatible change. Other commits removed throws clauses, which is only a compile-time issue but not a binary-incompatible change. I left those changes in for now, but if need be they could also be reverted. Change-Id: I98f533d88c7c1580956c3c281e72a1c78fa3f56f Reviewed-on: https://gerrit.libreoffice.org/55871 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-15do not allow threading in SwInterpreter for threading-disabled tokensLuboš Luňák
If a token is not suitable for the generic threading code, it's presumably not suitable for threading with SwInterpreter either. This is possibly already handled by checks in CheckToken(), but this can't hurt, just in case a token is in CheckForThreading() but not in CheckToken(). Change-Id: Ib969a21e9021fc6debc2131dc718419c6b25d363 Reviewed-on: https://gerrit.libreoffice.org/55886 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Luboš Luňák <l.lunak@collabora.com>
2018-06-15clean up calc'c choosing between threading and OpenCLLuboš Luňák
Now there's just one place to decide what is used first, in InterpretFormulaGroup(). Place in other places now checks both threading and OpenCL, which should be cheap, but it also allows e.g. falling back from OpenCL to threading if it doesn't work out for a specific formula group. Change-Id: I0cac55197c5278174d303691c20f77b842995c84 Reviewed-on: https://gerrit.libreoffice.org/55885 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-06-15Updated coreAdolfo Jayme Barrientos
Project: help 2bb9f040c74d9e609a53f048447abe815f99fc39 Helponline: Favicon refresh Change-Id: I53e871ae17019c8eadc762ad72de75b2fb7f7177
2018-06-15Fix nan is not a member of std when building androidMert Tumer
Change-Id: I4eab47fd3358d26587e61c9f030f9ed10b067677 Reviewed-on: https://gerrit.libreoffice.org/55783 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2024-07-15 02:59:59 +0000