summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-04-08external/firebird: Avoid -fsanitize=nonnull-attributeStephan Bergmann
...during JunitTest_dbaccess_complex: > workdir/UnpackedTarball/firebird/src/jrd/../dsql/../jrd/extds/../../common/classes/fb_string.h:677:26: runtime error: null pointer passed as argument 2, which is declared to never be null > /usr/include/string.h:43:28: note: nonnull attribute specified here > #0 in Firebird::StringBase<Firebird::StringComparator>::assign(void const*, unsigned int) at workdir/UnpackedTarball/firebird/src/jrd/../dsql/../jrd/extds/../../common/classes/fb_string.h:677:4 (instdir/program/../program/libEngine12.so +0x10d8acb) > #1 in Jrd::ExecStatementNode::getString(Jrd::thread_db*, Jrd::jrd_req*, Jrd::ValueExprNode const*, Firebird::StringBase<Firebird::StringComparator>&, bool) const at workdir/UnpackedTarball/firebird/src/dsql/StmtNodes.cpp:3506:6 (instdir/program/../program/libEngine12.so +0x1a4cb95) > #2 in Jrd::ExecStatementNode::execute(Jrd::thread_db*, Jrd::jrd_req*, Jrd::StmtNode::ExeState*) const at workdir/UnpackedTarball/firebird/src/dsql/StmtNodes.cpp:3426:3 (instdir/program/../program/libEngine12.so +0x1a4b21f) > #3 in EXE_looper(Jrd::thread_db*, Jrd::jrd_req*, Jrd::StmtNode const*) at workdir/UnpackedTarball/firebird/src/jrd/exe.cpp:1292:17 (instdir/program/../program/libEngine12.so +0x129fe0f) > #4 in looper_seh(Jrd::thread_db*, Jrd::jrd_req*, Jrd::StmtNode const*) at workdir/UnpackedTarball/firebird/src/jrd/exe.cpp:1426:2 (instdir/program/../program/libEngine12.so +0x12a295c) > #5 in execute_looper(Jrd::thread_db*, Jrd::jrd_req*, Jrd::jrd_tra*, Jrd::StmtNode const*, Jrd::jrd_req::req_s) at workdir/UnpackedTarball/firebird/src/jrd/exe.cpp:1023:2 (instdir/program/../program/libEngine12.so +0x1298007) > #6 in EXE_receive(Jrd::thread_db*, Jrd::jrd_req*, unsigned short, unsigned int, unsigned char*, bool) at workdir/UnpackedTarball/firebird/src/jrd/exe.cpp:631:3 (instdir/program/../program/libEngine12.so +0x1295ffa) > #7 in JRD_receive(Jrd::thread_db*, Jrd::jrd_req*, unsigned short, unsigned int, unsigned char*) at workdir/UnpackedTarball/firebird/src/jrd/jrd.cpp:7597:2 (instdir/program/../program/libEngine12.so +0x173b736) > #8 in Jrd::DsqlDmlRequest::execute(Jrd::thread_db*, Jrd::jrd_tra**, Firebird::IMessageMetadata*, unsigned char const*, Firebird::IMessageMetadata*, unsigned char*, bool) at workdir/UnpackedTarball/firebird/src/dsql/dsql.cpp:723:3 (instdir/program/../program/libEngine12.so +0x1b61a71) > #9 in DSQL_execute(Jrd::thread_db*, Jrd::jrd_tra**, Jrd::dsql_req*, Firebird::IMessageMetadata*, unsigned char const*, Firebird::IMessageMetadata*, unsigned char*) at workdir/UnpackedTarball/firebird/src/dsql/dsql.cpp:179:11 (instdir/program/../program/libEngine12.so +0x1b53abd) > #10 in Jrd::JStatement::execute(Firebird::CheckStatusWrapper*, Firebird::ITransaction*, Firebird::IMessageMetadata*, void*, Firebird::IMessageMetadata*, void*) at workdir/UnpackedTarball/firebird/src/jrd/jrd.cpp:4446:4 (instdir/program/../program/libEngine12.so +0x1743f17) > #11 in Firebird::IStatementBaseImpl<Jrd::JStatement, Firebird::CheckStatusWrapper, Firebird::IReferenceCountedImpl<Jrd::JStatement, Firebird::CheckStatusWrapper, Firebird::Inherit<Firebird::IVersionedImpl<Jrd::JStatement, Firebird::CheckStatusWrapper, Firebird::Inherit<Firebird::IStatement> > > > >::cloopexecuteDispatcher(Firebird::IStatement*, Firebird::IStatus*, Firebird::ITransaction*, Firebird::IMessageMetadata*, void*, Firebird::IMessageMetadata*, void*) at workdir/UnpackedTarball/firebird/src/include/firebird/IdlFbInterfaces.h:8120:44 (instdir/program/../program/libEngine12.so +0x177cb46) > #12 in Firebird::ITransaction* Firebird::IStatement::execute<Firebird::CheckStatusWrapper>(Firebird::CheckStatusWrapper*, Firebird::ITransaction*, Firebird::IMessageMetadata*, void*, Firebird::IMessageMetadata*, void*) at workdir/UnpackedTarball/firebird/src/include/firebird/IdlFbInterfaces.h:1636:24 (instdir/program/../program/libfbclient.so.2 +0x386562) > #13 in Why::YStatement::execute(Firebird::CheckStatusWrapper*, Firebird::ITransaction*, Firebird::IMessageMetadata*, void*, Firebird::IMessageMetadata*, void*) at workdir/UnpackedTarball/firebird/src/yvalve/why.cpp:4345:42 (instdir/program/../program/libfbclient.so.2 +0x34ecfa) > #14 in (anonymous namespace)::IscStatement::execute(Firebird::CheckStatusWrapper*, unsigned int*, Firebird::IMessageMetadata*, unsigned char*, Firebird::IMessageMetadata*, unsigned char*) at workdir/UnpackedTarball/firebird/src/yvalve/why.cpp:1372:39 (instdir/program/../program/libfbclient.so.2 +0x337d51) > #15 in isc_dsql_execute2 at workdir/UnpackedTarball/firebird/src/yvalve/why.cpp:2279:15 (instdir/program/../program/libfbclient.so.2 +0x337096) > #16 in isc_dsql_execute at workdir/UnpackedTarball/firebird/src/yvalve/why.cpp:2235:9 (instdir/program/../program/libfbclient.so.2 +0x336707) > #17 in connectivity::firebird::OStatement::executeQuery(rtl::OUString const&) at connectivity/source/drivers/firebird/Statement.cxx:115:12 (instdir/program/../program/libfirebird_sdbclo.so +0x23e8cc) > #18 in connectivity::firebird::OStatement::execute(rtl::OUString const&) at connectivity/source/drivers/firebird/Statement.cxx:148:45 (instdir/program/../program/libfirebird_sdbclo.so +0x23ff90) > #19 in OStatement::execute(rtl::OUString const&) at dbaccess/source/core/api/statement.cxx:489:35 (instdir/program/../program/libdbalo.so +0xf5811f) > #20 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5 (instdir/program/libgcc3_uno.so +0xba96d) > #21 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13 (instdir/program/libgcc3_uno.so +0xb6855) > #22 in unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:420:13 (instdir/program/libgcc3_uno.so +0xb4663) > #23 in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const at binaryurp/source/incomingrequest.cxx:236:13 (instdir/program/libbinaryurplo.so +0x209ede) > #24 in binaryurp::IncomingRequest::execute() const at binaryurp/source/incomingrequest.cxx:79:26 (instdir/program/libbinaryurplo.so +0x205f10) > #25 in request at binaryurp/source/reader.cxx:85:9 (instdir/program/libbinaryurplo.so +0x2966d3) > #26 in cppu_threadpool::JobQueue::enter(long, bool) at cppu/source/threadpool/jobqueue.cxx:107:17 (instdir/program/libuno_cppu.so.3 +0x17e863) > #27 in cppu_threadpool::ORequestThread::run() at cppu/source/threadpool/thread.cxx:165:31 (instdir/program/libuno_cppu.so.3 +0x1977bb) > #28 in threadFunc at include/osl/thread.hxx:185:15 (instdir/program/libuno_cppu.so.3 +0x1a0347) Change-Id: I2378378caca42270edfbb432096ce6ceca042a3f Reviewed-on: https://gerrit.libreoffice.org/52582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-08While at it, combine the check for ANDROID with the ones for WNT and HAIKUTor Lillqvist
Also, order them alphabetically. Change-Id: I144331d71455c1c794d300f9a4f4e2e21fcd5e1b
2018-04-08GNU Make's filter-out is hard to useTor Lillqvist
Change-Id: I99ec6176c0876b948e35880f02d54905d26e7280
2018-04-08SQL string quoting: escape "'" character also at beginning of stringLionel Elie Mamane
Change-Id: I51db43c1a3b6d3c93a04a3419238ea286cab987e Reviewed-on: https://gerrit.libreoffice.org/52575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-04-08tdf#116772 adapt handling of LIKE conditions to cleaned up StructuredFilterLionel Elie Mamane
Change-Id: Ifc60da9a95833ee7820a0e03354fa1a8c006e136 Reviewed-on: https://gerrit.libreoffice.org/52573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-04-08this looks suspicious in light of cleaned up StructuredFilterLionel Elie Mamane
Change-Id: I88f9834403e016e849dcd6c46638626b40252cf3 Reviewed-on: https://gerrit.libreoffice.org/52574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-04-08Removed includes wich are not longer neededlinus
Change-Id: If1b6c6113f79ac892938ddca0b8d0c019fba75ba Reviewed-on: https://gerrit.libreoffice.org/52594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-08tdf#112384 sw: Allow New line as a label followed by chapter numberingNithin Kumar Padavu
reference-language also added to token list Change-Id: I32713508d3611dc2bce10b2c5abb1e1a4167bdaf Reviewed-on: https://gerrit.libreoffice.org/52561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-08Revert "Fix protection of some unnecessarily strictly protected files"Tor Lillqvist
Problem now handled already elsewhere, see 2340536cf478f95e33b718d3f69da5345fc4d2b4. This reverts commit 155086493c9e035c0568868f5ae3b3dcf3299e6f. Change-Id: I4c731d4915d51dfc84982a41f8c1c6e45dfcb796
2018-04-08Corner-case unit tests for vlookup / case sensitivity comparison.Michael Meeks
The test cases which does not match excel's output are forced marked to TRUE(pass) and have comments. Change-Id: Ie8ec3be64c004df72a2da5aeb3380cd33743d386 Reviewed-on: https://gerrit.libreoffice.org/52590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-04-08fix global-buffer-overflow found through UI testing on UBSAN jenkins jobMarkus Mohrhard
Change-Id: Ie4d81561057bb4d67fe050ca7fb82861d5d207a2 Reviewed-on: https://gerrit.libreoffice.org/52587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-04-08tdf#106062 ooxmlexport: hanging indent ? aesthetic tab : noJustin Luth
By default, LO footnote paragraph style has a hanging indent of .60cm. In LO footnotes, the footnote character starts at the hanging indent (position 0) and the footnote text "magically" starts at the left margin. MSO doesn't do any magical formatting so exporting emulates that by inserting a tab after the footnote character. However, that aethetic tab was being inserted after EVERY footnote character, regardless of whether the emulation was needed or not. That particularly caused problems when the document was originally authored by MSO, which typically has no margin or first line indent. In those cases, the document is altered by gaining undesirable extra space. Since the emulation is only of value with a hanging indent that is larger than the footnote character, only add the tab when a hanging indent exists. (Checking the size of the hanging indent could improve this even more, but measuring font size etc adds too much complexity.) The import code also knows about the fake tab and removes it. Follow-up patches will change the import to ONLY remove the fake tab if there is a hanging indent. (That is going to cause "regressions" because tabs from some previously saved documents will now show the "aesthetic tab" - just like MSO does.) Change-Id: I371da3f2b09f600f027377a36583f91b39425151 Reviewed-on: https://gerrit.libreoffice.org/52171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-08tdf#115623: EPUB export: support style:master-pageMark Hung
Change-Id: I12d04c2e346c5202274a01b1f8950e3412dc9081 Reviewed-on: https://gerrit.libreoffice.org/52081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-08Adapted one more SdrModel usageArmin Le Grand
...to be more local and make use of getting a reference now from it's soure Change-Id: I365df886fe8c489badab0fd4dcf1e9d414204577 Reviewed-on: https://gerrit.libreoffice.org/52585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-04-08tdf#45904 move java based api tests to c++ (AccessibleRelationSet)kadertarlan
Change-Id: I2d9d72bbc845acf091570df663849495619ee765 Reviewed-on: https://gerrit.libreoffice.org/24563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-04-08uitest - Calc Stable sortingZdeněk Crhonek
Change-Id: I3a32fbfab50af21a60428f534e42a51ace8c4577 Reviewed-on: https://gerrit.libreoffice.org/52583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-04-08uitest- Calc autosum; add one more test with multiselectZdeněk Crhonek
Change-Id: Ia8edc3f01d399f990a02bdd94174eae4a75e50a6 Reviewed-on: https://gerrit.libreoffice.org/52537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-04-08uitest for bug tdf#106746Zdeněk Crhonek
Change-Id: I1cfacc199c59863abf2050ae29d087ffe3907943 Reviewed-on: https://gerrit.libreoffice.org/52097 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-04-08Updated coreAdolfo Jayme Barrientos
Project: help 9c769f9b79e171a6500b4150ace3896266db9e17 Helponline: Rely on color, not thick borders, to separate content from UI Those thick borders were fugly. Give a slightly darker appearance to the sidebar and make its border fainter. Remove the pure-white background in body to make it easier on the eyes. Kill the alarming yellow (what was I thinking?). Change-Id: If236126da91df535a0bddbfbf4804c8ee655c4e1
2018-04-08Fix regressions from d727476cff29382a34103b137542e15e1aeeb4b9Julien Nabet
Calls to statusChanged may call addStatusListener or removeStatusListener so copy m_aStatusListenerVector on stack and iterate on the copy Thank you Michael for having pointed these Change-Id: I8399db84874d7f68e24c57891a9ab408e7ebef78 Reviewed-on: https://gerrit.libreoffice.org/52579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-08Show preview correctly for relative sizeKatarina Behrens
Change-Id: I847e72b3808e1c692aa70e1c1a00917ddef9cbb9 Reviewed-on: https://gerrit.libreoffice.org/52367 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-08Read and write tiled state and relative/absolute bitmap sizeKatarina Behrens
With this, things are at least rountripped correctly (open dialog and close w/ OK, no changes made) Change-Id: Ief9182f05d86ff3b2a0000abe08184fcc1e2b681 Reviewed-on: https://gerrit.libreoffice.org/52368 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-08ucb: Fix overwriting at index 7Takeshi Abe
It seems a typo at ee2ecbf89b002fa8f60316b4266b96dfca8b4591. This recovers command "insert". Change-Id: Id335799ab615c09e025badd9408aeb363200c430 Reviewed-on: https://gerrit.libreoffice.org/52552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-08Fix typoAndrea Gelmini
Change-Id: I7c9682f4cc0f04d9cc9e13c339396a6373ce15c7 Reviewed-on: https://gerrit.libreoffice.org/52556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-08Fix typoAndrea Gelmini
Change-Id: I655328122905ff70b667187937f57d23145377b1 Reviewed-on: https://gerrit.libreoffice.org/52567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-08Updated coreStanislav Horacek
Project: help 1223c55707d05cf229553040aea771748a1452a1 highlight only words shown in UI in custom colors page Change-Id: Ie2596ddf6b8c11f154d01f3902802c0b27680145 Reviewed-on: https://gerrit.libreoffice.org/52565 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-04-07Avoid -fsanitize=nullStephan Bergmann
...during CppunitTest_sd_filters_test (see below), where SfxStyleSheetBase::m_pPool has apparently been null'ed in SdStyleSheet::disposing (sd/source/core/stlsheet.cxx). Presumably introduced with dfefe448c41921f2f1e54d3f69b8b9e89031d055 "SOSAW080: Added first bunch of basic changes to helpers"; adding a "TTTT" marker on alg_'s request. Needed to change SfxStyleSheetBase::GetPool to return pointer instead of ref. > include/svl/style.hxx:142:47: runtime error: reference binding to null pointer of type 'SfxStyleSheetBasePool' > #0 in SfxStyleSheetBase::GetPool() at include/svl/style.hxx:142:40 (instdir/program/libsvxcorelo.so +0x2d7a3ed) > #1 in sdr::properties::AttributeProperties::ImpRemoveStyleSheet() at svx/source/sdr/properties/attributeproperties.cxx:136:44 (instdir/program/libsvxcorelo.so +0x2d72f40) > #2 in sdr::properties::AttributeProperties::Notify(SfxBroadcaster&, SfxHint const&) at svx/source/sdr/properties/attributeproperties.cxx:474:25 (instdir/program/libsvxcorelo.so +0x2d793ec) > #3 in sdr::properties::TextProperties::Notify(SfxBroadcaster&, SfxHint const&) at svx/source/sdr/properties/textproperties.cxx:542:34 (instdir/program/libsvxcorelo.so +0x2d631f2) > #4 in SfxBroadcaster::Broadcast(SfxHint const&) at svl/source/notify/SfxBroadcaster.cxx:49:24 (instdir/program/libsvllo.so +0xc2d628) > #5 in (anonymous namespace)::StyleSheetDisposerFunctor::Dispose(rtl::Reference<SfxStyleSheetBase>) at svl/source/items/style.cxx:804:16 (instdir/program/libsvllo.so +0x99e4ef) > #6 in svl::IndexedStyleSheets::Clear(svl::StyleSheetDisposer&) at svl/source/items/IndexedStyleSheets.cxx:202:18 (instdir/program/libsvllo.so +0x8bb852) > #7 in SfxStyleSheetBasePool::Clear() at svl/source/items/style.cxx:815:34 (instdir/program/libsvllo.so +0x9965ea) > #8 in SdStyleSheetPool::dispose() at sd/source/core/stlpool.cxx:1386:9 (instdir/program/libsdlo.so +0x25353a7) > #9 in SdrModel::~SdrModel() at svx/source/svdraw/svdmodel.cxx:275:25 (instdir/program/libsvxcorelo.so +0x323f1ad) > #10 in FmFormModel::~FmFormModel() at svx/source/form/fmmodel.cxx:94:1 (instdir/program/libsvxcorelo.so +0x465f020) > #11 in SdDrawDocument::~SdDrawDocument() at sd/source/core/drawdoc.cxx:394:1 (instdir/program/libsdlo.so +0x2324254) > #12 in SdDrawDocument::~SdDrawDocument() at sd/source/core/drawdoc.cxx:346:1 (instdir/program/libsdlo.so +0x2324445) > #13 in SdDrawDocument::~SdDrawDocument() at sd/source/core/drawdoc.cxx:346:1 (instdir/program/libsdlo.so +0x23244ce) > #14 in sd::DrawDocShell::~DrawDocShell() at sd/source/ui/docshell/docshell.cxx:200:9 (instdir/program/libsdlo.so +0x2c4bdb9) > #15 in sd::DrawDocShell::~DrawDocShell() at sd/source/ui/docshell/docshell.cxx:179:1 (instdir/program/libsdlo.so +0x2c4c4a5) > #16 in sd::DrawDocShell::~DrawDocShell() at sd/source/ui/docshell/docshell.cxx:179:1 (instdir/program/libsdlo.so +0x2c4c56e) > #17 in SvRefBase::ReleaseRef() at include/tools/ref.hxx:165:29 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x1ff01) > #18 in tools::SvRef<sd::DrawDocShell>::~SvRef() at include/tools/ref.hxx:56:36 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x1a9fc) > #19 in SdFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) at sd/qa/unit/filters-test.cxx:78:1 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x17f53) > #20 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:130:20 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x5589c) > #21 in test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:155:5 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x56519) > #22 in SdFiltersTest::testCVEs() at sd/qa/unit/filters-test.cxx:83:5 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x1839d) Change-Id: Ibf61c18738c7a204ebf2bbc85b28930481b22612 Reviewed-on: https://gerrit.libreoffice.org/52554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-07Prefix SfxStyleSheetBase::pPool memberStephan Bergmann
...just that one member; came in handy when researching a failure, and don't want to loose that improvement. Change-Id: Ia5434c4bd8131c37f93d32ce840859469ac258ef Reviewed-on: https://gerrit.libreoffice.org/52553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-07Colibre icon: add cellstyles for Calc NBandreas kainz
Change-Id: I72fb89bd7a40c0324b676fbfdc7087c023c1eb1e Reviewed-on: https://gerrit.libreoffice.org/52533 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-07add hint on how to use lldb pretty-printers form within android studioChristian Lohmaier
Change-Id: Ia028dd64c04d1de95e42ea2b89ee2bca689a2390
2018-04-07prevent crash on invalid bitmap sizeChristian Lohmaier
sometimes the width and height cannot be determined properly (and 0 in that case), and this causes IllegalArgumentException when trying to create the Bitmap Change-Id: Id001c40d0febf9e85b4db5c0318a77e1f880353a
2018-04-07assert on empty lineCaolán McNamara
Change-Id: Ifa3cccb13a3595998d4c85957a69fb7ecb047dd0 Reviewed-on: https://gerrit.libreoffice.org/52525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-07Correctly recognize tiled/stretched/other bitmap fillKatarina Behrens
Change-Id: Ib50dbfb937a6631429902592ae9bae08e58738d8 Reviewed-on: https://gerrit.libreoffice.org/52365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-07Pass full item set to bitmap tabpagesKatarina Behrens
Change-Id: I5d72b582f98538fdf5efe40bfca686dc0cdfc013 Reviewed-on: https://gerrit.libreoffice.org/52364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-07libmspub: fix build for android-arm with debug enabledChristian Lohmaier
Change-Id: I2fff80f2e4a0bd1946c9b49d46871245f93bbb3e
2018-04-07tdf#116152 android.net.Uri.encode(string) is even better...Christian Lohmaier
Change-Id: Ib779cec33de660e2c01843b76c9987aa774fba29
2018-04-07tdf#116152 fix filenames with spaces (code expects %20, not +)Christian Lohmaier
URL-encoding added by 174229e4797b27eb795c6f2451ab1349c2c29ad8 did fix filenames with #, but broke filenames with space in return. Change-Id: I7f1ac6aa79c921dfca699eb3cd8c927efba9d55c
2018-04-07uitest - writer insert caption + insert frameZdeněk Crhonek
Change-Id: I572af755aaa146a53ac77599b29aa3b6e5fc14e3 Reviewed-on: https://gerrit.libreoffice.org/47275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-04-07uitest - writer Document properties; tdf#49683; tdf#81457Zdeněk Crhonek
Change-Id: If4a202a7b8ae9be11b8f8f05e50eb3202c5c655d Reviewed-on: https://gerrit.libreoffice.org/47685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-04-07comphelper: use a lambda expression in NamedValueCollection::operator >>=()Chris Sherlock
Change-Id: Idf47f500be097c4af907c37f6ca8632cd91f3ba2 Reviewed-on: https://gerrit.libreoffice.org/52548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-07dbahsql: Add doxygen commentsTamas Bunth
Change-Id: Ie666d4d8660d29c36479c2e8a1289bd789d1433b Reviewed-on: https://gerrit.libreoffice.org/52549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-04-07dbahsql: add default for autoincremented columnsTamas Bunth
Change-Id: I8b4c99ed9e3701193228c58cc9e64dc87a03da71 Reviewed-on: https://gerrit.libreoffice.org/52550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-04-07coverity#1433782 Unintended sign extensionCaolán McNamara
Change-Id: I804d2282094ab98d0295e57f35704fab78266b7f Reviewed-on: https://gerrit.libreoffice.org/52440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-07coverity#1433794 Unintended sign extensionCaolán McNamara
Change-Id: I674991f5621bf6cf5a9cbecac936872b48fbdbcd Reviewed-on: https://gerrit.libreoffice.org/52433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-07coverity#1433788 Unintended sign extensionCaolán McNamara
Change-Id: I3d907c567157009c2b5c79c3041f3ba841639281 Reviewed-on: https://gerrit.libreoffice.org/52442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-07coverity#1433789 Unintended sign extensionCaolán McNamara
Change-Id: Idad795503eb95e6fa77e620edc46140da554e61b Reviewed-on: https://gerrit.libreoffice.org/52443 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-07weld ScLinkedAreaDlgCaolán McNamara
Change-Id: I427e5abd76f6edfa891c9186d5822173d3fa7f7e Reviewed-on: https://gerrit.libreoffice.org/52513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-07When clearing mpNumRuleTable, clear too maNumRuleMap and maListStyleListsJulien Nabet
Open a brand new file on Writer type "fn", then F3 to open formula editor console logs show: <DocumentListsManager::createListForListStyle(..)> - a list for the provided list style name already exists. Serious defect. bt: 0 0x00007fffc91ebdee in sw::DocumentListsManager::createListForListStyle(rtl::OUString const&) (this=0x55555c7e85c0, sListStyleName="Outline") at /home/julien/lo/libreoffice/sw/source/core/doc/DocumentListsManager.cxx:98 1 0x00007fffc917ad81 in SwDoc::AddNumRule(SwNumRule*) (this=0x55555c7e2ef0, pRule=0x55555c872a50) at /home/julien/lo/libreoffice/sw/source/core/doc/docnum.cxx:2142 2 0x00007fffc915b04b in SwDoc::ClearDoc() (this=0x55555c7e2ef0) at /home/julien/lo/libreoffice/sw/source/core/doc/docnew.cxx:700 3 0x00007fffc961f9dc in SwXMLTextBlocks::ClearDoc() (this=0x555558cc15b0) at /home/julien/lo/libreoffice/sw/source/core/swg/SwXMLTextBlocks.cxx:134 4 0x00007fffc96306ef in SwTextBlocks::BeginGetDoc(unsigned short) (this=0x55555bc7ba00, n=11) at /home/julien/lo/libreoffice/sw/source/core/swg/swblocks.cxx:398 5 0x00007fffc9141032 in SwDoc::InsertGlossary(SwTextBlocks&, rtl::OUString const&, SwPaM&, SwCursorShell*) (this=0x5555579631a0, rBlock=..., rEntry="fn", rPaM= SwPaM = {...}, pShell=0x555557a23cb0) at /home/julien/lo/libreoffice/sw/source/core/doc/docglos.cxx:139 6 0x00007fffc9409518 in SwEditShell::InsertGlossary(SwTextBlocks&, rtl::OUString const&) (this=0x555557a23cb0, rGlossary=..., rStr="fn") at /home/julien/lo/libreoffice/sw/source/core/edit/edglss.cxx:42 7 0x00007fffc9d4d31e in SwGlossaryHdl::Expand(rtl::OUString const&, SwGlossaries*, SwTextBlocks*) (this=0x55555bc9dbc0, rShortName="fn", pGlossaries=0x55555beb9530, pGlossary=0x55555bc7ba00) at /home/julien/lo/libreoffice/sw/source/uibase/dochdl/gloshdl.cxx:503 8 0x00007fffc9d4c93e in SwGlossaryHdl::ExpandGlossary() (this=0x55555bc9dbc0) at /home/julien/lo/libreoffice/sw/source/uibase/dochdl/gloshdl.cxx:383 9 0x00007fffc9ec3322 in SwTextShell::ExecGlossary(SfxRequest&) (this=0x555558402620, rReq=...) at /home/julien/lo/libreoffice/sw/source/uibase/shells/textglos.cxx:57 10 0x00007fffc9ec5422 in SfxStubSwTextShellExecGlossary(SfxShell*, SfxRequest&) (pShell=0x555558402620, rReq=...) at /home/julien/lo/libreoffice/workdir/SdiTarget/sw/sdi/swslots.hxx:2996 11 0x00007ffff1aa5b7a in SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) (this=0x555558402620, pFunc=0x7fffc9ec53f4 <SfxStubSwTextShellExecGlossary(SfxShell*, SfxRequest&)>, rReq=...) at /home/julien/lo/libreoffice/include/sfx2/shell.hxx:210 12 0x00007ffff1a9c4b2 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) (this=0x555557a0add0, rShell=..., rSlot=..., rReq=..., bRecord=true) at /home/julien/lo/libreoffice/sfx2/source/control/dispatch.cxx:377 Since maListStyleLists is private member, we must use getIDocumentListsAccess().deleteListForListStyle Change-Id: I8c5a80adbba29b89784a49983fc69d300300334a Reviewed-on: https://gerrit.libreoffice.org/49200 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-07dbaccess: Enable hsql migration by defaultTamas Bunth
Also make Firebird driver not experimental anymore. With hsql migration enabled, the hsqldb related unit tests can be reused, because the underlying DBMS is transparent. To achieve that, I added firebird_sdbc component to hsqldb CppunitTest_* files. This commit also contains fixes for upcoming bugs while migrating from hsqldb to firebird, shown by hsqldb related unit tests: - null values: in case of null values, the setNull method should be used instead of nothing. (malformed string otherwise) Remove DBACCESS_HSQL_MIGRATION environment variable, since migration is default from now on. JunitTest_dbaccess_complex was based on HSQLDB. This commit replaces "if exists" hsql specific solution with firebird specific. Also disable test for queries with named parameters. Change-Id: Ieb68f5ad3a11389599c4f268ea4df82a83643b82 Reviewed-on: https://gerrit.libreoffice.org/52008 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-04-07Remove fill styles that are not implementedKatarina Behrens
Anyone is free to reintroduce those styles and implement them, but as long as it doesn't work (in fact it never did) it just confuses the users by presenting functionality that is not there Change-Id: Ic4c866536a391c02e78969355c4c2fa8d20a9cec Reviewed-on: https://gerrit.libreoffice.org/52363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
generated by cgit (git 2.34.1) at 2024-07-31 11:13:34 +0000