summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-03-30Bump version to 5.3-3cp-5.3-3Andras Timar
Change-Id: I282583bc84dc8db5810095379b5fd7c33c4f37c3
2017-03-30tdf#106857: use SfxInt32Item for ATTR_SNAPLINEJulien Nabet
and avoid crash with this bt: 3 0x00007ffff7449ef2 in __GI___assert_fail (assertion=assertion@entry=0x7ffff1f0cdd0 "dynamic_cast<const CntUInt32Item*>(&rItem) != nullptr", file=file@entry=0x7ffff1f0cce8 "/home/julien/lo/libreoffice/svl/source/items/cintitem.cxx", line=line@entry=232, function=function@entry=0x7ffff1f0d0a0 <CntUInt32Item::operator==(SfxPoolItem const&) const::__PRETTY_FUNCTION__> "virtual bool CntUInt32Item::operator==(const SfxPoolItem&) const") at assert.c:101 4 0x00007ffff1dd7ceb in CntUInt32Item::operator== (this=0x7fffffff2380, rItem=...) at /home/julien/lo/libreoffice/svl/source/items/cintitem.cxx:232 5 0x00007ffff1e0136e in SfxItemSet::Put (this=0x7fffffff2490, rItem=..., nWhich=<optimized out>) at /home/julien/lo/libreoffice/svl/source/items/itemset.cxx:510 6 0x00007fffc68c7ba1 in SfxItemSet::Put (this=this@entry=0x7fffffff2490, rItem=...) at /home/julien/lo/libreoffice/include/svl/itemset.hxx:131 7 0x00007fffc68d9052 in SdSnapLineDlg::GetAttr (this=0x55555bd802c0, rOutAttrs=SfxItemSet of pool 0x55555779b070 with parent 0x0 and Which ranges: [(28282, 28284)] = {...}) at /home/julien/lo/libreoffice/sd/source/ui/dlg/dlgsnap.cxx:159 Change-Id: Iebaf8d773a532f64c224c0371382132aa4a8d2eb Reviewed-on: https://gerrit.libreoffice.org/35885 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit e1ff3782cc0bef951e7e5f0166c2b2395eaee26b) Reviewed-on: https://gerrit.libreoffice.org/35895 Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit b688a226c5e346e7fb27cdfc22190ed516afc0f4)
2017-03-30update creditsChristian Lohmaier
Change-Id: I9175fb568d06688344e5a2ad8759f57563f9b229 (cherry picked from commit 261d9990228f4784f9a109e80657768b956e3d0d) (cherry picked from commit 2d1ccbe85654a5b2a64813263459ed9231832c37)
2017-03-30changelog creation: "command | > file" doesn't flyChristian Lohmaier
Change-Id: If270d509fbbad6a390ab61345bd1b14ead6ccc21 (cherry picked from commit 9ec6519650280c8cda33ff921926d42840ef89c6) (cherry picked from commit 92668e74ee68a26ac5a21664ef9378d5ec0db675)
2017-03-30tdf#94265: Correct the errorComputingDwarf
Always _WIN32 is defined, even in Win64. So the check must be to _WIN64 and then to _WIN32. Hope no more lines like this in code. Can you test programs with SDK 64 Bit? (cherry picked from commit 3b2863596f26a8d32a5bc322bbbf51cad403c9fb) Change-Id: Ibc6d486fba2077e924efe584d74659f4fe5ab525 Reviewed-on: https://gerrit.libreoffice.org/35836 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 4fbc70bcd790fad04ff158eafe899d47a0b624d6)
2017-03-30Resolves: tdf#106155 avoid opengl for toplevel X window iconsCaolán McNamara
because an opengl context requires a toplevel window so it recurses to death. Only the gen/kde4 vclplugs are affected here Change-Id: If5396d183d90d1872931b170dc90c3a70d8ea6b6 (cherry picked from commit b012e83e1cd09a0b6f9ede94a5c2d72d24459ce4) Reviewed-on: https://gerrit.libreoffice.org/35803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit b96c52baa6b9607d9a31cd1b34162e4ee041f9b6)
2017-03-30Resolves: rhbz#1436050 im window misplaced for gtk3Caolán McNamara
events are relative to event window not the toplevel window which includes a menubar widget (and maybe the decoration topbar as well) Change-Id: I5101bd4a35d6e3aee03191594e5f6edb7ca34c69 (cherry picked from commit 32351d1bd34a0a0d3bb8fa41667a770c125de460) Reviewed-on: https://gerrit.libreoffice.org/35761 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit b986fa2c66e272d926b189683c12cca81bcb5125)
2017-03-30Resolves: tdf#106645 gtk3 scrollbar is too wideCaolán McNamara
Change-Id: I4041dff0945c4bd34e085078a7130b637124c6cd (cherry picked from commit aa5d6f5acbab12b1ba76365f776ba228ba5e7e0e) Related: tdf#106645 make gtk3 scrollbar themes with arrows work properly, e.g. breeze-dark has arrows Change-Id: Ic59c0de3fb385adc2f8fddc605edd7498230d5fb (cherry picked from commit 9b7c35b4b7fd5a5347a3602f110d78e1019a54e9) Reviewed-on: https://gerrit.libreoffice.org/35540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 97a036e5a4b410b3f260a27566c695ac801b7ffb)
2017-03-29tdf#105625 related: don't duplicate dummy character on copyMike Kaganski
Change-Id: I5881887c7a0fd0c9ccd954a36482a3ada5103098 Reviewed-on: https://gerrit.libreoffice.org/34025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit d4036d3a89b65a4912f62e3930eb1a31cd90a16b) Reviewed-on: https://gerrit.libreoffice.org/35861 Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-03-29tdf#105625 related: fix pointer variable prefixMike Kaganski
Change-Id: I5030d33c83c89a4cb8653f88c4309af53b75f68b Reviewed-on: https://gerrit.libreoffice.org/33823 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit c484c5532a9508606d65dfbb805163cd00178f4c) Reviewed-on: https://gerrit.libreoffice.org/35860
2017-03-29tdf#105625: Allow Delete/Backspace to delete whole fieldmarkMike Kaganski
Previously, the fieldmarks couldn't be removed with backspace or deletee when cursor was right/left to them. After commits f72b866c9cf4f07fce6744fbf482c4c6488106e2 and c34fc4520dfee4ca068f249ee0756dacaa7a60cf, deletion worked wrong (it didn't delete the mark from mark manager; in case of text field, it removed one field's boundary). Now single backspace/delete properly removes the whole fieldmark, replacing it with its contents if applicable. Change-Id: Id26e6e4e40e274d9fd6f0224f3e2b4fe33c369b7 Reviewed-on: https://gerrit.libreoffice.org/33812 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit af42aab836626fdf7b29921dff5d344a8b0e47c6) Reviewed-on: https://gerrit.libreoffice.org/35859 Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-03-29tdf#105625 related: also check selection across field boundariesMike Kaganski
The problem in callnk.cxx was that when selecting 1 char to the right using keyboard, and exiting field boundary, nCmp pointed to previous position (inside field), and then compared to position to the left (which also may be inside field), thus missing call change link (and read-only state change). Seems that this was a mistake in commit 740efbb1daf26828f70dc785c1e107f67706286b. In pam.cxx, if cursor was to the left of field, and then selected 1 char to the right to cross field's boundary, then both PaM's point and mark had same fieldmark, but point was outside, and mark inside, and as code didn't check this condition, so read-only state wasn't properly set. Unit test is augmented to check the second problem. Change-Id: I7323e53eeb261b4ccdc0f9e36cc0956b373f104d Reviewed-on: https://gerrit.libreoffice.org/33790 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit c34fc4520dfee4ca068f249ee0756dacaa7a60cf) Reviewed-on: https://gerrit.libreoffice.org/35858 Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-03-29tdf#105625: allow editing around field marksMike Kaganski
This commit fixes commit aa799f64723933bbb46544f835a970cfcbb90384, and partially reverts commits bd505fdb9f669f365ff39b0ef46f0742c638e333 and 9104d5e8905c2ec2b576b5ca452d3e23d5555e49 that seem unnecessary now. Unit test included, the existing unit tests of partially reverted commits are kept. Change-Id: I2a02cda546f5d484553c3b9467993fca36dae140 Reviewed-on: https://gerrit.libreoffice.org/33722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit f72b866c9cf4f07fce6744fbf482c4c6488106e2) Reviewed-on: https://gerrit.libreoffice.org/35856 Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-03-29enable crashreport on WindowsAndras Timar
Change-Id: I55df3da63919f76afcd4905b1898287e26c8c4f1
2017-03-29LOK: Calc: limiting undo and add support for repair modeMarco Cecchetti
During collaborative editing changes can be undone regardless of who made them. This patch avoids this possibility and introduce support for repair mode, for cases where undo/redo of others' changes is intentional. Change-Id: I69fd435e96c4c675ffd1df81e936b5eae109daa0
2017-03-29Calc: safer life cycle handling for OutputDevice in SdrPaintWindowMarco Cecchetti
Change-Id: I5469332c4ef98bce8cd9c2caff5bf61dbf102b23 Reviewed-on: https://gerrit.libreoffice.org/35216 Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-03-29LOK: Calc - images are not painted below row 1000Marco Cecchetti
The problem was not due to some missing tile invalidation: it was at the painting stage. There was no overlap btw the view range and the object range. Now images and shape are painted correctly. There is still problems with control forms and charts. Change-Id: Ib74e3bb79b444df21844086ae666fc206aa48906 Reviewed-on: https://gerrit.libreoffice.org/35244 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-03-29tdf#106799 WW8: Accept TTP Mark without Cell MarkMike Kaganski
Paragraph mark of inner table (0x0D) sometimes has sprmPFInnerTtp, but no sprmPFInnerTableCell. This still counts as cell end (at least, MS Word treats it that way). Unit test included. Reviewed-on: https://gerrit.libreoffice.org/35763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 59af9cbbccee600408c89e872d548d153523ab1f) Change-Id: I5589cdd486c03ca4567d61882826cc7c245a40c9 Reviewed-on: https://gerrit.libreoffice.org/35773 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-03-29tdf#103058: Implement OpenDocuments ActiveX controlMike Kaganski
Change-Id: I97489090476cd884a122a4b36d3ac62ca86fd886 Reviewed-on: https://gerrit.libreoffice.org/29608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-03-29tdf#106291: WW8 import: Properly treat column spansMike Kaganski
Previous code unconditionally treated all cells in merge groups as rows span, thus in some conditions it merged incorrectly when there were cells from same row. The fix is inspired by SwTable::PrepareMerge(). Also, fixed improper adjustment of too narrow cells in WW8TabDesc::CalcDefaults(), which also happens in files where column spans are represented by spanned 1-twip-wide cells. Unit test included. Reviewed-on: https://gerrit.libreoffice.org/34820 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit bb2a3df2d5b5a01aa58fb3567686e50762186036) Change-Id: I6c3803635f006dd396805d6847daa4d80c97cad4 Reviewed-on: https://gerrit.libreoffice.org/34863 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-03-29tdf#106377 sw: fix Undo of delete of ToXMark from dialogMichael Stahl
The problem is that SwUndoResetAttr and the SwHistorySetTOXMark by design only insert the SwTextAttr, they don't insert the dummy char of a SwTextAttr that needs one, like the ToXMark does if it marks a point. So just change SwDoc::DeleteTOXMark to create SwUndoDelete instead. Change-Id: Ic1eebac4cf859771a6032bffb2fd8e198aa08084 (cherry picked from commit 63f7da77985674ddf59bb566bdada9c41893e822) Reviewed-on: https://gerrit.libreoffice.org/35501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 123bb36e7eafde85732b57e84d0377586a0a66d8)
2017-03-29tdf#106755: Fix script type for combining marksKhaled Hosny
We are classifying characters in the “Combining Diacritical Marks” Unicode block with ScriptType::LATIN, but these are combining marks and can combine with any script and should have been ScriptType::WEAK. Just removing them from the range in scriptList does the trick as we will fallback to getting the script classification based on the Unicode script property. Change-Id: I3577f4b03360a1c8e094a207f01b6bbb6abbaf30 Reviewed-on: https://gerrit.libreoffice.org/35811 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 55ddbfc610d2a00e565ca7bcb0277da33bb90947) Reviewed-on: https://gerrit.libreoffice.org/35815 (cherry picked from commit 1c5d8ea51f9da89d76b2b2d3bb896225a6ac9dca)
2017-03-29Attempted fix for mirrored geometry crasher.Michael Meeks
Only plausible cause is pWindow->GetParent() being null, while we have a pParent which has to be valid. http://crashreport.libreoffice.org/stats/crash_details/6161398d-17b6-4a93-aa70-a559efa07868 Code was initially introduced in this form: commit 4716735ba7d0ad133ff018481f94d6b4f201bbd9 Author: Stephan Schäfer <ssa@openoffice.org> Date: Thu Sep 19 15:46:19 2002 +0000 #103362# improve positioning and resizing of system windows No public report, sadly. And modified by commit fba46c6efd08d50fee92cc11546f3ed253a57af8 Author: Chris Sherlock <chris.sherlock79@gmail.com> Date: Mon Feb 3 16:46:04 2014 +1100 fdo#74424 Use Window::GetOutDev() to access ImplReMirrored() Part of the decoupling of Window from OutputDevice. We now get he Window's OutputDevice instance and manipulate this. Do not rely on the inherited function. where the GetParent()/pWindow->GetParent() problem surfaces Change-Id: Ia261028a4719525135e3fe4b00074427c1d9df6c Reviewed-on: https://gerrit.libreoffice.org/35796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit d93b8268da982ad26db9e03156ce9b89f3410486) Reviewed-on: https://gerrit.libreoffice.org/35827 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 39a09641a1d2e1b50c831fe5ecf3dc0b0174a210)
2017-03-29tdf#105843 : restore Application Start and Stop eventsJean-Baptiste Faure
Change-Id: Ifc99fcf84182edb49cac741f7bb10a1b239d5703 Reviewed-on: https://gerrit.libreoffice.org/35779 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 7c0054f1b7c3c475bff7a5adfdea0feaecf20748) Reviewed-on: https://gerrit.libreoffice.org/35812 Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 98399c291239e309769fe9a1099655343b21ccd2)
2017-03-29Resolves: tdf#106612 fix double click in draw/impress navigatorCaolán McNamara
Change-Id: Ic4b08c6e5cd430b5278bdc2cb7f1205bba160740 (cherry picked from commit 879aa0f71d98969f6bf2e540f1e95c7c9e0e05bf) Reviewed-on: https://gerrit.libreoffice.org/35539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 9fd212c3fbc28868e15f5d8e8ae598ac34176991)
2017-03-29tdf#105069, store the VBA module info for new modules as wellMarkus Mohrhard
This was never a problem until we started to export the VBA stream instead of just writing back the imported stream. Change-Id: I4e20e717bebd3dc649efcf1b9c18b6e5053303d9 Reviewed-on: https://gerrit.libreoffice.org/32741 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 2be139d76bdb66e77719613d802dc0047c284456) Reviewed-on: https://gerrit.libreoffice.org/35198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit fd242f02b195f896b23336fe51773d7abf310d4e)
2017-03-29valgrind: use of uninitialized valuesCaolán McNamara
Change-Id: I5b8c6d4d4576fd88dbffdfc710cbd9b2e9429942 (cherry picked from commit b7152aff51665bc802af66e6e599a89e0344c92f) Reviewed-on: https://gerrit.libreoffice.org/35805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 8337a9b186abc5a3393127227ec727f019f09dc5)
2017-03-28tdf#58624 sw: fix ~SwAccessibleContext() use-after-free raceMichael Stahl
As seen in JunitTest_toolkit_unoapi_1: Method doAccessibleAction() finished with state OK LOG> doAccessibleAction(): COMPLETED.OK debug:27272:12: -SwAccessibleParagraph mutexwait 0x3fd9f50 debug:27272:9: SwAccessibleContext::Dispose 0x3872620 11SwRootFrame debug:27272:9: SwAccessibleContext::DisposeChildren 0x4047c80 0x386d600 11SwPageFrame debug:27272:9: SwAccessibleContext::DisposeChildren xAcc 0 debug:27272:9: SwAccessibleContext::DisposeChildren 0x4047c80 0x386cef0 11SwBodyFrame debug:27272:9: SwAccessibleContext::DisposeChildren xAcc 0 debug:27272:9: SwAccessibleContext::DisposeChildren 0x4047c80 0x3878fe0 11SwTextFrame debug:27272:9: SwAccessibleContext::DisposeChildren xAcc 0 debug:27272:9: SwAccessibleMap::RemoveContext erase 0x3872620 debug:27272:9: ~SwAccessibleMap: frame entry 0x3878fe0 debug:27272:9: ~SwAccessibleMap: mpFrameMap 0x3eb64a0 debug:27272:9: ~SwAccessibleMap: mpShapeMap 0 soffice.bin: sw/source/core/access/accmap.cxx:1726: virtual SwAccessibleMap::~SwAccessibleMap(): Assertion `(!mpFrameMap || mpFrameMap->empty()) && "Frame map should be empty after disposing the root frame"' The problem here is that thread 12 is blocked on SolarMutex in ~SwAccessibleParagraph(), while thread 9 is in ~SwAccessibleMap(). This means that in SwAccessibleContext::DisposeChildren(), the WeakReference to the SwAccessibleParagraph cannot create a uno::Reference because its reference count is 0, so SwAccessibleContext::Dispose() is not called on it and it remains in the SwAccessibleMap::mpFrameMap. This triggers the assert and later on ~SwAccessibleContext() would access the deleted SwAccessibleMap and crash. To fix this, introduce a weak reference from SwAccessibleContext to SwAccessibleMap; use a std::weak_ptr because that is not derived from OWeakObject. The weak_ptr is only used in the dtor ~SwAccessibleContext(); as long as the ref-count of SwAccessibleContext is > 0 it is guaranteed that the SwAccessibleContext::m_pMap is either null or valid as the recursive Dispose() will work fine. It is possible that additional temporary owning references could delay the destruction of SwAccessibleMap, and the order of destruction of Writer documents is very fragile, so rely on the SolarMutex lock to prevent that; the only shared_ptr that owns SwAccessibleMap while SolarMutex is not locked is the one in SwViewShellImp. (An alternative fix would be to represent the 3 lifecycle stages of SwAccessibleContext by adding a C++-pointer to the SwAccessibleMap::mpFrameMap, so that DisposeChildren() can, if the WeakReference is no longer valid due to ref-count 0, use the pointer and clear SwAccessibleContext::m_pMap - this and the corresponding call to SwAccessibleMap::RemoveContext() from ~SwAccessibleContext() under a mutex that is shared_ptr-owned by SwAccessibleMap and all SwAccessibleContext.) Change-Id: If2b44c79189e3b3d276491a5c57d5404bb2be71a (cherry picked from commit 0c2229dcab143925c6ad390e0735e2d98c3eecca) Reviewed-on: https://gerrit.libreoffice.org/35654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit aba392d1a07b8b0d40583d7e893a409cf96f1725)
2017-03-28Access2Base Missing parentheses - tdf#106710Jean-Pierre Ledure
Due to more severe Basic interpreter on final parentheses missing parentheses were revealed (complement to commit cc16dfb11dfc275317bb535a62b11935c562b670) Change-Id: I45b43bca4a5ee938e9c4dc0b0f8b2d5856f710da Reviewed-on: https://gerrit.libreoffice.org/35717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit c317670eb6b5d29f0447feff0c33d528a88f4c8a)
2017-03-28Resolves: tdf#106461 use a row height of max of edit and listbox heightCaolán McNamara
not just take the listbox because edits can be taller and result in overlaps Change-Id: I6067b384484d933727220febda723bc9e8c5e90b (cherry picked from commit 5013abeb191cdc6f8375f107a4d30abd802547d2) Reviewed-on: https://gerrit.libreoffice.org/35596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 910582360d2a2f0455841b2cd0c3cc2c7ed08344)
2017-03-28ofz#944 avoid recurse to deathCaolán McNamara
(cherry picked from commit 7eb92eea21e2af47b17c9901107f6e4833567928) Change-Id: I27ed8cf5e8296a1ad91c33614913fc7af4a56d45 Reviewed-on: https://gerrit.libreoffice.org/35724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit c2a9387ab259f12c7ee724f7f5be52b8d8f7ed64)
2017-03-28Resolves: tdf#106724 crash when Title property doesn't already existCaolán McNamara
because we just write past the end instead of resizing before hand (cherry picked from commit 4e32e8900e59f9751a60d9fdef80cdf7d500f72f) Change-Id: I4742980a331b14ca39aff8aa6cfc27db154091ff Reviewed-on: https://gerrit.libreoffice.org/35651 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 1255360bffebef0f0521b00c4e5af57e6fe09e6b)
2017-03-28Resolves: tdf#106729 ensure VistaFilePicker init before accessCaolán McNamara
(cherry picked from commit a15ec82edebf14baa41a888ead7da8e0556ab0bb) Change-Id: I238599cf5ed464c4bb99a894ac47126fbc32796d Reviewed-on: https://gerrit.libreoffice.org/35745 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit de87afd6d8302d2c000be39010196cb1aef865c1)
2017-03-28tdf#106751 fix regressions in Hungarian spell checkingLászló Németh
using recent fixes of Hunspell code base Change-Id: I180a2ecba924180419c5eb1a0e78b5c84e7242c4 Reviewed-on: https://gerrit.libreoffice.org/35670 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 23c028ba014f521bf1b70c83439e0915e56c296f)
2017-03-28tdf#106529: fix closing parentheses of bundled macrosAndreas Säger
Change-Id: I43b6d4f97cb3b1cd1426e6aa7e13550d94cb7c51 Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/35726 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit ad4857211bcc39ccd4c84c670bfab1b937f65089) Reviewed-on: https://gerrit.libreoffice.org/35741 (cherry picked from commit 7fb7b091e963d8c45abf1db1202a88f2e188e9b0)
2017-03-26Access2Base Missing parentheses - tdf#106710Jean-Pierre Ledure
Due to more severe Basic interpreter on final parentheses missing parentheses were revealed Change-Id: I84ead9ba4957ae20ed094d7ae42df436fd1f88f2 Reviewed-on: https://gerrit.libreoffice.org/35683 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit a403671af80be1e1563eea013d155e6a0635f0f0)
2017-03-26Re-introduce a check I dropped in 7ceda09f6780c954fedc49764d5457aa2616b39aTor Lillqvist
Without fully understanding the code, best to let the condition be there. Use the same function to check for validity as before. (IsValid() which was renamed to IsValidForXml().) Change-Id: If50df539737352f12cb0178706cbc38512a99366 (cherry picked from commit a77908a2d82986ad9d2d9597536d1e22ce2cafd2)
2017-03-26A 'CondFmt' record can have a maximum of three CF records following (eek)Tor Lillqvist
What an odd restriction. Oh well. Don't export the conditional formats for the cell(s) in that case then. See https://msdn.microsoft.com/en-us/library/03AE6098-BDC2-475B-BA2C-B8AEF7882174 Change-Id: I4eeec8d33f9fbc572a02f727f38564d6c43b4f10 (cherry picked from commit 7ceda09f6780c954fedc49764d5457aa2616b39a)
2017-03-26Make sure that the 'stAuthor' field of a 'NoteSh' structure filfills the specTor Lillqvist
Its length must be greater than or equal to 1 and less than or equal to 54, so if the author is empty, use a single space, and otherwise truncate to max 54 characters. See https://msdn.microsoft.com/en-us/library/dd945371 Change-Id: I7604ae9e1d8eea336b42116ea7d305e183e6ca51 (cherry picked from commit 27e34a7dbb9aa2ce52ca529ec835d54c6a5508fc)
2017-03-26tdf#104729 FILESAVE Save author name in comment during export to .xlsxBartosz Kosiorek
Change-Id: I59d46f6a713e4f252844cda0f631ace239d73cdb Reviewed-on: https://gerrit.libreoffice.org/32115 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 36cdf3c35459df63ce137e550a6840a61865c0ca) (cherry picked from commit b61abf2d3d8638ace8abd08911b06a3ab1478799)
2017-03-26Write the 'FtNts' subrecord of 'Obj' when necessaryTor Lillqvist
See https://msdn.microsoft.com/en-us/library/dd952807 : nts (26 bytes): An optional FtNts structure that specifies the properties of this comment object. This field MUST exist if and only if cmo.ot is equal to 0x19. Change-Id: Ib4a007940c29a4f8eac1087601cfc7d242cfebd3 (cherry picked from commit 20a7d4b16d600101f4073ad4ce669a7566bf14c1)
2017-03-26It's SetSliceSize, not SetSliceLenTor Lillqvist
Change-Id: Ife4449f5afa7321c18e8eb963878d9c037f6d623 (cherry picked from commit 93a53e0ebba62873c768d887c6aa1125967aa9e4)
2017-03-26Use symbolic constants instead of hardcoded numbersTor Lillqvist
The constants were commented out, so uncomment them. Probably lots of the same left. Change-Id: Iac87bef3bc331ae126741efbb4d58cc539e5a42a (cherry picked from commit 74df76d6ac91fae02ef0d20ce863cb753ba953cb)
2017-03-26The 'fLockObj' field of an 'ObjProtect' MUST be 0x0001 says the specTor Lillqvist
So generate such a record only when the protection state is on. See https://msdn.microsoft.com/en-us/library/dd922139(v=office.12).aspx Change-Id: I710395527cd53dc47018806e51fcc699e11fb461 (cherry picked from commit 4a332d54b80bbc502ccc98bf924a269e00c10070)
2017-03-26The 'reserved1' bit of a 'Formula' MUST be zero according to current specTor Lillqvist
See https://msdn.microsoft.com/en-us/library/dd908919(v=office.12).aspx . This means we will never set the EXC_FORMULA_RECALC_ONLOAD flag, hmm? Change-Id: Ic081caa7f98426394cbc7b0b320fa1a5a9a34f6c (cherry picked from commit 727ee3f92a8882914ac3f68eaf53ac519ace5f38)
2017-03-26Set the 'unused2' bit of 'Font' to 1 iff 'uls' is greater than 0 per specTor Lillqvist
See https://msdn.microsoft.com/en-us/library/dd906117(v=office.12).aspx . Change-Id: I4ff278f4cdd388947bbe81b88b6c39ff2b208b1a (cherry picked from commit 970f8dc7847967719652590f71f0f19e46ba7268)
2017-03-24lok: Scheduler::ProcessEventsToIdle() needs the solar mutex locked.Jan Holesovsky
Change-Id: Ibd2e40a995e670db09ca7dbf09465a998f832446
2017-03-24sw lok: Avoid double declaration of variablePranav Kant
Fallback from f20bb20f8e1147d8ea1b93ee6dc216722461d456 when fixing merge conflicts Change-Id: I04a9c5dac43e4aeb3196decc703ad8e14f7b9944
2017-03-24lok: Forgotten file for the unit test.Jan Holesovsky
Change-Id: Id20c32c1451bd0144377821ffaacbbdeaecbe7bd
2017-03-24lok: Unit test for setting of the language during load of the document.Jan Holesovsky
Change-Id: Idf4d3ba6b55be1f885f9d8fc89157e7e498d4e42
generated by cgit (git 2.34.1) at 2024-06-22 00:35:17 +0000