Age | Commit message (Collapse) | Author |
|
Change-Id: I9ba1b9c3c0e3efb00538b2f3ed4fcffc29f9e931
|
|
Going via UNO for a class in the same module is an overkill.
Change-Id: Idf706782e5844fd2e553c44966e1dd1104dce8e7
Reviewed-on: https://gerrit.libreoffice.org/32030
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I6236428f8cfd17e52b5eac8c3747dcba6f83a440
Reviewed-on: https://gerrit.libreoffice.org/31964
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I014f49b8239b0165ab696398b5ef0a2af5e0ae8c
Reviewed-on: https://gerrit.libreoffice.org/31990
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Reverted because of issues mentioned in the bug report.
This reverts commit 64889c9fb6c3e8e7b7a7349833f7a10236104168.
Change-Id: I10fa0d0e55fd4c7c3624d9eb8a97e8c068b9db17
Reviewed-on: https://gerrit.libreoffice.org/32032
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
'LINKTARGET' is not really helpful as target name.
Use name based on makefile's name and hope something like
b81ac16e65b311d6e43c05c22c65d2040c9d7e04 is not needed anymore.
And if there are still some inconsistencies, we should fix makefile's name.
Also, don't use target.name because it's not unique.
There can be e.g. both Library_smoketest and CppunitTest_smoketest.
Change-Id: I541a1e41f80446e875e1bb2bfa89786e356e0e74
Reviewed-on: https://gerrit.libreoffice.org/32027
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
|
|
Change-Id: I9816e320d9ed31b8af50d20d207a9be21b58ace3
|
|
Change-Id: I614e29829ebd40b34f85ce32b806a5079b7967de
|
|
Change-Id: I53983b90e8039caa6b104b160f3aba8f0e8f6363
Reviewed-on: https://gerrit.libreoffice.org/31969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
and remove explicit OUString ctor calls, now criticised by
[loplugin:stringconstant]
Change-Id: I778df2f410108e1386431a0035101444ec44c951
Reviewed-on: https://gerrit.libreoffice.org/32014
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a
Reviewed-on: https://gerrit.libreoffice.org/32004
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
and avoid unexpected behaviours when pasting columns between tables
regression from:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=f0fa43ea99ac7564f2cc7ca1d997831808056b68
http://www.cplusplus.com/reference/list/list/insert/
and http://www.cplusplus.com/reference/deque/deque/insert/
helped me to understand my mistake
Change-Id: I6ff6b84a90c7ea8db1e4d7c2d12dd191f96141ae
Reviewed-on: https://gerrit.libreoffice.org/32020
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I45f4e2905ee016a933f6ff6cc89fcd0ced106b18
Reviewed-on: https://gerrit.libreoffice.org/31962
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Project: help cb54cfefe42d115a08e3c368a028b3f0b30485d4
tdf#104359 (partial) Handle ol_item and ul_item
This was throwing an exception and not generating a wiki page
Change-Id: Ic7d362cf65507aa8d90335c7f0ff3b5d8ea6fe58
Reviewed-on: https://gerrit.libreoffice.org/31610
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
|
|
As one knows, the features of Writer's document model that most impress
by their sheer quality of implementation are redlines and field marks.
Unsurprisingly, if the two meet in the context of the WW8 import, epic
disasters are imminent; ooo83574-1.doc is one such train wreck that
asserts with:
sw/source/core/crsr/bookmrk.cxx:111: void {anonymous}::lcl_RemoveFieldMarks(sw::mark::Fieldmark*, SwDoc*, sal_Unicode, sal_Unicode): Assertion `pStartTextNode->GetText()[rStart.nContent.GetIndex()] == aStartMark' failed.
This happens when, at the end of the import, the redlines are hidden by
moving them into their special SwNodes section. The reason why this one
asserts is that a previous SwRedline erroneously deleted the start dummy
char of this field mark, because that SwRedline had the wrong start/end
positions.
In Word the problematic paragraph is shown like this, where \a\b mark fields
and I D F redlines:
"Coming out of the work of Rummler and Brache’s \a(Rummler & Brache, 1995)(1995)\b work is the is the notion
IIIIIIIIIIIIDDDDDDDDDDDDDDDDDDDDD IIIIIIIIIIIIIIIIIIIIIIIIDDDDDD DDDDDDDDDDDDIIIIIII
another” \a(p. 9)\b\a(Rummler & Brache, 1995, p. 9)\b.. ( italics in the original)"
IIIIII DDDDDDDDDDDDDDDDDDDDDDDDDDDDDD IDDDIDDDDDDDDDDDDDDDDDDDDDDDD
FFFFFFFFFFFFFFFFFFFFFFFFFF
The first mis-positioned redline here ranges from 71 to 79, ")(1995)\b",
so it deletes the end dummy char of the field mark. It should range
from 72 to 78.
This commit adds some rather crude hacks which appear to work to avoid
the problem:
1. when a field mark is inserted, the start positions of the redlines
may need to be moved
2. when the end position of a redline is set, it may need adjustment to
exclude a field-mark that ends at the same position
Change-Id: I723f1858c84def2c063e2cb126317d06e8ac98b5
|
|
Change-Id: I096211333c563b501627fef0dbdec8c3c98d501a
|
|
Project: help 7de8eed8b1b908c9e37f6e2499f37768a2354d27
Handle 'acronym' item type
This was throwing an exception and not generating a wiki page
Format with a simple italic text for now - better ideas welcome!
Change-Id: I1b08c6b6dd2e96eef3cac4808fe23f911dc06cd3
Reviewed-on: https://gerrit.libreoffice.org/31609
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
|
|
Project: help 96a84b25e3ae012661a68da1ecdbbf0d94089d9b
tdf#104489 Include the product name in wiki page URL
Change-Id: I39155cf12a7ba178b0fb4e25315bd32156086846
Reviewed-on: https://gerrit.libreoffice.org/31772
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
|
|
This was still not appearing on the Attributes page
Change-Id: Ibfd10427c4a79848a2e50d26910e5d184216ef58
Reviewed-on: https://gerrit.libreoffice.org/31811
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
as that TTBOMK is the case where it's used. At least it's not used in
vcl and slideshow directly
Change-Id: Ie77656e56e0017800bc0107c2bfe63ddc4b5b9a5
|
|
Change-Id: I65e133c6d1c9ddc0b0e66e2cd1aff83c3713c0da
|
|
Change-Id: Ifb412506f2e36878d44d0e4f6360ae8d070ffa15
Reviewed-on: https://gerrit.libreoffice.org/28488
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
On Windows x64 there are two ODBCs - one for each bitness.
A 64-bit build gets 64-bit ODBC, and there is no provider named
"Microsoft Excel Driver (*.xls)", no normally the test is simply
skipped. But if MS Excel is installed, then it installs provider
"Microsoft Excel Driver (*.xls, *.xlsx, *.xlsm, *.xlsb)", that was
detected by previous code, but not used inside the VBAs. So, VBAs
tried to use "Microsoft Excel Driver (*.xls)" unavailable to them.
This patch allows using Excel's provider as well, thus allowing
developer to test against 64-bit-specific regressions.
However, the last test uses Microsoft.Jet.OLEDB.4.0 provider,
that is unavailable on Win64. There are substitutions -
Microsoft.ACE.OLEDB.12.0 and Microsoft.ACE.OLEDB.15.0,
but there is no easy way to test if they are installed. Thus,
that test is disabled on Win64 for now.
Also, possible buffer overflow fixed, when byte count was passed
to SQLGetInstalledDriversW instead of char count.
Change-Id: Ib5c55251f0e92b3078a46aee173b5061439445ae
Reviewed-on: https://gerrit.libreoffice.org/32019
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
|
|
Added extra gb_ macros, which seems to be used only for osx
Removed second jurt in BLACKLIST (assuming it is not like "not not True")
Change-Id: I989eb2e6de6f0edde7902b51f829442bd598eec2
|
|
Change-Id: I46df2800eb3440ee6c139867cf00f5cad5c4f3f1
Reviewed-on: https://gerrit.libreoffice.org/32012
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
(arbitrarily decided to keep the latter, being the less odd class name)
Change-Id: I5c061a0f12b8f3095e283b4896f7c910948ac50f
|
|
Change-Id: Ib944b8109c734f01ca67783c286c8e10e07a1d25
Reviewed-on: https://gerrit.libreoffice.org/31993
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
...vs. recently introduced llvm::StringLiteral (llvm/ADT/StringRef.h)
Change-Id: I4d74546b0d1401a74b0c15368bbc93794ecd0b1d
|
|
Without this, first lines (up to "Other arguments passed directly
to configure:" inclusive) go to STDERR, while the rest to STDOUT
Change-Id: I95327d1ebe7941e5eb89f941ff1f9dc59297946b
Reviewed-on: https://gerrit.libreoffice.org/31999
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
don't store string length, construct string with createFromAscii and
inline SERVICE_MAP_ENTRY macro
Change-Id: Ib25da99f3ad24f58179a0231a42b29e177967bfc
Reviewed-on: https://gerrit.libreoffice.org/32006
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Project: help d3d24377c0ed652c0f0460ecbb4a8d80261f999d
Remove noise in help file
Change-Id: Ifdcf7fe44f62d55b88ffb0c5c06fe45bb84c881d
Reviewed-on: https://gerrit.libreoffice.org/32010
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
|
|
The editeng-like approach is terribly annoying when typing, particularly in
bullet lists.
Change-Id: I66175579f801fa028273d9680d7383d8eb37bf28
|
|
2 parts changed for these bts:
0 SdrEditView::GetGeoAttrFromMarked (this=0x0) at /home/julien/lo/libreoffice/svx/source/svdraw/svdedtv1.cxx:1278
1 0x00002aaadf70ae97 in SvxBitmapTabPage::Reset (this=0x55555b2eb8b0, rAttrs=0x55555afa0310) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:278
See https://bugs.documentfoundation.org//show_bug.cgi?id=104615#c1
0 SdrPaintView::GetModel (this=0x0) at /home/julien/lo/libreoffice/include/svx/svdpntv.hxx:256
1 0x00002aaadf90ba0f in SvxBitmapTabPage::ModifyBitmapHdl (this=this@entry=0x55555b2e7950) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:526
2 0x00002aaadf90bcc7 in SvxBitmapTabPage::ClickBitmapHdl_Impl (this=this@entry=0x55555b2e7950) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:457
3 0x00002aaadf90c9d8 in SvxBitmapTabPage::Reset (this=0x55555b2e7950, rAttrs=<optimized out>) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:441
See https://bugs.documentfoundation.org//show_bug.cgi?id=104615#c2
Thank you to Katarina Behrens for her help on this.
See http://nabble.documentfoundation.org/About-opening-odc-file-and-mpView-null-td4202317.html
Change-Id: Ibbca868f33ca3292e0d3f787df87876bc9464e0b
Reviewed-on: https://gerrit.libreoffice.org/31924
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
Change-Id: I48e7f1e27ca7a221e06891e6c4ac543deaf32fa0
|
|
Temp directory created by copy_images (which contains copies of .png files
from any given icon-themes folder) was left behind. Happening at least since
commit 4e3dc8c141c2efd037c1f214b5edff071812b6a8
Date: Fri Jun 3 17:09:14 2016 +0200
remove use of Archive::Zip
With packimages.pl now used to package also screenshot images (in
multiple languages), tmp fills up quickly. This is fatal on Windows
Change-Id: Ie35c33277a80ed9085815f30b846bb97a365afb1
Reviewed-on: https://gerrit.libreoffice.org/31947
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
Change-Id: I0bfe65fa6870b243f927004d4de0da010b338c64
Reviewed-on: https://gerrit.libreoffice.org/31929
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
...that were apparently meant to flag cases where conversion from old tools
strings to rtl strings was done wrongly. But that flagging is probably of no
use: SAL_INFOs are usually disabled, so won't be noticed; and SAL_WARN or assert
would not be acceptable, as cases like 'nLen == 0x0FFFF' can legitimately
happen with long strings. I did a successful 'make check' with these SAL_INFOs
temporarily turned into assert, so there seems to be at least no gross
conversion error remaining.
Change-Id: I57f11db9119fb12555e3bfef17c077ee5eef3844
|
|
Change-Id: I182826a224859a07fa264f3404aa2bef7013de3a
Reviewed-on: https://gerrit.libreoffice.org/31992
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Assuming this line has been replaced by external/epoxy/Library_epoxy.mk.
Change-Id: I0aaa86f6d001a266d7975a357e820c05045af338
|
|
Change-Id: If65cbe691d427a68985de0f8b4c0f9ada7ab281f
|
|
Change-Id: Ia8f8ab2e84e41d2767a566be4009ddc54e4f2890
|
|
...deriving from VclReferenceBase. Complicated by the fact that the argument
type may be incomplete at the time of template instantiation. So this approach
may be less precise than the change to loplugin:vclwidgets from
cbf5b21f2a65bbb342295200f6ad93a00f90733e "Catch some misuses of VclPtr
construction" when the argument type becomes complete later in the comilation
unit. However, this approach would also catch the two misuses in UnoControls
found by cbf5b21f2a65bbb342295200f6ad93a00f90733e, so go with this approach for
now and revert the change to loplugin:vclwdigets.
Change-Id: I7888f23d2b9e2db81ae2ce4bf4c8277912317685
Reviewed-on: https://gerrit.libreoffice.org/31966
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: If737cf4aaec1e6297db2bc8a80b19720ca9ca189
|
|
The only actual use of fcvt across the codebase has been removed in 2002 with
31cb31335f3bf7e6e57d70ca61bf5a2a536d1e6e "GetStringFromDouble: replaced that
fcvt() and temporary LocaleDataWrapper instance crap" even before this
implementation for FREEBSD was introduce in 2003 with
c61bf41c39daa97d30016eedcd7a0b687c2d8558 "INTEGRATION: CWS ooo11rc: join: from
ooo11beta2".
Change-Id: Ieea9499f001c6eac6383c344afb9050dfc70f43c
|
|
Change-Id: I70078bf77786772795bc569407a9e6ac372df758
|
|
nouns are written Upper Case only in German
also Cancel button looks odd as secondary
Change-Id: Id1b051cbb86ab69ea88c7b1da2cda3eb19f063de
Reviewed-on: https://gerrit.libreoffice.org/31971
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
Change-Id: I5dc6a1b1fa42a4fd76af398c2fb56461574900ee
Reviewed-on: https://gerrit.libreoffice.org/31980
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
|
|
Project: dictionaries 499d730b4e1209149a566ef0f7bbb046bc403a98
Updated the GB Dictionary
Updated the Dictionaries:
- British (Marco A.G.Pinto)*
* British has 710 new words (2016-10-01) + 735 new words (2016-11-01).
Change-Id: I7dc61b241ac3092652f0005d33720ebdfefb0ef3
Reviewed-on: https://gerrit.libreoffice.org/30677
Reviewed-by: Stuart Swales <stuart.swales.croftnuisk@gmail.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: Iedf0ccb9c48235e8ffd3c14e4f56813d70b7c0c7
|
|
Change-Id: I32e6bad89b7cdcf0b181c0bb3a158b003fcfb767
|