summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-01-23new loplugin: pointerboolNoel Grandin
look for possibly bogus implicit conversions to bool when passing (normally pointer) args to bool params. this plugin comes in the wake of a couple of bugs caused by refactoring, where some of the call sites were not currently updated. Of the changes, the following are real bugs: desktop/../dp_persmap.cxx StartInputFieldDlg in sw/../fldmgr.cxx which occurred as a result of commit 39d719a80d8c87856c84e3ecd569d45fa6f8a30e Date: Tue May 3 11:39:37 2016 +0200 tdf#99529 sw: don't pop up input field dialog before inserting field CSerializationURLEncoded::encode_and_append in forms/../serialization_urlencoded.cxx XclExpCFImpl::XclExpCFImpl in sc/../xecontent.cxx I have no idea how to properly fix this, just made a guess. SwDocTest::test64kPageDescs in sw/qa/core/uwriter.cxx which looks like a simple copy/paste error. Change-Id: I795ebd5ef485a1d36863dc27fe13832989f5a441 Reviewed-on: https://gerrit.libreoffice.org/48291 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-23USHRT_MAX -> SAL_MAX_UINT16Stephan Bergmann
...that had presumably been forgotten when the surrounding code had been changed from USHORT to sal_uInt16 in cd42389ad67b403a07a0dda8e2a6e213def49251 "removetooltypes01: #i112600# remove tooltypes from sc". Plus, turning the preprocessor checks into static_asserts. Change-Id: I78271f7027af701699865913813d6dea8b0c570b Reviewed-on: https://gerrit.libreoffice.org/48358 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-23Fixed wordingMatthias Seidel
(cherry picked from commit 106d959da4cccda4c0342715cc06854f152c99d1) Change-Id: I51c86dfef0e0eff59ce2892d8ea07dd066fd9667
2018-01-23ofz#5566 sw: HTML import: ignore <DIV> in table structure elementsMichael Stahl
Looking at the HTML4 DTD https://www.w3.org/TR/html4/sgml/dtd.html, inside TABLE only various elements defining the structure of the table allowed, except inside cells (TD and TH elements). DIV in a table but outside cells may cause cursor positions to go off the rails, so better ignore such invalid DIV tags. Change-Id: Ia6195d80670631669c252d572242874b13642b74 Reviewed-on: https://gerrit.libreoffice.org/48359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-23its defineresource not define resourceCaolán McNamara
regression from commit 64d624b65124ac02d8ee59b135593fd9d8eb9067 Date: Sat Jan 9 22:55:28 2016 +0100 Fix typos Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Change-Id: Ifdf45e97b81523c84c73b93d14ed75b7b6909f77 Reviewed-on: https://gerrit.libreoffice.org/48355 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-23tdf#112153: Set button theme properlyTelesto
Change-Id: I0665880c0d0348fcbb3bcf04d9172405c8e31eb7 Reviewed-on: https://gerrit.libreoffice.org/48334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-01-23tdf#114985: Tell NSWindow to never use automatic window tabbingTelesto
Based on https://codereview.chromium.org/2325313002/ Change-Id: I8838449d57b1d1b010491a405c87645d38199fdf Reviewed-on: https://gerrit.libreoffice.org/48330 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-01-23tdf#114460 vcl: handle nested parentheses in PDF roundtripMiklos Vajna
The roundtrip of the pdf image failed due to this. Change-Id: I88a9657e242dd2659f9bf06233e5fcbfeb43ceb5 Reviewed-on: https://gerrit.libreoffice.org/48362 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-23EPUB export, fxl: silence Page <N> toc entries when have chapter namesMiklos Vajna
The EPUB ToC is now on par with the PDF ToC. Change-Id: Iea714fdb68c825aa14345037e909c354bbd7cf00 Reviewed-on: https://gerrit.libreoffice.org/48346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-23EPUB export, fixed layout: add chapter names to the navigation documentMiklos Vajna
Extend vcl::PDFExtOutDevData so that it's possible to use it outside the PDF export; this way the EPUB export can know which chapters start on which page. This means fixed and reflowable layout has the same table of contents, instead of just Page <N> in the fixed layout case. Change-Id: I935fb23c66ec747431b91e83b0e677d4e5f704b9 Reviewed-on: https://gerrit.libreoffice.org/48332 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-23Revert "Windows installer: Use blank phone # instead of x-xxx-xxx-xxx"Samuel Mehrbrodt
Breaks windows installer This reverts commit 7b129f55b4da9a20581fe805b7dacadcb6386252. Change-Id: I21a5a6790eac1704da4bda41fb0969dc10b19d1c Reviewed-on: https://gerrit.libreoffice.org/48369 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-23OutputDevice::GetCaretPositions takes sal_Int32 nIndex parameterStephan Bergmann
...since 16b446937e026ff5edd097e99b8d9be6ba314562 "Use OUString / sal_Int32 in vcl(outdev3.cxx,textlayout.cxx)" Change-Id: I9e77bf801c6d79e1993ac6ddecf740b3362aeafe Reviewed-on: https://gerrit.libreoffice.org/48364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-23USHRT_MAX -> SAL_MAX_UINT16Stephan Bergmann
...as BrowseBox::GetColumnId (into which _nColumnPos is passed) takes a sal_uInt16 argument Change-Id: I4b890bf0fcbc91f2f07b3614a2e07aabf3345f7e Reviewed-on: https://gerrit.libreoffice.org/48363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-23Assume this wants to SAL_WARN for the sal_uInt16 range, actuallyStephan Bergmann
Change-Id: Icdda5cbc39fc2878c869ec01349135fd56a15363 Reviewed-on: https://gerrit.libreoffice.org/48349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-23Fix odd check for nFieldLen range, assuming typosStephan Bergmann
The code used the odd combination of checking signed nFieldLen for != 0 and <= USHRT_MAX, and then converting to sal_Int16 (not sal_uInt16) ever since bf4154eb5307ec8c35f000fd1df39ef3abb2eb6d "initial import". But there are indeed various MaxTextLen properties in offapi of type short, not unsigned short, so for one assume that checking for <= SAL_MAX_INT16 (not SAL_MAX_UINT16) was actually intended. And, for another, also assume that checking nFieldLen for > 0 instead of != 0 was intended. Change-Id: I119ef3ce71ee397cb6cbca714bca154e29e6599d Reviewed-on: https://gerrit.libreoffice.org/48348 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-23USHRT_MAX -> SAL_MAX_UINT16 for XMLCharContext::m_nCountStephan Bergmann
...which is of type sal_uInt16 ever since the class got introduced with 0e3ff5db960cdf907c03445220f1e29d37fc367f "INTEGRATION: CWS oj14: #i77059# export char content helper for example line break" Change-Id: I1dcb2894861ea5b6104932d896b7166c5c0b4689 Reviewed-on: https://gerrit.libreoffice.org/48347 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-23More loplugin:cstylecast on WindowsStephan Bergmann
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862 Reviewed-on: https://gerrit.libreoffice.org/48317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-23USHRT_MAX -> SAL_MAX_UINT16 in IndexBitSetStephan Bergmann
...which is based on sal_uInt16 instead of USHORT since c5b727675460581258489d3bd569a61184ad69cd "removetooltypes: #i112600# remove tooltypes" Change-Id: I6b937961a69cc904226b05fe9679ac62e2f01c0a Reviewed-on: https://gerrit.libreoffice.org/48333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-23loplugin:useuniqueptr in HelpInterceptor_ImplNoel Grandin
Change-Id: I75c1ca2d6b0e03604bb6c96d2613261a1a05b988 Reviewed-on: https://gerrit.libreoffice.org/48297 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-23loplugin:useuniqueptr in SfxItemDisruptor_ImplNoel Grandin
Change-Id: Ie85c1a8fd699f68ffcc8853be4bf8a86cfec06e7 Reviewed-on: https://gerrit.libreoffice.org/48295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-23tdf#98931 Consider cell-anchored images when sortingSamuel Mehrbrodt
This makes images/draw objects anchored to cells move as any other content when sorting cells. Works for sorting rows and columns. Also fixes a bug where notes attached to cells were not sorted when sorting columns. Change-Id: Id9a56a15f776d5adbe382a9bca167bff48b69a0c Reviewed-on: https://gerrit.libreoffice.org/46838 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-01-22ofz#5573 Out of memoryCaolán McNamara
Change-Id: Ifb5cfdd87d7b26d18fcb66279afa7ef06beea9e3 Reviewed-on: https://gerrit.libreoffice.org/48323 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22loplugin:nullptr (clang-cl)Stephan Bergmann
Change-Id: Ie60f2cc7c3b0bcba7ddf2e7a0f6837c821b33dcc Reviewed-on: https://gerrit.libreoffice.org/48313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-22loplugin:redundantcast (clang-cl)Stephan Bergmann
Change-Id: If1a5289ce346fa94f7aa8080a50572d6f9cade53 Reviewed-on: https://gerrit.libreoffice.org/48314 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-22loplugin:cstylecast (clang-cl)Stephan Bergmann
manual fix in macro code too difficult for current rewriting plugin Change-Id: I4a2221d0cfb64dc0a0c6619cd9bc776e283da499 Reviewed-on: https://gerrit.libreoffice.org/48316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-22loplugin:cstylecast (clang-cl, manual fix of conditional code)Stephan Bergmann
Change-Id: I7d9c935897107fd0c8471f472234d789e9b8c2da Reviewed-on: https://gerrit.libreoffice.org/48315 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-22ofz#5575 call cleanup while its still a SmXMLImportCaolán McNamara
Change-Id: Ib80010410bd729e2356fe63f96809dd35fb26a73 Reviewed-on: https://gerrit.libreoffice.org/48320 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22ofz optimize this unique name generator a tadCaolán McNamara
Change-Id: Ie18f71febbfc5e1ed4300782919bbd92d76ea51b Reviewed-on: https://gerrit.libreoffice.org/48318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22limit the rest of CSS1_PIXLENGTH usersCaolán McNamara
Change-Id: I59487bb337bc8821cb995fd258602ff7fb580d54 Reviewed-on: https://gerrit.libreoffice.org/48311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22ofz#5561 Integer-overflowCaolán McNamara
Change-Id: I57660848190efff8e6354670eb68b60ed57f0094 Reviewed-on: https://gerrit.libreoffice.org/48308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22Updated coreAdolfo Jayme Barrientos
Project: help d8623712ce8523cd6d29116a5bd903e1d7edbd62 tdf#35301 Tiny text tweak for newly available ruby position Ruby text can not only be above base text, but also beside it. Change-Id: Ic9a11a1f7912c50d092f13c6d3d52d83713cd305
2018-01-22uitest for tdf#108124Zdeněk Crhonek
Change-Id: If500712e1fddc2a65b5c2df1649231ff3b46a45b Reviewed-on: https://gerrit.libreoffice.org/47019 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-22loplugin:unnecessaryparen (clang-cl)Stephan Bergmann
Change-Id: Iff2b28120e0c43f13d4fb21a75746f2a289214c7 Reviewed-on: https://gerrit.libreoffice.org/48312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-22gbuild: always compile as C++17 with MSVC 2017Michael Stahl
The current update MSVC 2017.5 supports fancy new C++ features, but unfortunately in its default C++14 mode it falls over and dies with an internal compiler error as soon as it sees the WeakImplHelper variadic template. In order to work around the ICE, build everything as C++17, which somehow doesn't crash. This causes loads of deprecation warnings about obsolete std::this and badly designed std::that, almost all of them from boost headers, which are well known for following every best practice in the C++ book. Liberally sprinkle macros around to suppress the warnings for now, like we already do with the other million warnings from boost headers. Change-Id: Ia6b6ef5e457b5fe3c8cfe361ba5da39376bb7c4c Reviewed-on: https://gerrit.libreoffice.org/48225 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-22sw: add an assert wrt. recent bug in SwHTMLParser::SplitAttrTab()Michael Stahl
Change-Id: I1fa64beb4724675c2e23bd5d4f0766f6d4cf7873
2018-01-22sw: prefix members of SwDocInfoField, SwDocStatField and SwDocStatFieldTypeMiklos Vajna
Change-Id: I8c6e618266f56148df385eb140668730d9b06ed3 Reviewed-on: https://gerrit.libreoffice.org/48293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-22ofz#5565 Indirect-leakCaolán McNamara
Change-Id: I7e201494edcf128389951e09ccfb6c7fc1e53315 Reviewed-on: https://gerrit.libreoffice.org/48309 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22Windows installer: Use blank phone # instead of x-xxx-xxx-xxxSamuel Mehrbrodt
Change-Id: Ia90de861bc3aa02e8b0bf482f602ab1ea29aae00 Reviewed-on: https://gerrit.libreoffice.org/48304 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-22crashtesting: dodgy aRect is unused anywayCaolán McNamara
assert on conversion fdo66047-1.odt to doc of too large long from Fraction Change-Id: I057eb41791eb3b454192540da5e1f1d099487839 Reviewed-on: https://gerrit.libreoffice.org/48324 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22StartExecuteAsync doesn't need a second paramNoel Grandin
we can just use this to store a keep-alive reference in AsyncContext Change-Id: I0152aef5386aa9753b48afdfc958790f10d13560 Reviewed-on: https://gerrit.libreoffice.org/48294 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-22tdf#105226 fix incorrect AM/PM symbol in locale it_IT.Winfried Donkers
Change-Id: I95ecc3163ea6081e51ce78653cebf292bee7b440 Reviewed-on: https://gerrit.libreoffice.org/48247 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-22tdf#114523 Make inline tooltips for changes optionalheiko tietze
Tooltips on tracked changes are not shown when Show track changes is switched off; additional property introduced at Tools > Option > Writer > Changes to disable the inline tooltip completely Change-Id: I5b54895bb22d167a383b06627c69326c3c2f5b02 Reviewed-on: https://gerrit.libreoffice.org/46971 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-01-22tdf#35301 Modify Asian phonetic guide dialog.Mark Hung
* Add a new ruby position option "Right" in the Asian phonetic guide dialog. * Allow set/get RubyPosition property via XRubySelection interface. Change-Id: I306450ad32f0eff71f284c85e78497a341bc7971 Reviewed-on: https://gerrit.libreoffice.org/48209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-01-22Actually remove the now-unnecessary, bad downcastStephan Bergmann
...after 8aa37ca1b94a340c0ca3dc4edebdc501edc25cf5 "ubsan SwTableBoxFormat is really SwTableLineFormat" Change-Id: I24d092a6cb4d3642e22045acde7eeffaf908075e
2018-01-22sc: std::iterator is deprecated in C++17Michael Stahl
Change-Id: I947dcf61e95bdc68d19eab7daca4c31ba8047d5e Reviewed-on: https://gerrit.libreoffice.org/48224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-22update flatpak-manifestDavid Tardon
Change-Id: If97c2f8826cbbd83821d9211040f1857e1a1e17f
2018-01-22Presumably misplaced castStephan Bergmann
...that was originally introduced as int intRadius = (int) radius + 1.0; in 05363527d84119c6759cdd638c76b041f2aa67b7 "Separable Gaussian Blur and Unsharpen Mask filter", and presumably was meant to cover the whole right-hand- side addition, not just "radius". Change-Id: I3c14f4055e74e3e4dcccbddce060a86f9bcc23f0 Reviewed-on: https://gerrit.libreoffice.org/48005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-01-22tdf#109062 restore osx scrollwheel logicCaolán McNamara
to pre commit f7d2bf216afa10268e6a7c1d4613a2fd8f7c7f3c Date: Tue May 16 10:12:09 2017 +0100 Resolves: tdf#103174 & rhbz#1367846 improve gtk3 trackpad scrolling state. Change-Id: If5a494441731e73136158b4905c2744ba8bc8875 Reviewed-on: https://gerrit.libreoffice.org/48249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22iOS, performance updatejan Iversen
Set SAL_LOG to empty in SIMULATOR scheme, allowing to easy add +WARN+INFO when testing. Removed duplicate entry in Info.plist Change-Id: I7d0231b0c30fd710e578f91b450c3c16696deb08
2018-01-22tdf#100370 Selection icon now working properly on mouse clickKshitij Pathania
Change-Id: I45786ab3eb0b93d2f987d83156011b768869a414 Reviewed-on: https://gerrit.libreoffice.org/48279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
generated by cgit (git 2.34.1) at 2024-07-21 01:30:22 +0000