summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-02-01tdf#105620: Probably better to not ignore initial x0 and y0Tor Lillqvist
So add to them instead of just assigning. In the bugdoc the initial values were zero, but maybe in some other cases they aren't. Change-Id: I3d399fe4aab9260817f171d4e69388a19eb85d21
2017-02-01loplugin:useuniqueptr extend to check local varsNoel Grandin
just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01gpg4libre: Support building --with-system-gpgme (Linux only so far)Katarina Behrens
Change-Id: I22af89b920d43f3fc5f0fff02070f288bfa59fb4 Reviewed-on: https://gerrit.libreoffice.org/33702 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-02-01tdf#105461 PDF export: handle text fill colorMiklos Vajna
Text portion level background in Writer text was working already, as Writer paints its background explicitly, and then uses no text fill color in the metafile (that is turned into a PDF later). However, text fill color is used for Writer shape text and also in Impress. The rectangle is not just the text itself, but also the ascent / descent region, this matches the desktop rendering result. Change-Id: I644007ade43a8b9e663890643b826ae12c427ea5 Reviewed-on: https://gerrit.libreoffice.org/33781 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-01-Wunused-macrosJochen Nitschke
Change-Id: I2d3b6f22deee0f2b9ec39592b89e0e4742659593 Reviewed-on: https://gerrit.libreoffice.org/33782 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-01xmlsecurity: various small cleanupsMiklos Vajna
Change-Id: Id713460036331fd9f98fd1eca85ca61f57cf5afe Reviewed-on: https://gerrit.libreoffice.org/33779 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-01tdf#105620: Fix placement of image embedded in graphicTor Lillqvist
Change-Id: I419e44d72f594fab0774152720f55c1d7d5366e6 Reviewed-on: https://gerrit.libreoffice.org/33723 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-02-01external/breakpad: Work around -fsanitize=alignmentStephan Bergmann
...as seen in the scenario described in 5997121a51e240c762b4d002d7d16b94ac13d4a1 "Support signal handlers registered with SA_SIGINFO", first > src/client/linux/minidump_writer/directory_reader.h:82:19: runtime error: member access within misaligned address 0x7f3f8235c2cc for type 'struct kernel_dirent', which requires 8 byte alignment > 0x7f3f8235c2cc: note: pointer points here > 10 02 00 00 d8 f8 3b 00 00 00 00 00 01 00 00 00 00 00 00 00 18 00 2e 00 00 00 00 04 02 c7 3b 00 and then > src/client/linux/minidump_writer/linux_dumper.cc:382:19: runtime error: member access within misaligned address 0x7f96c225d7bc for type 'google_breakpad::MappingInfo', which requires 8 byte alignment > 0x7f96c225d7bc: note: pointer points here > 20 0a 32 30 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > ^ Change-Id: I7f739567879093a404bee3e351ce9e8257676183
2017-02-01Support signal handlers registered with SA_SIGINFOStephan Bergmann
...as is the case for external/breakpad's google_breakpad::ExceptionHandler::SignalHandler (though that one appears to be careful to check that its additional arguments are not garbage, cf. the "Sometime, Breakpad runs inside a process where some other buggy code..." comment in workdir/UnpackedTarball/breakpad/src/client/linux/handler/exception_handler.cc). Seen when JunitTest_framework_complex run under ASan/UBSan happened to trigger an assert, > soffice.bin: vcl/source/app/dbggui.cxx:47: void ImplDbgTestSolarMutex(): Assertion `ImplGetSVData()->mpDefInst->CheckYieldMutex() && "SolarMutex not locked"' failed. > sal/osl/unx/signal.cxx:349:13: runtime error: call to function google_breakpad::ExceptionHandler::SignalHandler(int, siginfo_t*, void*) through pointer to incorrect function type 'void (*)(int)' > (instdir/program/libsofficeapp.so+0xb7eab0): note: google_breakpad::ExceptionHandler::SignalHandler(int, siginfo_t*, void*) defined here > #0 0x7f6cefc21693 in (anonymous namespace)::callSystemHandler(int) sal/osl/unx/signal.cxx:349:13 > #1 0x7f6cefc1f3e1 in (anonymous namespace)::signalHandlerFunction(int) sal/osl/unx/signal.cxx:422:9 > #2 0x7f6cedbc95bf (/lib64/libpthread.so.0+0x115bf) > #3 0x7f6ced20491e in __libc_signal_restore_set /usr/src/debug/glibc-2.24-33-ge9e69e4/signal/../sysdeps/unix/sysv/linux/nptl-signals.h:79 > #4 0x7f6ced20491e in __GI_raise /usr/src/debug/glibc-2.24-33-ge9e69e4/signal/../sysdeps/unix/sysv/linux/raise.c:55 > #5 0x7f6ced206519 in __GI_abort /usr/src/debug/glibc-2.24-33-ge9e69e4/stdlib/abort.c:89 > #6 0x7f6ced1fcda6 in __assert_fail_base /usr/src/debug/glibc-2.24-33-ge9e69e4/assert/assert.c:92 > #7 0x7f6ced1fce51 in __GI___assert_fail /usr/src/debug/glibc-2.24-33-ge9e69e4/assert/assert.c:101 > #8 0x7f6cb60cdad5 in ImplDbgTestSolarMutex() vcl/source/app/dbggui.cxx:47:5 > #9 0x7f6cbd337fb9 in DbgTestSolarMutex() tools/source/debug/debug.cxx:74:9 > #10 0x7f6cb3c98abf in vcl::Window::ReleaseGraphics(bool) vcl/source/window/window.cxx:900:5 ... Change-Id: I2625541e0b9e50f9723e61e0cbff0e6c77d0fb9f
2017-02-01Resolves: tdf#100438 focus trapped in disabled toolbarCaolán McNamara
lets just leave the toolbar active the whole time, seems to make more sense anyway wrt being allowed to keyboard into it to paste/insert special character Change-Id: I174fb707c4c7fd21d95461cc93323eb6d8970818
2017-02-01InfoBar: Introduce different typesSamuel Mehrbrodt
Makes it easier to push various infobars without specifiying the colors manually. Change-Id: I0f861ba02409a42ba2ae767a1ca7634eaf0e7aef Reviewed-on: https://gerrit.libreoffice.org/33777 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-01improve exception messages in stocNoel Grandin
Change-Id: I43716332ab916e5ec7b8ab7a4d14895d060a9bd4 Reviewed-on: https://gerrit.libreoffice.org/33692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01stoi not a member of std under android toolchainCaolán McNamara
Change-Id: I73a4e7894e33dd95ca50ea25f5f95bf94a43531e
2017-02-01with navigator in sidebar, press space, crashCaolán McNamara
because root entries have UserData of type SwContentType while children have UserData of type SwContent (both inherit from SwTypeNumber) Change-Id: Iab7a4caaca5dfdae16aa4f6ede565e26aa4c73c9
2017-02-01turn switch with one case into ifCaolán McNamara
Change-Id: I413f195bb5571eb536e948a7e9ffb982b3619e65
2017-02-01Improve InfoBar labels for signaturesSamuel Mehrbrodt
Change-Id: I50619d94c7bebeb99b5dbb9e21f0eefa3fd39482 Reviewed-on: https://gerrit.libreoffice.org/33778 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-01ofz#506 check len before allocCaolán McNamara
Change-Id: Ia3a30936fadde10275a964d09150a3b6e4f3e16f
2017-02-01An env var to disable font lookupKhaled Hosny
To be used in layout tests. Change-Id: I551b87786a4ad4ab34a22c458561109270fb4a31
2017-02-01upload zlib 1.2.11David Tardon
Change-Id: I4e19a9d976c28f5e6649bdbb3dd609e03a4c03a8 Reviewed-on: https://gerrit.libreoffice.org/33770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-02-01loplugin:stringconstant handle calls to constructors with one argNoel Grandin
Change-Id: Ide9148a908bef46ba14640dfa6f556beaf6e3f60 Reviewed-on: https://gerrit.libreoffice.org/33772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01defaults are good enough ..Jochen Nitschke
for copy ctor/assignment and dtor. inline MEMBER_CONSTRUCTOR_LIST macro Change-Id: I50296cebca3bc1aa43376ccd538c84df68a232a2 Reviewed-on: https://gerrit.libreoffice.org/33771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01inline macrosJochen Nitschke
move static arrays to anonymous namespace try creating the SotAction arrays at compile time with constexpr Change-Id: If0d0563b35936574beea617da08880a6c32569d9 Reviewed-on: https://gerrit.libreoffice.org/33750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01loplugin:stringconstantStephan Bergmann
Change-Id: Ic22b9c0c245cca23770a05518534a666e00f9f3e
2017-02-01gbuild-to-ide: VSGenerator and testVs2013 with relative linksFederico Bassini
VisualStudio2013IntegrationGenerator recently doesn't work with the new relative paths in GbuilParser. this patch does this, now it works fine with all relative paths. what is missing it's in the .vcxproj: <NMakeBuildCommandLine> <NMakeCleanCommandLine> <NMakeReBuildCommandLine> these still work with absolute path but i start now on working this Change-Id: I19610097edc11be67b4f7fd9f32b6683d334cc2d Reviewed-on: https://gerrit.libreoffice.org/33735 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2017-02-01convert ScChartGlue to scoped enumNoel Grandin
Change-Id: Ia3dd20988d26e23e94581b019ff32c9ebc8663fe Reviewed-on: https://gerrit.libreoffice.org/33753 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01makeAny->Any in accessibility..avmediaNoel Grandin
Change-Id: I70f2dfa66d7b66738a840e4a7b5c7fb1b8d7b39f Reviewed-on: https://gerrit.libreoffice.org/33756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01starmath: Simplify and micro-optimize lookup in SmIsMathAlpha()Takeshi Abe
Change-Id: Ica2e0d14141785b9e14c05179e517117afadc5e0 Reviewed-on: https://gerrit.libreoffice.org/33734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-01Convert RID_POPUP_TABBAR to xmlMaxim Monastirsky
Change-Id: Ic4587b8e244c52089692908fe0d10e363b5ed4fb
2017-01-31SolarMutexGuard for ImplDbgTestSolarMutex assert in JunitTest_dbaccess_complexCaolán McNamara
Change-Id: Ic2109abdec0ad3305c2720ac9012585cd7ceb25b
2017-01-31upload libmwaw 0.3.10David Tardon
Change-Id: I1355f60bdaf66aecef22f1093f57369b9fd91972 Reviewed-on: https://gerrit.libreoffice.org/33745 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-01-31tdf#105623 - Two labels for the same functionOlivier
Change-Id: I0c6e1ed8a7ef90602e3309226481bd91f390f866 Reviewed-on: https://gerrit.libreoffice.org/33751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-31Replace a terribly expensive json parsing with a peek for the value.Jan Holesovsky
We should reduce the amount of callbacks from the core in the first place, so that we don't have to deduplicate this much here, but this already helps a lot. Change-Id: Idf4a3681ac0f47536e00c1d97152f3f8bb99894b
2017-01-31Build the json message a much less expensive way.Jan Holesovsky
Change-Id: I10911deb52f6a0c65262f9d6af459cf6ddd2fae9
2017-01-31Revert "Lok: support for batch API calls"Jan Holesovsky
This was for the moment removed from the online.git, so let's disable the API bits too before it shows this is really necessary. Reverts also: Revert "Lok: unittest batch API" Change-Id: I7bf3fe62d1e73b6f233992d51f587868a78f4bec
2017-01-31add pct fuzzerCaolán McNamara
Change-Id: I6a1787b484479268223fb59bf510c20be833d4d0
2017-01-31Resolves: tdf#104884 print preview replaces the frame controllerCaolán McNamara
so the sidebar is listening to the old controller which has been disposed[1] so when print preview exits and yet another controller replaces the print preview one then the sidebar still doesn't listen to the current one. framework broadcasts COMPONENT_DETACHING/COMPONENT_REATTACHED around these changes, so if we listen to them we can keep attached to whatever is the current component [1] note that ContextChangeEventMultipler doesn't inform clients that the controller has been disposed, this remains unchanged here Change-Id: I141509d4a262307afd7dcfc3d77de6cdd6dbfa5f Reviewed-on: https://gerrit.libreoffice.org/33758 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-31Compatibility options refactoring. Part 1 small fixVitaliy Anderson
SvtCompatibilityOptions_Impl::impl_GetPropertyNames() solve problem with wrong lProperties names Change-Id: I0b71a80d542d8175c3f6e6cdf5fe857143714acb Reviewed-on: https://gerrit.libreoffice.org/33752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-01-31tdf#105637 Digital signatures dialog has unnessary labelsSamuel Mehrbrodt
Change-Id: I474968d566a31fba29bcdc1f74749de8e86fedce Reviewed-on: https://gerrit.libreoffice.org/33754 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31tdf#105566 Close Infobar after clicking action buttonSamuel Mehrbrodt
gpg4libre Change-Id: I24c7021043c5fb1a2a8ef1fbce66f8e416377692 Reviewed-on: https://gerrit.libreoffice.org/33755 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31tdf#105625: allow editing around field marksMike Kaganski
This commit fixes commit aa799f64723933bbb46544f835a970cfcbb90384, and partially reverts commits bd505fdb9f669f365ff39b0ef46f0742c638e333 and 9104d5e8905c2ec2b576b5ca452d3e23d5555e49 that seem unnecessary now. Unit test included, the existing unit tests of partially reverted commits are kept. Change-Id: I2a02cda546f5d484553c3b9467993fca36dae140 Reviewed-on: https://gerrit.libreoffice.org/33722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-01-31renumber global string IDs and close gapsEike Rathke
Eliminating 11 unused IDs that occupied empty elements in the string table. Also moved STR_ERR_NAME_INVALID_CELL_REF to the proper position. Change-Id: I2534476895edb438c7404d781781e6088adf0385
2017-01-31gtktiledviewer: gtk version checksPranav Kant
There is no major harm in excluding these lines of code on platforms with older gtk. Change-Id: Ica3f1e2b4f60f0bab55254632663ace7b4c61d4d
2017-01-31Build the ODK examples during subsequentcheckStephan Bergmann
...at least on Linux for now Change-Id: Id9d909a3b071c37ba0cd29bbff0edb83d937145f
2017-01-31Allow some OO_SDK_*_HOME to be emptyStephan Bergmann
...in which case the corresponding tool is located on the PATH Change-Id: I4242180fbbc829f11aa1a12cf1e6b9f0a21ab7c6
2017-01-31Use white font for colored InfoBarsSamuel Mehrbrodt
Change-Id: I35ac32fc213afe7dc8f3ed29caaa982117ec7737 Reviewed-on: https://gerrit.libreoffice.org/33748 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31tdf#105566 Show InfoBar also for signed docs with warningsSamuel Mehrbrodt
gpg4libre Change-Id: Ia3df9d9d8121539fd1c6b77f8872287b0b432d8e Reviewed-on: https://gerrit.libreoffice.org/33744 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31Add helper methods to get common colors to SfxInfoBarSamuel Mehrbrodt
Change-Id: Ic3816b046839636fa0d1b8cb881725bcc80ef011 Reviewed-on: https://gerrit.libreoffice.org/33742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31tdf#105566 Show InfoBar when signature is invalidSamuel Mehrbrodt
gpg4libre Change-Id: I272ac155889e25b9af91ff723a014588a65b045a Reviewed-on: https://gerrit.libreoffice.org/33737 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31sfx2: fix comment copypastaMichael Stahl
Change-Id: Iebb5f51afe6f32883a535656d8b9e1f0ec678050
2017-01-31more SAL_WARN_UNUSEDNoel Grandin
Change-Id: Idf44fe0302b4504c443f083e527b63b2461ada85
generated by cgit (git 2.34.1) at 2024-07-14 13:25:10 +0000