summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-18Line Style Tab Page alignment improvementandreas kainz
Change-Id: Ia546a6bc72f133af9bba704741ed47c1f30bb0f5 Reviewed-on: https://gerrit.libreoffice.org/79512 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-18Fix building against MySQL Connector/C 8Peter Levine
In MySQL Connector/C 8, my_bool is replaced by bool. It was previously defined as char. When building against MySQL Connector/C 8, this leads to type punning build errors. Redefine affected members of struct BindMetaData as bool if using version 8 of greater. Otherwise, default to char. Change-Id: If12b975d95afae86502867cb334cb4195802f91d Reviewed-on: https://gerrit.libreoffice.org/81002 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-18loplugin:virtualdead unused params in IMailDispatcherListenerNoel Grandin
Change-Id: I0cc6a813db88efc98673400447d98e50c32bc720 Reviewed-on: https://gerrit.libreoffice.org/80962 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-18cid#1454847 : introduce an explicit constructor...Dennis Francis
for NFIndexAndFmtType that initializes all its members appropriately. Change-Id: Iec675458bca169c79b3a27f775ccff5265cee22d Reviewed-on: https://gerrit.libreoffice.org/81004 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-10-18tdf#128208: Don't crash if the zip archive is brokenTor Lillqvist
Change-Id: I71f91752e6adeca1970a21c793cad3b5a5aeba13
2019-10-18tdf#128208: Add a testbench for the Spotlight importerTor Lillqvist
Makes it much easier to test it. Change-Id: I74c8651e34e9247acfa36c35165e5d7e4e32bb6e
2019-10-17loplugin:virtualdead unused param in BinaryObj::dataNoel Grandin
Change-Id: I726745b82747f24cc93662bfb0dd381a114fde78 Reviewed-on: https://gerrit.libreoffice.org/80955 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-17loplugin:virtualdead unused param in OOXMLDocument::setXNoteTypeNoel Grandin
which means the whole method is dead Change-Id: Ib3349f5beb8b9bb9fe223bc33aca84a20e581445 Reviewed-on: https://gerrit.libreoffice.org/80954 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-17rename LanguageBox back to SvxLanguageBoxCaolán McNamara
Change-Id: I9bd29b7377fdf0e1ba36cc021e7e78f83bb1c12c Reviewed-on: https://gerrit.libreoffice.org/80960 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17ODocumentInfoPreview not in any .ui filesCaolán McNamara
Change-Id: I8875a5b39e5a27df8b365e268bb2aab3c42300a4 Reviewed-on: https://gerrit.libreoffice.org/80959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17writerfilter: fix commentJustin Luth
The comment was introduced in commit 28a3156943 which was dealing with things being inside or outside of a paragraph. Change-Id: I1985776c4d2c0f86395e415c9943f9d6004a2fc4 Reviewed-on: https://gerrit.libreoffice.org/80929 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-10-17loplugin:virtualdead unused param in LoggedStream::lcl_infoNoel Grandin
which means the whole method is actually unused Change-Id: I72d33ab6e260012b82002ceae7ff9e54e2ea6349 Reviewed-on: https://gerrit.libreoffice.org/80953 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-17Silence Clang 10 trunk -Wdeprecated-volatile in GLib for nowStephan Bergmann
See <https://gitlab.gnome.org/GNOME/glib/merge_requests/1170> "Avoid C++20 deprecated assignment to volatile" for a potential fix in GLib (but also see my question at <https://github.com/llvm/llvm-project/commit/ 4a6861a7e5b59be24a09b8b9782255d028e7aade#commitcomment-35540755> "[c++20] P1152R4: warn on any simple-assignment to a volatile lvalue" whether that Clang warning is actually wanted here). With glib2-devel-2.62.1-1.fc31.x86_64, the suppressed warnings looked like > libreofficekit/source/gtk/lokdocview.cxx:327:1: error: use of result of assignment to object of volatile-qualified type 'volatile gsize' (aka 'volatile unsigned long') is deprecated [-Werror,-Wdeprecated-volatile] > G_DEFINE_TYPE_WITH_CODE (LOKDocView, lok_doc_view, GTK_TYPE_DRAWING_AREA, > ^ > /usr/include/glib-2.0/gobject/gtype.h:1617:56: note: expanded from macro 'G_DEFINE_TYPE_WITH_CODE' > #define G_DEFINE_TYPE_WITH_CODE(TN, t_n, T_P, _C_) _G_DEFINE_TYPE_EXTENDED_BEGIN (TN, t_n, T_P, 0) {_C_;} _G_DEFINE_TYPE_EXTENDED_END() > ^ > /usr/include/glib-2.0/gobject/gtype.h:2034:3: note: expanded from macro '_G_DEFINE_TYPE_EXTENDED_BEGIN' > _G_DEFINE_TYPE_EXTENDED_BEGIN_REGISTER(TypeName, type_name, TYPE_PARENT, flags) \ > ^ > /usr/include/glib-2.0/gobject/gtype.h:2005:7: note: expanded from macro '_G_DEFINE_TYPE_EXTENDED_BEGIN_REGISTER' > g_once_init_leave (&g_define_type_id__volatile, g_define_type_id); \ > ^ > /usr/include/glib-2.0/glib/gthread.h:257:17: note: expanded from macro 'g_once_init_leave' > (void) (0 ? *(location) = (result) : 0); \ > ^ Change-Id: If67ad04f8fb242f50b43a1d98ad2b28c4bed55a4 Reviewed-on: https://gerrit.libreoffice.org/80937 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-17Fix typoAndrea Gelmini
Change-Id: I179a20caf33e8e083e6e8f172d38f1201a0afd16 Reviewed-on: https://gerrit.libreoffice.org/80987 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-17Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - compatible.xhp page split is causing lost link in 03103350.xhp page Change-Id: Id807bedacc0c71fed8e6f5cdae77814e478b2bdd Reviewed-on: https://gerrit.libreoffice.org/80940 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-17drop swuilo-AutoFmtPreviewCaolán McNamara
Change-Id: Ib9a4d5ff89a4cfd8006d70fe3a1e193095150ee8 Reviewed-on: https://gerrit.libreoffice.org/80958 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17loplugin:virtualdead unusedparam in LoggedTable::lcl_entryNoel Grandin
Change-Id: I45c7330b3803f21165714c6140fac46a6592db9b Reviewed-on: https://gerrit.libreoffice.org/80952 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-17loplugin:buffereadd find stuff involving adding *StringBufferNoel Grandin
and create conversion methods on *StringBuffer to make this work Change-Id: I3cf5ee3e139826168894b46eff8ee4bcde00cb7e Reviewed-on: https://gerrit.libreoffice.org/80949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-17rename TextEncodingBox back to SvxTextEncodingBoxCaolán McNamara
Change-Id: I466a56a3b3204f960b9c6ce2dac836879112f5ab Reviewed-on: https://gerrit.libreoffice.org/80945 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17drop ScCsvTableBoxCaolán McNamara
Change-Id: Id73eb4c941ac9bcf75c518cefba795de587edbd9 Reviewed-on: https://gerrit.libreoffice.org/80957 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17Resolves: tdf#126773 Excel uses lowercase date and time format code keywordsEike Rathke
... so do the same when exporting to prevent surprises with iOS and OSX viewers or maybe other tools. This made it necessary to adapt ScExportTest::testExtendedLCIDXLSX() that checks calendar and date relevant exported format strings. Change-Id: I243d536e2a42562ec46375923facfa222ecbb29b Reviewed-on: https://gerrit.libreoffice.org/80920 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-10-17loplugin:virtualdead dead propertygroup functionalityNoel Grandin
ever since it was introduced in commit d09dd8986436f17717443823ef18bd8552fdf408 Date: Wed Sep 15 13:55:34 2010 +0200 dba34a: export/import min-/max-/default-/value for date/time as XML-Schema conformant strings looks like classic over-engineering Change-Id: Ia4e4b65cfe92f522dee238a54a37db01f691750e Reviewed-on: https://gerrit.libreoffice.org/80951 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-17loplugin:virtualdead look for virtual methods where a param is unusedNoel Grandin
Change-Id: Ibadc2aa79a52082db16eff44c89ab30938838dd8 Reviewed-on: https://gerrit.libreoffice.org/80935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-17tdf#125508 remove border frame from shadows and presetsCaolán McNamara
Change-Id: I022f64188e49553bd7bef38cdd51620dfa0b90cd Reviewed-on: https://gerrit.libreoffice.org/80883 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-17gbuild: Treat 'DBUS_GLIB_CFLAGS' as includes, not definesMichael Weghorn
Since that variable holds the relevant includes, using 'gb_LinkTarget_set_include' makes sure that those flags end up in the correct section, e.g. when generating IDE integration using 'gbuild-to-ide'. E.g. for the 'qtcreator-ide-integraton' make target, this makes sure that they end up in the 'INCLUDES' section in 'sd/sd.pro' and not the 'DEFINES' section, which previously led to an "error: macro name must be an identifier" being shown when editing files underneath 'sd/' in Qt Creator with the Clang Code Model plugin enabled, s.a. commit 4aa60490622cc10f8d3a31489c62a5622d240c83 ("gbuild: treat $({QT,KF}5_CFLAGS) as cxxflags, not defines"). Corresponding entry in my config_host.mk.in on Debian bullseye/testing: export DBUS_GLIB_CFLAGS=$(gb_SPACE)-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include Change-Id: I9af9a58fdc05ce6648221c00a20859be777843f9 Reviewed-on: https://gerrit.libreoffice.org/80944 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-10-17Don't use uninitialized memory when reading from the stream failsStephan Bergmann
Valgrind'ing CppunitTest_sc_filters_test failed with > Conditional jump or move depends on uninitialised value(s) > at 0x21175CE0: XclRange::GetColCount() const (/sc/source/filter/inc/xladdress.hxx:73) > by 0x2117048D: ImportExcel::ReadDimensions() (/sc/source/filter/excel/impop.cxx:248) > by 0x21188E78: ImportExcel8::Read() (/sc/source/filter/excel/read.cxx:1108) > by 0x21123C3F: ScFormatFilterPluginImpl::ScImportExcel(SfxMedium&, ScDocument*, EXCIMPFORMAT) (/sc/source/filter/excel/excel.cxx:137) [...] when loading sc/qa/unit/data/xls/pass/CVE-2006-3086-1.xls. As there appears to be no error-handling concept in ImportExcel::ReadDimensions, at least zero-initialize the relevant variables. Change-Id: I11dbd2a1032ecc723f65a563ef022d7eb3c970ff Reviewed-on: https://gerrit.libreoffice.org/80948 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-17Don't use uninitialized memory when reading from the stream failsStephan Bergmann
Flathub arm builds (but not other arches) had often (but not always) failed when processing sc/qa/unit/data/qpro/pass/ofz14090-1.wb2 in CppunitTest_sc_filters_test (e.g., <https://flathub.org/builds/#/builders/1/builds/724>: > Test name: ScFiltersTest::testCVEs > equality assertion failed > - Expected: 1 > - Actual : 0 > - file:///run/build/libreoffice/sc/qa/unit/data/qpro/pass/ofz14090-1.wb2 ) Valgrind revealed that this was due to using unintialized memory when the various maIn.Read... in QProToSc::Convert failed, starting with the use of uninitialized nFmla[i] after maIn.ReadUChar( nFmla[i] ); At least make things deterministic by setting the relevant variables to zero. (Another approach could be returning early with some ConvErr status.) Change-Id: I4c06aa8da5f777170cdc7bbe3ca1d61b23d3f326 Reviewed-on: https://gerrit.libreoffice.org/80947 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-17ofz#18280 remove LinkedFile supportCaolán McNamara
The code to create these "linked files" added by: commit 6f2f7e3091504e8e58d9be603ed3739f6f2cd68e Author: Mathias Bauer <mba@openoffice.org> Date: Fri Jul 6 14:03:59 2001 +0000 #89377#: new StorageMode for creating unpacked files use of creating them then introduced in: commit 53fe2691a3fb65110e7f5aee2919f7d8d559ff02 Author: Mathias Bauer <mba@openoffice.org> Date: Fri Jul 6 13:55:57 2001 +0000 #88062#: some optimizations that use then commented out in: commit 762dd2b15bfd201b2271b460efa72a5b68d6fb2a Author: Kurt Zenker <kz@openoffice.org> Date: Mon Oct 4 19:53:11 2004 +0000 and the unused code to create them removed in: commit 8a91528a3e03fe6e2923c33327b687ecf57adb0b Author: Stephan Bergmann <sbergman@redhat.com> Date: Thu May 7 10:37:27 2015 +0200 StorageMode::CreateUnpacked is never used It seems to me that there is no need to keep support for reading them as they seem to have been temporary files rather than something still existant Change-Id: I783cae63dc078a7e843729d3ca13f45c18168f4c Reviewed-on: https://gerrit.libreoffice.org/80943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17SvxLanguageBox is now unusedCaolán McNamara
Change-Id: I5aafb53bb9885b8b0b43161f1afc79852b1d89a3 Reviewed-on: https://gerrit.libreoffice.org/80767 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17Resolves: tdf#128129 add support for left/right expand/collapseCaolán McNamara
Change-Id: I6c8f11e1e2b4192933541e754a078c4d0ff58206 Reviewed-on: https://gerrit.libreoffice.org/80938 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17SvxTextEncodingBox is now unusedCaolán McNamara
Change-Id: I0276d79cd713357d36d504e8501cd1b979e86c9c Reviewed-on: https://gerrit.libreoffice.org/80766 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17weld ScImportAsciiDlgCaolán McNamara
notably the csv control is always LTR even in RTL mode, but the surrounding ScrollingWindow follows the environment direction, except the horizontal scrolling widget itself must LTR scroll. Change-Id: I72ee2b9dade73a11bcc4391e755fdb02886a884d Reviewed-on: https://gerrit.libreoffice.org/80765 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17Resolves tdf#127994 - Totd dialog get resized horizontallyHeiko Tietze
Width request set to 350 Change-Id: Ib974417282c76b4cede1b4773159b1fa748ddbfb Reviewed-on: https://gerrit.libreoffice.org/80887 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-17tdf#128166 sd: Fix canvas initialization argsMichael Weghorn
Commit 5926b22b5dc33490d23d594b129eb8a70b94ffb0 ("The SystemEnvData passed into the canvas factories appears to be unused") removed previous arg at index 1, so adapt here, too. This makes the presenter console shown again (tdf#128166). A visible result of FullScreenPane::CreateCanvas passing wrong args was that an Impress presentation shown in presentation mode in dual screen using the qt5/kf5 VCL plugin wouldn't terminate properly and crash Impress on close. Change-Id: I3933864d4bb007cfdefb0a20378ff3d75ea6cd85 Reviewed-on: https://gerrit.libreoffice.org/80933 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Michael Weghorn <m.weghorn@posteo.de>
2019-10-17tdf#121657 Show warning when no hyphenation info available for current langSamuel Mehrbrodt
Change-Id: I96114470d6151392e42e6938d92d4175022dbbe2 Reviewed-on: https://gerrit.libreoffice.org/80931 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-17loplugin:stringadd fix conditionNoel Grandin
Change-Id: I7752c281b1b6dd0d26bd7d6c4a6896c663f4cbc3 Reviewed-on: https://gerrit.libreoffice.org/80921 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-17Remove some memset callsMike Kaganski
Replace them with default initialization or calloc Change-Id: I747f53c2ced2d0473fd5a5ede4f8520a0633dcc1 Reviewed-on: https://gerrit.libreoffice.org/80805 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-17Remaining loplugin:bufferaddStephan Bergmann
...that had been missing because the plugin didn't implement postRun, so it didn't report anything when run as part of the shared plugin. (But did report the expected warnings when run as a standalone plugin during CompilerTest_compilerplugins_clang.) Most fixes are straightforward. A noteworthy one is PreparedStatement::setBytes in connectivity/source/drivers/postgresql/pq_preparedstatement.cxx: The old preallocation of a 20 character OStringBuffer might have prevented buf.append( reinterpret_cast<char *>(escapedString), len -1 ); from potentially throwing std::bad_alloc, which would have caused escapedString to be leaked. Even though that 20-character preallocation was likely just random junk and not meant to address the potential leak, lets address it now. Change-Id: Ib506332d061684a22a74e5e39e591539fd2c4900 Reviewed-on: https://gerrit.libreoffice.org/80925 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-17writerfilter: clean up now redundant PROP_LAYOUT_IN_CELLMiklos Vajna
Which is now exactly the same as PROP_FOLLOW_TEXT_FLOW, so no need to set it separately. Change-Id: I32e1e2bdfb8ac46eb6a07f5187f780275d334b2f Reviewed-on: https://gerrit.libreoffice.org/80926 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-17Add Name and Description to group context menuandreas kainz
Change-Id: Icc19b6e3493f1d9e49584c3e2ac99509fae4e02e Reviewed-on: https://gerrit.libreoffice.org/80923 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-17Cache last used number-format-type in interpreter-contextDennis Francis
if in cpu-threaded mode so that we can avoid the unnecessary locked SvNumberFormatter::GetType() calls (Mapping between NF index and NF-type does not change while formula-group-threading is running). Change-Id: I648bc08c885da845f0b09cd57013cc1c23e01a61 Reviewed-on: https://gerrit.libreoffice.org/80848 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-10-17move SSE2sum code to separate cxx file...Dennis Francis
and compile it with -arch:SSE2 if Windows. This code however gets called only if cpuid::hasSSE2() is true, so this does not cause problems with machines without SSE2 support. Change-Id: Ice23ac71d4c577b8811b08c74a3ca500a94fdc09 Reviewed-on: https://gerrit.libreoffice.org/80847 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-17Reuse pre-allocated ScInterpreter for HandleStuffAfterParallelCalculationDennis Francis
Change-Id: Idf10bb214d6d82370512eeb39ba7786dd9bceb38 Reviewed-on: https://gerrit.libreoffice.org/80846 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-17Pre-allocate an ScInterpreter object for each thread...Dennis Francis
and reuse them for interpret'ing all cells under the respective threads. This gives a sizeable win in the execution time especially for long formula-groups. Change-Id: Ib340950f21e863b5b821d20c092214d8bc5012aa Reviewed-on: https://gerrit.libreoffice.org/80845 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-17Remove code that is deadStephan Bergmann
...ever since 8f55fe4c6c73f110b1c72903c209399ff2527ea5 "INTEGRATION: CWS help2" dropped p->application and "/" from strBuff. Change-Id: I48aa9271daac4caf23d932741a5c75cb00ad7ee9 Reviewed-on: https://gerrit.libreoffice.org/80924 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-17Rename OUStringLiteral1 to OUStringCharStephan Bergmann
It started out as a wrapper around character literals, but has by now become a wrapper around arbitrary single characters. Besides updating the documentation, this change is a mechanical for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f Reviewed-on: https://gerrit.libreoffice.org/80892 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-17tdf#108350 writerfilter: restore TimesNewRoman as default fontJustin Luth
Followup for LO 5.4 commit 6f2ad89b33d972f9642bb53eeb91f41df3b6b0e6 which set Calibri/11pt as default. That is true if there is no style.xml file, or more specifically if there is no DocDefaults rPrDefault node. But if that node exists, then the age-old defaults are still valid. Earlier in LO 4.3, the default templates changed to use Liberation fonts by default. But in the same vein as using Calibri (and depending on LO to fallback to Carlito), set Word's default Times New Roman font and depend on LO to fallback to Liberation. That will make it better for MSWord users who share the document and who have less likelihood of knowing about Liberation/Carlito. Note that 10pt fontsize was already added to m_pDefaultCharProps earlier, so that part was already reset long ago. Change-Id: I3ba8a529fe95b05fbe2889cf1ebdbabb25963e8b Reviewed-on: https://gerrit.libreoffice.org/80854 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-10-17Don't send false 'INPLACE' messagesSzymon Kłos
Change-Id: I8eb9a77c7e6b9242f18ac5f0634091c88bf40ec0 Reviewed-on: https://gerrit.libreoffice.org/80695 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-16Update git submodulesAndras Timar
* Update translations from branch 'master' - Updated Slovenian translation Change-Id: I7a5c6bd9fc6ac769251aca007b01ad24e11dfd61
2019-10-16Resolves: tdf#127961 Add NBSP to quotation marks for all French except fr-CHEike Rathke
Change-Id: I71e8377bf44c2db5ef291d2990528ec16aaf3b44 Reviewed-on: https://gerrit.libreoffice.org/80909 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2024-07-14 10:41:26 +0000