summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-03-02Align columns in output harderTor Lillqvist
If we are going to use printf anyway, why not use its field width and left-adjustment features and actually achieve the columnar output we presumably wanted? Change-Id: I95dbd2aaa01d06c69d23d74fa249fd3419afa8d6
2017-03-02Remove HAVE_CXX11_UTF16_STRING_LITERAL, always true nowStephan Bergmann
...after 84b36c704d73362d4d86dc9e9c0efa0625958347 "Drop support for MSVC 2013". Make this a fatal configuration error for now. The check should be removed completely after LO 5.4 branch-off. Change-Id: If2f196abb93607dde9ba5c4f04d219679585e633 Reviewed-on: https://gerrit.libreoffice.org/34822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-02Remove HAVE_CXX11_CONSTEXPR, always true nowStephan Bergmann
...after 84b36c704d73362d4d86dc9e9c0efa0625958347 "Drop support for MSVC 2013". Make this a fatal configuration error for now. The check should be removed completely after LO 5.4 branch-off. Change-Id: I990fd8fcb4ec1327282df4efe21640c938d3cf06 Reviewed-on: https://gerrit.libreoffice.org/34821 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-02tdf#60874 Set custom HID for Protect Document windowGabor Kelemen
The window has its own help page but the SfxPasswordDialog has a default help page as well. We need to use custom help IDs here. The Password entry already has a custom HID however it is used on the default help page of SfxPasswordDialog. We need to set a custom help ID for the Confirm entry and use it in the scalc/01/06060200.xhp file like the one belonging to the Password entry. Change-Id: I9344c85cf362a1829202664315f8c8be0a265b59 Reviewed-on: https://gerrit.libreoffice.org/34501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-03-02Updated coreGabor Kelemen
Project: help 817d5bea68df8fa5c0fd63d7a352c6e9edb86c1d tdf#60874 (partial) Show correct page from "Protect Document" window The bookmark for the Password entry was used on the wrong page. This needed to be moved over and the entry description set up as extended help. A new help ID was needed to be added to the Confirm entry with an accompanying extended help. Hidden, as this page is rather a howto and not a window description (thankfully). Change-Id: I6583f8708cd4c0b0891ead7067ce486153dd2be1 Reviewed-on: https://gerrit.libreoffice.org/34502 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-03-02tdf#106190 fix left alignment of denominatorLaurent Balland-Poirier
The bug was introduced with left aligment of denominator. Non feasable denominators were not tested and create infinite loop while inserting and removing the same space. This patch detects - if denominator starts just after fraction bar. Otherwise, format is faulty. - if a non digit is detected in the denominator, next part of format is treated as text This patch is changing behavior of some formats: "# ?/foo??" is treated as faulty format while it was considered as valid "# ?/??E?" is treated with 2 digits in denominator and "E?" at the end, while it was considered as faulty Change-Id: I0379a398dff79b6e21a44776c0d4356d066cdeab Reviewed-on: https://gerrit.libreoffice.org/34659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-03-02Tests for "Precision as shown" following tdf#105657 tdf#106052Laurent Balland-Poirier
I was unabled to add these test svl/qa/unit/svl.cxx because they required ScDocument::RoundValueAsShown() Found that other formats are not supported by "Precision as shown" option: - engineering tdf#106252 - thousand tdf#106253 Change-Id: Iaf98c404cabec0f5c69f94f2bf863351487fe9d7 Reviewed-on: https://gerrit.libreoffice.org/34750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-03-02do item namespace dance for linking sd and merged into a single executableCaolán McNamara
Change-Id: Iad4549f3fdde53b8d654442b3a848ea1be6f245a
2017-03-02Remove HAVE_GCC_VISIBILITY_BROKEN check completely nowStephan Bergmann
...after 5.3 branch-off, cf. 1ea987f23a4514bcae5a6bd98014ade1af4a0107 "Remove HAVE_GCC_VISIBILITY_BROKEN, never true" Change-Id: Ibc6a059d5704c3ceafffef578bf61abe202dbdd6
2017-03-02Drop support for MSVC 2013David Ostrovsky
Change-Id: Ibf47c9ff7b5fb098e284a58c547b61286264dd80 Reviewed-on: https://gerrit.libreoffice.org/22588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-02Clean up use of integer typesStephan Bergmann
Change-Id: I9b4f740e1c53de0ee90c3299970f774ace67323b
2017-03-02change the solver test to explicitly test the available solversTomaž Vajngerl
This changes the lpsolver test to explicitly test the available linear solvers we have - either CoinMP, LpSolver or both. This prevents that a newly added solver will be automatically tested as it can have a different behaviour for the tested input values. Change-Id: I0c4d2f9c561d1e834ca51196b7b5ecf7d89ba550 Reviewed-on: https://gerrit.libreoffice.org/34813 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-03-02fix leakCaolán McNamara
Change-Id: Ic91bb15cafa97538a61247660044c1af57b59d84
2017-03-02add lwp fuzzerCaolán McNamara
Change-Id: I72a2d8ce47059f9af65d89fbdcc09d96c40cb79b
2017-03-02tdf#104117 set template parameter sal_Int64 for randomTomaž Vajngerl
Change-Id: Ie8cef4375608df160b383ff74c32838f00e60aba Reviewed-on: https://gerrit.libreoffice.org/34777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-03-02avoid recursive register styleCaolán McNamara
Change-Id: I090cec1f311be5e5a34e208d066925b294310e43
2017-03-02Fix typosAndrea Gelmini
Change-Id: I139e6948e92a7bcdce5a2197b9d3754cb9549a33 Reviewed-on: https://gerrit.libreoffice.org/34781 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02Fix typosAndrea Gelmini
Change-Id: I72db7ff99cde394bc161dfd835bfb0d9a47a53d1 Reviewed-on: https://gerrit.libreoffice.org/34780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02Fix typosAndrea Gelmini
Change-Id: Ic6c41fbcc36c11a7528cde0986593a39c2d6738b Reviewed-on: https://gerrit.libreoffice.org/34803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02Fix typosAndrea Gelmini
Change-Id: If5e709c9d6e3a4fbb568bdc261cccd214dd0cbd3 Reviewed-on: https://gerrit.libreoffice.org/34784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02Fix typosAndrea Gelmini
Change-Id: I35eeb71f4f698e39b7b0d98e3cb30657a64a611a Reviewed-on: https://gerrit.libreoffice.org/34802 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02fix leakCaolán McNamara
Change-Id: I01c7ebf10831a27eaab55c2082cbe0a0f28bda1f
2017-03-02dig out lotuswordpros table limitsCaolán McNamara
Change-Id: Iea7d436a78336de150b3d3ae317b99b554fb8657
2017-03-02-Werror,-Wimplicit-fallthroughStephan Bergmann
Change-Id: I7a3f7233018e76208f80e47eb176c2879e943e47
2017-03-02ofz: don't alloc for bitmap where there isn't enough data to fillCaolán McNamara
Change-Id: Ief236828f564ff81bf3a415127413b6cc72fd70d
2017-03-02COMPRESS_OWN define is not used standalone anywhereCaolán McNamara
Change-Id: Iaca54d62a48711a7763cac98c6f303b952b2da29
2017-03-02reject bmps with unknown compression schemesCaolán McNamara
and RLE8/RLE4 compression with wrong bitmap depth Change-Id: I7e580cb119e90262a88c57b86f562eaba81c4944
2017-03-02Fix typosAndrea Gelmini
Change-Id: Ibc81246e615d7c68c93e01b84584e78a79bece16 Reviewed-on: https://gerrit.libreoffice.org/34779 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-02Fix typosAndrea Gelmini
Change-Id: Ib725427225fe95fb39a72f96bbd60d5464c9351a Reviewed-on: https://gerrit.libreoffice.org/34782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-02Complete the transition of SwRedlineTable::size_typeStephan Bergmann
...from 9ca8a63fff65acf2ea13b391495ad232f4636548 "Use consistent integer types in the SwRedlineTable interface". This all started as an attempt to reduce the number of places a to-be-committed improved loplugin:loopvartoosmall complains about. Lets see where it ends... SwRedlineTable::size_type is now the size_type of the underlying std::vector, no longer sal_uInt16 from ancient times. I tried hard to find all places that are affected by this change, changing types of affected variables and non-static data members as needed. Some notes: * The original code used USHRT_MAX as a "not found" value. I replaced that with a new SwRedlineTable::npos, of type SwRedlineTable::size_type but still for now of value USHRT_MAX. This should eventually be changed to something more sensible, like std::numeric_limits<SwRedlineTable::size_type>::max() (which is best done after we have constexpr support in all toolchains, so that npos can be constexpr). It is important that the value of npos is towards positive infinity, as many places in the code use for (i = f(); // may return npos i < table.size(); ++i) table[i] ... * There are some borders where values of SwRedlineTable::size_type are converted into different types, for various reasons. But all of those other types should be large enough for practical purposes (at least 32 bits wide): MakrEntry::m_nIdx: long int SvxRedlinTable::InsertEntry: sal_uIntPtr nPos SwRangeRedline: size_t SwRedlineItr: sal_Int32 SwVbaRevision::GetPosition: sal_Int32 SwXRedlines: sal_Int32 * .uno:TrackedChangeIndex= transports textual representations of such values. libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx treats them purely as strings, while SwTiledRenderingTest converts them to int. * TODO: The one place I'm unsure about is SfxUInt16Items with IDs FN_REDLINE_ACCEPT_DIRECT, FN_REDLINE_REJECT_DIRECT, and FN_REDLINE_NEXT_CHANGE in sw/source/uibase/uiview/view2.cxx. For now, I kept those as SfxUInt16Items and take care to "map" USHRT_MAX to npos when reading from those items. But I have no idea where instances of those items would actually be created, and what it would mean to change those items' types? Change-Id: Ib7a14dc67e2b970766966e43f4732abd9f045ff8 Reviewed-on: https://gerrit.libreoffice.org/34775 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-02Missing includeStephan Bergmann
Change-Id: I2fb82e3c5a9b26b1016cf99e943cf0cc30225495
2017-03-02tdf#106270 vcl PDF import: use BitmapWriteAccess::CopyScanline()Miklos Vajna
This requires one function call / row only, cross-platform and works with OpenGL enabled as well. Change-Id: I12fd0f52a1a7e8e683b50071ded95f63fecc4d40 Reviewed-on: https://gerrit.libreoffice.org/34774 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-02ofz: init varsCaolán McNamara
Change-Id: Ie35617997845de25af9e528668bce4c332ac408a
2017-03-02ofz: oom in reading hwp dataCaolán McNamara
Change-Id: I1e4dc5f474b229d4d68d3fc34bc23c88767e5e50
2017-03-02use std::vector::insert when inserting multiple of the same thingNoel Grandin
instead of looping Change-Id: I7b8c1663e303449302e0b96dc5b483367c2a52ba
2017-03-02xmlsecurity: avoid using the SerialNumberAdapter wrapperMiklos Vajna
This service is only used in xmlsecurity and it's a wrapper around two free functions in the same module. Change-Id: Ibc5a026b51eda6c2b4b27b7254dedc220dbf909a Reviewed-on: https://gerrit.libreoffice.org/34772 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-02bypass exception throwing and catchingNoel Grandin
instead of needlessly catching the exception that comphelper::getEnumAsINT32 generates, let's just call the same function that comphelper::getEnumAsINT32 uses Change-Id: Ibc7d79cc15c13d4124f5bd62a038804209cf5b07
2017-03-02elide the SwSurround enumNoel Grandin
no point in redeclaring an existing enum exactly Change-Id: I4fb367e4b27e36601f1f36b629097a87b5f00096 Reviewed-on: https://gerrit.libreoffice.org/34773 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02add test for own basic functionZdeněk Crhonek
Change-Id: I9c42195c7338300964e111e2a3fbc8d61cac6186 Reviewed-on: https://gerrit.libreoffice.org/34770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-03-02don't need this STL hack anymoreNoel Grandin
Change-Id: Id0883060acf2ca73af5cce56e1cf9021c2fb121a
2017-03-02sw: replace hardcoded 1 with TRISTATE_TRUEJochen Nitschke
Change-Id: I071f787f6a00acc9827fbce9e6993d33450ab7b5 Reviewed-on: https://gerrit.libreoffice.org/34764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02no need to use smart pointers for DataFlavorExVectorJochen Nitschke
DataFlavorExVector is a std::vector<..> typedef. remove odd void pointer in BrowseBox. return const references to keep getter const qualified. Change-Id: Iafd529a46b7511941c1dffc86d2066fdc4f07e28 Reviewed-on: https://gerrit.libreoffice.org/34767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02starmath: Drop SmParseError::UnoperExpectedTakeshi Abe
because it cannot happen unless the invariant about TG::UnOper is broken. Change-Id: I2250c785c278d77e991be04353cf34b5c1c45a21 Reviewed-on: https://gerrit.libreoffice.org/34735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-01xmloff: prefix member nElement of XMLTransformerBaseJulien Nabet
Change-Id: I83f62ccad47bc10c2a506a6b79a24e3367df5335 Reviewed-on: https://gerrit.libreoffice.org/34769 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-01Typo: decaration->declarationJulien Nabet
Change-Id: I743e7f41243ae54b1deece4743b248a002ecfdb8 Reviewed-on: https://gerrit.libreoffice.org/34768 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-01ofz: check reads, zero vars, return earlier on failureCaolán McNamara
Change-Id: I287ec575d95ff950097a255abbcd0d3304c04a56
2017-03-01ofz: ReadBlock has to be HWPIDLen to be usefulCaolán McNamara
Change-Id: Iaa349921972bb19b40bf68c6a3b0c7128cff4b8d
2017-03-01Resolves: tdf#106261 throw away old node map for tableCaolán McNamara
when generating a new one, otherwise on exporting the same table twice to two consecutive .doc footnotes will think the second export of the table is a level lower because it will find it in the map and WW8TableNodeInfo::Pointer_t WW8TableInfo::insertTableNodeInfo does pNodeInfo->setDepth(nDepth + pNodeInfo->getDepth()); using the cached pNodeInfo depth and not a new fresh pNodeInfo of depth 0 Change-Id: I7aa7ac6a19814910c1d19d78f04cfd9886c444c5
2017-03-01No need for the program -> MacOS symlinkTor Lillqvist
Or could it be that some external scripts insist on running LibreOffice.app/Contents/program/soffice? Or some instructions talk about that pathname? Change-Id: I99e2b2636971c7ee8de09a9e42df9f965eeec5fb
2017-03-01Updated coreMichael Stahl
Project: help e7999c35fd7460118469142420c7d39ba5562222 tdf#77111 helpcontent: adapt "Text flow" tab page help Replace obsolete description of "0" page number. Change-Id: I1881bca456d94af74060e1e3b92e043255c9e702
generated by cgit (git 2.34.1) at 2024-07-11 14:27:12 +0000