summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-04-29tdf#120135 Currency icon must not show the dollar sign SIFRMatthias Freund
SIFR icon update "currencyfield" Change-Id: Ied78cf1edc7a03239300db10461275ecc75ad4ae Reviewed-on: https://gerrit.libreoffice.org/71490 Tested-by: Jenkins Reviewed-by: Matthias Freund <matti_lx@secure.mailbox.org>
2019-04-29Fix typoAndrea Gelmini
Change-Id: I881b23341ee1fc8d1ff3443e8ab52f51e07c3646 Reviewed-on: https://gerrit.libreoffice.org/71499 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-29Fix typoAndrea Gelmini
Change-Id: I6e04287504cc8d4c0e3d09632ee1c7355157e5ee Reviewed-on: https://gerrit.libreoffice.org/71500 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-29Add MetaActionTransparent to the SVM testTomaž Vajngerl
Change-Id: Ia927070883e5647b61876e31d6a0a085e2456f8a Reviewed-on: https://gerrit.libreoffice.org/71498 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29Add TextAlign,RasterOp to the SVM testTomaž Vajngerl
Change-Id: I58b7bb114864a9fdf901a92d54717964c6f1b68e Reviewed-on: https://gerrit.libreoffice.org/71497 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29Add LineColor,FillColor,OverlineColor to the SVM testTomaž Vajngerl
Change-Id: Id130dd7739b9662541b50b7792da170da70a6a9b Reviewed-on: https://gerrit.libreoffice.org/71496 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29Add MetaActionClipRegion to the SVM testTomaž Vajngerl
Change-Id: I51bd172cdd22d55a6800d1e74e38149874629f85 Reviewed-on: https://gerrit.libreoffice.org/71495 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29Add MetaActionWallpaper to the SVM testTomaž Vajngerl
Change-Id: Icce9c3c5fa826b6f5237d2d0e28fc51555a3e267 Reviewed-on: https://gerrit.libreoffice.org/71494 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29Add MetaActionHatch to the SVM testTomaž Vajngerl
Change-Id: I96113168d4ae8289cec3a5b0bbd6aa79faf97c48 Reviewed-on: https://gerrit.libreoffice.org/71493 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29update Metafile dumper and change the order of MetaActionsTomaž Vajngerl
Change-Id: Ib851156da20528e7df5197ba96c35727af7bdbb6 Reviewed-on: https://gerrit.libreoffice.org/71492 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-29Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' - Rename some menu-related help files for Impress and Draw The renamed files are in the process of heavy editing, so might as well move from obfuscated names to human-readable ones. Change-Id: I2df6470eefc3b8bb381de77471c688d9498854cf Reviewed-on: https://gerrit.libreoffice.org/71436 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-29Add all MetaActions to SVM tests as stubs, change order of testsTomaž Vajngerl
Change-Id: Ic0f143ea6871965a5d1e9db4b35db88f8adb5181 Reviewed-on: https://gerrit.libreoffice.org/71491 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-28Resolves: tdf#125002 toggling on radio button generates click on anotherCaolán McNamara
so use toggle and ignore toggle offs Change-Id: Id6a9f3a7a9cf02d62ede00e4c246629406f9a64b Reviewed-on: https://gerrit.libreoffice.org/71481 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-28uitest for bug tdf#124818Zdeněk Crhonek
Change-Id: I7aeca38c62c986041aab438e5d28bc8e6f0ccf2a Reviewed-on: https://gerrit.libreoffice.org/71486 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-04-28uitest for bug tdf#124896Zdeněk Crhonek
Change-Id: Iacaf5e19bb20dee471ebdc53977170312cf0fc5f Reviewed-on: https://gerrit.libreoffice.org/71485 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-04-28Resolves: tdf#124931 key stroke in shortcut keys not selecting the key comboCaolán McNamara
Change-Id: Ife3e99e0cf00d7d320eb8e403743d42fb8274df8 Reviewed-on: https://gerrit.libreoffice.org/71483 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-28WebDav: Don't unlock the file during saving of a documentTamás Zolnai
Otherwise it can happen that the file is locked by someone else during the saving method is running. I just extended the scope of the existing DisableUnlockWebDAV() calls a bit. In case of webdav it does not cause an issue to avoid unlocking the file before locking it again with an other SfxMedium. Change-Id: I6ac4e3326c63c9e184a7710ce8994cac1ed79449 Reviewed-on: https://gerrit.libreoffice.org/71484 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-04-28Just apply Asian kerning to unmodified glyphsJan-Marek Glogowski
IMHO the old code was doing the opposite of the comment. But the comment makes more sense then the code, so adjust the code accordingly. OTOH just this code was added in commit f89d70de85a6 ("INTEGRATION: CWS vcl27 (1.30.48); FILE MERGED 2004/09/09 12:33:53 hdu 1.30.48.1: #116489# only apply asian kerning on default-formatted text"). Maybe still a bug? Can't check the bug tracker, as this is pre-Apache, and so can't verify the old bug :-( Change-Id: I550d1524d3e82f7e853820d3e5ddab8cc62228f9 Reviewed-on: https://gerrit.libreoffice.org/71441 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-04-28tdf#120703 PVS: dereference before nullptr checkMike Kaganski
V595 The 'ustrFile' pointer was utilized before it was verified against nullptr. Check lines: 83, 107. Change-Id: I874983508fb805b1f0a55b3a5b6d4d78ae1babdb Reviewed-on: https://gerrit.libreoffice.org/71472 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28Move and fix Asian kerning unicode point checkJan-Marek Glogowski
It's the same then * (1 != c && 2 != c) || (3 != c) * !(1 == c || 2 == c) || !(3 == c) * !((1 == c || 2 == c) && (3 == c)) which is always true. Change-Id: Ib63127319ff7e9c13877ac54aa92427637061812 Reviewed-on: https://gerrit.libreoffice.org/71477 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-04-28Move lcl_CalcAsianKerning near its only userJan-Marek Glogowski
This function is just used by ApplyAsianKerning, so move it there. While at it drop the unused constant boolean. Same for the comment referencing ImplCalcKerning, which is long gone since a huge merge in commit 2f382d6c2579 ("MWS_SRX644: migrate branch mws_srx644 -> HEAD"). Also "const int"ify ApplyAsianKerning. No need for long, as the lcl_CalcAsianKerning just returns int in the range [-2,+2]. Change-Id: I9b1b3351ab71219c8e2ee49ce441f5222e5c1c4b Reviewed-on: https://gerrit.libreoffice.org/71476 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-04-28Resolves: tdf#124704 need to state the area the tooltip is forCaolán McNamara
to make it work under gtk3 Change-Id: I4c895181af233a16292ce16b194f0a60994446fb Reviewed-on: https://gerrit.libreoffice.org/71478 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-28Remove unneeded checkMike Kaganski
See commit 60dca2de31ad6a187e35b3a2d751ea674f7f0d9d, which converted preceeding OSL_ENSURE into asserts - so nullptr is considered impossible here. Change-Id: Ia6d8f226d94c84a66bad67ce1b5f702864d61fdc Reviewed-on: https://gerrit.libreoffice.org/71475 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: dereference before nullptr checkMike Kaganski
V595 The 'pDoc' pointer was utilized before it was verified against nullptr. Check lines: 434, 460. Change-Id: Iec92cbb8c4f5e47f7852015bf466b1f8ed195517 Reviewed-on: https://gerrit.libreoffice.org/71471 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: nullptr dereferenceMike Kaganski
V595 The 'GetMedium()' pointer was utilized before it was verified against nullptr. Check lines: 435, 455. bURLChanged is only meaningful when GetMedium() is not nullptr; otherwise bSaveDS could become true where no medium existed, and dereferencing GetMedium() to find its URL would segfault. Change-Id: I6f533acb3b1ca078803aa23bdece0ba2ee1d87c3 Reviewed-on: https://gerrit.libreoffice.org/71467 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: nullptr dereferenceMike Kaganski
V595 The 'pContact' pointer was utilized before it was verified against nullptr. Check lines: 1254, 1256. Change-Id: I5d3d28b3c8a70924f329fde9f020f42d9eb5e9a1 Reviewed-on: https://gerrit.libreoffice.org/71459 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: dereference before nullptr checkMike Kaganski
V595 The 'mpViewShell' pointer was utilized before it was verified against nullptr. Check lines: 96, 125. Change-Id: I824c6cf8a5ed7f0ef20e99df36c83feec7fe54ea Reviewed-on: https://gerrit.libreoffice.org/71468 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: dereference before nullptr checkMike Kaganski
V595 The 'mpViewShell' pointer was utilized before it was verified against nullptr. Check lines: 193, 201. Change-Id: I0d3cfee4d6f7bbb536c463b698361a1d299d2863 Reviewed-on: https://gerrit.libreoffice.org/71469 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: dereference before nullptr checkMike Kaganski
V595 The 'GetActiveWindow()' pointer was utilized before it was verified against nullptr. Check lines: 544, 567. Change-Id: I1ef45fa72542168ba88f24482973a1c660bcc1a8 Reviewed-on: https://gerrit.libreoffice.org/71470 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28set parent for file picker dialogCaolán McNamara
Change-Id: I92c83dcb9fd0fa3305aa2f40f6cc0d28fc0ad022 Reviewed-on: https://gerrit.libreoffice.org/71438 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-28ofz#14167 arbitrary sheet limit to make fuzzing usefulCaolán McNamara
Change-Id: I729d62520e9b59e96984f5d4b1aabd059f60d71d Reviewed-on: https://gerrit.libreoffice.org/71437 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-28tdf#120703 PVS: Avoid dereferencing nullptrMike Kaganski
V595 The 'pEndIdx' pointer was utilized before it was verified against nullptr. Check lines: 1328, 1347. Change-Id: If9aff472e6ec7429ef2055b44dd11e62d4489ba4 Reviewed-on: https://gerrit.libreoffice.org/71458 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: fix cleanup checksMike Kaganski
pofs is guaranteed to be non-nullptr after getOutputStream, so no need to check that. is_open() only matters to decide if close() is needed. V595 The 'pofs' pointer was utilized before it was verified against nullptr. Check lines: 1033, 1057. Check lines: 1194, 1220. Change-Id: I2dd22d29c465889269f2496f0964bee030cb5964 Reviewed-on: https://gerrit.libreoffice.org/71456 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28Remove redundant checksMike Kaganski
The result of GetDialogExampleSet is checked below. Change-Id: Ic3f7820d6d6923e0ced518157ce41f6bc0de65a7 Reviewed-on: https://gerrit.libreoffice.org/71457 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: Check potentially null pointer before useMike Kaganski
V595 The 'pHdl' pointer was utilized before it was verified against nullptr. Check lines: 192, 197. Change-Id: I52e1d1eadaded8616b8a27e0fcfaf6d1e6baa03e Reviewed-on: https://gerrit.libreoffice.org/71455 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: V581 ifs with identical conditionsMike Kaganski
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I99117fa7c04a5de565833be7bdc001d97e635d61 Reviewed-on: https://gerrit.libreoffice.org/71453 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: Blind attempt to implement original ideaMike Kaganski
The strange implementation was there ever since commit bd36338009672fdabd5b6d585f8c1092b617196a. The other possibility is to just remove the block above the last assignment to aRet Change-Id: I5bd3bf1f518ab894e5df4cbc7d86a76d325e4600 Reviewed-on: https://gerrit.libreoffice.org/71447 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: V581 ifs with identical conditionsMike Kaganski
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I11fa13677c7980e6ac17fc4358406472ee784e41 Reviewed-on: https://gerrit.libreoffice.org/71446 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28Removed duplicated includeAndrea Gelmini
Change-Id: Ia5809ac7ff74652e5d83ef2dbc176c4f586b7203 Reviewed-on: https://gerrit.libreoffice.org/71449 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-28Fix typoAndrea Gelmini
Change-Id: Id6985abca7702039168381082da4e47603b9aaf3 Reviewed-on: https://gerrit.libreoffice.org/71451 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-28Fix typoAndrea Gelmini
Change-Id: I8c928576919c9410eda0a7f33b2120d13c3bc6bf Reviewed-on: https://gerrit.libreoffice.org/71450 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-28prefix member variables of AnimationBitmapTomaž Vajngerl
Change-Id: Ic84773399c95d61f843e4388fe01d00cd4facc5a Reviewed-on: https://gerrit.libreoffice.org/71425 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-28move Animation, AnimationBitmap out from clang-format blacklistTomaž Vajngerl
Change-Id: I95fd2d4e164bf04c4457b3e20401270227e21a8f Reviewed-on: https://gerrit.libreoffice.org/71424 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-28Separate AnimationBitmap from Animation.{hxx,cxx} sourceTomaž Vajngerl
Change-Id: I982a108b2241c049b595a13d6f39d24ef0266074 Reviewed-on: https://gerrit.libreoffice.org/71423 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-28rename animate.hxx to animate/Animation.hxx, more changes followTomaž Vajngerl
This is the first step of refactoring Animation where it is needed to separate AnimationBitmap(s) from the Animation class, which is also responsible for displaying of animation. General idea is to make Graphic work only with AnimationBitmaps, which can be freely be swapped out and in, make copies - all transparantly from the actually displaying them and possibly it will also remove the need to copy the animation objects. Change-Id: If5d55ac1a5b26c3880d4f7602be57742b086f9da Reviewed-on: https://gerrit.libreoffice.org/71406 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-28tdf#124944 don't directly adjust fallback layoutsJan-Marek Glogowski
These are adjusted via MultiSalLayout::AdjustLayout, as they just know their own text width, but not the full text width of the MultiSalLayout, so the adjustment is too large. The correct adjustment is done by preparing a DXArray for all glyphs, which is then passed to the individual font fallback layouts for general adjustment. Change-Id: I439527d03df4752e74ff94aee7775a95275be5e2 Reviewed-on: https://gerrit.libreoffice.org/71440 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-04-28Minimize scope of variablesJan-Marek Glogowski
Change-Id: I6602c84b9bd7143e5e7b224c17559b083c9b7f9c Reviewed-on: https://gerrit.libreoffice.org/71439 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-04-27tdf#120703 PVS: re-read aPrefSize after updating itMike Kaganski
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 645, 655 Since commit 37aa7d81aacaae12dfe0fd2ade2779235bbf72f1 Change-Id: I7b4d2d58e51cf98ac6294d1feacd28c3a8761d81 Reviewed-on: https://gerrit.libreoffice.org/71431 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-27unit-test for tdf#124326Dennis Francis
Change-Id: Id3416e5631dcd6e427429ac475ac81b2ab70b9e5 Reviewed-on: https://gerrit.libreoffice.org/71429 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-04-27unit-test for tdf#120270Dennis Francis
Change-Id: Icaa547ba5ef210ba721661242b2becd9f559f09a Reviewed-on: https://gerrit.libreoffice.org/71428 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
generated by cgit (git 2.34.1) at 2024-08-18 08:07:52 +0000