summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-11-08Updated coreAndras Timar
Project: help 0119d6fd483709ee783da89d961e93e71ba41eb6 fix invalid xml Change-Id: I15ed980578006e5ef55e0983d1683b001baa39f2
2016-11-08Resolves: tdf#103783 do consider parent of WB_DIALOGCONTROL widgets...Caolán McNamara
for tab cycling, given the problem of tdf#103783 regression from... commit fd40e3ea09a481a2e97452d2244ecdfd6c3508c1 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Nov 1 16:34:22 2016 +0000 lock tab-cycling inside the WB_DIALOGCONTROL widget activate the color selector in the toolbar in the sidebar panel, press tab to cycle between its widgets, when it hits the bottom it will not return to the first widget, but escape out of the floating window into the next sibling of the toolbar but only check the Parent, not RealParent Change-Id: I9577a0a9f3a622373c195e77ca43d17511b4154d
2016-11-08Updated coreJoel Madero
Project: help 578e1e320daaa82b2d3b8c0eeea84bf704967939 tdf#103397 - added example for Transpose function Added a simple example to the help for transpose() function Added tablehead style to example rows/columns Change-Id: I464983d480cb237a53e033005057a1faef0b9193 Reviewed-on: https://gerrit.libreoffice.org/30334 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2016-11-08Remove obsolete OxygenOffice stringsGabor Kelemen
These belonged to extra galleries, introduced in 49d5bdcf4d516b21721f1ed6d313ea4a170d39eb I missed to remove these in 8dc38d9ded92960eda46343b67da8a8b95404b5a Change-Id: I32c649d56053b32f2c2993aeda51425d7586c9b7 Reviewed-on: https://gerrit.libreoffice.org/30698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-08xmlsecurity PDF verify: fix handling of xref stream free objectsMiklos Vajna
In case our xref table doesn't have an entry for "free" object types, then the table size won't provide a valid id for a next object. That resulted in creating all new objects with the same ID. With this, our verifier at least can see the new signature when appending one to a signed PDF 1.6 file. Change-Id: Iac39a400706cfcd23dd814d2b81cb8b950c69fc6 Reviewed-on: https://gerrit.libreoffice.org/30704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-08xmlsecurity PDF sign: handle xref stream when reading trailerMiklos Vajna
Don't give up signing just because PDF 1.4 trailer is missing, provided that PDF 1.5 xref stream is available. Change-Id: I03360d428346537583a4398aa3a94b195b428713 Reviewed-on: https://gerrit.libreoffice.org/30703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-08xmlsecurity PDF sign: don't crash on missing trailerMiklos Vajna
This will need cross-reference stream write support, just don't crash for now. Change-Id: Id48c131b22d4ed96174693f3e96b14c273d596a8 Reviewed-on: https://gerrit.libreoffice.org/30702 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-08Return early from double ToolBarManager::disposeStephan Bergmann
...if that should ever happen. Also means that ToolBarManager::RemoveControllers will now only be called with m_bDispose being false. Change-Id: If17d60f291cc8dad19d6f6e33d39e08c7f8ad7aa
2016-11-08Clean up (calls to) ToolBarManager::RemoveControllersStephan Bergmann
...which turns out to be only called with SolarMutex locked Change-Id: I3264b0a043da7111b8ca12c59ee7a590f1a43b8e
2016-11-08Remove license information of dropped extensionsGabor Kelemen
No need to mention licensing info of OxygenOffice-related extensions that were dropped in 8dc38d9ded92960eda46343b67da8a8b95404b5a Change-Id: I12b862433b62154078d88f6debac8ecae749a751 Reviewed-on: https://gerrit.libreoffice.org/30699 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-11-08Clean up (calls to) StatusBarManger::RemoveControllersStephan Bergmann
...which turns out to be only called with SolarMutex locked and m_bDisposed being false Change-Id: I454e7951ea579fb6d9dc71d0aabebd373380b3e4
2016-11-08Drop more OxygenOffice bitsGabor Kelemen
Follow up to 8dc38d9ded92960eda46343b67da8a8b95404b5a Here we drop some --help descriptions and the rest of removed extensions from the Jenkins config file Change-Id: Ie1520adf2c48c2dc714b00c53ba0055f1deb3c62 Reviewed-on: https://gerrit.libreoffice.org/30697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-08There's no derivations from StatusBarManagerStephan Bergmann
Change-Id: Ifa2970cf838209b72e286109f14b98e77f389c0b
2016-11-08xmlsecurity: move the sec context from the format helpers to the sign managerMiklos Vajna
The signature manager always creates an XML helper, and optionally creates a PDF helper as well. Both of them initialize xmlsec, and when the signature manager is deleted, there are two de-inits, leading to an assertion failure in xmlsec. Fix the problem by moving the duplicated xmlsec init to the signature manager. This has the additional benefit that general security-related code no longer has to talk to the XML helper, it can use the signature manager, which feels more natural. (What viewing a certificate had to do with XML?) Change-Id: If6a6bc433636445f3782849a367d4a7ac0be7688 Reviewed-on: https://gerrit.libreoffice.org/30695 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-08Ensure that the string array is null when no strings present.Kohei Yoshida
It was intended this way from day one, but the implementation didn't live up to that promise... Change-Id: I231ddc8923fdd8a205127c6a3214dd93f13378b9 Reviewed-on: https://gerrit.libreoffice.org/30678 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-08Fallout from previous commit 248dbe1de5eeea9e9173e53a0b1891f63ff73d68Tor Lillqvist
Remove SignatureInformation::nSecurityEnvironmentIndex as it was always -1. Change-Id: I39247e5c40ce36e394c30b450626eca533f46267
2016-11-08Bin pointless (overloaded) member functionTor Lillqvist
The XSecController::setX509Certificate() overload that took a sal_Int32 nSecurityEnvironmentIndex was called in just one place, and -1 was always passed for the nSecurityEnvironmentIndex. Change-Id: Ic37b7053c90a6fbb8b4e5b6485483d34c605b965
2016-11-08Add fill-column: 100 to the Emacs mode lineTor Lillqvist
Vim users: No reason to panic. This does not mean that Emacs users would suddenly start to split existing (or new) code lines always before column 100. The default value for fill-column is 70, and that hasn't forced code lines edited in Emacs to be shorter than that earlier either. The primary intent of using a fill-column of 100 (instead of the default 70) is that when you edit some long (multi-line) comment block, and you want to reformat ("fill", "reflow") that comment (using the fill-paragraph command, bound to Meta-Q), lines will be filled up to column 100, and not just 70, which in most cases would look quite short. Unless I am strongly advised not to, I will start adding this to the mode lines in source files if I remember, as I happen to edit some comment block in them. Change-Id: Icfb93dbb22b2db7190fdc9c8ee9518d08e73c7a8
2016-11-08sfx2: let .uno:SignPDF add a matching button to the infobarMiklos Vajna
When the user uses .uno:SignPDF to open a PDF file in read-only mode, then the infobar now has a "Sign Document" button, which is a shortcut for the File -> Digital Signatures -> Digital Signatures menu item. Change-Id: I2953a5cb1252c5ff1c395d45c54db1a97b39433e
2016-11-08Work in progress on supporting XAdES-compliant signatures for ODFTor Lillqvist
xmlsecurity is such a mess. Too many different classes that actually have more or less identical life-time, with names that smell of delusions of grandeur. "Manager", "security framework controller" etc for stuff that actually exist only during the execution of a simple dialog. And then a "helper" class that actually in on a higher level than a "framework controller". But oh well. Change-Id: I86e461b1bc91a0d8f5b7fb9f13a5be201729df1e
2016-11-08typo fix: ressource -> resourceAndras Timar
Change-Id: Id8d1c01b17e711a057a9f3f20e1d0f955b2ea6c8 Reviewed-on: https://gerrit.libreoffice.org/30690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-08Change new colour only, keep active one on the initial valueKatarina Behrens
Change-Id: Icfda455d275d0449725867fd7bf4ea3060e7dc26 Reviewed-on: https://gerrit.libreoffice.org/30691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-08simplify mark points and gluepoints managementCaolán McNamara
Change-Id: I52070cfe4909a13189d9c130114d98565ced9089
2016-11-08loplugin:expandablemethods in extensionsNoel Grandin
Change-Id: I93a770933de86146de1d25db9d596615916c3e28 Reviewed-on: https://gerrit.libreoffice.org/30689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08reduce copying when decomposing drawinglayer primitivesNoel Grandin
instead of returning a Primitive2DContainer from each method which we are then going to immediately append to another container, pass down a single container by reference which we can append to Change-Id: I0f28a499d2ec54f7111a7044c30099767aa079e1 Reviewed-on: https://gerrit.libreoffice.org/30258 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08no need to use endsWithAsciiL like this anymoreNoel Grandin
Change-Id: Ie59d001816661ac19ce19ddae36efd8d880a987f
2016-11-08loplugin:expandablemethods in reportdesignNoel Grandin
which led to discovering some unused parameters Change-Id: Ie8f67a47aa9ec409637da32ef9bc457952397772 Reviewed-on: https://gerrit.libreoffice.org/30681 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08tdf#79329 DOCX import: fix missing outer table with floattable at cell startMiklos Vajna
The bug document has a normal table, then its C1 cell starts with a nested table, which is floating. The problem is that converting the nested table to a textframe invalidates the start text range of the C1 cell in the outer table we store, so the conversion of the outer table from text to table fails. This never worked, so to avoid the regression just don't convert inner floating tables to textframes when they're anchored at the cell start. A more general fix in the future can be addressing the actual invalidation of the cell start/end text ranges, and then this specific fix will not be necessary anymore. Change-Id: I12cefa41977cf719b07b0fb3ef9ec423c17ef3b1 Reviewed-on: https://gerrit.libreoffice.org/30685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-08loplugin:expandablemethods in forms..formulaNoel Grandin
Change-Id: Idc948ad06913def28cb642c3a4e5ea9322b9fb3b Reviewed-on: https://gerrit.libreoffice.org/30688 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08coverity#1394269 Uncaught exceptionCaolán McNamara
and coverity#1394270 Uncaught exception Change-Id: I91e62c595ed923e44eea4c4fa1ac77444e34a9d9
2016-11-08loplugin:expandablemethods in lotuswordpro..packageNoel Grandin
Change-Id: Ic9827c998f4f78775fdf5c1eaf9d4749d4986102 Reviewed-on: https://gerrit.libreoffice.org/30682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08try and auto-silence coverity#1394273 Use after freeCaolán McNamara
and coverity#1394272 Use after free Change-Id: Id2340bccc6fbaeb917cb397890875bd0849ffe85
2016-11-08coverity#1394268 Resource leakCaolán McNamara
Change-Id: I8f4a76d4f7e5cb2429ed5911c6026535590c681e
2016-11-08loplugin:unnecessaryvirtual in basctl..chart2Noel Grandin
Change-Id: Id4eeb12792c3a66b68a907cb459ab437e3d64e4c Reviewed-on: https://gerrit.libreoffice.org/30680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:expandablemethods in frameworkNoel Grandin
Change-Id: I444f31f06d2445392a59879c2d7fb1f8ad1c24c6 Reviewed-on: https://gerrit.libreoffice.org/30684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:expandablemethods in hwpfilter..linguisticNoel Grandin
Change-Id: I62ae20ab4a47b3b7e2b0d503cedcad3319cc9c85 Reviewed-on: https://gerrit.libreoffice.org/30683 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08tdf#88023: Only warn about unavailable JRE onceMike Kaganski
The underlying design is that there's a single JavaInteractionHandler instance owned by a JavaContext, and that JavaContext installed in Desktop::Main (desktop/source/app/app.cxx). This patch ensures that no additional JavaContext is created in SfxOfficeDispatch::dispatch*() functions unless they are used without preinstalled JavaContext. Thanks to Stephan Bergmann for guidance! Change-Id: I2569df221067a5b9bf1f6cd5d8f69b561316a170 Reviewed-on: https://gerrit.libreoffice.org/30529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu
Change-Id: I2f7e2fd8b9ae45e1aa45cf97750a6107ed9f3036 Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30673 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:oncevarNoel Grandin
Change-Id: I44fb6858eeff14fcbd9fdfbbb0aabd1433b6a27d Reviewed-on: https://gerrit.libreoffice.org/30668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in frameworkNoel Grandin
Change-Id: I893bf955e45e661e3ec440dbd530fca22931c23b Reviewed-on: https://gerrit.libreoffice.org/30666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in hwpfilter..rscNoel Grandin
Change-Id: I2e9df8223d503b813b4c458747e8c44bb8ef8868 Reviewed-on: https://gerrit.libreoffice.org/30661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in sc..scaddinsNoel Grandin
Change-Id: I4a2d333984827f363ea76580993438d704f9738f Reviewed-on: https://gerrit.libreoffice.org/30660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08Resolves: tdf#103701 bulk-broadcast the correct hint ID for formula groupsEike Rathke
BulkBroadcastGroupAreas() and BulkDataHint and thus FormulaGroupAreaListener::Notify() omitted to transport the actual hint and assumed SC_HINT_DATACHANGED, but SC_HINT_TABLEOPDIRTY needs to be handled as well. Change-Id: I765f7c95f7aeab295f35dcf6949a3b1926cbe248
2016-11-07Revert "Reverts a commit series that cripple windows ci."Caolán McNamara
with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601. Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128 Reviewed-on: https://gerrit.libreoffice.org/30598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-07style fix for cppcheck duplicateBreakJochen Nitschke
Change-Id: I42d4763db5a87741baa6b6d5ec58ea136394bf7a Reviewed-on: https://gerrit.libreoffice.org/30670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07style fix for cppcheck redundantConditionJochen Nitschke
Change-Id: I5d02c6f4c6b411c23a6de43374884a76e1c408fe Reviewed-on: https://gerrit.libreoffice.org/30667 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07vcl: improve accounting of SVG images in graphics cacheMichael Stahl
The problem is that the graphics cache only counts the size of the SVG text, which is stored in SvgData::maSvgDataArray. However the SvgData::maSequence may use a lot more memory, as it may contain de-compressed bitmaps that are stored as base64-encoded PNGs in the SVG text. For example icon-themes/galaxy/brand/flat_logo.svg is 812 Ko but contains 60 Mo of bitmaps. This may cause excessive memory usage and failure to export documents due to OOM; according to valgrind massif, the bitmap buffers use 90% of the heap. Add a new interface com::sun::star::util::XAccounting, and implement it in drawinglayer BasePrimitive2D. VCL SvgData can't access drawinglayer via C++ directly so this looks like the best approach. Change-Id: I5a7c3147733e23473c1decabed24c1f79d951c7d Reviewed-on: https://gerrit.libreoffice.org/30669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-07typo: modul -> moduleAndras Timar
Change-Id: I2839bb336358c4653b018c383440fb91b0b4e0ca Reviewed-on: https://gerrit.libreoffice.org/30657 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2016-11-07google docs can generate a pptx with an empty cmLstCaolán McNamara
Change-Id: I2a3dcae5361929c6880b2da1b3107cb2c8141f32
generated by cgit (git 2.34.1) at 2024-08-17 21:39:11 +0000