summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-03-29Bump version to 7.5.9.2.M2mimo-7.5.9.2.M2Aron Budea
Change-Id: If0ed93f823717fab42d5797f88f7e9397558ba69
2024-03-26related tdf#147583 sw find: fix backwards search for string at end of paraJustin Luth
Prior to this fix, it was finding every single character in the document when searching for ".$". Interestingly, the unit test worked even before the patch. Not sure how that could be possible... make CppunitTest_sw_uiwriter7 \ CPPUNIT_TEST_NAME=testTdf147583_backwardSearch Change-Id: I20779898c01736eb39ecd7db7d66c2c24e4358b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165037 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit e830394c068c229bb840018f2f0e8810da6a1487)
2024-03-26tdf#147583 sw find: fix backwards search for emptyPara/endOfParaJustin Luth
A comment added 10 years ago thought that it had never worked. The very last paragraph end cannot be selected manually, and so of course it can't work in find either. It didn't work earlier either. Everything goes ballistic if searching inside comments, but that would be handled elsewhere anyway I guess. It didn't work earlier either. Keeping the search "inside the selection" didn't work earlier either. That should be fixed now. make CppunitTest_sw_uiwriter7 \ CPPUNIT_TEST_NAME=testTdf147583_backwardSearch Change-Id: I48a72084d277b8c270255de9296a2743162937cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164892 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164982 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 2f5b9916baaf0017ece84bf867a9e9acfe86d61a)
2024-03-12tdf#159927 sd headerfooterdlg: detect existing date/time languageJustin Luth
Sometimes it was hard to change an existing foreign language to your own language for Impress' header/footer fields. The function was only checking the first master slide for the date/time language. If it didn't have one, then the default locale was selected. However, although all pages share the same date/time language, it is not necessary for all (or even the first) master slide to have a date/time field. So check through all the master slides until one with a date/time is found. Obviously if none have one defined things still work OK, because that is effectively how it was working beforehand. I don't have much hope for a successful unit test. I'll try to develop it as a follow-up to this patch. Change-Id: Ida44957013978720ad12fadc9b4ebc88bc10ea40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164045 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> (cherry picked from commit 62323124f54885c6de4ac4fa38052d380309a5a1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164506 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 703cc8d674d81573a1e6191a12cec4012cca22f7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164671 (cherry picked from commit 2dd2471290acf4d1229cca7b43719e57242cd59e)
2024-02-09Update git submodulesAndras Timar
* Update helpcontent2 from branch 'distro/mimo/mimo-7-5' to 62caa4586e08b6464396189f1f6e68f57f76bce3 - Too big enviroment on Windows can cause failure with xargs Change-Id: I5d796dbf6ad4d93dd133583a1dac95a210674ef9
2023-12-07Fix USE_CONFIG_APPROVE_CONFIRMATION and USE_CONFIG_REJECT_CONFIRMATIONmimo-7.5.9.2.M1Mike Kaganski
They still showed UI in case of signed macros. Two decisions were made, to improve security of USE_CONFIG_APPROVE_CONFIRMATION: 1. In case of High macro security mode, valid but untrusted certificate will be automatically rejected (because it is not safe to automatically add trusted certificates) - so in this mode, USE_CONFIG_APPROVE_CONFIRMATION is the same as USE_CONFIG_REJECT_CONFIRMATION; 2. In case of Medium macro security mode, valid but untrusted certificate will not automatically allow macros execution, but will proceed to the following checks - which on Windows will try to check the source's Security Zone, and may disallow macros based on that. Only after Security Zone check the macros will be automatically allowed. Change-Id: I1a9c92c6b940b689599c5d106798ecfc691dad46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159214 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159278 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-07Simplify a bitMike Kaganski
Additionally, get rid of a variable that was for system path, but used "URL" in its name :-) Change-Id: I77db0ae42677e2fef1431d45b1736d2e54ff26d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159156 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159277 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-07Do not throw on IZoneIdentifier COM errorMike Kaganski
Not being able to obtain Security Zone info from OS is not a fatal error here; just handle it accordingly. Change-Id: Ifb19c88f2c08e99c313aecc54044252bac50f88e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159155 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159276 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-07tdf#158090: Do not auto-reject SignatureState::BROKEN in ALWAYS_EXECUTE caseMike Kaganski
It doesn't make sense to silently reject it here, but e.g., allow the confirmation dialog for SignatureState::INVALID case; also, it was only possible to get a silent execution of BROKEN-signature macros (in Low security mode) vs. silent reject (in all higher modes) - which was not good security-wise. Now it will result in the usual confirmation dialog in Medium security mode. Both BROKEN and INVALID signature states are made sure to not allow automatically depending on the Windows Security Zone. Change-Id: I41b0fc96b6bd00e960ae612e79fa1f0f1e06a069 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159153 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159275 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-07Only call getDocumentLocation onceMike Kaganski
Change-Id: I0d611e5170b392a6f2b78fda51e48cd1a3287fa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144909 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-07Simplify a bitMike Kaganski
Change-Id: Ibf5a0800d7b9410a6191e3be7deef1edd4725640 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159152 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159274 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-07Early shortcut for cases requiring both macro and document signaturesMike Kaganski
This avoids a possible problem in High security mode, introduced in commit 1dc71daf7fa7204a98c75dac680af664ab9c8edb (Improve macro checks, 2021-01-28), where a valid but untrusted macro certificate initiates a UI asking to always allow this certificate; but no matter what user chose, macros will be disallowed when the document itself is unsigned. Now it will check the document signature state early. Change-Id: If2255be5da19f3de0090154f0b891ed9496e7bc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159105 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159273 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-07Simplify a bitMike Kaganski
Change-Id: I05ef5346f5aab25b208aa058658353cf71e68e87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159103 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159272 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-07FROM_LIST_NO_WARN was handled aboveMike Kaganski
Change-Id: I88da25f5f2819edd78fb95573c619cd8e3187469 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159102 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159271 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-07tdf#158090: Limit signed document requirement to High security levelMike Kaganski
Commit 1dc71daf7fa7204a98c75dac680af664ab9c8edb (Improve macro checks, 2021-01-28) introduced a new requirement, that trusted macro signature must be accompanied by valid document signature when the document has events calling macros, otherwise macros are not allowed. But this breaks multiple workflows, where security level is set to limit users' ability to run unsigned macros, where documents aren't signed. As the first step, limit the security hardening introduced in the said commit to High security level; in Medium security level, restore the previous behavior. The plan is to fix more inconsistencies later, and then introduce a new separate configuration to require document signature to allow trusted macros (enabled by default), so that the combination of its default value and the High default security level keep the hardened default security implemented currently, while allowing users to opt to the previous documented behavior. Change-Id: I71ff0e531f3a42fbee7828982e4fd39f0e9d6ea3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159101 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159270 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-07Add comments for the magic constantsMike Kaganski
Change-Id: Ic35758357c18c9d172532819a3e8968fd66b26ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159100 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159269 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-07Set document's current macro exec mode consistently in adjustMacroModeMike Kaganski
Change-Id: Id69d4d043d824b1a9e558bfc9395c4ff64da7c38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159099 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159268 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-07Pass XInteractionHandler to hasTrustedScriptingSignature instead of a boolMike Kaganski
This allows to use the same interaction handler there, as used in DocumentMacroMode::adjustMacroMode. hasTrustedScriptingSignature used to find its own interaction handler; and that would conflict with e.g. ODatabaseModelImpl::adjustMacroMode_AutoReject, which passes nullptr to adjustMacroMode, with intention to not show any UI; but with signed macros (see tdf#97694), the UI would still appear. Change-Id: Ia209f96bef67dccfe1da23c4d172ac47497f8eb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159070 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159267 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-07Add a description commentMike Kaganski
Basically describing commit 71c6f438cecc3ce5e8060efe1df840652885701c (tdf#129311 don't allow temporary trusted certs, 2019-12-17). Change-Id: I4d947014b09412638560e9249f242cf6ff222cc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159069 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159266 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-07Rename variable: The UI is not only to "add" author (i.e., modify config)Mike Kaganski
It is mainly to allow macro execution for this unknown certificate once. The UI will even disable the option to add, when the config is read-only. Change-Id: Iebc526c23572dc7c0e94fac79fafc8b402d451c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159051 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159265 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-07getCurrentMacroExecMode returns sal_Int16Mike Kaganski
And that conforms the IDL definition of css::document::MacroExecMode Change-Id: I78ebfa94eb50552e7f4ecf3d64a0ac0556c56867 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159029 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159264 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-07Simplify a bitMike Kaganski
XDocumentDigitalSignatures::isLocationTrusted would remove segments itself, as needed; this change not only simplifies this code, but also potentially allows to define not only trusted directories, but also individuals trusted files (if the UI would be adjusted). Change-Id: I0b0d60946d84a52479fcce5ce49d368cf53283fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159009 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159263 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-07Avoid reinterpret_castMike Kaganski
Change-Id: I52b1f3d9fb0a3476ac1649ebc05c71aa8f2ce99e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144908 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-07Avoid unneeded initialization, and use URLZONE idsMike Kaganski
Change-Id: I8c6f31865b992fab0739fbefed5d39f21d0fa664 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144904 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-07Related: tdf#125093 Check Windows Security Zones for macrosVasily Melenchuk
In Windows, files get assigned security zones (local, from intranet, from internet, etc) after download via browser or email client. This is used by MS Word to decide in which mode it is safe to open file. This patch implements basic support for similar feature: by default there are no changes in macro behavior. But it is possible to use expert configuration options to tweak default behavior, and for example disable macros automatically, if a file is downloaded from Internet or other unsafe locations. Change-Id: I0bf1ae4e54d75dd5d07cab309124a67a85ef2d4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143680 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-07Fix buildMike Kaganski
Change-Id: I8bed8e0d267004a0a8b7b2c5e178b2a6ae6a3f05
2023-12-03Bump version to 7.5.9.2.M1Andras Timar
Change-Id: Ib8f1ce745fae2b7d6158a7e6154e0d903d783b98
2023-12-03backport skia "Avoid combining extremely large meshes" fixCaolán McNamara
Change-Id: Iaedd03ba4014b133bc28a4b0a6a7b6aaaaa39a97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160116 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-03update creditsXisco Fauli
Change-Id: I086375044292658c7bfb7b7d4a99d4d1e1313ac3 (cherry picked from commit 7b96db51608e237155a37c7b5d31ef408a19019b)
2023-12-03update creditsChristian Lohmaier
Change-Id: I1c4a240ba3af7805865b96fbee4911c022cac897 (cherry picked from commit 53f91fb880a5360ace7d0de5fce785088c8d19d6)
2023-12-03upgrade libcmisCaolán McNamara
Change-Id: Ie2d5f3f8208f9952db5be10905b5905cd03b91de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159366 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 3368447e826d4204086e4d8bfe59af4412c16233) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159454 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 25b159729f1202ca2a42de5e76f22718d68400c8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159589
2023-12-03tdf#155266 force flush after scrollingPatrick Luby
This is the second attempt to force a flush after scrolling. Commit 9c0803edd1f42b2d29115674795c7c674fea1a35 worked on Mac Silicon but not Mac Intel. So, instead of calling [NSApp currentEvent] to determine if scrolling has occurred, mark the AquaSalFrame whenever a scrollwheel or mouse drag event is dispatched so the frame will be flushed in the next AquaSalFrame::Flush() call. Change-Id: I2d0b99d2cd1167e92c7fd89bf53b2f30ab85a165 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159003 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> (cherry picked from commit 0c54c09aeb7e170512195c8f619ab2ded98c1ec5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159038 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-03curl: mitigate migration to OpenSSL on LinuxMichael Stahl
The problem is that curl 8.3.0 removed the NSS backend, so we now have no other choice than to use the bundled OpenSSL on Linux. Currently any curl https connection fails with: CurlSession.cxx:963: curl_easy_perform failed: (60) SSL certificate problem: unable to get local issuer certificate Apparently this requires manually telling curl which CA certificates to trust; there is a configure flag --with-ca-bundle but that is useless as it tries to load the file relative to whatever is the current working directory, and also did i mention that there are at least 3 different locations where a Linux system may store its system trusted CA certificates because ALL ABOUT CHOICE. So add a new header with an init function to try out various file locations listed in this nice blog article and call it from way too many places that independently use curl. https://www.happyassassin.net/posts/2015/01/12/a-note-about-ssltls-trusted-certificate-stores-and-platforms/ TODO: perhaps bundle a cacert.pem as a fallback in case the system chose to innovate by putting its certificates in yet another unexpected place (regression from commit c2930ebff82c4f7ffe8377ab82627131f8544226) Change-Id: Ibf1cc0069bc2ae011ecead9a4c2b455e94b01241 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158915 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 11f439b861922b9286b2e47ed326f3508a48d44e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159125 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-03libcmis: fix regression setting wrong type of CURLOPT_SEEKFUNCTIONMichael Stahl
Change-Id: I45421bbe13626aa843380e77f589e793328f99d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159010 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 584c01394ff06072b11ef4bd4bffb9e7f2d31e81) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159124 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-03libcmis: HttpSession: add a callback that can be used to configure libcurlMichael Stahl
Change-Id: I6c2a3d1976f2256b21a3a306db7fbf04ca444c32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159000 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 061e48e607291c2992c81d3073a8c41387c56996) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159123 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-03libcmis: fix regression in HttpSession::initProtocols()Michael Stahl
Change-Id: I1d884945cc1f88a3abbf87c78227b56abf865c16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158999 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 385aae6595fa467c73b6fdede5153d785c3ce138) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159122 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-03upgrade to libcmis 0.6.0Caolán McNamara
Change-Id: Ia22d2efca14b1f55f45a4ecb9c487591c3117e17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157704 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 4e1a5d693e408db170ccf4c84b49017056f289fa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159121 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-03tdf#158038 fix opening pdf files in appstore ver (sandbox issue w/ helper tool)Christian Lohmaier
https://developer.apple.com/documentation/xcode/embedding-a-helper-tool-in-a-sandboxed-app "Adding other entitlements to the tool can cause problems. If the tool immediately crashes with a code signing error when your app runs the tool, check that the tool is signed with just these two entitlements: com.apple.security.app-sandbox and com.apple.security.inherit." This is indeed what happened.. Change-Id: Id03948c03b7d453aae4ca58719f582576e30a16f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158790 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 2c3fe12e0ffc59be7c28d9b9908db881adb0f1ea) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158709 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-03update creditsChristian Lohmaier
Change-Id: I9ca75498e8f0df14fab318c54f0b29805ccfe3a3 (cherry picked from commit 7fff4e2ca6739928f72e5f0d2eb5820823916769)
2023-12-03Resolves: tdf#157849 gtk_spin_button_update callback can delete widgetCaolán McNamara
so later GtkInstanceEditable::signal_activate is on deleted widget Change-Id: I9bb9848b4554792db11fc7b0e2d3491a94975b3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158168 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-03tdf#157397 vcl: PDF export: fix CreateControl replayMichael Stahl
The problem is that the CreateLink and CreateControl actions are replayed in a different order than they are recorded, because CreateLink is a global action, and CreateControl a page action. This means that the mCurId at the time when PDFExtOutDevData::CreateControl() is called does not correspond to a position in mParaIds when CreateControl is replayed; it will be inserted too early and bump all the CreateLink ones to later indexes. Avoid this by adding another global action CreateControlLink that is added when CreateControl is being replayed, which appears to work. (Another subtle problem is that, in case of PDF/A-1, the page actions could be discarded completely; this should work in that case too.) (regression from commit d4d471fc88fe4fd14f44dfccdfe360dec327d4f0) Change-Id: I92d89ac08db6548e9f0d1480d984aeacb4d22262 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157767 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 2e32aa1e9fc240c9cd9854655106d0decbd3694a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157863 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-03tdf#157565 show tooltip if any parent window is the key windowPatrick Luby
Commit b69db38a38b09e158e8d46d8b717db85860ca874 caused tooltips to fail to appear if their immediate parent window was not the key window. So, look through the parent window's parent windows and, if any of those windows are the kwy window, show the tooltip. Change-Id: Icf1aed1144fdeac03b4b208de8ed8ee2db8ad4a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158212 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> (cherry picked from commit f2b3e97b4068c3c9799a5c2efd9118200ec7dd15) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158161
2023-12-03tdf#157680 scale down size and adjust size and scale factor for /BBoxPatrick Luby
The size of an embedded PDF files is multiplied by PDF_INSERT_MAGIC_SCALE_FACTOR for platforms like macOS so undo that by adjusting the size and scale factor. For some unknown reason, when exporting the following PDF, the estimated size of embedded PDF charts are 20x larger than expected. This only occurs on macOS so possibly there is some special conversion from MapUnit::MapPoint to MapUnit::MapTwip elsewhere in the code: https://bugs.documentfoundation.org/attachment.cgi?id=190109 Change-Id: Id0563466fea3d7a3a0419787ec9da45f0c1d2e0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158156 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-12-03crashreporting: svx::SentenceEditWindow_Impl::CreateSpellPortions()Caolán McNamara
cui/source/dialogs/SpellDialog.cxx:2005 aRet[ aRet.size() - 1 ].sText += aLeftOverText; presumably aRet is empty() here a) don't bother appending if aLeftOverText is empty() b) don't crah if aRet is empty() and aLeftOverText is not Change-Id: Ie9a9585f572d8afb17183b479fb6f2cce5952aa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158047 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 3c0db58e51a24bf08ca443af62489e761063f456) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158152
2023-12-03tdf#101376 don't detach thread if it is the main thread on macOSPatrick Luby
On macOS, many AWT classes do their work on the main thread deep in native methods in the java.awt.* classes. The problem is that Oracle's and OpenJDK's JVMs don't bracket their "perform on main thread" native calls with "attach/detach current thread" calls to the JVM. Change-Id: I0859dc9e20f34bd0b43bb321898507764fd530fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157985 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> (cherry picked from commit a0eee8e56b91324470bb0e15c6b8009cfc411335) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157962
2023-12-03tdf#141457 sc notebookbar_compact: fix empty Statistics menuJustin Luth
Change-Id: If873da6e5d877a07bc4260fa5832cc29d73f4af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157946 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> (cherry picked from commit e72064ac53ac3177d4ae451358ff013443565daa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157954 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit d9b697824f31c2e2beefb023241e39ee849fc77d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158033
2023-12-03Follow-up: tdf#156985 Use SC_USE_SSE2 to determine which KahanSum::add() to useEike Rathke
Also, the CPU identifier for MSVC WIN32 is not X86 but INTEL, so actually use SSE2 there as well, which was the cause of things failing on that platform. For other platforms than Intel x86/x86_64 SSE2 is not defined, so exclude the new unit test based on that and live on with the old slightly off value. Experiments did not yield any solution that works, even using plain sumNeumaierNormal() (similar to SSE2) in the executeUnrolled() case instead of KahanSum with its m_fMem did not help, nor trying to add the internal values in different orders or with long double, au contraire the error was slightly larger. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156899 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 361c4f008e48b08df635839d2e5dcad7389df44a) Conflicts: sc/qa/unit/ucalc_formula2.cxx Change-Id: Ica0b2963f76c01f248799e9a809ef06eb099e722 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157964 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-03tdf#157613 make sure surface is not a null pointerPatrick Luby
Change-Id: I8e3c1be3f05f7ccc1f3ba00093cd71a564e5ae9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157848 Reviewed-by: Patrick Luby <plubius@neooffice.org> Tested-by: Patrick Luby <plubius@neooffice.org> (cherry picked from commit bacdae0d6b0cec4de39812496f6ffafe04629411) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157871 Tested-by: Jenkins
2023-12-03curl: upgrade to release 8.4.0Thorsten Behrens
Fixes CVE-2023-38546 and CVE-2023-38545 Minor amount of bugfixes, nothing that immediately affects us. New feature: IPFS protocols via HTTP gateway now supported, with the right URL. Change-Id: I24af4d17b570685081aa031c50a87bb8dcf1833d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157786 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-12-03tdf#156902 Do not set glow on group shape in importRegina Henschel
Currently a group is not able to use glow. But in MS Office it is possible. When we try to set glow at the group, we produce an exception and no children are imported. So for now the patch prevents setting glow. Change-Id: Ifa7245ebf3c38f8685239c2b62eefccd35aab870 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157679 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit e84ae94270f0f0037fa2662a5f2765b37a50c33e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157711 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157702
generated by cgit (git 2.34.1) at 2024-07-08 09:34:32 +0000