summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-09-20Bump version to 6.4-48cp-6.4-48Andras Timar
Change-Id: I775f09f0d58bf6ea9bd322414221e25a757ed9e2
2021-09-17lok: ensure no more tunneled spellchecking menuHenry Castro
Change-Id: Ic79d9b6d606573d93830347390c6466b033e9f12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120963 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-09-17lok: IME: directly copy formatting for inserted textSzymon Kłos
This is a fix for online where after: lok: IME: preserve formatting when inserting at the end of paragraph https://cgit.freedesktop.org/libreoffice/core/commit/?h=distro/collabora/cp-6.4&id=bf96d1f23e5c12f9263643dfdab94fd1361bb098 text formatting is lost. Change-Id: I3d316f8f4c4d750eac7900228f9f2d99f70d99bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122199 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-09-15lok: IME: preserve formatting when inserting at the end of paragraphSzymon Kłos
There was a problem with inserting characters at the end of paragraph in online. When user set text to bolded, inserted few characters, then switched bold off. When trying to put another non-bolded character - the result was still bolded. It is caused by IME mechanics which gathers all elements for composition and at the end deletes these characters and inserts again but using document interface to keep undo records. During that operation formatting has been lost. This change does the same in reversed order so we first put new string correctly formatted at the end. Then we remove old leftovers. In result formatting is correct. Change-Id: Ieb498afdbe42c0080c30ea3db994cedc98e89847 Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121774 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2021-09-09Revert "tdf#142214: autocomplete: do not search across empty blocks"Ilmari Lauhakangas
This reverts commit ca2ec443893731093970914feb750b31ea13e47f. Breaks user experience. Removed ScTiledRenderingTest::testAutoInputStringBlock as well. Conflicts: sc/source/core/data/column3.cxx Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121640 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> (cherry picked from commit 223f3a6fac43580114bca86abb34d7cf3219f4bc) Change-Id: Id03bc645d78c29c0aa588b2133fc1cb96f3cceb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121810 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-09-08Revert "Tentative fix for crash in the iOS app"Tor Lillqvist
The root cause for the problem was fixed elsewhere by 0f65b4b6f33891a724bee5356aa5549c76fa0ce3 (and back-ports). This reverts (the back-port of) commit 9e4c72ec7ea83aa0d023a90a6b02ddb17c6b2d74. Change-Id: I0167846d2aaeacc66657b4203d0118b7847679ba
2021-09-04speed up scanning the LOK queueNoel Grandin
we frequently scan the queue to caolesce events. Most of the time we are scanning based on the event type. So split the queue data into a compact queue that only contains the type, and another queue for the rest of the data. That makes the scanning __much__ more cache-friendly. Change-Id: I92d0b95611cd139cac8532f9297eaabda71d5fe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119996 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-03sw: fix crash in SwView::Execute()Miklos Vajna
Crashreport: program/../program/libswlo.so SwView::Execute(SfxRequest&) sw/source/uibase/uiview/view2.cxx:1312 program/libmergedlo.so SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) sfx2/source/control/dispatch.cxx:263 /opt/collaboraoffice6.4/program/libmergedlo.so SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) sfx2/source/control/dispatch.cxx:760 (discriminator 3) /opt/collaboraoffice6.4/program/libmergedlo.so SfxDispatcher::Execute(unsigned short, SfxCallMode, SfxItemSet const*, SfxItemSet const*, unsigned short) sfx2/source/control/dispatch.cxx:819 Change-Id: I2e7b27f458971dbd33971589f71337c59981ee83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121547 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2021-09-01Bump version to 6.4-47cp-6.4-47Andras Timar
Change-Id: Ic2afbbc77616bb9beac7b4d2fb9aa4bf1780ed2f
2021-09-01openssl: add patch for CVE-2021-3712Michael Stahl
Change-Id: I4061cbac18ddf9c7f932a27bf2b54a2b1c2f9d99
2021-09-01Stopgap workaround for misspelling wavy underline drawing bug on iOSTor Lillqvist
Explicity make the rectangle white before drawing the red wavy line. Sure, this means that it looks bad if the document background colour is not white. Better than how it looks currently, though, with the rectangle containing the wavy underline ending up (for unknown reasons) black. And most documents have a white background. Change-Id: I92b2246bbdbd1404e4c48292c3610d1582a56163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121370 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-08-31Check mpWindowImpl before use in Window::EndTrackingSzymon Kłos
Change-Id: I0a4ddd1b61f5919f346bb2f3a1e2ca9fbad958bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120860 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-08-29LOK: avoid writing freeze pans data to file if not setPranam Lashkari
Change-Id: I9bc4023ae1673a2ae68db584357fb6c6643342a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121125 Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2021-08-29Take the PDF graphic rendering DPI into account when exportingTomaž Vajngerl
Change-Id: I1d3465fc7357e6991161d5a96bcd70c53c55f244 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121072 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-08-29fix -Werror -Wsign-compare error on AndroidAron Budea
Change-Id: I08ce05fa25af17d1df4ba17cae89ac11d860494a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121215 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2021-08-28cid#1490403: fix wrong initial flag bFoundDennis Francis
Change-Id: I502653985e54c82198034534bb878d06787f8c94 Signed-off-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120859 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-08-23LOK make sure single row/column table are resizablePranam Lashkari
First row/column are treated as heading in the table, that's why need some special case handling for it First row/column are not counted in regular row/column Change-Id: If67b759911ea87f2b166a69243b85e98d90c4d22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120778 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-22calc: get rects faster for simple selectionSzymon Kłos
In LOK when we select the full row using keyboard shortcut Ctrl + Shift + right arrow we need to receive complete selection so we will avoid requesting it by chunks, slowly moving the view to the right. So - don't clip the selection rects to the visible area. It is needed only for simple selections so to avoid performance issues - use simpler algorithm without loops checking every cell size. Change-Id: I6ab975b6c155f3dde3014a52752ffdc79a93844f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120611 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2021-08-22curl: upgrade to release 7.78.0Michael Stahl
* Fixes CVE-2020-8284 CVE-2021-22924 * Also fixes these which don't look relevant to LO: CVE-2020-8231 CVE-2020-8285 CVE-2020-8286 CVE-2021-22876 CVE-2021-22890 CVE-2021-22897 CVE-2021-22898 CVE-2021-22901 CVE-2021-22922 CVE-2021-22923 CVE-2021-22925 CVE-2021-22926 * disable some new protocols and dependencies * remove curl-ios.patch.1 as the code no longer exists upstream Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119313 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 946f457c885bd10ff1a7281c351f3981f035f5a7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119262 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Change-Id: I12d5f87f4d503a5f9859226a05cfe2a07e46d993
2021-08-18unit test for escaped unicode chars in strings importDennis Francis
Change-Id: I4c4190538bdcb3292546d6d5884eb7900807060c Signed-off-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120623 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-08-18sc oox: recover escaped unicode chars in strings importDennis Francis
according to OOX open spec 2.1.1742 Part 1 Section 22.9.2.19, ST_Xstring (Escaped String). In this implementation, some restrictions mentioned in this spec are not kept for simplicity. Change-Id: If27797a9625d49be54c600c8a864965f1101ceb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120570 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-08-18sc: lok: introduce LOK_CALLBACK_DOCUMENT_BACKGROUND_COLOR callbackDennis Francis
to send the document background color (Calc only for now). Change-Id: Ibd2f042a81c9bb714bed947c4ef92f82ff3e6f50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120524 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Dennis Francis <dennis.francis@collabora.com>
2021-08-17Fix nesting level bug in ProfileZoneGopi Krishna Menon
Move the profile zone global nesting variable into the source from header and make it thread-local. Change-Id: I97751f5c532d8e0e36adb7d9d383bd88f752953f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119657 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-08-16Bump version to 6.4-46Michael Meeks
Change-Id: Ic7e142795efaae460e12dc8c69b8848450a13d8a
2021-08-13sc: lok: avoid selection jumps with multiple usersDennis Francis
In LOK case, avoid spurious "leavingwindow" mouse move events which has negative coordinates. We later use these coordinates to compute the cell address corresponding to the event to extend the selection which will be wrong in this case. Such spurious events occur for some reason when a user is selecting a range, (even when not leaving the view area) with one or more other viewers in that sheet. The root cause of these bad coordinates seems to be in vcl in winproc.cxx, ImplHandleMouseEvent() in the code block starting ``` // test for mouseleave and mouseenter VclPtr<vcl::Window> pMouseMoveWin = pWinFrameData->mpMouseMoveWin; if ( pChild != pMouseMoveWin ) { if ( pMouseMoveWin ) { Point aLeaveMousePos = pMouseMoveWin->ImplFrameToOutput( aMousePos ); ``` This needs more investigation. Meanwhile this interim patch fixes the issue of selection jump by avoiding those unhelpful mouse events. Change-Id: I01fb3ae6a3903ada2a44a8b3d2b4a46b0122326b Signed-off-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120317 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
2021-08-11use tools::Json for cursor messagesNoel Grandin
and tweak the JsonWriter to produce output more like the boost propertytree, to make the cypress tests happier. Change-Id: Ia2062508ae9f14a5f89306042c33884ff300f478 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119936 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-09sw lok: avoid expensive DLPre/PostPaint2() around InvalidateWindows()Miklos Vajna
This shows up on profiles and it's not needed. It was only there, because Online always needs an invalidation to have updated tiles, so there the paint was replaced with an invalidate. And then the drawinglayer setup/teardown was not made conditional by accident. The PaintTile() case goes via Paint() -> PaintSwFrame(), which still calls these functions; this commit only speeds up SwViewShell::ImplEndAction(), which is called synchronously e.g. on every keypress. (cherry picked from commit aff28c59816d046d9b74460c1b17101b99b9514e) Change-Id: I6c362f148bc2837bd842602754770c5267e16afd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120200 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-09sw: fix assert fail with ShowRedlineChanges=false and para formatMiklos Vajna
It fails like this: loolforkit: sw/source/core/layout/wsfrm.cxx:4551: void UnHide(SwRootFrame&): Assertion `rLayout.GetCurrShell()->ActionPend()' failed. #4 0x00007f98e9f8c198 in UnHide(SwRootFrame&) (rLayout=...) at sw/source/core/layout/wsfrm.cxx:4551 #5 0x00007f98e9f8c839 in SwRootFrame::SetHideRedlines(bool) (this=0x7f98c40f7bd0, bHideRedlines=false) at sw/source/core/layout/wsfrm.cxx:4664 #6 0x00007f98e9b18afd in sw::DocumentRedlineManager::SetRedlineFlags(RedlineFlags) (this=0x80a4120, eMode=49) at sw/source/core/doc/DocumentRedlineManager.cxx:1097 #7 0x00007f98e9cfa503 in SwEditShell::SetAttrSet(SfxItemSet const&, SetAttrMode, SwPaM*, bool) (this=0x8885840, rSet= SfxItemSet of pool 0x808fd10 with parent 0x0 and Which ranges: [(63, 64), (120, 120)] = {...}, nFlags=SetAttrMode::DEFAULT, pPaM=0x0, bParagraphSetting=true) at sw/source/core/edit/edatmisc.cxx:187 #8 0x00007f98ea995f07 in SwTextShell::ExecParaAttr(SfxRequest&) (this=0x8bd0820, rReq=...) at sw/source/uibase/shells/txtattr.cxx:451 Fix it the same way commit dd489bc01adc22fc5015ea56b61d66104af184a8 (tdf#125754 sw_redlinehide: avoid recursive layout in SetHideRedlines(), 2019-06-19) did: make sure that SetHideRedlines() is called before EndAllAction(). (cherry picked from commit 39392ee94c78692a9179f7face15af0c9e74e492) Conflicts: sw/Module_sw.mk Change-Id: I6304abec2e2e2967a8369b0219492bebcd606d03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120098 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-06lok: sc: unit test for non existent tab view data fixDennis Francis
Conflicts: sc/qa/unit/tiledrendering/tiledrendering.cxx Change-Id: I7c0ea95118448a49288ff70c8e7bcddc379df5ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119602 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-08-06lok: sc: avoid crash on non existent tab view dataDennis Francis
... when accessing position helpers. Change-Id: Ia627a8c4ed30ad1f1c2333df00b656fe041f111e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119601 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-08-04improve LOK notifyInvalidationNoel Grandin
(*) tweak buffer in SfxLokHelper::notifyInvalidation to be a bit larger, so we avoid the cost of a resize&copy (*) use our optimised OString concatentation instead of going via std::stringstream (*) pass down a pointer to rectangle, instead of a string. later we will use this to avoid doing the stringify until later Change-Id: Ia3e3042bc919d9b9cb80e47a93704eb236438605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119994 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-08-02vcl: avoid native widget pieces for disposed BorderWindow.Michael Meeks
Fixes crash around help windows: vcl::Window::IsCompoundControl() const vcl/source/window/window2.cxx:1200 vcl::Window::Show(bool, ShowFlags) vcl/source/window/window.cxx:2243 (discriminator 3) vcl::Window::Show(bool, ShowFlags) vcl/source/window/window.cxx:2298 HelpTextWindow::ImplShow() vcl/source/app/help.cxx:371 Scheduler::ProcessTaskScheduling() vcl/source/app/scheduler.cxx:495 Change-Id: Ia0205813f3e9d306314577d59d6cdd1bdfa0ee71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119881 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-07-28tdf#136113 shape editing does not change modified statusNoel Grandin
regression from commit edf13fe1247e7ef411a9ff5435385573fad01f56 tdf#93831 xlsx file full of pictures of numbers slow to open No real idea why this fixes it - I suspect that the referenced commit was forcing the initialisation of the drawing layer too early. This commit does not making the related xlsx file any slower to load. Change-Id: I1d8fdc5134a1b70bf214df642a9e7a386b853895 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101491 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit c9b81503a85a2763e1bfd1b6722fcf6d96a983e7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101467 (cherry picked from commit 3905cb1b2c723617298dd525cf18669f3ca5720b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119447 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2021-07-28Revert "Add a few more ProfileZones"Tor Lillqvist
The output from these are events with zero or one microsecod duration in the overwhelming majority of cases and thus useless. This reverts commit ffcca583b856cd9d1f7f6fd373bfa617c49c1ef4. Change-Id: If8576b0432451a205ee7cae8a845e8ed17f3f347 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119583 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-07-26Deduplicate reference marks and cell auto fill messagesSzymon Kłos
We use only the last value Change-Id: If3536b5b4bc67755cb7bb73850a590d37675e6a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114547 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-07-20Bump version to 6.4-45cp-6.4-45Andras Timar
Change-Id: I0d433c5deff7419fb178cbe7e2efca91dc43cff9
2021-07-20Add a few more ProfileZonesTor Lillqvist
Change-Id: Ic7f9630fb31a3fae147460cc5d406b4428b35812 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118406 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-07-18tdf#57351 sc UI: fix disabled Insert Columns optionsTünde Tóth
In a sheet with active autofilter or standard filter, Insert Columns Before/After weren't available in the context menu of the column header and in Sheet->Insert Columns... Change-Id: I746d7d5a451848306d67d57e42d3981c471c66f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115400 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119146 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-07-16vcl: check mpWindowImpl for nullptr.Michael Meeks
Crash in calc's mouse capture / end tracking. Change-Id: If5b4cded8ebfc04d1fcf645a7b74184532ab2338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119069 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-07-16sw: xDictionary may be an empty reference in SID_SPELLCHECK_IGNORE_ALLMiklos Vajna
Seen in a crashreport: handleFatalSignal ./common/SigUtil.cpp:255 /lib/x86_64-linux-gnu/libpthread.so.0 __restore_rt ??:? program/../program/libswlo.so SwTextShell::Execute(SfxRequest&) sw/source/uibase/shells/textsh1.cxx:1496 Change-Id: I709f361a1396abbb07cea06509afc41bb5f5c9a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119006 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-07-16Revert "Notebookbar: skip early init in all apps"Szymon Kłos
This reverts commit 6af0a488a059982a8b5d72fe399c7e8841a2e9b4. Delayed notebookbar init in Calc causes "number format" combobox to not work. (it works after some number is typed into document only). Original problem fixed by reverted change doesn't exist anymore because new shortcuts for paste special and paste unformatted text were introduced Change-Id: Ie112ae0df7b6d3782916b98c96f1a17b15396115 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118771 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-07-15lok: include the label of the status indicatorHenry Castro
Change-Id: Ib2714e3d2b6add54ffba753d3519aeba7a3f1959 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118681 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-07-15sw lok: guard against half-constructed views in sendLOKCursorUpdates()Miklos Vajna
Crashreport backtrace is: SwCursorShell::sendLOKCursorUpdates() sw/source/core/crsr/crsrsh.cxx:2044 SwCursorShell::UpdateCursor(unsigned short, bool) sw/source/core/crsr/crsrsh.cxx:2032 SwCursorShell::GotoFieldmark(sw::mark::IFieldmark const*) sw/source/core/crsr/crbm.cxx:315 SwWrtShell::GotoFieldmark(sw::mark::IFieldmark const*) sw/source/uibase/wrtsh/wrtsh3.cxx:93 (discriminator 4) SwWrtShell::SwWrtShell(SwDoc&, vcl::Window*, SwView&, SwViewOption const*) sw/source/uibase/wrtsh/wrtsh1.cxx:1709 SwView::SwView(SfxViewFrame*, SfxViewShell*) Change-Id: I26e0615747290c1e596db54cdbbc93b61b4067a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118938 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-07-14vcl: make get_id safe for disposed windows; avoid unsafe use as well.Michael Meeks
crash from: findChild(vcl::Window*, rtl::OUString const&, bool) include/rtl/ustring.hxx:1744 WindowUIObject::get_visible_child(rtl::OUString const&) /vcl/source/uitest/uiobject.cxx:463 lcl_sendDialogEvent ... Change-Id: Ic1756c7b03f2dee9780fb1a735917f1d0fc11876 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118690 Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-07-12tdf143222 Handle alternate content of graphicData element.Gülşah Köse
Handle alternate content and make true choice. According to ooxml spec ole object requires exactly one pic element. (ECMA-376 Part 1, Annex A, CT_OleObject). In the current case first choice has not pic element and we should allow fallback processing. Change-Id: I30b7de703b8c2f00d6bf286e05eea505ac3627f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118539 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118678 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-07-09sfx2: fix uninitialized SfxViewShell::mbLOKIsFreemiumViewMiklos Vajna
Introduced in commit 1b9fe58acb7b5bbbc83ecca30e17663fff7f0db4 (LOK: introduced Freemium LOK API, 2021-06-02). Change-Id: Ifdd6c13a64a167fa00b0305441c52340167f3809 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118632 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> (cherry picked from commit d6811bd47a255d40aeb4509c7011fa7d9e75e3f3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118639 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-07-09lok-desktop: unit tests for LOK_CALLBACK_TABLE_SELECTEDDennis Francis
Change-Id: I4e07ffc6f8eebbbee284d19cd9c77df13dddff3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118002 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-07-08fix cairocanvas build with internal cairoLuboš Luňák
3a4bfe3e45be2d5b591ab5cae3694c9492ca9e1b made cairocanvas #include also a pixman header, but the internal cairo case wasn't setting up the pixman include path. Change-Id: Ib0daab3a5ec1a6ebf1b29eb37b039d2f41f770c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114491 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 04bd21d483c33c5011e31ac12d02c9e00dc410ce) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118499 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-07-06lok: sw: avoid duplicate LOK_CALLBACK_TABLE_SELECTED msgsDennis Francis
Alternate approach is to track changes in the active table in each view but it needs a bigger change and run the risk of overlooking cases where table dimensions and position changes, which is possibly why this message is created from UpdateCursor() in the first place. Change-Id: I06643e2a7416d6c0fe2b0dc5c9b4adcd45fa50c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118001 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-07-06Bump version to 6.4-44cp-6.4-44Andras Timar
Change-Id: Ib76eca9727221edf513db015825f5c4cf2b5f528
generated by cgit (git 2.34.1) at 2024-08-11 00:54:43 +0000