summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-03-03KJ: Fix for tdf#131061rizmut
- Update Cell Styles icons naming - Update icons in Merge Cells dialog Change-Id: If5c9ea38399f1f5f436a8c86d097369432705644 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89821 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-03-03sw padded numbering: add doc model and UNO APIMiklos Vajna
The idea is to behave similar to Arabic numbering, but pad the result on the left up to 2 characters. Word has this feature, so far Writer falled back to plain Arabic numbering. This is just the document model, not layout yet. Change-Id: I8ac90536848d00b8678129184db0849130724dee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89846 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-03sw doc model xml dump: show numbering typeMiklos Vajna
Change-Id: I6d2145469b8153c86294c40e1b3dfcc9d65ced60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89819 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-03uitest: split up UITest_writer_demoMiklos Vajna
I used solenv/gbuild/Trace.mk to measure where the time is spent at the end of an incremental 'make check'. The last 141 seconds is spent executing UITest_writer_demo alone. If that test is executed in isolation, it takes 289 seconds. I measured the cost of all the individual .py suites and arranged them into 8 separate UITests, this way the make -j8 cost is 101 seconds (i.e. 35% of the baseline). IOW this is supposed to speed up 'make check' with 3m13s, provided you have the code already built. Change-Id: I1ffee3a06b8fd84d7b9a0295547900df11f11f68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89835 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-03tdf#84399 VML import: map <v:shape o:spt="202"> to TextShapeMiklos Vajna
This partially reverts commit 81f9fe3a14f0fc99afbfa7ce3a26a9c7855d0919 (fdo#74401 VML groupshape import: only handle v:rect as TextShape, 2014-03-19), which wanted to map triangles to custom shapes. It was overlooked that we can have not only explicit rectangles and custom shapes, but also <v:shape> elements which have their shape type explicitly set to TextBox. The later is now again handled similar to rectangles. This keeps the triangle case working, but fixes the <v:shape o:spt="202"> case. We need to make this decision while parsing the XML, so some rework is needed to have earlier access to its container (group shape or draw page) and also to its shape type. Change-Id: I33a4b3cd03b0df5d93cffa19e7ea834113df2bdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89852 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-03Missing dependencyStephan Bergmann
(see <https://gerrit.libreoffice.org/c/core/+/89474/2# message-df62334d1cd68aee22bbd7ee451bafba9bd62b72>) Change-Id: I12d7bb4f0be102943e8c8dc204e517d045bc0d1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89837 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-03Adapt solenv/flatpak-manifest.in to recent download.lst changesStephan Bergmann
...and to f3e7004794eded346d98264d3061f4e4aa80ee0a "tdf#130725: use strtod by David M. Gay to make sure we get the nearest" Change-Id: Id26259f15587c9ab9cc4722b40c09153026c3f42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89845 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-03Revert "Make Chart Creation Wizard async"Stephan Bergmann
This reverts commit ed86b6250cd00ed6b7bdb81307bc66adba129cae. Reason for revert: Most Jenkins builds for that change were aborted after timing out, and many other Gerrit Jenkins and tinderbox builds now time out, too. It very much smells like that commit was the culprit. Change-Id: I5473c58957f92d63113e32f862ad9c114f9c844c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89803 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-02Fix Korea's Hanja Upper Numbers codepoint array #tdf130077DaeHyun Sung
fix code point for Korean Numenic strings codepoint array 5 伍 1000 阡 Change-Id: Id6b37fbaf5ca538ae61555d8c2237c66406c4fb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87240 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-02ofz#20976 build-failureCaolán McNamara
Change-Id: I6fc81e6ef13f77dea410f95e159a932089603aeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89801 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-02Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 6e4e81d1d12dd131a8ceb95255544b8f51f302d8 - improve links to module-specific help pages for Styles window Change the present method of linking the "Styles" header for each module to a generic page with an activated link to the relevant styles help page to go directly to that page. Each of specific pages calls "text/shared/02/01230000.xhp#stylist" This patch moves the switch in this page to be applied to the Styles header. Change-Id: Icb846f44d5eb61e8a42612c0d8e05de2c959f7d2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89786 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-03-02Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 3fd0111f7071d3feed644b88c3227817c422510b - Helper to refactor paragraphs in XHP The helper transforms XHP paragraphs into : roles=note, warning, tip into <note>,<warning> and <tip> roles=heading and level=[n] into <h[n]> usage: xsltproc refactor.xsl source.xhp > target.xhp Change-Id: Ib3d69aebc35978f6e73a27bee232864bfe6e8463 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89832 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-03-02Revert "ofz#20976 build-failure"Caolán McNamara
This reverts commit 5b22433d79823372744038c5ae28094bc938fb48. Reason for revert: <INSERT REASONING HERE> Change-Id: I4a104ca86dadbcc7f797df41326d48a53ca1c990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89800 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-02ofz#20976 build-failureCaolán McNamara
Change-Id: I31434d2b979aff20a53b164ffbb3d19247cd1ce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89826 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-02tdf#130986 Chart OOXML export: fix number format of custom labelBalazs Varga
Export correct sourceLinked attribute in c:dLbls/c:dLbl/c:numFmt, as in c:dLbls/c:numFmt. Change-Id: I0e52720b3cb2c99550a779763f01ba12f762050d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89638 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-02uitest: check copy in .uno:MoveXisco Fauli
Change-Id: I916d3853500705b1037aa669374511c184402313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89822 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-02Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to eb8ea00768b65b71653e85fdcda022fc39df211d - Created help page for submenu Text Removed help page for Change Case as it was merged into Text. Change-Id: I85fbf915f71135d21bc180385fe3aa3013e5a2cd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89628 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-03-02Fix typoAndrea Gelmini
Like in 7fe40724b7b07710a501710466b6f10b526c2c97 Change-Id: I52eeeb46d4a6de44af94bc6fb3fb19b1c2dab3b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89759 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-02Fix typoAndrea Gelmini
Change-Id: Ib03d068389d70866490456372cea1038366bfa2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89831 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-02can pass length to icu compare hereNoel Grandin
which will skip the need to do strlen() Change-Id: I0c9663f5f51f158179c4e0725c1901d7256173e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89817 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02Qt5 unify font attribute conversionsJan-Marek Glogowski
Adds conversion functions for VCLs FontWeight, FontWidth and FontItalic to Qt5FontFace and remove the partial "switch" tables from KF5SalFrame. And correctly handle the FontWidth in Qt5Font as the stretch value, so the default font in qt5 gets the correct stretch and doesn't look bold. Change-Id: I698986416dff13e6dfaf9dfa7f95851b89e9137d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89813 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-03-02clang-format lotuswordpro with under 5-percent lines of changeMuhammet Kara
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: I4527dcc9aaabd1fba3363c0aa2bf3217e42ef45e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89776 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-02fix get_SHA_for_change in logerrit scriptNoel Grandin
after commit 02b5d09c0dab1621ce23f9a8df45fa1628be3ece tdf#105204 fix shellcheck warnings in logerrit the previous get_SHA_for_change returned a URL with a leading space, which was previously implicitly stripped. Adding quotes prevents that stripping, so we need to explicitly strip here Change-Id: I5b303f6ca5b1dc7d2a369afc2c52830b1b9586eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89816 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02tdf#118893: avoid nullptr dereferenceMike Kaganski
Change-Id: I56ada18348ed1b1ebe5e1d6f000391965d822b4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89815 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-02Qt5 some refactoring for HiDPI mergeJan-Marek Glogowski
This is a preparatory patch for merging the initial fix for tdf#127687, the Qt5 HiDPI scaling support, and generally to make the style handling code a little bit more readable. It includes: * Moving all lcl_ Qt5Graphics_Controls functions into the class as private functions without lcl_ prefix. * Add three additional helpers - pixelMetric, sizeFromContents and subControlRect - to cut down boilerplate QApplication::style()-> prefixes for the style calls everywhere. * Drop the superfluous Qt5Frame::TriggerPaintEvent functions. * Drop the single, broken maGeometry.nTopDecoration filling. * Split some very long lines of nested call code by using some intermediate variables. * Move a Qt5Data include from hxx into cpp Change-Id: Iae1bfafd14c4163447f3d55e2307f0f617e68a0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89751 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-03-02speedup sw build a littleNoel Grandin
from 11m46 to 11m21 Used ClangBuildAnalyzer to find headers that took a long time to parse (in total, across all modules). (*) moved the boost stuff out of sw/inc/docary into a new header. (*) make sw/inc/ndtxt no longer include doc.hxx Change-Id: Ia1d4ebddb4ddd4ec4ffbc011f4a5e24a42b46d3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89808 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02prevent gbuildtojson.py from removing the GBUILD_TRACE fileLuboš Luňák
It starts a new make (MAKE_RESTARTS is again not set), so the code for removing the file gets triggered again. Change-Id: If48214703fd86337a5bfa2c1c8e67cbdfbdfdfad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89814 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-02cid#1459023 Dereference null return valueCaolán McNamara
Change-Id: Id99adac0a544b59b6ac8f6ac225df1f218ed8405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89765 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-02tdf#126904 calc right arrow large unexpected column jump in protected sheetNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I3b6f6e5430c97ef52f63c406eb3c3b39b9dd578e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02tdf#42949 Fix IWYU warnings in svx/source/s*/*cxxGabor Kelemen
Except for already done svx/source/sdr/ Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I1c4b34cf42aa9faa2f7de36fe1602059460c6c1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89656 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-02sw: layout: fix wrongly positioned table rows in --convert-to pdfMichael Stahl
If the document is loaded via UI, the first layout action is triggered from resizing the Window and the table is positioned properly on the first try. If the document is loaded via --convert-to, only getRendererCount() formats the content of the table, and the table is positioned 3 times but its first row is only positioned 2 times. The first time the table id="56" is positioned, the previous table id="50" is at correct Y 5988 but its content isn't formatted yet, so its height is almost 0 (just table's border etc.), so the table ends up at y = 6271. The second time the table id="56" is positioned, the previous table id="50" is at wrong Y 7937 and its content is valid, so its height is 1203, so the table ends up at y = 9140. The third time the table id="56" is positioned, the previous table id="50" is at correct Y 5988 and its content is valid, so its height is 1203, so the table ends up at correct y = 7191 ... but the first SwRowFrame remains at y = 9140 and is never repositioned, and the lower rows are cut off (invisible). Change SwTabFrame::MakeAll() so that a MakePos() that moves the table itself does not leave the first SwRowFrame's position valid, which should ensure that all rows are repositioned. (And work around C++'s particularly unhelpful type system.) This happens since the earliest version checked, OOo 3.3. Change-Id: If3dfe1ffcb81e03aa4f4bffcf33a237f0c92bd08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89735 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-02tdf#131031 Gtk3 presume the resize did happenJan-Marek Glogowski
Regression from commit b26ca5b13733b46c2df0787502f885e15b390956 ("tdf#130841 resize to client size after SetPosSize"). It just happens for me on gtk3, not gen and not win. But since gtk3 also sets the nX and nY value SetPosSize eventually before the fact, do the same for the nWidth and nHeight. Change-Id: I2898c403b73de790f3f988b8b8ec2067f4b0b43f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89760 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-03-02tdf#131062 DOCX import: fix table-style paragraph background colorLászló Németh
by comparing fill attributes to ParaBackColor to avoid losing them. Regression from commit a9ba8e57a41c5ddf3597272bddab30e51fb3fd38 (Revert "tdf#118947 sw tablestyle: manually scan parents for ::SET"). See also commit 24077b2d52ab3d0fd0db5afb25d8b94b62386e3e (writerfilter: import paragraph color as fill attributes) Change-Id: Id42ea3adaddf883435dd61e5dea0e6c5fb89f927 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89215 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-02Make Chart Creation Wizard asyncSzymon Kłos
* FuInsertChart as a memeber in ScTabViewShell stores instance is needed to react on the dialog's result * CreationWizardUnoDlg converted to XAsynchronousExecutableDialog added dialog close handler which notifies listeners In the Online dialog become dead after closing, additional PostUserEvent was needed to kill the dialog after real close (without it user needed to select any cell to close dialog) * Reuse in Writer Change-Id: I9fe123d5c189d568f0edb4d36173a224a820a8a3 Reviewed-on: https://gerrit.libreoffice.org/79654 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/79571 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-03-02tdf#36737 - Initialize default values of optionalsAndreas Heinisch
Initialize default values of optionals in function headers. In LO Basic, optional parameters are allowed, but without any default values. Missing parameters will not be initialized to their respective default values of its datatype, either. With option Compatible, optional parameters are allowed with default values. Missing optional parameters that don't have explicit default values will not be initialized to their default values of its datatype. With option VBASupport, optional parameters are allowed with default values. Missing optional parameters that don't have explicit default values will be initialized to their default values of its datatype. Change-Id: I57aabae5f70d1cf6c4e8feb95ce0db6af753383c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87550 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-02dtoa needed by salCaolán McNamara
Change-Id: I79067b047384425c65a2653b20e637d8461cf7f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89780 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-02sw: prefix members of SwRedlineSaveData, SwUndoAttrTable, SwUndoCpyTable ...Miklos Vajna
... and SwUndoFormatColl See tdf#94879 for motivation. Change-Id: I004a80401c48d9706537cce318d0dc44fb4204be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89807 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-02Revert "Stop Navigator content view flashing"Stephan Bergmann
This reverts commit 201a7652092c6a7796a59e6ddee144e4f0c9ece9. Was this submitted in the wrong order? There is no m_bIsInPromoteDemote across the code base. Change-Id: I85cfbb797fccfd0c03c1ec19a792da8e10c7acde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89806 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-02Add functionality for promote/demote chapter/level shortcut keysJim Raykowski
The following arrow key shortcuts for these actions can be used when focus is on outline content in Writer Navigator: Ctrl+Up promote chapter Ctrl+Down demote chapter Ctrl+Left promote level Ctrl+Right demote level Holding the Shift key, in combination with the above, will exclude children from the action. Change-Id: I73a320d571791e2e9e1c0e4efb579c9977220494 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89491 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02Adapt compilerplugins to Clang trunk changeStephan Bergmann
<https://github.com/llvm/llvm-project/commit/ 93184a8eda272c65308906836b47cbf209de779e> "Remove unused parameter from CXXRecordDecl::forallBases [NFC]" Change-Id: I8efdda2a37fd0df3b964401e8851a0f95f8d0ab4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89781 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-02don't rely on parser ::characters callback only firing onceNoel Grandin
which is true for the old parser, but not always so for the FastParser. So pre-emptively fix some stuff Change-Id: I405834f1dfd28c98cae87b6de38d238f723edafd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89712 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02Stop Navigator content view flashingJim Raykowski
Redraw flashing occurs in the content tree when outlines are moved during promote/demote chapter/level and when switching content navigation view mode. Also, the focus rectangle is briefly shown. This patch uses the m_bIsInPromoteDemote flag, that indicates when outline levels are in the process of being moved, to not redraw the content tree until after the moved outlines are reselected. To stop focus rectangle flashing a check for tree emptiness is used in the Paint function. Change-Id: I252c5a0032157c0a8287c748071d180675b3a70d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89659 Tested-by: Jenkins Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02Add XServiceInfo tests to ScTableSheetsObjJens Carl
Change-Id: Iaaadc2554bb0ce103ef01bbf02c316d21fae51af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89761 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-03-02gtk3 a11y: fix get_text(1,-1)Samuel Thibault
Even when the end offset is -1, we have to return the text starting a the given starting position, up to the end, but not necessarily from the beginning. Change-Id: I6a79092c683c273eaedb8661545df71b742110ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89486 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-02tdf#130945 Writer: Preview of linked doc is not updated when editedSerge Krot
Change-Id: Id8ee653cc9cb5dbcb3ad0a31688a0b5e34d99fff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89499 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-02tdf#129096: Document Recovery: Use TypeDetection on loadVasily Melenchuk
Loading of recovered document happend before via XFilter::filter is not updating media descriptor of document. But this is important for password protected documents to store entered password and used encryption type. To avoid this problem let's use TypeDetection which during its work will ask user for password and store all the info in modified media descriptor before actual recovery attempt. Change-Id: Ide2ebf0955e0937cdc7c9d7165593b71f904649b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88844 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Jenkins
2020-03-02tdf#130348: Add special case for ChartDeck, tooTor Lillqvist
Change-Id: Idf6cc1469f074debfc4351a58826a3a7411391ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89722 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 6a031edca26cadd5917a94de2d3b6a706197a8fc)
2020-03-01nDepth is only written to, not readCaolán McNamara
Change-Id: Idf6f038e535f48558b04f3aea63c01c9e164ee8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89779 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-01Catch by referenceEike Rathke
error: catching polymorphic type ‘class qrcodegen::data_too_long’ by value [-Werror=catch-value=] Change-Id: I34cd429186b737f32ceec124849d48860788a9d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89778 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2020-03-01lok: Set default text for new text box on mobileMuhammet Kara
Change-Id: I0b6056e9dbf5fb81d092092cc183b05120b95d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89352 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89710 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>