summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-06-11Simplify Sequence/vector initializationsJulien Nabet
Change-Id: Ib02e25b4600666185cf0f8d0cc8d5c64186789c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117064 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-11EMF tdf#59814 tdf#142567 Align RestoreDC record with MSO implementationBartosz Kosiorek
Some of WMF and EMF behaviours are undocumented. In that case, we are implementing the behaviour, observed in MS Office or MS Paint. With this commit the behaviour of import EMF RestoreDC records, will be the same as for MS Paint and MS Office. Change-Id: I73b65d14018f2667ffd59daf16ecc6d7ce9c1870 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117052 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2021-06-11sw define bibliography entry dialog: unconditionally allow the browse buttonMiklos Vajna
This eliminates the "Local file" type, arguing that regardless of the type of the bibliography entry, it may make sense to associate a local URL with that. Additionally, this allows using the file picker with non-HTTP URLs, like webdav. Change-Id: I315facdcf292f439765c420e5368a99267fe1a98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117059 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-06-11ScriptForge - (scriptforge.py) add reference to SF/Python help pageJean-Pierre Ledure
Change-Id: I68ec6c53bbf9f6631f33192776b154936c1b721e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117065 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-06-11Simplify vector initializationsJulien Nabet
Change-Id: Icf8972be204799e9b3b3824ab18d8584911fe1c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117061 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-11gtk4: support separators via manipulating menu sectionsCaolán McNamara
Change-Id: Iaade04dd5a4fa89ef74a22a19ebe5e37655fc61a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-11use freshly compiled dump_syms.exe on windows for symbolinfo extractionChristian Lohmaier
while self compiled one still segfaults frequently, it is a tad better than the included one (and compiling froms source instead of using precompiled binaries is a net win in any case) Out of 50 attempts with the mergedlo.dll, the new compiled dump_syms succeeded 11 times, the shipped one succeeded 7 times - so could still be regular variance in that small sample size, but at least not significantly worse either. Change-Id: I86c213fe6aece58f1391d4c2bf9906b85eee9c57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117056 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-06-11tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
Another place where SfxItemState was used as placeholder Change-Id: I54e549db50b7485024a305eb39fda848cbed6b78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117036 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2021-06-11tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
The mechanism around NUMRULE_STATE does only do something when the SfxItemState is actually SfxItemState::SET, so this can be reduced to use a valid Item shared_ptr when this is the case Change-Id: I973648abff3696057f2ca21608ed64570742dddb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117043 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2021-06-11tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
Another place where SfxItemState::UNKNOWN was used as placeholder Change-Id: Ie2757e8356bfea7010b0442d72ef7865cbb18d5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117034 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2021-06-11qt5/kf5: Fix crash on exitMichael Weghorn
This extends the solution from commit fa8db25af6218262b3dab2e93b76464975889ceb Date: Thu Jun 3 20:47:10 2021 +0100 gtk4 crash on exit to cover the qt5/kf5 cases as well, after seeing equivalent crashes with kf5 VCL plugin (e.g. when starting Writer and no profile exists) after commit 556243467a0ac3f647de75bf3fb6c9f3b72466a4 Date: Wed Jun 2 13:06:54 2021 +0200 fix shutdown leak in CppunitTest_sw_filters_test Change-Id: I4ef25bac0891c059588dbc8e6abe50db14230dea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117042 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-06-11Simplify Sequences initializations (writerfilter/writerperfect/x*)Julien Nabet
Change-Id: I1bd31fe6cf0f8aaf4f2cfe1d3d49e61a0633f361 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117057 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-11Simplify Sequences initializations (vbahelper)Julien Nabet
Change-Id: I9bbcf97acd59e7430758e05ae949f7e494afc704 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117051 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-11Simplify Sequences initializations (vcl)Julien Nabet
Change-Id: Id93bde17dbc4c71ad93bc094b94408fc9e39ec98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117055 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-11loplugin:unusedmethods improve filteringNoel Grandin
Change-Id: I75771dbcecd58259bffdd2ddb0df631205aa8d93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117032 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-11Simplify Sequences initializations (unotools)Julien Nabet
Change-Id: Ibc5deee4b69213310a75c2a74a800d99bc451424 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117047 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-11Simplify Sequences initializations (ucb)Julien Nabet
Change-Id: Idd38076a40b1177253719c01c1928da4c903151c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117017 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-11Simplify even more initializations in svl/passwordcontainer.cxxJulien Nabet
Change-Id: I42cb919a8853df050d71b97f86abd20fdfccb5a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116978 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-11Simplify Sequences initializations (sw)Julien Nabet
Change-Id: I02647bdb720620afe20284a069a71c19dbfcea05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116944 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-11Simplify Sequences initializations (sc)Julien Nabet
Change-Id: I0c581b3a900a6b89c0f4e203310d65600545987f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116929 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-11sw_uiwriter3: Unify code and use createSwDoc everywhereXisco Fauli
Change-Id: I8054b4a9661e1873fa30390b7f7c85bd654343ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117049 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-11gtk4: process sections and submenus of toplevel menumodelCaolán McNamara
and place initial contents into a section by default Change-Id: I1e7bb20bf5efb481e4f7ed0f38c8b46c06f7a7d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117050 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-11cid#1473844 Untrusted loop boundCaolán McNamara
and cid#1474351 Untrusted loop bound cid#1474118 Untrusted loop bound this time without second guessing the original intent Change-Id: Iaa6b636a08ed29feaf709fbcbac7deac761a0fc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117045 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-11Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to ab81b6bfa02cd89c244bc55148486324863844f8 - sf_form(control) Python support Change-Id: Iad14d1c5c7d353e50aba84d0cfa461e56f69f4ef Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115969 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-06-11Resolves: tdf#142758 Revert record parse misunderstandingCaolán McNamara
of 'Related: cid#1474351 Untrusted loop bound' and add in documentation for the records This reverts commit 2134d83b8d6e73ca8eacd812eb3431bff38c74f6. This reverts commit 7c2e6058439da9d061e5e0bbd07c8b6d4f2ffcbf. This reverts commit 3748fe3e4fc22a400b3120010192b75754e38b17. Change-Id: I5b407eb4388a8d67fc863cc6070fbbf8b15321d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117044 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-11loplugin:unnecessaryreturn in SvxColorValueSet::layoutToGivenHeightNoel Grandin
Change-Id: Ia42158597588fe802a2f06a6e8e59f372c62c022 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117031 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-11uiwriter: use createSwDoc instead of loadFromDesktop for empty docsXisco Fauli
Change-Id: Iacfda21398bfd920c5e0be62893ba723ee99d738 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117041 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-11no need to make a copy hereNoel Grandin
Change-Id: I47d51d3d372403f30ab38697037cdb205839df44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117030 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-11sw image anchor type: consider a style-based custom valueMiklos Vajna
The anchor type is determined during insertion, it's stored as direct formatting after that. We used to have a user-profile default for the anchor type. This commit allows customizing the Graphics or OLE styles: if they specify a custom anchor type, then that is user instead of the user profile setting. This allows creating templates where the default depends on the used template and not on the user profile. The UI for this was added in commit 5951da5175b9d7e5b3b47bd0d90989d2ef528c79 (sw image anchor type: add style UI for this, 2021-06-10). Change-Id: Id05342a5f38dc6267cdbe68b248dc50b87854ce2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117040 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-06-11ofz#35150 crash in Bitmap::Crop from wmf loadCaolán McNamara
which is a problem since... commit 33d2cf7008de79106b5da4bba0241aa14d81d88f Date: Sat Jun 5 19:30:46 2021 +0200 WMF Change the sign of read fields in BITBLT and DIB records Change-Id: Iea1261a52866d691435f0612f672636009c00355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117039 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-11ofz#35149 crash in vcl::bitmap::CreateFromData from wmf loadCaolán McNamara
which has started since... commit 01ded1e6d362dbcd7148334c6965d6ad00981d4a Date: Tue Jun 8 23:07:28 2021 +0200 WMF tdf#55058 tdf#142722 Add implementation of BitBlt and StretchBlt Change-Id: I5bbde55dbd9e239c05544ac4a21e2758770245d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117038 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-11WMF/EMF tdf#59814 tdf#142567 Fix RestoreDC recordBartosz Kosiorek
With previous implementation, the RestoreDC index argument was skipped, and always the last entry was taken. With this commit the support for reading SaveDC by specific index was added. The SaveDC/RestoreDC index support was added for both EMF and WMF, according to [MS-WMF] and [MS-EMF] documentation. Change-Id: I9b8a1a41462ae01de25ac3c85e453bcd80e05537 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117033 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2021-06-11Related: tdf#139447 DBTreeViewBase ctor takes a bool if its a sqltype or notCaolán McNamara
Change-Id: I7924dfb3dc15e34fae93b435e1a9e76f3da29463 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117037 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-11loplugin:unnecessaryreturn in sw/Noel Grandin
Change-Id: Iaca3f5385fd2c763cd1121ae50624aaa4a1f6165 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117029 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-11loplugin:unnecessaryreturn SwWrtShell::Toggle*Noel Grandin
Change-Id: I221dca35df23205023cf675b83c94c83178217d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117028 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-11math.desktop include "Spreadsheet" categoryCaolán McNamara
but it's not a spreadsheet since... commit dad7fe7227fb80a32d3c2c777584dc9d74b9e929 Date: Thu Jan 2 16:16:55 2014 +0100 Fix math categories to make SUSE rpm check happy Change-Id: I0397ea12cd7f29f4b0c1f0e0ad76a3429b55c455 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116884 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-06-11"drawinglayer" -> "drawinglayer.emf" log area for some emf codeLuboš Luňák
Change-Id: I83fa2d40225f83b82cea7f8934f4afdee181abe3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117000 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-06-11tdf#139447 crash on dragging query/table from explorer to calc sheetCaolán McNamara
Change-Id: Ic827cb967a9a9cb78f28a23707813aeec8381cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-11CppunitTest_vcl_svm_test: add missing basegfx linkMiklos Vajna
Missing probably because https://gerrit.libreoffice.org/c/core/+/116967/1 was merged before its https://gerrit.libreoffice.org/c/core/+/116959/4 parent. Change-Id: I0c6304c98f27e1f24ee615e4580c8ad7458bf79b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117027 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-06-11tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
ParaLineSpacingControl::Initialize() is another place where SfxItemState::UNKNOWN was just used as a placeholder for a non-set SfxItemState (aka could not be queried) Change-Id: I95ad01579e5aa4c86ace619e2201481742297c2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117016 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-11tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
FontworkBar::getState does not need to check for SfxItemState::UNKNOWN at all, actions solely depend on FontWork object being selected. This also greatly simplifies that method. Also, the optimization by passing in a variable to checkForSelectedFontWork and remember if already computed can be removed - also in other places where it had to be given, but was not re-used at all Change-Id: I35b1f36195feb1d645619665d2dd65a84b75b118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117014 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-11tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
In this case SfxItemState::UNKNOWN was used as boolean state to decide to keep extracted value or replace. First method even throws an exception when SfxItemState::UNKNOWN should happen. I tried to be very careful in changing these methods, so another look/check from reviewers will be welcome. I think that code was unnecessarily complicated, too, butz hope to not have touched semantics (behaviour) at all Change-Id: Id213fedcafcfb655749caf2659f9a15b240ec27d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116999 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-11Remove duplicate codeStephan Bergmann
The two > aSet.Put( aAnch ); had been like that ever since at least 84a3db80b4fd66c6854b3135b5f69b61fd828e62 "initial import", but only now aa9cb8e14749e7fb7a83b55a2bb095501f731a18 "-Werror,-Wunused-but-set-variable (Clang 13 trunk)" removed the lines of code between them (and which should not have changed neither aSet nor aAnch as a side effect, which could have explained the putative duplication), making the duplication stick out. Lets assume this was an error ever since, and that just one call is enough. Change-Id: Ie1ad54fb31212849f242eea77bc9e436b6fd92f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116980 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-11sw: handle InvertBorderSpacing when replacing compat optionsMiklos Vajna
This was added in commit de0866b507e259f1726d1015293aad8fcadd763a (sw-invert-border-spacing.diff:, 2010-09-14), it's off by default and is on for Word documents. Change-Id: Idf1999dbe9e641259e09eaafbebd347199cd5db4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117015 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-11Add IntersectClipRegion cppunit tests to vclpanoskorovesis
Two tests where added, IntersectRectClipRegion and IntersectRegionClipRegion, along with their .svm files. The tests create mutliple IntersectClipRegions and test their attributes. Change-Id: I33b7b13b4f3eef1de07cc063ef22fea034d65cfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116967 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-11Resolves tdf#142651 Writer: Next Change stopped workingJim Raykowski
by normalizing copy of PaM instead of reference Change-Id: If2c8664de18eb9473151c5961ad7654932ca37e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116875 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-06-10sw_uiwriter: remove duplicated createDoc methodXisco Fauli
Change-Id: Ie29cd4aa6907018d1bfe492c22ac1d431d0331ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117020 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-10sw_layoutwriter: remove duplicated createDoc methodXisco Fauli
Change-Id: I25f995f06ce56ecec3411007bfd4f381cc7af207 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117021 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-10loplugin:unnecessaryreturn SotStorageStream::CommitNoel Grandin
Change-Id: Icfd32ea8b29aa544b71d0c4fc6bc67c06f81e327 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116987 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-10schema: update to ODF 1.3 OSMichael Stahl
Change-Id: I97e28612aeeebed709da9ad621250c6b26e55f92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116734 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
generated by cgit (git 2.34.1) at 2024-07-11 05:37:51 +0000