summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-03-13accessibility: simplify getSelection when possibleArnaud Versini
Change-Id: I187716bca329da0aeae9fec9f48a45a9df386130 Reviewed-on: https://gerrit.libreoffice.org/50688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-13related: tdf#116264 give windows message dialogs less border widthCaolán McNamara
Change-Id: Ieced9b02515ffc7479bfc66ca501e20962d5572e Reviewed-on: https://gerrit.libreoffice.org/51172 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-13Updated coreGabor Kelemen
Project: help 05d4e9fb471224b6adbc174ecb7968ffa29d4a56 Add missing ahelps / fix bookmarks to Insert Field pages Some were missing, some were misplaced. Change-Id: I0d72bb44c8630b4c9920e3d38cf0b306d3f15802 Reviewed-on: https://gerrit.libreoffice.org/51170 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2018-03-13lokdialog: For floating menus, ignore the screen size in the LOK case.Jan Holesovsky
Change-Id: I85f6fcbc865eba7aac48a4c2e7d8c4bb82311581 Reviewed-on: https://gerrit.libreoffice.org/51063 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/51165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-03-13Revert "lok: Don't freeze the LibreOfficeKit via the spell-checking popup..."Jan Holesovsky
This reverts commit 551e639f467813e52ff4301822b6a7f8778a2ef4. Change-Id: I0c7c85fe22d53aa5587ec119e1c3242682b88e43 Reviewed-on: https://gerrit.libreoffice.org/51164 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-03-13Modernize a bit extensionsJulien Nabet
mainly by using for-range loops Change-Id: I297275748ffdce0576e51f63294d7e5b21729af7 Reviewed-on: https://gerrit.libreoffice.org/51182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-13sw XHTML export: avoid <u> for underline in ReqIF modeMiklos Vajna
The spec insists on the CSS equivalent (while <b> and <i> is OK). Change-Id: Ied3ebc896403ab85f544b0071e841e35eafdeb64 Reviewed-on: https://gerrit.libreoffice.org/51158 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-13sw XHTML export: always write images as PNG in ReqIF modeMiklos Vajna
JPG image would have to be JPG + PNG fallback, at which point it's easier to just write PNG. Change-Id: I6e4f0759244d29735fdcda8e050d198f118c737d Reviewed-on: https://gerrit.libreoffice.org/51151 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-13tdf#116117 sfx2 store: don't inherit temp file permissions when renamingMiklos Vajna
This has to be handled explicitly, otherwise the tempfile permissions (which intentionally don't respect umask()) would be preserved on rename(). Change-Id: I0a2681dbf06986e73f6e12d294e35e87b93b4f8a Reviewed-on: https://gerrit.libreoffice.org/51169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-13remove unused defineTomaž Vajngerl
Change-Id: Ie674196c19e7c61dcec370b8958d79ca8b3aebc4 Reviewed-on: https://gerrit.libreoffice.org/51187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-13change minimizer extension to not use GraphicUrl and FillBitmapUrlTomaž Vajngerl
Change-Id: I3a0c22d0e9411e5a427efce6adee0679e2c2de68 Reviewed-on: https://gerrit.libreoffice.org/51109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-13winaccessibility: GraphicURL is not set anymoreTomaž Vajngerl
Change-Id: I87dd8abcf52dac0c92936fe71b905ed6dd1beefd Reviewed-on: https://gerrit.libreoffice.org/51108 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-13sd: remove useage of GraphicURL in PhotoAlbumDialogTomaž Vajngerl
Change-Id: I1ed5d2ad75d4424e93fa6d9761d99ab6e1bee06a Reviewed-on: https://gerrit.libreoffice.org/51107 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-13tdf#114552 Convert anchor toggle to anchor menuSamuel Mehrbrodt
Since we now have three, not two anchor types. Change-Id: I9654de574a9d546d2191093cba9c192fac3cd3d7 Reviewed-on: https://gerrit.libreoffice.org/50987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-13Sorry, could not resist: Drive-by cosmetic changesTor Lillqvist
Remove noise comments, ASCII graphics, and superfluous whitespace. Change-Id: Icca0995082ce8afad1e770a263fdef00bfc33449 Reviewed-on: https://gerrit.libreoffice.org/51168 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-03-13tdf#114260: Allow moving top-level menusMuhammet Kara
in the Customize dialog. Change-Id: I0dafe59e017e05977d00cf564cfef21190a0a7a1 Reviewed-on: https://gerrit.libreoffice.org/51163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-13lokdocview: new property 'is-initialized'; fix gtktiledviewer for calcPranav Kant
there's no lokdocview property to tell if the doc has been completely initialized (initializeForRendering() has been called, etc.). This new property takes care of that which we now use to ignore configure event fired before document is initialized for rendering. Configure event handler queries document for row/col header which asserts because some values hasn't been initialized yet. Change-Id: I58385b2cb56bf317fe20ecf0570b7095f7260174 Reviewed-on: https://gerrit.libreoffice.org/51156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-13vcl: prefix BitmapEx member variables with an 'm'Chris Sherlock
Change-Id: I39c52cd670e6148fca1f65c35a5ff411bfda7137 Reviewed-on: https://gerrit.libreoffice.org/51143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-13vcl: rename BitmapFilter::filter() to execute(), rename existing classesChris Sherlock
Change-Id: I0c7b840de6bb4c7570bd6a55ccf3b427f98cc524 Reviewed-on: https://gerrit.libreoffice.org/51142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-13sd: bullet graphic uses "Graphic" prop. instead "GraphicURL"Tomaž Vajngerl
Change-Id: Iab5b10ae1887c1ea7149bb4ba09ba9e913985398 Reviewed-on: https://gerrit.libreoffice.org/51106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-13Colibre icons: add transition icons for impressandreas kainz
Change-Id: I532278bba585f60d5657492ec3fc055fb442cc09 Reviewed-on: https://gerrit.libreoffice.org/51183 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-13Change ODK example to use Graphic property instead of GraphicURLTomaž Vajngerl
Change-Id: I0a8b518a62c35da52008668c6e8cc7d0fd74e1d4 Reviewed-on: https://gerrit.libreoffice.org/51105 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-13tdf#116277 blank frame into which document will load shown too earlyCaolán McNamara
normally we want this to be the window that is the parent for any warning or password dialog. But for these (weird, see also impl_findSlotParam) frames dispatched with slotid arguments, they are opened before the dialog which will fill them is launched. Presumably in sane land the dialog would be dispatched from the menu entry, then on its create the frame opened with the desired contents. Change-Id: I1234b648ca1bd7fd2109cb4d3c70d5bfed9ab563 Reviewed-on: https://gerrit.libreoffice.org/51150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-13tdf#114622 Add Numbering in Arabic-Indic numeralsSuhail Alkowaileet
Fix all comments Change-Id: Ib11662de5cac3b073114ab4425e8f45a0c04c8c8 Reviewed-on: https://gerrit.libreoffice.org/47058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-13Colibre icons: add wizards iconsandreas kainz
Change-Id: Icbf9158c13743cfd8c6f617e15d1854cb4f63c8a Reviewed-on: https://gerrit.libreoffice.org/51181 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-13Colibre Icons: add app icons in different sizes folder resandreas kainz
Change-Id: I7ebc9a21fbf33c0a37868b7a4e5318a8d9e13392 Reviewed-on: https://gerrit.libreoffice.org/51180 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-13tdf#114552 Improve image scaling in CalcSamuel Mehrbrodt
When anchor type "To cell (resize with cell)" is selected, we do now:: 1. Consider aspect ratio when scaling graphic objects with cell This only works when the image fits into one cell. When the image is over multiple cells, we need to respect the end anchor, so we need to keep the existing behavior (no aspect ratio considered). 2. Always scale images if anchor type is "resize with cell" Previously it would only scale if the image is larger than the cell. Now we always enlarge the image if the cell is enlarged, and shrink the image if the cell is shrinked _and_ the image no longer fits into the shrinked cell Change-Id: Ib2a24819d0058bcebce73ea97bbf70a963d74584 Reviewed-on: https://gerrit.libreoffice.org/50451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-12tdf#115853: save current custom property when adding lineJulien Nabet
by reloading current lines before adding a brand new one indeed the info are deleted by ClearCustomProperties each time SfxDocumentInfoItem destructor is called Change-Id: Id1e2e652e90c720f00b8612aa9afbfa91b784d1d Reviewed-on: https://gerrit.libreoffice.org/50070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-12tdf#116322: Don’t hard-code RTL character rangesKhaled Hosny
Calc’s ScOutputData::LayoutStrings() has an optimization that skips edit engine for what it seems to consider simple enough text (single script, no bidi controls, etc) and it ends up calling this code in OutputDevice that hard-codes RTL character ranges and skips bidi algorithm if none is found. Since the list of RTL characters is not fixed and new version of Unicode can added new RTL characters, help the next boor soul that will spend another day debugging this in the future by removing the hard-coded RTL ranges and instead check for some known LTR ranges. Change-Id: I6eb8fd3d1342a5539d607bf54e9c2de31f5a32b4 Reviewed-on: https://gerrit.libreoffice.org/51118 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-03-12Colibre Icons: finalize chart2 icon folderandreas kainz
Change-Id: Ibbe4c6e63213dc9fa767ca04d1376f8742adb34a Reviewed-on: https://gerrit.libreoffice.org/51174 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-12forcepoint #27 check region bands loaded from stream for consistencyCaolán McNamara
Change-Id: I92376b5fb4208c78fa25a94d4dd394256793161c Reviewed-on: https://gerrit.libreoffice.org/51144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12tdf#107094 backward heading search doesn't always workCaolán McNamara
regression from... commit 84e44386d70e886f9bae633ebe915ea3a52f8dbd Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Nov 12 10:35:18 2014 +0000 coverity#982189 Unchecked return value so put it back the way it was and explicitly ignore the return instead Change-Id: I6f5ef42b38236ea5f70ddbccfa25a81f2f3e976c Change-Id: I0c0084247e8570ace2198fa893db273dab00d2b0 Reviewed-on: https://gerrit.libreoffice.org/51146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12forcepoint #21 pop on empty stackCaolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: I25b1c6361fb0a3ae6b01f2be870c9e1b49bf5b84 Reviewed-on: https://gerrit.libreoffice.org/51114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12forcepoint #24 back() on empty vectorCaolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: Idb6723b53a1ae8aaca80847bfe643bc4abaedd21 Reviewed-on: https://gerrit.libreoffice.org/51121 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12solenv: the installer's -b parameter is unusedMichael Stahl
"build" is hard-coded to "majorminor0". Change-Id: I15271544917f70b8ae029bd7542aecfe0a46befe
2018-03-12solenv: installer's -m parameter & globals::minor & PRODUCTMINOR unusedMichael Stahl
Change-Id: I2f550ca5b02551b84d3631e0101918af49924fe2
2018-03-12solenv: LAST_MINOR is effectively deadMichael Stahl
Change-Id: I07d90c68934712295952e6e6725e0206c16a5b7e
2018-03-12Revert "g: ignore submodule changes"Stephan Bergmann
This reverts commit 27925032cd5aec8805185679e01c687c40bbd617. Conflicts: g According to vmiklos, that commit was meant to help with the following scenario: Assume a dev uses submodules and uses plain `git pull && git submodule update` instead of ./g. When they forget the "&& git submodule update" part and do `git commit -a`, changes to the submodules were excluded from the commit. However, when they do `git add -u && git commit` instead of `git commit -a`, changes to the submodules /are/ included in the commit, despite `git status` or `git diff` (both prior to `git add -u`) or `git diff --cached` (after `git add -u`) not indicating that there are any changes to the submodules. I consider that problem more confusing and severe than the problem that the commit solved. Change-Id: I595eed3c1c04efd108be1ccd792d8d7bce72a345 Reviewed-on: https://gerrit.libreoffice.org/51155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-12forcepoint #26 check input against max valid enum valuesCaolán McNamara
Change-Id: Ide72884c77904ae9495b5189cde086e43923e4bd Reviewed-on: https://gerrit.libreoffice.org/51136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12forcepoint #25 ensure null terminationCaolán McNamara
Change-Id: I37f4787fb5772e959c45280d9650adcc15591033 Reviewed-on: https://gerrit.libreoffice.org/51128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12tdf#115649: ensure we own SolarMutex in the callbackMike Kaganski
The crash is caused by releasing SolarMutex we don't own; the release happens in Application::Reschedule() inside SalPrintAbortProc. The crashing callstack: ucrtbase.dll!abort() mergedlo.dll!comphelper::GenericSolarMutex::doRelease(bool bUnlockAll) Line 72 mergedlo.dll!SalYieldMutex::doRelease(bool bUnlockAll) Line 177 [Inline Frame] mergedlo.dll!SolarMutexReleaser::{ctor}() Line 1473 mergedlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 550 mergedlo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 469 mergedlo.dll!SalPrintAbortProc(HDC__ * hPrnDC, int __formal) Line 1308 gdi32full.dll!vSAPCallback() gdi32full.dll!ExtEscapeImpl() gdi32.dll!ExtEscape() [Frames may be missing, no binary loaded for KMUU727V.DLL] KMUU727V.DLL!0000000011d0dc21() Change-Id: I955eab7894186900d0d99e28f62d87cc645e4a5a Reviewed-on: https://gerrit.libreoffice.org/51052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-03-12missing error description for ERRCODE_SFX_FORMAT_ROWCOLCaolán McNamara
Change-Id: Ia616486011f92ccfdd743e46f1b583b99b087eb5 Reviewed-on: https://gerrit.libreoffice.org/51113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12forcepoint #23 Null dereferenceCaolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: I2e68a6c3fe1846fbfaaa0305c02da135a930d863 Reviewed-on: https://gerrit.libreoffice.org/51120 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12forcepoint #22 pop on empty stackCaolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: I964c79af0087075df0142cd251fd304a68bc497b Reviewed-on: https://gerrit.libreoffice.org/51119 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12Colibre Icons: fix formula png iconsandreas kainz
Change-Id: Ic37e0d4926d72c25f3654fc674b021e7cd1b7c4a Reviewed-on: https://gerrit.libreoffice.org/51141 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-12Colibre Icons: fix formula res iconsandreas kainz
Change-Id: I41869da44cada6f4bb96d76942d923150464ff57 Reviewed-on: https://gerrit.libreoffice.org/51140 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-12Fix typoAndrea Gelmini
Change-Id: If7667b9cda78b481de0048a459cef3de4642385a Reviewed-on: https://gerrit.libreoffice.org/51084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-03-12Colibre Icons: add sc_ iconsandreas kainz
Change-Id: I9c8381e886a095f0e109b3932f6d94b87d9862de Reviewed-on: https://gerrit.libreoffice.org/51139 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-12dbahsql: use empty Any for "Other" columnTamas Bunth
Change-Id: Ie3e918956a25fba2831d3542e5f3d1b26c4fdc2a Reviewed-on: https://gerrit.libreoffice.org/51117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-03-12-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I9272b14c7760f2880983e198ff98b54cf37e1d30