summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-04-13Removed duplicated includesAndrea Gelmini
No automatic tools. Manual checked and tested. Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754 Reviewed-on: https://gerrit.libreoffice.org/36371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-13tdf#92650: add a unit test for this.Kohei Yoshida
Also add a modern C++11 version of checkOutput(), which should be used instead of the older variant that is a template function. Change-Id: I64706baf531c557c3631c998122515e40d555cf6 Reviewed-on: https://gerrit.libreoffice.org/36497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-04-13tdf#92650: handle overwritten references correctly in undo.Kohei Yoshida
Change-Id: Idc3fbd78f8163c97a9cd80a3ff474b6da0349353 Reviewed-on: https://gerrit.libreoffice.org/36496 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-04-13finally switch the workaround offEike Rathke
Change-Id: I284292a2749c2b38ef874315d5b526e403d578e8
2017-04-13turn assert into SAL_INFOEike Rathke
The old assert conditions don't hold anymore since removeFromDrawPageAndFree() only deletes the SdrCaptionObj on the last refcount, but info can be useful. Change-Id: I456149b8799a0509dcd7a2da09d627fb0de1a912
2017-04-13control deletion of SdrCaptionObj within ScCaptionPtr by refcountEike Rathke
I guess this is about the first time ever that repeated Undo and Redo of Cut&Paste of a cell comment does not crash.. Change-Id: I493a0a5439efde133a07d73ddcbcdf5bda4bc276
2017-04-13bail out early if there is no caption to removeEike Rathke
Change-Id: Id08d82751560092fd6225131970f607dbb2e4801
2017-04-13in RemoveCaption() forget() instead of reset(nullptr)Eike Rathke
Change-Id: Id97d4d97c1d46ac6de6198515756a0786a54626e
2017-04-12Updated coreJohnny_M
Project: help 958daee8ba1a708cfb5eaa3811078500e653f88e Fix measurement unit conversion reference 1. Following pages were incorrectly referring to https://help.libreoffice.org/Common/Frequently-Used_Buttons#metrik instead of https://help.libreoffice.org/Common/Conversion_of_measurement_units#metrik : - https://help.libreoffice.org/Common/Page (in "Related Topics" at the bottom) - https://help.libreoffice.org/Math/Font_Sizes (in "Base size") Note: Following pages already use the correct reference: - https://help.libreoffice.org/Calc/Optimal_Row_Heights (at the top; http://opengrok.libreoffice.org/xref/help/source/text/scalc/01/05030200.xhp#41 ) - https://help.libreoffice.org/Calc/Optimal_Column_Width (at the top; http://opengrok.libreoffice.org/xref/help/source/text/scalc/01/05040200.xhp#42 ) - And other - see http://opengrok.libreoffice.org/search?q=%23metrik&project=help&defs=&refs=&path=&hist= 2. While at it, also added the same reference to the place which was incorrectly meant as reference before: - https://help.libreoffice.org/Common/Frequently-Used_Buttons#Metrics Change-Id: I827ff047bfb2426ff1192e90a5361ab05198a7f8 Reviewed-on: https://gerrit.libreoffice.org/35997 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-04-12can use gb_CppunitTest_use_configuration and still access .ui filesCaolán McNamara
after... commit 506cab1a01b0481d0831a7a692a26dc5a5b55e91 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Apr 12 16:14:10 2017 +0100 take the .ui files from $BRAND_BASE_DIR/$BRAND_SHARE_SUBDIR Change-Id: I9cffdc092206c038da32a32a2cfe629e68b5c258 Change-Id: I906d16037cdf0b9203a4120cb1a5e9846a5c7b7f Reviewed-on: https://gerrit.libreoffice.org/36482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12Notebookbar: remove dependency between all containers and IPrioritableSzymon Kłos
Change-Id: I92bff0d68470763c88172744e82d9b5915ffb6f1 Reviewed-on: https://gerrit.libreoffice.org/36387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-04-12ofz: avoid oomCaolán McNamara
Change-Id: I64dd130f618ea18b802117b7a2cf0eeb8f271046
2017-04-12drop obsolete check for boost/function.hppDavid Tardon
Change-Id: I95b968b7ba13481d246fde7471b02f821372e1fd
2017-04-12NumberingManager.cxx: remove unusedVitaliy Anderson
Change-Id: I43266bba61ae95386383b7080c9c5983804afe4a Reviewed-on: https://gerrit.libreoffice.org/36478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12[API-CHANGE] drop css.comp.logging.SimpleLogRingCaolán McNamara
Change-Id: I2f61a8ec24a28a917b458673df6ed45ac1f93e72 Reviewed-on: https://gerrit.libreoffice.org/36447 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-12Updated coreGabor Kelemen
Project: help dafaa1c1e89f912513e87c613db7ff23961d3030 Update Customize - Toolbars page help Sync with UI and reorder paragraphs to better follow its structure. Add bookmarks as needed. Change-Id: I19f0d1ada570ecff6d5fc8ee37051a7c37125b3b Reviewed-on: https://gerrit.libreoffice.org/36398 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-04-12EnableHeadlessMode bool arg doesn't toggle headlessCaolán McNamara
but refers if a dialog is fatal or autocancelled Change-Id: I7f15ecb26a3e29065caaacb932c7416f4cd96ff6 Reviewed-on: https://gerrit.libreoffice.org/36487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-12Lets see if basing WINDOWS_SDK_BINDIR_NO_ARCH on WINDOWS_SDK_HOME works betterStephan Bergmann
...than basing it on naked winsdktest, even though both should be effectively equivalent modulo Windows pathname normalization voodoo. But at least the Win-x86@62-TDF bot complained after a4d1ed6ba2a81b4284cd360f44b6723bc9bfaf85 "Adapt to Windows SDK 10.0.15063" with > configure: setting up the build environment variables... > cygpath: cannot create short name of C:\Program Files (x86)\Microsoft SDKs\Windows\v7.1A\Bin\x86 > configure: error: path conversion failed for "C:\Program Files (x86)\Microsoft SDKs\Windows\v7.1A\/Bin/x86". presumably because that path does not exist, so pathmunge() -> PathFormat() -> cygpath can't generate a short 8.1 DOS form for it (and maybe with the already voodoo'ed WINDOWS_SDK_HOME that happened to work nevertheless, because voodoo?). Unfortunately, this requires to move the whole "Check for the Windows SDK" block further up---but the block itself left unchanged except for splitting the part out that uses WINDOWS_SDK_BINDIR_NO_ARCH. Change-Id: I13a369ba34b63392ec42333dbc1e538b49a24ca1 Reviewed-on: https://gerrit.libreoffice.org/36481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-12tdf#39468 Translate German comments in swJens Carl
Translate German comments and terms in sw/ Change-Id: Idc788ab3a62d29489893e086a51329ace59a6465 Reviewed-on: https://gerrit.libreoffice.org/36401 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-12update test to pass now that .ui files are foundCaolán McNamara
with 506cab1a01b0481d0831a7a692a26dc5a5b55e91 "take the .ui files from $BRAND_BASE_DIR/$BRAND_SHARE_SUBDIR" in place .ui files are found and the count here changes, reverting the above makes it pass, but also reverting 08cf2fd01064306eef7fdbb5b62320947c4d1089 (framework: last dispatchInterceptor gets asked first, 2016-05-20) that this test wants to test also passes Change-Id: I01f5b77065e9562619412824bf69494b7b672b68
2017-04-12tdf#92007 python scripts with tuple-assignments fails on access from GUIWerner Tietz
Change-Id: Ice1d7d92cec56751cb26cbb31a5995ab30895125 Reviewed-on: https://gerrit.libreoffice.org/36399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12enum spelling: throught -> throughJustin Luth
git grep -l "[ _\.]THROUGHT" | xargs sed -i 's/THROUGHT/THROUGH/g' git grep -l -i "[ _\.]THROUGHT" | xargs sed -i 's/throught/through/g' In ENUMs: THROUGHT = THROUGH (preserved as valid alternate spelling) In ooxmlexport8 - unit test confirms THROUGH = THROUGHT Change-Id: Iae0fef9a8adcb96761989f38903a24ffb1b91e77 Reviewed-on: https://gerrit.libreoffice.org/35998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-12take the .ui files from $BRAND_BASE_DIR/$BRAND_SHARE_SUBDIRCaolán McNamara
Change-Id: I9cffdc092206c038da32a32a2cfe629e68b5c258
2017-04-12ooxmlexport4 triggers .ui loading tooCaolán McNamara
Change-Id: I9ed7b3a90f87d9235f80b7d5201ea35ac1ec01e1
2017-04-12Remove more remains of bundled extensionsGabor Kelemen
Change-Id: I22686d1e3b89c017a6e48a4b42cabc5e092b11cc Reviewed-on: https://gerrit.libreoffice.org/36396 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12tell cppunit test about .ui requirementCaolán McNamara
Change-Id: I2346732db5c4b120025594b89c003f544588048e
2017-04-12tdf#96505 Get rid of cargo cult long integer literalsdilekuzulmez
Change-Id: I67984bfbeffd2d69103b7665d953fa3b1ff03397 Reviewed-on: https://gerrit.libreoffice.org/36316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12sw: fix typos in URLsMichael Stahl
Change-Id: I51adbc08515352242b3e5b5f9eee071aee5a3951
2017-04-12hwpfilter: remove write-only variableMichael Stahl
Change-Id: I03e29b1a3761fcafc70168b04d788dbf3e1584eb
2017-04-12fix typo @trhowsMichael Stahl
Change-Id: Ia57df88476b3dad0ed140d4f33a2cb813274376e
2017-04-12tdf#39468 Translate German comments in swJens Carl
Translate German comments and terms in sw/source/filter/html/parcss1.cxx Change-Id: Ib36ba2214d621a2f5272928922c5999a718d86bb Reviewed-on: https://gerrit.libreoffice.org/36442 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-12convert header/footer menu to .uiCaolán McNamara
Change-Id: Ia1aed81bfd806fbca78acc3b23886056a23ade4d
2017-04-12convert AX_FONTDATA constants to scoped enumNoel Grandin
Change-Id: I0de365c8f654973f483d09fc9170f40bda7cbd9e Reviewed-on: https://gerrit.libreoffice.org/36457 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-12tdf#39468 Translate German comments in swJens Carl
Translate German comments and terms in sw Change-Id: I1c9f64d91e7e490e92eb83ee348de0e90232942e Reviewed-on: https://gerrit.libreoffice.org/36439 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-12convert annotation page break menu to .uiCaolán McNamara
Change-Id: I822029c8fe2dc8ae0a0f52091375d79c0784b7ce
2017-04-12convert SwTableSearchType to o3tl::typed_flagsNoel Grandin
Change-Id: I4fbe114d96ac34540d0774fedbe1fed210efa906 Reviewed-on: https://gerrit.libreoffice.org/36459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-12Revert "Work around clang-cl issue with MSVC's safeint.h for now"Stephan Bergmann
This reverts commit acbb7e3243afec515bf98b2b34454afc5320bf66. No longer needed with safeint.h from recent "Windows Software Development Kit - Windows 10.0.15063.137".
2017-04-12convert FOUND_ constants to o3tl::typed_flagsNoel Grandin
Change-Id: I378cc5d853edc22ac80cae4d80607d933aa2612a Reviewed-on: https://gerrit.libreoffice.org/36454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-12use std::unique_ptrCaolán McNamara
Change-Id: I74ab04b58c848961b1c4d30b68e8dd5ff5dd1f0d
2017-04-12drop unused argumentCaolán McNamara
Change-Id: Ibbf3d6cbf694b1ca693d53c9ac92076a85df125f
2017-04-12ofz: timeout, guard against going backwardsCaolán McNamara
Change-Id: Ib91ae165147582bdb44690215a1df6f01ede796b
2017-04-12fix indentCaolán McNamara
Change-Id: Iaee640be234199b34c24a5a0e1e841914f92133a
2017-04-12convert selection menu to .uiCaolán McNamara
Change-Id: Ie4cf80202c333600ce027c78aa3c379ef33f4f80 Reviewed-on: https://gerrit.libreoffice.org/36449 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-12Adapt to Windows SDK 10.0.15063Stephan Bergmann
On a machine with MSVC 2013 and 2015 (but no 2017) installed, I installed "Windows Software Development Kit - Windows 10.0.15063.137" as available through <https://developer.microsoft.com/en-US/windows/downloads/windows-10-sdk> (in the hopes that it will provide a better fix for acbb7e3243afec515bf98b2b34454afc5320bf66 "Work around clang-cl issue with MSVC's safeint.h for now"). That apparently removed various files from the C:\Program Files (x86)\Windows Kits\10\bin\ hierarchy, while it added files to a new C:\Program Files (x86)\Windows Kits\10\bin\10.0.15063.0\ hierarchy (and <https://developer.microsoft.com/en-US/windows/downloads/windows-10-sdk> mentions that in an "SDK Layout Changes: Side by Side install of tools and metadata" section). So return a new winsdkbinsubdir var from find_winsdk() to cover installations that use this new layout scheme. In b076e8f673d1714ee8b6f991eb2ca299b6fa8949 "Fix include and library paths for at least me", tml had hardcoded some 10.0.15063 -> 10.0.14393 mappings that are unhelpful at least in my scenario. I tried to keep those hacks in in a way that would still work for tml's scenario. The check for msiinfo.exe etc. had been broken since ecfabb66f421ef07f52a655117f047aa75d54a01 "add support for Windows 8 SDK", but apparently in a way so that nobody noticed. The first # needed for msi packaging pathmunge "$WINDOWS_SDK_BINDIR_NO_ARCH/x86" "before" is indeed needed, as (at least some of) those tools are only available in the arm and x86 sub-dirs, not in the arm64 and x64 ones. (I'm not sure whether the two later pathmunges adding $WINDOWS_SDK_BINDIR_NO_ARCH/{x64,x86} are still relevant, though.) Change-Id: Ia403e4bde7b1abf7e2c9d9f084a05af2d1311617 Reviewed-on: https://gerrit.libreoffice.org/36455 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-12CppunitTest_libreofficekit_tiledrendering: disable occasionally failing testMiklos Vajna
When it failed, it always failed like this: libreofficekit/qa/unit/tiledrendering.cxx:311:TiledRenderingTest::runAllTests equality assertion failed - Expected: 3 - Actual : It's not clear yet what triggers the failure, sounds like some kind of timing. Change-Id: Ib5f44523f9a29c892aeda9eb881f452b57adb8a8 Reviewed-on: https://gerrit.libreoffice.org/36445 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-12external: upgrade to pdfium-3050 and stop using bundled zlibMiklos Vajna
Change-Id: I2e572585ea1cebc65aa364d8ce059cf0a3e1b83f Reviewed-on: https://gerrit.libreoffice.org/36443 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-12Add minimal INetMIME::scanContentType test and fix bugs thus foundStephan Bergmann
Change-Id: I8fcbeb2b0804bc4f9ee8f97f7d02737ba79a7f20
2017-04-12convert ReadWriteGuardMode to scoped enumNoel Grandin
Change-Id: I21ae815d5bbd7b39cd690168738c21925558585e Reviewed-on: https://gerrit.libreoffice.org/36452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-12no need to use OUStringToOString in SAL_INFONoel Grandin
Change-Id: I707e0d72aba89b7e644def6f4c251e14f6599ad2 Reviewed-on: https://gerrit.libreoffice.org/36451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-12infinite SetDefaultSize->SetPosSize->SetDefaultSizeCaolán McNamara
https://retrace.fedoraproject.org/faf/reports/1278627/ presumably the 'optimal' starting size hits the invalid size path causing another attempt usin the optimal size, so force a valid initial fallback size Change-Id: I6c38ee5e1b90ce41a4550c8a8370e791f5c351b0