summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-11-12Fix typosAndrea Gelmini
Change-Id: Ibb94b2b16afbcca84dd55ae51fde6fd27afede3a Reviewed-on: https://gerrit.libreoffice.org/63297 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-12tdf#120677: restore treatment of blanks in SwTextGuess::GuessMike Kaganski
Before commit 0be3db28a4db4d2c81a5cb2edd48711eec55b51b, all non-breakable spaces were converted to plain spaces in SwTextSlot::SwTextSlot (see pInf->SetText call there). The mentioned commit has changed that to allow differentiating non-breakable spaces from other types of spaces (related to the fix of tdf#115067). This broke following processing of the NBSPs when they don't fit to line, causing infinite layout loop leading to OOM. This allows to restore old behavior to not call the break iterator for NBSP by explicitly checking for it. Change-Id: I36ab06abb66bbe65a5fc542c41e816a9f20a2dcf Reviewed-on: https://gerrit.libreoffice.org/63290 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-12uitest Writer - Table properties dialogZdeněk Crhonek
Change-Id: I1706c19c9636ba43f5b64a0691c108b1b76293c2 Reviewed-on: https://gerrit.libreoffice.org/63299 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-11-12We need share/liblangtag, tooTor Lillqvist
Otherwise i18nlantag works weirdly. Change-Id: Ic5bf2007e586e6bb53a9e89782c2b05f73e348e3
2018-11-12uitest cleaning 01Zdeněk Crhonek
Change-Id: Iae30d2bef4bba232d5e5a042d1c736e36496ce1c Reviewed-on: https://gerrit.libreoffice.org/63298 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-11-12tdf#120703 PVS: V560 Properly compare current to cDecimalSepAltMike Kaganski
V560 A part of conditional expression is always false: current == cDecimalSep. Assuming a copypaste error in commit 21052ba2edeef9e16bf90fea62f007b1131c73c0. Compare to a similar case below (line 817). Change-Id: Iebd84aa8df3e37b9a5e4fdc7ce7a25a0704a260f Reviewed-on: https://gerrit.libreoffice.org/63269 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-11-12fix missing "else" in transliterateBulletNoel Grandin
ever since commit f1830339193643466c1dd76dc37594c21ab3ac4f Date: Tue Apr 8 15:07:08 2003 +0000 INTEGRATION: CWS calc06 (1.2.44); FILE MERGED not it will make much difference to the logic found by experimental loplugin:indentation Change-Id: I2d724ababa1664a87f2822ed8b59f3e3cd50e5e4 Reviewed-on: https://gerrit.libreoffice.org/63287 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-12honor getNumDecimalSep for keypad input in native gtk3 dialogsCaolán McNamara
Change-Id: Ibbd37f18ee97eb6ded0ab90cd70b777ffd20f91d Reviewed-on: https://gerrit.libreoffice.org/63291 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-12Guard listener cleanup of BasicProviderImplJan-Marek Glogowski
Otherwise JunitTest_sfx2_complex dbgutil asserts especially on Windows with: ucrtbased!get_wide_winmain_command_line+0x296 ucrtbased!get_wide_winmain_command_line+0xe4 ucrtbased!wassert+0x1a vcllo!ImplDbgTestSolarMutex+0x43 tllo!DbgTestSolarMutex+0x11d svllo!SfxBroadcaster::RemoveListener+0x2e svllo!SfxListener::~SfxListener+0x8f basprovlo!basprov::BasicProviderImpl::~BasicProviderImpl+0x8f ... Change-Id: Ia183436a92bc70ed5208364987b3e97e27b5bd6e Reviewed-on: https://gerrit.libreoffice.org/63289 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2018-11-12Add a SAL_INFO() when changing the global "lok" language tagTor Lillqvist
Change-Id: I229bb2cce38c3f67724802e31edff73e313b7457
2018-11-12tdf#118581 Correctly display issuer name in signature lineSamuel Mehrbrodt
Move the xmlsec helper methods to comphelper so that we can use them in cui Change-Id: If9b10cfff5f5abd6b16e48f043af7959edbb1142 Reviewed-on: https://gerrit.libreoffice.org/63198 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-12Adapt to new ConstantExpr in Clang trunk towards Clang 8Stephan Bergmann
After <https://reviews.llvm.org/D53921> "Compound literals, enums, et al require const expr" (making use of ConstantExpr recently introduced with <https://reviews.llvm.org/D53475> "Create ConstantExpr class", CompilerTest_compilerplugins_clang started to fail with > [CPT] compilerplugins/clang/test/unnecessaryparen.cxx > error: 'error' diagnostics expected but not seen: > File /data/sbergman/lo-clang2/core/compilerplugins/clang/test/unnecessaryparen.cxx Line 35: parentheses immediately inside case statement [loplugin:unnecessaryparen] > error: 'error' diagnostics seen but not expected: > File /data/sbergman/lo-clang2/core/compilerplugins/clang/test/unnecessaryparen.cxx Line 35: unnecessary parentheses around identifier [loplugin:unnecessaryparen] > 2 errors generated. Change-Id: Iebcfcd9af30e26df02819fbffb105599fa6a1701 Reviewed-on: https://gerrit.libreoffice.org/63285 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-12Revert "Add check for en_US.utf8 locale"Stephan Bergmann
This reverts commit 6b56ca7a9bf67bcada666f4cb1c2e20e7c0d512e, which is no longer necessary after cfdcb1bb0cf3a9fa2b342109cd581d3211e965bf "external/libnumbertext: Don't depend on en_US.UTF-8 locale". I have seen a full `make check screenshot` succeed on a Debian 9 without any en_US locale. Change-Id: I2037af478d9bc5017c7263bb45effd3e9ccde0d3 Reviewed-on: https://gerrit.libreoffice.org/63279 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-12tdf#42949 Fix IWYU warnings in sd/source/ui/slidesorter/inc/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I48e3c5a62314baa11d6c53ce41311a9a0f1c661b Reviewed-on: https://gerrit.libreoffice.org/62678 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-12-Werror,-Wunused-private-fieldStephan Bergmann
...since 9eb81304989acb16c61c15b211dd124548ffb85f "tdf#120703 PVS: drop the unused code". And which now removes the sole use of RID_SVXSTR_LOAD_ERROR. Change-Id: If8afa7595a449cb8677b03a159a452b73fed110e
2018-11-12loplugin:singlevalfields in vclNoel Grandin
Change-Id: I71367548ae15ef78f9860bab9bb05c96b82eb54a Reviewed-on: https://gerrit.libreoffice.org/63275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-12loplugin:singlevalfields in accessibility..extensionsNoel Grandin
Change-Id: Id3a3241af83f769fc60f67e01c9129d6f4b5c2af Reviewed-on: https://gerrit.libreoffice.org/63274 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-12svx: prefix members of SdrEditViewMiklos Vajna
Change-Id: I3e27d8444c5a152ee39b9e2cc12b9df707f092b8 Reviewed-on: https://gerrit.libreoffice.org/63281 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-11-12tdf#118764 Tab stop fixes for Area and Line panelsJim Raykowski
Change-Id: Ib29701a44ab42806951a5b2ad6b63aabda4abfba Reviewed-on: https://gerrit.libreoffice.org/63262 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-11-12convert ENSURE_ORIG_INTERFACE macro to template methodNoel Grandin
Change-Id: I50870b501d6195cf5b593e8a3b8b446f4461deca Reviewed-on: https://gerrit.libreoffice.org/63277 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-12Fix typoAndrea Gelmini
Change-Id: Ic471fbbfbcc00c0bb4ee42498ddcb1005e1e7103 Reviewed-on: https://gerrit.libreoffice.org/63280 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-12tdf#97361 Make check_bookmarks.py more pythonicHamish McIntyre-Bhatty
Keep lines within the correct length and add a little bit of whitespace to improve readability. Change-Id: I0cf26886b25079a970938b728004c96c9fa3e26f Reviewed-on: https://gerrit.libreoffice.org/61622 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-12tdf#97361 Make check_table.py more pythonicHamish McIntyre-Bhatty
Improve readability by inserting a little whitespace, and obeying PEP 8 (python style guide) more closely. Also remove an unused import and a few unused local variables. Change-Id: I07de686ec9b04e293bc4e0a092e5ad957cffbbba Reviewed-on: https://gerrit.libreoffice.org/61624 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-12tdf#97361 Make var_fields more pythonic.Hamish McIntyre-Bhatty
Use whitespace to improve readability, including indenting arguments in a more readable way Change-Id: I7cf687042fb1d4d62e8acb8277539101dc859859 Reviewed-on: https://gerrit.libreoffice.org/61626 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-12Make MaybeInterpret, NeedsInterpret, IsDirtyOrInTableOpDirty inlineDennis Francis
because they are in the hot path of the most common workload. For example, in SUM(A1:A50000) where column A is itself a formula-group, in threaded mode(default) A1:A50000 will already be evaluated, so cost to calling MaybeInterpret/NeedsInterpret etc should be as minimal as possible. Change-Id: Ie15c1483573391a718fb3af14cba3c798323363d Reviewed-on: https://gerrit.libreoffice.org/63064 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-11-12tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: Ifb3c9016019977aa2c51dbd0a0394a0f81150df5 Reviewed-on: https://gerrit.libreoffice.org/63270 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-12Re-order the members of ScFormulaResult...Dennis Francis
to make the common access pattern cache friendly. For example, in case of a large sum like =SUM(A1:A50000) where the column A itself is composed of formulas, the inner loop of computation involves accessing ScFormulaResult's of each formulacell of column A. Recently this was made faster by the use of a "cache" flag (commit 77f7b4768a), so to get the result it just need access to the cache bool-flag and the mfValue member. Hence it makes sense to group the bools together with the mfValue member. Change-Id: If12d0736ba98b9d74e7b96304fce71e8e6e66619 Reviewed-on: https://gerrit.libreoffice.org/63063 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2018-11-12Replace "using namespace" with qualified indentifiersJens Carl
Change-Id: I69cfd2a3528b059fe7d0be8c38e49782ca1fa78a Reviewed-on: https://gerrit.libreoffice.org/63272 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-12Impress menubar Grid section sync with Drawandreas kainz
Change-Id: Ic8738467d9099c63b42ac0d0ec28048b8466f471 Reviewed-on: https://gerrit.libreoffice.org/63271 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-11KJ: ^slide transition, flip, rotate, db, table border colorRizal Muttaqin
Change-Id: Id14a6e7754baecb0ecb70f95bf13b62b545c97a8 Reviewed-on: https://gerrit.libreoffice.org/63259 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2018-11-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I08ea67c1b51ee04258ce7769bfe9d97a1cb46b22 Reviewed-on: https://gerrit.libreoffice.org/63268 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-11fix oss-fuzz buildCaolán McNamara
Change-Id: Ia32a80547cd3e3fd21791d8ef2cf717700c790a8
2018-11-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix icon display in Help pages 1) The python script creates the replacement table (xsl) for missing icons from colibre/links.txt. Later it should go to build system. 2) Handle icon tables when images are not from icon-theme Change-Id: If946af6fc6c05431c07470c01082a46e0fdbdde0 Reviewed-on: https://gerrit.libreoffice.org/63254 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-11Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' - Fixed some silliness, added highlighting for index filter Change-Id: I946ffdb52ed8f324ab58f45a90f5decdd58932dc Reviewed-on: https://gerrit.libreoffice.org/63240 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-11Resolves: tdf#83128 translate row/col counts as separate n_gettext argsCaolán McNamara
Change-Id: I2aadeb92bbe482c766b1debf6278928d38dcc5d0 Reviewed-on: https://gerrit.libreoffice.org/63202 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I1027242192dfd2be4918094d59f2a8f8c8fec041 Reviewed-on: https://gerrit.libreoffice.org/63266 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-11tdf#120703 PVS: V560 A part of conditional expression is always trueMike Kaganski
This changes the condition to only select row if it's not selected yet; previously, because of the always-true condition or'ed, SelectRow was always executed. Change-Id: Id12b640518f3d72810e997735216db336d79f7f6 Reviewed-on: https://gerrit.libreoffice.org/63267 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-11[API CHANGE] Remove SAL_BOUND againStephan Bergmann
...that had been added to the stable URE interface, apparently by mistake, with 7474699aa372296da7494d1d0bec1f7dafbaae79 "contains some slightly changed macros from vos/macros.hxx", then removed with 2f0803e5869dd2d45c8d4b407017f053e83ed601 "remove unused macros, and add SAL_N_ELEMENTS", then re-introduced with d441fa1f8cc0a17a2bc166bf2f2a44f76b83a773 "remvove vos/macros.h usage". The last internal uses have now been removed with <https://gerrit.libreoffice.org/63264> "Replace uses of SAL_BOUND with o3tl::clamp". Change-Id: I0dd842533d97fa878606cbf62efb9fa46c029088 Reviewed-on: https://gerrit.libreoffice.org/63265 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-11Replace uses of SAL_BOUND with o3tl::clampStephan Bergmann
Change-Id: I66a7aad64623d778b4bf2fea591f227fdac2fdc7 Reviewed-on: https://gerrit.libreoffice.org/63264 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-11Removed repeated semicolonAndrea Gelmini
Change-Id: Iefc820a4c4bb87fe113f97b085d8e89f30ff2db5 Reviewed-on: https://gerrit.libreoffice.org/63261 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-11-11cppCheck redundantAssignment variable bUseCustomLabelZdibák Zoltán
Change-Id: Ic900d5116fd1cf5a90526078c6e4802f09589aa7 Reviewed-on: https://gerrit.libreoffice.org/63253 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-11cppCheck narrowed variableScope rEntryZdibák Zoltán
Change-Id: I04b0b0dc85afdceead9766d8a45e21055074d5fc Reviewed-on: https://gerrit.libreoffice.org/63248 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-11cppCheck bRet reassigned before usedZdibák Zoltán
Change-Id: Iaf27254896783deaeaee65bd51617d8e4e457873 Reviewed-on: https://gerrit.libreoffice.org/63244 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-11NB tabbed: update calc and impress layoutandreas kainz
Change-Id: I8a27c11c4d8f345b316d7b2bf3bc0fdfd2e03b4b Reviewed-on: https://gerrit.libreoffice.org/63258 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-11cppCheck redundantAssignmentZdibák Zoltán
Change-Id: Ib9203fa65d7b9825b0a7181dcfc0f522bc575541 Reviewed-on: https://gerrit.libreoffice.org/63242 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-11cppCheck redundantAssignmentZdibák Zoltán
Change-Id: I829c660c6c73868ac6a0f74e554d99c54d9f0ea8 Reviewed-on: https://gerrit.libreoffice.org/63245 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-11cppCheck redundantAssignment variable pContextZdibák Zoltán
Change-Id: Ic7c97853eeeaa87e7ed7ecfad638f516f2be2969 Reviewed-on: https://gerrit.libreoffice.org/63246 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-11cppCheck redundantAssignment variable bSuccessZdibák Zoltán
Change-Id: Ifacc27284201f74da7b4693a74d40e83ffc66408 Reviewed-on: https://gerrit.libreoffice.org/63251 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-11cppCheck redundantAssignment variable pCloneZdibák Zoltán
Change-Id: If2e1643a507f13e7da733896b1115ef39b512f00 Reviewed-on: https://gerrit.libreoffice.org/63252 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-11cppCheck redundantAssignment pParseNodeZdibák Zoltán
Change-Id: I0e5e2d607bddd1f73fc8c256169a2fbe070f6448 Reviewed-on: https://gerrit.libreoffice.org/63256 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2024-07-02 10:30:38 +0000