summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-06-21Resolves: tdf#108610 crash on double delete of async eventCaolán McNamara
regression from... commit e4e4d5713e248f02faf7aa6199b11e152973de8e Date: Wed May 31 15:40:25 2017 +0200 clang-tidy readability-delete-null-pointer which in turn triggered some loplugin:useuniqueptr lets revert the fix of commit 93a288bd75d7caed46d6f29bf006f3d97a9602a9 Date: Mon Jun 12 21:44:57 2017 +0200 svx: fix the std::unique_ptr that deletes itself twice and make the code do exactly like it always did pre initial change Change-Id: Ia922fccdc476e40b5c672b097b04c229215ce38e Reviewed-on: https://gerrit.libreoffice.org/39052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-21gpg4libre: fix build for windows and macThorsten Behrens
Change-Id: I3e36b22cefba4c6195bcf8b85b3f7a2cc101b845
2017-06-21gpg4libre: actually take key from user selectionThorsten Behrens
Change-Id: I6b18865913492d41a8e0206a430e267fe78c553a
2017-06-21gpg4libre: make signature impl swappable in-situ during validationThorsten Behrens
Sadly we only know whether its a OpenPGP or X509 signature during parsing, so we need to switch the implementation mid-way Change-Id: Ib48a9da0105de62cfecda095df8c154b59ba8c40
2017-06-21gpg4libre: some code improvements, add metadata for OpenPGP keysThorsten Behrens
Change-Id: I1beb692b9a9a34b5f0cf743ba9e4a145ac582184
2017-06-21gpg4libre: Make viewing signatures work for gpg signaturesSamuel Mehrbrodt
Change-Id: Ic10846cb87e23ca9ffa0eb0d64c56fcf79c73a9d
2017-06-21gpg4libre: Fixup unit tests, now that SecurityContext is neededKatarina Behrens
Change-Id: Ifa43fa735c8b0d58ff3d3deca2ad4eca6560494a
2017-06-21gpg4libre: write PGPData info, get more metadata out for gpg keyThorsten Behrens
Change-Id: Ia560869ec02fca7fe4219136e1fe939e13f1e4c2
2017-06-21gpg4libre: Init xmlsec in one place before creating the gpg/x509 servicesSamuel Mehrbrodt
Change-Id: I0308d586344b5e52ad327f6650b62ac0eac7ecb9
2017-06-21gpg4libre: List both (x509 and gpg) existing signaturesSamuel Mehrbrodt
Change-Id: I57ae79f7632885bf5c5aadcad3fb5ad4a5a9413d
2017-06-21gpg4libre: [API-CHANGE] add certificate kind (X509 vs. OpenPGP)Katarina Behrens
Change-Id: I423bef41f93af9d1b78ee9795be7ec33c3c7ae0c
2017-06-21gpg4libre: now use the gpg security envThorsten Behrens
Change-Id: I84e4d6872aab27f5b11ec727787a2eab80ef6a66
2017-06-21gpg4libre: fix build, explicit ctor callThorsten Behrens
Change-Id: Iec7ca4e37d6f5c4f63aaa22acfa0bdd395747471
2017-06-21gpg4libre: Having this dllpublic should be fine now since it's in inc/Samuel Mehrbrodt
Change-Id: I79c132e717a62c6274eeafe33d732616cbd6a5a6
2017-06-21gpg4libre: Make signature dialog work with two signing servicesSamuel Mehrbrodt
Change-Id: I0b47e6dba38222bb6b4f778c4206d3b37bc93089
2017-06-21gpg4libre: initial GPG signature validationThorsten Behrens
Change-Id: I80afd77f74a6cb3f3fb7da03a6a4b74b132360d2
2017-06-21gpg4libre: fix gpg signature generationThorsten Behrens
Change-Id: I6eb95c948b6c8c9b8dee21215b430921bf454bb9
2017-06-21gpg4libre: share static xmlsec lib between nss and gpgThorsten Behrens
In the end, the gpgme implementation uses enough of xmlsec functionality that splitting those (and ending up with two copies) was just not worth it. Change-Id: Ida87c848e4e6a770e3c697add9ceb589a9ec3930
2017-06-21Updated coreChristian Lohmaier
Project: translations 3a8e01f5e88f26c3a455d3cf8c2b92c3d7b11422 update translations for 5.4.0 rc1 and force-fix errors using pocheck Change-Id: Ie086d580cf55f92d4b916a9822c82cf6bb4130e5
2017-06-21remove unused EE_READWRITE constantsNoel Grandin
just as well EE_READWRITE_GENERALERROR is unused, since it's value overlaps with ERRCODE_SVX_LINGU_LANGUAGENOTEXISTS Change-Id: I9752d78ae8510f650d709ee0d4f28b536494ec06 Reviewed-on: https://gerrit.libreoffice.org/39057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21s/ERRCODE_SBX_OK/ERRCODE_NONENoel Grandin
adds no value Change-Id: Iedf7a6a7be28fed4059b576312890be8cbb980d7 Reviewed-on: https://gerrit.libreoffice.org/39056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21Resolves: tdf#108671 mark named expression single reference #REF! if deletedEike Rathke
Probably broken already since commit f77c9d5b3cb65d9c2e2417f60bec1113feac50e1 Date: Mon Jul 29 14:47:07 2013 -0400 Change-Id: If90a959d000a1bf5ab0804deb22d5cfad413ea5e
2017-06-21Assert that nTabNo fits maTabData, tdf#108654 relatedEike Rathke
Change-Id: I30b95f69a71317896d86e36b1b926c703f1539d1
2017-06-21Resolves: tdf#108654 check nTabNo against maTabData sizeEike Rathke
ScViewData::DeleteTab() and DeleteTabs() never did that and worked by accident for which commit 73dec49802ef8fc42c5719efaa42a33cde68e569 removed the grounding.. Change-Id: I95460cd017d558c073df7891551d0251009dc1d4
2017-06-21loplugin:privatebaseStephan Bergmann
Change-Id: I4ccc29493332af16d9d79adff56002757b9d5bb6
2017-06-21ofz#2340 null deferences on close redlinesCaolán McNamara
Change-Id: I5e270f160f51b7ffa7059dfd17f31d8ec5919a3e
2017-06-21-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I0f16c434f735ced976580e921394778559b57410
2017-06-21Listen for changes in editing preference settingsbrainbreaker
This commit gives the ability to listen for changes in editing preference settings to LibreOfficeMainActivity. This makes sure that value of mIsExperimentalMode boolean is correct in any condition. Change-Id: Ie2a931e63fad30262ad2f870b6c06f707db96618 Reviewed-on: https://gerrit.libreoffice.org/37033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-06-21Fix compilation with Clang 3.9.1Tor Lillqvist
Change-Id: I6e96064a001fd511864665fe0ef8b60d45462c12
2017-06-21loplugin:unusedfields in sw part2Noel Grandin
Change-Id: I7404fcac486f54fc0e310f401d8546c4aacfede2 Reviewed-on: https://gerrit.libreoffice.org/39040 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21loplugin:unusedfields in sw part5Noel Grandin
Change-Id: I4111ed1dcb04e010ecfb93df3a7e7bf715abf585 Reviewed-on: https://gerrit.libreoffice.org/39044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21loplugin:unusedfields in sw part3Noel Grandin
Change-Id: I0ee93f4df757d477912de70937ec1dded82c48fb Reviewed-on: https://gerrit.libreoffice.org/39041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21Process all core files that are foundStephan Bergmann
...which can be useful e.g. when a UITest spawned multiple soffice.bin sub- processes that crashed Change-Id: Ic14ab286b320f2ee548c217e5395cfeec3afa889
2017-06-21loplugin:unusedfields in sfx2 part2Noel Grandin
Change-Id: I227b643641250d47ac6b2218f57ddb231765960e Reviewed-on: https://gerrit.libreoffice.org/39038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21loplugin:unusedfields in sw part1Noel Grandin
Change-Id: Iabbf7f09c0d92b488d7e03f4436f077c5e6e87aa Reviewed-on: https://gerrit.libreoffice.org/39039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21White-list sw/Jens Carl
Change-Id: Ic4ca1753720d3806cc0fa9f517078dd5032d9e20 Reviewed-on: https://gerrit.libreoffice.org/39029 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-21tdf#39468 Translate German comments in sw/source/filter/ww8/ww8scan.cxxJens Carl
Change-Id: I30e673fc5741c37e3064e2b2035d772b43364d06 Reviewed-on: https://gerrit.libreoffice.org/39022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-21tdf#39468 Translate German comments in sw/Jens Carl
Translate the last remnants found by ./bin/find-german-comments sw Change-Id: I0618671b8794e05a51eeff811746a1154359d0fe Reviewed-on: https://gerrit.libreoffice.org/39028 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-21tdf#39468 Translate German comments/terms in sw/source/filter/ww8/ww8graf.cxxJens Carl
Change-Id: I3cfc777be4b717bee7fd4559ca79fb9ba6626a51 Reviewed-on: https://gerrit.libreoffice.org/39027 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-06-21loplugin:unusedfields in sfx2 part1Noel Grandin
and fix a memory leak in NotebookbarTabControl where it was not freeing it's m_pListener field Change-Id: Ib9970c9084982d532fa38d1bc3c44180ab2c3c39 Reviewed-on: https://gerrit.libreoffice.org/39036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21Fix use of wrong functionTamas Bunth
Input is a color, expected return value is an index. Change-Id: I1bb6977cea5aad7a89082ace12f0a85c58a0f2e3 Reviewed-on: https://gerrit.libreoffice.org/39045 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-06-21loplugin:unusedfields in svtoolsNoel Grandin
Change-Id: Ic8f67d40825d9843fd57535bd61bef51b470a8be Reviewed-on: https://gerrit.libreoffice.org/39016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21loplugin:unusedfields in svx part2Noel Grandin
Change-Id: Ie9fd55b71a152f428a397d9917918f0e9de39aaf Reviewed-on: https://gerrit.libreoffice.org/39014 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21android:update safeint header to use the else implementation with clangbrainbreaker
Clang toolchain does not defines the __builtin_mul_overflow for 32-bit ARM. So, fallback to else implementation of checked_multiply when building Android with Clang Change-Id: I6120606f521ce121541a5b7f1150229258012d55 Reviewed-on: https://gerrit.libreoffice.org/39005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-21fix android buildNoel Grandin
after commit 528632660b72b105345945c13c5b68060d94a91b "convert ErrCode to strong typedef" Change-Id: I31727d89f6450e5d1d0930abf7dba7a32f8b894a
2017-06-21tdf#82173 writerfilter: copy Xnote Characters -> Xnote anchorJustin Luth
In MSWord, Footnote Reference applies to both in-text and in-footnote formating of the reference number, while LO uses two. Convert into one style, and copy into the other style. Change-Id: I8cf731d5d1236c86fc1c82e798d8a459ca95d0ba Reviewed-on: https://gerrit.libreoffice.org/38374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-21sw_htmlimport::testTableBorder1px testcase simplifiedVasily Melenchuk
Goal of this testcase is just to ensure that some table cell borders exist while some others do not. There is no reason to do exact width comparison which is causing errors on some MacOS configurations. Change-Id: I574c29220696ae654dea2db0398790a440efd83b Reviewed-on: https://gerrit.libreoffice.org/39015 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-21xmlsecurity nss: adopt the private key of the signing certificate explicitlyMiklos Vajna
xmlsec1-customkeymanage.patch.1 of our bundled xmlsec extends xmlSecNssKeyDataX509VerifyAndExtractKey(), so that it calls xmlSecNssPKIAdoptKey() for the private key of the signing certificate. Make this explicit in xmlsecurity/ code, so we don't depend on the patched xmlSecNssKeyDataX509VerifyAndExtractKey(). This is harmless for the patched xmlsec, but it prevents this error: warn:xmlsecurity.xmlsec:26221:1:xmlsecurity/source/xmlsec/errorcallback.cxx:48: keys.c:1246: xmlSecKeysMngrGetKey() '' 'xmlSecKeysMngrFindKey' 1 ' ' warn:xmlsecurity.xmlsec:26221:1:xmlsecurity/source/xmlsec/errorcallback.cxx:48: xmldsig.c:790: xmlSecDSigCtxProcessKeyInfoNode() '' '' 45 'details=NULL' warn:xmlsecurity.xmlsec:26221:1:xmlsecurity/source/xmlsec/errorcallback.cxx:48: xmldsig.c:503: xmlSecDSigCtxProcessSignatureNode() '' 'xmlSecDSigCtxProcessKeyInfoNode' 1 ' ' warn:xmlsecurity.xmlsec:26221:1:xmlsecurity/source/xmlsec/errorcallback.cxx:48: xmldsig.c:286: xmlSecDSigCtxSign() '' 'xmlSecDSigCtxSignatureProcessNode' 1 ' ' when xmlsec is not patched. (This is needed, but not enough to build against system xmlsec.) Change-Id: I5d68a8be7aefcb529566213f9b9c2985eab6a80a Reviewed-on: https://gerrit.libreoffice.org/39023 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-21loplugin:unusedfields store..svlNoel Grandin
Change-Id: I6070a683e5128271b84a10caccb548d07c950927 Reviewed-on: https://gerrit.libreoffice.org/39021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21loplugin:unusedfields in svx part1Noel Grandin
Change-Id: I6621e0dda5a5dc3e68c7b1613975c075e2879912 Reviewed-on: https://gerrit.libreoffice.org/39006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-13 16:45:35 +0000