summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-10-21Correct commentTor Lillqvist
Change-Id: I29633cfe7b378796bec5fe822941193ded8a9aa9
2014-10-20fdo#85185 Copy OUString argument to avoid a use after freeMatthew J. Francis
The original OUString is destroyed along with its containing object part way through the call to PaletteManager::PopupColorPicker(), so a copy must be taken Change-Id: I8417ff23a17003e80a4f65e0cf1ad2a8dda5386c Reviewed-on: https://gerrit.libreoffice.org/12031 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-20put back variable deleted by mistakeDavid Tardon
Change-Id: Ic705fe6bb7c3b9bae4b09d0b487f48056675b4b8
2014-10-20crash in tools->options->advancedCaolán McNamara
regression from... commit 06562c678410e425de629109ce92933c2d89a8f6 Date: Sat Oct 18 10:36:36 2014 +0200 convert SV_BMP_ constants to enum Change-Id: I46cb7f649fa44d8967e0e7da03583157d2706f05 Reviewed-on: https://gerrit.libreoffice.org/12018 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Change-Id: I29486e8fe17d9e06e01c33f93d99ffc6ae3d017c
2014-10-20Clean up VendorBase (virtual) member functions furtherStephan Bergmann
Change-Id: If6b9355c6992eb6651f71c0944a93af0856ef1c7
2014-10-20Clean up VendorBase (virtual) member functionsStephan Bergmann
Change-Id: I1377dfded1246c8e96db3addc28489886c7f2d99
2014-10-20Revert "Fix fdo#84795 Menu, DropDown-List not disappears with right mouse click"Caolán McNamara
This reverts commit 53c836701e22b1babd3702b502facd76236df7ff. because it means that all disabled buttons get their "click" delivered so disabled buttons are only visually disabled. e.g. writer: insert->table->autoformat, click on the disabled "rename" or "add" or "remove" and the sub dialog appears. Or in calc insert->object->chart and click on the disabled "back" -> crash
2014-10-20chart2: fix memory leak due to cyclic reference in VAxisBaseMichael Stahl
The VAxisBase::m_xNumberFormatsSupplier refers to the ChartModel itself, and apparently that is a cyclic reference. Naively using the ChartModel's m_xNumberFormatsSupplier in ChartView::impl_createDiagramAndContent() because it will later be passed to AxisHelper::getExplicitNumberFormatKeyForAxis(), which expects to be able to convert it to a ChartModel. Since passing around the ChartModel as an XNumberFormattingSupplier is sort of un-intuitive anyway, refactor some methods to use XChartDocument instead, and only create the VPolarAxis / VCartesianAxis with the ChartModel's m_xNumberFormatsSupplier. The drawback is that if ChartModel::attachNumberFormatsSupplier() is called after ChartView::update() has created the axes, it may not have an effect on them; not sure if that is a real or hypothetical problem. Change-Id: Ib5f0d5882b85adaf44f80e086f19178b3e64882f
2014-10-20tweak CaughtExceptionCaolán McNamara
Change-Id: If5aac87876b139bfb394ec124136de131c3518ae
2014-10-20add bin/refcount_leak.py script to help detect leaks of UNO objectsMichael Stahl
Initially this didn't help at all, but with some tweaks it now finds the leaked ChartModel as the #3 and #4 printed stacks, with a very bad score of 40. Change-Id: I918bcb64bad0b9432bf2b670b03915836fb34a11
2014-10-20Related: fdo#84676 set floating undo bits to the same as the color pickersCaolán McNamara
Change-Id: I153d92e94319bd1e7f0d425288f184bd8d13542d
2014-10-20fix font testsCaolán McNamara
Change-Id: I2738ea2a5c6714d8e43c06aa2eb4c53500a5afe9
2014-10-20-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I2e7c2206872dfe22c77555f3a14ea2a10c2453c2
2014-10-20fdo#85042 Windows XP SP2 is requiredAndras Timar
Change-Id: Ie36cc7444fe5d685393e06d3d3a3a8d827b2f775
2014-10-20Missing includeStephan Bergmann
...and only use getCaughtException as first statement in catch block. Change-Id: Idcac073896b84fd2671b52b2315f454651dbf910
2014-10-20fdo#78826 HIG: missing colons and capitalization in scAdolfo Jayme Barrientos
Also: * Something I missed from the HIG: standardize Help button position Change-Id: Iaac65bd277d87ff58883f287808a5c5b804cc04e Reviewed-on: https://gerrit.libreoffice.org/12015 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-20Work around workaround for old MSVC 2012Stephan Bergmann
...not allowing certain o3tl::is_typed_flags::Wrap conversion operators to be explicit, thus causing ambiguities here. Change-Id: I5108885229eb185ceac57042e67405b393cdcf3b
2014-10-20Resolves: fdo#84885 chart wizard dialog cut offCaolán McNamara
Change-Id: Ie24687cd1c54b1fed04745c83f507c17a5574175
2014-10-20chart2: fix temp file leaks in Chart2ExportTestMichael Stahl
Change-Id: Id128f19dee056189a34a02156fd0bf3ac14c2454
2014-10-20chart2: fix temp file leak caused by missing tearDown() between testsMichael Stahl
Change-Id: Ia4ee76743c640c0c5b92ec169e619f6c8788480e
2014-10-20Revert "at least fix the crash when calling SdXImpressDocument::disposeMichael Stahl
... for now" This reverts commit 599473a13e3c5ba669d995c913ad415bd674a16c. moggi says the unspecified crash happened with the tests following the comment in chart2import.cxx:75, but the tests run fine in valgrind now. The commit creates a memory leak in the CppunitTests as SfxBaseModel::dispose() returns early, because mbDisposed is set. Change-Id: I987dce6a4090784d166a4a3b2e7f9e2c0cddd289
2014-10-20DOCX import: fix <w:pageBreakBefore> wrt. inherited stylesMiklos Vajna
We used to ignore this element with a "false" logical attribute, but that causes a problem when an inherited style wants to explicitly disable this element from a parent style. Change-Id: I2fc4c5b2002987d44679d863ea3f19114b9ab7a4
2014-10-20allow to build with system opencolladaDavid Tardon
Change-Id: I6101099c57d429987e06bca0652c843f4a94f8cc
2014-10-20add test file for MWAW presentation importDavid Tardon
Change-Id: I676de4ca59524e858bf24133d7c54f424922ef26
2014-10-20Add a filter for AppleWork's presentation file...osnola
Change-Id: I9f03ecc6d67ad77ccb0d5240fe0b5968c8063bd3
2014-10-20Revert "fdo#75757: remove inheritance to std::map"Stephan Bergmann
This reverts commit a2deca9d755710bd543fd0caaea0352ac746396d: config_map had been introduced on purpose with bfb978334cea775b8ae5c40ceea050ea0660d80a "configmgr: faster / simpler compare for keys." Change-Id: I3ae0edc4d23977c6537bd2f462f90a702266de6d
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: If50022b55a558c4124d71acbbe0ef5eb48801d0b
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: Idb6337bed1c32444f9644d54eba5240f09c13ef6
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: I2cb764db97469654f977de63e273874d43745bf8
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: Ia3055b00c20a885dfa0584f864f0e91ccad1e9c9
2014-10-20Resolves: fdo#85006 limit script stripping to known suffixesCaolán McNamara
Change-Id: I276535b007bbb55555148d5937076b86da5de825
2014-10-20fix problem with gcc compiler complaining on variable typeAdam Co
Change-Id: I9a16e24e79d22b0af1710d6ac25eaa5fb19c71ff Reviewed-on: https://gerrit.libreoffice.org/12047 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-20coverity#735638 Division or modulo by float zeroCaolán McNamara
Change-Id: I2f183bc0bb9c67e3873e13a4bdbc57be9471b8a3
2014-10-20coverity#735639 Division or modulo by float zeroCaolán McNamara
Change-Id: I2ba45c49fb00fdd53b8e388e25df503e82c2332e
2014-10-20add CVE-2013-4979 testCaolán McNamara
Change-Id: I54025f46394ec1b16443ba75ff9edf9d8e1f6738
2014-10-20add eps import regression testCaolán McNamara
Change-Id: Iba88c7e54ba83132a859124d51f88be72cb3e3e1
2014-10-20coverity#706540 Uncaught exceptionCaolán McNamara
Change-Id: I175050b5ab66f4eeaa658f0aab1739b175d38d51
2014-10-20coverity#706538 Uncaught exceptionCaolán McNamara
Change-Id: If23396c545e7add653fa9e5ac6e544aaa794120d
2014-10-20coverity#704010 Unchecked return valueCaolán McNamara
Change-Id: I90750c51ce3b38defdba7ecdb7734172983efa8c
2014-10-20coverity#982248 Unchecked return valueCaolán McNamara
Change-Id: Ice8c1b3eab28fc8ef27d802f64b7dd90a0614e42
2014-10-20coverity#703957 Unchecked return valueCaolán McNamara
Change-Id: If9e3e7297b1539c93902895c50af3fb8f6c83a76
2014-10-20coverity#1242704 Untrusted loop boundCaolán McNamara
Change-Id: Ib2e00c0cd269dc7ae55b206713fe07e5326072f2
2014-10-20coverity#1242606 Untrusted loop boundCaolán McNamara
Change-Id: Iafa03d4dd65eb343a80996880bc1ed846d1b7491
2014-10-20Missing "Stephan Bergmann
Change-Id: I5d596f85fe11bc9336e1669d571795f3dfc70c6c
2014-10-20fdo#75757: remove inheritance to std::mapDaniel Sikeler
Change-Id: I189d7a1d68eb9022a32e882d68ce8c8dc567c1fd Reviewed-on: https://gerrit.libreoffice.org/12042 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-10-20Clean jvmfwk tracing outputTor Lillqvist
Change-Id: I070fb24e9466d697a6014bd65635f6cda8736819
2014-10-20Skip vendors that are irrelevantTor Lillqvist
There surely are no Apple JVMs for other OSes than OS X. Correspondingly, there surely are no IBM, Blackdown, BEA, FSF or FreeBSD JVMs for OS X. At least not ones that would be relevant today. Change-Id: I0ee6f904665a2145771802beffe54268718bef50
2014-10-20Fix MSI comment when productname contains whitespaceYiiChang Yen
Change-Id: I5c6383cd383eef02cc9e8a6f4798b928763e46c6 Reviewed-on: https://gerrit.libreoffice.org/11994 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-20Increase assert coverage of OStringBuffer argumentsMatthew J. Francis
Change-Id: Ifd3c9919ef104909efa8964e7a0cb5e723e3331d Signed-off-by: Stephan Bergmann <sbergman@redhat.com>