summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-10-11vcl: test OutputDevice::DrawPolyLine()Chris Sherlock
Change-Id: Iac95e0d08043153c877c204fa40aa90b3b974156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122973 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-11vcl: test OutputDevice::DrawWaveLine()Chris Sherlock
Change-Id: I31391416b1633635ce7be7b4a445008d3e5ebde6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122972 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-11vcl: test OutputDevice::DrawBorder()Chris Sherlock
Change-Id: I627cf9a8f9f6697a7e01cef9356b298e0a2b21f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122971 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-11vcl: test OutputDevice::DrawCheckered()Chris Sherlock
Change-Id: Ie6e4f626954961f874cc47bfdf6434ae496e9c2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122894 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-11vcl: ensure test VDevs are always bigger than operation being testedChris Sherlock
Change-Id: I4b57db489e950d75929be51210c113e6a149b534 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123222 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-11vcl: fix issue in testErase()Chris Sherlock
Funnily enough, this *could* still be a valid test because SetOutputSizePixel() acutally triggers an Erase(). But that's not really the point, the test is brittle because we possibly may remove the Erase from that function one day. This sets the actions we test to the *second*, explicit Erase we are actually testing. Change-Id: Ib0bb4693a90ad2a4756f93a8933db95d337950c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123236 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-11cid#1492820 WMI: Inefficient Map IteratorCaolán McNamara
Change-Id: I2a220d5f8178dc96bb930600d51884c245128324 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123366 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-11loplugin:moveparam in unoidlNoel Grandin
Change-Id: Id3069cad0b118b5593bb7a0faa9d7e33e5bef168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123353 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-11fix MSVC mergelibs buildLuboš Luňák
Linker complains about duplicate symbols for the template, seems to be a case of https://codesynthesis.com/~boris/blog/2010/01/18/dll-export-cxx-templates/ Change-Id: Iaffa3ba55edf4e54c62757c64d6b340b55a514cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123362 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-11remove unused variablesLuboš Luňák
The if is even wrong, testing for WINNT nested inside testing for not WINNT. Change-Id: I797ff61099064f1b66fea34fb25a00a88df4fca2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123255 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-11cid#1492337 Unintended sign extensionCaolán McNamara
Change-Id: Ic5956d1c87a1461fcd1555767f7f83123b87b5e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123367 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-11loplugin:moveparam in unotoolsNoel Grandin
Change-Id: Idd014c93e2e85d2ffc7a2535a9c65cffc8a9d403 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123348 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-11sw: prefix members of SwDLL, SwFieldDlgWrapper, SwImplShellAction and ...Miklos Vajna
... SwModelessRedlineAcceptDlg See tdf#94879 for motivation. Change-Id: I06299afbbba2a52f08526ef9e7bb9c5892c7a7eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123361 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-10-11tdf#143959 sdext.pdfimport: call vcl::Font::identifyFont directlyKevin Suo
Previously the unittest testTdf143959_nameFromFontFile did not fail even if the fixing code in wrapper.cxx is removed. That was because the "if (xHolder.is())" condition is always false in the unittest run, which suggests that the calling of com.sun.star.awt.FontIdentificator through the uno did not work in some circumstances. See comments in: https://gerrit.libreoffice.org/c/core/+/120815 In this patch, we call the vcl::Font::identifyFont directly rather than through the uno calling. This is proven to work in both the manual and unittest running. Change-Id: I6334bca2defaa27cf6ac72af3d621fbb59e57980 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123358 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-11sdext.pdfimport tdf#78427: Add support for more Font Weight featuresKevin Suo
...e.g. Thin, Extra-Light, Light, Semi-Bold, Bold, Extra-Bold and Black. Previously the xpdfimport code passes the isBold value which is bool value. sdext.pdfimport accepted this value from the xpdfimport output and check whether a font is bold or not. However, there are many other FontWeight features more than a "bold". This patch changes the isBold to the GfxFont::Weight type, and changed the sdext.pdfimport isBold bool type (in FontAttributes) to an OUString fontWeight. The value for the fontWeight is set according to the GfxFont::Weight passed by xpdfimport, and then this fontWeight is passed to the ODF xml generation stage and used there directly. Now the Semibold and Light (as shown in the unittest file) can be currectly handled. However, for other weights the parseFontFamilyName still need to be updated, but before doing that I plan to refector this function as the current logic is very difficult for maintennance. Change-Id: If2ce5f0f41c83843d8a6aeb30134b3faf99ba877 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-11Fix gpgmepp build with glibcMike Kaganski
posix-io.c: In function '_gpgme_io_spawn': posix-io.c:492:23: error: void value not ignored as it ought to be 492 | while ((i = closefrom (fd)) && errno == EINTR) | ^ make[1]: *** [Makefile:964: posix-io.lo] Error 1 Change-Id: I0e7abc33200ca7436c72e925447e681fd241c6a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123259 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-11tdf#144397 tdf#144636 XLSX: cache external named ranges and their formulasBalazs Varga
XLSX round-trip resulted corrupt XLSX with invalid named range, triggering Excel file repair, because of incomplete handling of external file reference of the named ranges (tdf#144636). Cache external named ranges and their formulas in case of updating formulas without data loss. Also we can copy cell formulas and we get valid results of formulas from the cached tables, instead of an error type. Now Calc resolves the external file reference of the named ranges, e.g. see "rangenameinotherfile" of the unit test document in Manage Names (Ctrl-F3). After the fix, it contains full path of the external file, and recalculating the sheet or changing data in the target file reveals that the named range works correctly (tdf#144397). Change-Id: Ic011a29290f8cabcc39fdc4b8d775ecf9d33612f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122026 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-10-11merge LD_PLUGIN use with other LTO useLuboš Luňák
It seems LD_PLUGIN predates the other --plugin usage, so make that one use LD_PLUGIN instead of using --plugin twice. Change-Id: I00133be18e576bc9a797853621a20dd7d5245344 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123257 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-11use ThinLTO for Clang everywhereLuboš Luňák
No idea why it should be used only on Apple platforms and normal LTO elsewhere. ThinLTO should build faster and the result should perform roughly the same. Change-Id: Ie93cf0ba810ee5bb2309fcbd3548a4847587b3d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123256 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-11remove unused forward declarationsLuboš Luňák
The class has been moved to vcl::font namespace, so these are wrong, which means they are unused. Change-Id: Ie24dfe4afbe78f03e3aa54cf2983bd45a4735a37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123330 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-11Drop unused 'using namespace' hereMike Kaganski
Change-Id: Iffd9e68cbefae664374ca8ad75441f899b849f34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123168 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-11Expand some defines and simplify loopsMike Kaganski
Change-Id: I5cbfa815fb2b3d92eac1959ece67160fae4cd556 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123170 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-11Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 152530c4360c80e9a052c4c883a8e4d53001f364 - Create documentation for Basic "New" operator Change-Id: I11157f8db43811a107eb5270db5b39c351b37dcc Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123159 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-11Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 79cf3e922b00a74a6a29ec324589aab7f05c5886 - Running Python Interactive Console: - Provide a non ambiguous capture - Present APSO console as optional - Provide GNU/Linux appropriate information Change-Id: Ice7069242fc900b5c7c60a576671f62f841a313d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122732 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-11Simplify one matchIgnoreAsciiCase overloadMike Kaganski
Change-Id: I982a5fd893b94085d30aeb595640d46cac4acdf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123169 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-10Revert "Initialize nDXBuffer array (vcl/edit)"Julien Nabet
This reverts commit 00ee02ea26a070d630160ef5c51f36ab093a9b53. as suggested implicitely Change-Id: I48aed1f48dca493c486f738dca895b1c00027066 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123171 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-10Initialize nDXBuffer array (vcl/edit)Julien Nabet
Change-Id: I2ed4e43e8bf52d980e850e61769343c6a685e74d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123355 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-10loplugin:moveparam in xmloffNoel Grandin
Change-Id: I46c1c8dc46cd2b8470b69506f6609f8bd7e42211 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123347 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-10gtk4: popdown context menu when radio/check is toggledCaolán McNamara
Change-Id: I6cee9ee639b85c76c140d1ee0ad735fb57dae905 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-10fix (cppunit test) build with --enable-mergelibsRene Engelhard
S=/home/rene/LibreOffice/git/master && I=$S/instdir && W=$S/workdir && /usr/bin/ccache x86_64-linux-gnu-g++ -pthread -shared -Wl,-z,noexecstack -Wl,-z,origin '-Wl,-rpath,$ORIGIN/../Library' -Wl,-rpath-link,$I/program -Wl,-z,defs -Wl,-rpath-link,/lib:/usr/lib -Wl,-z,combreloc -Wl,--hash-style=gnu -Wl,-Bsymbolic-functions -L$W/LinkTarget/StaticLibrary -L$I/sdk/lib -L$I/program -L$I/program -L$W/LinkTarget/Library -Wl,-z,relro $W/CxxObject/vcl/qa/cppunit/BackendTest.o -Wl,--start-group -lcppunit -Wl,--end-group -Wl,--no-as-needed -lmergedlo -luno_cppu -luno_cppuhelpergcc3 -luno_sal -ltest -lunotest -o $W/LinkTarget/CppunitTest/libtest_vcl_backend_test.so /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/outdev.o: in function `VclOutdevTest::testDrawPixel()': ././vcl/qa/cppunit/outdev.cxx:1091: undefined reference to `typeinfo for MetaPixelAction' /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/outdev.o: in function `VclOutdevTest::testDrawRect()': ././vcl/qa/cppunit/outdev.cxx:1203: undefined reference to `typeinfo for MetaRoundRectAction' /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/outdev.o: in function `VclOutdevTest::testDrawEllipse()': ././vcl/qa/cppunit/outdev.cxx:1225: undefined reference to `typeinfo for MetaEllipseAction' /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/outdev.o: in function `VclOutdevTest::testDrawPie()': ././vcl/qa/cppunit/outdev.cxx:1243: undefined reference to `typeinfo for MetaPieAction' /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/outdev.o: in function `VclOutdevTest::testDrawChord()': ././vcl/qa/cppunit/outdev.cxx:1263: undefined reference to `typeinfo for MetaChordAction' /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/outdev.o: in function `VclOutdevTest::testDrawArc()': ././vcl/qa/cppunit/outdev.cxx:1284: undefined reference to `typeinfo for MetaArcAction' Change-Id: I65f79d726de553d894c848a89cf1dd97d5e45b54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123329 Tested-by: Jenkins Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-10gtk3: popdown context menus on toggling radio/check buttons tooCaolán McNamara
like we do for menubar menus (tdf#125803) Change-Id: Ib70b90bd9ec9b1f624b1cdff5ba6d304f75f8919 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123344 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-10gtk[3|4] use set_buildable_id and get_buildable_idCaolán McNamara
Change-Id: Ia3a24d80ac56bc834c11f85a98e3b9fa1a862e41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123343 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-10gtk4: this is fixed now by at least >= gtk4-4.4.0Caolán McNamara
Change-Id: Iaff7c779917c7a1d90849d2091dd818bc0c04750 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123342 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-10OSL : remove useless rtl::Static in debugbaseArnaud Versini
Change-Id: I54ef4d1b492409265496c7f2b852568274bcf073 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-10loplugin:moveparam in basegfxNoel Grandin
Change-Id: I73414e94358114ff0d475f13855db8c4c493b6f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123334 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-10loplugin:moveparam in xmlscriptNoel Grandin
Change-Id: I8c33291dae8a4f90c02f47d823b127ca4e383d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-10loplugin:moveparam in svxNoel Grandin
Change-Id: I2e422235129f810feea5c17afa1332d8b7ac14ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123332 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-10loplugin:moveparam in editengNoel Grandin
Change-Id: I08aed09b0acd283d700bdf75f650e93dba7c7b85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123341 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-10ofz: Integer-overflowCaolán McNamara
seeing as GetHmmFromInch is already using limit_cast, use saturating_add here Change-Id: I3123ac15edd300f6d7d64c458ce95b20c9220117 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123340 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-10loplugin:moveparam in comphelperNoel Grandin
Change-Id: I109d8507890460c5a479af2a5b94f905197b08d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-10loplugin:moveparam in svlNoel Grandin
Change-Id: Icd45c7f693c866e7eafcf6aeb052a4d190dce38c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-10loplugin:moveparam in ucbhelperNoel Grandin
Change-Id: Id6b03af5ecd662ce2e390bb76819cfe5d2ec05ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-10cid#1492337 Unintended sign extensionCaolán McNamara
Change-Id: I6836e83ba17de646bfb661281b76c2b5e58b76c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123323 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-10OSL : use std::mutex in backtraceapiArnaud Versini
Change-Id: I2df73d7959dd24882f75130f0fd03ff096dce8d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123322 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-10Typo: brake(s)->break(s) (I let the right use of "brake" of course)Julien Nabet
Change-Id: I6a15f4d09c571877db22feee688b46b872eb73dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123331 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-10use SfxItemSetFixed in swNoel Grandin
Change-Id: I69e188d7599b7fc439f613cec0a0967ccb748b7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-10don't use common PCH with sc_parallelism testLuboš Luňák
Otherwise it duplicates the precompiled_system.o object, the second copy brought in by libscqahelper, making Clang LTO build fail. Change-Id: Ic6827b0745e134ab327ad18fc212ca31084ff579 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123327 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-10Typo: CT_SytemColor_lastClr->CT_SystemColor_lastClrJulien Nabet
Change-Id: I10ebe939562097d3fc098a42c09b1e0f6e5cbd6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123315 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-10tdf#144757 - fixed fonts not shown in font listChris Sherlock
When in font options, the Fonts in "Font Setting for HTML, Basic and SQL Sources" were not showing any fixed (non-proportional) fonts in the list when "Non-proportional fonts only" was ticked. The reason this was occuring was because we were not populating the fixed font attribute when getting the CT font descriptor. Change-Id: I06127ac48bd0f3bc9b70217b36bbf584a1b0fdc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123316 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-10-09Rename bookmrk* -> bookmark*Julien Nabet
Change-Id: I9dec77b2af8abe5abb286ff76ed85d1e4078ee6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123325 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2024-07-15 10:05:49 +0000