Age | Commit message (Collapse) | Author |
|
Change-Id: I7ac2662afe77e6e9170b004b335635f97ae03692
Reviewed-on: https://gerrit.libreoffice.org/62184
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I03fe3f70ee97066d9c2083d4ef091c501f241392
|
|
There is no guarantee that if something is wrong, the
Application::ShowNativeErrorBox() will manage to show anything, is
there? And this code might be invoked in a program that doesn't even
have any GUI. So at least try to show the message on stderr, too.
Change-Id: Ieb11a6f490c26c773af646ed7e9c3cf6ccb4a669
|
|
Change-Id: I31b2717e60b5eae6c992e27700e589938764957c
Reviewed-on: https://gerrit.libreoffice.org/62035
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
Create B2DPolygon with ::basegfx::utils::createWaveline
to render the waveline. Parameters are adapted from
the drawinglayer. Thickness of the line isn't really
implemented yet.
Change-Id: I74d05744632d5d54e439a2a3e144fa2daf4ae1bb
Reviewed-on: https://gerrit.libreoffice.org/61947
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
Change-Id: Ie3fa48a6ff5cf602b1cd661e3e4053a001a4470f
Reviewed-on: https://gerrit.libreoffice.org/62083
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
Change-Id: I7972ef73b8c11ae78569fa1c7dc0a244ebba3f30
Reviewed-on: https://gerrit.libreoffice.org/62181
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Icf48d2d0422dc4e757627001e4792b45208054ab
|
|
and all other sw modules
Change-Id: Ifd7161f58170f32555134250b91e537eeada3c99
Reviewed-on: https://gerrit.libreoffice.org/61988
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Coincidentally, remove unwarranted addition of one hour
Added unit test dbaccess_tdf119625
Change-Id: I84a47c7abd4ab8e2c80d3faaf8cf4f11e1b81df3
Reviewed-on: https://gerrit.libreoffice.org/60048
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Tested-by: Tamás Bunth <btomi96@gmail.com>
|
|
* Update helpcontent2 from branch 'master'
- Missing space between words.
Change-Id: I5731c2c00ee45d949182d17dfbebe94fa1c00be4
Reviewed-on: https://gerrit.libreoffice.org/62178
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I565506d58f2dd94a6c2c5e1c4a2000ce1f9752cf
Reviewed-on: https://gerrit.libreoffice.org/61445
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
https://docs.microsoft.com/en-us/windows/desktop/api/objidl/nf-objidl-irunnableobject-isrunning
has IRunnableObject::IsRunning as returning BOOL unlike ::Run which returns HRESULT
Change-Id: I992d8ba33502eff56b582e1cb9b73f6227c383b8
Reviewed-on: https://gerrit.libreoffice.org/62169
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
It can be used to test the mysqlc connector whenever there is an
external mysql or mariadb server running.
The test runs only when CONNECTIVITY_TEST_MYSQL_DRIVER environment variable
is set. This variable should contain the URL of the database, including
the port number and the host name.
The URL should also contain a user name password pair which can be used
to connect to the external database. The URL format is the following:
[user]/[passwd]@sdbc:mysql:mysqlc:[host]:[port]/[db_name]
README is updated and contains detailed information about the test.
Change-Id: I1bbc9369ff193a29c06de63a0f6cc975877c8da3
Reviewed-on: https://gerrit.libreoffice.org/62171
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
|
|
Change-Id: I2bd26bcad94aa905f0c87d92b43561855409e330
|
|
(it nicely prints exceptions' messages, too)
Change-Id: I66bb4fd856d0249a7dc5bc58975b6ea322f9a9ca
Reviewed-on: https://gerrit.libreoffice.org/62165
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ibdc0f75b18330b77e18293f7485e165d2133290e
Reviewed-on: https://gerrit.libreoffice.org/62179
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
produces false positive
> [CXX] svtools/source/svrtf/rtfkeywd.cxx
> /home/sbergman/lo/core/svtools/source/svrtf/rtfkeywd.cxx:38:23: error: var should be const, or whitelisted [loplugin:staticvar]
> static RTF_TokenEntry aRTFTokenTab[] = {
> ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
Change-Id: I7cd96988218d1192ced2fadff911c7ec89088012
|
|
V668 There is no sense in testing the 'pMed' pointer against null, as the memory
was allocated using the 'new' operator. The exception will be generated in
the case of memory allocation error.
Change-Id: Ia630fd30d86e9b8f9ce85077edbd949274bbee70
Reviewed-on: https://gerrit.libreoffice.org/62125
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Id11b8fdc91e552a38a78f13df410f4d364e7acbf
Reviewed-on: https://gerrit.libreoffice.org/62170
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
and all the other sw modules
Change-Id: Ie407f858bf1d17f3af4c2948fcd4cb40bc9e8c92
Reviewed-on: https://gerrit.libreoffice.org/61963
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
similar layout to graphic
Change-Id: Id97460cdeb1db62326b7cb2e7655a39af2c1ae99
Reviewed-on: https://gerrit.libreoffice.org/61962
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
Change-Id: Ib0bb557a2a98d8256182aab29b98b953ffc9c7a4
Reviewed-on: https://gerrit.libreoffice.org/62172
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Follow-up on f7982d4dfa85f15a6f0c25e9795a5847ecfcbf31
Change-Id: I2defd3474fdbb0b87898df7734bb076ab95c8c08
Reviewed-on: https://gerrit.libreoffice.org/61950
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: Ic0e5e113ff16dbb3fb246c52f5a2fee8d9f52304
|
|
Change-Id: I303b4db52e852011d45a147f3010a8f934c1f77b
Reviewed-on: https://gerrit.libreoffice.org/62167
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Splash screen text should be black now
Change-Id: I963ffc89c48fdc1de148586cd6f0fb4bf35d44bd
Reviewed-on: https://gerrit.libreoffice.org/61924
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
Item moved above Templates...
Change-Id: I813544bbfb76c34dd3e73daf87d8d5ea1478240b
Reviewed-on: https://gerrit.libreoffice.org/61787
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
Change-Id: Ia443a0e61a091d877c8da26bf7d45bf4261f8669
Reviewed-on: https://gerrit.libreoffice.org/62166
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
treat fields touched in operator== as not being important, which
finds some more stuff (but also adds some false+)
Change-Id: I3f5d504d7dec7945a917afbcd58c92df74f03645
Reviewed-on: https://gerrit.libreoffice.org/62020
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
looks for variables that can be declared const and static i.e. they can
be stored in the read-only linker segment and shared between different
processes
Change-Id: I8ddc6e5fa0f6b10d80c75d5952df8ddd311cf892
Reviewed-on: https://gerrit.libreoffice.org/61591
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
category V668 complete
Change-Id: I986d4cb89a7c72d54d71ea01fc598a9958deee24
Reviewed-on: https://gerrit.libreoffice.org/62138
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
V571 The '!aDelData.isDeleted()' condition was already verified in line 359.
Change-Id: Ie66aa65c024e30d34a4b0766ddad3fa24ce98644
Reviewed-on: https://gerrit.libreoffice.org/62163
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
for...
"The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression"
subcases, where the args are already bool
Change-Id: Ica8b5c4974c513f7f7ad8acf17ca931e85ebc8af
Reviewed-on: https://gerrit.libreoffice.org/62146
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I2ac33db8d265f1af1c8fc8def2d3a45c5be37741
Reviewed-on: https://gerrit.libreoffice.org/62154
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
V571 The 'pNew' condition was already verified in line 47.
Change-Id: Ib6b6a48f8c565ee28bbbaa8846f549639b6291be
Reviewed-on: https://gerrit.libreoffice.org/62159
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Change-Id: Ida759ae9fce3d384b19e41683bdcd796eb158efe
Reviewed-on: https://gerrit.libreoffice.org/62147
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
V560 A part of conditional expression is always true: (nHintStart >= nStartIdx)
V509 The 'dynamic_cast' operator should be located inside the try..catch block,
as it could potentially generate an exception. Raising exception inside
the destructor is illegal.
V560 A part of conditional expression is always true: pHint.
Change-Id: Icfb9a2961f5db034fd19f4665fe3ceaae6232350
Reviewed-on: https://gerrit.libreoffice.org/62039
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Change-Id: I5ba0504265f5692614a8db0117883528bd4bfc0b
Reviewed-on: https://gerrit.libreoffice.org/62000
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
|
|
Follow-up of commit f4103a42d58535e21c48ff94ab000ab0305c62e3
Change-Id: I4562386d3151875dff8e9eddf31c4af3333cefb7
Reviewed-on: https://gerrit.libreoffice.org/61245
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
and final tab review
Change-Id: Ia91398f65486f09fccce19b3b1a568f96844cd24
Reviewed-on: https://gerrit.libreoffice.org/62164
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
V571 The 'pArgs' condition was already verified in line 47.
Change-Id: Id63eb556610ec457864e44b7d3f49e46f133e5a9
Reviewed-on: https://gerrit.libreoffice.org/62162
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
V571 The 'SwKeyState::KeyToView != eFlyState' condition was already verified in line 1723.
Change-Id: I4fb5d7a5e50822985ca753706d4cdb1693439118
Reviewed-on: https://gerrit.libreoffice.org/62161
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
V571 The '!pNumRule' condition was already verified in line 2092.
Change-Id: I2fc040e9c3053b351b99eb123285ef05f20813f5
Reviewed-on: https://gerrit.libreoffice.org/62160
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
V571 The 'pColumn->GetWidthOption()' condition was already verified in line 1033.
Change-Id: I5bc11bceddc8090f41bf86b45f880ceea3dfb204
Reviewed-on: https://gerrit.libreoffice.org/62158
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
V571 The 'mpView' condition was already verified in line 417.
Change-Id: I64d522412f1f627ab04a29f90b33177ef726eb58
Reviewed-on: https://gerrit.libreoffice.org/62157
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
V571 The 'bOk' condition was already verified in line 1553.
Change-Id: I19a30071ebfc1937d03f2fdfcbfc12017e3e835e
Reviewed-on: https://gerrit.libreoffice.org/62156
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
V571 The 'mpViewShell' condition was already verified in line 887.
Change-Id: I90e8beee2f66936122824e403ae82aebceb3adc4
Reviewed-on: https://gerrit.libreoffice.org/62155
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Use range-based loop or replace with STL functions.
Change-Id: I3cdb0f89523008199af1550de164a52b75c52ba5
Reviewed-on: https://gerrit.libreoffice.org/62088
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
There are cases where the extension registration becomes invalid
(empty rdb files) which leads to extensions not starting up,
although installed and active.
Syncing extension repos on startup fixes that.
The performance impact is negligible (1ms in my measurements).
Change-Id: I10475ce6a054b43c4591b17a8486648ca6a30068
Reviewed-on: https://gerrit.libreoffice.org/61943
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|